* drivers/scsi/53c700.c:2063:8-16: WARNING: use scnprintf or sprintf
@ 2020-09-10 8:53 kernel test robot
2020-09-10 8:53 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: kernel test robot @ 2020-09-10 8:53 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 3537 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Denis Efremov <efremov@linux.com>
CC: Julia Lawall <Julia.Lawall@lip6.fr>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 7fe10096c1508c7f033d34d0741809f8eecc1ed4
commit: abfc19ff202d287742483e15fd478ddd6ada2187 coccinelle: api: add device_attr_show script
date: 5 weeks ago
:::::: branch date: 6 hours ago
:::::: commit date: 5 weeks ago
config: x86_64-randconfig-c002-20200909 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
coccinelle warnings: (new ones prefixed by >>)
>> drivers/scsi/53c700.c:2063:8-16: WARNING: use scnprintf or sprintf
--
>> drivers/acpi/dock.c:563:8-16: WARNING: use scnprintf or sprintf
drivers/acpi/dock.c:544:8-16: WARNING: use scnprintf or sprintf
drivers/acpi/dock.c:495:8-16: WARNING: use scnprintf or sprintf
drivers/acpi/dock.c:506:8-16: WARNING: use scnprintf or sprintf
--
>> drivers/ide/ide-park.c:112:8-16: WARNING: use scnprintf or sprintf
--
>> drivers/platform/x86/lg-laptop.c:496:8-16: WARNING: use scnprintf or sprintf
drivers/platform/x86/lg-laptop.c:322:8-16: WARNING: use scnprintf or sprintf
drivers/platform/x86/lg-laptop.c:447:8-16: WARNING: use scnprintf or sprintf
drivers/platform/x86/lg-laptop.c:406:8-16: WARNING: use scnprintf or sprintf
drivers/platform/x86/lg-laptop.c:364:8-16: WARNING: use scnprintf or sprintf
--
>> drivers/platform/x86/panasonic-laptop.c:371:8-16: WARNING: use scnprintf or sprintf
drivers/platform/x86/panasonic-laptop.c:383:8-16: WARNING: use scnprintf or sprintf
drivers/platform/x86/panasonic-laptop.c:359:8-16: WARNING: use scnprintf or sprintf
drivers/platform/x86/panasonic-laptop.c:395:8-16: WARNING: use scnprintf or sprintf
--
>> drivers/hwmon/sch5636.c:275:8-16: WARNING: use scnprintf or sprintf
drivers/hwmon/sch5636.c:261:8-16: WARNING: use scnprintf or sprintf
drivers/hwmon/sch5636.c:247:8-16: WARNING: use scnprintf or sprintf
drivers/hwmon/sch5636.c:187:8-16: WARNING: use scnprintf or sprintf
drivers/hwmon/sch5636.c:179:8-16: WARNING: use scnprintf or sprintf
drivers/hwmon/sch5636.c:163:8-16: WARNING: use scnprintf or sprintf
drivers/hwmon/sch5636.c:230:8-16: WARNING: use scnprintf or sprintf
drivers/hwmon/sch5636.c:216:8-16: WARNING: use scnprintf or sprintf
drivers/hwmon/sch5636.c:202:8-16: WARNING: use scnprintf or sprintf
--
>> drivers/scsi/scsi_transport_fc.c:1557:9-17: WARNING: use scnprintf or sprintf
drivers/scsi/scsi_transport_fc.c:1481:9-17: WARNING: use scnprintf or sprintf
drivers/scsi/scsi_transport_fc.c:1505:9-17: WARNING: use scnprintf or sprintf
drivers/scsi/scsi_transport_fc.c:1590:8-16: WARNING: use scnprintf or sprintf
drivers/scsi/scsi_transport_fc.c:955:9-17: WARNING: use scnprintf or sprintf
drivers/scsi/scsi_transport_fc.c:921:10-18: WARNING: use scnprintf or sprintf
drivers/scsi/scsi_transport_fc.c:826:9-17: WARNING: use scnprintf or sprintf
drivers/scsi/scsi_transport_fc.c:1255:9-17: WARNING: use scnprintf or sprintf
--
>> net/netfilter/xt_IDLETIMER.c:88:9-17: WARNING: use scnprintf or sprintf
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 38457 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] coccinelle: api: fix device_attr_show.cocci warnings
2020-09-10 8:53 drivers/scsi/53c700.c:2063:8-16: WARNING: use scnprintf or sprintf kernel test robot
@ 2020-09-10 8:53 ` kernel test robot
2020-09-10 8:53 ` kernel test robot
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: kernel test robot @ 2020-09-10 8:53 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1747 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Denis Efremov <efremov@linux.com>
CC: Julia Lawall <Julia.Lawall@lip6.fr>
CC: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
CC: "Martin K. Petersen" <martin.petersen@oracle.com>
CC: linux-scsi(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org
From: kernel test robot <lkp@intel.com>
drivers/scsi/53c700.c:2063:8-16: WARNING: use scnprintf or sprintf
From Documentation/filesystems/sysfs.txt:
show() must not use snprintf() when formatting the value to be
returned to user space. If you can guarantee that an overflow
will never happen you can use sprintf() otherwise you must use
scnprintf().
Generated by: scripts/coccinelle/api/device_attr_show.cocci
Fixes: abfc19ff202d ("coccinelle: api: add device_attr_show script")
CC: Denis Efremov <efremov@linux.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 7fe10096c1508c7f033d34d0741809f8eecc1ed4
commit: abfc19ff202d287742483e15fd478ddd6ada2187 coccinelle: api: add device_attr_show script
:::::: branch date: 6 hours ago
:::::: commit date: 5 weeks ago
Please take the patch only if it's a positive warning. Thanks!
53c700.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/scsi/53c700.c
+++ b/drivers/scsi/53c700.c
@@ -2060,7 +2060,7 @@ NCR_700_show_active_tags(struct device *
{
struct scsi_device *SDp = to_scsi_device(dev);
- return snprintf(buf, 20, "%d\n", NCR_700_get_depth(SDp));
+ return scnprintf(buf, 20, "%d\n", NCR_700_get_depth(SDp));
}
static struct device_attribute NCR_700_active_tags_attr = {
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] coccinelle: api: fix device_attr_show.cocci warnings
2020-09-10 8:53 drivers/scsi/53c700.c:2063:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-09-10 8:53 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
@ 2020-09-10 8:53 ` kernel test robot
2020-09-10 8:53 ` kernel test robot
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: kernel test robot @ 2020-09-10 8:53 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 2860 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Denis Efremov <efremov@linux.com>
CC: Julia Lawall <Julia.Lawall@lip6.fr>
CC: "Rafael J. Wysocki" <rjw@rjwysocki.net>
CC: Len Brown <lenb@kernel.org>
CC: linux-acpi(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org
From: kernel test robot <lkp@intel.com>
drivers/acpi/dock.c:563:8-16: WARNING: use scnprintf or sprintf
drivers/acpi/dock.c:544:8-16: WARNING: use scnprintf or sprintf
drivers/acpi/dock.c:495:8-16: WARNING: use scnprintf or sprintf
drivers/acpi/dock.c:506:8-16: WARNING: use scnprintf or sprintf
From Documentation/filesystems/sysfs.txt:
show() must not use snprintf() when formatting the value to be
returned to user space. If you can guarantee that an overflow
will never happen you can use sprintf() otherwise you must use
scnprintf().
Generated by: scripts/coccinelle/api/device_attr_show.cocci
Fixes: abfc19ff202d ("coccinelle: api: add device_attr_show script")
CC: Denis Efremov <efremov@linux.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 7fe10096c1508c7f033d34d0741809f8eecc1ed4
commit: abfc19ff202d287742483e15fd478ddd6ada2187 coccinelle: api: add device_attr_show script
:::::: branch date: 6 hours ago
:::::: commit date: 5 weeks ago
Please take the patch only if it's a positive warning. Thanks!
dock.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--- a/drivers/acpi/dock.c
+++ b/drivers/acpi/dock.c
@@ -492,7 +492,7 @@ static ssize_t show_docked(struct device
struct acpi_device *adev = NULL;
acpi_bus_get_device(dock_station->handle, &adev);
- return snprintf(buf, PAGE_SIZE, "%u\n", acpi_device_enumerated(adev));
+ return scnprintf(buf, PAGE_SIZE, "%u\n", acpi_device_enumerated(adev));
}
static DEVICE_ATTR(docked, S_IRUGO, show_docked, NULL);
@@ -503,7 +503,7 @@ static ssize_t show_flags(struct device
struct device_attribute *attr, char *buf)
{
struct dock_station *dock_station = dev->platform_data;
- return snprintf(buf, PAGE_SIZE, "%d\n", dock_station->flags);
+ return scnprintf(buf, PAGE_SIZE, "%d\n", dock_station->flags);
}
static DEVICE_ATTR(flags, S_IRUGO, show_flags, NULL);
@@ -541,7 +541,7 @@ static ssize_t show_dock_uid(struct devi
if (ACPI_FAILURE(status))
return 0;
- return snprintf(buf, PAGE_SIZE, "%llx\n", lbuf);
+ return scnprintf(buf, PAGE_SIZE, "%llx\n", lbuf);
}
static DEVICE_ATTR(uid, S_IRUGO, show_dock_uid, NULL);
@@ -560,7 +560,7 @@ static ssize_t show_dock_type(struct dev
else
type = "unknown";
- return snprintf(buf, PAGE_SIZE, "%s\n", type);
+ return scnprintf(buf, PAGE_SIZE, "%s\n", type);
}
static DEVICE_ATTR(type, S_IRUGO, show_dock_type, NULL);
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] coccinelle: api: fix device_attr_show.cocci warnings
2020-09-10 8:53 drivers/scsi/53c700.c:2063:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-09-10 8:53 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-09-10 8:53 ` kernel test robot
@ 2020-09-10 8:53 ` kernel test robot
2020-09-10 8:53 ` kernel test robot
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: kernel test robot @ 2020-09-10 8:53 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1599 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Denis Efremov <efremov@linux.com>
CC: Julia Lawall <Julia.Lawall@lip6.fr>
CC: linux-ide(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org
From: kernel test robot <lkp@intel.com>
drivers/ide/ide-park.c:112:8-16: WARNING: use scnprintf or sprintf
From Documentation/filesystems/sysfs.txt:
show() must not use snprintf() when formatting the value to be
returned to user space. If you can guarantee that an overflow
will never happen you can use sprintf() otherwise you must use
scnprintf().
Generated by: scripts/coccinelle/api/device_attr_show.cocci
Fixes: abfc19ff202d ("coccinelle: api: add device_attr_show script")
CC: Denis Efremov <efremov@linux.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 7fe10096c1508c7f033d34d0741809f8eecc1ed4
commit: abfc19ff202d287742483e15fd478ddd6ada2187 coccinelle: api: add device_attr_show script
:::::: branch date: 6 hours ago
:::::: commit date: 5 weeks ago
Please take the patch only if it's a positive warning. Thanks!
ide-park.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/ide/ide-park.c
+++ b/drivers/ide/ide-park.c
@@ -109,7 +109,7 @@ ssize_t ide_park_show(struct device *dev
msecs = 0;
spin_unlock_irq(&hwif->lock);
- return snprintf(buf, 20, "%u\n", msecs);
+ return scnprintf(buf, 20, "%u\n", msecs);
}
ssize_t ide_park_store(struct device *dev, struct device_attribute *attr,
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] coccinelle: api: fix device_attr_show.cocci warnings
2020-09-10 8:53 drivers/scsi/53c700.c:2063:8-16: WARNING: use scnprintf or sprintf kernel test robot
` (2 preceding siblings ...)
2020-09-10 8:53 ` kernel test robot
@ 2020-09-10 8:53 ` kernel test robot
2020-09-10 8:53 ` kernel test robot
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: kernel test robot @ 2020-09-10 8:53 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 3156 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Denis Efremov <efremov@linux.com>
CC: Julia Lawall <Julia.Lawall@lip6.fr>
CC: "Matan Ziv-Av" <matan@svgalib.org>
CC: Darren Hart <dvhart@infradead.org>
CC: Andy Shevchenko <andy@infradead.org>
CC: platform-driver-x86(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org
From: kernel test robot <lkp@intel.com>
drivers/platform/x86/lg-laptop.c:496:8-16: WARNING: use scnprintf or sprintf
drivers/platform/x86/lg-laptop.c:322:8-16: WARNING: use scnprintf or sprintf
drivers/platform/x86/lg-laptop.c:447:8-16: WARNING: use scnprintf or sprintf
drivers/platform/x86/lg-laptop.c:406:8-16: WARNING: use scnprintf or sprintf
drivers/platform/x86/lg-laptop.c:364:8-16: WARNING: use scnprintf or sprintf
From Documentation/filesystems/sysfs.txt:
show() must not use snprintf() when formatting the value to be
returned to user space. If you can guarantee that an overflow
will never happen you can use sprintf() otherwise you must use
scnprintf().
Generated by: scripts/coccinelle/api/device_attr_show.cocci
Fixes: abfc19ff202d ("coccinelle: api: add device_attr_show script")
CC: Denis Efremov <efremov@linux.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 7fe10096c1508c7f033d34d0741809f8eecc1ed4
commit: abfc19ff202d287742483e15fd478ddd6ada2187 coccinelle: api: add device_attr_show script
:::::: branch date: 6 hours ago
:::::: commit date: 5 weeks ago
Please take the patch only if it's a positive warning. Thanks!
lg-laptop.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
--- a/drivers/platform/x86/lg-laptop.c
+++ b/drivers/platform/x86/lg-laptop.c
@@ -319,7 +319,7 @@ static ssize_t fan_mode_show(struct devi
status = r->integer.value & 0x01;
kfree(r);
- return snprintf(buffer, PAGE_SIZE, "%d\n", status);
+ return scnprintf(buffer, PAGE_SIZE, "%d\n", status);
}
static ssize_t usb_charge_store(struct device *dev,
@@ -361,7 +361,7 @@ static ssize_t usb_charge_show(struct de
kfree(r);
- return snprintf(buffer, PAGE_SIZE, "%d\n", status);
+ return scnprintf(buffer, PAGE_SIZE, "%d\n", status);
}
static ssize_t reader_mode_store(struct device *dev,
@@ -403,7 +403,7 @@ static ssize_t reader_mode_show(struct d
kfree(r);
- return snprintf(buffer, PAGE_SIZE, "%d\n", status);
+ return scnprintf(buffer, PAGE_SIZE, "%d\n", status);
}
static ssize_t fn_lock_store(struct device *dev,
@@ -444,7 +444,7 @@ static ssize_t fn_lock_show(struct devic
status = !!r->buffer.pointer[0];
kfree(r);
- return snprintf(buffer, PAGE_SIZE, "%d\n", status);
+ return scnprintf(buffer, PAGE_SIZE, "%d\n", status);
}
static ssize_t battery_care_limit_store(struct device *dev,
@@ -493,7 +493,7 @@ static ssize_t battery_care_limit_show(s
if (status != 80 && status != 100)
status = 0;
- return snprintf(buffer, PAGE_SIZE, "%d\n", status);
+ return scnprintf(buffer, PAGE_SIZE, "%d\n", status);
}
static DEVICE_ATTR_RW(fan_mode);
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] coccinelle: api: fix device_attr_show.cocci warnings
2020-09-10 8:53 drivers/scsi/53c700.c:2063:8-16: WARNING: use scnprintf or sprintf kernel test robot
` (3 preceding siblings ...)
2020-09-10 8:53 ` kernel test robot
@ 2020-09-10 8:53 ` kernel test robot
2020-09-10 8:53 ` kernel test robot
2020-09-10 8:53 ` kernel test robot
6 siblings, 0 replies; 8+ messages in thread
From: kernel test robot @ 2020-09-10 8:53 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 3177 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Denis Efremov <efremov@linux.com>
CC: Julia Lawall <Julia.Lawall@lip6.fr>
CC: Harald Welte <laforge@gnumonks.org>
CC: Darren Hart <dvhart@infradead.org>
CC: Andy Shevchenko <andy@infradead.org>
CC: platform-driver-x86(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org
From: kernel test robot <lkp@intel.com>
drivers/platform/x86/panasonic-laptop.c:371:8-16: WARNING: use scnprintf or sprintf
drivers/platform/x86/panasonic-laptop.c:383:8-16: WARNING: use scnprintf or sprintf
drivers/platform/x86/panasonic-laptop.c:359:8-16: WARNING: use scnprintf or sprintf
drivers/platform/x86/panasonic-laptop.c:395:8-16: WARNING: use scnprintf or sprintf
From Documentation/filesystems/sysfs.txt:
show() must not use snprintf() when formatting the value to be
returned to user space. If you can guarantee that an overflow
will never happen you can use sprintf() otherwise you must use
scnprintf().
Generated by: scripts/coccinelle/api/device_attr_show.cocci
Fixes: abfc19ff202d ("coccinelle: api: add device_attr_show script")
CC: Denis Efremov <efremov@linux.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 7fe10096c1508c7f033d34d0741809f8eecc1ed4
commit: abfc19ff202d287742483e15fd478ddd6ada2187 coccinelle: api: add device_attr_show script
:::::: branch date: 6 hours ago
:::::: commit date: 5 weeks ago
Please take the patch only if it's a positive warning. Thanks!
panasonic-laptop.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--- a/drivers/platform/x86/panasonic-laptop.c
+++ b/drivers/platform/x86/panasonic-laptop.c
@@ -356,7 +356,7 @@ static ssize_t show_numbatt(struct devic
if (!acpi_pcc_retrieve_biosdata(pcc))
return -EIO;
- return snprintf(buf, PAGE_SIZE, "%u\n", pcc->sinf[SINF_NUM_BATTERIES]);
+ return scnprintf(buf, PAGE_SIZE, "%u\n", pcc->sinf[SINF_NUM_BATTERIES]);
}
static ssize_t show_lcdtype(struct device *dev, struct device_attribute *attr,
@@ -368,7 +368,7 @@ static ssize_t show_lcdtype(struct devic
if (!acpi_pcc_retrieve_biosdata(pcc))
return -EIO;
- return snprintf(buf, PAGE_SIZE, "%u\n", pcc->sinf[SINF_LCD_TYPE]);
+ return scnprintf(buf, PAGE_SIZE, "%u\n", pcc->sinf[SINF_LCD_TYPE]);
}
static ssize_t show_mute(struct device *dev, struct device_attribute *attr,
@@ -380,7 +380,7 @@ static ssize_t show_mute(struct device *
if (!acpi_pcc_retrieve_biosdata(pcc))
return -EIO;
- return snprintf(buf, PAGE_SIZE, "%u\n", pcc->sinf[SINF_MUTE]);
+ return scnprintf(buf, PAGE_SIZE, "%u\n", pcc->sinf[SINF_MUTE]);
}
static ssize_t show_sticky(struct device *dev, struct device_attribute *attr,
@@ -392,7 +392,7 @@ static ssize_t show_sticky(struct device
if (!acpi_pcc_retrieve_biosdata(pcc))
return -EIO;
- return snprintf(buf, PAGE_SIZE, "%u\n", pcc->sinf[SINF_STICKY_KEY]);
+ return scnprintf(buf, PAGE_SIZE, "%u\n", pcc->sinf[SINF_STICKY_KEY]);
}
static ssize_t set_sticky(struct device *dev, struct device_attribute *attr,
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] coccinelle: api: fix device_attr_show.cocci warnings
2020-09-10 8:53 drivers/scsi/53c700.c:2063:8-16: WARNING: use scnprintf or sprintf kernel test robot
` (4 preceding siblings ...)
2020-09-10 8:53 ` kernel test robot
@ 2020-09-10 8:53 ` kernel test robot
2020-09-10 8:53 ` kernel test robot
6 siblings, 0 replies; 8+ messages in thread
From: kernel test robot @ 2020-09-10 8:53 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 4724 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Denis Efremov <efremov@linux.com>
CC: Julia Lawall <Julia.Lawall@lip6.fr>
CC: Jean Delvare <jdelvare@suse.com>
CC: Guenter Roeck <linux@roeck-us.net>
CC: linux-hwmon(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org
From: kernel test robot <lkp@intel.com>
drivers/hwmon/sch5636.c:275:8-16: WARNING: use scnprintf or sprintf
drivers/hwmon/sch5636.c:261:8-16: WARNING: use scnprintf or sprintf
drivers/hwmon/sch5636.c:247:8-16: WARNING: use scnprintf or sprintf
drivers/hwmon/sch5636.c:187:8-16: WARNING: use scnprintf or sprintf
drivers/hwmon/sch5636.c:179:8-16: WARNING: use scnprintf or sprintf
drivers/hwmon/sch5636.c:163:8-16: WARNING: use scnprintf or sprintf
drivers/hwmon/sch5636.c:230:8-16: WARNING: use scnprintf or sprintf
drivers/hwmon/sch5636.c:216:8-16: WARNING: use scnprintf or sprintf
drivers/hwmon/sch5636.c:202:8-16: WARNING: use scnprintf or sprintf
From Documentation/filesystems/sysfs.txt:
show() must not use snprintf() when formatting the value to be
returned to user space. If you can guarantee that an overflow
will never happen you can use sprintf() otherwise you must use
scnprintf().
Generated by: scripts/coccinelle/api/device_attr_show.cocci
Fixes: abfc19ff202d ("coccinelle: api: add device_attr_show script")
CC: Denis Efremov <efremov@linux.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 7fe10096c1508c7f033d34d0741809f8eecc1ed4
commit: abfc19ff202d287742483e15fd478ddd6ada2187 coccinelle: api: add device_attr_show script
:::::: branch date: 6 hours ago
:::::: commit date: 5 weeks ago
Please take the patch only if it's a positive warning. Thanks!
sch5636.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
--- a/drivers/hwmon/sch5636.c
+++ b/drivers/hwmon/sch5636.c
@@ -160,7 +160,7 @@ static int reg_to_rpm(u16 reg)
static ssize_t name_show(struct device *dev, struct device_attribute *devattr,
char *buf)
{
- return snprintf(buf, PAGE_SIZE, "%s\n", DEVNAME);
+ return scnprintf(buf, PAGE_SIZE, "%s\n", DEVNAME);
}
static ssize_t in_value_show(struct device *dev,
@@ -176,7 +176,7 @@ static ssize_t in_value_show(struct devi
val = DIV_ROUND_CLOSEST(
data->in[attr->index] * SCH5636_REG_IN_FACTORS[attr->index],
255);
- return snprintf(buf, PAGE_SIZE, "%d\n", val);
+ return scnprintf(buf, PAGE_SIZE, "%d\n", val);
}
static ssize_t in_label_show(struct device *dev,
@@ -184,7 +184,7 @@ static ssize_t in_label_show(struct devi
{
struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
- return snprintf(buf, PAGE_SIZE, "%s\n",
+ return scnprintf(buf, PAGE_SIZE, "%s\n",
SCH5636_IN_LABELS[attr->index]);
}
@@ -199,7 +199,7 @@ static ssize_t temp_value_show(struct de
return PTR_ERR(data);
val = (data->temp_val[attr->index] - 64) * 1000;
- return snprintf(buf, PAGE_SIZE, "%d\n", val);
+ return scnprintf(buf, PAGE_SIZE, "%d\n", val);
}
static ssize_t temp_fault_show(struct device *dev,
@@ -213,7 +213,7 @@ static ssize_t temp_fault_show(struct de
return PTR_ERR(data);
val = (data->temp_ctrl[attr->index] & SCH5636_TEMP_WORKING) ? 0 : 1;
- return snprintf(buf, PAGE_SIZE, "%d\n", val);
+ return scnprintf(buf, PAGE_SIZE, "%d\n", val);
}
static ssize_t temp_alarm_show(struct device *dev,
@@ -227,7 +227,7 @@ static ssize_t temp_alarm_show(struct de
return PTR_ERR(data);
val = (data->temp_ctrl[attr->index] & SCH5636_TEMP_ALARM) ? 1 : 0;
- return snprintf(buf, PAGE_SIZE, "%d\n", val);
+ return scnprintf(buf, PAGE_SIZE, "%d\n", val);
}
static ssize_t fan_value_show(struct device *dev,
@@ -244,7 +244,7 @@ static ssize_t fan_value_show(struct dev
if (val < 0)
return val;
- return snprintf(buf, PAGE_SIZE, "%d\n", val);
+ return scnprintf(buf, PAGE_SIZE, "%d\n", val);
}
static ssize_t fan_fault_show(struct device *dev,
@@ -258,7 +258,7 @@ static ssize_t fan_fault_show(struct dev
return PTR_ERR(data);
val = (data->fan_ctrl[attr->index] & SCH5636_FAN_NOT_PRESENT) ? 1 : 0;
- return snprintf(buf, PAGE_SIZE, "%d\n", val);
+ return scnprintf(buf, PAGE_SIZE, "%d\n", val);
}
static ssize_t fan_alarm_show(struct device *dev,
@@ -272,7 +272,7 @@ static ssize_t fan_alarm_show(struct dev
return PTR_ERR(data);
val = (data->fan_ctrl[attr->index] & SCH5636_FAN_ALARM) ? 1 : 0;
- return snprintf(buf, PAGE_SIZE, "%d\n", val);
+ return scnprintf(buf, PAGE_SIZE, "%d\n", val);
}
static struct sensor_device_attribute sch5636_attr[] = {
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] coccinelle: api: fix device_attr_show.cocci warnings
2020-09-10 8:53 drivers/scsi/53c700.c:2063:8-16: WARNING: use scnprintf or sprintf kernel test robot
` (5 preceding siblings ...)
2020-09-10 8:53 ` kernel test robot
@ 2020-09-10 8:53 ` kernel test robot
6 siblings, 0 replies; 8+ messages in thread
From: kernel test robot @ 2020-09-10 8:53 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1993 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Denis Efremov <efremov@linux.com>
CC: Julia Lawall <Julia.Lawall@lip6.fr>
CC: Pablo Neira Ayuso <pablo@netfilter.org>
CC: Jozsef Kadlecsik <kadlec@netfilter.org>
CC: Florian Westphal <fw@strlen.de>
CC: Jakub Kicinski <kuba@kernel.org>
CC: netfilter-devel(a)vger.kernel.org
CC: coreteam(a)netfilter.org
CC: netdev(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org
From: kernel test robot <lkp@intel.com>
net/netfilter/xt_IDLETIMER.c:88:9-17: WARNING: use scnprintf or sprintf
From Documentation/filesystems/sysfs.txt:
show() must not use snprintf() when formatting the value to be
returned to user space. If you can guarantee that an overflow
will never happen you can use sprintf() otherwise you must use
scnprintf().
Generated by: scripts/coccinelle/api/device_attr_show.cocci
Fixes: abfc19ff202d ("coccinelle: api: add device_attr_show script")
CC: Denis Efremov <efremov@linux.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 7fe10096c1508c7f033d34d0741809f8eecc1ed4
commit: abfc19ff202d287742483e15fd478ddd6ada2187 coccinelle: api: add device_attr_show script
:::::: branch date: 6 hours ago
:::::: commit date: 5 weeks ago
Please take the patch only if it's a positive warning. Thanks!
xt_IDLETIMER.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/net/netfilter/xt_IDLETIMER.c
+++ b/net/netfilter/xt_IDLETIMER.c
@@ -85,9 +85,9 @@ static ssize_t idletimer_tg_show(struct
mutex_unlock(&list_mutex);
if (time_after(expires, jiffies) || ktimespec.tv_sec > 0)
- return snprintf(buf, PAGE_SIZE, "%ld\n", time_diff);
+ return scnprintf(buf, PAGE_SIZE, "%ld\n", time_diff);
- return snprintf(buf, PAGE_SIZE, "0\n");
+ return scnprintf(buf, PAGE_SIZE, "0\n");
}
static void idletimer_tg_work(struct work_struct *work)
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-09-10 8:53 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-10 8:53 drivers/scsi/53c700.c:2063:8-16: WARNING: use scnprintf or sprintf kernel test robot
2020-09-10 8:53 ` [PATCH] coccinelle: api: fix device_attr_show.cocci warnings kernel test robot
2020-09-10 8:53 ` kernel test robot
2020-09-10 8:53 ` kernel test robot
2020-09-10 8:53 ` kernel test robot
2020-09-10 8:53 ` kernel test robot
2020-09-10 8:53 ` kernel test robot
2020-09-10 8:53 ` kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.