* [RFC PATCH net-next v1 00/11] make drivers/net/ethernet W=1 clean @ 2020-09-11 1:23 ` Jesse Brandeburg 0 siblings, 0 replies; 68+ messages in thread From: Jesse Brandeburg @ 2020-09-11 1:23 UTC (permalink / raw) To: netdev; +Cc: Jesse Brandeburg, intel-wired-lan This series is a placeholder to show I've about finished this work. After applying the patches below, the drivers/net/ethernet directory can be built as modules with W=1 with no warnings. This series removes 1,283 warnings and hopefully allows the ethernet directory to move forward from here without more warnings being added. Some of these patches are already sent to Intel Wired Lan, but the rest of the series titled drivers/net/ethernet affects other drivers, not just Intel, but they depend on the first five. Jesse Brandeburg (11): i40e: prepare flash string in a simpler way i40e: clean up W=1 warnings in i40e iavf: clean up W=1 warnings in iavf ixgbe: clean up W=1 warnings in ixgbe intel-ethernet: make W=1 build cleanly drivers/net/ethernet: clean up unused assignments drivers/net/ethernet: rid ethernet of no-prototype warnings drivers/net/ethernet: handle one warning explicitly drivers/net/ethernet: add some basic kdoc tags drivers/net/ethernet: remove incorrectly formatted doc drivers/net/ethernet: clean up mis-targeted comments drivers/net/ethernet/amazon/ena/ena_com.c | 2 +- .../aquantia/atlantic/hw_atl/hw_atl_b0.c | 2 +- drivers/net/ethernet/arc/emac_arc.c | 2 +- .../net/ethernet/atheros/atl1c/atl1c_main.c | 6 +- .../net/ethernet/atheros/atl1e/atl1e_main.c | 7 +- drivers/net/ethernet/atheros/atlx/atl1.c | 2 +- drivers/net/ethernet/atheros/atlx/atl2.c | 6 +- .../net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 2 + .../ethernet/broadcom/bnx2x/bnx2x_ethtool.c | 6 +- .../net/ethernet/broadcom/bnx2x/bnx2x_main.c | 12 +- .../net/ethernet/broadcom/bnx2x/bnx2x_sp.c | 98 ++--- drivers/net/ethernet/brocade/bna/bfa_cee.c | 20 +- drivers/net/ethernet/brocade/bna/bfa_ioc.c | 8 +- drivers/net/ethernet/brocade/bna/bnad.c | 7 +- drivers/net/ethernet/cadence/macb_main.c | 6 +- drivers/net/ethernet/cadence/macb_pci.c | 2 +- drivers/net/ethernet/calxeda/xgmac.c | 2 + .../ethernet/cavium/liquidio/cn68xx_device.c | 1 + .../net/ethernet/cavium/liquidio/lio_core.c | 92 ++--- .../net/ethernet/cavium/liquidio/lio_main.c | 355 +++++++++--------- .../ethernet/cavium/liquidio/lio_vf_main.c | 158 ++++---- .../ethernet/cavium/liquidio/octeon_console.c | 12 +- .../ethernet/cavium/liquidio/octeon_device.c | 17 +- .../ethernet/cavium/liquidio/octeon_droq.c | 2 +- .../ethernet/cavium/liquidio/octeon_mailbox.c | 5 +- .../ethernet/cavium/liquidio/octeon_mem_ops.c | 1 + .../net/ethernet/chelsio/cxgb3/cxgb3_main.c | 8 +- drivers/net/ethernet/chelsio/cxgb3/sge.c | 28 +- drivers/net/ethernet/chelsio/cxgb3/t3_hw.c | 5 +- drivers/net/ethernet/cisco/enic/enic_api.c | 2 +- .../net/ethernet/cisco/enic/enic_ethtool.c | 2 +- drivers/net/ethernet/cortina/gemini.c | 8 +- drivers/net/ethernet/dec/tulip/de4x5.c | 4 +- drivers/net/ethernet/dec/tulip/media.c | 5 - drivers/net/ethernet/dnet.c | 8 +- drivers/net/ethernet/ethoc.c | 6 +- .../net/ethernet/freescale/dpaa2/dpaa2-eth.c | 2 +- drivers/net/ethernet/freescale/fec_ptp.c | 8 +- drivers/net/ethernet/freescale/fman/fman.c | 14 +- .../net/ethernet/freescale/fman/fman_muram.c | 6 +- .../net/ethernet/freescale/fman/fman_port.c | 23 +- drivers/net/ethernet/freescale/fman/mac.c | 4 +- drivers/net/ethernet/hisilicon/hns/hnae.c | 2 +- .../net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 34 +- .../ethernet/hisilicon/hns/hns_dsaf_main.c | 148 ++++---- .../ethernet/hisilicon/hns/hns_dsaf_misc.c | 7 +- .../net/ethernet/hisilicon/hns/hns_dsaf_ppe.c | 17 +- .../net/ethernet/hisilicon/hns/hns_dsaf_rcb.c | 7 +- .../ethernet/hisilicon/hns/hns_dsaf_xgmac.c | 3 +- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 4 +- .../net/ethernet/hisilicon/hns/hns_ethtool.c | 48 +-- .../hisilicon/hns3/hns3pf/hclge_dcb.c | 1 + drivers/net/ethernet/hisilicon/hns_mdio.c | 3 +- .../net/ethernet/huawei/hinic/hinic_hw_cmdq.c | 2 +- .../net/ethernet/huawei/hinic/hinic_hw_dev.c | 6 +- .../net/ethernet/huawei/hinic/hinic_hw_eqs.c | 1 + .../net/ethernet/huawei/hinic/hinic_hw_if.c | 1 + .../net/ethernet/huawei/hinic/hinic_hw_mgmt.c | 1 + .../net/ethernet/huawei/hinic/hinic_main.c | 2 +- drivers/net/ethernet/intel/e100.c | 8 +- drivers/net/ethernet/intel/e1000/e1000_hw.c | 147 ++++---- drivers/net/ethernet/intel/e1000/e1000_main.c | 39 +- .../net/ethernet/intel/e1000e/80003es2lan.c | 1 - drivers/net/ethernet/intel/e1000e/ich8lan.c | 16 +- drivers/net/ethernet/intel/e1000e/netdev.c | 50 ++- drivers/net/ethernet/intel/e1000e/phy.c | 3 + drivers/net/ethernet/intel/e1000e/ptp.c | 2 +- drivers/net/ethernet/intel/i40e/i40e_client.c | 2 - drivers/net/ethernet/intel/i40e/i40e_common.c | 4 +- drivers/net/ethernet/intel/i40e/i40e_ddp.c | 8 +- drivers/net/ethernet/intel/i40e/i40e_main.c | 17 +- drivers/net/ethernet/intel/i40e/i40e_ptp.c | 1 - drivers/net/ethernet/intel/i40e/i40e_txrx.c | 7 +- .../ethernet/intel/i40e/i40e_virtchnl_pf.c | 9 +- drivers/net/ethernet/intel/iavf/iavf_main.c | 24 +- drivers/net/ethernet/intel/igb/e1000_82575.c | 6 +- drivers/net/ethernet/intel/igb/e1000_i210.c | 5 +- drivers/net/ethernet/intel/igb/e1000_mac.c | 1 + drivers/net/ethernet/intel/igb/e1000_mbx.c | 1 + drivers/net/ethernet/intel/igb/igb_main.c | 28 +- drivers/net/ethernet/intel/igb/igb_ptp.c | 8 +- drivers/net/ethernet/intel/igbvf/netdev.c | 17 +- drivers/net/ethernet/intel/igc/igc_main.c | 2 +- drivers/net/ethernet/intel/igc/igc_ptp.c | 4 +- drivers/net/ethernet/intel/ixgb/ixgb_hw.c | 135 ++++--- drivers/net/ethernet/intel/ixgb/ixgb_main.c | 17 +- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 +- drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 8 +- .../net/ethernet/intel/ixgbevf/ixgbevf_main.c | 3 +- drivers/net/ethernet/marvell/mvneta.c | 7 +- drivers/net/ethernet/marvell/pxa168_eth.c | 3 +- drivers/net/ethernet/mellanox/mlx4/en_tx.c | 2 +- drivers/net/ethernet/micrel/ksz884x.c | 59 +-- .../ethernet/microchip/encx24j600-regmap.c | 2 +- drivers/net/ethernet/microchip/lan743x_main.c | 9 +- drivers/net/ethernet/natsemi/ns83820.c | 6 +- drivers/net/ethernet/neterion/s2io.c | 91 ++--- .../net/ethernet/neterion/vxge/vxge-config.c | 5 +- .../net/ethernet/neterion/vxge/vxge-ethtool.c | 2 +- .../net/ethernet/neterion/vxge/vxge-main.c | 10 +- drivers/net/ethernet/neterion/vxge/vxge-reg.h | 4 +- .../net/ethernet/neterion/vxge/vxge-traffic.c | 72 ++-- .../oki-semi/pch_gbe/pch_gbe_ethtool.c | 4 +- .../ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 5 +- .../ethernet/oki-semi/pch_gbe/pch_gbe_param.c | 14 +- .../net/ethernet/packetengines/yellowfin.c | 2 +- .../net/ethernet/qlogic/netxen/netxen_nic.h | 3 - .../qlogic/netxen/netxen_nic_ethtool.c | 3 + .../ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 3 +- drivers/net/ethernet/qualcomm/emac/emac.c | 1 + drivers/net/ethernet/realtek/8139cp.c | 2 + drivers/net/ethernet/renesas/sh_eth.c | 8 + .../net/ethernet/samsung/sxgbe/sxgbe_main.c | 17 +- drivers/net/ethernet/sfc/falcon/farch.c | 29 +- drivers/net/ethernet/sfc/falcon/rx.c | 2 + drivers/net/ethernet/sfc/falcon/selftest.c | 2 +- drivers/net/ethernet/sfc/net_driver.h | 2 +- drivers/net/ethernet/sfc/ptp.c | 6 + drivers/net/ethernet/sis/sis900.c | 8 +- .../net/ethernet/stmicro/stmmac/dwmac-rk.c | 2 +- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 18 +- .../ethernet/stmicro/stmmac/stmmac_platform.c | 3 +- drivers/net/ethernet/sun/cassini.c | 4 +- .../net/ethernet/synopsys/dwc-xlgmac-common.c | 2 +- drivers/net/ethernet/tehuti/tehuti.c | 17 +- drivers/net/ethernet/ti/cpsw_new.c | 2 - drivers/net/ethernet/ti/davinci_cpdma.c | 2 +- drivers/net/ethernet/ti/davinci_emac.c | 10 +- drivers/net/ethernet/ti/tlan.c | 4 +- drivers/net/ethernet/via/via-rhine.c | 2 +- drivers/net/ethernet/via/via-velocity.c | 40 +- drivers/net/ethernet/xilinx/ll_temac_main.c | 26 +- 132 files changed, 1227 insertions(+), 1117 deletions(-) base-commit: b55353e2cc1415c1ece3ae34a856309b40bb0b4b -- 2.27.0 ^ permalink raw reply [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 00/11] make drivers/net/ethernet W=1 clean @ 2020-09-11 1:23 ` Jesse Brandeburg 0 siblings, 0 replies; 68+ messages in thread From: Jesse Brandeburg @ 2020-09-11 1:23 UTC (permalink / raw) To: intel-wired-lan This series is a placeholder to show I've about finished this work. After applying the patches below, the drivers/net/ethernet directory can be built as modules with W=1 with no warnings. This series removes 1,283 warnings and hopefully allows the ethernet directory to move forward from here without more warnings being added. Some of these patches are already sent to Intel Wired Lan, but the rest of the series titled drivers/net/ethernet affects other drivers, not just Intel, but they depend on the first five. Jesse Brandeburg (11): i40e: prepare flash string in a simpler way i40e: clean up W=1 warnings in i40e iavf: clean up W=1 warnings in iavf ixgbe: clean up W=1 warnings in ixgbe intel-ethernet: make W=1 build cleanly drivers/net/ethernet: clean up unused assignments drivers/net/ethernet: rid ethernet of no-prototype warnings drivers/net/ethernet: handle one warning explicitly drivers/net/ethernet: add some basic kdoc tags drivers/net/ethernet: remove incorrectly formatted doc drivers/net/ethernet: clean up mis-targeted comments drivers/net/ethernet/amazon/ena/ena_com.c | 2 +- .../aquantia/atlantic/hw_atl/hw_atl_b0.c | 2 +- drivers/net/ethernet/arc/emac_arc.c | 2 +- .../net/ethernet/atheros/atl1c/atl1c_main.c | 6 +- .../net/ethernet/atheros/atl1e/atl1e_main.c | 7 +- drivers/net/ethernet/atheros/atlx/atl1.c | 2 +- drivers/net/ethernet/atheros/atlx/atl2.c | 6 +- .../net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 2 + .../ethernet/broadcom/bnx2x/bnx2x_ethtool.c | 6 +- .../net/ethernet/broadcom/bnx2x/bnx2x_main.c | 12 +- .../net/ethernet/broadcom/bnx2x/bnx2x_sp.c | 98 ++--- drivers/net/ethernet/brocade/bna/bfa_cee.c | 20 +- drivers/net/ethernet/brocade/bna/bfa_ioc.c | 8 +- drivers/net/ethernet/brocade/bna/bnad.c | 7 +- drivers/net/ethernet/cadence/macb_main.c | 6 +- drivers/net/ethernet/cadence/macb_pci.c | 2 +- drivers/net/ethernet/calxeda/xgmac.c | 2 + .../ethernet/cavium/liquidio/cn68xx_device.c | 1 + .../net/ethernet/cavium/liquidio/lio_core.c | 92 ++--- .../net/ethernet/cavium/liquidio/lio_main.c | 355 +++++++++--------- .../ethernet/cavium/liquidio/lio_vf_main.c | 158 ++++---- .../ethernet/cavium/liquidio/octeon_console.c | 12 +- .../ethernet/cavium/liquidio/octeon_device.c | 17 +- .../ethernet/cavium/liquidio/octeon_droq.c | 2 +- .../ethernet/cavium/liquidio/octeon_mailbox.c | 5 +- .../ethernet/cavium/liquidio/octeon_mem_ops.c | 1 + .../net/ethernet/chelsio/cxgb3/cxgb3_main.c | 8 +- drivers/net/ethernet/chelsio/cxgb3/sge.c | 28 +- drivers/net/ethernet/chelsio/cxgb3/t3_hw.c | 5 +- drivers/net/ethernet/cisco/enic/enic_api.c | 2 +- .../net/ethernet/cisco/enic/enic_ethtool.c | 2 +- drivers/net/ethernet/cortina/gemini.c | 8 +- drivers/net/ethernet/dec/tulip/de4x5.c | 4 +- drivers/net/ethernet/dec/tulip/media.c | 5 - drivers/net/ethernet/dnet.c | 8 +- drivers/net/ethernet/ethoc.c | 6 +- .../net/ethernet/freescale/dpaa2/dpaa2-eth.c | 2 +- drivers/net/ethernet/freescale/fec_ptp.c | 8 +- drivers/net/ethernet/freescale/fman/fman.c | 14 +- .../net/ethernet/freescale/fman/fman_muram.c | 6 +- .../net/ethernet/freescale/fman/fman_port.c | 23 +- drivers/net/ethernet/freescale/fman/mac.c | 4 +- drivers/net/ethernet/hisilicon/hns/hnae.c | 2 +- .../net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 34 +- .../ethernet/hisilicon/hns/hns_dsaf_main.c | 148 ++++---- .../ethernet/hisilicon/hns/hns_dsaf_misc.c | 7 +- .../net/ethernet/hisilicon/hns/hns_dsaf_ppe.c | 17 +- .../net/ethernet/hisilicon/hns/hns_dsaf_rcb.c | 7 +- .../ethernet/hisilicon/hns/hns_dsaf_xgmac.c | 3 +- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 4 +- .../net/ethernet/hisilicon/hns/hns_ethtool.c | 48 +-- .../hisilicon/hns3/hns3pf/hclge_dcb.c | 1 + drivers/net/ethernet/hisilicon/hns_mdio.c | 3 +- .../net/ethernet/huawei/hinic/hinic_hw_cmdq.c | 2 +- .../net/ethernet/huawei/hinic/hinic_hw_dev.c | 6 +- .../net/ethernet/huawei/hinic/hinic_hw_eqs.c | 1 + .../net/ethernet/huawei/hinic/hinic_hw_if.c | 1 + .../net/ethernet/huawei/hinic/hinic_hw_mgmt.c | 1 + .../net/ethernet/huawei/hinic/hinic_main.c | 2 +- drivers/net/ethernet/intel/e100.c | 8 +- drivers/net/ethernet/intel/e1000/e1000_hw.c | 147 ++++---- drivers/net/ethernet/intel/e1000/e1000_main.c | 39 +- .../net/ethernet/intel/e1000e/80003es2lan.c | 1 - drivers/net/ethernet/intel/e1000e/ich8lan.c | 16 +- drivers/net/ethernet/intel/e1000e/netdev.c | 50 ++- drivers/net/ethernet/intel/e1000e/phy.c | 3 + drivers/net/ethernet/intel/e1000e/ptp.c | 2 +- drivers/net/ethernet/intel/i40e/i40e_client.c | 2 - drivers/net/ethernet/intel/i40e/i40e_common.c | 4 +- drivers/net/ethernet/intel/i40e/i40e_ddp.c | 8 +- drivers/net/ethernet/intel/i40e/i40e_main.c | 17 +- drivers/net/ethernet/intel/i40e/i40e_ptp.c | 1 - drivers/net/ethernet/intel/i40e/i40e_txrx.c | 7 +- .../ethernet/intel/i40e/i40e_virtchnl_pf.c | 9 +- drivers/net/ethernet/intel/iavf/iavf_main.c | 24 +- drivers/net/ethernet/intel/igb/e1000_82575.c | 6 +- drivers/net/ethernet/intel/igb/e1000_i210.c | 5 +- drivers/net/ethernet/intel/igb/e1000_mac.c | 1 + drivers/net/ethernet/intel/igb/e1000_mbx.c | 1 + drivers/net/ethernet/intel/igb/igb_main.c | 28 +- drivers/net/ethernet/intel/igb/igb_ptp.c | 8 +- drivers/net/ethernet/intel/igbvf/netdev.c | 17 +- drivers/net/ethernet/intel/igc/igc_main.c | 2 +- drivers/net/ethernet/intel/igc/igc_ptp.c | 4 +- drivers/net/ethernet/intel/ixgb/ixgb_hw.c | 135 ++++--- drivers/net/ethernet/intel/ixgb/ixgb_main.c | 17 +- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 +- drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 8 +- .../net/ethernet/intel/ixgbevf/ixgbevf_main.c | 3 +- drivers/net/ethernet/marvell/mvneta.c | 7 +- drivers/net/ethernet/marvell/pxa168_eth.c | 3 +- drivers/net/ethernet/mellanox/mlx4/en_tx.c | 2 +- drivers/net/ethernet/micrel/ksz884x.c | 59 +-- .../ethernet/microchip/encx24j600-regmap.c | 2 +- drivers/net/ethernet/microchip/lan743x_main.c | 9 +- drivers/net/ethernet/natsemi/ns83820.c | 6 +- drivers/net/ethernet/neterion/s2io.c | 91 ++--- .../net/ethernet/neterion/vxge/vxge-config.c | 5 +- .../net/ethernet/neterion/vxge/vxge-ethtool.c | 2 +- .../net/ethernet/neterion/vxge/vxge-main.c | 10 +- drivers/net/ethernet/neterion/vxge/vxge-reg.h | 4 +- .../net/ethernet/neterion/vxge/vxge-traffic.c | 72 ++-- .../oki-semi/pch_gbe/pch_gbe_ethtool.c | 4 +- .../ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 5 +- .../ethernet/oki-semi/pch_gbe/pch_gbe_param.c | 14 +- .../net/ethernet/packetengines/yellowfin.c | 2 +- .../net/ethernet/qlogic/netxen/netxen_nic.h | 3 - .../qlogic/netxen/netxen_nic_ethtool.c | 3 + .../ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 3 +- drivers/net/ethernet/qualcomm/emac/emac.c | 1 + drivers/net/ethernet/realtek/8139cp.c | 2 + drivers/net/ethernet/renesas/sh_eth.c | 8 + .../net/ethernet/samsung/sxgbe/sxgbe_main.c | 17 +- drivers/net/ethernet/sfc/falcon/farch.c | 29 +- drivers/net/ethernet/sfc/falcon/rx.c | 2 + drivers/net/ethernet/sfc/falcon/selftest.c | 2 +- drivers/net/ethernet/sfc/net_driver.h | 2 +- drivers/net/ethernet/sfc/ptp.c | 6 + drivers/net/ethernet/sis/sis900.c | 8 +- .../net/ethernet/stmicro/stmmac/dwmac-rk.c | 2 +- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 18 +- .../ethernet/stmicro/stmmac/stmmac_platform.c | 3 +- drivers/net/ethernet/sun/cassini.c | 4 +- .../net/ethernet/synopsys/dwc-xlgmac-common.c | 2 +- drivers/net/ethernet/tehuti/tehuti.c | 17 +- drivers/net/ethernet/ti/cpsw_new.c | 2 - drivers/net/ethernet/ti/davinci_cpdma.c | 2 +- drivers/net/ethernet/ti/davinci_emac.c | 10 +- drivers/net/ethernet/ti/tlan.c | 4 +- drivers/net/ethernet/via/via-rhine.c | 2 +- drivers/net/ethernet/via/via-velocity.c | 40 +- drivers/net/ethernet/xilinx/ll_temac_main.c | 26 +- 132 files changed, 1227 insertions(+), 1117 deletions(-) base-commit: b55353e2cc1415c1ece3ae34a856309b40bb0b4b -- 2.27.0 ^ permalink raw reply [flat|nested] 68+ messages in thread
* [RFC PATCH net-next v1 01/11] i40e: prepare flash string in a simpler way 2020-09-11 1:23 ` [Intel-wired-lan] " Jesse Brandeburg @ 2020-09-11 1:23 ` Jesse Brandeburg -1 siblings, 0 replies; 68+ messages in thread From: Jesse Brandeburg @ 2020-09-11 1:23 UTC (permalink / raw) To: netdev; +Cc: Jesse Brandeburg, intel-wired-lan The flash string handling code triggered a W=1 warning and upon investigation it seems everything can be handled in a simpler way with a single initialization and one strlcat. The buffer is filled with NULL after the end of the string by the initializer, and the strlcat checks total length, and makes sure the buffer is terminated cleanly. I didn't mark this with a fixes tag as there is no apparent bug since the existing code would limit the input data + path to be the right size, but it does fix the W=1 warning. Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> --- drivers/net/ethernet/intel/i40e/i40e_ddp.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_ddp.c b/drivers/net/ethernet/intel/i40e/i40e_ddp.c index 5e08f100c413..9767fdf56124 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_ddp.c +++ b/drivers/net/ethernet/intel/i40e/i40e_ddp.c @@ -434,14 +434,10 @@ int i40e_ddp_flash(struct net_device *netdev, struct ethtool_flash *flash) * stored profile. */ if (strncmp(flash->data, "-", 2) != 0) { + char profile_name[ETHTOOL_FLASH_MAX_FILENAME] = I40E_DDP_PROFILE_PATH; struct i40e_ddp_old_profile_list *list_entry; - char profile_name[sizeof(I40E_DDP_PROFILE_PATH) - + I40E_DDP_PROFILE_NAME_MAX]; - profile_name[sizeof(profile_name) - 1] = 0; - strncpy(profile_name, I40E_DDP_PROFILE_PATH, - sizeof(profile_name) - 1); - strncat(profile_name, flash->data, I40E_DDP_PROFILE_NAME_MAX); + strlcat(profile_name, flash->data, ETHTOOL_FLASH_MAX_FILENAME); /* Load DDP recipe. */ status = request_firmware(&ddp_config, profile_name, &netdev->dev); -- 2.27.0 ^ permalink raw reply related [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 01/11] i40e: prepare flash string in a simpler way @ 2020-09-11 1:23 ` Jesse Brandeburg 0 siblings, 0 replies; 68+ messages in thread From: Jesse Brandeburg @ 2020-09-11 1:23 UTC (permalink / raw) To: intel-wired-lan The flash string handling code triggered a W=1 warning and upon investigation it seems everything can be handled in a simpler way with a single initialization and one strlcat. The buffer is filled with NULL after the end of the string by the initializer, and the strlcat checks total length, and makes sure the buffer is terminated cleanly. I didn't mark this with a fixes tag as there is no apparent bug since the existing code would limit the input data + path to be the right size, but it does fix the W=1 warning. Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> --- drivers/net/ethernet/intel/i40e/i40e_ddp.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_ddp.c b/drivers/net/ethernet/intel/i40e/i40e_ddp.c index 5e08f100c413..9767fdf56124 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_ddp.c +++ b/drivers/net/ethernet/intel/i40e/i40e_ddp.c @@ -434,14 +434,10 @@ int i40e_ddp_flash(struct net_device *netdev, struct ethtool_flash *flash) * stored profile. */ if (strncmp(flash->data, "-", 2) != 0) { + char profile_name[ETHTOOL_FLASH_MAX_FILENAME] = I40E_DDP_PROFILE_PATH; struct i40e_ddp_old_profile_list *list_entry; - char profile_name[sizeof(I40E_DDP_PROFILE_PATH) - + I40E_DDP_PROFILE_NAME_MAX]; - profile_name[sizeof(profile_name) - 1] = 0; - strncpy(profile_name, I40E_DDP_PROFILE_PATH, - sizeof(profile_name) - 1); - strncat(profile_name, flash->data, I40E_DDP_PROFILE_NAME_MAX); + strlcat(profile_name, flash->data, ETHTOOL_FLASH_MAX_FILENAME); /* Load DDP recipe. */ status = request_firmware(&ddp_config, profile_name, &netdev->dev); -- 2.27.0 ^ permalink raw reply related [flat|nested] 68+ messages in thread
* [RFC PATCH net-next v1 02/11] i40e: clean up W=1 warnings in i40e 2020-09-11 1:23 ` [Intel-wired-lan] " Jesse Brandeburg @ 2020-09-11 1:23 ` Jesse Brandeburg -1 siblings, 0 replies; 68+ messages in thread From: Jesse Brandeburg @ 2020-09-11 1:23 UTC (permalink / raw) To: netdev; +Cc: Jesse Brandeburg, intel-wired-lan Inspired by Lee Jones, this eliminates the remaining W=1 warnings in i40e. Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> --- drivers/net/ethernet/intel/i40e/i40e_client.c | 2 -- drivers/net/ethernet/intel/i40e/i40e_common.c | 4 ++-- drivers/net/ethernet/intel/i40e/i40e_main.c | 17 ++++++++++------- drivers/net/ethernet/intel/i40e/i40e_ptp.c | 1 - drivers/net/ethernet/intel/i40e/i40e_txrx.c | 7 ++++--- .../net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 9 +++++---- 6 files changed, 21 insertions(+), 19 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_client.c b/drivers/net/ethernet/intel/i40e/i40e_client.c index befd3018183f..a2dba32383f6 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_client.c +++ b/drivers/net/ethernet/intel/i40e/i40e_client.c @@ -278,8 +278,6 @@ void i40e_client_update_msix_info(struct i40e_pf *pf) /** * i40e_client_add_instance - add a client instance struct to the instance list * @pf: pointer to the board struct - * @client: pointer to a client struct in the client list. - * @existing: if there was already an existing instance * **/ static void i40e_client_add_instance(struct i40e_pf *pf) diff --git a/drivers/net/ethernet/intel/i40e/i40e_common.c b/drivers/net/ethernet/intel/i40e/i40e_common.c index 6ab52cbd697a..adc9e4fa4789 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_common.c +++ b/drivers/net/ethernet/intel/i40e/i40e_common.c @@ -3766,9 +3766,7 @@ i40e_status i40e_aq_stop_lldp(struct i40e_hw *hw, bool shutdown_agent, /** * i40e_aq_start_lldp * @hw: pointer to the hw struct - * @buff: buffer for result * @persist: True if start of LLDP should be persistent across power cycles - * @buff_size: buffer size * @cmd_details: pointer to command details structure or NULL * * Start the embedded LLDP Agent on all ports. @@ -5395,6 +5393,7 @@ static void i40e_mdio_if_number_selection(struct i40e_hw *hw, bool set_mdio, * @hw: pointer to the hw struct * @phy_select: select which phy should be accessed * @dev_addr: PHY device address + * @page_change: flag to indicate if phy page should be updated * @set_mdio: use MDIO I/F number specified by mdio_num * @mdio_num: MDIO I/F number * @reg_addr: PHY register address @@ -5439,6 +5438,7 @@ enum i40e_status_code i40e_aq_set_phy_register_ext(struct i40e_hw *hw, * @hw: pointer to the hw struct * @phy_select: select which phy should be accessed * @dev_addr: PHY device address + * @page_change: flag to indicate if phy page should be updated * @set_mdio: use MDIO I/F number specified by mdio_num * @mdio_num: MDIO I/F number * @reg_addr: PHY register address diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c index 05c6d3ea11e6..4553700ce686 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_main.c +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c @@ -287,6 +287,7 @@ void i40e_service_event_schedule(struct i40e_pf *pf) /** * i40e_tx_timeout - Respond to a Tx Hang * @netdev: network interface device structure + * @txqueue: queue number timing out * * If any port has noticed a Tx timeout, it is likely that the whole * device is munged, not just the one netdev port, so go for the full @@ -1609,6 +1610,8 @@ static int i40e_set_mac(struct net_device *netdev, void *p) * i40e_config_rss_aq - Prepare for RSS using AQ commands * @vsi: vsi structure * @seed: RSS hash seed + * @lut: pointer to lookup table of lut_size + * @lut_size: size of the lookup table **/ static int i40e_config_rss_aq(struct i40e_vsi *vsi, const u8 *seed, u8 *lut, u16 lut_size) @@ -5815,7 +5818,6 @@ static int i40e_vsi_reconfig_rss(struct i40e_vsi *vsi, u16 rss_size) /** * i40e_channel_setup_queue_map - Setup a channel queue map * @pf: ptr to PF device - * @vsi: the VSI being setup * @ctxt: VSI context structure * @ch: ptr to channel structure * @@ -6058,8 +6060,7 @@ static inline int i40e_setup_hw_channel(struct i40e_pf *pf, /** * i40e_setup_channel - setup new channel using uplink element * @pf: ptr to PF device - * @type: type of channel to be created (VMDq2/VF) - * @uplink_seid: underlying HW switching element (VEB) ID + * @vsi: pointer to the VSI to set up the channel within * @ch: ptr to channel structure * * Setup new channel (VSI) based on specified type (VMDq2/VF) @@ -7780,7 +7781,7 @@ int i40e_add_del_cloud_filter_big_buf(struct i40e_vsi *vsi, /** * i40e_parse_cls_flower - Parse tc flower filters provided by kernel * @vsi: Pointer to VSI - * @cls_flower: Pointer to struct flow_cls_offload + * @f: Pointer to struct flow_cls_offload * @filter: Pointer to cloud filter structure * **/ @@ -8161,8 +8162,8 @@ static int i40e_delete_clsflower(struct i40e_vsi *vsi, /** * i40e_setup_tc_cls_flower - flower classifier offloads - * @netdev: net device to configure - * @type_data: offload data + * @np: net device to configure + * @cls_flower: offload data **/ static int i40e_setup_tc_cls_flower(struct i40e_netdev_priv *np, struct flow_cls_offload *cls_flower) @@ -9586,6 +9587,7 @@ static int i40e_reconstitute_veb(struct i40e_veb *veb) /** * i40e_get_capabilities - get info about the HW * @pf: the PF struct + * @list_type: AQ capability to be queried **/ static int i40e_get_capabilities(struct i40e_pf *pf, enum i40e_admin_queue_opc list_type) @@ -10547,7 +10549,7 @@ static void i40e_service_task(struct work_struct *work) /** * i40e_service_timer - timer callback - * @data: pointer to PF struct + * @t: timer list pointer **/ static void i40e_service_timer(struct timer_list *t) { @@ -12380,6 +12382,7 @@ static int i40e_get_phys_port_id(struct net_device *netdev, * @addr: the MAC address entry being added * @vid: VLAN ID * @flags: instructions from stack about fdb operation + * @extack: netlink extended ack, unused currently */ static int i40e_ndo_fdb_add(struct ndmsg *ndm, struct nlattr *tb[], struct net_device *dev, diff --git a/drivers/net/ethernet/intel/i40e/i40e_ptp.c b/drivers/net/ethernet/intel/i40e/i40e_ptp.c index ff7b19c6bc73..7a879614ca55 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_ptp.c +++ b/drivers/net/ethernet/intel/i40e/i40e_ptp.c @@ -259,7 +259,6 @@ static u32 i40e_ptp_get_rx_events(struct i40e_pf *pf) /** * i40e_ptp_rx_hang - Detect error case when Rx timestamp registers are hung * @pf: The PF private data structure - * @vsi: The VSI with the rings relevant to 1588 * * This watchdog task is scheduled to detect error case where hardware has * dropped an Rx packet that was timestamped when the ring is full. The diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c index 91ab824926b9..828dff2e7ed2 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c +++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c @@ -1755,7 +1755,6 @@ static inline void i40e_rx_hash(struct i40e_ring *ring, * @rx_ring: rx descriptor ring packet is being transacted on * @rx_desc: pointer to the EOP Rx descriptor * @skb: pointer to current skb being populated - * @rx_ptype: the packet type decoded by hardware * * This function checks the ring, descriptor, and packet information in * order to populate the hash, checksum, VLAN, protocol, and @@ -3499,7 +3498,7 @@ static inline int i40e_tx_map(struct i40e_ring *tx_ring, struct sk_buff *skb, /** * i40e_xmit_xdp_ring - transmits an XDP buffer to an XDP Tx ring - * @xdp: data to transmit + * @xdpf: data to transmit * @xdp_ring: XDP Tx ring **/ static int i40e_xmit_xdp_ring(struct xdp_frame *xdpf, @@ -3694,7 +3693,9 @@ netdev_tx_t i40e_lan_xmit_frame(struct sk_buff *skb, struct net_device *netdev) /** * i40e_xdp_xmit - Implements ndo_xdp_xmit * @dev: netdev - * @xdp: XDP buffer + * @n: number of frames + * @frames: array of XDP buffer pointers + * @flags: XDP extra info * * Returns number of frames successfully sent. Frames that fail are * free'ed via XDP return API. diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c index 8e133d6545bd..f32a907b4419 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c +++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c @@ -2234,7 +2234,8 @@ static int i40e_vc_config_queues_msg(struct i40e_vf *vf, u8 *msg) } /** - * i40e_validate_queue_map + * i40e_validate_queue_map - check queue map is valid + * @vf: the VF structure pointer * @vsi_id: vsi id * @queuemap: Tx or Rx queue map * @@ -3150,8 +3151,8 @@ static int i40e_vc_disable_vlan_stripping(struct i40e_vf *vf, u8 *msg) /** * i40e_validate_cloud_filter - * @mask: mask for TC filter - * @data: data for TC filter + * @vf: pointer to VF structure + * @tc_filter: pointer to filter requested * * This function validates cloud filter programmed as TC filter for ADq **/ @@ -3284,7 +3285,7 @@ static int i40e_validate_cloud_filter(struct i40e_vf *vf, /** * i40e_find_vsi_from_seid - searches for the vsi with the given seid * @vf: pointer to the VF info - * @seid - seid of the vsi it is searching for + * @seid: seid of the vsi it is searching for **/ static struct i40e_vsi *i40e_find_vsi_from_seid(struct i40e_vf *vf, u16 seid) { -- 2.27.0 ^ permalink raw reply related [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 02/11] i40e: clean up W=1 warnings in i40e @ 2020-09-11 1:23 ` Jesse Brandeburg 0 siblings, 0 replies; 68+ messages in thread From: Jesse Brandeburg @ 2020-09-11 1:23 UTC (permalink / raw) To: intel-wired-lan Inspired by Lee Jones, this eliminates the remaining W=1 warnings in i40e. Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> --- drivers/net/ethernet/intel/i40e/i40e_client.c | 2 -- drivers/net/ethernet/intel/i40e/i40e_common.c | 4 ++-- drivers/net/ethernet/intel/i40e/i40e_main.c | 17 ++++++++++------- drivers/net/ethernet/intel/i40e/i40e_ptp.c | 1 - drivers/net/ethernet/intel/i40e/i40e_txrx.c | 7 ++++--- .../net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 9 +++++---- 6 files changed, 21 insertions(+), 19 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_client.c b/drivers/net/ethernet/intel/i40e/i40e_client.c index befd3018183f..a2dba32383f6 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_client.c +++ b/drivers/net/ethernet/intel/i40e/i40e_client.c @@ -278,8 +278,6 @@ void i40e_client_update_msix_info(struct i40e_pf *pf) /** * i40e_client_add_instance - add a client instance struct to the instance list * @pf: pointer to the board struct - * @client: pointer to a client struct in the client list. - * @existing: if there was already an existing instance * **/ static void i40e_client_add_instance(struct i40e_pf *pf) diff --git a/drivers/net/ethernet/intel/i40e/i40e_common.c b/drivers/net/ethernet/intel/i40e/i40e_common.c index 6ab52cbd697a..adc9e4fa4789 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_common.c +++ b/drivers/net/ethernet/intel/i40e/i40e_common.c @@ -3766,9 +3766,7 @@ i40e_status i40e_aq_stop_lldp(struct i40e_hw *hw, bool shutdown_agent, /** * i40e_aq_start_lldp * @hw: pointer to the hw struct - * @buff: buffer for result * @persist: True if start of LLDP should be persistent across power cycles - * @buff_size: buffer size * @cmd_details: pointer to command details structure or NULL * * Start the embedded LLDP Agent on all ports. @@ -5395,6 +5393,7 @@ static void i40e_mdio_if_number_selection(struct i40e_hw *hw, bool set_mdio, * @hw: pointer to the hw struct * @phy_select: select which phy should be accessed * @dev_addr: PHY device address + * @page_change: flag to indicate if phy page should be updated * @set_mdio: use MDIO I/F number specified by mdio_num * @mdio_num: MDIO I/F number * @reg_addr: PHY register address @@ -5439,6 +5438,7 @@ enum i40e_status_code i40e_aq_set_phy_register_ext(struct i40e_hw *hw, * @hw: pointer to the hw struct * @phy_select: select which phy should be accessed * @dev_addr: PHY device address + * @page_change: flag to indicate if phy page should be updated * @set_mdio: use MDIO I/F number specified by mdio_num * @mdio_num: MDIO I/F number * @reg_addr: PHY register address diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c index 05c6d3ea11e6..4553700ce686 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_main.c +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c @@ -287,6 +287,7 @@ void i40e_service_event_schedule(struct i40e_pf *pf) /** * i40e_tx_timeout - Respond to a Tx Hang * @netdev: network interface device structure + * @txqueue: queue number timing out * * If any port has noticed a Tx timeout, it is likely that the whole * device is munged, not just the one netdev port, so go for the full @@ -1609,6 +1610,8 @@ static int i40e_set_mac(struct net_device *netdev, void *p) * i40e_config_rss_aq - Prepare for RSS using AQ commands * @vsi: vsi structure * @seed: RSS hash seed + * @lut: pointer to lookup table of lut_size + * @lut_size: size of the lookup table **/ static int i40e_config_rss_aq(struct i40e_vsi *vsi, const u8 *seed, u8 *lut, u16 lut_size) @@ -5815,7 +5818,6 @@ static int i40e_vsi_reconfig_rss(struct i40e_vsi *vsi, u16 rss_size) /** * i40e_channel_setup_queue_map - Setup a channel queue map * @pf: ptr to PF device - * @vsi: the VSI being setup * @ctxt: VSI context structure * @ch: ptr to channel structure * @@ -6058,8 +6060,7 @@ static inline int i40e_setup_hw_channel(struct i40e_pf *pf, /** * i40e_setup_channel - setup new channel using uplink element * @pf: ptr to PF device - * @type: type of channel to be created (VMDq2/VF) - * @uplink_seid: underlying HW switching element (VEB) ID + * @vsi: pointer to the VSI to set up the channel within * @ch: ptr to channel structure * * Setup new channel (VSI) based on specified type (VMDq2/VF) @@ -7780,7 +7781,7 @@ int i40e_add_del_cloud_filter_big_buf(struct i40e_vsi *vsi, /** * i40e_parse_cls_flower - Parse tc flower filters provided by kernel * @vsi: Pointer to VSI - * @cls_flower: Pointer to struct flow_cls_offload + * @f: Pointer to struct flow_cls_offload * @filter: Pointer to cloud filter structure * **/ @@ -8161,8 +8162,8 @@ static int i40e_delete_clsflower(struct i40e_vsi *vsi, /** * i40e_setup_tc_cls_flower - flower classifier offloads - * @netdev: net device to configure - * @type_data: offload data + * @np: net device to configure + * @cls_flower: offload data **/ static int i40e_setup_tc_cls_flower(struct i40e_netdev_priv *np, struct flow_cls_offload *cls_flower) @@ -9586,6 +9587,7 @@ static int i40e_reconstitute_veb(struct i40e_veb *veb) /** * i40e_get_capabilities - get info about the HW * @pf: the PF struct + * @list_type: AQ capability to be queried **/ static int i40e_get_capabilities(struct i40e_pf *pf, enum i40e_admin_queue_opc list_type) @@ -10547,7 +10549,7 @@ static void i40e_service_task(struct work_struct *work) /** * i40e_service_timer - timer callback - * @data: pointer to PF struct + * @t: timer list pointer **/ static void i40e_service_timer(struct timer_list *t) { @@ -12380,6 +12382,7 @@ static int i40e_get_phys_port_id(struct net_device *netdev, * @addr: the MAC address entry being added * @vid: VLAN ID * @flags: instructions from stack about fdb operation + * @extack: netlink extended ack, unused currently */ static int i40e_ndo_fdb_add(struct ndmsg *ndm, struct nlattr *tb[], struct net_device *dev, diff --git a/drivers/net/ethernet/intel/i40e/i40e_ptp.c b/drivers/net/ethernet/intel/i40e/i40e_ptp.c index ff7b19c6bc73..7a879614ca55 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_ptp.c +++ b/drivers/net/ethernet/intel/i40e/i40e_ptp.c @@ -259,7 +259,6 @@ static u32 i40e_ptp_get_rx_events(struct i40e_pf *pf) /** * i40e_ptp_rx_hang - Detect error case when Rx timestamp registers are hung * @pf: The PF private data structure - * @vsi: The VSI with the rings relevant to 1588 * * This watchdog task is scheduled to detect error case where hardware has * dropped an Rx packet that was timestamped when the ring is full. The diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c index 91ab824926b9..828dff2e7ed2 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c +++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c @@ -1755,7 +1755,6 @@ static inline void i40e_rx_hash(struct i40e_ring *ring, * @rx_ring: rx descriptor ring packet is being transacted on * @rx_desc: pointer to the EOP Rx descriptor * @skb: pointer to current skb being populated - * @rx_ptype: the packet type decoded by hardware * * This function checks the ring, descriptor, and packet information in * order to populate the hash, checksum, VLAN, protocol, and @@ -3499,7 +3498,7 @@ static inline int i40e_tx_map(struct i40e_ring *tx_ring, struct sk_buff *skb, /** * i40e_xmit_xdp_ring - transmits an XDP buffer to an XDP Tx ring - * @xdp: data to transmit + * @xdpf: data to transmit * @xdp_ring: XDP Tx ring **/ static int i40e_xmit_xdp_ring(struct xdp_frame *xdpf, @@ -3694,7 +3693,9 @@ netdev_tx_t i40e_lan_xmit_frame(struct sk_buff *skb, struct net_device *netdev) /** * i40e_xdp_xmit - Implements ndo_xdp_xmit * @dev: netdev - * @xdp: XDP buffer + * @n: number of frames + * @frames: array of XDP buffer pointers + * @flags: XDP extra info * * Returns number of frames successfully sent. Frames that fail are * free'ed via XDP return API. diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c index 8e133d6545bd..f32a907b4419 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c +++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c @@ -2234,7 +2234,8 @@ static int i40e_vc_config_queues_msg(struct i40e_vf *vf, u8 *msg) } /** - * i40e_validate_queue_map + * i40e_validate_queue_map - check queue map is valid + * @vf: the VF structure pointer * @vsi_id: vsi id * @queuemap: Tx or Rx queue map * @@ -3150,8 +3151,8 @@ static int i40e_vc_disable_vlan_stripping(struct i40e_vf *vf, u8 *msg) /** * i40e_validate_cloud_filter - * @mask: mask for TC filter - * @data: data for TC filter + * @vf: pointer to VF structure + * @tc_filter: pointer to filter requested * * This function validates cloud filter programmed as TC filter for ADq **/ @@ -3284,7 +3285,7 @@ static int i40e_validate_cloud_filter(struct i40e_vf *vf, /** * i40e_find_vsi_from_seid - searches for the vsi with the given seid * @vf: pointer to the VF info - * @seid - seid of the vsi it is searching for + * @seid: seid of the vsi it is searching for **/ static struct i40e_vsi *i40e_find_vsi_from_seid(struct i40e_vf *vf, u16 seid) { -- 2.27.0 ^ permalink raw reply related [flat|nested] 68+ messages in thread
* RE: [Intel-wired-lan] [RFC PATCH net-next v1 02/11] i40e: clean up W=1 warnings in i40e 2020-09-11 1:23 ` [Intel-wired-lan] " Jesse Brandeburg @ 2020-09-23 2:02 ` Brown, Aaron F -1 siblings, 0 replies; 68+ messages in thread From: Brown, Aaron F @ 2020-09-23 2:02 UTC (permalink / raw) To: Brandeburg, Jesse, netdev; +Cc: intel-wired-lan > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of > Jesse Brandeburg > Sent: Thursday, September 10, 2020 6:23 PM > To: netdev@vger.kernel.org > Cc: intel-wired-lan@lists.osuosl.org > Subject: [Intel-wired-lan] [RFC PATCH net-next v1 02/11] i40e: clean up W=1 > warnings in i40e > > Inspired by Lee Jones, this eliminates the remaining W=1 warnings in i40e. > > Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> > --- > drivers/net/ethernet/intel/i40e/i40e_client.c | 2 -- > drivers/net/ethernet/intel/i40e/i40e_common.c | 4 ++-- > drivers/net/ethernet/intel/i40e/i40e_main.c | 17 ++++++++++------- > drivers/net/ethernet/intel/i40e/i40e_ptp.c | 1 - > drivers/net/ethernet/intel/i40e/i40e_txrx.c | 7 ++++--- > .../net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 9 +++++---- > 6 files changed, 21 insertions(+), 19 deletions(-) > Tested-by: Aaron Brown <aaron.f.brown@intel.com> Not sure if this is intended to be the final form, but it's in the tree I'm testing with and seems to work... ^ permalink raw reply [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 02/11] i40e: clean up W=1 warnings in i40e @ 2020-09-23 2:02 ` Brown, Aaron F 0 siblings, 0 replies; 68+ messages in thread From: Brown, Aaron F @ 2020-09-23 2:02 UTC (permalink / raw) To: intel-wired-lan > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of > Jesse Brandeburg > Sent: Thursday, September 10, 2020 6:23 PM > To: netdev at vger.kernel.org > Cc: intel-wired-lan at lists.osuosl.org > Subject: [Intel-wired-lan] [RFC PATCH net-next v1 02/11] i40e: clean up W=1 > warnings in i40e > > Inspired by Lee Jones, this eliminates the remaining W=1 warnings in i40e. > > Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> > --- > drivers/net/ethernet/intel/i40e/i40e_client.c | 2 -- > drivers/net/ethernet/intel/i40e/i40e_common.c | 4 ++-- > drivers/net/ethernet/intel/i40e/i40e_main.c | 17 ++++++++++------- > drivers/net/ethernet/intel/i40e/i40e_ptp.c | 1 - > drivers/net/ethernet/intel/i40e/i40e_txrx.c | 7 ++++--- > .../net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 9 +++++---- > 6 files changed, 21 insertions(+), 19 deletions(-) > Tested-by: Aaron Brown <aaron.f.brown@intel.com> Not sure if this is intended to be the final form, but it's in the tree I'm testing with and seems to work... ^ permalink raw reply [flat|nested] 68+ messages in thread
* [RFC PATCH net-next v1 03/11] iavf: clean up W=1 warnings in iavf 2020-09-11 1:23 ` [Intel-wired-lan] " Jesse Brandeburg @ 2020-09-11 1:23 ` Jesse Brandeburg -1 siblings, 0 replies; 68+ messages in thread From: Jesse Brandeburg @ 2020-09-11 1:23 UTC (permalink / raw) To: netdev; +Cc: Jesse Brandeburg, intel-wired-lan Inspired by Lee Jones, this eliminates the remaining W=1 warnings in iavf. Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> --- drivers/net/ethernet/intel/iavf/iavf_main.c | 24 ++++++++++----------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c index d870343cf689..814e59bf2c94 100644 --- a/drivers/net/ethernet/intel/iavf/iavf_main.c +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c @@ -147,6 +147,7 @@ void iavf_schedule_reset(struct iavf_adapter *adapter) /** * iavf_tx_timeout - Respond to a Tx Hang * @netdev: network interface device structure + * @txqueue: queue number that is timing out **/ static void iavf_tx_timeout(struct net_device *netdev, unsigned int txqueue) { @@ -2572,8 +2573,8 @@ static int iavf_validate_ch_config(struct iavf_adapter *adapter, } /** - * iavf_del_all_cloud_filters - delete all cloud filters - * on the traffic classes + * iavf_del_all_cloud_filters - delete all cloud filters on the traffic classes + * @adapter: board private structure **/ static void iavf_del_all_cloud_filters(struct iavf_adapter *adapter) { @@ -2592,7 +2593,7 @@ static void iavf_del_all_cloud_filters(struct iavf_adapter *adapter) /** * __iavf_setup_tc - configure multiple traffic classes * @netdev: network interface device structure - * @type_date: tc offload data + * @type_data: tc offload data * * This function processes the config information provided by the * user to configure traffic classes/queue channels and packages the @@ -2690,7 +2691,7 @@ static int __iavf_setup_tc(struct net_device *netdev, void *type_data) /** * iavf_parse_cls_flower - Parse tc flower filters provided by kernel * @adapter: board private structure - * @cls_flower: pointer to struct flow_cls_offload + * @f: pointer to struct flow_cls_offload * @filter: pointer to cloud filter structure */ static int iavf_parse_cls_flower(struct iavf_adapter *adapter, @@ -3064,8 +3065,8 @@ static int iavf_delete_clsflower(struct iavf_adapter *adapter, /** * iavf_setup_tc_cls_flower - flower classifier offloads - * @netdev: net device to configure - * @type_data: offload data + * @adapter: board private structure + * @cls_flower: pointer to flow_cls_offload struct with flow info */ static int iavf_setup_tc_cls_flower(struct iavf_adapter *adapter, struct flow_cls_offload *cls_flower) @@ -3112,7 +3113,7 @@ static LIST_HEAD(iavf_block_cb_list); * iavf_setup_tc - configure multiple traffic classes * @netdev: network interface device structure * @type: type of offload - * @type_date: tc offload data + * @type_data: tc offload data * * This function is the callback to ndo_setup_tc in the * netdev_ops. @@ -3768,8 +3769,7 @@ static int iavf_probe(struct pci_dev *pdev, const struct pci_device_id *ent) /** * iavf_suspend - Power management suspend routine - * @pdev: PCI device information struct - * @state: unused + * @dev_d: device info pointer * * Called when the system (VM) is entering sleep/suspend. **/ @@ -3799,15 +3799,15 @@ static int __maybe_unused iavf_suspend(struct device *dev_d) /** * iavf_resume - Power management resume routine - * @pdev: PCI device information struct + * @dev_d: device info pointer * * Called when the system (VM) is resumed from sleep/suspend. **/ static int __maybe_unused iavf_resume(struct device *dev_d) { + struct net_device *netdev = dev_get_drvdata(dev_d); + struct iavf_adapter *adapter = netdev_priv(netdev); struct pci_dev *pdev = to_pci_dev(dev_d); - struct iavf_adapter *adapter = pci_get_drvdata(pdev); - struct net_device *netdev = adapter->netdev; u32 err; pci_set_master(pdev); -- 2.27.0 ^ permalink raw reply related [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 03/11] iavf: clean up W=1 warnings in iavf @ 2020-09-11 1:23 ` Jesse Brandeburg 0 siblings, 0 replies; 68+ messages in thread From: Jesse Brandeburg @ 2020-09-11 1:23 UTC (permalink / raw) To: intel-wired-lan Inspired by Lee Jones, this eliminates the remaining W=1 warnings in iavf. Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> --- drivers/net/ethernet/intel/iavf/iavf_main.c | 24 ++++++++++----------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c index d870343cf689..814e59bf2c94 100644 --- a/drivers/net/ethernet/intel/iavf/iavf_main.c +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c @@ -147,6 +147,7 @@ void iavf_schedule_reset(struct iavf_adapter *adapter) /** * iavf_tx_timeout - Respond to a Tx Hang * @netdev: network interface device structure + * @txqueue: queue number that is timing out **/ static void iavf_tx_timeout(struct net_device *netdev, unsigned int txqueue) { @@ -2572,8 +2573,8 @@ static int iavf_validate_ch_config(struct iavf_adapter *adapter, } /** - * iavf_del_all_cloud_filters - delete all cloud filters - * on the traffic classes + * iavf_del_all_cloud_filters - delete all cloud filters on the traffic classes + * @adapter: board private structure **/ static void iavf_del_all_cloud_filters(struct iavf_adapter *adapter) { @@ -2592,7 +2593,7 @@ static void iavf_del_all_cloud_filters(struct iavf_adapter *adapter) /** * __iavf_setup_tc - configure multiple traffic classes * @netdev: network interface device structure - * @type_date: tc offload data + * @type_data: tc offload data * * This function processes the config information provided by the * user to configure traffic classes/queue channels and packages the @@ -2690,7 +2691,7 @@ static int __iavf_setup_tc(struct net_device *netdev, void *type_data) /** * iavf_parse_cls_flower - Parse tc flower filters provided by kernel * @adapter: board private structure - * @cls_flower: pointer to struct flow_cls_offload + * @f: pointer to struct flow_cls_offload * @filter: pointer to cloud filter structure */ static int iavf_parse_cls_flower(struct iavf_adapter *adapter, @@ -3064,8 +3065,8 @@ static int iavf_delete_clsflower(struct iavf_adapter *adapter, /** * iavf_setup_tc_cls_flower - flower classifier offloads - * @netdev: net device to configure - * @type_data: offload data + * @adapter: board private structure + * @cls_flower: pointer to flow_cls_offload struct with flow info */ static int iavf_setup_tc_cls_flower(struct iavf_adapter *adapter, struct flow_cls_offload *cls_flower) @@ -3112,7 +3113,7 @@ static LIST_HEAD(iavf_block_cb_list); * iavf_setup_tc - configure multiple traffic classes * @netdev: network interface device structure * @type: type of offload - * @type_date: tc offload data + * @type_data: tc offload data * * This function is the callback to ndo_setup_tc in the * netdev_ops. @@ -3768,8 +3769,7 @@ static int iavf_probe(struct pci_dev *pdev, const struct pci_device_id *ent) /** * iavf_suspend - Power management suspend routine - * @pdev: PCI device information struct - * @state: unused + * @dev_d: device info pointer * * Called when the system (VM) is entering sleep/suspend. **/ @@ -3799,15 +3799,15 @@ static int __maybe_unused iavf_suspend(struct device *dev_d) /** * iavf_resume - Power management resume routine - * @pdev: PCI device information struct + * @dev_d: device info pointer * * Called when the system (VM) is resumed from sleep/suspend. **/ static int __maybe_unused iavf_resume(struct device *dev_d) { + struct net_device *netdev = dev_get_drvdata(dev_d); + struct iavf_adapter *adapter = netdev_priv(netdev); struct pci_dev *pdev = to_pci_dev(dev_d); - struct iavf_adapter *adapter = pci_get_drvdata(pdev); - struct net_device *netdev = adapter->netdev; u32 err; pci_set_master(pdev); -- 2.27.0 ^ permalink raw reply related [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 03/11] iavf: clean up W=1 warnings in iavf 2020-09-11 1:23 ` [Intel-wired-lan] " Jesse Brandeburg (?) @ 2020-09-23 3:12 ` Brown, Aaron F -1 siblings, 0 replies; 68+ messages in thread From: Brown, Aaron F @ 2020-09-23 3:12 UTC (permalink / raw) To: intel-wired-lan > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of > Jesse Brandeburg > Sent: Thursday, September 10, 2020 6:23 PM > To: netdev at vger.kernel.org > Cc: intel-wired-lan at lists.osuosl.org > Subject: [Intel-wired-lan] [RFC PATCH net-next v1 03/11] iavf: clean up W=1 > warnings in iavf > > Inspired by Lee Jones, this eliminates the remaining W=1 warnings > in iavf. > > Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> > --- > drivers/net/ethernet/intel/iavf/iavf_main.c | 24 ++++++++++----------- > 1 file changed, 12 insertions(+), 12 deletions(-) > Tested-by: Aaron Brown <aaron.f.brown@intel.com> ^ permalink raw reply [flat|nested] 68+ messages in thread
* [RFC PATCH net-next v1 04/11] ixgbe: clean up W=1 warnings in ixgbe 2020-09-11 1:23 ` [Intel-wired-lan] " Jesse Brandeburg @ 2020-09-11 1:23 ` Jesse Brandeburg -1 siblings, 0 replies; 68+ messages in thread From: Jesse Brandeburg @ 2020-09-11 1:23 UTC (permalink / raw) To: netdev; +Cc: Jesse Brandeburg, intel-wired-lan Inspired by Lee Jones, this eliminates the remaining W=1 warnings in ixgbe. Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 ++- drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 8 ++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c index 0b675c34ce49..02899f79f0ff 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c @@ -6175,8 +6175,9 @@ static void ixgbe_set_eee_capable(struct ixgbe_adapter *adapter) /** * ixgbe_tx_timeout - Respond to a Tx Hang * @netdev: network interface device structure + * @txqueue: queue number that timed out **/ -static void ixgbe_tx_timeout(struct net_device *netdev, unsigned int txqueue) +static void ixgbe_tx_timeout(struct net_device *netdev, unsigned int __always_unused txqueue) { struct ixgbe_adapter *adapter = netdev_priv(netdev); diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c index 7980d7265e10..f77fa3e4fdd1 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c @@ -771,7 +771,7 @@ static s32 ixgbe_mii_bus_write_generic(struct ixgbe_hw *hw, int addr, /** * ixgbe_mii_bus_read - Read a clause 22/45 register - * @hw: pointer to hardware structure + * @bus: pointer to mii_bus structure which points to our driver private * @addr: address * @regnum: register number **/ @@ -786,7 +786,7 @@ static s32 ixgbe_mii_bus_read(struct mii_bus *bus, int addr, int regnum) /** * ixgbe_mii_bus_write - Write a clause 22/45 register - * @hw: pointer to hardware structure + * @bus: pointer to mii_bus structure which points to our driver private * @addr: address * @regnum: register number * @val: value to write @@ -803,7 +803,7 @@ static s32 ixgbe_mii_bus_write(struct mii_bus *bus, int addr, int regnum, /** * ixgbe_x550em_a_mii_bus_read - Read a clause 22/45 register on x550em_a - * @hw: pointer to hardware structure + * @bus: pointer to mii_bus structure which points to our driver private * @addr: address * @regnum: register number **/ @@ -820,7 +820,7 @@ static s32 ixgbe_x550em_a_mii_bus_read(struct mii_bus *bus, int addr, /** * ixgbe_x550em_a_mii_bus_write - Write a clause 22/45 register on x550em_a - * @hw: pointer to hardware structure + * @bus: pointer to mii_bus structure which points to our driver private * @addr: address * @regnum: register number * @val: value to write -- 2.27.0 ^ permalink raw reply related [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 04/11] ixgbe: clean up W=1 warnings in ixgbe @ 2020-09-11 1:23 ` Jesse Brandeburg 0 siblings, 0 replies; 68+ messages in thread From: Jesse Brandeburg @ 2020-09-11 1:23 UTC (permalink / raw) To: intel-wired-lan Inspired by Lee Jones, this eliminates the remaining W=1 warnings in ixgbe. Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 ++- drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 8 ++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c index 0b675c34ce49..02899f79f0ff 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c @@ -6175,8 +6175,9 @@ static void ixgbe_set_eee_capable(struct ixgbe_adapter *adapter) /** * ixgbe_tx_timeout - Respond to a Tx Hang * @netdev: network interface device structure + * @txqueue: queue number that timed out **/ -static void ixgbe_tx_timeout(struct net_device *netdev, unsigned int txqueue) +static void ixgbe_tx_timeout(struct net_device *netdev, unsigned int __always_unused txqueue) { struct ixgbe_adapter *adapter = netdev_priv(netdev); diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c index 7980d7265e10..f77fa3e4fdd1 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c @@ -771,7 +771,7 @@ static s32 ixgbe_mii_bus_write_generic(struct ixgbe_hw *hw, int addr, /** * ixgbe_mii_bus_read - Read a clause 22/45 register - * @hw: pointer to hardware structure + * @bus: pointer to mii_bus structure which points to our driver private * @addr: address * @regnum: register number **/ @@ -786,7 +786,7 @@ static s32 ixgbe_mii_bus_read(struct mii_bus *bus, int addr, int regnum) /** * ixgbe_mii_bus_write - Write a clause 22/45 register - * @hw: pointer to hardware structure + * @bus: pointer to mii_bus structure which points to our driver private * @addr: address * @regnum: register number * @val: value to write @@ -803,7 +803,7 @@ static s32 ixgbe_mii_bus_write(struct mii_bus *bus, int addr, int regnum, /** * ixgbe_x550em_a_mii_bus_read - Read a clause 22/45 register on x550em_a - * @hw: pointer to hardware structure + * @bus: pointer to mii_bus structure which points to our driver private * @addr: address * @regnum: register number **/ @@ -820,7 +820,7 @@ static s32 ixgbe_x550em_a_mii_bus_read(struct mii_bus *bus, int addr, /** * ixgbe_x550em_a_mii_bus_write - Write a clause 22/45 register on x550em_a - * @hw: pointer to hardware structure + * @bus: pointer to mii_bus structure which points to our driver private * @addr: address * @regnum: register number * @val: value to write -- 2.27.0 ^ permalink raw reply related [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 04/11] ixgbe: clean up W=1 warnings in ixgbe 2020-09-11 1:23 ` [Intel-wired-lan] " Jesse Brandeburg (?) @ 2020-09-23 3:57 ` Brown, Aaron F -1 siblings, 0 replies; 68+ messages in thread From: Brown, Aaron F @ 2020-09-23 3:57 UTC (permalink / raw) To: intel-wired-lan > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of > Jesse Brandeburg > Sent: Thursday, September 10, 2020 6:24 PM > To: netdev at vger.kernel.org > Cc: intel-wired-lan at lists.osuosl.org > Subject: [Intel-wired-lan] [RFC PATCH net-next v1 04/11] ixgbe: clean up W=1 > warnings in ixgbe > > Inspired by Lee Jones, this eliminates the remaining W=1 warnings in > ixgbe. > > Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 ++- > drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 8 ++++---- > 2 files changed, 6 insertions(+), 5 deletions(-) > Tested-by: Aaron Brown <aaron.f.brown@intel.com> ^ permalink raw reply [flat|nested] 68+ messages in thread
* [RFC PATCH net-next v1 05/11] intel-ethernet: make W=1 build cleanly 2020-09-11 1:23 ` [Intel-wired-lan] " Jesse Brandeburg @ 2020-09-11 1:23 ` Jesse Brandeburg -1 siblings, 0 replies; 68+ messages in thread From: Jesse Brandeburg @ 2020-09-11 1:23 UTC (permalink / raw) To: netdev; +Cc: Jesse Brandeburg, intel-wired-lan This takes care of all of the trivial W=1 fixes in the Intel Ethernet drivers, which allows developers and maintainers to build more of the networking tree with more complete warning checks. Almost all of the changes were trivial comment updates on function headers, but some of the changes were for variables that were storing a return value from a register read, where the return value wasn't used. Those conversions to remove the lvalue of the assignment should be safe because the readl memory mapped reads are marked volatile and should not be optimized out without an lvalue (I suspect a very long time ago this wasn't guaranteed as it is today). Inspired by Lee Jones' series of wireless work to do the same. Compile tested only. Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> --- drivers/net/ethernet/intel/e100.c | 8 +- drivers/net/ethernet/intel/e1000/e1000_hw.c | 147 ++++++++---------- drivers/net/ethernet/intel/e1000/e1000_main.c | 39 +++-- .../net/ethernet/intel/e1000e/80003es2lan.c | 1 - drivers/net/ethernet/intel/e1000e/ich8lan.c | 16 +- drivers/net/ethernet/intel/e1000e/netdev.c | 50 ++++-- drivers/net/ethernet/intel/e1000e/phy.c | 3 + drivers/net/ethernet/intel/e1000e/ptp.c | 2 +- drivers/net/ethernet/intel/igb/e1000_82575.c | 6 +- drivers/net/ethernet/intel/igb/e1000_i210.c | 5 +- drivers/net/ethernet/intel/igb/e1000_mac.c | 1 + drivers/net/ethernet/intel/igb/e1000_mbx.c | 1 + drivers/net/ethernet/intel/igb/igb_main.c | 28 ++-- drivers/net/ethernet/intel/igb/igb_ptp.c | 8 +- drivers/net/ethernet/intel/igbvf/netdev.c | 17 +- drivers/net/ethernet/intel/igc/igc_main.c | 2 +- drivers/net/ethernet/intel/igc/igc_ptp.c | 4 +- drivers/net/ethernet/intel/ixgb/ixgb_hw.c | 135 ++++++++-------- drivers/net/ethernet/intel/ixgb/ixgb_main.c | 17 +- .../net/ethernet/intel/ixgbevf/ixgbevf_main.c | 3 +- 20 files changed, 265 insertions(+), 228 deletions(-) diff --git a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/intel/e100.c index 36da059388dc..76bb77b4607a 100644 --- a/drivers/net/ethernet/intel/e100.c +++ b/drivers/net/ethernet/intel/e100.c @@ -384,7 +384,7 @@ enum cb_status { cb_ok = 0x2000, }; -/** +/* * cb_command - Command Block flags * @cb_tx_nc: 0: controller does CRC (normal), 1: CRC from skb memory */ @@ -2593,7 +2593,7 @@ static void e100_diag_test(struct net_device *netdev, { struct ethtool_cmd cmd; struct nic *nic = netdev_priv(netdev); - int i, err; + int i; memset(data, 0, E100_TEST_LEN * sizeof(u64)); data[0] = !mii_link_ok(&nic->mii); @@ -2601,7 +2601,7 @@ static void e100_diag_test(struct net_device *netdev, if (test->flags & ETH_TEST_FL_OFFLINE) { /* save speed, duplex & autoneg settings */ - err = mii_ethtool_gset(&nic->mii, &cmd); + mii_ethtool_gset(&nic->mii, &cmd); if (netif_running(netdev)) e100_down(nic); @@ -2610,7 +2610,7 @@ static void e100_diag_test(struct net_device *netdev, data[4] = e100_loopback_test(nic, lb_phy); /* restore speed, duplex & autoneg settings */ - err = mii_ethtool_sset(&nic->mii, &cmd); + mii_ethtool_sset(&nic->mii, &cmd); if (netif_running(netdev)) e100_up(nic); diff --git a/drivers/net/ethernet/intel/e1000/e1000_hw.c b/drivers/net/ethernet/intel/e1000/e1000_hw.c index 4e7a0810eaeb..2120dacfd55c 100644 --- a/drivers/net/ethernet/intel/e1000/e1000_hw.c +++ b/drivers/net/ethernet/intel/e1000/e1000_hw.c @@ -139,6 +139,7 @@ static void e1000_phy_init_script(struct e1000_hw *hw) * at the end of this routine. */ ret_val = e1000_read_phy_reg(hw, 0x2F5B, &phy_saved_data); + e_dbg("Reading PHY register 0x2F5B failed: %d\n", ret_val); /* Disabled the PHY transmitter */ e1000_write_phy_reg(hw, 0x2F5B, 0x0003); @@ -377,7 +378,6 @@ s32 e1000_reset_hw(struct e1000_hw *hw) { u32 ctrl; u32 ctrl_ext; - u32 icr; u32 manc; u32 led_ctrl; s32 ret_val; @@ -502,7 +502,7 @@ s32 e1000_reset_hw(struct e1000_hw *hw) ew32(IMC, 0xffffffff); /* Clear any pending interrupt events. */ - icr = er32(ICR); + er32(ICR); /* If MWI was previously enabled, reenable it. */ if (hw->mac_type == e1000_82542_rev2_0) { @@ -1897,7 +1897,6 @@ void e1000_config_collision_dist(struct e1000_hw *hw) /** * e1000_config_mac_to_phy - sync phy and mac settings * @hw: Struct containing variables accessed by shared code - * @mii_reg: data to write to the MII control register * * Sets MAC speed and duplex settings to reflect the those in the PHY * The contents of the PHY register containing the needed information need to @@ -2370,16 +2369,13 @@ static s32 e1000_check_for_serdes_link_generic(struct e1000_hw *hw) */ s32 e1000_check_for_link(struct e1000_hw *hw) { - u32 rxcw = 0; - u32 ctrl; u32 status; u32 rctl; u32 icr; - u32 signal = 0; s32 ret_val; u16 phy_data; - ctrl = er32(CTRL); + er32(CTRL); status = er32(STATUS); /* On adapters with a MAC newer than 82544, SW Definable pin 1 will be @@ -2388,12 +2384,9 @@ s32 e1000_check_for_link(struct e1000_hw *hw) */ if ((hw->media_type == e1000_media_type_fiber) || (hw->media_type == e1000_media_type_internal_serdes)) { - rxcw = er32(RXCW); + er32(RXCW); if (hw->media_type == e1000_media_type_fiber) { - signal = - (hw->mac_type > - e1000_82544) ? E1000_CTRL_SWDPIN1 : 0; if (status & E1000_STATUS_LU) hw->get_link_status = false; } @@ -2922,7 +2915,7 @@ static s32 e1000_read_phy_reg_ex(struct e1000_hw *hw, u32 reg_addr, * * @hw: Struct containing variables accessed by shared code * @reg_addr: address of the PHY register to write - * @data: data to write to the PHY + * @phy_data: data to write to the PHY * * Writes a value to a PHY register */ @@ -4675,78 +4668,76 @@ s32 e1000_led_off(struct e1000_hw *hw) */ static void e1000_clear_hw_cntrs(struct e1000_hw *hw) { - volatile u32 temp; - - temp = er32(CRCERRS); - temp = er32(SYMERRS); - temp = er32(MPC); - temp = er32(SCC); - temp = er32(ECOL); - temp = er32(MCC); - temp = er32(LATECOL); - temp = er32(COLC); - temp = er32(DC); - temp = er32(SEC); - temp = er32(RLEC); - temp = er32(XONRXC); - temp = er32(XONTXC); - temp = er32(XOFFRXC); - temp = er32(XOFFTXC); - temp = er32(FCRUC); - - temp = er32(PRC64); - temp = er32(PRC127); - temp = er32(PRC255); - temp = er32(PRC511); - temp = er32(PRC1023); - temp = er32(PRC1522); - - temp = er32(GPRC); - temp = er32(BPRC); - temp = er32(MPRC); - temp = er32(GPTC); - temp = er32(GORCL); - temp = er32(GORCH); - temp = er32(GOTCL); - temp = er32(GOTCH); - temp = er32(RNBC); - temp = er32(RUC); - temp = er32(RFC); - temp = er32(ROC); - temp = er32(RJC); - temp = er32(TORL); - temp = er32(TORH); - temp = er32(TOTL); - temp = er32(TOTH); - temp = er32(TPR); - temp = er32(TPT); - - temp = er32(PTC64); - temp = er32(PTC127); - temp = er32(PTC255); - temp = er32(PTC511); - temp = er32(PTC1023); - temp = er32(PTC1522); - - temp = er32(MPTC); - temp = er32(BPTC); + er32(CRCERRS); + er32(SYMERRS); + er32(MPC); + er32(SCC); + er32(ECOL); + er32(MCC); + er32(LATECOL); + er32(COLC); + er32(DC); + er32(SEC); + er32(RLEC); + er32(XONRXC); + er32(XONTXC); + er32(XOFFRXC); + er32(XOFFTXC); + er32(FCRUC); + + er32(PRC64); + er32(PRC127); + er32(PRC255); + er32(PRC511); + er32(PRC1023); + er32(PRC1522); + + er32(GPRC); + er32(BPRC); + er32(MPRC); + er32(GPTC); + er32(GORCL); + er32(GORCH); + er32(GOTCL); + er32(GOTCH); + er32(RNBC); + er32(RUC); + er32(RFC); + er32(ROC); + er32(RJC); + er32(TORL); + er32(TORH); + er32(TOTL); + er32(TOTH); + er32(TPR); + er32(TPT); + + er32(PTC64); + er32(PTC127); + er32(PTC255); + er32(PTC511); + er32(PTC1023); + er32(PTC1522); + + er32(MPTC); + er32(BPTC); if (hw->mac_type < e1000_82543) return; - temp = er32(ALGNERRC); - temp = er32(RXERRC); - temp = er32(TNCRS); - temp = er32(CEXTERR); - temp = er32(TSCTC); - temp = er32(TSCTFC); + er32(ALGNERRC); + er32(RXERRC); + er32(TNCRS); + er32(CEXTERR); + er32(TSCTC); + er32(TSCTFC); if (hw->mac_type <= e1000_82544) return; - temp = er32(MGTPRC); - temp = er32(MGTPDC); - temp = er32(MGTPTC); + er32(MGTPRC); + er32(MGTPDC); + er32(MGTPTC); } /** @@ -4778,8 +4769,6 @@ void e1000_reset_adaptive(struct e1000_hw *hw) /** * e1000_update_adaptive - update adaptive IFS * @hw: Struct containing variables accessed by shared code - * @tx_packets: Number of transmits since last callback - * @total_collisions: Number of collisions since last callback * * Called during the callback/watchdog routine to update IFS value based on * the ratio of transmits to collisions. @@ -5064,8 +5053,6 @@ static s32 e1000_check_polarity(struct e1000_hw *hw, /** * e1000_check_downshift - Check if Downshift occurred * @hw: Struct containing variables accessed by shared code - * @downshift: output parameter : 0 - No Downshift occurred. - * 1 - Downshift occurred. * * returns: - E1000_ERR_XXX * E1000_SUCCESS diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c index 1e6ec081fd9d..906591614553 100644 --- a/drivers/net/ethernet/intel/e1000/e1000_main.c +++ b/drivers/net/ethernet/intel/e1000/e1000_main.c @@ -199,8 +199,10 @@ module_param(debug, int, 0); MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)"); /** - * e1000_get_hw_dev - return device - * used by hardware layer to print debugging information + * e1000_get_hw_dev - helper function for getting netdev + * @hw: pointer to HW struct + * + * return device used by hardware layer to print debugging information * **/ struct net_device *e1000_get_hw_dev(struct e1000_hw *hw) @@ -354,7 +356,7 @@ static void e1000_release_manageability(struct e1000_adapter *adapter) /** * e1000_configure - configure the hardware for RX and TX - * @adapter = private board structure + * @adapter: private board structure **/ static void e1000_configure(struct e1000_adapter *adapter) { @@ -3489,8 +3491,9 @@ static void e1000_dump(struct e1000_adapter *adapter) /** * e1000_tx_timeout - Respond to a Tx Hang * @netdev: network interface device structure + * @txqueue: number of the Tx queue that hung (unused) **/ -static void e1000_tx_timeout(struct net_device *netdev, unsigned int txqueue) +static void e1000_tx_timeout(struct net_device *netdev, unsigned int __always_unused txqueue) { struct e1000_adapter *adapter = netdev_priv(netdev); @@ -3787,7 +3790,8 @@ static irqreturn_t e1000_intr(int irq, void *data) /** * e1000_clean - NAPI Rx polling callback - * @adapter: board private structure + * @napi: napi struct containing references to driver info + * @budget: budget given to driver for receive packets **/ static int e1000_clean(struct napi_struct *napi, int budget) { @@ -3818,6 +3822,7 @@ static int e1000_clean(struct napi_struct *napi, int budget) /** * e1000_clean_tx_irq - Reclaim resources after transmit completes * @adapter: board private structure + * @tx_ring: ring to clean **/ static bool e1000_clean_tx_irq(struct e1000_adapter *adapter, struct e1000_tx_ring *tx_ring) @@ -3933,7 +3938,7 @@ static bool e1000_clean_tx_irq(struct e1000_adapter *adapter, * @adapter: board private structure * @status_err: receive descriptor status and error fields * @csum: receive descriptor csum field - * @sk_buff: socket buffer with received data + * @skb: socket buffer with received data **/ static void e1000_rx_checksum(struct e1000_adapter *adapter, u32 status_err, u32 csum, struct sk_buff *skb) @@ -3970,6 +3975,9 @@ static void e1000_rx_checksum(struct e1000_adapter *adapter, u32 status_err, /** * e1000_consume_page - helper function for jumbo Rx path + * @bi: software descriptor shadow data + * @skb: skb being modified + * @length: length of data being added **/ static void e1000_consume_page(struct e1000_rx_buffer *bi, struct sk_buff *skb, u16 length) @@ -4003,6 +4011,7 @@ static void e1000_receive_skb(struct e1000_adapter *adapter, u8 status, /** * e1000_tbi_adjust_stats * @hw: Struct containing variables accessed by shared code + * @stats: point to stats struct * @frame_len: The length of the frame in question * @mac_addr: The Ethernet destination address of the frame in question * @@ -4548,6 +4557,8 @@ e1000_alloc_jumbo_rx_buffers(struct e1000_adapter *adapter, /** * e1000_alloc_rx_buffers - Replace used receive buffers; legacy & extended * @adapter: address of board private structure + * @rx_ring: pointer to ring struct + * @cleaned_count: number of new Rx buffers to try to allocate **/ static void e1000_alloc_rx_buffers(struct e1000_adapter *adapter, struct e1000_rx_ring *rx_ring, @@ -4662,7 +4673,7 @@ static void e1000_alloc_rx_buffers(struct e1000_adapter *adapter, /** * e1000_smartspeed - Workaround for SmartSpeed on 82541 and 82547 controllers. - * @adapter: + * @adapter: address of board private structure **/ static void e1000_smartspeed(struct e1000_adapter *adapter) { @@ -4718,10 +4729,10 @@ static void e1000_smartspeed(struct e1000_adapter *adapter) } /** - * e1000_ioctl - - * @netdev: - * @ifreq: - * @cmd: + * e1000_ioctl - handle ioctl calls + * @netdev: pointer to our netdev + * @ifr: pointer to interface request structure + * @cmd: ioctl data **/ static int e1000_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd) { @@ -4737,9 +4748,9 @@ static int e1000_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd) /** * e1000_mii_ioctl - - * @netdev: - * @ifreq: - * @cmd: + * @netdev: pointer to our netdev + * @ifr: pointer to interface request structure + * @cmd: ioctl data **/ static int e1000_mii_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd) diff --git a/drivers/net/ethernet/intel/e1000e/80003es2lan.c b/drivers/net/ethernet/intel/e1000e/80003es2lan.c index 4b103cca8a39..be9c695dde12 100644 --- a/drivers/net/ethernet/intel/e1000e/80003es2lan.c +++ b/drivers/net/ethernet/intel/e1000e/80003es2lan.c @@ -1072,7 +1072,6 @@ static s32 e1000_setup_copper_link_80003es2lan(struct e1000_hw *hw) /** * e1000_cfg_on_link_up_80003es2lan - es2 link configuration after link-up * @hw: pointer to the HW structure - * @duplex: current duplex setting * * Configure the KMRN interface by applying last minute quirks for * 10/100 operation. diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c b/drivers/net/ethernet/intel/e1000e/ich8lan.c index b2f2fcfdf732..ded74304e8cf 100644 --- a/drivers/net/ethernet/intel/e1000e/ich8lan.c +++ b/drivers/net/ethernet/intel/e1000e/ich8lan.c @@ -743,7 +743,7 @@ static s32 e1000_init_mac_params_ich8lan(struct e1000_hw *hw) /** * __e1000_access_emi_reg_locked - Read/write EMI register * @hw: pointer to the HW structure - * @addr: EMI address to program + * @address: EMI address to program * @data: pointer to value to read/write from/to the EMI address * @read: boolean flag to indicate read or write * @@ -2266,7 +2266,7 @@ static s32 e1000_k1_gig_workaround_hv(struct e1000_hw *hw, bool link) /** * e1000_configure_k1_ich8lan - Configure K1 power state * @hw: pointer to the HW structure - * @enable: K1 state to configure + * @k1_enable: K1 state to configure * * Configure the K1 power state based on the provided parameter. * Assumes semaphore already acquired. @@ -2405,8 +2405,10 @@ static s32 e1000_set_mdio_slow_mode_hv(struct e1000_hw *hw) } /** - * e1000_hv_phy_workarounds_ich8lan - A series of Phy workarounds to be - * done after every PHY reset. + * e1000_hv_phy_workarounds_ich8lan - apply PHY workarounds + * @hw: pointer to the HW structure + * + * A series of PHY workarounds to be done after every PHY reset. **/ static s32 e1000_hv_phy_workarounds_ich8lan(struct e1000_hw *hw) { @@ -2694,8 +2696,10 @@ s32 e1000_lv_jumbo_workaround_ich8lan(struct e1000_hw *hw, bool enable) } /** - * e1000_lv_phy_workarounds_ich8lan - A series of Phy workarounds to be - * done after every PHY reset. + * e1000_lv_phy_workarounds_ich8lan - apply ich8 specific workarounds + * @hw: pointer to the HW structure + * + * A series of PHY workarounds to be done after every PHY reset. **/ static s32 e1000_lv_phy_workarounds_ich8lan(struct e1000_hw *hw) { diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c index 664e8ccc88d2..99f4ec9b5696 100644 --- a/drivers/net/ethernet/intel/e1000e/netdev.c +++ b/drivers/net/ethernet/intel/e1000e/netdev.c @@ -501,6 +501,7 @@ static void e1000e_dump(struct e1000_adapter *adapter) /** * e1000_desc_unused - calculate if we have unused descriptors + * @ring: pointer to ring struct to perform calculation on **/ static int e1000_desc_unused(struct e1000_ring *ring) { @@ -577,6 +578,7 @@ static void e1000e_rx_hwtstamp(struct e1000_adapter *adapter, u32 status, /** * e1000_receive_skb - helper function to handle Rx indications * @adapter: board private structure + * @netdev: pointer to netdev struct * @staterr: descriptor extended error and status field as written by hardware * @vlan: descriptor vlan field as written by hardware (no le/be conversion) * @skb: pointer to sk_buff to be indicated to stack @@ -601,8 +603,7 @@ static void e1000_receive_skb(struct e1000_adapter *adapter, * e1000_rx_checksum - Receive Checksum Offload * @adapter: board private structure * @status_err: receive descriptor status and error fields - * @csum: receive descriptor csum field - * @sk_buff: socket buffer with received data + * @skb: socket buffer with received data **/ static void e1000_rx_checksum(struct e1000_adapter *adapter, u32 status_err, struct sk_buff *skb) @@ -673,6 +674,8 @@ static void e1000e_update_tdt_wa(struct e1000_ring *tx_ring, unsigned int i) /** * e1000_alloc_rx_buffers - Replace used receive buffers * @rx_ring: Rx descriptor ring + * @cleaned_count: number to reallocate + * @gfp: flags for allocation **/ static void e1000_alloc_rx_buffers(struct e1000_ring *rx_ring, int cleaned_count, gfp_t gfp) @@ -741,6 +744,8 @@ static void e1000_alloc_rx_buffers(struct e1000_ring *rx_ring, /** * e1000_alloc_rx_buffers_ps - Replace used receive buffers; packet split * @rx_ring: Rx descriptor ring + * @cleaned_count: number to reallocate + * @gfp: flags for allocation **/ static void e1000_alloc_rx_buffers_ps(struct e1000_ring *rx_ring, int cleaned_count, gfp_t gfp) @@ -844,6 +849,7 @@ static void e1000_alloc_rx_buffers_ps(struct e1000_ring *rx_ring, * e1000_alloc_jumbo_rx_buffers - Replace used jumbo receive buffers * @rx_ring: Rx descriptor ring * @cleaned_count: number of buffers to allocate this pass + * @gfp: flags for allocation **/ static void e1000_alloc_jumbo_rx_buffers(struct e1000_ring *rx_ring, @@ -933,6 +939,8 @@ static inline void e1000_rx_hash(struct net_device *netdev, __le32 rss, /** * e1000_clean_rx_irq - Send received data up the network stack * @rx_ring: Rx descriptor ring + * @work_done: output parameter for indicating completed work + * @work_to_do: how many packets we can clean * * the return value indicates whether actual cleaning was done, there * is no guarantee that everything was cleaned @@ -1327,6 +1335,8 @@ static bool e1000_clean_tx_irq(struct e1000_ring *tx_ring) /** * e1000_clean_rx_irq_ps - Send received data up the network stack; packet split * @rx_ring: Rx descriptor ring + * @work_done: output parameter for indicating completed work + * @work_to_do: how many packets we can clean * * the return value indicates whether actual cleaning was done, there * is no guarantee that everything was cleaned @@ -1517,9 +1527,6 @@ static bool e1000_clean_rx_irq_ps(struct e1000_ring *rx_ring, int *work_done, return cleaned; } -/** - * e1000_consume_page - helper function - **/ static void e1000_consume_page(struct e1000_buffer *bi, struct sk_buff *skb, u16 length) { @@ -1531,7 +1538,9 @@ static void e1000_consume_page(struct e1000_buffer *bi, struct sk_buff *skb, /** * e1000_clean_jumbo_rx_irq - Send received data up the network stack; legacy - * @adapter: board private structure + * @rx_ring: Rx descriptor ring + * @work_done: output parameter for indicating completed work + * @work_to_do: how many packets we can clean * * the return value indicates whether actual cleaning was done, there * is no guarantee that everything was cleaned @@ -1994,6 +2003,7 @@ static irqreturn_t e1000_intr_msix_rx(int __always_unused irq, void *data) /** * e1000_configure_msix - Configure MSI-X hardware + * @adapter: board private structure * * e1000_configure_msix sets up the hardware to properly * generate MSI-X interrupts. @@ -2072,6 +2082,7 @@ void e1000e_reset_interrupt_capability(struct e1000_adapter *adapter) /** * e1000e_set_interrupt_capability - set MSI or MSI-X if supported + * @adapter: board private structure * * Attempt to configure interrupts using the best available * capabilities of the hardware and kernel. @@ -2127,6 +2138,7 @@ void e1000e_set_interrupt_capability(struct e1000_adapter *adapter) /** * e1000_request_msix - Initialize MSI-X interrupts + * @adapter: board private structure * * e1000_request_msix allocates MSI-X vectors and requests interrupts from the * kernel. @@ -2180,6 +2192,7 @@ static int e1000_request_msix(struct e1000_adapter *adapter) /** * e1000_request_irq - initialize interrupts + * @adapter: board private structure * * Attempts to configure interrupts using the best available * capabilities of the hardware and kernel. @@ -2240,6 +2253,7 @@ static void e1000_free_irq(struct e1000_adapter *adapter) /** * e1000_irq_disable - Mask off interrupt generation on the NIC + * @adapter: board private structure **/ static void e1000_irq_disable(struct e1000_adapter *adapter) { @@ -2262,6 +2276,7 @@ static void e1000_irq_disable(struct e1000_adapter *adapter) /** * e1000_irq_enable - Enable default interrupt generation settings + * @adapter: board private structure **/ static void e1000_irq_enable(struct e1000_adapter *adapter) { @@ -2332,6 +2347,8 @@ void e1000e_release_hw_control(struct e1000_adapter *adapter) /** * e1000_alloc_ring_dma - allocate memory for a ring structure + * @adapter: board private structure + * @ring: ring struct for which to allocate dma **/ static int e1000_alloc_ring_dma(struct e1000_adapter *adapter, struct e1000_ring *ring) @@ -2507,7 +2524,6 @@ void e1000e_free_rx_resources(struct e1000_ring *rx_ring) /** * e1000_update_itr - update the dynamic ITR value based on statistics - * @adapter: pointer to adapter * @itr_setting: current adapter->itr * @packets: the number of packets during this measurement interval * @bytes: the number of bytes during this measurement interval @@ -3049,12 +3065,13 @@ static void e1000_configure_tx(struct e1000_adapter *adapter) } } +#define PAGE_USE_COUNT(S) (((S) >> PAGE_SHIFT) + \ + (((S) & (PAGE_SIZE - 1)) ? 1 : 0)) + /** * e1000_setup_rctl - configure the receive control registers * @adapter: Board private structure **/ -#define PAGE_USE_COUNT(S) (((S) >> PAGE_SHIFT) + \ - (((S) & (PAGE_SIZE - 1)) ? 1 : 0)) static void e1000_setup_rctl(struct e1000_adapter *adapter) { struct e1000_hw *hw = &adapter->hw; @@ -3605,6 +3622,7 @@ s32 e1000e_get_base_timinca(struct e1000_adapter *adapter, u32 *timinca) /** * e1000e_config_hwtstamp - configure the hwtstamp registers and enable/disable * @adapter: board private structure + * @config: timestamp configuration * * Outgoing time stamping can be enabled and disabled. Play nice and * disable it when requested, although it shouldn't cause any overhead @@ -3808,6 +3826,7 @@ void e1000e_power_up_phy(struct e1000_adapter *adapter) /** * e1000_power_down_phy - Power down the PHY + * @adapter: board private structure * * Power down the PHY so no link is implied when interface is down. * The PHY cannot be powered down if management or WoL is active. @@ -3820,6 +3839,7 @@ static void e1000_power_down_phy(struct e1000_adapter *adapter) /** * e1000_flush_tx_ring - remove all descriptors from the tx_ring + * @adapter: board private structure * * We want to clear all pending descriptors from the TX ring. * zeroing happens when the HW reads the regs. We assign the ring itself as @@ -3854,6 +3874,7 @@ static void e1000_flush_tx_ring(struct e1000_adapter *adapter) /** * e1000_flush_rx_ring - remove all descriptors from the rx_ring + * @adapter: board private structure * * Mark all descriptors in the RX ring as consumed and disable the rx ring */ @@ -3886,6 +3907,7 @@ static void e1000_flush_rx_ring(struct e1000_adapter *adapter) /** * e1000_flush_desc_rings - remove all descriptors from the descriptor rings + * @adapter: board private structure * * In i219, the descriptor rings must be emptied before resetting the HW * or before changing the device state to D3 during runtime (runtime PM). @@ -3968,6 +3990,7 @@ static void e1000e_systim_reset(struct e1000_adapter *adapter) /** * e1000e_reset - bring the hardware into a known good state + * @adapter: board private structure * * This function boots the hardware and enables some settings that * require a configuration cycle of the hardware - those cannot be @@ -4847,7 +4870,7 @@ static void e1000e_update_phy_task(struct work_struct *work) /** * e1000_update_phy_info - timre call-back to update PHY info - * @data: pointer to adapter cast into an unsigned long + * @t: pointer to timer_list containing private info adapter * * Need to wait a few seconds after link up to get diagnostic information from * the phy @@ -5187,7 +5210,7 @@ static void e1000e_check_82574_phy_workaround(struct e1000_adapter *adapter) /** * e1000_watchdog - Timer Call-back - * @data: pointer to adapter cast into an unsigned long + * @t: pointer to timer_list containing private info adapter **/ static void e1000_watchdog(struct timer_list *t) { @@ -5972,8 +5995,9 @@ static netdev_tx_t e1000_xmit_frame(struct sk_buff *skb, /** * e1000_tx_timeout - Respond to a Tx Hang * @netdev: network interface device structure + * @txqueue: index of the hung queue (unused) **/ -static void e1000_tx_timeout(struct net_device *netdev, unsigned int txqueue) +static void e1000_tx_timeout(struct net_device *netdev, unsigned int __always_unused txqueue) { struct e1000_adapter *adapter = netdev_priv(netdev); @@ -6174,7 +6198,7 @@ static int e1000_mii_ioctl(struct net_device *netdev, struct ifreq *ifr, /** * e1000e_hwtstamp_ioctl - control hardware time stamping * @netdev: network interface device structure - * @ifreq: interface request + * @ifr: interface request * * Outgoing time stamping can be enabled and disabled. Play nice and * disable it when requested, although it shouldn't cause any overhead diff --git a/drivers/net/ethernet/intel/e1000e/phy.c b/drivers/net/ethernet/intel/e1000e/phy.c index e11c877595fb..bdd9dc163f15 100644 --- a/drivers/net/ethernet/intel/e1000e/phy.c +++ b/drivers/net/ethernet/intel/e1000e/phy.c @@ -2311,6 +2311,7 @@ s32 e1000e_determine_phy_address(struct e1000_hw *hw) /** * e1000_get_phy_addr_for_bm_page - Retrieve PHY page address * @page: page to access + * @reg: register to check * * Returns the phy address for the page requested. **/ @@ -2728,6 +2729,7 @@ void e1000_power_down_phy_copper(struct e1000_hw *hw) * @offset: register offset to be read * @data: pointer to the read data * @locked: semaphore has already been acquired or not + * @page_set: BM_WUC_PAGE already set and access enabled * * Acquires semaphore, if necessary, then reads the PHY register at offset * and stores the retrieved information in data. Release any acquired @@ -2836,6 +2838,7 @@ s32 e1000_read_phy_reg_page_hv(struct e1000_hw *hw, u32 offset, u16 *data) * @offset: register offset to write to * @data: data to write at register offset * @locked: semaphore has already been acquired or not + * @page_set: BM_WUC_PAGE already set and access enabled * * Acquires semaphore, if necessary, then writes the data to PHY register * at the offset. Release any acquired semaphores before exiting. diff --git a/drivers/net/ethernet/intel/e1000e/ptp.c b/drivers/net/ethernet/intel/e1000e/ptp.c index 34b988d70488..8d21bcb427ec 100644 --- a/drivers/net/ethernet/intel/e1000e/ptp.c +++ b/drivers/net/ethernet/intel/e1000e/ptp.c @@ -144,7 +144,7 @@ static int e1000e_phc_get_syncdevicetime(ktime_t *device, /** * e1000e_phc_getsynctime - Reads the current system/device cross timestamp * @ptp: ptp clock structure - * @cts: structure containing timestamp + * @xtstamp: structure containing timestamp * * Read device and system (ART) clock simultaneously and return the scaled * clock values in ns. diff --git a/drivers/net/ethernet/intel/igb/e1000_82575.c b/drivers/net/ethernet/intel/igb/e1000_82575.c index a32391e82762..50863fd87d53 100644 --- a/drivers/net/ethernet/intel/igb/e1000_82575.c +++ b/drivers/net/ethernet/intel/igb/e1000_82575.c @@ -2554,7 +2554,7 @@ static s32 igb_update_nvm_checksum_i350(struct e1000_hw *hw) /** * __igb_access_emi_reg - Read/write EMI register * @hw: pointer to the HW structure - * @addr: EMI address to program + * @address: EMI address to program * @data: pointer to value to read/write from/to the EMI address * @read: boolean flag to indicate read or write **/ @@ -2590,7 +2590,7 @@ s32 igb_read_emi_reg(struct e1000_hw *hw, u16 addr, u16 *data) * igb_set_eee_i350 - Enable/disable EEE support * @hw: pointer to the HW structure * @adv1G: boolean flag enabling 1G EEE advertisement - * @adv100m: boolean flag enabling 100M EEE advertisement + * @adv100M: boolean flag enabling 100M EEE advertisement * * Enable/disable EEE based on setting in dev_spec structure. * @@ -2646,7 +2646,7 @@ s32 igb_set_eee_i350(struct e1000_hw *hw, bool adv1G, bool adv100M) * igb_set_eee_i354 - Enable/disable EEE support * @hw: pointer to the HW structure * @adv1G: boolean flag enabling 1G EEE advertisement - * @adv100m: boolean flag enabling 100M EEE advertisement + * @adv100M: boolean flag enabling 100M EEE advertisement * * Enable/disable EEE legacy mode based on setting in dev_spec structure. * diff --git a/drivers/net/ethernet/intel/igb/e1000_i210.c b/drivers/net/ethernet/intel/igb/e1000_i210.c index c393cb2c0f16..9265901455cd 100644 --- a/drivers/net/ethernet/intel/igb/e1000_i210.c +++ b/drivers/net/ethernet/intel/igb/e1000_i210.c @@ -357,13 +357,14 @@ static s32 igb_read_invm_word_i210(struct e1000_hw *hw, u8 address, u16 *data) /** * igb_read_invm_i210 - Read invm wrapper function for I210/I211 * @hw: pointer to the HW structure - * @words: number of words to read + * @offset: offset to read from + * @words: number of words to read (unused) * @data: pointer to the data read * * Wrapper function to return data formerly found in the NVM. **/ static s32 igb_read_invm_i210(struct e1000_hw *hw, u16 offset, - u16 words __always_unused, u16 *data) + u16 __always_unused words, u16 *data) { s32 ret_val = 0; diff --git a/drivers/net/ethernet/intel/igb/e1000_mac.c b/drivers/net/ethernet/intel/igb/e1000_mac.c index 3254737c07a3..fd8eb2f9ab9d 100644 --- a/drivers/net/ethernet/intel/igb/e1000_mac.c +++ b/drivers/net/ethernet/intel/igb/e1000_mac.c @@ -166,6 +166,7 @@ static s32 igb_find_vlvf_slot(struct e1000_hw *hw, u32 vlan, bool vlvf_bypass) * @vlan: VLAN id to add or remove * @vind: VMDq output index that maps queue to VLAN id * @vlan_on: if true add filter, if false remove + * @vlvf_bypass: skip VLVF if no match is found * * Sets or clears a bit in the VLAN filter table array based on VLAN id * and if we are adding or removing the filter diff --git a/drivers/net/ethernet/intel/igb/e1000_mbx.c b/drivers/net/ethernet/intel/igb/e1000_mbx.c index 46debd991bfe..33cceb77e960 100644 --- a/drivers/net/ethernet/intel/igb/e1000_mbx.c +++ b/drivers/net/ethernet/intel/igb/e1000_mbx.c @@ -9,6 +9,7 @@ * @msg: The message buffer * @size: Length of buffer * @mbx_id: id of mailbox to read + * @unlock: skip locking or not * * returns SUCCESS if it successfully read message from buffer **/ diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index e1e37d0b7703..44157fcd3cf7 100644 --- a/drivers/net/ethernet/intel/igb/igb_main.c +++ b/drivers/net/ethernet/intel/igb/igb_main.c @@ -549,8 +549,7 @@ static void igb_dump(struct igb_adapter *adapter) /** * igb_get_i2c_data - Reads the I2C SDA data bit - * @hw: pointer to hardware structure - * @i2cctl: Current value of I2CCTL register + * @data: opaque pointer to adapter struct * * Returns the I2C data bit value **/ @@ -3868,6 +3867,7 @@ static int igb_sw_init(struct igb_adapter *adapter) /** * igb_open - Called when a network interface is made active * @netdev: network interface device structure + * @resuming: indicates whether we are in a resume call * * Returns 0 on success, negative value on failure * @@ -3985,6 +3985,7 @@ int igb_open(struct net_device *netdev) /** * igb_close - Disables a network interface * @netdev: network interface device structure + * @suspending: indicates we are in a suspend call * * Returns 0, this is not allowed to fail * @@ -5219,7 +5220,7 @@ static void igb_check_lvmmc(struct igb_adapter *adapter) /** * igb_watchdog - Timer Call-back - * @data: pointer to adapter cast into an unsigned long + * @t: pointer to timer_list containing our private info pointer **/ static void igb_watchdog(struct timer_list *t) { @@ -6192,8 +6193,9 @@ static netdev_tx_t igb_xmit_frame(struct sk_buff *skb, /** * igb_tx_timeout - Respond to a Tx Hang * @netdev: network interface device structure + * @txqueue: number of the Tx queue that hung (unused) **/ -static void igb_tx_timeout(struct net_device *netdev, unsigned int txqueue) +static void igb_tx_timeout(struct net_device *netdev, unsigned int __always_unused txqueue) { struct igb_adapter *adapter = netdev_priv(netdev); struct e1000_hw *hw = &adapter->hw; @@ -8181,7 +8183,6 @@ static inline void igb_rx_hash(struct igb_ring *ring, * igb_is_non_eop - process handling of non-EOP buffers * @rx_ring: Rx ring being processed * @rx_desc: Rx descriptor for current buffer - * @skb: current socket buffer containing buffer in progress * * This function updates next to clean. If the buffer is an EOP buffer * this function exits returning false, otherwise it will place the @@ -8460,8 +8461,9 @@ static bool igb_alloc_mapped_page(struct igb_ring *rx_ring, } /** - * igb_alloc_rx_buffers - Replace used receive buffers; packet split - * @adapter: address of board private structure + * igb_alloc_rx_buffers - Replace used receive buffers + * @rx_ring: rx descriptor ring to allocate new receive buffers + * @cleaned_count: count of buffers to allocate **/ void igb_alloc_rx_buffers(struct igb_ring *rx_ring, u16 cleaned_count) { @@ -8530,9 +8532,9 @@ void igb_alloc_rx_buffers(struct igb_ring *rx_ring, u16 cleaned_count) /** * igb_mii_ioctl - - * @netdev: - * @ifreq: - * @cmd: + * @netdev: pointer to netdev struct + * @ifr: interface structure + * @cmd: ioctl command to execute **/ static int igb_mii_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd) { @@ -8560,9 +8562,9 @@ static int igb_mii_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd) /** * igb_ioctl - - * @netdev: - * @ifreq: - * @cmd: + * @netdev: pointer to netdev struct + * @ifr: interface structure + * @cmd: ioctl command to execute **/ static int igb_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd) { diff --git a/drivers/net/ethernet/intel/igb/igb_ptp.c b/drivers/net/ethernet/intel/igb/igb_ptp.c index 490368d3d03c..7cc5428c3b3d 100644 --- a/drivers/net/ethernet/intel/igb/igb_ptp.c +++ b/drivers/net/ethernet/intel/igb/igb_ptp.c @@ -957,8 +957,8 @@ void igb_ptp_rx_rgtstamp(struct igb_q_vector *q_vector, /** * igb_ptp_get_ts_config - get hardware time stamping config - * @netdev: - * @ifreq: + * @netdev: netdev struct + * @ifr: interface struct * * Get the hwtstamp_config settings to return to the user. Rather than attempt * to deconstruct the settings from the registers, just return a shadow copy @@ -1141,8 +1141,8 @@ static int igb_ptp_set_timestamp_mode(struct igb_adapter *adapter, /** * igb_ptp_set_ts_config - set hardware time stamping config - * @netdev: - * @ifreq: + * @netdev: netdev struct + * @ifr: interface struct * **/ int igb_ptp_set_ts_config(struct net_device *netdev, struct ifreq *ifr) diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c b/drivers/net/ethernet/intel/igbvf/netdev.c index 19269f5d52bc..ee9f8c1dca83 100644 --- a/drivers/net/ethernet/intel/igbvf/netdev.c +++ b/drivers/net/ethernet/intel/igbvf/netdev.c @@ -61,7 +61,7 @@ static const struct igbvf_info *igbvf_info_tbl[] = { /** * igbvf_desc_unused - calculate if we have unused descriptors - * @rx_ring: address of receive ring structure + * @ring: address of receive ring structure **/ static int igbvf_desc_unused(struct igbvf_ring *ring) { @@ -74,6 +74,8 @@ static int igbvf_desc_unused(struct igbvf_ring *ring) /** * igbvf_receive_skb - helper function to handle Rx indications * @adapter: board private structure + * @netdev: pointer to netdev struct + * @skb: skb to indicate to stack * @status: descriptor status field as written by hardware * @vlan: descriptor vlan field as written by hardware (no le/be conversion) * @skb: pointer to sk_buff to be indicated to stack @@ -233,6 +235,8 @@ static void igbvf_alloc_rx_buffers(struct igbvf_ring *rx_ring, /** * igbvf_clean_rx_irq - Send received data up the network stack; legacy * @adapter: board private structure + * @work_done: output parameter used to indicate completed work + * @work_to_do: input parameter setting limit of work * * the return value indicates whether actual cleaning was done, there * is no guarantee that everything was cleaned @@ -406,6 +410,7 @@ static void igbvf_put_txbuf(struct igbvf_adapter *adapter, /** * igbvf_setup_tx_resources - allocate Tx resources (Descriptors) * @adapter: board private structure + * @tx_ring: ring being initialized * * Return 0 on success, negative on failure **/ @@ -444,6 +449,7 @@ int igbvf_setup_tx_resources(struct igbvf_adapter *adapter, /** * igbvf_setup_rx_resources - allocate Rx resources (Descriptors) * @adapter: board private structure + * @rx_ring: ring being initialized * * Returns 0 on success, negative on failure **/ @@ -540,7 +546,7 @@ void igbvf_free_tx_resources(struct igbvf_ring *tx_ring) /** * igbvf_clean_rx_ring - Free Rx Buffers per Queue - * @adapter: board private structure + * @rx_ring: ring structure pointer to free buffers from **/ static void igbvf_clean_rx_ring(struct igbvf_ring *rx_ring) { @@ -760,7 +766,7 @@ static void igbvf_set_itr(struct igbvf_adapter *adapter) /** * igbvf_clean_tx_irq - Reclaim resources after transmit completes - * @adapter: board private structure + * @tx_ring: ring structure to clean descriptors from * * returns true if ring is completely cleaned **/ @@ -1891,7 +1897,7 @@ static bool igbvf_has_link(struct igbvf_adapter *adapter) /** * igbvf_watchdog - Timer Call-back - * @data: pointer to adapter cast into an unsigned long + * @t: timer list pointer containing private struct **/ static void igbvf_watchdog(struct timer_list *t) { @@ -2372,8 +2378,9 @@ static netdev_tx_t igbvf_xmit_frame(struct sk_buff *skb, /** * igbvf_tx_timeout - Respond to a Tx Hang * @netdev: network interface device structure + * @txqueue: queue timing out (unused) **/ -static void igbvf_tx_timeout(struct net_device *netdev, unsigned int txqueue) +static void igbvf_tx_timeout(struct net_device *netdev, unsigned int __always_unused txqueue) { struct igbvf_adapter *adapter = netdev_priv(netdev); diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c index c6968fdb6caa..3183150c7995 100644 --- a/drivers/net/ethernet/intel/igc/igc_main.c +++ b/drivers/net/ethernet/intel/igc/igc_main.c @@ -4653,7 +4653,7 @@ int igc_close(struct net_device *netdev) /** * igc_ioctl - Access the hwtstamp interface * @netdev: network interface device structure - * @ifreq: interface request data + * @ifr: interface request data * @cmd: ioctl command **/ static int igc_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd) diff --git a/drivers/net/ethernet/intel/igc/igc_ptp.c b/drivers/net/ethernet/intel/igc/igc_ptp.c index 36c999250fcc..7aee56346656 100644 --- a/drivers/net/ethernet/intel/igc/igc_ptp.c +++ b/drivers/net/ethernet/intel/igc/igc_ptp.c @@ -420,7 +420,7 @@ static void igc_ptp_tx_work(struct work_struct *work) /** * igc_ptp_set_ts_config - set hardware time stamping config * @netdev: network interface device structure - * @ifreq: interface request data + * @ifr: interface request data * **/ int igc_ptp_set_ts_config(struct net_device *netdev, struct ifreq *ifr) @@ -447,7 +447,7 @@ int igc_ptp_set_ts_config(struct net_device *netdev, struct ifreq *ifr) /** * igc_ptp_get_ts_config - get hardware time stamping config * @netdev: network interface device structure - * @ifreq: interface request data + * @ifr: interface request data * * Get the hwtstamp_config settings to return to the user. Rather than attempt * to deconstruct the settings from the registers, just return a shadow copy diff --git a/drivers/net/ethernet/intel/ixgb/ixgb_hw.c b/drivers/net/ethernet/intel/ixgb/ixgb_hw.c index cbaa933ef30d..a430871d1c27 100644 --- a/drivers/net/ethernet/intel/ixgb/ixgb_hw.c +++ b/drivers/net/ethernet/intel/ixgb/ixgb_hw.c @@ -98,7 +98,6 @@ bool ixgb_adapter_stop(struct ixgb_hw *hw) { u32 ctrl_reg; - u32 icr_reg; ENTER(); @@ -142,7 +141,7 @@ ixgb_adapter_stop(struct ixgb_hw *hw) IXGB_WRITE_REG(hw, IMC, 0xffffffff); /* Clear any pending interrupt events. */ - icr_reg = IXGB_READ_REG(hw, ICR); + IXGB_READ_REG(hw, ICR); return ctrl_reg & IXGB_CTRL0_RST; } @@ -274,7 +273,6 @@ bool ixgb_init_hw(struct ixgb_hw *hw) { u32 i; - u32 ctrl_reg; bool status; ENTER(); @@ -286,7 +284,7 @@ ixgb_init_hw(struct ixgb_hw *hw) */ pr_debug("Issuing a global reset to MAC\n"); - ctrl_reg = ixgb_mac_reset(hw); + ixgb_mac_reset(hw); pr_debug("Issuing an EE reset to MAC\n"); #ifdef HP_ZX1 @@ -949,8 +947,6 @@ bool ixgb_check_for_bad_link(struct ixgb_hw *hw) static void ixgb_clear_hw_cntrs(struct ixgb_hw *hw) { - volatile u32 temp_reg; - ENTER(); /* if we are stopped or resetting exit gracefully */ @@ -959,66 +955,66 @@ ixgb_clear_hw_cntrs(struct ixgb_hw *hw) return; } - temp_reg = IXGB_READ_REG(hw, TPRL); - temp_reg = IXGB_READ_REG(hw, TPRH); - temp_reg = IXGB_READ_REG(hw, GPRCL); - temp_reg = IXGB_READ_REG(hw, GPRCH); - temp_reg = IXGB_READ_REG(hw, BPRCL); - temp_reg = IXGB_READ_REG(hw, BPRCH); - temp_reg = IXGB_READ_REG(hw, MPRCL); - temp_reg = IXGB_READ_REG(hw, MPRCH); - temp_reg = IXGB_READ_REG(hw, UPRCL); - temp_reg = IXGB_READ_REG(hw, UPRCH); - temp_reg = IXGB_READ_REG(hw, VPRCL); - temp_reg = IXGB_READ_REG(hw, VPRCH); - temp_reg = IXGB_READ_REG(hw, JPRCL); - temp_reg = IXGB_READ_REG(hw, JPRCH); - temp_reg = IXGB_READ_REG(hw, GORCL); - temp_reg = IXGB_READ_REG(hw, GORCH); - temp_reg = IXGB_READ_REG(hw, TORL); - temp_reg = IXGB_READ_REG(hw, TORH); - temp_reg = IXGB_READ_REG(hw, RNBC); - temp_reg = IXGB_READ_REG(hw, RUC); - temp_reg = IXGB_READ_REG(hw, ROC); - temp_reg = IXGB_READ_REG(hw, RLEC); - temp_reg = IXGB_READ_REG(hw, CRCERRS); - temp_reg = IXGB_READ_REG(hw, ICBC); - temp_reg = IXGB_READ_REG(hw, ECBC); - temp_reg = IXGB_READ_REG(hw, MPC); - temp_reg = IXGB_READ_REG(hw, TPTL); - temp_reg = IXGB_READ_REG(hw, TPTH); - temp_reg = IXGB_READ_REG(hw, GPTCL); - temp_reg = IXGB_READ_REG(hw, GPTCH); - temp_reg = IXGB_READ_REG(hw, BPTCL); - temp_reg = IXGB_READ_REG(hw, BPTCH); - temp_reg = IXGB_READ_REG(hw, MPTCL); - temp_reg = IXGB_READ_REG(hw, MPTCH); - temp_reg = IXGB_READ_REG(hw, UPTCL); - temp_reg = IXGB_READ_REG(hw, UPTCH); - temp_reg = IXGB_READ_REG(hw, VPTCL); - temp_reg = IXGB_READ_REG(hw, VPTCH); - temp_reg = IXGB_READ_REG(hw, JPTCL); - temp_reg = IXGB_READ_REG(hw, JPTCH); - temp_reg = IXGB_READ_REG(hw, GOTCL); - temp_reg = IXGB_READ_REG(hw, GOTCH); - temp_reg = IXGB_READ_REG(hw, TOTL); - temp_reg = IXGB_READ_REG(hw, TOTH); - temp_reg = IXGB_READ_REG(hw, DC); - temp_reg = IXGB_READ_REG(hw, PLT64C); - temp_reg = IXGB_READ_REG(hw, TSCTC); - temp_reg = IXGB_READ_REG(hw, TSCTFC); - temp_reg = IXGB_READ_REG(hw, IBIC); - temp_reg = IXGB_READ_REG(hw, RFC); - temp_reg = IXGB_READ_REG(hw, LFC); - temp_reg = IXGB_READ_REG(hw, PFRC); - temp_reg = IXGB_READ_REG(hw, PFTC); - temp_reg = IXGB_READ_REG(hw, MCFRC); - temp_reg = IXGB_READ_REG(hw, MCFTC); - temp_reg = IXGB_READ_REG(hw, XONRXC); - temp_reg = IXGB_READ_REG(hw, XONTXC); - temp_reg = IXGB_READ_REG(hw, XOFFRXC); - temp_reg = IXGB_READ_REG(hw, XOFFTXC); - temp_reg = IXGB_READ_REG(hw, RJC); + IXGB_READ_REG(hw, TPRL); + IXGB_READ_REG(hw, TPRH); + IXGB_READ_REG(hw, GPRCL); + IXGB_READ_REG(hw, GPRCH); + IXGB_READ_REG(hw, BPRCL); + IXGB_READ_REG(hw, BPRCH); + IXGB_READ_REG(hw, MPRCL); + IXGB_READ_REG(hw, MPRCH); + IXGB_READ_REG(hw, UPRCL); + IXGB_READ_REG(hw, UPRCH); + IXGB_READ_REG(hw, VPRCL); + IXGB_READ_REG(hw, VPRCH); + IXGB_READ_REG(hw, JPRCL); + IXGB_READ_REG(hw, JPRCH); + IXGB_READ_REG(hw, GORCL); + IXGB_READ_REG(hw, GORCH); + IXGB_READ_REG(hw, TORL); + IXGB_READ_REG(hw, TORH); + IXGB_READ_REG(hw, RNBC); + IXGB_READ_REG(hw, RUC); + IXGB_READ_REG(hw, ROC); + IXGB_READ_REG(hw, RLEC); + IXGB_READ_REG(hw, CRCERRS); + IXGB_READ_REG(hw, ICBC); + IXGB_READ_REG(hw, ECBC); + IXGB_READ_REG(hw, MPC); + IXGB_READ_REG(hw, TPTL); + IXGB_READ_REG(hw, TPTH); + IXGB_READ_REG(hw, GPTCL); + IXGB_READ_REG(hw, GPTCH); + IXGB_READ_REG(hw, BPTCL); + IXGB_READ_REG(hw, BPTCH); + IXGB_READ_REG(hw, MPTCL); + IXGB_READ_REG(hw, MPTCH); + IXGB_READ_REG(hw, UPTCL); + IXGB_READ_REG(hw, UPTCH); + IXGB_READ_REG(hw, VPTCL); + IXGB_READ_REG(hw, VPTCH); + IXGB_READ_REG(hw, JPTCL); + IXGB_READ_REG(hw, JPTCH); + IXGB_READ_REG(hw, GOTCL); + IXGB_READ_REG(hw, GOTCH); + IXGB_READ_REG(hw, TOTL); + IXGB_READ_REG(hw, TOTH); + IXGB_READ_REG(hw, DC); + IXGB_READ_REG(hw, PLT64C); + IXGB_READ_REG(hw, TSCTC); + IXGB_READ_REG(hw, TSCTFC); + IXGB_READ_REG(hw, IBIC); + IXGB_READ_REG(hw, RFC); + IXGB_READ_REG(hw, LFC); + IXGB_READ_REG(hw, PFRC); + IXGB_READ_REG(hw, PFTC); + IXGB_READ_REG(hw, MCFRC); + IXGB_READ_REG(hw, MCFTC); + IXGB_READ_REG(hw, XONRXC); + IXGB_READ_REG(hw, XONTXC); + IXGB_READ_REG(hw, XOFFRXC); + IXGB_READ_REG(hw, XOFFTXC); + IXGB_READ_REG(hw, RJC); } /****************************************************************************** @@ -1161,18 +1157,13 @@ static void ixgb_optics_reset(struct ixgb_hw *hw) { if (hw->phy_type == ixgb_phy_type_txn17401) { - u16 mdio_reg; - ixgb_write_phy_reg(hw, MDIO_CTRL1, IXGB_PHY_ADDRESS, MDIO_MMD_PMAPMD, MDIO_CTRL1_RESET); - mdio_reg = ixgb_read_phy_reg(hw, - MDIO_CTRL1, - IXGB_PHY_ADDRESS, - MDIO_MMD_PMAPMD); + ixgb_read_phy_reg(hw, MDIO_CTRL1, IXGB_PHY_ADDRESS, MDIO_MMD_PMAPMD); } } diff --git a/drivers/net/ethernet/intel/ixgb/ixgb_main.c b/drivers/net/ethernet/intel/ixgb/ixgb_main.c index 048351cf0e4a..1588376d4c67 100644 --- a/drivers/net/ethernet/intel/ixgb/ixgb_main.c +++ b/drivers/net/ethernet/intel/ixgb/ixgb_main.c @@ -1109,7 +1109,7 @@ ixgb_set_multi(struct net_device *netdev) /** * ixgb_watchdog - Timer Call-back - * @data: pointer to netdev cast into an unsigned long + * @t: pointer to timer_list containing our private info pointer **/ static void @@ -1531,10 +1531,11 @@ ixgb_xmit_frame(struct sk_buff *skb, struct net_device *netdev) /** * ixgb_tx_timeout - Respond to a Tx Hang * @netdev: network interface device structure + * @txqueue: queue hanging (unused) **/ static void -ixgb_tx_timeout(struct net_device *netdev, unsigned int txqueue) +ixgb_tx_timeout(struct net_device *netdev, unsigned int __always_unused txqueue) { struct ixgb_adapter *adapter = netdev_priv(netdev); @@ -1746,7 +1747,8 @@ ixgb_intr(int irq, void *data) /** * ixgb_clean - NAPI Rx polling callback - * @adapter: board private structure + * @napi: napi struct pointer + * @budget: max number of receives to clean **/ static int @@ -1865,7 +1867,7 @@ ixgb_clean_tx_irq(struct ixgb_adapter *adapter) * ixgb_rx_checksum - Receive Checksum Offload for 82597. * @adapter: board private structure * @rx_desc: receive descriptor - * @sk_buff: socket buffer with received data + * @skb: socket buffer with received data **/ static void @@ -1923,6 +1925,8 @@ static void ixgb_check_copybreak(struct napi_struct *napi, /** * ixgb_clean_rx_irq - Send received data up the network stack, * @adapter: board private structure + * @work_done: output pointer to amount of packets cleaned + * @work_to_do: how much work we can complete **/ static bool @@ -2042,6 +2046,7 @@ ixgb_clean_rx_irq(struct ixgb_adapter *adapter, int *work_done, int work_to_do) /** * ixgb_alloc_rx_buffers - Replace used receive buffers * @adapter: address of board private structure + * @cleaned_count: how many buffers to allocate **/ static void @@ -2211,7 +2216,7 @@ static pci_ers_result_t ixgb_io_error_detected(struct pci_dev *pdev, /** * ixgb_io_slot_reset - called after the pci bus has been reset. - * @pdev pointer to pci device with error + * @pdev: pointer to pci device with error * * This callback is called after the PCI bus has been reset. * Basically, this tries to restart the card from scratch. @@ -2259,7 +2264,7 @@ static pci_ers_result_t ixgb_io_slot_reset(struct pci_dev *pdev) /** * ixgb_io_resume - called when its OK to resume normal operations - * @pdev pointer to pci device with error + * @pdev: pointer to pci device with error * * The error recovery driver tells us that its OK to resume * normal operation. Implementation resembles the second-half diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c index 50afec43e001..ba54c728aef2 100644 --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c @@ -246,8 +246,9 @@ static void ixgbevf_tx_timeout_reset(struct ixgbevf_adapter *adapter) /** * ixgbevf_tx_timeout - Respond to a Tx Hang * @netdev: network interface device structure + * @txqueue: transmit queue hanging (unused) **/ -static void ixgbevf_tx_timeout(struct net_device *netdev, unsigned int txqueue) +static void ixgbevf_tx_timeout(struct net_device *netdev, unsigned int __always_unused txqueue) { struct ixgbevf_adapter *adapter = netdev_priv(netdev); -- 2.27.0 ^ permalink raw reply related [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 05/11] intel-ethernet: make W=1 build cleanly @ 2020-09-11 1:23 ` Jesse Brandeburg 0 siblings, 0 replies; 68+ messages in thread From: Jesse Brandeburg @ 2020-09-11 1:23 UTC (permalink / raw) To: intel-wired-lan This takes care of all of the trivial W=1 fixes in the Intel Ethernet drivers, which allows developers and maintainers to build more of the networking tree with more complete warning checks. Almost all of the changes were trivial comment updates on function headers, but some of the changes were for variables that were storing a return value from a register read, where the return value wasn't used. Those conversions to remove the lvalue of the assignment should be safe because the readl memory mapped reads are marked volatile and should not be optimized out without an lvalue (I suspect a very long time ago this wasn't guaranteed as it is today). Inspired by Lee Jones' series of wireless work to do the same. Compile tested only. Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> --- drivers/net/ethernet/intel/e100.c | 8 +- drivers/net/ethernet/intel/e1000/e1000_hw.c | 147 ++++++++---------- drivers/net/ethernet/intel/e1000/e1000_main.c | 39 +++-- .../net/ethernet/intel/e1000e/80003es2lan.c | 1 - drivers/net/ethernet/intel/e1000e/ich8lan.c | 16 +- drivers/net/ethernet/intel/e1000e/netdev.c | 50 ++++-- drivers/net/ethernet/intel/e1000e/phy.c | 3 + drivers/net/ethernet/intel/e1000e/ptp.c | 2 +- drivers/net/ethernet/intel/igb/e1000_82575.c | 6 +- drivers/net/ethernet/intel/igb/e1000_i210.c | 5 +- drivers/net/ethernet/intel/igb/e1000_mac.c | 1 + drivers/net/ethernet/intel/igb/e1000_mbx.c | 1 + drivers/net/ethernet/intel/igb/igb_main.c | 28 ++-- drivers/net/ethernet/intel/igb/igb_ptp.c | 8 +- drivers/net/ethernet/intel/igbvf/netdev.c | 17 +- drivers/net/ethernet/intel/igc/igc_main.c | 2 +- drivers/net/ethernet/intel/igc/igc_ptp.c | 4 +- drivers/net/ethernet/intel/ixgb/ixgb_hw.c | 135 ++++++++-------- drivers/net/ethernet/intel/ixgb/ixgb_main.c | 17 +- .../net/ethernet/intel/ixgbevf/ixgbevf_main.c | 3 +- 20 files changed, 265 insertions(+), 228 deletions(-) diff --git a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/intel/e100.c index 36da059388dc..76bb77b4607a 100644 --- a/drivers/net/ethernet/intel/e100.c +++ b/drivers/net/ethernet/intel/e100.c @@ -384,7 +384,7 @@ enum cb_status { cb_ok = 0x2000, }; -/** +/* * cb_command - Command Block flags * @cb_tx_nc: 0: controller does CRC (normal), 1: CRC from skb memory */ @@ -2593,7 +2593,7 @@ static void e100_diag_test(struct net_device *netdev, { struct ethtool_cmd cmd; struct nic *nic = netdev_priv(netdev); - int i, err; + int i; memset(data, 0, E100_TEST_LEN * sizeof(u64)); data[0] = !mii_link_ok(&nic->mii); @@ -2601,7 +2601,7 @@ static void e100_diag_test(struct net_device *netdev, if (test->flags & ETH_TEST_FL_OFFLINE) { /* save speed, duplex & autoneg settings */ - err = mii_ethtool_gset(&nic->mii, &cmd); + mii_ethtool_gset(&nic->mii, &cmd); if (netif_running(netdev)) e100_down(nic); @@ -2610,7 +2610,7 @@ static void e100_diag_test(struct net_device *netdev, data[4] = e100_loopback_test(nic, lb_phy); /* restore speed, duplex & autoneg settings */ - err = mii_ethtool_sset(&nic->mii, &cmd); + mii_ethtool_sset(&nic->mii, &cmd); if (netif_running(netdev)) e100_up(nic); diff --git a/drivers/net/ethernet/intel/e1000/e1000_hw.c b/drivers/net/ethernet/intel/e1000/e1000_hw.c index 4e7a0810eaeb..2120dacfd55c 100644 --- a/drivers/net/ethernet/intel/e1000/e1000_hw.c +++ b/drivers/net/ethernet/intel/e1000/e1000_hw.c @@ -139,6 +139,7 @@ static void e1000_phy_init_script(struct e1000_hw *hw) * at the end of this routine. */ ret_val = e1000_read_phy_reg(hw, 0x2F5B, &phy_saved_data); + e_dbg("Reading PHY register 0x2F5B failed: %d\n", ret_val); /* Disabled the PHY transmitter */ e1000_write_phy_reg(hw, 0x2F5B, 0x0003); @@ -377,7 +378,6 @@ s32 e1000_reset_hw(struct e1000_hw *hw) { u32 ctrl; u32 ctrl_ext; - u32 icr; u32 manc; u32 led_ctrl; s32 ret_val; @@ -502,7 +502,7 @@ s32 e1000_reset_hw(struct e1000_hw *hw) ew32(IMC, 0xffffffff); /* Clear any pending interrupt events. */ - icr = er32(ICR); + er32(ICR); /* If MWI was previously enabled, reenable it. */ if (hw->mac_type == e1000_82542_rev2_0) { @@ -1897,7 +1897,6 @@ void e1000_config_collision_dist(struct e1000_hw *hw) /** * e1000_config_mac_to_phy - sync phy and mac settings * @hw: Struct containing variables accessed by shared code - * @mii_reg: data to write to the MII control register * * Sets MAC speed and duplex settings to reflect the those in the PHY * The contents of the PHY register containing the needed information need to @@ -2370,16 +2369,13 @@ static s32 e1000_check_for_serdes_link_generic(struct e1000_hw *hw) */ s32 e1000_check_for_link(struct e1000_hw *hw) { - u32 rxcw = 0; - u32 ctrl; u32 status; u32 rctl; u32 icr; - u32 signal = 0; s32 ret_val; u16 phy_data; - ctrl = er32(CTRL); + er32(CTRL); status = er32(STATUS); /* On adapters with a MAC newer than 82544, SW Definable pin 1 will be @@ -2388,12 +2384,9 @@ s32 e1000_check_for_link(struct e1000_hw *hw) */ if ((hw->media_type == e1000_media_type_fiber) || (hw->media_type == e1000_media_type_internal_serdes)) { - rxcw = er32(RXCW); + er32(RXCW); if (hw->media_type == e1000_media_type_fiber) { - signal = - (hw->mac_type > - e1000_82544) ? E1000_CTRL_SWDPIN1 : 0; if (status & E1000_STATUS_LU) hw->get_link_status = false; } @@ -2922,7 +2915,7 @@ static s32 e1000_read_phy_reg_ex(struct e1000_hw *hw, u32 reg_addr, * * @hw: Struct containing variables accessed by shared code * @reg_addr: address of the PHY register to write - * @data: data to write to the PHY + * @phy_data: data to write to the PHY * * Writes a value to a PHY register */ @@ -4675,78 +4668,76 @@ s32 e1000_led_off(struct e1000_hw *hw) */ static void e1000_clear_hw_cntrs(struct e1000_hw *hw) { - volatile u32 temp; - - temp = er32(CRCERRS); - temp = er32(SYMERRS); - temp = er32(MPC); - temp = er32(SCC); - temp = er32(ECOL); - temp = er32(MCC); - temp = er32(LATECOL); - temp = er32(COLC); - temp = er32(DC); - temp = er32(SEC); - temp = er32(RLEC); - temp = er32(XONRXC); - temp = er32(XONTXC); - temp = er32(XOFFRXC); - temp = er32(XOFFTXC); - temp = er32(FCRUC); - - temp = er32(PRC64); - temp = er32(PRC127); - temp = er32(PRC255); - temp = er32(PRC511); - temp = er32(PRC1023); - temp = er32(PRC1522); - - temp = er32(GPRC); - temp = er32(BPRC); - temp = er32(MPRC); - temp = er32(GPTC); - temp = er32(GORCL); - temp = er32(GORCH); - temp = er32(GOTCL); - temp = er32(GOTCH); - temp = er32(RNBC); - temp = er32(RUC); - temp = er32(RFC); - temp = er32(ROC); - temp = er32(RJC); - temp = er32(TORL); - temp = er32(TORH); - temp = er32(TOTL); - temp = er32(TOTH); - temp = er32(TPR); - temp = er32(TPT); - - temp = er32(PTC64); - temp = er32(PTC127); - temp = er32(PTC255); - temp = er32(PTC511); - temp = er32(PTC1023); - temp = er32(PTC1522); - - temp = er32(MPTC); - temp = er32(BPTC); + er32(CRCERRS); + er32(SYMERRS); + er32(MPC); + er32(SCC); + er32(ECOL); + er32(MCC); + er32(LATECOL); + er32(COLC); + er32(DC); + er32(SEC); + er32(RLEC); + er32(XONRXC); + er32(XONTXC); + er32(XOFFRXC); + er32(XOFFTXC); + er32(FCRUC); + + er32(PRC64); + er32(PRC127); + er32(PRC255); + er32(PRC511); + er32(PRC1023); + er32(PRC1522); + + er32(GPRC); + er32(BPRC); + er32(MPRC); + er32(GPTC); + er32(GORCL); + er32(GORCH); + er32(GOTCL); + er32(GOTCH); + er32(RNBC); + er32(RUC); + er32(RFC); + er32(ROC); + er32(RJC); + er32(TORL); + er32(TORH); + er32(TOTL); + er32(TOTH); + er32(TPR); + er32(TPT); + + er32(PTC64); + er32(PTC127); + er32(PTC255); + er32(PTC511); + er32(PTC1023); + er32(PTC1522); + + er32(MPTC); + er32(BPTC); if (hw->mac_type < e1000_82543) return; - temp = er32(ALGNERRC); - temp = er32(RXERRC); - temp = er32(TNCRS); - temp = er32(CEXTERR); - temp = er32(TSCTC); - temp = er32(TSCTFC); + er32(ALGNERRC); + er32(RXERRC); + er32(TNCRS); + er32(CEXTERR); + er32(TSCTC); + er32(TSCTFC); if (hw->mac_type <= e1000_82544) return; - temp = er32(MGTPRC); - temp = er32(MGTPDC); - temp = er32(MGTPTC); + er32(MGTPRC); + er32(MGTPDC); + er32(MGTPTC); } /** @@ -4778,8 +4769,6 @@ void e1000_reset_adaptive(struct e1000_hw *hw) /** * e1000_update_adaptive - update adaptive IFS * @hw: Struct containing variables accessed by shared code - * @tx_packets: Number of transmits since last callback - * @total_collisions: Number of collisions since last callback * * Called during the callback/watchdog routine to update IFS value based on * the ratio of transmits to collisions. @@ -5064,8 +5053,6 @@ static s32 e1000_check_polarity(struct e1000_hw *hw, /** * e1000_check_downshift - Check if Downshift occurred * @hw: Struct containing variables accessed by shared code - * @downshift: output parameter : 0 - No Downshift occurred. - * 1 - Downshift occurred. * * returns: - E1000_ERR_XXX * E1000_SUCCESS diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c index 1e6ec081fd9d..906591614553 100644 --- a/drivers/net/ethernet/intel/e1000/e1000_main.c +++ b/drivers/net/ethernet/intel/e1000/e1000_main.c @@ -199,8 +199,10 @@ module_param(debug, int, 0); MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)"); /** - * e1000_get_hw_dev - return device - * used by hardware layer to print debugging information + * e1000_get_hw_dev - helper function for getting netdev + * @hw: pointer to HW struct + * + * return device used by hardware layer to print debugging information * **/ struct net_device *e1000_get_hw_dev(struct e1000_hw *hw) @@ -354,7 +356,7 @@ static void e1000_release_manageability(struct e1000_adapter *adapter) /** * e1000_configure - configure the hardware for RX and TX - * @adapter = private board structure + * @adapter: private board structure **/ static void e1000_configure(struct e1000_adapter *adapter) { @@ -3489,8 +3491,9 @@ static void e1000_dump(struct e1000_adapter *adapter) /** * e1000_tx_timeout - Respond to a Tx Hang * @netdev: network interface device structure + * @txqueue: number of the Tx queue that hung (unused) **/ -static void e1000_tx_timeout(struct net_device *netdev, unsigned int txqueue) +static void e1000_tx_timeout(struct net_device *netdev, unsigned int __always_unused txqueue) { struct e1000_adapter *adapter = netdev_priv(netdev); @@ -3787,7 +3790,8 @@ static irqreturn_t e1000_intr(int irq, void *data) /** * e1000_clean - NAPI Rx polling callback - * @adapter: board private structure + * @napi: napi struct containing references to driver info + * @budget: budget given to driver for receive packets **/ static int e1000_clean(struct napi_struct *napi, int budget) { @@ -3818,6 +3822,7 @@ static int e1000_clean(struct napi_struct *napi, int budget) /** * e1000_clean_tx_irq - Reclaim resources after transmit completes * @adapter: board private structure + * @tx_ring: ring to clean **/ static bool e1000_clean_tx_irq(struct e1000_adapter *adapter, struct e1000_tx_ring *tx_ring) @@ -3933,7 +3938,7 @@ static bool e1000_clean_tx_irq(struct e1000_adapter *adapter, * @adapter: board private structure * @status_err: receive descriptor status and error fields * @csum: receive descriptor csum field - * @sk_buff: socket buffer with received data + * @skb: socket buffer with received data **/ static void e1000_rx_checksum(struct e1000_adapter *adapter, u32 status_err, u32 csum, struct sk_buff *skb) @@ -3970,6 +3975,9 @@ static void e1000_rx_checksum(struct e1000_adapter *adapter, u32 status_err, /** * e1000_consume_page - helper function for jumbo Rx path + * @bi: software descriptor shadow data + * @skb: skb being modified + * @length: length of data being added **/ static void e1000_consume_page(struct e1000_rx_buffer *bi, struct sk_buff *skb, u16 length) @@ -4003,6 +4011,7 @@ static void e1000_receive_skb(struct e1000_adapter *adapter, u8 status, /** * e1000_tbi_adjust_stats * @hw: Struct containing variables accessed by shared code + * @stats: point to stats struct * @frame_len: The length of the frame in question * @mac_addr: The Ethernet destination address of the frame in question * @@ -4548,6 +4557,8 @@ e1000_alloc_jumbo_rx_buffers(struct e1000_adapter *adapter, /** * e1000_alloc_rx_buffers - Replace used receive buffers; legacy & extended * @adapter: address of board private structure + * @rx_ring: pointer to ring struct + * @cleaned_count: number of new Rx buffers to try to allocate **/ static void e1000_alloc_rx_buffers(struct e1000_adapter *adapter, struct e1000_rx_ring *rx_ring, @@ -4662,7 +4673,7 @@ static void e1000_alloc_rx_buffers(struct e1000_adapter *adapter, /** * e1000_smartspeed - Workaround for SmartSpeed on 82541 and 82547 controllers. - * @adapter: + * @adapter: address of board private structure **/ static void e1000_smartspeed(struct e1000_adapter *adapter) { @@ -4718,10 +4729,10 @@ static void e1000_smartspeed(struct e1000_adapter *adapter) } /** - * e1000_ioctl - - * @netdev: - * @ifreq: - * @cmd: + * e1000_ioctl - handle ioctl calls + * @netdev: pointer to our netdev + * @ifr: pointer to interface request structure + * @cmd: ioctl data **/ static int e1000_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd) { @@ -4737,9 +4748,9 @@ static int e1000_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd) /** * e1000_mii_ioctl - - * @netdev: - * @ifreq: - * @cmd: + * @netdev: pointer to our netdev + * @ifr: pointer to interface request structure + * @cmd: ioctl data **/ static int e1000_mii_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd) diff --git a/drivers/net/ethernet/intel/e1000e/80003es2lan.c b/drivers/net/ethernet/intel/e1000e/80003es2lan.c index 4b103cca8a39..be9c695dde12 100644 --- a/drivers/net/ethernet/intel/e1000e/80003es2lan.c +++ b/drivers/net/ethernet/intel/e1000e/80003es2lan.c @@ -1072,7 +1072,6 @@ static s32 e1000_setup_copper_link_80003es2lan(struct e1000_hw *hw) /** * e1000_cfg_on_link_up_80003es2lan - es2 link configuration after link-up * @hw: pointer to the HW structure - * @duplex: current duplex setting * * Configure the KMRN interface by applying last minute quirks for * 10/100 operation. diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c b/drivers/net/ethernet/intel/e1000e/ich8lan.c index b2f2fcfdf732..ded74304e8cf 100644 --- a/drivers/net/ethernet/intel/e1000e/ich8lan.c +++ b/drivers/net/ethernet/intel/e1000e/ich8lan.c @@ -743,7 +743,7 @@ static s32 e1000_init_mac_params_ich8lan(struct e1000_hw *hw) /** * __e1000_access_emi_reg_locked - Read/write EMI register * @hw: pointer to the HW structure - * @addr: EMI address to program + * @address: EMI address to program * @data: pointer to value to read/write from/to the EMI address * @read: boolean flag to indicate read or write * @@ -2266,7 +2266,7 @@ static s32 e1000_k1_gig_workaround_hv(struct e1000_hw *hw, bool link) /** * e1000_configure_k1_ich8lan - Configure K1 power state * @hw: pointer to the HW structure - * @enable: K1 state to configure + * @k1_enable: K1 state to configure * * Configure the K1 power state based on the provided parameter. * Assumes semaphore already acquired. @@ -2405,8 +2405,10 @@ static s32 e1000_set_mdio_slow_mode_hv(struct e1000_hw *hw) } /** - * e1000_hv_phy_workarounds_ich8lan - A series of Phy workarounds to be - * done after every PHY reset. + * e1000_hv_phy_workarounds_ich8lan - apply PHY workarounds + * @hw: pointer to the HW structure + * + * A series of PHY workarounds to be done after every PHY reset. **/ static s32 e1000_hv_phy_workarounds_ich8lan(struct e1000_hw *hw) { @@ -2694,8 +2696,10 @@ s32 e1000_lv_jumbo_workaround_ich8lan(struct e1000_hw *hw, bool enable) } /** - * e1000_lv_phy_workarounds_ich8lan - A series of Phy workarounds to be - * done after every PHY reset. + * e1000_lv_phy_workarounds_ich8lan - apply ich8 specific workarounds + * @hw: pointer to the HW structure + * + * A series of PHY workarounds to be done after every PHY reset. **/ static s32 e1000_lv_phy_workarounds_ich8lan(struct e1000_hw *hw) { diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c index 664e8ccc88d2..99f4ec9b5696 100644 --- a/drivers/net/ethernet/intel/e1000e/netdev.c +++ b/drivers/net/ethernet/intel/e1000e/netdev.c @@ -501,6 +501,7 @@ static void e1000e_dump(struct e1000_adapter *adapter) /** * e1000_desc_unused - calculate if we have unused descriptors + * @ring: pointer to ring struct to perform calculation on **/ static int e1000_desc_unused(struct e1000_ring *ring) { @@ -577,6 +578,7 @@ static void e1000e_rx_hwtstamp(struct e1000_adapter *adapter, u32 status, /** * e1000_receive_skb - helper function to handle Rx indications * @adapter: board private structure + * @netdev: pointer to netdev struct * @staterr: descriptor extended error and status field as written by hardware * @vlan: descriptor vlan field as written by hardware (no le/be conversion) * @skb: pointer to sk_buff to be indicated to stack @@ -601,8 +603,7 @@ static void e1000_receive_skb(struct e1000_adapter *adapter, * e1000_rx_checksum - Receive Checksum Offload * @adapter: board private structure * @status_err: receive descriptor status and error fields - * @csum: receive descriptor csum field - * @sk_buff: socket buffer with received data + * @skb: socket buffer with received data **/ static void e1000_rx_checksum(struct e1000_adapter *adapter, u32 status_err, struct sk_buff *skb) @@ -673,6 +674,8 @@ static void e1000e_update_tdt_wa(struct e1000_ring *tx_ring, unsigned int i) /** * e1000_alloc_rx_buffers - Replace used receive buffers * @rx_ring: Rx descriptor ring + * @cleaned_count: number to reallocate + * @gfp: flags for allocation **/ static void e1000_alloc_rx_buffers(struct e1000_ring *rx_ring, int cleaned_count, gfp_t gfp) @@ -741,6 +744,8 @@ static void e1000_alloc_rx_buffers(struct e1000_ring *rx_ring, /** * e1000_alloc_rx_buffers_ps - Replace used receive buffers; packet split * @rx_ring: Rx descriptor ring + * @cleaned_count: number to reallocate + * @gfp: flags for allocation **/ static void e1000_alloc_rx_buffers_ps(struct e1000_ring *rx_ring, int cleaned_count, gfp_t gfp) @@ -844,6 +849,7 @@ static void e1000_alloc_rx_buffers_ps(struct e1000_ring *rx_ring, * e1000_alloc_jumbo_rx_buffers - Replace used jumbo receive buffers * @rx_ring: Rx descriptor ring * @cleaned_count: number of buffers to allocate this pass + * @gfp: flags for allocation **/ static void e1000_alloc_jumbo_rx_buffers(struct e1000_ring *rx_ring, @@ -933,6 +939,8 @@ static inline void e1000_rx_hash(struct net_device *netdev, __le32 rss, /** * e1000_clean_rx_irq - Send received data up the network stack * @rx_ring: Rx descriptor ring + * @work_done: output parameter for indicating completed work + * @work_to_do: how many packets we can clean * * the return value indicates whether actual cleaning was done, there * is no guarantee that everything was cleaned @@ -1327,6 +1335,8 @@ static bool e1000_clean_tx_irq(struct e1000_ring *tx_ring) /** * e1000_clean_rx_irq_ps - Send received data up the network stack; packet split * @rx_ring: Rx descriptor ring + * @work_done: output parameter for indicating completed work + * @work_to_do: how many packets we can clean * * the return value indicates whether actual cleaning was done, there * is no guarantee that everything was cleaned @@ -1517,9 +1527,6 @@ static bool e1000_clean_rx_irq_ps(struct e1000_ring *rx_ring, int *work_done, return cleaned; } -/** - * e1000_consume_page - helper function - **/ static void e1000_consume_page(struct e1000_buffer *bi, struct sk_buff *skb, u16 length) { @@ -1531,7 +1538,9 @@ static void e1000_consume_page(struct e1000_buffer *bi, struct sk_buff *skb, /** * e1000_clean_jumbo_rx_irq - Send received data up the network stack; legacy - * @adapter: board private structure + * @rx_ring: Rx descriptor ring + * @work_done: output parameter for indicating completed work + * @work_to_do: how many packets we can clean * * the return value indicates whether actual cleaning was done, there * is no guarantee that everything was cleaned @@ -1994,6 +2003,7 @@ static irqreturn_t e1000_intr_msix_rx(int __always_unused irq, void *data) /** * e1000_configure_msix - Configure MSI-X hardware + * @adapter: board private structure * * e1000_configure_msix sets up the hardware to properly * generate MSI-X interrupts. @@ -2072,6 +2082,7 @@ void e1000e_reset_interrupt_capability(struct e1000_adapter *adapter) /** * e1000e_set_interrupt_capability - set MSI or MSI-X if supported + * @adapter: board private structure * * Attempt to configure interrupts using the best available * capabilities of the hardware and kernel. @@ -2127,6 +2138,7 @@ void e1000e_set_interrupt_capability(struct e1000_adapter *adapter) /** * e1000_request_msix - Initialize MSI-X interrupts + * @adapter: board private structure * * e1000_request_msix allocates MSI-X vectors and requests interrupts from the * kernel. @@ -2180,6 +2192,7 @@ static int e1000_request_msix(struct e1000_adapter *adapter) /** * e1000_request_irq - initialize interrupts + * @adapter: board private structure * * Attempts to configure interrupts using the best available * capabilities of the hardware and kernel. @@ -2240,6 +2253,7 @@ static void e1000_free_irq(struct e1000_adapter *adapter) /** * e1000_irq_disable - Mask off interrupt generation on the NIC + * @adapter: board private structure **/ static void e1000_irq_disable(struct e1000_adapter *adapter) { @@ -2262,6 +2276,7 @@ static void e1000_irq_disable(struct e1000_adapter *adapter) /** * e1000_irq_enable - Enable default interrupt generation settings + * @adapter: board private structure **/ static void e1000_irq_enable(struct e1000_adapter *adapter) { @@ -2332,6 +2347,8 @@ void e1000e_release_hw_control(struct e1000_adapter *adapter) /** * e1000_alloc_ring_dma - allocate memory for a ring structure + * @adapter: board private structure + * @ring: ring struct for which to allocate dma **/ static int e1000_alloc_ring_dma(struct e1000_adapter *adapter, struct e1000_ring *ring) @@ -2507,7 +2524,6 @@ void e1000e_free_rx_resources(struct e1000_ring *rx_ring) /** * e1000_update_itr - update the dynamic ITR value based on statistics - * @adapter: pointer to adapter * @itr_setting: current adapter->itr * @packets: the number of packets during this measurement interval * @bytes: the number of bytes during this measurement interval @@ -3049,12 +3065,13 @@ static void e1000_configure_tx(struct e1000_adapter *adapter) } } +#define PAGE_USE_COUNT(S) (((S) >> PAGE_SHIFT) + \ + (((S) & (PAGE_SIZE - 1)) ? 1 : 0)) + /** * e1000_setup_rctl - configure the receive control registers * @adapter: Board private structure **/ -#define PAGE_USE_COUNT(S) (((S) >> PAGE_SHIFT) + \ - (((S) & (PAGE_SIZE - 1)) ? 1 : 0)) static void e1000_setup_rctl(struct e1000_adapter *adapter) { struct e1000_hw *hw = &adapter->hw; @@ -3605,6 +3622,7 @@ s32 e1000e_get_base_timinca(struct e1000_adapter *adapter, u32 *timinca) /** * e1000e_config_hwtstamp - configure the hwtstamp registers and enable/disable * @adapter: board private structure + * @config: timestamp configuration * * Outgoing time stamping can be enabled and disabled. Play nice and * disable it when requested, although it shouldn't cause any overhead @@ -3808,6 +3826,7 @@ void e1000e_power_up_phy(struct e1000_adapter *adapter) /** * e1000_power_down_phy - Power down the PHY + * @adapter: board private structure * * Power down the PHY so no link is implied when interface is down. * The PHY cannot be powered down if management or WoL is active. @@ -3820,6 +3839,7 @@ static void e1000_power_down_phy(struct e1000_adapter *adapter) /** * e1000_flush_tx_ring - remove all descriptors from the tx_ring + * @adapter: board private structure * * We want to clear all pending descriptors from the TX ring. * zeroing happens when the HW reads the regs. We assign the ring itself as @@ -3854,6 +3874,7 @@ static void e1000_flush_tx_ring(struct e1000_adapter *adapter) /** * e1000_flush_rx_ring - remove all descriptors from the rx_ring + * @adapter: board private structure * * Mark all descriptors in the RX ring as consumed and disable the rx ring */ @@ -3886,6 +3907,7 @@ static void e1000_flush_rx_ring(struct e1000_adapter *adapter) /** * e1000_flush_desc_rings - remove all descriptors from the descriptor rings + * @adapter: board private structure * * In i219, the descriptor rings must be emptied before resetting the HW * or before changing the device state to D3 during runtime (runtime PM). @@ -3968,6 +3990,7 @@ static void e1000e_systim_reset(struct e1000_adapter *adapter) /** * e1000e_reset - bring the hardware into a known good state + * @adapter: board private structure * * This function boots the hardware and enables some settings that * require a configuration cycle of the hardware - those cannot be @@ -4847,7 +4870,7 @@ static void e1000e_update_phy_task(struct work_struct *work) /** * e1000_update_phy_info - timre call-back to update PHY info - * @data: pointer to adapter cast into an unsigned long + * @t: pointer to timer_list containing private info adapter * * Need to wait a few seconds after link up to get diagnostic information from * the phy @@ -5187,7 +5210,7 @@ static void e1000e_check_82574_phy_workaround(struct e1000_adapter *adapter) /** * e1000_watchdog - Timer Call-back - * @data: pointer to adapter cast into an unsigned long + * @t: pointer to timer_list containing private info adapter **/ static void e1000_watchdog(struct timer_list *t) { @@ -5972,8 +5995,9 @@ static netdev_tx_t e1000_xmit_frame(struct sk_buff *skb, /** * e1000_tx_timeout - Respond to a Tx Hang * @netdev: network interface device structure + * @txqueue: index of the hung queue (unused) **/ -static void e1000_tx_timeout(struct net_device *netdev, unsigned int txqueue) +static void e1000_tx_timeout(struct net_device *netdev, unsigned int __always_unused txqueue) { struct e1000_adapter *adapter = netdev_priv(netdev); @@ -6174,7 +6198,7 @@ static int e1000_mii_ioctl(struct net_device *netdev, struct ifreq *ifr, /** * e1000e_hwtstamp_ioctl - control hardware time stamping * @netdev: network interface device structure - * @ifreq: interface request + * @ifr: interface request * * Outgoing time stamping can be enabled and disabled. Play nice and * disable it when requested, although it shouldn't cause any overhead diff --git a/drivers/net/ethernet/intel/e1000e/phy.c b/drivers/net/ethernet/intel/e1000e/phy.c index e11c877595fb..bdd9dc163f15 100644 --- a/drivers/net/ethernet/intel/e1000e/phy.c +++ b/drivers/net/ethernet/intel/e1000e/phy.c @@ -2311,6 +2311,7 @@ s32 e1000e_determine_phy_address(struct e1000_hw *hw) /** * e1000_get_phy_addr_for_bm_page - Retrieve PHY page address * @page: page to access + * @reg: register to check * * Returns the phy address for the page requested. **/ @@ -2728,6 +2729,7 @@ void e1000_power_down_phy_copper(struct e1000_hw *hw) * @offset: register offset to be read * @data: pointer to the read data * @locked: semaphore has already been acquired or not + * @page_set: BM_WUC_PAGE already set and access enabled * * Acquires semaphore, if necessary, then reads the PHY register at offset * and stores the retrieved information in data. Release any acquired @@ -2836,6 +2838,7 @@ s32 e1000_read_phy_reg_page_hv(struct e1000_hw *hw, u32 offset, u16 *data) * @offset: register offset to write to * @data: data to write at register offset * @locked: semaphore has already been acquired or not + * @page_set: BM_WUC_PAGE already set and access enabled * * Acquires semaphore, if necessary, then writes the data to PHY register * at the offset. Release any acquired semaphores before exiting. diff --git a/drivers/net/ethernet/intel/e1000e/ptp.c b/drivers/net/ethernet/intel/e1000e/ptp.c index 34b988d70488..8d21bcb427ec 100644 --- a/drivers/net/ethernet/intel/e1000e/ptp.c +++ b/drivers/net/ethernet/intel/e1000e/ptp.c @@ -144,7 +144,7 @@ static int e1000e_phc_get_syncdevicetime(ktime_t *device, /** * e1000e_phc_getsynctime - Reads the current system/device cross timestamp * @ptp: ptp clock structure - * @cts: structure containing timestamp + * @xtstamp: structure containing timestamp * * Read device and system (ART) clock simultaneously and return the scaled * clock values in ns. diff --git a/drivers/net/ethernet/intel/igb/e1000_82575.c b/drivers/net/ethernet/intel/igb/e1000_82575.c index a32391e82762..50863fd87d53 100644 --- a/drivers/net/ethernet/intel/igb/e1000_82575.c +++ b/drivers/net/ethernet/intel/igb/e1000_82575.c @@ -2554,7 +2554,7 @@ static s32 igb_update_nvm_checksum_i350(struct e1000_hw *hw) /** * __igb_access_emi_reg - Read/write EMI register * @hw: pointer to the HW structure - * @addr: EMI address to program + * @address: EMI address to program * @data: pointer to value to read/write from/to the EMI address * @read: boolean flag to indicate read or write **/ @@ -2590,7 +2590,7 @@ s32 igb_read_emi_reg(struct e1000_hw *hw, u16 addr, u16 *data) * igb_set_eee_i350 - Enable/disable EEE support * @hw: pointer to the HW structure * @adv1G: boolean flag enabling 1G EEE advertisement - * @adv100m: boolean flag enabling 100M EEE advertisement + * @adv100M: boolean flag enabling 100M EEE advertisement * * Enable/disable EEE based on setting in dev_spec structure. * @@ -2646,7 +2646,7 @@ s32 igb_set_eee_i350(struct e1000_hw *hw, bool adv1G, bool adv100M) * igb_set_eee_i354 - Enable/disable EEE support * @hw: pointer to the HW structure * @adv1G: boolean flag enabling 1G EEE advertisement - * @adv100m: boolean flag enabling 100M EEE advertisement + * @adv100M: boolean flag enabling 100M EEE advertisement * * Enable/disable EEE legacy mode based on setting in dev_spec structure. * diff --git a/drivers/net/ethernet/intel/igb/e1000_i210.c b/drivers/net/ethernet/intel/igb/e1000_i210.c index c393cb2c0f16..9265901455cd 100644 --- a/drivers/net/ethernet/intel/igb/e1000_i210.c +++ b/drivers/net/ethernet/intel/igb/e1000_i210.c @@ -357,13 +357,14 @@ static s32 igb_read_invm_word_i210(struct e1000_hw *hw, u8 address, u16 *data) /** * igb_read_invm_i210 - Read invm wrapper function for I210/I211 * @hw: pointer to the HW structure - * @words: number of words to read + * @offset: offset to read from + * @words: number of words to read (unused) * @data: pointer to the data read * * Wrapper function to return data formerly found in the NVM. **/ static s32 igb_read_invm_i210(struct e1000_hw *hw, u16 offset, - u16 words __always_unused, u16 *data) + u16 __always_unused words, u16 *data) { s32 ret_val = 0; diff --git a/drivers/net/ethernet/intel/igb/e1000_mac.c b/drivers/net/ethernet/intel/igb/e1000_mac.c index 3254737c07a3..fd8eb2f9ab9d 100644 --- a/drivers/net/ethernet/intel/igb/e1000_mac.c +++ b/drivers/net/ethernet/intel/igb/e1000_mac.c @@ -166,6 +166,7 @@ static s32 igb_find_vlvf_slot(struct e1000_hw *hw, u32 vlan, bool vlvf_bypass) * @vlan: VLAN id to add or remove * @vind: VMDq output index that maps queue to VLAN id * @vlan_on: if true add filter, if false remove + * @vlvf_bypass: skip VLVF if no match is found * * Sets or clears a bit in the VLAN filter table array based on VLAN id * and if we are adding or removing the filter diff --git a/drivers/net/ethernet/intel/igb/e1000_mbx.c b/drivers/net/ethernet/intel/igb/e1000_mbx.c index 46debd991bfe..33cceb77e960 100644 --- a/drivers/net/ethernet/intel/igb/e1000_mbx.c +++ b/drivers/net/ethernet/intel/igb/e1000_mbx.c @@ -9,6 +9,7 @@ * @msg: The message buffer * @size: Length of buffer * @mbx_id: id of mailbox to read + * @unlock: skip locking or not * * returns SUCCESS if it successfully read message from buffer **/ diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index e1e37d0b7703..44157fcd3cf7 100644 --- a/drivers/net/ethernet/intel/igb/igb_main.c +++ b/drivers/net/ethernet/intel/igb/igb_main.c @@ -549,8 +549,7 @@ static void igb_dump(struct igb_adapter *adapter) /** * igb_get_i2c_data - Reads the I2C SDA data bit - * @hw: pointer to hardware structure - * @i2cctl: Current value of I2CCTL register + * @data: opaque pointer to adapter struct * * Returns the I2C data bit value **/ @@ -3868,6 +3867,7 @@ static int igb_sw_init(struct igb_adapter *adapter) /** * igb_open - Called when a network interface is made active * @netdev: network interface device structure + * @resuming: indicates whether we are in a resume call * * Returns 0 on success, negative value on failure * @@ -3985,6 +3985,7 @@ int igb_open(struct net_device *netdev) /** * igb_close - Disables a network interface * @netdev: network interface device structure + * @suspending: indicates we are in a suspend call * * Returns 0, this is not allowed to fail * @@ -5219,7 +5220,7 @@ static void igb_check_lvmmc(struct igb_adapter *adapter) /** * igb_watchdog - Timer Call-back - * @data: pointer to adapter cast into an unsigned long + * @t: pointer to timer_list containing our private info pointer **/ static void igb_watchdog(struct timer_list *t) { @@ -6192,8 +6193,9 @@ static netdev_tx_t igb_xmit_frame(struct sk_buff *skb, /** * igb_tx_timeout - Respond to a Tx Hang * @netdev: network interface device structure + * @txqueue: number of the Tx queue that hung (unused) **/ -static void igb_tx_timeout(struct net_device *netdev, unsigned int txqueue) +static void igb_tx_timeout(struct net_device *netdev, unsigned int __always_unused txqueue) { struct igb_adapter *adapter = netdev_priv(netdev); struct e1000_hw *hw = &adapter->hw; @@ -8181,7 +8183,6 @@ static inline void igb_rx_hash(struct igb_ring *ring, * igb_is_non_eop - process handling of non-EOP buffers * @rx_ring: Rx ring being processed * @rx_desc: Rx descriptor for current buffer - * @skb: current socket buffer containing buffer in progress * * This function updates next to clean. If the buffer is an EOP buffer * this function exits returning false, otherwise it will place the @@ -8460,8 +8461,9 @@ static bool igb_alloc_mapped_page(struct igb_ring *rx_ring, } /** - * igb_alloc_rx_buffers - Replace used receive buffers; packet split - * @adapter: address of board private structure + * igb_alloc_rx_buffers - Replace used receive buffers + * @rx_ring: rx descriptor ring to allocate new receive buffers + * @cleaned_count: count of buffers to allocate **/ void igb_alloc_rx_buffers(struct igb_ring *rx_ring, u16 cleaned_count) { @@ -8530,9 +8532,9 @@ void igb_alloc_rx_buffers(struct igb_ring *rx_ring, u16 cleaned_count) /** * igb_mii_ioctl - - * @netdev: - * @ifreq: - * @cmd: + * @netdev: pointer to netdev struct + * @ifr: interface structure + * @cmd: ioctl command to execute **/ static int igb_mii_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd) { @@ -8560,9 +8562,9 @@ static int igb_mii_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd) /** * igb_ioctl - - * @netdev: - * @ifreq: - * @cmd: + * @netdev: pointer to netdev struct + * @ifr: interface structure + * @cmd: ioctl command to execute **/ static int igb_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd) { diff --git a/drivers/net/ethernet/intel/igb/igb_ptp.c b/drivers/net/ethernet/intel/igb/igb_ptp.c index 490368d3d03c..7cc5428c3b3d 100644 --- a/drivers/net/ethernet/intel/igb/igb_ptp.c +++ b/drivers/net/ethernet/intel/igb/igb_ptp.c @@ -957,8 +957,8 @@ void igb_ptp_rx_rgtstamp(struct igb_q_vector *q_vector, /** * igb_ptp_get_ts_config - get hardware time stamping config - * @netdev: - * @ifreq: + * @netdev: netdev struct + * @ifr: interface struct * * Get the hwtstamp_config settings to return to the user. Rather than attempt * to deconstruct the settings from the registers, just return a shadow copy @@ -1141,8 +1141,8 @@ static int igb_ptp_set_timestamp_mode(struct igb_adapter *adapter, /** * igb_ptp_set_ts_config - set hardware time stamping config - * @netdev: - * @ifreq: + * @netdev: netdev struct + * @ifr: interface struct * **/ int igb_ptp_set_ts_config(struct net_device *netdev, struct ifreq *ifr) diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c b/drivers/net/ethernet/intel/igbvf/netdev.c index 19269f5d52bc..ee9f8c1dca83 100644 --- a/drivers/net/ethernet/intel/igbvf/netdev.c +++ b/drivers/net/ethernet/intel/igbvf/netdev.c @@ -61,7 +61,7 @@ static const struct igbvf_info *igbvf_info_tbl[] = { /** * igbvf_desc_unused - calculate if we have unused descriptors - * @rx_ring: address of receive ring structure + * @ring: address of receive ring structure **/ static int igbvf_desc_unused(struct igbvf_ring *ring) { @@ -74,6 +74,8 @@ static int igbvf_desc_unused(struct igbvf_ring *ring) /** * igbvf_receive_skb - helper function to handle Rx indications * @adapter: board private structure + * @netdev: pointer to netdev struct + * @skb: skb to indicate to stack * @status: descriptor status field as written by hardware * @vlan: descriptor vlan field as written by hardware (no le/be conversion) * @skb: pointer to sk_buff to be indicated to stack @@ -233,6 +235,8 @@ static void igbvf_alloc_rx_buffers(struct igbvf_ring *rx_ring, /** * igbvf_clean_rx_irq - Send received data up the network stack; legacy * @adapter: board private structure + * @work_done: output parameter used to indicate completed work + * @work_to_do: input parameter setting limit of work * * the return value indicates whether actual cleaning was done, there * is no guarantee that everything was cleaned @@ -406,6 +410,7 @@ static void igbvf_put_txbuf(struct igbvf_adapter *adapter, /** * igbvf_setup_tx_resources - allocate Tx resources (Descriptors) * @adapter: board private structure + * @tx_ring: ring being initialized * * Return 0 on success, negative on failure **/ @@ -444,6 +449,7 @@ int igbvf_setup_tx_resources(struct igbvf_adapter *adapter, /** * igbvf_setup_rx_resources - allocate Rx resources (Descriptors) * @adapter: board private structure + * @rx_ring: ring being initialized * * Returns 0 on success, negative on failure **/ @@ -540,7 +546,7 @@ void igbvf_free_tx_resources(struct igbvf_ring *tx_ring) /** * igbvf_clean_rx_ring - Free Rx Buffers per Queue - * @adapter: board private structure + * @rx_ring: ring structure pointer to free buffers from **/ static void igbvf_clean_rx_ring(struct igbvf_ring *rx_ring) { @@ -760,7 +766,7 @@ static void igbvf_set_itr(struct igbvf_adapter *adapter) /** * igbvf_clean_tx_irq - Reclaim resources after transmit completes - * @adapter: board private structure + * @tx_ring: ring structure to clean descriptors from * * returns true if ring is completely cleaned **/ @@ -1891,7 +1897,7 @@ static bool igbvf_has_link(struct igbvf_adapter *adapter) /** * igbvf_watchdog - Timer Call-back - * @data: pointer to adapter cast into an unsigned long + * @t: timer list pointer containing private struct **/ static void igbvf_watchdog(struct timer_list *t) { @@ -2372,8 +2378,9 @@ static netdev_tx_t igbvf_xmit_frame(struct sk_buff *skb, /** * igbvf_tx_timeout - Respond to a Tx Hang * @netdev: network interface device structure + * @txqueue: queue timing out (unused) **/ -static void igbvf_tx_timeout(struct net_device *netdev, unsigned int txqueue) +static void igbvf_tx_timeout(struct net_device *netdev, unsigned int __always_unused txqueue) { struct igbvf_adapter *adapter = netdev_priv(netdev); diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c index c6968fdb6caa..3183150c7995 100644 --- a/drivers/net/ethernet/intel/igc/igc_main.c +++ b/drivers/net/ethernet/intel/igc/igc_main.c @@ -4653,7 +4653,7 @@ int igc_close(struct net_device *netdev) /** * igc_ioctl - Access the hwtstamp interface * @netdev: network interface device structure - * @ifreq: interface request data + * @ifr: interface request data * @cmd: ioctl command **/ static int igc_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd) diff --git a/drivers/net/ethernet/intel/igc/igc_ptp.c b/drivers/net/ethernet/intel/igc/igc_ptp.c index 36c999250fcc..7aee56346656 100644 --- a/drivers/net/ethernet/intel/igc/igc_ptp.c +++ b/drivers/net/ethernet/intel/igc/igc_ptp.c @@ -420,7 +420,7 @@ static void igc_ptp_tx_work(struct work_struct *work) /** * igc_ptp_set_ts_config - set hardware time stamping config * @netdev: network interface device structure - * @ifreq: interface request data + * @ifr: interface request data * **/ int igc_ptp_set_ts_config(struct net_device *netdev, struct ifreq *ifr) @@ -447,7 +447,7 @@ int igc_ptp_set_ts_config(struct net_device *netdev, struct ifreq *ifr) /** * igc_ptp_get_ts_config - get hardware time stamping config * @netdev: network interface device structure - * @ifreq: interface request data + * @ifr: interface request data * * Get the hwtstamp_config settings to return to the user. Rather than attempt * to deconstruct the settings from the registers, just return a shadow copy diff --git a/drivers/net/ethernet/intel/ixgb/ixgb_hw.c b/drivers/net/ethernet/intel/ixgb/ixgb_hw.c index cbaa933ef30d..a430871d1c27 100644 --- a/drivers/net/ethernet/intel/ixgb/ixgb_hw.c +++ b/drivers/net/ethernet/intel/ixgb/ixgb_hw.c @@ -98,7 +98,6 @@ bool ixgb_adapter_stop(struct ixgb_hw *hw) { u32 ctrl_reg; - u32 icr_reg; ENTER(); @@ -142,7 +141,7 @@ ixgb_adapter_stop(struct ixgb_hw *hw) IXGB_WRITE_REG(hw, IMC, 0xffffffff); /* Clear any pending interrupt events. */ - icr_reg = IXGB_READ_REG(hw, ICR); + IXGB_READ_REG(hw, ICR); return ctrl_reg & IXGB_CTRL0_RST; } @@ -274,7 +273,6 @@ bool ixgb_init_hw(struct ixgb_hw *hw) { u32 i; - u32 ctrl_reg; bool status; ENTER(); @@ -286,7 +284,7 @@ ixgb_init_hw(struct ixgb_hw *hw) */ pr_debug("Issuing a global reset to MAC\n"); - ctrl_reg = ixgb_mac_reset(hw); + ixgb_mac_reset(hw); pr_debug("Issuing an EE reset to MAC\n"); #ifdef HP_ZX1 @@ -949,8 +947,6 @@ bool ixgb_check_for_bad_link(struct ixgb_hw *hw) static void ixgb_clear_hw_cntrs(struct ixgb_hw *hw) { - volatile u32 temp_reg; - ENTER(); /* if we are stopped or resetting exit gracefully */ @@ -959,66 +955,66 @@ ixgb_clear_hw_cntrs(struct ixgb_hw *hw) return; } - temp_reg = IXGB_READ_REG(hw, TPRL); - temp_reg = IXGB_READ_REG(hw, TPRH); - temp_reg = IXGB_READ_REG(hw, GPRCL); - temp_reg = IXGB_READ_REG(hw, GPRCH); - temp_reg = IXGB_READ_REG(hw, BPRCL); - temp_reg = IXGB_READ_REG(hw, BPRCH); - temp_reg = IXGB_READ_REG(hw, MPRCL); - temp_reg = IXGB_READ_REG(hw, MPRCH); - temp_reg = IXGB_READ_REG(hw, UPRCL); - temp_reg = IXGB_READ_REG(hw, UPRCH); - temp_reg = IXGB_READ_REG(hw, VPRCL); - temp_reg = IXGB_READ_REG(hw, VPRCH); - temp_reg = IXGB_READ_REG(hw, JPRCL); - temp_reg = IXGB_READ_REG(hw, JPRCH); - temp_reg = IXGB_READ_REG(hw, GORCL); - temp_reg = IXGB_READ_REG(hw, GORCH); - temp_reg = IXGB_READ_REG(hw, TORL); - temp_reg = IXGB_READ_REG(hw, TORH); - temp_reg = IXGB_READ_REG(hw, RNBC); - temp_reg = IXGB_READ_REG(hw, RUC); - temp_reg = IXGB_READ_REG(hw, ROC); - temp_reg = IXGB_READ_REG(hw, RLEC); - temp_reg = IXGB_READ_REG(hw, CRCERRS); - temp_reg = IXGB_READ_REG(hw, ICBC); - temp_reg = IXGB_READ_REG(hw, ECBC); - temp_reg = IXGB_READ_REG(hw, MPC); - temp_reg = IXGB_READ_REG(hw, TPTL); - temp_reg = IXGB_READ_REG(hw, TPTH); - temp_reg = IXGB_READ_REG(hw, GPTCL); - temp_reg = IXGB_READ_REG(hw, GPTCH); - temp_reg = IXGB_READ_REG(hw, BPTCL); - temp_reg = IXGB_READ_REG(hw, BPTCH); - temp_reg = IXGB_READ_REG(hw, MPTCL); - temp_reg = IXGB_READ_REG(hw, MPTCH); - temp_reg = IXGB_READ_REG(hw, UPTCL); - temp_reg = IXGB_READ_REG(hw, UPTCH); - temp_reg = IXGB_READ_REG(hw, VPTCL); - temp_reg = IXGB_READ_REG(hw, VPTCH); - temp_reg = IXGB_READ_REG(hw, JPTCL); - temp_reg = IXGB_READ_REG(hw, JPTCH); - temp_reg = IXGB_READ_REG(hw, GOTCL); - temp_reg = IXGB_READ_REG(hw, GOTCH); - temp_reg = IXGB_READ_REG(hw, TOTL); - temp_reg = IXGB_READ_REG(hw, TOTH); - temp_reg = IXGB_READ_REG(hw, DC); - temp_reg = IXGB_READ_REG(hw, PLT64C); - temp_reg = IXGB_READ_REG(hw, TSCTC); - temp_reg = IXGB_READ_REG(hw, TSCTFC); - temp_reg = IXGB_READ_REG(hw, IBIC); - temp_reg = IXGB_READ_REG(hw, RFC); - temp_reg = IXGB_READ_REG(hw, LFC); - temp_reg = IXGB_READ_REG(hw, PFRC); - temp_reg = IXGB_READ_REG(hw, PFTC); - temp_reg = IXGB_READ_REG(hw, MCFRC); - temp_reg = IXGB_READ_REG(hw, MCFTC); - temp_reg = IXGB_READ_REG(hw, XONRXC); - temp_reg = IXGB_READ_REG(hw, XONTXC); - temp_reg = IXGB_READ_REG(hw, XOFFRXC); - temp_reg = IXGB_READ_REG(hw, XOFFTXC); - temp_reg = IXGB_READ_REG(hw, RJC); + IXGB_READ_REG(hw, TPRL); + IXGB_READ_REG(hw, TPRH); + IXGB_READ_REG(hw, GPRCL); + IXGB_READ_REG(hw, GPRCH); + IXGB_READ_REG(hw, BPRCL); + IXGB_READ_REG(hw, BPRCH); + IXGB_READ_REG(hw, MPRCL); + IXGB_READ_REG(hw, MPRCH); + IXGB_READ_REG(hw, UPRCL); + IXGB_READ_REG(hw, UPRCH); + IXGB_READ_REG(hw, VPRCL); + IXGB_READ_REG(hw, VPRCH); + IXGB_READ_REG(hw, JPRCL); + IXGB_READ_REG(hw, JPRCH); + IXGB_READ_REG(hw, GORCL); + IXGB_READ_REG(hw, GORCH); + IXGB_READ_REG(hw, TORL); + IXGB_READ_REG(hw, TORH); + IXGB_READ_REG(hw, RNBC); + IXGB_READ_REG(hw, RUC); + IXGB_READ_REG(hw, ROC); + IXGB_READ_REG(hw, RLEC); + IXGB_READ_REG(hw, CRCERRS); + IXGB_READ_REG(hw, ICBC); + IXGB_READ_REG(hw, ECBC); + IXGB_READ_REG(hw, MPC); + IXGB_READ_REG(hw, TPTL); + IXGB_READ_REG(hw, TPTH); + IXGB_READ_REG(hw, GPTCL); + IXGB_READ_REG(hw, GPTCH); + IXGB_READ_REG(hw, BPTCL); + IXGB_READ_REG(hw, BPTCH); + IXGB_READ_REG(hw, MPTCL); + IXGB_READ_REG(hw, MPTCH); + IXGB_READ_REG(hw, UPTCL); + IXGB_READ_REG(hw, UPTCH); + IXGB_READ_REG(hw, VPTCL); + IXGB_READ_REG(hw, VPTCH); + IXGB_READ_REG(hw, JPTCL); + IXGB_READ_REG(hw, JPTCH); + IXGB_READ_REG(hw, GOTCL); + IXGB_READ_REG(hw, GOTCH); + IXGB_READ_REG(hw, TOTL); + IXGB_READ_REG(hw, TOTH); + IXGB_READ_REG(hw, DC); + IXGB_READ_REG(hw, PLT64C); + IXGB_READ_REG(hw, TSCTC); + IXGB_READ_REG(hw, TSCTFC); + IXGB_READ_REG(hw, IBIC); + IXGB_READ_REG(hw, RFC); + IXGB_READ_REG(hw, LFC); + IXGB_READ_REG(hw, PFRC); + IXGB_READ_REG(hw, PFTC); + IXGB_READ_REG(hw, MCFRC); + IXGB_READ_REG(hw, MCFTC); + IXGB_READ_REG(hw, XONRXC); + IXGB_READ_REG(hw, XONTXC); + IXGB_READ_REG(hw, XOFFRXC); + IXGB_READ_REG(hw, XOFFTXC); + IXGB_READ_REG(hw, RJC); } /****************************************************************************** @@ -1161,18 +1157,13 @@ static void ixgb_optics_reset(struct ixgb_hw *hw) { if (hw->phy_type == ixgb_phy_type_txn17401) { - u16 mdio_reg; - ixgb_write_phy_reg(hw, MDIO_CTRL1, IXGB_PHY_ADDRESS, MDIO_MMD_PMAPMD, MDIO_CTRL1_RESET); - mdio_reg = ixgb_read_phy_reg(hw, - MDIO_CTRL1, - IXGB_PHY_ADDRESS, - MDIO_MMD_PMAPMD); + ixgb_read_phy_reg(hw, MDIO_CTRL1, IXGB_PHY_ADDRESS, MDIO_MMD_PMAPMD); } } diff --git a/drivers/net/ethernet/intel/ixgb/ixgb_main.c b/drivers/net/ethernet/intel/ixgb/ixgb_main.c index 048351cf0e4a..1588376d4c67 100644 --- a/drivers/net/ethernet/intel/ixgb/ixgb_main.c +++ b/drivers/net/ethernet/intel/ixgb/ixgb_main.c @@ -1109,7 +1109,7 @@ ixgb_set_multi(struct net_device *netdev) /** * ixgb_watchdog - Timer Call-back - * @data: pointer to netdev cast into an unsigned long + * @t: pointer to timer_list containing our private info pointer **/ static void @@ -1531,10 +1531,11 @@ ixgb_xmit_frame(struct sk_buff *skb, struct net_device *netdev) /** * ixgb_tx_timeout - Respond to a Tx Hang * @netdev: network interface device structure + * @txqueue: queue hanging (unused) **/ static void -ixgb_tx_timeout(struct net_device *netdev, unsigned int txqueue) +ixgb_tx_timeout(struct net_device *netdev, unsigned int __always_unused txqueue) { struct ixgb_adapter *adapter = netdev_priv(netdev); @@ -1746,7 +1747,8 @@ ixgb_intr(int irq, void *data) /** * ixgb_clean - NAPI Rx polling callback - * @adapter: board private structure + * @napi: napi struct pointer + * @budget: max number of receives to clean **/ static int @@ -1865,7 +1867,7 @@ ixgb_clean_tx_irq(struct ixgb_adapter *adapter) * ixgb_rx_checksum - Receive Checksum Offload for 82597. * @adapter: board private structure * @rx_desc: receive descriptor - * @sk_buff: socket buffer with received data + * @skb: socket buffer with received data **/ static void @@ -1923,6 +1925,8 @@ static void ixgb_check_copybreak(struct napi_struct *napi, /** * ixgb_clean_rx_irq - Send received data up the network stack, * @adapter: board private structure + * @work_done: output pointer to amount of packets cleaned + * @work_to_do: how much work we can complete **/ static bool @@ -2042,6 +2046,7 @@ ixgb_clean_rx_irq(struct ixgb_adapter *adapter, int *work_done, int work_to_do) /** * ixgb_alloc_rx_buffers - Replace used receive buffers * @adapter: address of board private structure + * @cleaned_count: how many buffers to allocate **/ static void @@ -2211,7 +2216,7 @@ static pci_ers_result_t ixgb_io_error_detected(struct pci_dev *pdev, /** * ixgb_io_slot_reset - called after the pci bus has been reset. - * @pdev pointer to pci device with error + * @pdev: pointer to pci device with error * * This callback is called after the PCI bus has been reset. * Basically, this tries to restart the card from scratch. @@ -2259,7 +2264,7 @@ static pci_ers_result_t ixgb_io_slot_reset(struct pci_dev *pdev) /** * ixgb_io_resume - called when its OK to resume normal operations - * @pdev pointer to pci device with error + * @pdev: pointer to pci device with error * * The error recovery driver tells us that its OK to resume * normal operation. Implementation resembles the second-half diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c index 50afec43e001..ba54c728aef2 100644 --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c @@ -246,8 +246,9 @@ static void ixgbevf_tx_timeout_reset(struct ixgbevf_adapter *adapter) /** * ixgbevf_tx_timeout - Respond to a Tx Hang * @netdev: network interface device structure + * @txqueue: transmit queue hanging (unused) **/ -static void ixgbevf_tx_timeout(struct net_device *netdev, unsigned int txqueue) +static void ixgbevf_tx_timeout(struct net_device *netdev, unsigned int __always_unused txqueue) { struct ixgbevf_adapter *adapter = netdev_priv(netdev); -- 2.27.0 ^ permalink raw reply related [flat|nested] 68+ messages in thread
* Re: [Intel-wired-lan] [RFC PATCH net-next v1 05/11] intel-ethernet: make W=1 build cleanly 2020-09-11 1:23 ` [Intel-wired-lan] " Jesse Brandeburg @ 2020-09-11 17:43 ` Vinicius Costa Gomes -1 siblings, 0 replies; 68+ messages in thread From: Vinicius Costa Gomes @ 2020-09-11 17:43 UTC (permalink / raw) To: Jesse Brandeburg, netdev; +Cc: intel-wired-lan Jesse Brandeburg <jesse.brandeburg@intel.com> writes: > This takes care of all of the trivial W=1 fixes in the Intel > Ethernet drivers, which allows developers and maintainers to > build more of the networking tree with more complete warning > checks. > > Almost all of the changes were trivial comment updates on > function headers, but some of the changes were for variables that > were storing a return value from a register read, where the > return value wasn't used. Those conversions to remove the lvalue > of the assignment should be safe because the readl memory mapped > reads are marked volatile and should not be optimized out without > an lvalue (I suspect a very long time ago this wasn't guaranteed > as it is today). > > Inspired by Lee Jones' series of wireless work to do the same. > Compile tested only. > > Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> > --- > drivers/net/ethernet/intel/e100.c | 8 +- > drivers/net/ethernet/intel/e1000/e1000_hw.c | 147 ++++++++---------- > drivers/net/ethernet/intel/e1000/e1000_main.c | 39 +++-- > .../net/ethernet/intel/e1000e/80003es2lan.c | 1 - > drivers/net/ethernet/intel/e1000e/ich8lan.c | 16 +- > drivers/net/ethernet/intel/e1000e/netdev.c | 50 ++++-- > drivers/net/ethernet/intel/e1000e/phy.c | 3 + > drivers/net/ethernet/intel/e1000e/ptp.c | 2 +- > drivers/net/ethernet/intel/igb/e1000_82575.c | 6 +- > drivers/net/ethernet/intel/igb/e1000_i210.c | 5 +- > drivers/net/ethernet/intel/igb/e1000_mac.c | 1 + > drivers/net/ethernet/intel/igb/e1000_mbx.c | 1 + > drivers/net/ethernet/intel/igb/igb_main.c | 28 ++-- > drivers/net/ethernet/intel/igb/igb_ptp.c | 8 +- > drivers/net/ethernet/intel/igbvf/netdev.c | 17 +- > drivers/net/ethernet/intel/igc/igc_main.c | 2 +- > drivers/net/ethernet/intel/igc/igc_ptp.c | 4 +- > drivers/net/ethernet/intel/ixgb/ixgb_hw.c | 135 ++++++++-------- > drivers/net/ethernet/intel/ixgb/ixgb_main.c | 17 +- > .../net/ethernet/intel/ixgbevf/ixgbevf_main.c | 3 +- > 20 files changed, 265 insertions(+), 228 deletions(-) > ... > diff --git a/drivers/net/ethernet/intel/e1000/e1000_hw.c b/drivers/net/ethernet/intel/e1000/e1000_hw.c > index 4e7a0810eaeb..2120dacfd55c 100644 > --- a/drivers/net/ethernet/intel/e1000/e1000_hw.c > +++ b/drivers/net/ethernet/intel/e1000/e1000_hw.c > @@ -139,6 +139,7 @@ static void e1000_phy_init_script(struct e1000_hw *hw) > * at the end of this routine. > */ > ret_val = e1000_read_phy_reg(hw, 0x2F5B, &phy_saved_data); > + e_dbg("Reading PHY register 0x2F5B failed: %d\n", ret_val); > Adding this debug statement seems unrelated. > /* Disabled the PHY transmitter */ > e1000_write_phy_reg(hw, 0x2F5B, 0x0003); Apart from this, Reviewed-by: Vinicius Costa Gomes <vinicius.gomes@intel.com> -- Vinicius ^ permalink raw reply [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 05/11] intel-ethernet: make W=1 build cleanly @ 2020-09-11 17:43 ` Vinicius Costa Gomes 0 siblings, 0 replies; 68+ messages in thread From: Vinicius Costa Gomes @ 2020-09-11 17:43 UTC (permalink / raw) To: intel-wired-lan Jesse Brandeburg <jesse.brandeburg@intel.com> writes: > This takes care of all of the trivial W=1 fixes in the Intel > Ethernet drivers, which allows developers and maintainers to > build more of the networking tree with more complete warning > checks. > > Almost all of the changes were trivial comment updates on > function headers, but some of the changes were for variables that > were storing a return value from a register read, where the > return value wasn't used. Those conversions to remove the lvalue > of the assignment should be safe because the readl memory mapped > reads are marked volatile and should not be optimized out without > an lvalue (I suspect a very long time ago this wasn't guaranteed > as it is today). > > Inspired by Lee Jones' series of wireless work to do the same. > Compile tested only. > > Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> > --- > drivers/net/ethernet/intel/e100.c | 8 +- > drivers/net/ethernet/intel/e1000/e1000_hw.c | 147 ++++++++---------- > drivers/net/ethernet/intel/e1000/e1000_main.c | 39 +++-- > .../net/ethernet/intel/e1000e/80003es2lan.c | 1 - > drivers/net/ethernet/intel/e1000e/ich8lan.c | 16 +- > drivers/net/ethernet/intel/e1000e/netdev.c | 50 ++++-- > drivers/net/ethernet/intel/e1000e/phy.c | 3 + > drivers/net/ethernet/intel/e1000e/ptp.c | 2 +- > drivers/net/ethernet/intel/igb/e1000_82575.c | 6 +- > drivers/net/ethernet/intel/igb/e1000_i210.c | 5 +- > drivers/net/ethernet/intel/igb/e1000_mac.c | 1 + > drivers/net/ethernet/intel/igb/e1000_mbx.c | 1 + > drivers/net/ethernet/intel/igb/igb_main.c | 28 ++-- > drivers/net/ethernet/intel/igb/igb_ptp.c | 8 +- > drivers/net/ethernet/intel/igbvf/netdev.c | 17 +- > drivers/net/ethernet/intel/igc/igc_main.c | 2 +- > drivers/net/ethernet/intel/igc/igc_ptp.c | 4 +- > drivers/net/ethernet/intel/ixgb/ixgb_hw.c | 135 ++++++++-------- > drivers/net/ethernet/intel/ixgb/ixgb_main.c | 17 +- > .../net/ethernet/intel/ixgbevf/ixgbevf_main.c | 3 +- > 20 files changed, 265 insertions(+), 228 deletions(-) > ... > diff --git a/drivers/net/ethernet/intel/e1000/e1000_hw.c b/drivers/net/ethernet/intel/e1000/e1000_hw.c > index 4e7a0810eaeb..2120dacfd55c 100644 > --- a/drivers/net/ethernet/intel/e1000/e1000_hw.c > +++ b/drivers/net/ethernet/intel/e1000/e1000_hw.c > @@ -139,6 +139,7 @@ static void e1000_phy_init_script(struct e1000_hw *hw) > * at the end of this routine. > */ > ret_val = e1000_read_phy_reg(hw, 0x2F5B, &phy_saved_data); > + e_dbg("Reading PHY register 0x2F5B failed: %d\n", ret_val); > Adding this debug statement seems unrelated. > /* Disabled the PHY transmitter */ > e1000_write_phy_reg(hw, 0x2F5B, 0x0003); Apart from this, Reviewed-by: Vinicius Costa Gomes <vinicius.gomes@intel.com> -- Vinicius ^ permalink raw reply [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 05/11] intel-ethernet: make W=1 build cleanly 2020-09-11 17:43 ` Vinicius Costa Gomes (?) @ 2020-09-11 23:06 ` Jacob Keller -1 siblings, 0 replies; 68+ messages in thread From: Jacob Keller @ 2020-09-11 23:06 UTC (permalink / raw) To: intel-wired-lan On 9/11/2020 10:43 AM, Vinicius Costa Gomes wrote: > Jesse Brandeburg <jesse.brandeburg@intel.com> writes: > >> This takes care of all of the trivial W=1 fixes in the Intel >> Ethernet drivers, which allows developers and maintainers to >> build more of the networking tree with more complete warning >> checks. >> >> Almost all of the changes were trivial comment updates on >> function headers, but some of the changes were for variables that >> were storing a return value from a register read, where the >> return value wasn't used. Those conversions to remove the lvalue >> of the assignment should be safe because the readl memory mapped >> reads are marked volatile and should not be optimized out without >> an lvalue (I suspect a very long time ago this wasn't guaranteed >> as it is today). >> >> Inspired by Lee Jones' series of wireless work to do the same. >> Compile tested only. >> >> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> >> --- >> drivers/net/ethernet/intel/e100.c | 8 +- >> drivers/net/ethernet/intel/e1000/e1000_hw.c | 147 ++++++++---------- >> drivers/net/ethernet/intel/e1000/e1000_main.c | 39 +++-- >> .../net/ethernet/intel/e1000e/80003es2lan.c | 1 - >> drivers/net/ethernet/intel/e1000e/ich8lan.c | 16 +- >> drivers/net/ethernet/intel/e1000e/netdev.c | 50 ++++-- >> drivers/net/ethernet/intel/e1000e/phy.c | 3 + >> drivers/net/ethernet/intel/e1000e/ptp.c | 2 +- >> drivers/net/ethernet/intel/igb/e1000_82575.c | 6 +- >> drivers/net/ethernet/intel/igb/e1000_i210.c | 5 +- >> drivers/net/ethernet/intel/igb/e1000_mac.c | 1 + >> drivers/net/ethernet/intel/igb/e1000_mbx.c | 1 + >> drivers/net/ethernet/intel/igb/igb_main.c | 28 ++-- >> drivers/net/ethernet/intel/igb/igb_ptp.c | 8 +- >> drivers/net/ethernet/intel/igbvf/netdev.c | 17 +- >> drivers/net/ethernet/intel/igc/igc_main.c | 2 +- >> drivers/net/ethernet/intel/igc/igc_ptp.c | 4 +- >> drivers/net/ethernet/intel/ixgb/ixgb_hw.c | 135 ++++++++-------- >> drivers/net/ethernet/intel/ixgb/ixgb_main.c | 17 +- >> .../net/ethernet/intel/ixgbevf/ixgbevf_main.c | 3 +- >> 20 files changed, 265 insertions(+), 228 deletions(-) >> > > ... > >> diff --git a/drivers/net/ethernet/intel/e1000/e1000_hw.c b/drivers/net/ethernet/intel/e1000/e1000_hw.c >> index 4e7a0810eaeb..2120dacfd55c 100644 >> --- a/drivers/net/ethernet/intel/e1000/e1000_hw.c >> +++ b/drivers/net/ethernet/intel/e1000/e1000_hw.c >> @@ -139,6 +139,7 @@ static void e1000_phy_init_script(struct e1000_hw *hw) >> * at the end of this routine. >> */ >> ret_val = e1000_read_phy_reg(hw, 0x2F5B, &phy_saved_data); >> + e_dbg("Reading PHY register 0x2F5B failed: %d\n", ret_val); >> > > Adding this debug statement seems unrelated. Adding the debug statement does make ret_val become used, but yea it could have been called out in the commit message. > >> /* Disabled the PHY transmitter */ >> e1000_write_phy_reg(hw, 0x2F5B, 0x0003); > > Apart from this, > > Reviewed-by: Vinicius Costa Gomes <vinicius.gomes@intel.com> > ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [Intel-wired-lan] [RFC PATCH net-next v1 05/11] intel-ethernet: make W=1 build cleanly 2020-09-11 17:43 ` Vinicius Costa Gomes @ 2020-09-11 23:28 ` Jesse Brandeburg -1 siblings, 0 replies; 68+ messages in thread From: Jesse Brandeburg @ 2020-09-11 23:28 UTC (permalink / raw) To: Vinicius Costa Gomes; +Cc: netdev, intel-wired-lan Vinicius Costa Gomes wrote: > > diff --git a/drivers/net/ethernet/intel/e1000/e1000_hw.c b/drivers/net/ethernet/intel/e1000/e1000_hw.c > > index 4e7a0810eaeb..2120dacfd55c 100644 > > --- a/drivers/net/ethernet/intel/e1000/e1000_hw.c > > +++ b/drivers/net/ethernet/intel/e1000/e1000_hw.c > > @@ -139,6 +139,7 @@ static void e1000_phy_init_script(struct e1000_hw *hw) > > * at the end of this routine. > > */ > > ret_val = e1000_read_phy_reg(hw, 0x2F5B, &phy_saved_data); > > + e_dbg("Reading PHY register 0x2F5B failed: %d\n", ret_val); > > > > Adding this debug statement seems unrelated. Thanks, in the next version I actually addressed this in the commit message, that this one change was to solve the "you didn't use ret_val" with a conceivably useful message. I also rejiggered the patches to have the register read lvalue removals all in their own patch instead of squashed together with kdoc changes. > > > /* Disabled the PHY transmitter */ > > e1000_write_phy_reg(hw, 0x2F5B, 0x0003); > > Apart from this, > > Reviewed-by: Vinicius Costa Gomes <vinicius.gomes@intel.com> > Thanks for the review! ^ permalink raw reply [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 05/11] intel-ethernet: make W=1 build cleanly @ 2020-09-11 23:28 ` Jesse Brandeburg 0 siblings, 0 replies; 68+ messages in thread From: Jesse Brandeburg @ 2020-09-11 23:28 UTC (permalink / raw) To: intel-wired-lan Vinicius Costa Gomes wrote: > > diff --git a/drivers/net/ethernet/intel/e1000/e1000_hw.c b/drivers/net/ethernet/intel/e1000/e1000_hw.c > > index 4e7a0810eaeb..2120dacfd55c 100644 > > --- a/drivers/net/ethernet/intel/e1000/e1000_hw.c > > +++ b/drivers/net/ethernet/intel/e1000/e1000_hw.c > > @@ -139,6 +139,7 @@ static void e1000_phy_init_script(struct e1000_hw *hw) > > * at the end of this routine. > > */ > > ret_val = e1000_read_phy_reg(hw, 0x2F5B, &phy_saved_data); > > + e_dbg("Reading PHY register 0x2F5B failed: %d\n", ret_val); > > > > Adding this debug statement seems unrelated. Thanks, in the next version I actually addressed this in the commit message, that this one change was to solve the "you didn't use ret_val" with a conceivably useful message. I also rejiggered the patches to have the register read lvalue removals all in their own patch instead of squashed together with kdoc changes. > > > /* Disabled the PHY transmitter */ > > e1000_write_phy_reg(hw, 0x2F5B, 0x0003); > > Apart from this, > > Reviewed-by: Vinicius Costa Gomes <vinicius.gomes@intel.com> > Thanks for the review! ^ permalink raw reply [flat|nested] 68+ messages in thread
* [RFC PATCH net-next v1 06/11] drivers/net/ethernet: clean up unused assignments 2020-09-11 1:23 ` [Intel-wired-lan] " Jesse Brandeburg @ 2020-09-11 1:23 ` Jesse Brandeburg -1 siblings, 0 replies; 68+ messages in thread From: Jesse Brandeburg @ 2020-09-11 1:23 UTC (permalink / raw) To: netdev; +Cc: Jesse Brandeburg, intel-wired-lan As part of the W=1 compliation series, these lines all created warnings about unused variables that were assigned a value. Most of them are from register reads, but some are just picking up a return value from a function and never doing anything with it. The register reads should be OK, because the current implementation of readl and friends will always execute even without an lvalue. When it makes sense, just remove the lvalue assignment and the local. Other times, just remove the offending code, and occasionally, just mark the variable as maybe unused since it could be used in an ifdef or debug scenario. Only compile tested with W=1 and an allyesconfig with all the network drivers turned into modules (to try to test all options). Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> --- drivers/net/ethernet/brocade/bna/bnad.c | 7 ++-- .../net/ethernet/cavium/liquidio/lio_main.c | 4 +-- .../ethernet/cavium/liquidio/octeon_device.c | 13 ++++---- drivers/net/ethernet/cortina/gemini.c | 6 ++-- drivers/net/ethernet/dec/tulip/de4x5.c | 4 +-- drivers/net/ethernet/dec/tulip/media.c | 5 --- drivers/net/ethernet/dnet.c | 8 ++--- drivers/net/ethernet/freescale/fec_ptp.c | 3 +- drivers/net/ethernet/marvell/mvneta.c | 7 ++-- drivers/net/ethernet/marvell/pxa168_eth.c | 3 +- drivers/net/ethernet/mellanox/mlx4/en_tx.c | 2 +- drivers/net/ethernet/micrel/ksz884x.c | 13 +++----- drivers/net/ethernet/microchip/lan743x_main.c | 9 ++---- drivers/net/ethernet/neterion/vxge/vxge-reg.h | 4 +-- .../net/ethernet/neterion/vxge/vxge-traffic.c | 32 +++++++------------ .../ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 3 +- drivers/net/ethernet/sfc/falcon/farch.c | 29 +++++++---------- drivers/net/ethernet/sis/sis900.c | 5 ++- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 4 +-- .../net/ethernet/synopsys/dwc-xlgmac-common.c | 2 +- drivers/net/ethernet/ti/cpsw_new.c | 2 -- drivers/net/ethernet/ti/davinci_emac.c | 5 ++- drivers/net/ethernet/ti/tlan.c | 4 +-- drivers/net/ethernet/via/via-velocity.c | 13 -------- 24 files changed, 65 insertions(+), 122 deletions(-) diff --git a/drivers/net/ethernet/brocade/bna/bnad.c b/drivers/net/ethernet/brocade/bna/bnad.c index cc80bbbefe87..7e4e831d720f 100644 --- a/drivers/net/ethernet/brocade/bna/bnad.c +++ b/drivers/net/ethernet/brocade/bna/bnad.c @@ -3277,7 +3277,7 @@ bnad_change_mtu(struct net_device *netdev, int new_mtu) { int err, mtu; struct bnad *bnad = netdev_priv(netdev); - u32 rx_count = 0, frame, new_frame; + u32 frame, new_frame; mutex_lock(&bnad->conf_mutex); @@ -3293,12 +3293,9 @@ bnad_change_mtu(struct net_device *netdev, int new_mtu) /* only when transition is over 4K */ if ((frame <= 4096 && new_frame > 4096) || (frame > 4096 && new_frame <= 4096)) - rx_count = bnad_reinit_rx(bnad); + bnad_reinit_rx(bnad); } - /* rx_count > 0 - new rx created - * - Linux set err = 0 and return - */ err = bnad_mtu_set(bnad, new_frame); if (err) err = -EBUSY; diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c b/drivers/net/ethernet/cavium/liquidio/lio_main.c index 8e0ed01e7f03..737ae69eec6e 100644 --- a/drivers/net/ethernet/cavium/liquidio/lio_main.c +++ b/drivers/net/ethernet/cavium/liquidio/lio_main.c @@ -1,4 +1,4 @@ -/********************************************************************** +/* * Author: Cavium, Inc. * * Contact: support@cavium.com @@ -14,7 +14,7 @@ * AS-IS and WITHOUT ANY WARRANTY; without even the implied warranty * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE, TITLE, or * NONINFRINGEMENT. See the GNU General Public License for more details. - ***********************************************************************/ + */ #include <linux/module.h> #include <linux/interrupt.h> #include <linux/pci.h> diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_device.c b/drivers/net/ethernet/cavium/liquidio/octeon_device.c index ac32facaa427..1db29ffde3e5 100644 --- a/drivers/net/ethernet/cavium/liquidio/octeon_device.c +++ b/drivers/net/ethernet/cavium/liquidio/octeon_device.c @@ -1,4 +1,4 @@ -/********************************************************************** +/* * Author: Cavium, Inc. * * Contact: support@cavium.com @@ -14,7 +14,7 @@ * AS-IS and WITHOUT ANY WARRANTY; without even the implied warranty * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE, TITLE, or * NONINFRINGEMENT. See the GNU General Public License for more details. - ***********************************************************************/ + */ #include <linux/pci.h> #include <linux/netdevice.h> #include <linux/vmalloc.h> @@ -1324,7 +1324,7 @@ u64 lio_pci_readq(struct octeon_device *oct, u64 addr) { u64 val64; unsigned long flags; - u32 val32, addrhi; + u32 addrhi; spin_lock_irqsave(&oct->pci_win_lock, flags); @@ -1339,10 +1339,10 @@ u64 lio_pci_readq(struct octeon_device *oct, u64 addr) writel(addrhi, oct->reg_list.pci_win_rd_addr_hi); /* Read back to preserve ordering of writes */ - val32 = readl(oct->reg_list.pci_win_rd_addr_hi); + readl(oct->reg_list.pci_win_rd_addr_hi); writel(addr & 0xffffffff, oct->reg_list.pci_win_rd_addr_lo); - val32 = readl(oct->reg_list.pci_win_rd_addr_lo); + readl(oct->reg_list.pci_win_rd_addr_lo); val64 = readq(oct->reg_list.pci_win_rd_data); @@ -1355,7 +1355,6 @@ void lio_pci_writeq(struct octeon_device *oct, u64 val, u64 addr) { - u32 val32; unsigned long flags; spin_lock_irqsave(&oct->pci_win_lock, flags); @@ -1365,7 +1364,7 @@ void lio_pci_writeq(struct octeon_device *oct, /* The write happens when the LSB is written. So write MSB first. */ writel(val >> 32, oct->reg_list.pci_win_wr_data_hi); /* Read the MSB to ensure ordering of writes. */ - val32 = readl(oct->reg_list.pci_win_wr_data_hi); + readl(oct->reg_list.pci_win_wr_data_hi); writel(val & 0xffffffff, oct->reg_list.pci_win_wr_data_lo); diff --git a/drivers/net/ethernet/cortina/gemini.c b/drivers/net/ethernet/cortina/gemini.c index 9dcf47f576c6..07e9dee03c98 100644 --- a/drivers/net/ethernet/cortina/gemini.c +++ b/drivers/net/ethernet/cortina/gemini.c @@ -509,7 +509,6 @@ static int gmac_init(struct net_device *netdev) .rel_threshold = 0, } }; union gmac_config0 tmp; - u32 val; config0.bits.max_len = gmac_pick_rx_max_len(netdev->mtu); tmp.bits32 = readl(port->gmac_base + GMAC_CONFIG0); @@ -519,7 +518,7 @@ static int gmac_init(struct net_device *netdev) writel(config2.bits32, port->gmac_base + GMAC_CONFIG2); writel(config3.bits32, port->gmac_base + GMAC_CONFIG3); - val = readl(port->dma_base + GMAC_AHB_WEIGHT_REG); + readl(port->dma_base + GMAC_AHB_WEIGHT_REG); writel(ahb_weight.bits32, port->dma_base + GMAC_AHB_WEIGHT_REG); writel(hw_weigh.bits32, @@ -2107,9 +2106,8 @@ static void gmac_get_ringparam(struct net_device *netdev, struct ethtool_ringparam *rp) { struct gemini_ethernet_port *port = netdev_priv(netdev); - union gmac_config0 config0; - config0.bits32 = readl(port->gmac_base + GMAC_CONFIG0); + readl(port->gmac_base + GMAC_CONFIG0); rp->rx_max_pending = 1 << 15; rp->rx_mini_max_pending = 0; diff --git a/drivers/net/ethernet/dec/tulip/de4x5.c b/drivers/net/ethernet/dec/tulip/de4x5.c index f9dd1aa9f2da..683e328b5461 100644 --- a/drivers/net/ethernet/dec/tulip/de4x5.c +++ b/drivers/net/ethernet/dec/tulip/de4x5.c @@ -4925,11 +4925,11 @@ mii_get_oui(u_char phyaddr, u_long ioaddr) u_char breg[2]; } a; int i, r2, r3, ret=0;*/ - int r2, r3; + int r2; /* Read r2 and r3 */ r2 = mii_rd(MII_ID0, phyaddr, ioaddr); - r3 = mii_rd(MII_ID1, phyaddr, ioaddr); + mii_rd(MII_ID1, phyaddr, ioaddr); /* SEEQ and Cypress way * / / * Shuffle r2 and r3 * / a.reg=0; diff --git a/drivers/net/ethernet/dec/tulip/media.c b/drivers/net/ethernet/dec/tulip/media.c index dcf21a36a9cf..011604787b8e 100644 --- a/drivers/net/ethernet/dec/tulip/media.c +++ b/drivers/net/ethernet/dec/tulip/media.c @@ -319,13 +319,8 @@ void tulip_select_media(struct net_device *dev, int startup) break; } case 5: case 6: { - u16 setup[5]; - new_csr6 = 0; /* FIXME */ - for (i = 0; i < 5; i++) - setup[i] = get_u16(&p[i*2 + 1]); - if (startup && mtable->has_reset) { struct medialeaf *rleaf = &mtable->mleaf[mtable->has_reset]; unsigned char *rst = rleaf->leafdata; diff --git a/drivers/net/ethernet/dnet.c b/drivers/net/ethernet/dnet.c index 3143df9a398c..48c6eb142dcc 100644 --- a/drivers/net/ethernet/dnet.c +++ b/drivers/net/ethernet/dnet.c @@ -507,12 +507,12 @@ static netdev_tx_t dnet_start_xmit(struct sk_buff *skb, struct net_device *dev) { struct dnet *bp = netdev_priv(dev); - u32 tx_status, irq_enable; unsigned int i, tx_cmd, wrsz; unsigned long flags; unsigned int *bufp; + u32 irq_enable; - tx_status = dnet_readl(bp, TX_STATUS); + dnet_readl(bp, TX_STATUS); pr_debug("start_xmit: len %u head %p data %p\n", skb->len, skb->head, skb->data); @@ -520,7 +520,7 @@ static netdev_tx_t dnet_start_xmit(struct sk_buff *skb, struct net_device *dev) spin_lock_irqsave(&bp->lock, flags); - tx_status = dnet_readl(bp, TX_STATUS); + dnet_readl(bp, TX_STATUS); bufp = (unsigned int *)(((unsigned long) skb->data) & ~0x3UL); wrsz = (u32) skb->len + 3; @@ -542,7 +542,7 @@ static netdev_tx_t dnet_start_xmit(struct sk_buff *skb, struct net_device *dev) if (dnet_readl(bp, TX_FIFO_WCNT) > DNET_FIFO_TX_DATA_AF_TH) { netif_stop_queue(dev); - tx_status = dnet_readl(bp, INTR_SRC); + dnet_readl(bp, INTR_SRC); irq_enable = dnet_readl(bp, INTR_ENB); irq_enable |= DNET_INTR_ENB_TX_FIFOAE; dnet_writel(bp, irq_enable, INTR_ENB); diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/ethernet/freescale/fec_ptp.c index a0c1f4410306..0405a3975f3f 100644 --- a/drivers/net/ethernet/freescale/fec_ptp.c +++ b/drivers/net/ethernet/freescale/fec_ptp.c @@ -520,13 +520,12 @@ static void fec_time_keep(struct work_struct *work) { struct delayed_work *dwork = to_delayed_work(work); struct fec_enet_private *fep = container_of(dwork, struct fec_enet_private, time_keep); - u64 ns; unsigned long flags; mutex_lock(&fep->ptp_clk_mutex); if (fep->ptp_clk_on) { spin_lock_irqsave(&fep->tmreg_lock, flags); - ns = timecounter_read(&fep->tc); + timecounter_read(&fep->tc); spin_unlock_irqrestore(&fep->tmreg_lock, flags); } mutex_unlock(&fep->ptp_clk_mutex); diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index f75e05e899bb..4694242b7b3b 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c @@ -751,13 +751,12 @@ static void mvneta_txq_inc_put(struct mvneta_tx_queue *txq) static void mvneta_mib_counters_clear(struct mvneta_port *pp) { int i; - u32 dummy; /* Perform dummy reads from MIB counters */ for (i = 0; i < MVNETA_MIB_LATE_COLLISION; i += 4) - dummy = mvreg_read(pp, (MVNETA_MIB_COUNTERS_BASE + i)); - dummy = mvreg_read(pp, MVNETA_RX_DISCARD_FRAME_COUNT); - dummy = mvreg_read(pp, MVNETA_OVERRUN_FRAME_COUNT); + mvreg_read(pp, (MVNETA_MIB_COUNTERS_BASE + i)); + mvreg_read(pp, MVNETA_RX_DISCARD_FRAME_COUNT); + mvreg_read(pp, MVNETA_OVERRUN_FRAME_COUNT); } /* Get System Network Statistics */ diff --git a/drivers/net/ethernet/marvell/pxa168_eth.c b/drivers/net/ethernet/marvell/pxa168_eth.c index faac94b2d5ff..d1e4d42e497d 100644 --- a/drivers/net/ethernet/marvell/pxa168_eth.c +++ b/drivers/net/ethernet/marvell/pxa168_eth.c @@ -1187,11 +1187,10 @@ static int pxa168_eth_stop(struct net_device *dev) static int pxa168_eth_change_mtu(struct net_device *dev, int mtu) { - int retval; struct pxa168_eth_private *pep = netdev_priv(dev); dev->mtu = mtu; - retval = set_port_config_ext(pep); + set_port_config_ext(pep); if (!netif_running(dev)) return 0; diff --git a/drivers/net/ethernet/mellanox/mlx4/en_tx.c b/drivers/net/ethernet/mellanox/mlx4/en_tx.c index 9dff7b086c9f..f69ff7fbf619 100644 --- a/drivers/net/ethernet/mellanox/mlx4/en_tx.c +++ b/drivers/net/ethernet/mellanox/mlx4/en_tx.c @@ -842,6 +842,7 @@ netdev_tx_t mlx4_en_xmit(struct sk_buff *skb, struct net_device *dev) struct mlx4_en_tx_desc *tx_desc; struct mlx4_wqe_data_seg *data; struct mlx4_en_tx_info *tx_info; + u32 __maybe_unused ring_cons; int tx_ind; int nr_txbb; int desc_size; @@ -855,7 +856,6 @@ netdev_tx_t mlx4_en_xmit(struct sk_buff *skb, struct net_device *dev) bool stop_queue; bool inline_ok; u8 data_offset; - u32 ring_cons; bool bf_ok; tx_ind = skb_get_queue_mapping(skb); diff --git a/drivers/net/ethernet/micrel/ksz884x.c b/drivers/net/ethernet/micrel/ksz884x.c index bb646b65cc95..c84a1e8c918b 100644 --- a/drivers/net/ethernet/micrel/ksz884x.c +++ b/drivers/net/ethernet/micrel/ksz884x.c @@ -1649,8 +1649,7 @@ static inline void set_tx_len(struct ksz_desc *desc, u32 len) #define HW_DELAY(hw, reg) \ do { \ - u16 dummy; \ - dummy = readw(hw->io + reg); \ + readw(hw->io + reg); \ } while (0) /** @@ -4978,7 +4977,6 @@ static inline int rx_proc(struct net_device *dev, struct ksz_hw* hw, struct dev_info *hw_priv = priv->adapter; struct ksz_dma_buf *dma_buf; struct sk_buff *skb; - int rx_status; /* Received length includes 4-byte CRC. */ packet_len = status.rx.frame_len - 4; @@ -5014,7 +5012,7 @@ static inline int rx_proc(struct net_device *dev, struct ksz_hw* hw, dev->stats.rx_bytes += packet_len; /* Notify upper layer for received packet. */ - rx_status = netif_rx(skb); + netif_rx(skb); return 0; } @@ -6509,7 +6507,6 @@ static void netdev_get_ethtool_stats(struct net_device *dev, int i; int n; int p; - int rc; u64 counter[TOTAL_PORT_COUNTER_NUM]; mutex_lock(&hw_priv->lock); @@ -6530,19 +6527,19 @@ static void netdev_get_ethtool_stats(struct net_device *dev, if (1 == port->mib_port_cnt && n < SWITCH_PORT_NUM) { p = n; - rc = wait_event_interruptible_timeout( + wait_event_interruptible_timeout( hw_priv->counter[p].counter, 2 == hw_priv->counter[p].read, HZ * 1); } else for (i = 0, p = n; i < port->mib_port_cnt - n; i++, p++) { if (0 == i) { - rc = wait_event_interruptible_timeout( + wait_event_interruptible_timeout( hw_priv->counter[p].counter, 2 == hw_priv->counter[p].read, HZ * 2); } else if (hw->port_mib[p].cnt_ptr) { - rc = wait_event_interruptible_timeout( + wait_event_interruptible_timeout( hw_priv->counter[p].counter, 2 == hw_priv->counter[p].read, HZ * 1); diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/ethernet/microchip/lan743x_main.c index de93cc6ebc1a..4561021a5b1a 100644 --- a/drivers/net/ethernet/microchip/lan743x_main.c +++ b/drivers/net/ethernet/microchip/lan743x_main.c @@ -158,9 +158,8 @@ static void lan743x_tx_isr(void *context, u32 int_sts, u32 flags) struct lan743x_tx *tx = context; struct lan743x_adapter *adapter = tx->adapter; bool enable_flag = true; - u32 int_en = 0; - int_en = lan743x_csr_read(adapter, INT_EN_SET); + lan743x_csr_read(adapter, INT_EN_SET); if (flags & LAN743X_VECTOR_FLAG_SOURCE_ENABLE_CLEAR) { lan743x_csr_write(adapter, INT_EN_CLR, INT_BIT_DMA_TX_(tx->channel_number)); @@ -1699,10 +1698,9 @@ static int lan743x_tx_napi_poll(struct napi_struct *napi, int weight) bool start_transmitter = false; unsigned long irq_flags = 0; u32 ioc_bit = 0; - u32 int_sts = 0; ioc_bit = DMAC_INT_BIT_TX_IOC_(tx->channel_number); - int_sts = lan743x_csr_read(adapter, DMAC_INT_STS); + lan743x_csr_read(adapter, DMAC_INT_STS); if (tx->vector_flags & LAN743X_VECTOR_FLAG_SOURCE_STATUS_W2C) lan743x_csr_write(adapter, DMAC_INT_STS, ioc_bit); spin_lock_irqsave(&tx->ring_lock, irq_flags); @@ -3038,7 +3036,6 @@ static int lan743x_pm_suspend(struct device *dev) struct pci_dev *pdev = to_pci_dev(dev); struct net_device *netdev = pci_get_drvdata(pdev); struct lan743x_adapter *adapter = netdev_priv(netdev); - int ret; lan743x_pcidev_shutdown(pdev); @@ -3051,7 +3048,7 @@ static int lan743x_pm_suspend(struct device *dev) lan743x_pm_set_wol(adapter); /* Host sets PME_En, put D3hot */ - ret = pci_prepare_to_sleep(pdev); + pci_prepare_to_sleep(pdev); return 0; } diff --git a/drivers/net/ethernet/neterion/vxge/vxge-reg.h b/drivers/net/ethernet/neterion/vxge/vxge-reg.h index 3e658b175947..3bb03b9c39b7 100644 --- a/drivers/net/ethernet/neterion/vxge/vxge-reg.h +++ b/drivers/net/ethernet/neterion/vxge/vxge-reg.h @@ -1,4 +1,4 @@ -/****************************************************************************** +/* * This software may be used and distributed according to the terms of * the GNU General Public License (GPL), incorporated herein by reference. * Drivers based on or derived from this code fall under the GPL and must @@ -10,7 +10,7 @@ * vxge-reg.h: Driver for Exar Corp's X3100 Series 10GbE PCIe I/O Virtualized * Server Adapter. * Copyright(c) 2002-2010 Exar Corp. - ******************************************************************************/ + */ #ifndef VXGE_REG_H #define VXGE_REG_H diff --git a/drivers/net/ethernet/neterion/vxge/vxge-traffic.c b/drivers/net/ethernet/neterion/vxge/vxge-traffic.c index 709d20d9938f..bd525e8eda10 100644 --- a/drivers/net/ethernet/neterion/vxge/vxge-traffic.c +++ b/drivers/net/ethernet/neterion/vxge/vxge-traffic.c @@ -30,8 +30,6 @@ */ enum vxge_hw_status vxge_hw_vpath_intr_enable(struct __vxge_hw_vpath_handle *vp) { - u64 val64; - struct __vxge_hw_virtualpath *vpath; struct vxge_hw_vpath_reg __iomem *vp_reg; enum vxge_hw_status status = VXGE_HW_OK; @@ -84,7 +82,7 @@ enum vxge_hw_status vxge_hw_vpath_intr_enable(struct __vxge_hw_vpath_handle *vp) __vxge_hw_pio_mem_write32_upper((u32)VXGE_HW_INTR_MASK_ALL, &vp_reg->xgmac_vp_int_status); - val64 = readq(&vp_reg->vpath_general_int_status); + readq(&vp_reg->vpath_general_int_status); /* Mask unwanted interrupts */ @@ -157,8 +155,6 @@ enum vxge_hw_status vxge_hw_vpath_intr_enable(struct __vxge_hw_vpath_handle *vp) enum vxge_hw_status vxge_hw_vpath_intr_disable( struct __vxge_hw_vpath_handle *vp) { - u64 val64; - struct __vxge_hw_virtualpath *vpath; enum vxge_hw_status status = VXGE_HW_OK; struct vxge_hw_vpath_reg __iomem *vp_reg; @@ -179,8 +175,6 @@ enum vxge_hw_status vxge_hw_vpath_intr_disable( (u32)VXGE_HW_INTR_MASK_ALL, &vp_reg->vpath_general_int_mask); - val64 = VXGE_HW_TIM_CLR_INT_EN_VP(1 << (16 - vpath->vp_id)); - writeq(VXGE_HW_INTR_MASK_ALL, &vp_reg->kdfcctl_errors_mask); __vxge_hw_pio_mem_write32_upper((u32)VXGE_HW_INTR_MASK_ALL, @@ -487,9 +481,7 @@ void vxge_hw_device_unmask_all(struct __vxge_hw_device *hldev) */ void vxge_hw_device_flush_io(struct __vxge_hw_device *hldev) { - u32 val32; - - val32 = readl(&hldev->common_reg->titan_general_int_status); + readl(&hldev->common_reg->titan_general_int_status); } /** @@ -1716,8 +1708,8 @@ void vxge_hw_fifo_txdl_free(struct __vxge_hw_fifo *fifo, void *txdlh) enum vxge_hw_status vxge_hw_vpath_mac_addr_add( struct __vxge_hw_vpath_handle *vp, - u8 (macaddr)[ETH_ALEN], - u8 (macaddr_mask)[ETH_ALEN], + u8 *macaddr, + u8 *macaddr_mask, enum vxge_hw_vpath_mac_addr_add_mode duplicate_mode) { u32 i; @@ -1779,8 +1771,8 @@ vxge_hw_vpath_mac_addr_add( enum vxge_hw_status vxge_hw_vpath_mac_addr_get( struct __vxge_hw_vpath_handle *vp, - u8 (macaddr)[ETH_ALEN], - u8 (macaddr_mask)[ETH_ALEN]) + u8 *macaddr, + u8 *macaddr_mask) { u32 i; u64 data1 = 0ULL; @@ -1831,8 +1823,8 @@ vxge_hw_vpath_mac_addr_get( enum vxge_hw_status vxge_hw_vpath_mac_addr_get_next( struct __vxge_hw_vpath_handle *vp, - u8 (macaddr)[ETH_ALEN], - u8 (macaddr_mask)[ETH_ALEN]) + u8 *macaddr, + u8 *macaddr_mask) { u32 i; u64 data1 = 0ULL; @@ -1884,8 +1876,8 @@ vxge_hw_vpath_mac_addr_get_next( enum vxge_hw_status vxge_hw_vpath_mac_addr_delete( struct __vxge_hw_vpath_handle *vp, - u8 (macaddr)[ETH_ALEN], - u8 (macaddr_mask)[ETH_ALEN]) + u8 *macaddr, + u8 *macaddr_mask) { u32 i; u64 data1 = 0ULL; @@ -2375,7 +2367,6 @@ enum vxge_hw_status vxge_hw_vpath_poll_rx(struct __vxge_hw_ring *ring) u8 t_code; enum vxge_hw_status status = VXGE_HW_OK; void *first_rxdh; - u64 val64 = 0; int new_count = 0; ring->cmpl_cnt = 0; @@ -2403,8 +2394,7 @@ enum vxge_hw_status vxge_hw_vpath_poll_rx(struct __vxge_hw_ring *ring) } writeq(VXGE_HW_PRC_RXD_DOORBELL_NEW_QW_CNT(new_count), &ring->vp_reg->prc_rxd_doorbell); - val64 = - readl(&ring->common_reg->titan_general_int_status); + readl(&ring->common_reg->titan_general_int_status); ring->doorbell_cnt = 0; } } diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c index 29b9c728a65e..fc490881cd03 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c @@ -658,11 +658,10 @@ int qlcnic_83xx_cam_lock(struct qlcnic_adapter *adapter) void qlcnic_83xx_cam_unlock(struct qlcnic_adapter *adapter) { void __iomem *addr; - u32 val; struct qlcnic_hardware_context *ahw = adapter->ahw; addr = ahw->pci_base0 + QLC_83XX_SEM_UNLOCK_FUNC(ahw->pci_func); - val = readl(addr); + readl(addr); } void qlcnic_83xx_read_crb(struct qlcnic_adapter *adapter, char *buf, diff --git a/drivers/net/ethernet/sfc/falcon/farch.c b/drivers/net/ethernet/sfc/falcon/farch.c index fa1ade856b10..2c91792cec01 100644 --- a/drivers/net/ethernet/sfc/falcon/farch.c +++ b/drivers/net/ethernet/sfc/falcon/farch.c @@ -870,17 +870,12 @@ static u16 ef4_farch_handle_rx_not_ok(struct ef4_rx_queue *rx_queue, { struct ef4_channel *channel = ef4_rx_queue_channel(rx_queue); struct ef4_nic *efx = rx_queue->efx; - bool rx_ev_buf_owner_id_err, rx_ev_ip_hdr_chksum_err; + bool __maybe_unused rx_ev_buf_owner_id_err, rx_ev_ip_hdr_chksum_err; bool rx_ev_tcp_udp_chksum_err, rx_ev_eth_crc_err; bool rx_ev_frm_trunc, rx_ev_drib_nib, rx_ev_tobe_disc; - bool rx_ev_other_err, rx_ev_pause_frm; - bool rx_ev_hdr_type, rx_ev_mcast_pkt; - unsigned rx_ev_pkt_type; + bool rx_ev_pause_frm; - rx_ev_hdr_type = EF4_QWORD_FIELD(*event, FSF_AZ_RX_EV_HDR_TYPE); - rx_ev_mcast_pkt = EF4_QWORD_FIELD(*event, FSF_AZ_RX_EV_MCAST_PKT); rx_ev_tobe_disc = EF4_QWORD_FIELD(*event, FSF_AZ_RX_EV_TOBE_DISC); - rx_ev_pkt_type = EF4_QWORD_FIELD(*event, FSF_AZ_RX_EV_PKT_TYPE); rx_ev_buf_owner_id_err = EF4_QWORD_FIELD(*event, FSF_AZ_RX_EV_BUF_OWNER_ID_ERR); rx_ev_ip_hdr_chksum_err = EF4_QWORD_FIELD(*event, @@ -893,10 +888,6 @@ static u16 ef4_farch_handle_rx_not_ok(struct ef4_rx_queue *rx_queue, 0 : EF4_QWORD_FIELD(*event, FSF_AA_RX_EV_DRIB_NIB)); rx_ev_pause_frm = EF4_QWORD_FIELD(*event, FSF_AZ_RX_EV_PAUSE_FRM_ERR); - /* Every error apart from tobe_disc and pause_frm */ - rx_ev_other_err = (rx_ev_drib_nib | rx_ev_tcp_udp_chksum_err | - rx_ev_buf_owner_id_err | rx_ev_eth_crc_err | - rx_ev_frm_trunc | rx_ev_ip_hdr_chksum_err); /* Count errors that are not in MAC stats. Ignore expected * checksum errors during self-test. */ @@ -916,6 +907,13 @@ static u16 ef4_farch_handle_rx_not_ok(struct ef4_rx_queue *rx_queue, * to a FIFO overflow. */ #ifdef DEBUG + { + /* Every error apart from tobe_disc and pause_frm */ + + bool rx_ev_other_err = (rx_ev_drib_nib | rx_ev_tcp_udp_chksum_err | + rx_ev_buf_owner_id_err | rx_ev_eth_crc_err | + rx_ev_frm_trunc | rx_ev_ip_hdr_chksum_err); + if (rx_ev_other_err && net_ratelimit()) { netif_dbg(efx, rx_err, efx->net_dev, " RX queue %d unexpected RX event " @@ -932,6 +930,7 @@ static u16 ef4_farch_handle_rx_not_ok(struct ef4_rx_queue *rx_queue, rx_ev_tobe_disc ? " [TOBE_DISC]" : "", rx_ev_pause_frm ? " [PAUSE]" : ""); } + } #endif /* The frame must be discarded if any of these are true. */ @@ -1643,15 +1642,11 @@ void ef4_farch_rx_push_indir_table(struct ef4_nic *efx) */ void ef4_farch_dimension_resources(struct ef4_nic *efx, unsigned sram_lim_qw) { - unsigned vi_count, buftbl_min; + unsigned vi_count; /* Account for the buffer table entries backing the datapath channels * and the descriptor caches for those channels. */ - buftbl_min = ((efx->n_rx_channels * EF4_MAX_DMAQ_SIZE + - efx->n_tx_channels * EF4_TXQ_TYPES * EF4_MAX_DMAQ_SIZE + - efx->n_channels * EF4_MAX_EVQ_SIZE) - * sizeof(ef4_qword_t) / EF4_BUF_SIZE); vi_count = max(efx->n_channels, efx->n_tx_channels * EF4_TXQ_TYPES); efx->tx_dc_base = sram_lim_qw - vi_count * TX_DC_ENTRIES; @@ -2532,7 +2527,6 @@ int ef4_farch_filter_remove_safe(struct ef4_nic *efx, enum ef4_farch_filter_table_id table_id; struct ef4_farch_filter_table *table; unsigned int filter_idx; - struct ef4_farch_filter_spec *spec; int rc; table_id = ef4_farch_filter_id_table_id(filter_id); @@ -2543,7 +2537,6 @@ int ef4_farch_filter_remove_safe(struct ef4_nic *efx, filter_idx = ef4_farch_filter_id_index(filter_id); if (filter_idx >= table->size) return -ENOENT; - spec = &table->spec[filter_idx]; spin_lock_bh(&efx->filter_lock); rc = ef4_farch_filter_remove(efx, table, filter_idx, priority); diff --git a/drivers/net/ethernet/sis/sis900.c b/drivers/net/ethernet/sis/sis900.c index cfa460c7db23..869b7618e2ba 100644 --- a/drivers/net/ethernet/sis/sis900.c +++ b/drivers/net/ethernet/sis/sis900.c @@ -789,10 +789,9 @@ static u16 sis900_default_phy(struct net_device * net_dev) static void sis900_set_capability(struct net_device *net_dev, struct mii_phy *phy) { u16 cap; - u16 status; - status = mdio_read(net_dev, phy->phy_addr, MII_STATUS); - status = mdio_read(net_dev, phy->phy_addr, MII_STATUS); + mdio_read(net_dev, phy->phy_addr, MII_STATUS); + mdio_read(net_dev, phy->phy_addr, MII_STATUS); cap = MII_NWAY_CSMA_CD | ((phy->status & MII_STAT_CAN_TX_FDX)? MII_NWAY_TX_FDX:0) | diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index c553047ff482..3fa24b310d20 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -3630,15 +3630,15 @@ static unsigned int stmmac_rx_buf1_len(struct stmmac_priv *priv, struct dma_desc *p, int status, unsigned int len) { - int ret, coe = priv->hw->rx_csum; unsigned int plen = 0, hlen = 0; + int coe = priv->hw->rx_csum; /* Not first descriptor, buffer is always zero */ if (priv->sph && len) return 0; /* First descriptor, get split header length */ - ret = stmmac_get_rx_header_len(priv, p, &hlen); + stmmac_get_rx_header_len(priv, p, &hlen); if (priv->sph && hlen) { priv->xstats.rx_split_hdr_pkt_n++; return hlen; diff --git a/drivers/net/ethernet/synopsys/dwc-xlgmac-common.c b/drivers/net/ethernet/synopsys/dwc-xlgmac-common.c index eb1c6b03c329..df26cea45904 100644 --- a/drivers/net/ethernet/synopsys/dwc-xlgmac-common.c +++ b/drivers/net/ethernet/synopsys/dwc-xlgmac-common.c @@ -513,7 +513,7 @@ void xlgmac_get_all_hw_features(struct xlgmac_pdata *pdata) void xlgmac_print_all_hw_features(struct xlgmac_pdata *pdata) { - char *str = NULL; + char __maybe_unused *str = NULL; XLGMAC_PR("\n"); XLGMAC_PR("=====================================================\n"); diff --git a/drivers/net/ethernet/ti/cpsw_new.c b/drivers/net/ethernet/ti/cpsw_new.c index 8ed78577cded..f62f7fa7edae 100644 --- a/drivers/net/ethernet/ti/cpsw_new.c +++ b/drivers/net/ethernet/ti/cpsw_new.c @@ -1660,12 +1660,10 @@ static int cpsw_dl_switch_mode_set(struct devlink *dl, u32 id, for (i = 0; i < cpsw->data.slaves; i++) { struct cpsw_slave *slave = &cpsw->slaves[i]; struct net_device *sl_ndev = slave->ndev; - struct cpsw_priv *priv; if (!sl_ndev) continue; - priv = netdev_priv(sl_ndev); if (switch_en) vlan = cpsw->data.default_vlan; else diff --git a/drivers/net/ethernet/ti/davinci_emac.c b/drivers/net/ethernet/ti/davinci_emac.c index de282531f68b..b36d0e412d23 100644 --- a/drivers/net/ethernet/ti/davinci_emac.c +++ b/drivers/net/ethernet/ti/davinci_emac.c @@ -1227,7 +1227,7 @@ static int emac_poll(struct napi_struct *napi, int budget) struct net_device *ndev = priv->ndev; struct device *emac_dev = &ndev->dev; u32 status = 0; - u32 num_tx_pkts = 0, num_rx_pkts = 0; + u32 num_rx_pkts = 0; /* Check interrupt vectors and call packet processing */ status = emac_read(EMAC_MACINVECTOR); @@ -1238,8 +1238,7 @@ static int emac_poll(struct napi_struct *napi, int budget) mask = EMAC_DM646X_MAC_IN_VECTOR_TX_INT_VEC; if (status & mask) { - num_tx_pkts = cpdma_chan_process(priv->txchan, - EMAC_DEF_TX_MAX_SERVICE); + cpdma_chan_process(priv->txchan, EMAC_DEF_TX_MAX_SERVICE); } /* TX processing */ mask = EMAC_DM644X_MAC_IN_VECTOR_RX_INT_VEC; diff --git a/drivers/net/ethernet/ti/tlan.c b/drivers/net/ethernet/ti/tlan.c index 76a342ea3797..c7a6af632654 100644 --- a/drivers/net/ethernet/ti/tlan.c +++ b/drivers/net/ethernet/ti/tlan.c @@ -654,7 +654,6 @@ module_exit(tlan_exit); static void __init tlan_eisa_probe(void) { long ioaddr; - int rc = -ENODEV; int irq; u16 device_id; @@ -719,8 +718,7 @@ static void __init tlan_eisa_probe(void) /* Setup the newly found eisa adapter */ - rc = tlan_probe1(NULL, ioaddr, irq, - 12, NULL); + tlan_probe1(NULL, ioaddr, irq, 12, NULL); continue; out: diff --git a/drivers/net/ethernet/via/via-velocity.c b/drivers/net/ethernet/via/via-velocity.c index 6d2a31488a74..722b44604ea8 100644 --- a/drivers/net/ethernet/via/via-velocity.c +++ b/drivers/net/ethernet/via/via-velocity.c @@ -877,26 +877,13 @@ static u32 check_connection_type(struct mac_regs __iomem *regs) */ static int velocity_set_media_mode(struct velocity_info *vptr, u32 mii_status) { - u32 curr_status; struct mac_regs __iomem *regs = vptr->mac_regs; vptr->mii_status = mii_check_media_mode(vptr->mac_regs); - curr_status = vptr->mii_status & (~VELOCITY_LINK_FAIL); /* Set mii link status */ set_mii_flow_control(vptr); - /* - Check if new status is consistent with current status - if (((mii_status & curr_status) & VELOCITY_AUTONEG_ENABLE) || - (mii_status==curr_status)) { - vptr->mii_status=mii_check_media_mode(vptr->mac_regs); - vptr->mii_status=check_connection_type(vptr->mac_regs); - netdev_info(vptr->netdev, "Velocity link no change\n"); - return 0; - } - */ - if (PHYID_GET_PHY_ID(vptr->phy_id) == PHYID_CICADA_CS8201) MII_REG_BITS_ON(AUXCR_MDPPS, MII_NCONFIG, vptr->mac_regs); -- 2.27.0 ^ permalink raw reply related [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 06/11] drivers/net/ethernet: clean up unused assignments @ 2020-09-11 1:23 ` Jesse Brandeburg 0 siblings, 0 replies; 68+ messages in thread From: Jesse Brandeburg @ 2020-09-11 1:23 UTC (permalink / raw) To: intel-wired-lan As part of the W=1 compliation series, these lines all created warnings about unused variables that were assigned a value. Most of them are from register reads, but some are just picking up a return value from a function and never doing anything with it. The register reads should be OK, because the current implementation of readl and friends will always execute even without an lvalue. When it makes sense, just remove the lvalue assignment and the local. Other times, just remove the offending code, and occasionally, just mark the variable as maybe unused since it could be used in an ifdef or debug scenario. Only compile tested with W=1 and an allyesconfig with all the network drivers turned into modules (to try to test all options). Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> --- drivers/net/ethernet/brocade/bna/bnad.c | 7 ++-- .../net/ethernet/cavium/liquidio/lio_main.c | 4 +-- .../ethernet/cavium/liquidio/octeon_device.c | 13 ++++---- drivers/net/ethernet/cortina/gemini.c | 6 ++-- drivers/net/ethernet/dec/tulip/de4x5.c | 4 +-- drivers/net/ethernet/dec/tulip/media.c | 5 --- drivers/net/ethernet/dnet.c | 8 ++--- drivers/net/ethernet/freescale/fec_ptp.c | 3 +- drivers/net/ethernet/marvell/mvneta.c | 7 ++-- drivers/net/ethernet/marvell/pxa168_eth.c | 3 +- drivers/net/ethernet/mellanox/mlx4/en_tx.c | 2 +- drivers/net/ethernet/micrel/ksz884x.c | 13 +++----- drivers/net/ethernet/microchip/lan743x_main.c | 9 ++---- drivers/net/ethernet/neterion/vxge/vxge-reg.h | 4 +-- .../net/ethernet/neterion/vxge/vxge-traffic.c | 32 +++++++------------ .../ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 3 +- drivers/net/ethernet/sfc/falcon/farch.c | 29 +++++++---------- drivers/net/ethernet/sis/sis900.c | 5 ++- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 4 +-- .../net/ethernet/synopsys/dwc-xlgmac-common.c | 2 +- drivers/net/ethernet/ti/cpsw_new.c | 2 -- drivers/net/ethernet/ti/davinci_emac.c | 5 ++- drivers/net/ethernet/ti/tlan.c | 4 +-- drivers/net/ethernet/via/via-velocity.c | 13 -------- 24 files changed, 65 insertions(+), 122 deletions(-) diff --git a/drivers/net/ethernet/brocade/bna/bnad.c b/drivers/net/ethernet/brocade/bna/bnad.c index cc80bbbefe87..7e4e831d720f 100644 --- a/drivers/net/ethernet/brocade/bna/bnad.c +++ b/drivers/net/ethernet/brocade/bna/bnad.c @@ -3277,7 +3277,7 @@ bnad_change_mtu(struct net_device *netdev, int new_mtu) { int err, mtu; struct bnad *bnad = netdev_priv(netdev); - u32 rx_count = 0, frame, new_frame; + u32 frame, new_frame; mutex_lock(&bnad->conf_mutex); @@ -3293,12 +3293,9 @@ bnad_change_mtu(struct net_device *netdev, int new_mtu) /* only when transition is over 4K */ if ((frame <= 4096 && new_frame > 4096) || (frame > 4096 && new_frame <= 4096)) - rx_count = bnad_reinit_rx(bnad); + bnad_reinit_rx(bnad); } - /* rx_count > 0 - new rx created - * - Linux set err = 0 and return - */ err = bnad_mtu_set(bnad, new_frame); if (err) err = -EBUSY; diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c b/drivers/net/ethernet/cavium/liquidio/lio_main.c index 8e0ed01e7f03..737ae69eec6e 100644 --- a/drivers/net/ethernet/cavium/liquidio/lio_main.c +++ b/drivers/net/ethernet/cavium/liquidio/lio_main.c @@ -1,4 +1,4 @@ -/********************************************************************** +/* * Author: Cavium, Inc. * * Contact: support at cavium.com @@ -14,7 +14,7 @@ * AS-IS and WITHOUT ANY WARRANTY; without even the implied warranty * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE, TITLE, or * NONINFRINGEMENT. See the GNU General Public License for more details. - ***********************************************************************/ + */ #include <linux/module.h> #include <linux/interrupt.h> #include <linux/pci.h> diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_device.c b/drivers/net/ethernet/cavium/liquidio/octeon_device.c index ac32facaa427..1db29ffde3e5 100644 --- a/drivers/net/ethernet/cavium/liquidio/octeon_device.c +++ b/drivers/net/ethernet/cavium/liquidio/octeon_device.c @@ -1,4 +1,4 @@ -/********************************************************************** +/* * Author: Cavium, Inc. * * Contact: support at cavium.com @@ -14,7 +14,7 @@ * AS-IS and WITHOUT ANY WARRANTY; without even the implied warranty * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE, TITLE, or * NONINFRINGEMENT. See the GNU General Public License for more details. - ***********************************************************************/ + */ #include <linux/pci.h> #include <linux/netdevice.h> #include <linux/vmalloc.h> @@ -1324,7 +1324,7 @@ u64 lio_pci_readq(struct octeon_device *oct, u64 addr) { u64 val64; unsigned long flags; - u32 val32, addrhi; + u32 addrhi; spin_lock_irqsave(&oct->pci_win_lock, flags); @@ -1339,10 +1339,10 @@ u64 lio_pci_readq(struct octeon_device *oct, u64 addr) writel(addrhi, oct->reg_list.pci_win_rd_addr_hi); /* Read back to preserve ordering of writes */ - val32 = readl(oct->reg_list.pci_win_rd_addr_hi); + readl(oct->reg_list.pci_win_rd_addr_hi); writel(addr & 0xffffffff, oct->reg_list.pci_win_rd_addr_lo); - val32 = readl(oct->reg_list.pci_win_rd_addr_lo); + readl(oct->reg_list.pci_win_rd_addr_lo); val64 = readq(oct->reg_list.pci_win_rd_data); @@ -1355,7 +1355,6 @@ void lio_pci_writeq(struct octeon_device *oct, u64 val, u64 addr) { - u32 val32; unsigned long flags; spin_lock_irqsave(&oct->pci_win_lock, flags); @@ -1365,7 +1364,7 @@ void lio_pci_writeq(struct octeon_device *oct, /* The write happens when the LSB is written. So write MSB first. */ writel(val >> 32, oct->reg_list.pci_win_wr_data_hi); /* Read the MSB to ensure ordering of writes. */ - val32 = readl(oct->reg_list.pci_win_wr_data_hi); + readl(oct->reg_list.pci_win_wr_data_hi); writel(val & 0xffffffff, oct->reg_list.pci_win_wr_data_lo); diff --git a/drivers/net/ethernet/cortina/gemini.c b/drivers/net/ethernet/cortina/gemini.c index 9dcf47f576c6..07e9dee03c98 100644 --- a/drivers/net/ethernet/cortina/gemini.c +++ b/drivers/net/ethernet/cortina/gemini.c @@ -509,7 +509,6 @@ static int gmac_init(struct net_device *netdev) .rel_threshold = 0, } }; union gmac_config0 tmp; - u32 val; config0.bits.max_len = gmac_pick_rx_max_len(netdev->mtu); tmp.bits32 = readl(port->gmac_base + GMAC_CONFIG0); @@ -519,7 +518,7 @@ static int gmac_init(struct net_device *netdev) writel(config2.bits32, port->gmac_base + GMAC_CONFIG2); writel(config3.bits32, port->gmac_base + GMAC_CONFIG3); - val = readl(port->dma_base + GMAC_AHB_WEIGHT_REG); + readl(port->dma_base + GMAC_AHB_WEIGHT_REG); writel(ahb_weight.bits32, port->dma_base + GMAC_AHB_WEIGHT_REG); writel(hw_weigh.bits32, @@ -2107,9 +2106,8 @@ static void gmac_get_ringparam(struct net_device *netdev, struct ethtool_ringparam *rp) { struct gemini_ethernet_port *port = netdev_priv(netdev); - union gmac_config0 config0; - config0.bits32 = readl(port->gmac_base + GMAC_CONFIG0); + readl(port->gmac_base + GMAC_CONFIG0); rp->rx_max_pending = 1 << 15; rp->rx_mini_max_pending = 0; diff --git a/drivers/net/ethernet/dec/tulip/de4x5.c b/drivers/net/ethernet/dec/tulip/de4x5.c index f9dd1aa9f2da..683e328b5461 100644 --- a/drivers/net/ethernet/dec/tulip/de4x5.c +++ b/drivers/net/ethernet/dec/tulip/de4x5.c @@ -4925,11 +4925,11 @@ mii_get_oui(u_char phyaddr, u_long ioaddr) u_char breg[2]; } a; int i, r2, r3, ret=0;*/ - int r2, r3; + int r2; /* Read r2 and r3 */ r2 = mii_rd(MII_ID0, phyaddr, ioaddr); - r3 = mii_rd(MII_ID1, phyaddr, ioaddr); + mii_rd(MII_ID1, phyaddr, ioaddr); /* SEEQ and Cypress way * / / * Shuffle r2 and r3 * / a.reg=0; diff --git a/drivers/net/ethernet/dec/tulip/media.c b/drivers/net/ethernet/dec/tulip/media.c index dcf21a36a9cf..011604787b8e 100644 --- a/drivers/net/ethernet/dec/tulip/media.c +++ b/drivers/net/ethernet/dec/tulip/media.c @@ -319,13 +319,8 @@ void tulip_select_media(struct net_device *dev, int startup) break; } case 5: case 6: { - u16 setup[5]; - new_csr6 = 0; /* FIXME */ - for (i = 0; i < 5; i++) - setup[i] = get_u16(&p[i*2 + 1]); - if (startup && mtable->has_reset) { struct medialeaf *rleaf = &mtable->mleaf[mtable->has_reset]; unsigned char *rst = rleaf->leafdata; diff --git a/drivers/net/ethernet/dnet.c b/drivers/net/ethernet/dnet.c index 3143df9a398c..48c6eb142dcc 100644 --- a/drivers/net/ethernet/dnet.c +++ b/drivers/net/ethernet/dnet.c @@ -507,12 +507,12 @@ static netdev_tx_t dnet_start_xmit(struct sk_buff *skb, struct net_device *dev) { struct dnet *bp = netdev_priv(dev); - u32 tx_status, irq_enable; unsigned int i, tx_cmd, wrsz; unsigned long flags; unsigned int *bufp; + u32 irq_enable; - tx_status = dnet_readl(bp, TX_STATUS); + dnet_readl(bp, TX_STATUS); pr_debug("start_xmit: len %u head %p data %p\n", skb->len, skb->head, skb->data); @@ -520,7 +520,7 @@ static netdev_tx_t dnet_start_xmit(struct sk_buff *skb, struct net_device *dev) spin_lock_irqsave(&bp->lock, flags); - tx_status = dnet_readl(bp, TX_STATUS); + dnet_readl(bp, TX_STATUS); bufp = (unsigned int *)(((unsigned long) skb->data) & ~0x3UL); wrsz = (u32) skb->len + 3; @@ -542,7 +542,7 @@ static netdev_tx_t dnet_start_xmit(struct sk_buff *skb, struct net_device *dev) if (dnet_readl(bp, TX_FIFO_WCNT) > DNET_FIFO_TX_DATA_AF_TH) { netif_stop_queue(dev); - tx_status = dnet_readl(bp, INTR_SRC); + dnet_readl(bp, INTR_SRC); irq_enable = dnet_readl(bp, INTR_ENB); irq_enable |= DNET_INTR_ENB_TX_FIFOAE; dnet_writel(bp, irq_enable, INTR_ENB); diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/ethernet/freescale/fec_ptp.c index a0c1f4410306..0405a3975f3f 100644 --- a/drivers/net/ethernet/freescale/fec_ptp.c +++ b/drivers/net/ethernet/freescale/fec_ptp.c @@ -520,13 +520,12 @@ static void fec_time_keep(struct work_struct *work) { struct delayed_work *dwork = to_delayed_work(work); struct fec_enet_private *fep = container_of(dwork, struct fec_enet_private, time_keep); - u64 ns; unsigned long flags; mutex_lock(&fep->ptp_clk_mutex); if (fep->ptp_clk_on) { spin_lock_irqsave(&fep->tmreg_lock, flags); - ns = timecounter_read(&fep->tc); + timecounter_read(&fep->tc); spin_unlock_irqrestore(&fep->tmreg_lock, flags); } mutex_unlock(&fep->ptp_clk_mutex); diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index f75e05e899bb..4694242b7b3b 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c @@ -751,13 +751,12 @@ static void mvneta_txq_inc_put(struct mvneta_tx_queue *txq) static void mvneta_mib_counters_clear(struct mvneta_port *pp) { int i; - u32 dummy; /* Perform dummy reads from MIB counters */ for (i = 0; i < MVNETA_MIB_LATE_COLLISION; i += 4) - dummy = mvreg_read(pp, (MVNETA_MIB_COUNTERS_BASE + i)); - dummy = mvreg_read(pp, MVNETA_RX_DISCARD_FRAME_COUNT); - dummy = mvreg_read(pp, MVNETA_OVERRUN_FRAME_COUNT); + mvreg_read(pp, (MVNETA_MIB_COUNTERS_BASE + i)); + mvreg_read(pp, MVNETA_RX_DISCARD_FRAME_COUNT); + mvreg_read(pp, MVNETA_OVERRUN_FRAME_COUNT); } /* Get System Network Statistics */ diff --git a/drivers/net/ethernet/marvell/pxa168_eth.c b/drivers/net/ethernet/marvell/pxa168_eth.c index faac94b2d5ff..d1e4d42e497d 100644 --- a/drivers/net/ethernet/marvell/pxa168_eth.c +++ b/drivers/net/ethernet/marvell/pxa168_eth.c @@ -1187,11 +1187,10 @@ static int pxa168_eth_stop(struct net_device *dev) static int pxa168_eth_change_mtu(struct net_device *dev, int mtu) { - int retval; struct pxa168_eth_private *pep = netdev_priv(dev); dev->mtu = mtu; - retval = set_port_config_ext(pep); + set_port_config_ext(pep); if (!netif_running(dev)) return 0; diff --git a/drivers/net/ethernet/mellanox/mlx4/en_tx.c b/drivers/net/ethernet/mellanox/mlx4/en_tx.c index 9dff7b086c9f..f69ff7fbf619 100644 --- a/drivers/net/ethernet/mellanox/mlx4/en_tx.c +++ b/drivers/net/ethernet/mellanox/mlx4/en_tx.c @@ -842,6 +842,7 @@ netdev_tx_t mlx4_en_xmit(struct sk_buff *skb, struct net_device *dev) struct mlx4_en_tx_desc *tx_desc; struct mlx4_wqe_data_seg *data; struct mlx4_en_tx_info *tx_info; + u32 __maybe_unused ring_cons; int tx_ind; int nr_txbb; int desc_size; @@ -855,7 +856,6 @@ netdev_tx_t mlx4_en_xmit(struct sk_buff *skb, struct net_device *dev) bool stop_queue; bool inline_ok; u8 data_offset; - u32 ring_cons; bool bf_ok; tx_ind = skb_get_queue_mapping(skb); diff --git a/drivers/net/ethernet/micrel/ksz884x.c b/drivers/net/ethernet/micrel/ksz884x.c index bb646b65cc95..c84a1e8c918b 100644 --- a/drivers/net/ethernet/micrel/ksz884x.c +++ b/drivers/net/ethernet/micrel/ksz884x.c @@ -1649,8 +1649,7 @@ static inline void set_tx_len(struct ksz_desc *desc, u32 len) #define HW_DELAY(hw, reg) \ do { \ - u16 dummy; \ - dummy = readw(hw->io + reg); \ + readw(hw->io + reg); \ } while (0) /** @@ -4978,7 +4977,6 @@ static inline int rx_proc(struct net_device *dev, struct ksz_hw* hw, struct dev_info *hw_priv = priv->adapter; struct ksz_dma_buf *dma_buf; struct sk_buff *skb; - int rx_status; /* Received length includes 4-byte CRC. */ packet_len = status.rx.frame_len - 4; @@ -5014,7 +5012,7 @@ static inline int rx_proc(struct net_device *dev, struct ksz_hw* hw, dev->stats.rx_bytes += packet_len; /* Notify upper layer for received packet. */ - rx_status = netif_rx(skb); + netif_rx(skb); return 0; } @@ -6509,7 +6507,6 @@ static void netdev_get_ethtool_stats(struct net_device *dev, int i; int n; int p; - int rc; u64 counter[TOTAL_PORT_COUNTER_NUM]; mutex_lock(&hw_priv->lock); @@ -6530,19 +6527,19 @@ static void netdev_get_ethtool_stats(struct net_device *dev, if (1 == port->mib_port_cnt && n < SWITCH_PORT_NUM) { p = n; - rc = wait_event_interruptible_timeout( + wait_event_interruptible_timeout( hw_priv->counter[p].counter, 2 == hw_priv->counter[p].read, HZ * 1); } else for (i = 0, p = n; i < port->mib_port_cnt - n; i++, p++) { if (0 == i) { - rc = wait_event_interruptible_timeout( + wait_event_interruptible_timeout( hw_priv->counter[p].counter, 2 == hw_priv->counter[p].read, HZ * 2); } else if (hw->port_mib[p].cnt_ptr) { - rc = wait_event_interruptible_timeout( + wait_event_interruptible_timeout( hw_priv->counter[p].counter, 2 == hw_priv->counter[p].read, HZ * 1); diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/ethernet/microchip/lan743x_main.c index de93cc6ebc1a..4561021a5b1a 100644 --- a/drivers/net/ethernet/microchip/lan743x_main.c +++ b/drivers/net/ethernet/microchip/lan743x_main.c @@ -158,9 +158,8 @@ static void lan743x_tx_isr(void *context, u32 int_sts, u32 flags) struct lan743x_tx *tx = context; struct lan743x_adapter *adapter = tx->adapter; bool enable_flag = true; - u32 int_en = 0; - int_en = lan743x_csr_read(adapter, INT_EN_SET); + lan743x_csr_read(adapter, INT_EN_SET); if (flags & LAN743X_VECTOR_FLAG_SOURCE_ENABLE_CLEAR) { lan743x_csr_write(adapter, INT_EN_CLR, INT_BIT_DMA_TX_(tx->channel_number)); @@ -1699,10 +1698,9 @@ static int lan743x_tx_napi_poll(struct napi_struct *napi, int weight) bool start_transmitter = false; unsigned long irq_flags = 0; u32 ioc_bit = 0; - u32 int_sts = 0; ioc_bit = DMAC_INT_BIT_TX_IOC_(tx->channel_number); - int_sts = lan743x_csr_read(adapter, DMAC_INT_STS); + lan743x_csr_read(adapter, DMAC_INT_STS); if (tx->vector_flags & LAN743X_VECTOR_FLAG_SOURCE_STATUS_W2C) lan743x_csr_write(adapter, DMAC_INT_STS, ioc_bit); spin_lock_irqsave(&tx->ring_lock, irq_flags); @@ -3038,7 +3036,6 @@ static int lan743x_pm_suspend(struct device *dev) struct pci_dev *pdev = to_pci_dev(dev); struct net_device *netdev = pci_get_drvdata(pdev); struct lan743x_adapter *adapter = netdev_priv(netdev); - int ret; lan743x_pcidev_shutdown(pdev); @@ -3051,7 +3048,7 @@ static int lan743x_pm_suspend(struct device *dev) lan743x_pm_set_wol(adapter); /* Host sets PME_En, put D3hot */ - ret = pci_prepare_to_sleep(pdev); + pci_prepare_to_sleep(pdev); return 0; } diff --git a/drivers/net/ethernet/neterion/vxge/vxge-reg.h b/drivers/net/ethernet/neterion/vxge/vxge-reg.h index 3e658b175947..3bb03b9c39b7 100644 --- a/drivers/net/ethernet/neterion/vxge/vxge-reg.h +++ b/drivers/net/ethernet/neterion/vxge/vxge-reg.h @@ -1,4 +1,4 @@ -/****************************************************************************** +/* * This software may be used and distributed according to the terms of * the GNU General Public License (GPL), incorporated herein by reference. * Drivers based on or derived from this code fall under the GPL and must @@ -10,7 +10,7 @@ * vxge-reg.h: Driver for Exar Corp's X3100 Series 10GbE PCIe I/O Virtualized * Server Adapter. * Copyright(c) 2002-2010 Exar Corp. - ******************************************************************************/ + */ #ifndef VXGE_REG_H #define VXGE_REG_H diff --git a/drivers/net/ethernet/neterion/vxge/vxge-traffic.c b/drivers/net/ethernet/neterion/vxge/vxge-traffic.c index 709d20d9938f..bd525e8eda10 100644 --- a/drivers/net/ethernet/neterion/vxge/vxge-traffic.c +++ b/drivers/net/ethernet/neterion/vxge/vxge-traffic.c @@ -30,8 +30,6 @@ */ enum vxge_hw_status vxge_hw_vpath_intr_enable(struct __vxge_hw_vpath_handle *vp) { - u64 val64; - struct __vxge_hw_virtualpath *vpath; struct vxge_hw_vpath_reg __iomem *vp_reg; enum vxge_hw_status status = VXGE_HW_OK; @@ -84,7 +82,7 @@ enum vxge_hw_status vxge_hw_vpath_intr_enable(struct __vxge_hw_vpath_handle *vp) __vxge_hw_pio_mem_write32_upper((u32)VXGE_HW_INTR_MASK_ALL, &vp_reg->xgmac_vp_int_status); - val64 = readq(&vp_reg->vpath_general_int_status); + readq(&vp_reg->vpath_general_int_status); /* Mask unwanted interrupts */ @@ -157,8 +155,6 @@ enum vxge_hw_status vxge_hw_vpath_intr_enable(struct __vxge_hw_vpath_handle *vp) enum vxge_hw_status vxge_hw_vpath_intr_disable( struct __vxge_hw_vpath_handle *vp) { - u64 val64; - struct __vxge_hw_virtualpath *vpath; enum vxge_hw_status status = VXGE_HW_OK; struct vxge_hw_vpath_reg __iomem *vp_reg; @@ -179,8 +175,6 @@ enum vxge_hw_status vxge_hw_vpath_intr_disable( (u32)VXGE_HW_INTR_MASK_ALL, &vp_reg->vpath_general_int_mask); - val64 = VXGE_HW_TIM_CLR_INT_EN_VP(1 << (16 - vpath->vp_id)); - writeq(VXGE_HW_INTR_MASK_ALL, &vp_reg->kdfcctl_errors_mask); __vxge_hw_pio_mem_write32_upper((u32)VXGE_HW_INTR_MASK_ALL, @@ -487,9 +481,7 @@ void vxge_hw_device_unmask_all(struct __vxge_hw_device *hldev) */ void vxge_hw_device_flush_io(struct __vxge_hw_device *hldev) { - u32 val32; - - val32 = readl(&hldev->common_reg->titan_general_int_status); + readl(&hldev->common_reg->titan_general_int_status); } /** @@ -1716,8 +1708,8 @@ void vxge_hw_fifo_txdl_free(struct __vxge_hw_fifo *fifo, void *txdlh) enum vxge_hw_status vxge_hw_vpath_mac_addr_add( struct __vxge_hw_vpath_handle *vp, - u8 (macaddr)[ETH_ALEN], - u8 (macaddr_mask)[ETH_ALEN], + u8 *macaddr, + u8 *macaddr_mask, enum vxge_hw_vpath_mac_addr_add_mode duplicate_mode) { u32 i; @@ -1779,8 +1771,8 @@ vxge_hw_vpath_mac_addr_add( enum vxge_hw_status vxge_hw_vpath_mac_addr_get( struct __vxge_hw_vpath_handle *vp, - u8 (macaddr)[ETH_ALEN], - u8 (macaddr_mask)[ETH_ALEN]) + u8 *macaddr, + u8 *macaddr_mask) { u32 i; u64 data1 = 0ULL; @@ -1831,8 +1823,8 @@ vxge_hw_vpath_mac_addr_get( enum vxge_hw_status vxge_hw_vpath_mac_addr_get_next( struct __vxge_hw_vpath_handle *vp, - u8 (macaddr)[ETH_ALEN], - u8 (macaddr_mask)[ETH_ALEN]) + u8 *macaddr, + u8 *macaddr_mask) { u32 i; u64 data1 = 0ULL; @@ -1884,8 +1876,8 @@ vxge_hw_vpath_mac_addr_get_next( enum vxge_hw_status vxge_hw_vpath_mac_addr_delete( struct __vxge_hw_vpath_handle *vp, - u8 (macaddr)[ETH_ALEN], - u8 (macaddr_mask)[ETH_ALEN]) + u8 *macaddr, + u8 *macaddr_mask) { u32 i; u64 data1 = 0ULL; @@ -2375,7 +2367,6 @@ enum vxge_hw_status vxge_hw_vpath_poll_rx(struct __vxge_hw_ring *ring) u8 t_code; enum vxge_hw_status status = VXGE_HW_OK; void *first_rxdh; - u64 val64 = 0; int new_count = 0; ring->cmpl_cnt = 0; @@ -2403,8 +2394,7 @@ enum vxge_hw_status vxge_hw_vpath_poll_rx(struct __vxge_hw_ring *ring) } writeq(VXGE_HW_PRC_RXD_DOORBELL_NEW_QW_CNT(new_count), &ring->vp_reg->prc_rxd_doorbell); - val64 = - readl(&ring->common_reg->titan_general_int_status); + readl(&ring->common_reg->titan_general_int_status); ring->doorbell_cnt = 0; } } diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c index 29b9c728a65e..fc490881cd03 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c @@ -658,11 +658,10 @@ int qlcnic_83xx_cam_lock(struct qlcnic_adapter *adapter) void qlcnic_83xx_cam_unlock(struct qlcnic_adapter *adapter) { void __iomem *addr; - u32 val; struct qlcnic_hardware_context *ahw = adapter->ahw; addr = ahw->pci_base0 + QLC_83XX_SEM_UNLOCK_FUNC(ahw->pci_func); - val = readl(addr); + readl(addr); } void qlcnic_83xx_read_crb(struct qlcnic_adapter *adapter, char *buf, diff --git a/drivers/net/ethernet/sfc/falcon/farch.c b/drivers/net/ethernet/sfc/falcon/farch.c index fa1ade856b10..2c91792cec01 100644 --- a/drivers/net/ethernet/sfc/falcon/farch.c +++ b/drivers/net/ethernet/sfc/falcon/farch.c @@ -870,17 +870,12 @@ static u16 ef4_farch_handle_rx_not_ok(struct ef4_rx_queue *rx_queue, { struct ef4_channel *channel = ef4_rx_queue_channel(rx_queue); struct ef4_nic *efx = rx_queue->efx; - bool rx_ev_buf_owner_id_err, rx_ev_ip_hdr_chksum_err; + bool __maybe_unused rx_ev_buf_owner_id_err, rx_ev_ip_hdr_chksum_err; bool rx_ev_tcp_udp_chksum_err, rx_ev_eth_crc_err; bool rx_ev_frm_trunc, rx_ev_drib_nib, rx_ev_tobe_disc; - bool rx_ev_other_err, rx_ev_pause_frm; - bool rx_ev_hdr_type, rx_ev_mcast_pkt; - unsigned rx_ev_pkt_type; + bool rx_ev_pause_frm; - rx_ev_hdr_type = EF4_QWORD_FIELD(*event, FSF_AZ_RX_EV_HDR_TYPE); - rx_ev_mcast_pkt = EF4_QWORD_FIELD(*event, FSF_AZ_RX_EV_MCAST_PKT); rx_ev_tobe_disc = EF4_QWORD_FIELD(*event, FSF_AZ_RX_EV_TOBE_DISC); - rx_ev_pkt_type = EF4_QWORD_FIELD(*event, FSF_AZ_RX_EV_PKT_TYPE); rx_ev_buf_owner_id_err = EF4_QWORD_FIELD(*event, FSF_AZ_RX_EV_BUF_OWNER_ID_ERR); rx_ev_ip_hdr_chksum_err = EF4_QWORD_FIELD(*event, @@ -893,10 +888,6 @@ static u16 ef4_farch_handle_rx_not_ok(struct ef4_rx_queue *rx_queue, 0 : EF4_QWORD_FIELD(*event, FSF_AA_RX_EV_DRIB_NIB)); rx_ev_pause_frm = EF4_QWORD_FIELD(*event, FSF_AZ_RX_EV_PAUSE_FRM_ERR); - /* Every error apart from tobe_disc and pause_frm */ - rx_ev_other_err = (rx_ev_drib_nib | rx_ev_tcp_udp_chksum_err | - rx_ev_buf_owner_id_err | rx_ev_eth_crc_err | - rx_ev_frm_trunc | rx_ev_ip_hdr_chksum_err); /* Count errors that are not in MAC stats. Ignore expected * checksum errors during self-test. */ @@ -916,6 +907,13 @@ static u16 ef4_farch_handle_rx_not_ok(struct ef4_rx_queue *rx_queue, * to a FIFO overflow. */ #ifdef DEBUG + { + /* Every error apart from tobe_disc and pause_frm */ + + bool rx_ev_other_err = (rx_ev_drib_nib | rx_ev_tcp_udp_chksum_err | + rx_ev_buf_owner_id_err | rx_ev_eth_crc_err | + rx_ev_frm_trunc | rx_ev_ip_hdr_chksum_err); + if (rx_ev_other_err && net_ratelimit()) { netif_dbg(efx, rx_err, efx->net_dev, " RX queue %d unexpected RX event " @@ -932,6 +930,7 @@ static u16 ef4_farch_handle_rx_not_ok(struct ef4_rx_queue *rx_queue, rx_ev_tobe_disc ? " [TOBE_DISC]" : "", rx_ev_pause_frm ? " [PAUSE]" : ""); } + } #endif /* The frame must be discarded if any of these are true. */ @@ -1643,15 +1642,11 @@ void ef4_farch_rx_push_indir_table(struct ef4_nic *efx) */ void ef4_farch_dimension_resources(struct ef4_nic *efx, unsigned sram_lim_qw) { - unsigned vi_count, buftbl_min; + unsigned vi_count; /* Account for the buffer table entries backing the datapath channels * and the descriptor caches for those channels. */ - buftbl_min = ((efx->n_rx_channels * EF4_MAX_DMAQ_SIZE + - efx->n_tx_channels * EF4_TXQ_TYPES * EF4_MAX_DMAQ_SIZE + - efx->n_channels * EF4_MAX_EVQ_SIZE) - * sizeof(ef4_qword_t) / EF4_BUF_SIZE); vi_count = max(efx->n_channels, efx->n_tx_channels * EF4_TXQ_TYPES); efx->tx_dc_base = sram_lim_qw - vi_count * TX_DC_ENTRIES; @@ -2532,7 +2527,6 @@ int ef4_farch_filter_remove_safe(struct ef4_nic *efx, enum ef4_farch_filter_table_id table_id; struct ef4_farch_filter_table *table; unsigned int filter_idx; - struct ef4_farch_filter_spec *spec; int rc; table_id = ef4_farch_filter_id_table_id(filter_id); @@ -2543,7 +2537,6 @@ int ef4_farch_filter_remove_safe(struct ef4_nic *efx, filter_idx = ef4_farch_filter_id_index(filter_id); if (filter_idx >= table->size) return -ENOENT; - spec = &table->spec[filter_idx]; spin_lock_bh(&efx->filter_lock); rc = ef4_farch_filter_remove(efx, table, filter_idx, priority); diff --git a/drivers/net/ethernet/sis/sis900.c b/drivers/net/ethernet/sis/sis900.c index cfa460c7db23..869b7618e2ba 100644 --- a/drivers/net/ethernet/sis/sis900.c +++ b/drivers/net/ethernet/sis/sis900.c @@ -789,10 +789,9 @@ static u16 sis900_default_phy(struct net_device * net_dev) static void sis900_set_capability(struct net_device *net_dev, struct mii_phy *phy) { u16 cap; - u16 status; - status = mdio_read(net_dev, phy->phy_addr, MII_STATUS); - status = mdio_read(net_dev, phy->phy_addr, MII_STATUS); + mdio_read(net_dev, phy->phy_addr, MII_STATUS); + mdio_read(net_dev, phy->phy_addr, MII_STATUS); cap = MII_NWAY_CSMA_CD | ((phy->status & MII_STAT_CAN_TX_FDX)? MII_NWAY_TX_FDX:0) | diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index c553047ff482..3fa24b310d20 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -3630,15 +3630,15 @@ static unsigned int stmmac_rx_buf1_len(struct stmmac_priv *priv, struct dma_desc *p, int status, unsigned int len) { - int ret, coe = priv->hw->rx_csum; unsigned int plen = 0, hlen = 0; + int coe = priv->hw->rx_csum; /* Not first descriptor, buffer is always zero */ if (priv->sph && len) return 0; /* First descriptor, get split header length */ - ret = stmmac_get_rx_header_len(priv, p, &hlen); + stmmac_get_rx_header_len(priv, p, &hlen); if (priv->sph && hlen) { priv->xstats.rx_split_hdr_pkt_n++; return hlen; diff --git a/drivers/net/ethernet/synopsys/dwc-xlgmac-common.c b/drivers/net/ethernet/synopsys/dwc-xlgmac-common.c index eb1c6b03c329..df26cea45904 100644 --- a/drivers/net/ethernet/synopsys/dwc-xlgmac-common.c +++ b/drivers/net/ethernet/synopsys/dwc-xlgmac-common.c @@ -513,7 +513,7 @@ void xlgmac_get_all_hw_features(struct xlgmac_pdata *pdata) void xlgmac_print_all_hw_features(struct xlgmac_pdata *pdata) { - char *str = NULL; + char __maybe_unused *str = NULL; XLGMAC_PR("\n"); XLGMAC_PR("=====================================================\n"); diff --git a/drivers/net/ethernet/ti/cpsw_new.c b/drivers/net/ethernet/ti/cpsw_new.c index 8ed78577cded..f62f7fa7edae 100644 --- a/drivers/net/ethernet/ti/cpsw_new.c +++ b/drivers/net/ethernet/ti/cpsw_new.c @@ -1660,12 +1660,10 @@ static int cpsw_dl_switch_mode_set(struct devlink *dl, u32 id, for (i = 0; i < cpsw->data.slaves; i++) { struct cpsw_slave *slave = &cpsw->slaves[i]; struct net_device *sl_ndev = slave->ndev; - struct cpsw_priv *priv; if (!sl_ndev) continue; - priv = netdev_priv(sl_ndev); if (switch_en) vlan = cpsw->data.default_vlan; else diff --git a/drivers/net/ethernet/ti/davinci_emac.c b/drivers/net/ethernet/ti/davinci_emac.c index de282531f68b..b36d0e412d23 100644 --- a/drivers/net/ethernet/ti/davinci_emac.c +++ b/drivers/net/ethernet/ti/davinci_emac.c @@ -1227,7 +1227,7 @@ static int emac_poll(struct napi_struct *napi, int budget) struct net_device *ndev = priv->ndev; struct device *emac_dev = &ndev->dev; u32 status = 0; - u32 num_tx_pkts = 0, num_rx_pkts = 0; + u32 num_rx_pkts = 0; /* Check interrupt vectors and call packet processing */ status = emac_read(EMAC_MACINVECTOR); @@ -1238,8 +1238,7 @@ static int emac_poll(struct napi_struct *napi, int budget) mask = EMAC_DM646X_MAC_IN_VECTOR_TX_INT_VEC; if (status & mask) { - num_tx_pkts = cpdma_chan_process(priv->txchan, - EMAC_DEF_TX_MAX_SERVICE); + cpdma_chan_process(priv->txchan, EMAC_DEF_TX_MAX_SERVICE); } /* TX processing */ mask = EMAC_DM644X_MAC_IN_VECTOR_RX_INT_VEC; diff --git a/drivers/net/ethernet/ti/tlan.c b/drivers/net/ethernet/ti/tlan.c index 76a342ea3797..c7a6af632654 100644 --- a/drivers/net/ethernet/ti/tlan.c +++ b/drivers/net/ethernet/ti/tlan.c @@ -654,7 +654,6 @@ module_exit(tlan_exit); static void __init tlan_eisa_probe(void) { long ioaddr; - int rc = -ENODEV; int irq; u16 device_id; @@ -719,8 +718,7 @@ static void __init tlan_eisa_probe(void) /* Setup the newly found eisa adapter */ - rc = tlan_probe1(NULL, ioaddr, irq, - 12, NULL); + tlan_probe1(NULL, ioaddr, irq, 12, NULL); continue; out: diff --git a/drivers/net/ethernet/via/via-velocity.c b/drivers/net/ethernet/via/via-velocity.c index 6d2a31488a74..722b44604ea8 100644 --- a/drivers/net/ethernet/via/via-velocity.c +++ b/drivers/net/ethernet/via/via-velocity.c @@ -877,26 +877,13 @@ static u32 check_connection_type(struct mac_regs __iomem *regs) */ static int velocity_set_media_mode(struct velocity_info *vptr, u32 mii_status) { - u32 curr_status; struct mac_regs __iomem *regs = vptr->mac_regs; vptr->mii_status = mii_check_media_mode(vptr->mac_regs); - curr_status = vptr->mii_status & (~VELOCITY_LINK_FAIL); /* Set mii link status */ set_mii_flow_control(vptr); - /* - Check if new status is consistent with current status - if (((mii_status & curr_status) & VELOCITY_AUTONEG_ENABLE) || - (mii_status==curr_status)) { - vptr->mii_status=mii_check_media_mode(vptr->mac_regs); - vptr->mii_status=check_connection_type(vptr->mac_regs); - netdev_info(vptr->netdev, "Velocity link no change\n"); - return 0; - } - */ - if (PHYID_GET_PHY_ID(vptr->phy_id) == PHYID_CICADA_CS8201) MII_REG_BITS_ON(AUXCR_MDPPS, MII_NCONFIG, vptr->mac_regs); -- 2.27.0 ^ permalink raw reply related [flat|nested] 68+ messages in thread
* Re: [RFC PATCH net-next v1 06/11] drivers/net/ethernet: clean up unused assignments 2020-09-11 1:23 ` [Intel-wired-lan] " Jesse Brandeburg @ 2020-09-11 17:16 ` Edward Cree -1 siblings, 0 replies; 68+ messages in thread From: Edward Cree @ 2020-09-11 17:16 UTC (permalink / raw) To: Jesse Brandeburg, netdev; +Cc: intel-wired-lan On 11/09/2020 02:23, Jesse Brandeburg wrote: > As part of the W=1 compliation series, these lines all created > warnings about unused variables that were assigned a value. Most > of them are from register reads, but some are just picking up > a return value from a function and never doing anything with it. > > The register reads should be OK, because the current > implementation of readl and friends will always execute even > without an lvalue. > > When it makes sense, just remove the lvalue assignment and the > local. Other times, just remove the offending code, and > occasionally, just mark the variable as maybe unused since it > could be used in an ifdef or debug scenario. > > Only compile tested with W=1 and an allyesconfig with all the > network drivers turned into modules (to try to test all options). > > Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> For the sfc/falcon part: Acked-by: Edward Cree <ecree@solarflare.com> (it's not the same as the solution I went with for thevery similar code in the Siena driver (../farch.c), but it looks reasonable enough). ^ permalink raw reply [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 06/11] drivers/net/ethernet: clean up unused assignments @ 2020-09-11 17:16 ` Edward Cree 0 siblings, 0 replies; 68+ messages in thread From: Edward Cree @ 2020-09-11 17:16 UTC (permalink / raw) To: intel-wired-lan On 11/09/2020 02:23, Jesse Brandeburg wrote: > As part of the W=1 compliation series, these lines all created > warnings about unused variables that were assigned a value. Most > of them are from register reads, but some are just picking up > a return value from a function and never doing anything with it. > > The register reads should be OK, because the current > implementation of readl and friends will always execute even > without an lvalue. > > When it makes sense, just remove the lvalue assignment and the > local. Other times, just remove the offending code, and > occasionally, just mark the variable as maybe unused since it > could be used in an ifdef or debug scenario. > > Only compile tested with W=1 and an allyesconfig with all the > network drivers turned into modules (to try to test all options). > > Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> For the sfc/falcon part: Acked-by: Edward Cree <ecree@solarflare.com> (it's not the same as the solution I went with for thevery ?similar code in the Siena driver (../farch.c), but it looks ?reasonable enough). ^ permalink raw reply [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 06/11] drivers/net/ethernet: clean up unused assignments 2020-09-11 1:23 ` [Intel-wired-lan] " Jesse Brandeburg (?) (?) @ 2020-09-11 23:03 ` Jacob Keller 2020-09-11 23:18 ` Jesse Brandeburg -1 siblings, 1 reply; 68+ messages in thread From: Jacob Keller @ 2020-09-11 23:03 UTC (permalink / raw) To: intel-wired-lan On 9/10/2020 6:23 PM, Jesse Brandeburg wrote: > As part of the W=1 compliation series, these lines all created > warnings about unused variables that were assigned a value. Most > of them are from register reads, but some are just picking up > a return value from a function and never doing anything with it. > > The register reads should be OK, because the current > implementation of readl and friends will always execute even > without an lvalue. > > When it makes sense, just remove the lvalue assignment and the > local. Other times, just remove the offending code, and > occasionally, just mark the variable as maybe unused since it > could be used in an ifdef or debug scenario. > > Only compile tested with W=1 and an allyesconfig with all the > network drivers turned into modules (to try to test all options). > > Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> > --- > drivers/net/ethernet/brocade/bna/bnad.c | 7 ++-- > .../net/ethernet/cavium/liquidio/lio_main.c | 4 +-- > .../ethernet/cavium/liquidio/octeon_device.c | 13 ++++---- > drivers/net/ethernet/cortina/gemini.c | 6 ++-- > drivers/net/ethernet/dec/tulip/de4x5.c | 4 +-- > drivers/net/ethernet/dec/tulip/media.c | 5 --- > drivers/net/ethernet/dnet.c | 8 ++--- > drivers/net/ethernet/freescale/fec_ptp.c | 3 +- > drivers/net/ethernet/marvell/mvneta.c | 7 ++-- > drivers/net/ethernet/marvell/pxa168_eth.c | 3 +- > drivers/net/ethernet/mellanox/mlx4/en_tx.c | 2 +- > drivers/net/ethernet/micrel/ksz884x.c | 13 +++----- > drivers/net/ethernet/microchip/lan743x_main.c | 9 ++---- > drivers/net/ethernet/neterion/vxge/vxge-reg.h | 4 +-- > .../net/ethernet/neterion/vxge/vxge-traffic.c | 32 +++++++------------ > .../ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 3 +- > drivers/net/ethernet/sfc/falcon/farch.c | 29 +++++++---------- > drivers/net/ethernet/sis/sis900.c | 5 ++- > .../net/ethernet/stmicro/stmmac/stmmac_main.c | 4 +-- > .../net/ethernet/synopsys/dwc-xlgmac-common.c | 2 +- > drivers/net/ethernet/ti/cpsw_new.c | 2 -- > drivers/net/ethernet/ti/davinci_emac.c | 5 ++- > drivers/net/ethernet/ti/tlan.c | 4 +-- > drivers/net/ethernet/via/via-velocity.c | 13 -------- > 24 files changed, 65 insertions(+), 122 deletions(-) > > diff --git a/drivers/net/ethernet/brocade/bna/bnad.c b/drivers/net/ethernet/brocade/bna/bnad.c > index cc80bbbefe87..7e4e831d720f 100644 > --- a/drivers/net/ethernet/brocade/bna/bnad.c > +++ b/drivers/net/ethernet/brocade/bna/bnad.c > @@ -3277,7 +3277,7 @@ bnad_change_mtu(struct net_device *netdev, int new_mtu) > { > int err, mtu; > struct bnad *bnad = netdev_priv(netdev); > - u32 rx_count = 0, frame, new_frame; > + u32 frame, new_frame; > > mutex_lock(&bnad->conf_mutex); > > @@ -3293,12 +3293,9 @@ bnad_change_mtu(struct net_device *netdev, int new_mtu) > /* only when transition is over 4K */ > if ((frame <= 4096 && new_frame > 4096) || > (frame > 4096 && new_frame <= 4096)) > - rx_count = bnad_reinit_rx(bnad); > + bnad_reinit_rx(bnad); > } > > - /* rx_count > 0 - new rx created > - * - Linux set err = 0 and return > - */ > err = bnad_mtu_set(bnad, new_frame); > if (err) > err = -EBUSY; > diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c b/drivers/net/ethernet/cavium/liquidio/lio_main.c > index 8e0ed01e7f03..737ae69eec6e 100644 > --- a/drivers/net/ethernet/cavium/liquidio/lio_main.c > +++ b/drivers/net/ethernet/cavium/liquidio/lio_main.c > @@ -1,4 +1,4 @@ > -/********************************************************************** > +/* I suspect this was meant to go into the kdoc patch instead? Thanks, Jake ^ permalink raw reply [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 06/11] drivers/net/ethernet: clean up unused assignments 2020-09-11 23:03 ` Jacob Keller @ 2020-09-11 23:18 ` Jesse Brandeburg 0 siblings, 0 replies; 68+ messages in thread From: Jesse Brandeburg @ 2020-09-11 23:18 UTC (permalink / raw) To: intel-wired-lan Jacob Keller wrote: err = -EBUSY; > > diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c b/drivers/net/ethernet/cavium/liquidio/lio_main.c > > index 8e0ed01e7f03..737ae69eec6e 100644 > > --- a/drivers/net/ethernet/cavium/liquidio/lio_main.c > > +++ b/drivers/net/ethernet/cavium/liquidio/lio_main.c > > @@ -1,4 +1,4 @@ > > -/********************************************************************** > > +/* > > I suspect this was meant to go into the kdoc patch instead? Actually it shouldn't be there at all, but it's fixed, thanks! ^ permalink raw reply [flat|nested] 68+ messages in thread
* [RFC PATCH net-next v1 07/11] drivers/net/ethernet: rid ethernet of no-prototype warnings 2020-09-11 1:23 ` [Intel-wired-lan] " Jesse Brandeburg @ 2020-09-11 1:23 ` Jesse Brandeburg -1 siblings, 0 replies; 68+ messages in thread From: Jesse Brandeburg @ 2020-09-11 1:23 UTC (permalink / raw) To: netdev; +Cc: Jesse Brandeburg, intel-wired-lan The W=1 builds showed a few files exporting functions (non-static) that were not prototyped. What actually happened is that there were prototypes, but the include file was forgotten in the implementation file. Add the include file and remove the warnings. Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> --- drivers/net/ethernet/cavium/liquidio/cn68xx_device.c | 1 + drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c | 1 + drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c | 1 + 3 files changed, 3 insertions(+) diff --git a/drivers/net/ethernet/cavium/liquidio/cn68xx_device.c b/drivers/net/ethernet/cavium/liquidio/cn68xx_device.c index 50b533ff58e6..30254e4cf70f 100644 --- a/drivers/net/ethernet/cavium/liquidio/cn68xx_device.c +++ b/drivers/net/ethernet/cavium/liquidio/cn68xx_device.c @@ -25,6 +25,7 @@ #include "octeon_main.h" #include "cn66xx_regs.h" #include "cn66xx_device.h" +#include "cn68xx_device.h" #include "cn68xx_regs.h" static void lio_cn68xx_set_dpi_regs(struct octeon_device *oct) diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c b/drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c index 4c85ae643b7b..7ccab36143c1 100644 --- a/drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c +++ b/drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c @@ -22,6 +22,7 @@ #include "octeon_iq.h" #include "response_manager.h" #include "octeon_device.h" +#include "octeon_mem_ops.h" #define MEMOPS_IDX BAR1_INDEX_DYNAMIC_MAP diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c index d6c3952aba04..f28b8f3df857 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c @@ -3,6 +3,7 @@ #include "hclge_main.h" #include "hclge_tm.h" +#include "hclge_dcb.h" #include "hnae3.h" #define BW_PERCENT 100 -- 2.27.0 ^ permalink raw reply related [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 07/11] drivers/net/ethernet: rid ethernet of no-prototype warnings @ 2020-09-11 1:23 ` Jesse Brandeburg 0 siblings, 0 replies; 68+ messages in thread From: Jesse Brandeburg @ 2020-09-11 1:23 UTC (permalink / raw) To: intel-wired-lan The W=1 builds showed a few files exporting functions (non-static) that were not prototyped. What actually happened is that there were prototypes, but the include file was forgotten in the implementation file. Add the include file and remove the warnings. Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> --- drivers/net/ethernet/cavium/liquidio/cn68xx_device.c | 1 + drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c | 1 + drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c | 1 + 3 files changed, 3 insertions(+) diff --git a/drivers/net/ethernet/cavium/liquidio/cn68xx_device.c b/drivers/net/ethernet/cavium/liquidio/cn68xx_device.c index 50b533ff58e6..30254e4cf70f 100644 --- a/drivers/net/ethernet/cavium/liquidio/cn68xx_device.c +++ b/drivers/net/ethernet/cavium/liquidio/cn68xx_device.c @@ -25,6 +25,7 @@ #include "octeon_main.h" #include "cn66xx_regs.h" #include "cn66xx_device.h" +#include "cn68xx_device.h" #include "cn68xx_regs.h" static void lio_cn68xx_set_dpi_regs(struct octeon_device *oct) diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c b/drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c index 4c85ae643b7b..7ccab36143c1 100644 --- a/drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c +++ b/drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c @@ -22,6 +22,7 @@ #include "octeon_iq.h" #include "response_manager.h" #include "octeon_device.h" +#include "octeon_mem_ops.h" #define MEMOPS_IDX BAR1_INDEX_DYNAMIC_MAP diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c index d6c3952aba04..f28b8f3df857 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c @@ -3,6 +3,7 @@ #include "hclge_main.h" #include "hclge_tm.h" +#include "hclge_dcb.h" #include "hnae3.h" #define BW_PERCENT 100 -- 2.27.0 ^ permalink raw reply related [flat|nested] 68+ messages in thread
* [RFC PATCH net-next v1 08/11] drivers/net/ethernet: handle one warning explicitly 2020-09-11 1:23 ` [Intel-wired-lan] " Jesse Brandeburg @ 2020-09-11 1:23 ` Jesse Brandeburg -1 siblings, 0 replies; 68+ messages in thread From: Jesse Brandeburg @ 2020-09-11 1:23 UTC (permalink / raw) To: netdev; +Cc: Jesse Brandeburg, intel-wired-lan While fixing the W=1 builds, this warning came up because the developers used a very tricky way to get structures initialized to a non-zero value, but this causes GCC to warn about an override. In this case the override was intentional, so just disable the warning for this code with a #pragma. Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> --- drivers/net/ethernet/renesas/sh_eth.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c index 586642c33d2b..659530f9c117 100644 --- a/drivers/net/ethernet/renesas/sh_eth.c +++ b/drivers/net/ethernet/renesas/sh_eth.c @@ -45,6 +45,13 @@ #define SH_ETH_OFFSET_DEFAULTS \ [0 ... SH_ETH_MAX_REGISTER_OFFSET - 1] = SH_ETH_OFFSET_INVALID +/* use some intentionally tricky logic here to initialize the whole struct to + * 0xffff, but then override certain fields, requiring us to indicate that we + * "know" that there are overrides in this structure, and we'll need to disable + * that warning from W=1 builds + */ +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Woverride-init" static const u16 sh_eth_offset_gigabit[SH_ETH_MAX_REGISTER_OFFSET] = { SH_ETH_OFFSET_DEFAULTS, @@ -332,6 +339,7 @@ static const u16 sh_eth_offset_fast_sh3_sh2[SH_ETH_MAX_REGISTER_OFFSET] = { [TSU_ADRH0] = 0x0100, }; +#pragma GCC diagnostic pop static void sh_eth_rcv_snd_disable(struct net_device *ndev); static struct net_device_stats *sh_eth_get_stats(struct net_device *ndev); -- 2.27.0 ^ permalink raw reply related [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 08/11] drivers/net/ethernet: handle one warning explicitly @ 2020-09-11 1:23 ` Jesse Brandeburg 0 siblings, 0 replies; 68+ messages in thread From: Jesse Brandeburg @ 2020-09-11 1:23 UTC (permalink / raw) To: intel-wired-lan While fixing the W=1 builds, this warning came up because the developers used a very tricky way to get structures initialized to a non-zero value, but this causes GCC to warn about an override. In this case the override was intentional, so just disable the warning for this code with a #pragma. Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> --- drivers/net/ethernet/renesas/sh_eth.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c index 586642c33d2b..659530f9c117 100644 --- a/drivers/net/ethernet/renesas/sh_eth.c +++ b/drivers/net/ethernet/renesas/sh_eth.c @@ -45,6 +45,13 @@ #define SH_ETH_OFFSET_DEFAULTS \ [0 ... SH_ETH_MAX_REGISTER_OFFSET - 1] = SH_ETH_OFFSET_INVALID +/* use some intentionally tricky logic here to initialize the whole struct to + * 0xffff, but then override certain fields, requiring us to indicate that we + * "know" that there are overrides in this structure, and we'll need to disable + * that warning from W=1 builds + */ +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Woverride-init" static const u16 sh_eth_offset_gigabit[SH_ETH_MAX_REGISTER_OFFSET] = { SH_ETH_OFFSET_DEFAULTS, @@ -332,6 +339,7 @@ static const u16 sh_eth_offset_fast_sh3_sh2[SH_ETH_MAX_REGISTER_OFFSET] = { [TSU_ADRH0] = 0x0100, }; +#pragma GCC diagnostic pop static void sh_eth_rcv_snd_disable(struct net_device *ndev); static struct net_device_stats *sh_eth_get_stats(struct net_device *ndev); -- 2.27.0 ^ permalink raw reply related [flat|nested] 68+ messages in thread
* Re: [RFC PATCH net-next v1 08/11] drivers/net/ethernet: handle one warning explicitly 2020-09-11 1:23 ` [Intel-wired-lan] " Jesse Brandeburg @ 2020-09-11 22:56 ` Jacob Keller -1 siblings, 0 replies; 68+ messages in thread From: Jacob Keller @ 2020-09-11 22:56 UTC (permalink / raw) To: Jesse Brandeburg, netdev; +Cc: intel-wired-lan On 9/10/2020 6:23 PM, Jesse Brandeburg wrote: > While fixing the W=1 builds, this warning came up because the > developers used a very tricky way to get structures initialized > to a non-zero value, but this causes GCC to warn about an > override. In this case the override was intentional, so just > disable the warning for this code with a #pragma. > > Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> > --- > drivers/net/ethernet/renesas/sh_eth.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c > index 586642c33d2b..659530f9c117 100644 > --- a/drivers/net/ethernet/renesas/sh_eth.c > +++ b/drivers/net/ethernet/renesas/sh_eth.c > @@ -45,6 +45,13 @@ > #define SH_ETH_OFFSET_DEFAULTS \ > [0 ... SH_ETH_MAX_REGISTER_OFFSET - 1] = SH_ETH_OFFSET_INVALID > > +/* use some intentionally tricky logic here to initialize the whole struct to > + * 0xffff, but then override certain fields, requiring us to indicate that we > + * "know" that there are overrides in this structure, and we'll need to disable > + * that warning from W=1 builds > + */ > +#pragma GCC diagnostic push > +#pragma GCC diagnostic ignored "-Woverride-init" This should probably use something like the __diag() macros instead of GCC-specific code, e.g. __diag_push() __diag_ignore(GCC, <version>, "-Woverride-init") ... __diag_pop() Where <version> is the major GCC version that introduced this warning. Thanks, Jake > static const u16 sh_eth_offset_gigabit[SH_ETH_MAX_REGISTER_OFFSET] = { > SH_ETH_OFFSET_DEFAULTS, > > @@ -332,6 +339,7 @@ static const u16 sh_eth_offset_fast_sh3_sh2[SH_ETH_MAX_REGISTER_OFFSET] = { > > [TSU_ADRH0] = 0x0100, > }; > +#pragma GCC diagnostic pop > > static void sh_eth_rcv_snd_disable(struct net_device *ndev); > static struct net_device_stats *sh_eth_get_stats(struct net_device *ndev); > ^ permalink raw reply [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 08/11] drivers/net/ethernet: handle one warning explicitly @ 2020-09-11 22:56 ` Jacob Keller 0 siblings, 0 replies; 68+ messages in thread From: Jacob Keller @ 2020-09-11 22:56 UTC (permalink / raw) To: intel-wired-lan On 9/10/2020 6:23 PM, Jesse Brandeburg wrote: > While fixing the W=1 builds, this warning came up because the > developers used a very tricky way to get structures initialized > to a non-zero value, but this causes GCC to warn about an > override. In this case the override was intentional, so just > disable the warning for this code with a #pragma. > > Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> > --- > drivers/net/ethernet/renesas/sh_eth.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c > index 586642c33d2b..659530f9c117 100644 > --- a/drivers/net/ethernet/renesas/sh_eth.c > +++ b/drivers/net/ethernet/renesas/sh_eth.c > @@ -45,6 +45,13 @@ > #define SH_ETH_OFFSET_DEFAULTS \ > [0 ... SH_ETH_MAX_REGISTER_OFFSET - 1] = SH_ETH_OFFSET_INVALID > > +/* use some intentionally tricky logic here to initialize the whole struct to > + * 0xffff, but then override certain fields, requiring us to indicate that we > + * "know" that there are overrides in this structure, and we'll need to disable > + * that warning from W=1 builds > + */ > +#pragma GCC diagnostic push > +#pragma GCC diagnostic ignored "-Woverride-init" This should probably use something like the __diag() macros instead of GCC-specific code, e.g. __diag_push() __diag_ignore(GCC, <version>, "-Woverride-init") ... __diag_pop() Where <version> is the major GCC version that introduced this warning. Thanks, Jake > static const u16 sh_eth_offset_gigabit[SH_ETH_MAX_REGISTER_OFFSET] = { > SH_ETH_OFFSET_DEFAULTS, > > @@ -332,6 +339,7 @@ static const u16 sh_eth_offset_fast_sh3_sh2[SH_ETH_MAX_REGISTER_OFFSET] = { > > [TSU_ADRH0] = 0x0100, > }; > +#pragma GCC diagnostic pop > > static void sh_eth_rcv_snd_disable(struct net_device *ndev); > static struct net_device_stats *sh_eth_get_stats(struct net_device *ndev); > ^ permalink raw reply [flat|nested] 68+ messages in thread
* [RFC PATCH net-next v1 09/11] drivers/net/ethernet: add some basic kdoc tags 2020-09-11 1:23 ` [Intel-wired-lan] " Jesse Brandeburg @ 2020-09-11 1:23 ` Jesse Brandeburg -1 siblings, 0 replies; 68+ messages in thread From: Jesse Brandeburg @ 2020-09-11 1:23 UTC (permalink / raw) To: netdev; +Cc: Jesse Brandeburg, intel-wired-lan A couple of drivers had a "generic documentation" section that would trigger a "can't understand" message from W=1 compiles. Fix by using correct DOC: tags. Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> --- drivers/net/ethernet/arc/emac_arc.c | 2 +- drivers/net/ethernet/cadence/macb_pci.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/arc/emac_arc.c b/drivers/net/ethernet/arc/emac_arc.c index 1c7736b7eaf7..800620b8f10d 100644 --- a/drivers/net/ethernet/arc/emac_arc.c +++ b/drivers/net/ethernet/arc/emac_arc.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0-or-later /** - * emac_arc.c - ARC EMAC specific glue layer + * DOC: emac_arc.c - ARC EMAC specific glue layer * * Copyright (C) 2014 Romain Perier * diff --git a/drivers/net/ethernet/cadence/macb_pci.c b/drivers/net/ethernet/cadence/macb_pci.c index cd7d0332cba3..35316c91f523 100644 --- a/drivers/net/ethernet/cadence/macb_pci.c +++ b/drivers/net/ethernet/cadence/macb_pci.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0-only /** - * Cadence GEM PCI wrapper. + * DOC: Cadence GEM PCI wrapper. * * Copyright (C) 2016 Cadence Design Systems - https://www.cadence.com * -- 2.27.0 ^ permalink raw reply related [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 09/11] drivers/net/ethernet: add some basic kdoc tags @ 2020-09-11 1:23 ` Jesse Brandeburg 0 siblings, 0 replies; 68+ messages in thread From: Jesse Brandeburg @ 2020-09-11 1:23 UTC (permalink / raw) To: intel-wired-lan A couple of drivers had a "generic documentation" section that would trigger a "can't understand" message from W=1 compiles. Fix by using correct DOC: tags. Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> --- drivers/net/ethernet/arc/emac_arc.c | 2 +- drivers/net/ethernet/cadence/macb_pci.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/arc/emac_arc.c b/drivers/net/ethernet/arc/emac_arc.c index 1c7736b7eaf7..800620b8f10d 100644 --- a/drivers/net/ethernet/arc/emac_arc.c +++ b/drivers/net/ethernet/arc/emac_arc.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0-or-later /** - * emac_arc.c - ARC EMAC specific glue layer + * DOC: emac_arc.c - ARC EMAC specific glue layer * * Copyright (C) 2014 Romain Perier * diff --git a/drivers/net/ethernet/cadence/macb_pci.c b/drivers/net/ethernet/cadence/macb_pci.c index cd7d0332cba3..35316c91f523 100644 --- a/drivers/net/ethernet/cadence/macb_pci.c +++ b/drivers/net/ethernet/cadence/macb_pci.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0-only /** - * Cadence GEM PCI wrapper. + * DOC: Cadence GEM PCI wrapper. * * Copyright (C) 2016 Cadence Design Systems - https://www.cadence.com * -- 2.27.0 ^ permalink raw reply related [flat|nested] 68+ messages in thread
* [RFC PATCH net-next v1 10/11] drivers/net/ethernet: remove incorrectly formatted doc 2020-09-11 1:23 ` [Intel-wired-lan] " Jesse Brandeburg @ 2020-09-11 1:23 ` Jesse Brandeburg -1 siblings, 0 replies; 68+ messages in thread From: Jesse Brandeburg @ 2020-09-11 1:23 UTC (permalink / raw) To: netdev; +Cc: Jesse Brandeburg, intel-wired-lan As part of the W=1 series for ethernet, these drivers were discovered to be using kdoc style comments but were not actually doing kdoc. Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> --- drivers/net/ethernet/amazon/ena/ena_com.c | 2 +- .../aquantia/atlantic/hw_atl/hw_atl_b0.c | 2 +- drivers/net/ethernet/xilinx/ll_temac_main.c | 26 +++++++++---------- 3 files changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c b/drivers/net/ethernet/amazon/ena/ena_com.c index 452e66b39a17..6967d40b5ac7 100644 --- a/drivers/net/ethernet/amazon/ena/ena_com.c +++ b/drivers/net/ethernet/amazon/ena/ena_com.c @@ -603,7 +603,7 @@ static int ena_com_wait_and_process_admin_cq_polling(struct ena_comp_ctx *comp_c return ret; } -/** +/* * Set the LLQ configurations of the firmware * * The driver provides only the enabled feature values to the device, diff --git a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c index 8941ac4df9e3..9f1b15077e7d 100644 --- a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c +++ b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c @@ -1536,7 +1536,7 @@ static int hw_atl_b0_hw_fl2_clear(struct aq_hw_s *self, return aq_hw_err_from_flags(self); } -/** +/* * @brief Set VLAN filter table * @details Configure VLAN filter table to accept (and assign the queue) traffic * for the particular vlan ids. diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c index 9a15f14daa47..60c199fcb91e 100644 --- a/drivers/net/ethernet/xilinx/ll_temac_main.c +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c @@ -106,7 +106,7 @@ static bool hard_acs_rdy_or_timeout(struct temac_local *lp, ktime_t timeout) */ #define HARD_ACS_RDY_POLL_NS (20 * NSEC_PER_MSEC) -/** +/* * temac_indirect_busywait - Wait for current indirect register access * to complete. */ @@ -121,7 +121,7 @@ int temac_indirect_busywait(struct temac_local *lp) return 0; } -/** +/* * temac_indirect_in32 - Indirect register read access. This function * must be called without lp->indirect_lock being held. */ @@ -136,7 +136,7 @@ u32 temac_indirect_in32(struct temac_local *lp, int reg) return val; } -/** +/* * temac_indirect_in32_locked - Indirect register read access. This * function must be called with lp->indirect_lock being held. Use * this together with spin_lock_irqsave/spin_lock_irqrestore to avoid @@ -164,7 +164,7 @@ u32 temac_indirect_in32_locked(struct temac_local *lp, int reg) return temac_ior(lp, XTE_LSW0_OFFSET); } -/** +/* * temac_indirect_out32 - Indirect register write access. This function * must be called without lp->indirect_lock being held. */ @@ -177,7 +177,7 @@ void temac_indirect_out32(struct temac_local *lp, int reg, u32 value) spin_unlock_irqrestore(lp->indirect_lock, flags); } -/** +/* * temac_indirect_out32_locked - Indirect register write access. This * function must be called with lp->indirect_lock being held. Use * this together with spin_lock_irqsave/spin_lock_irqrestore to avoid @@ -202,7 +202,7 @@ void temac_indirect_out32_locked(struct temac_local *lp, int reg, u32 value) WARN_ON(temac_indirect_busywait(lp)); } -/** +/* * temac_dma_in32_* - Memory mapped DMA read, these function expects a * register input that is based on DCR word addresses which are then * converted to memory mapped byte addresses. To be assigned to @@ -218,7 +218,7 @@ static u32 temac_dma_in32_le(struct temac_local *lp, int reg) return ioread32(lp->sdma_regs + (reg << 2)); } -/** +/* * temac_dma_out32_* - Memory mapped DMA read, these function expects * a register input that is based on DCR word addresses which are then * converted to memory mapped byte addresses. To be assigned to @@ -240,7 +240,7 @@ static void temac_dma_out32_le(struct temac_local *lp, int reg, u32 value) */ #ifdef CONFIG_PPC_DCR -/** +/* * temac_dma_dcr_in32 - DCR based DMA read */ static u32 temac_dma_dcr_in(struct temac_local *lp, int reg) @@ -248,7 +248,7 @@ static u32 temac_dma_dcr_in(struct temac_local *lp, int reg) return dcr_read(lp->sdma_dcrs, reg); } -/** +/* * temac_dma_dcr_out32 - DCR based DMA write */ static void temac_dma_dcr_out(struct temac_local *lp, int reg, u32 value) @@ -256,7 +256,7 @@ static void temac_dma_dcr_out(struct temac_local *lp, int reg, u32 value) dcr_write(lp->sdma_dcrs, reg, value); } -/** +/* * temac_dcr_setup - If the DMA is DCR based, then setup the address and * I/O functions */ @@ -293,7 +293,7 @@ static int temac_dcr_setup(struct temac_local *lp, struct platform_device *op, #endif -/** +/* * temac_dma_bd_release - Release buffer descriptor rings */ static void temac_dma_bd_release(struct net_device *ndev) @@ -323,7 +323,7 @@ static void temac_dma_bd_release(struct net_device *ndev) lp->tx_bd_v, lp->tx_bd_p); } -/** +/* * temac_dma_bd_init - Setup buffer descriptor rings */ static int temac_dma_bd_init(struct net_device *ndev) @@ -593,7 +593,7 @@ static struct temac_option { {} }; -/** +/* * temac_setoptions */ static u32 temac_setoptions(struct net_device *ndev, u32 options) -- 2.27.0 ^ permalink raw reply related [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 10/11] drivers/net/ethernet: remove incorrectly formatted doc @ 2020-09-11 1:23 ` Jesse Brandeburg 0 siblings, 0 replies; 68+ messages in thread From: Jesse Brandeburg @ 2020-09-11 1:23 UTC (permalink / raw) To: intel-wired-lan As part of the W=1 series for ethernet, these drivers were discovered to be using kdoc style comments but were not actually doing kdoc. Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> --- drivers/net/ethernet/amazon/ena/ena_com.c | 2 +- .../aquantia/atlantic/hw_atl/hw_atl_b0.c | 2 +- drivers/net/ethernet/xilinx/ll_temac_main.c | 26 +++++++++---------- 3 files changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c b/drivers/net/ethernet/amazon/ena/ena_com.c index 452e66b39a17..6967d40b5ac7 100644 --- a/drivers/net/ethernet/amazon/ena/ena_com.c +++ b/drivers/net/ethernet/amazon/ena/ena_com.c @@ -603,7 +603,7 @@ static int ena_com_wait_and_process_admin_cq_polling(struct ena_comp_ctx *comp_c return ret; } -/** +/* * Set the LLQ configurations of the firmware * * The driver provides only the enabled feature values to the device, diff --git a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c index 8941ac4df9e3..9f1b15077e7d 100644 --- a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c +++ b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c @@ -1536,7 +1536,7 @@ static int hw_atl_b0_hw_fl2_clear(struct aq_hw_s *self, return aq_hw_err_from_flags(self); } -/** +/* * @brief Set VLAN filter table * @details Configure VLAN filter table to accept (and assign the queue) traffic * for the particular vlan ids. diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c index 9a15f14daa47..60c199fcb91e 100644 --- a/drivers/net/ethernet/xilinx/ll_temac_main.c +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c @@ -106,7 +106,7 @@ static bool hard_acs_rdy_or_timeout(struct temac_local *lp, ktime_t timeout) */ #define HARD_ACS_RDY_POLL_NS (20 * NSEC_PER_MSEC) -/** +/* * temac_indirect_busywait - Wait for current indirect register access * to complete. */ @@ -121,7 +121,7 @@ int temac_indirect_busywait(struct temac_local *lp) return 0; } -/** +/* * temac_indirect_in32 - Indirect register read access. This function * must be called without lp->indirect_lock being held. */ @@ -136,7 +136,7 @@ u32 temac_indirect_in32(struct temac_local *lp, int reg) return val; } -/** +/* * temac_indirect_in32_locked - Indirect register read access. This * function must be called with lp->indirect_lock being held. Use * this together with spin_lock_irqsave/spin_lock_irqrestore to avoid @@ -164,7 +164,7 @@ u32 temac_indirect_in32_locked(struct temac_local *lp, int reg) return temac_ior(lp, XTE_LSW0_OFFSET); } -/** +/* * temac_indirect_out32 - Indirect register write access. This function * must be called without lp->indirect_lock being held. */ @@ -177,7 +177,7 @@ void temac_indirect_out32(struct temac_local *lp, int reg, u32 value) spin_unlock_irqrestore(lp->indirect_lock, flags); } -/** +/* * temac_indirect_out32_locked - Indirect register write access. This * function must be called with lp->indirect_lock being held. Use * this together with spin_lock_irqsave/spin_lock_irqrestore to avoid @@ -202,7 +202,7 @@ void temac_indirect_out32_locked(struct temac_local *lp, int reg, u32 value) WARN_ON(temac_indirect_busywait(lp)); } -/** +/* * temac_dma_in32_* - Memory mapped DMA read, these function expects a * register input that is based on DCR word addresses which are then * converted to memory mapped byte addresses. To be assigned to @@ -218,7 +218,7 @@ static u32 temac_dma_in32_le(struct temac_local *lp, int reg) return ioread32(lp->sdma_regs + (reg << 2)); } -/** +/* * temac_dma_out32_* - Memory mapped DMA read, these function expects * a register input that is based on DCR word addresses which are then * converted to memory mapped byte addresses. To be assigned to @@ -240,7 +240,7 @@ static void temac_dma_out32_le(struct temac_local *lp, int reg, u32 value) */ #ifdef CONFIG_PPC_DCR -/** +/* * temac_dma_dcr_in32 - DCR based DMA read */ static u32 temac_dma_dcr_in(struct temac_local *lp, int reg) @@ -248,7 +248,7 @@ static u32 temac_dma_dcr_in(struct temac_local *lp, int reg) return dcr_read(lp->sdma_dcrs, reg); } -/** +/* * temac_dma_dcr_out32 - DCR based DMA write */ static void temac_dma_dcr_out(struct temac_local *lp, int reg, u32 value) @@ -256,7 +256,7 @@ static void temac_dma_dcr_out(struct temac_local *lp, int reg, u32 value) dcr_write(lp->sdma_dcrs, reg, value); } -/** +/* * temac_dcr_setup - If the DMA is DCR based, then setup the address and * I/O functions */ @@ -293,7 +293,7 @@ static int temac_dcr_setup(struct temac_local *lp, struct platform_device *op, #endif -/** +/* * temac_dma_bd_release - Release buffer descriptor rings */ static void temac_dma_bd_release(struct net_device *ndev) @@ -323,7 +323,7 @@ static void temac_dma_bd_release(struct net_device *ndev) lp->tx_bd_v, lp->tx_bd_p); } -/** +/* * temac_dma_bd_init - Setup buffer descriptor rings */ static int temac_dma_bd_init(struct net_device *ndev) @@ -593,7 +593,7 @@ static struct temac_option { {} }; -/** +/* * temac_setoptions */ static u32 temac_setoptions(struct net_device *ndev, u32 options) -- 2.27.0 ^ permalink raw reply related [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 10/11] drivers/net/ethernet: remove incorrectly formatted doc 2020-09-11 1:23 ` [Intel-wired-lan] " Jesse Brandeburg (?) @ 2020-09-11 22:59 ` Jacob Keller 2020-09-11 23:25 ` Jesse Brandeburg -1 siblings, 1 reply; 68+ messages in thread From: Jacob Keller @ 2020-09-11 22:59 UTC (permalink / raw) To: intel-wired-lan A lot of these look like they should probably just be converted to use kdoc format instead of removing the '/**' On 9/10/2020 6:23 PM, Jesse Brandeburg wrote: > As part of the W=1 series for ethernet, these drivers were discovered to > be using kdoc style comments but were not actually doing kdoc. > > Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> > --- > drivers/net/ethernet/amazon/ena/ena_com.c | 2 +- > .../aquantia/atlantic/hw_atl/hw_atl_b0.c | 2 +- > drivers/net/ethernet/xilinx/ll_temac_main.c | 26 +++++++++---------- > 3 files changed, 15 insertions(+), 15 deletions(-) > > diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c b/drivers/net/ethernet/amazon/ena/ena_com.c > index 452e66b39a17..6967d40b5ac7 100644 > --- a/drivers/net/ethernet/amazon/ena/ena_com.c > +++ b/drivers/net/ethernet/amazon/ena/ena_com.c > @@ -603,7 +603,7 @@ static int ena_com_wait_and_process_admin_cq_polling(struct ena_comp_ctx *comp_c > return ret; > } > > -/** > +/* > * Set the LLQ configurations of the firmware > * > * The driver provides only the enabled feature values to the device, > diff --git a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c > index 8941ac4df9e3..9f1b15077e7d 100644 > --- a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c > +++ b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c > @@ -1536,7 +1536,7 @@ static int hw_atl_b0_hw_fl2_clear(struct aq_hw_s *self, > return aq_hw_err_from_flags(self); > } > > -/** > +/* > * @brief Set VLAN filter table > * @details Configure VLAN filter table to accept (and assign the queue) traffic > * for the particular vlan ids. This looks like a doxygen style comment. I wonder if whoever maintains this code uses doxygen and expects this to get picked up. > diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c > index 9a15f14daa47..60c199fcb91e 100644 > --- a/drivers/net/ethernet/xilinx/ll_temac_main.c > +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c > @@ -106,7 +106,7 @@ static bool hard_acs_rdy_or_timeout(struct temac_local *lp, ktime_t timeout) > */ > #define HARD_ACS_RDY_POLL_NS (20 * NSEC_PER_MSEC) > > -/** > +/* > * temac_indirect_busywait - Wait for current indirect register access > * to complete. > */ This looks like a function comment. Shouldn't this just be fixed/updated so that it is a valid kdoc comment instead? > @@ -121,7 +121,7 @@ int temac_indirect_busywait(struct temac_local *lp) > return 0; > } > > -/** > +/* > * temac_indirect_in32 - Indirect register read access. This function > * must be called without lp->indirect_lock being held. > */ > @@ -136,7 +136,7 @@ u32 temac_indirect_in32(struct temac_local *lp, int reg) > return val; > } > > -/** > +/* > * temac_indirect_in32_locked - Indirect register read access. This > * function must be called with lp->indirect_lock being held. Use > * this together with spin_lock_irqsave/spin_lock_irqrestore to avoid > @@ -164,7 +164,7 @@ u32 temac_indirect_in32_locked(struct temac_local *lp, int reg) > return temac_ior(lp, XTE_LSW0_OFFSET); > } > > -/** > +/* > * temac_indirect_out32 - Indirect register write access. This function > * must be called without lp->indirect_lock being held. > */ > @@ -177,7 +177,7 @@ void temac_indirect_out32(struct temac_local *lp, int reg, u32 value) > spin_unlock_irqrestore(lp->indirect_lock, flags); > } > > -/** > +/* > * temac_indirect_out32_locked - Indirect register write access. This > * function must be called with lp->indirect_lock being held. Use > * this together with spin_lock_irqsave/spin_lock_irqrestore to avoid > @@ -202,7 +202,7 @@ void temac_indirect_out32_locked(struct temac_local *lp, int reg, u32 value) > WARN_ON(temac_indirect_busywait(lp)); > } > > -/** > +/* > * temac_dma_in32_* - Memory mapped DMA read, these function expects a > * register input that is based on DCR word addresses which are then > * converted to memory mapped byte addresses. To be assigned to > @@ -218,7 +218,7 @@ static u32 temac_dma_in32_le(struct temac_local *lp, int reg) > return ioread32(lp->sdma_regs + (reg << 2)); > } > > -/** > +/* > * temac_dma_out32_* - Memory mapped DMA read, these function expects > * a register input that is based on DCR word addresses which are then > * converted to memory mapped byte addresses. To be assigned to > @@ -240,7 +240,7 @@ static void temac_dma_out32_le(struct temac_local *lp, int reg, u32 value) > */ > #ifdef CONFIG_PPC_DCR > > -/** > +/* > * temac_dma_dcr_in32 - DCR based DMA read > */ > static u32 temac_dma_dcr_in(struct temac_local *lp, int reg) > @@ -248,7 +248,7 @@ static u32 temac_dma_dcr_in(struct temac_local *lp, int reg) > return dcr_read(lp->sdma_dcrs, reg); > } > > -/** > +/* > * temac_dma_dcr_out32 - DCR based DMA write > */ > static void temac_dma_dcr_out(struct temac_local *lp, int reg, u32 value) > @@ -256,7 +256,7 @@ static void temac_dma_dcr_out(struct temac_local *lp, int reg, u32 value) > dcr_write(lp->sdma_dcrs, reg, value); > } > > -/** > +/* > * temac_dcr_setup - If the DMA is DCR based, then setup the address and > * I/O functions > */ > @@ -293,7 +293,7 @@ static int temac_dcr_setup(struct temac_local *lp, struct platform_device *op, > > #endif > > -/** > +/* > * temac_dma_bd_release - Release buffer descriptor rings > */ > static void temac_dma_bd_release(struct net_device *ndev) > @@ -323,7 +323,7 @@ static void temac_dma_bd_release(struct net_device *ndev) > lp->tx_bd_v, lp->tx_bd_p); > } > > -/** > +/* > * temac_dma_bd_init - Setup buffer descriptor rings > */ > static int temac_dma_bd_init(struct net_device *ndev) > @@ -593,7 +593,7 @@ static struct temac_option { > {} > }; > > -/** > +/* > * temac_setoptions > */ > static u32 temac_setoptions(struct net_device *ndev, u32 options) > ^ permalink raw reply [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 10/11] drivers/net/ethernet: remove incorrectly formatted doc 2020-09-11 22:59 ` Jacob Keller @ 2020-09-11 23:25 ` Jesse Brandeburg 2020-09-14 23:06 ` Jacob Keller 0 siblings, 1 reply; 68+ messages in thread From: Jesse Brandeburg @ 2020-09-11 23:25 UTC (permalink / raw) To: intel-wired-lan Jacob Keller wrote: > A lot of these look like they should probably just be converted to use > kdoc format instead of removing the '/**' I understand why you're saying that, and I spent a considerable amount of time fixing drivers that appeared to *try* to use kdoc but messed up. However, if they don't have anything that looks like doxygen or kdoc, then I just removed the "/**" to a /* and stopped kdoc processing. The temac driver is a good example of not actually trying to kdoc at all. However I will look over the patches and see if I see @brief anywhere that is left and try to fix those up. I've done so much now I might as well finish it, but the @brief doxygen style notes had never been processed into kdoc before, so changing the /** into /* doesn't actually remove any value, just makes the build clean. > > diff --git a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c > > index 8941ac4df9e3..9f1b15077e7d 100644 > > --- a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c > > +++ b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c > > @@ -1536,7 +1536,7 @@ static int hw_atl_b0_hw_fl2_clear(struct aq_hw_s *self, > > return aq_hw_err_from_flags(self); > > } > > > > -/** > > +/* > > * @brief Set VLAN filter table > > * @details Configure VLAN filter table to accept (and assign the queue) traffic > > * for the particular vlan ids. > > This looks like a doxygen style comment. I wonder if whoever maintains > this code uses doxygen and expects this to get picked up. It was never picked up by kdoc. And in this case this is the only kdoc comment in this whole file, so I didn't like the idea of this *one* being documented while the whole rest of the driver was not. > > diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c > > index 9a15f14daa47..60c199fcb91e 100644 > > --- a/drivers/net/ethernet/xilinx/ll_temac_main.c > > +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c > > @@ -106,7 +106,7 @@ static bool hard_acs_rdy_or_timeout(struct temac_local *lp, ktime_t timeout) > > */ > > #define HARD_ACS_RDY_POLL_NS (20 * NSEC_PER_MSEC) > > > > -/** > > +/* > > * temac_indirect_busywait - Wait for current indirect register access > > * to complete. > > */ > > This looks like a function comment. Shouldn't this just be fixed/updated > so that it is a valid kdoc comment instead? As per above, this driver didn't even try to use kdoc, so I just honored their original intent and removed /**. Thanks for the review and comments! ^ permalink raw reply [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 10/11] drivers/net/ethernet: remove incorrectly formatted doc 2020-09-11 23:25 ` Jesse Brandeburg @ 2020-09-14 23:06 ` Jacob Keller 0 siblings, 0 replies; 68+ messages in thread From: Jacob Keller @ 2020-09-14 23:06 UTC (permalink / raw) To: intel-wired-lan On 9/11/2020 4:25 PM, Jesse Brandeburg wrote: > Jacob Keller wrote: > >> A lot of these look like they should probably just be converted to use >> kdoc format instead of removing the '/**' > > I understand why you're saying that, and I spent a considerable amount > of time fixing drivers that appeared to *try* to use kdoc but messed > up. However, if they don't have anything that looks like doxygen or > kdoc, then I just removed the "/**" to a /* and stopped kdoc processing. > > The temac driver is a good example of not actually trying to kdoc at > all. > > However I will look over the patches and see if I see @brief anywhere > that is left and try to fix those up. I've done so much now I might as > well finish it, but the @brief doxygen style notes had never been > processed into kdoc before, so changing the /** into /* doesn't > actually remove any value, just makes the build clean. > Sure, I think that's important. I just wanted to point out that we are probably breaking whoever maintained/wrote that code and used doxygen. (Since as far as I understand, doxygen also relies on the /** to find comments). Basically: I think we should be clear that is what we are doing: "We support kdoc, not doxygen, so if you want this, use kdoc format" Thanks, Jake ^ permalink raw reply [flat|nested] 68+ messages in thread
* [RFC PATCH net-next v1 11/11] drivers/net/ethernet: clean up mis-targeted comments 2020-09-11 1:23 ` [Intel-wired-lan] " Jesse Brandeburg @ 2020-09-11 1:23 ` Jesse Brandeburg -1 siblings, 0 replies; 68+ messages in thread From: Jesse Brandeburg @ 2020-09-11 1:23 UTC (permalink / raw) To: netdev; +Cc: Jesse Brandeburg, intel-wired-lan As part of the W=1 cleanups for ethernet, a million [1] driver comments had to be cleaned up to get the W=1 compilation to succeed. This change finally makes the drivers/net/ethernet tree compile with W=1 set on the command line. [1] - ok it wasn't quite a million, but it felt like it. Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> --- Testing Hints: build with W=1 in the drivers/net/ethernet directory, I used: make allmodconfig make modules_prepare make M=drivers/net/ethernet W=1 modules --- .../net/ethernet/atheros/atl1c/atl1c_main.c | 6 +- .../net/ethernet/atheros/atl1e/atl1e_main.c | 7 +- drivers/net/ethernet/atheros/atlx/atl1.c | 2 +- drivers/net/ethernet/atheros/atlx/atl2.c | 6 +- .../net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 2 + .../ethernet/broadcom/bnx2x/bnx2x_ethtool.c | 6 +- .../net/ethernet/broadcom/bnx2x/bnx2x_main.c | 12 +- .../net/ethernet/broadcom/bnx2x/bnx2x_sp.c | 98 ++--- drivers/net/ethernet/brocade/bna/bfa_cee.c | 20 +- drivers/net/ethernet/brocade/bna/bfa_ioc.c | 8 +- drivers/net/ethernet/cadence/macb_main.c | 6 +- drivers/net/ethernet/calxeda/xgmac.c | 2 + .../net/ethernet/cavium/liquidio/lio_core.c | 92 ++--- .../net/ethernet/cavium/liquidio/lio_main.c | 351 +++++++++--------- .../ethernet/cavium/liquidio/lio_vf_main.c | 158 ++++---- .../ethernet/cavium/liquidio/octeon_console.c | 12 +- .../ethernet/cavium/liquidio/octeon_device.c | 4 +- .../ethernet/cavium/liquidio/octeon_droq.c | 2 +- .../ethernet/cavium/liquidio/octeon_mailbox.c | 5 +- .../net/ethernet/chelsio/cxgb3/cxgb3_main.c | 8 +- drivers/net/ethernet/chelsio/cxgb3/sge.c | 28 +- drivers/net/ethernet/chelsio/cxgb3/t3_hw.c | 5 +- drivers/net/ethernet/cisco/enic/enic_api.c | 2 +- .../net/ethernet/cisco/enic/enic_ethtool.c | 2 +- drivers/net/ethernet/cortina/gemini.c | 2 + drivers/net/ethernet/ethoc.c | 6 +- .../net/ethernet/freescale/dpaa2/dpaa2-eth.c | 2 +- drivers/net/ethernet/freescale/fec_ptp.c | 5 +- drivers/net/ethernet/freescale/fman/fman.c | 14 +- .../net/ethernet/freescale/fman/fman_muram.c | 6 +- .../net/ethernet/freescale/fman/fman_port.c | 23 +- drivers/net/ethernet/freescale/fman/mac.c | 4 +- drivers/net/ethernet/hisilicon/hns/hnae.c | 2 +- .../net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 34 +- .../ethernet/hisilicon/hns/hns_dsaf_main.c | 148 ++++---- .../ethernet/hisilicon/hns/hns_dsaf_misc.c | 7 +- .../net/ethernet/hisilicon/hns/hns_dsaf_ppe.c | 17 +- .../net/ethernet/hisilicon/hns/hns_dsaf_rcb.c | 7 +- .../ethernet/hisilicon/hns/hns_dsaf_xgmac.c | 3 +- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 4 +- .../net/ethernet/hisilicon/hns/hns_ethtool.c | 48 +-- drivers/net/ethernet/hisilicon/hns_mdio.c | 3 +- .../net/ethernet/huawei/hinic/hinic_hw_cmdq.c | 2 +- .../net/ethernet/huawei/hinic/hinic_hw_dev.c | 6 +- .../net/ethernet/huawei/hinic/hinic_hw_eqs.c | 1 + .../net/ethernet/huawei/hinic/hinic_hw_if.c | 1 + .../net/ethernet/huawei/hinic/hinic_hw_mgmt.c | 1 + .../net/ethernet/huawei/hinic/hinic_main.c | 2 +- drivers/net/ethernet/micrel/ksz884x.c | 46 ++- .../ethernet/microchip/encx24j600-regmap.c | 2 +- drivers/net/ethernet/natsemi/ns83820.c | 6 +- drivers/net/ethernet/neterion/s2io.c | 91 ++--- .../net/ethernet/neterion/vxge/vxge-config.c | 5 +- .../net/ethernet/neterion/vxge/vxge-ethtool.c | 2 +- .../net/ethernet/neterion/vxge/vxge-main.c | 10 +- .../net/ethernet/neterion/vxge/vxge-traffic.c | 40 +- .../oki-semi/pch_gbe/pch_gbe_ethtool.c | 4 +- .../ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 5 +- .../ethernet/oki-semi/pch_gbe/pch_gbe_param.c | 14 +- .../net/ethernet/packetengines/yellowfin.c | 2 +- .../net/ethernet/qlogic/netxen/netxen_nic.h | 3 - .../qlogic/netxen/netxen_nic_ethtool.c | 3 + drivers/net/ethernet/qualcomm/emac/emac.c | 1 + drivers/net/ethernet/realtek/8139cp.c | 2 + .../net/ethernet/samsung/sxgbe/sxgbe_main.c | 17 +- drivers/net/ethernet/sfc/falcon/rx.c | 2 + drivers/net/ethernet/sfc/falcon/selftest.c | 2 +- drivers/net/ethernet/sfc/net_driver.h | 2 +- drivers/net/ethernet/sfc/ptp.c | 6 + drivers/net/ethernet/sis/sis900.c | 3 +- .../net/ethernet/stmicro/stmmac/dwmac-rk.c | 2 +- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 14 +- .../ethernet/stmicro/stmmac/stmmac_platform.c | 3 +- drivers/net/ethernet/sun/cassini.c | 4 +- drivers/net/ethernet/tehuti/tehuti.c | 17 +- drivers/net/ethernet/ti/davinci_cpdma.c | 2 +- drivers/net/ethernet/ti/davinci_emac.c | 5 +- drivers/net/ethernet/via/via-rhine.c | 2 +- drivers/net/ethernet/via/via-velocity.c | 27 +- 79 files changed, 828 insertions(+), 708 deletions(-) diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c index c7288e1fa3a2..00de463268a8 100644 --- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c +++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c @@ -204,7 +204,7 @@ static u32 atl1c_wait_until_idle(struct atl1c_hw *hw, u32 modu_ctrl) /** * atl1c_phy_config - Timer Call-back - * @data: pointer to netdev cast into an unsigned long + * @t: timer list containing pointer to netdev cast into an unsigned long */ static void atl1c_phy_config(struct timer_list *t) { @@ -346,6 +346,7 @@ static void atl1c_del_timer(struct atl1c_adapter *adapter) /** * atl1c_tx_timeout - Respond to a Tx Hang * @netdev: network interface device structure + * @txqueue: index of hanging tx queue */ static void atl1c_tx_timeout(struct net_device *netdev, unsigned int txqueue) { @@ -846,6 +847,7 @@ static inline void atl1c_clean_buffer(struct pci_dev *pdev, /** * atl1c_clean_tx_ring - Free Tx-skb * @adapter: board private structure + * @type: type of transmit queue */ static void atl1c_clean_tx_ring(struct atl1c_adapter *adapter, enum atl1c_trans_queue type) @@ -1861,6 +1863,8 @@ static void atl1c_clean_rx_irq(struct atl1c_adapter *adapter, /** * atl1c_clean - NAPI Rx polling callback + * @napi: napi info + * @budget: limit of packets to clean */ static int atl1c_clean(struct napi_struct *napi, int budget) { diff --git a/drivers/net/ethernet/atheros/atl1e/atl1e_main.c b/drivers/net/ethernet/atheros/atl1e/atl1e_main.c index fb78f6c31708..e43f71849daf 100644 --- a/drivers/net/ethernet/atheros/atl1e/atl1e_main.c +++ b/drivers/net/ethernet/atheros/atl1e/atl1e_main.c @@ -111,7 +111,7 @@ static inline void atl1e_irq_reset(struct atl1e_adapter *adapter) /** * atl1e_phy_config - Timer Call-back - * @data: pointer to netdev cast into an unsigned long + * @t: timer list containing pointer to netdev cast into an unsigned long */ static void atl1e_phy_config(struct timer_list *t) { @@ -196,7 +196,7 @@ static int atl1e_check_link(struct atl1e_adapter *adapter) /** * atl1e_link_chg_task - deal with link change event Out of interrupt context - * @netdev: network interface device structure + * @work: work struct with driver info */ static void atl1e_link_chg_task(struct work_struct *work) { @@ -246,6 +246,7 @@ static void atl1e_cancel_work(struct atl1e_adapter *adapter) /** * atl1e_tx_timeout - Respond to a Tx Hang * @netdev: network interface device structure + * @txqueue: the index of the hanging queue */ static void atl1e_tx_timeout(struct net_device *netdev, unsigned int txqueue) { @@ -1502,6 +1503,8 @@ static void atl1e_clean_rx_irq(struct atl1e_adapter *adapter, u8 que, /** * atl1e_clean - NAPI Rx polling callback + * @napi: napi info + * @budget: number of packets to clean */ static int atl1e_clean(struct napi_struct *napi, int budget) { diff --git a/drivers/net/ethernet/atheros/atlx/atl1.c b/drivers/net/ethernet/atheros/atlx/atl1.c index 60f8aa79deb2..eaf96d002fa5 100644 --- a/drivers/net/ethernet/atheros/atlx/atl1.c +++ b/drivers/net/ethernet/atheros/atlx/atl1.c @@ -2552,7 +2552,7 @@ static irqreturn_t atl1_intr(int irq, void *data) /** * atl1_phy_config - Timer Call-back - * @data: pointer to netdev cast into an unsigned long + * @t: timer_list containing pointer to netdev cast into an unsigned long */ static void atl1_phy_config(struct timer_list *t) { diff --git a/drivers/net/ethernet/atheros/atlx/atl2.c b/drivers/net/ethernet/atheros/atlx/atl2.c index e2526c0fb7cf..021fb0e6417a 100644 --- a/drivers/net/ethernet/atheros/atlx/atl2.c +++ b/drivers/net/ethernet/atheros/atlx/atl2.c @@ -994,6 +994,7 @@ static int atl2_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd) /** * atl2_tx_timeout - Respond to a Tx Hang * @netdev: network interface device structure + * @txqueue: index of the hanging transmit queue */ static void atl2_tx_timeout(struct net_device *netdev, unsigned int txqueue) { @@ -1005,7 +1006,7 @@ static void atl2_tx_timeout(struct net_device *netdev, unsigned int txqueue) /** * atl2_watchdog - Timer Call-back - * @data: pointer to netdev cast into an unsigned long + * @t: timer list containing a pointer to netdev cast into an unsigned long */ static void atl2_watchdog(struct timer_list *t) { @@ -1030,7 +1031,7 @@ static void atl2_watchdog(struct timer_list *t) /** * atl2_phy_config - Timer Call-back - * @data: pointer to netdev cast into an unsigned long + * @t: timer list containing a pointer to netdev cast into an unsigned long */ static void atl2_phy_config(struct timer_list *t) { @@ -1235,6 +1236,7 @@ static int atl2_check_link(struct atl2_adapter *adapter) /** * atl2_link_chg_task - deal with link change event Out of interrupt context + * @work: pointer to work struct with private info */ static void atl2_link_chg_task(struct work_struct *work) { diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c index 2c0ccd4fba9b..1a6ec1a12d53 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c @@ -504,6 +504,7 @@ static void bnx2x_tpa_start(struct bnx2x_fastpath *fp, u16 queue, * @len_on_bd: total length of the first packet for the * aggregation. * @pkt_len: length of all segments + * @num_of_coalesced_segs: count of segments * * Approximate value of the MSS for this aggregation calculated using * the first packet of it. @@ -1958,6 +1959,7 @@ void bnx2x_set_num_queues(struct bnx2x *bp) * bnx2x_set_real_num_queues - configure netdev->real_num_[tx,rx]_queues * * @bp: Driver handle + * @include_cnic: handle cnic case * * We currently support for at most 16 Tx queues for each CoS thus we will * allocate a multiple of 16 for ETH L2 rings according to the value of the diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c index 7cea33803f7f..32245bbe88a8 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c @@ -839,8 +839,9 @@ static bool bnx2x_is_wreg_in_chip(struct bnx2x *bp, /** * bnx2x_read_pages_regs - read "paged" registers * - * @bp device handle - * @p output buffer + * @bp: device handle + * @p: output buffer + * @preset: the preset value * * Reads "paged" memories: memories that may only be read by first writing to a * specific address ("write address") and then reading from a specific address @@ -3561,6 +3562,7 @@ static void bnx2x_get_channels(struct net_device *dev, * bnx2x_change_num_queues - change the number of RSS queues. * * @bp: bnx2x private structure + * @num_rss: rss count * * Re-configure interrupt mode to get the new number of MSI-X * vectors and re-add NAPI objects. diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c index 3c543dd7a8f3..207289fd16da 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c @@ -3086,9 +3086,9 @@ void bnx2x_func_init(struct bnx2x *bp, struct bnx2x_func_init_params *p) /** * bnx2x_get_common_flags - Return common flags * - * @bp device handle - * @fp queue handle - * @zero_stats TRUE if statistics zeroing is needed + * @bp: device handle + * @fp: queue handle + * @zero_stats: TRUE if statistics zeroing is needed * * Return the flags that are common for the Tx-only and not normal connections. */ @@ -13591,8 +13591,8 @@ static int bnx2x_set_qm_cid_count(struct bnx2x *bp) /** * bnx2x_get_num_none_def_sbs - return the number of none default SBs - * - * @dev: pci device + * @pdev: pci device + * @cnic_cnt: count * */ static int bnx2x_get_num_non_def_sbs(struct pci_dev *pdev, int cnic_cnt) @@ -14451,9 +14451,7 @@ module_exit(bnx2x_cleanup); /** * bnx2x_set_iscsi_eth_mac_addr - set iSCSI MAC(s). - * * @bp: driver handle - * @set: set or clear the CAM entry * * This function will wait until the ramrod completion returns. * Return 0 if success, -ENODEV if ramrod doesn't return. diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c index e26f4da5a6d7..6cd1523ad9e5 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c @@ -37,10 +37,12 @@ /** * bnx2x_exe_queue_init - init the Exe Queue object * + * @bp: driver handle * @o: pointer to the object * @exe_len: length * @owner: pointer to the owner * @validate: validate function pointer + * @remove: remove function pointer * @optimize: optimize function pointer * @exec: execute function pointer * @get: get function pointer @@ -103,7 +105,7 @@ static inline int bnx2x_exe_queue_length(struct bnx2x_exe_queue_obj *o) * * @bp: driver handle * @o: queue - * @cmd: new command to add + * @elem: new command to add * @restore: true - do not optimize the command * * If the element is optimized or is illegal, frees it. @@ -277,7 +279,7 @@ static void bnx2x_raw_set_pending(struct bnx2x_raw_obj *o) * * @bp: device handle * @state: state which is to be cleared - * @state_p: state buffer + * @pstate: state buffer * */ static inline int bnx2x_state_wait(struct bnx2x *bp, int state, @@ -424,8 +426,8 @@ static bool bnx2x_put_credit_vlan_mac(struct bnx2x_vlan_mac_obj *o) * @bp: device handle * @o: vlan_mac object * - * @details: Non-blocking implementation; should be called under execution - * queue lock. + * Context: Non-blocking implementation; should be called under execution + * queue lock. */ static int __bnx2x_vlan_mac_h_write_trylock(struct bnx2x *bp, struct bnx2x_vlan_mac_obj *o) @@ -445,7 +447,7 @@ static int __bnx2x_vlan_mac_h_write_trylock(struct bnx2x *bp, * @bp: device handle * @o: vlan_mac object * - * @details Should be called under execution queue lock; notice it might release + * details Should be called under execution queue lock; notice it might release * and reclaim it during its run. */ static void __bnx2x_vlan_mac_h_exec_pending(struct bnx2x *bp, @@ -475,7 +477,7 @@ static void __bnx2x_vlan_mac_h_exec_pending(struct bnx2x *bp, * @o: vlan_mac object * @ramrod_flags: ramrod flags of missed execution * - * @details Should be called under execution queue lock. + * Context: Should be called under execution queue lock. */ static void __bnx2x_vlan_mac_h_pend(struct bnx2x *bp, struct bnx2x_vlan_mac_obj *o, @@ -493,7 +495,7 @@ static void __bnx2x_vlan_mac_h_pend(struct bnx2x *bp, * @bp: device handle * @o: vlan_mac object * - * @details Should be called under execution queue lock. Notice if a pending + * Context: Should be called under execution queue lock. Notice if a pending * execution exists, it would perform it - possibly releasing and * reclaiming the execution queue lock. */ @@ -516,7 +518,7 @@ static void __bnx2x_vlan_mac_h_write_unlock(struct bnx2x *bp, * @bp: device handle * @o: vlan_mac object * - * @details Should be called under the execution queue lock. May sleep. May + * Context: Should be called under the execution queue lock. May sleep. May * release and reclaim execution queue lock during its run. */ static int __bnx2x_vlan_mac_h_read_lock(struct bnx2x *bp, @@ -536,7 +538,7 @@ static int __bnx2x_vlan_mac_h_read_lock(struct bnx2x *bp, * @bp: device handle * @o: vlan_mac object * - * @details May sleep. Claims and releases execution queue lock during its run. + * Context: May sleep. Claims and releases execution queue lock during its run. */ int bnx2x_vlan_mac_h_read_lock(struct bnx2x *bp, struct bnx2x_vlan_mac_obj *o) @@ -556,7 +558,7 @@ int bnx2x_vlan_mac_h_read_lock(struct bnx2x *bp, * @bp: device handle * @o: vlan_mac object * - * @details Should be called under execution queue lock. Notice if a pending + * Context: Should be called under execution queue lock. Notice if a pending * execution exists, it would be performed if this was the last * reader. possibly releasing and reclaiming the execution queue lock. */ @@ -591,7 +593,7 @@ static void __bnx2x_vlan_mac_h_read_unlock(struct bnx2x *bp, * @bp: device handle * @o: vlan_mac object * - * @details Notice if a pending execution exists, it would be performed if this + * Context: Notice if a pending execution exists, it would be performed if this * was the last reader. Claims and releases the execution queue lock * during its run. */ @@ -968,7 +970,7 @@ static void bnx2x_set_one_mac_e2(struct bnx2x *bp, * * @bp: device handle * @o: queue - * @type: + * @type: the type of echo * @cam_offset: offset in cam memory * @hdr: pointer to a header to setup * @@ -1608,8 +1610,8 @@ static int __bnx2x_vlan_mac_execute_step(struct bnx2x *bp, * * @bp: device handle * @o: bnx2x_vlan_mac_obj - * @cqe: - * @cont: if true schedule next execution chunk + * @cqe: completion element + * @ramrod_flags: if set schedule next execution chunk * */ static int bnx2x_complete_vlan_mac(struct bnx2x *bp, @@ -1656,7 +1658,7 @@ static int bnx2x_complete_vlan_mac(struct bnx2x *bp, * bnx2x_optimize_vlan_mac - optimize ADD and DEL commands. * * @bp: device handle - * @o: bnx2x_qable_obj + * @qo: bnx2x_qable_obj * @elem: bnx2x_exeq_elem */ static int bnx2x_optimize_vlan_mac(struct bnx2x *bp, @@ -1714,10 +1716,10 @@ static int bnx2x_optimize_vlan_mac(struct bnx2x *bp, * bnx2x_vlan_mac_get_registry_elem - prepare a registry element * * @bp: device handle - * @o: - * @elem: - * @restore: - * @re: + * @o: vlan object + * @elem: element + * @restore: to restore or not + * @re: registry * * prepare a registry element according to the current command request. */ @@ -1768,9 +1770,9 @@ static inline int bnx2x_vlan_mac_get_registry_elem( * bnx2x_execute_vlan_mac - execute vlan mac command * * @bp: device handle - * @qo: - * @exe_chunk: - * @ramrod_flags: + * @qo: bnx2x_qable_obj pointer + * @exe_chunk: chunk + * @ramrod_flags: flags * * go and send a ramrod! */ @@ -2006,8 +2008,8 @@ int bnx2x_config_vlan_mac(struct bnx2x *bp, * bnx2x_vlan_mac_del_all - delete elements with given vlan_mac_flags spec * * @bp: device handle - * @o: - * @vlan_mac_flags: + * @o: vlan object info + * @vlan_mac_flags: vlan flags * @ramrod_flags: execution flags to be used for this deletion * * if the last operation has completed successfully and there are no @@ -2767,7 +2769,7 @@ static int bnx2x_mcast_enqueue_cmd(struct bnx2x *bp, /** * bnx2x_mcast_get_next_bin - get the next set bin (index) * - * @o: + * @o: multicast object info * @last: index to start looking from (including) * * returns the next found (set) bin or a negative value if none is found. @@ -2892,7 +2894,7 @@ static void bnx2x_mcast_set_one_rule_e2(struct bnx2x *bp, * bnx2x_mcast_handle_restore_cmd_e2 - restore configuration from the registry * * @bp: device handle - * @o: + * @o: multicast object info * @start_bin: index in the registry to start from (including) * @rdata_idx: index in the ramrod data to start from * @@ -3202,11 +3204,11 @@ static inline void bnx2x_mcast_hdl_del(struct bnx2x *bp, } /** - * bnx2x_mcast_handle_current_cmd - + * bnx2x_mcast_handle_current_cmd - send command if room * * @bp: device handle - * @p: - * @cmd: + * @p: ramrod mcast info + * @cmd: command * @start_cnt: first line in the ramrod data that may be used * * This function is called iff there is enough place for the current command in @@ -3323,7 +3325,7 @@ static void bnx2x_mcast_revert_e2(struct bnx2x *bp, * bnx2x_mcast_set_rdata_hdr_e2 - sets a header values * * @bp: device handle - * @p: + * @p: ramrod parameters * @len: number of rules to handle */ static inline void bnx2x_mcast_set_rdata_hdr_e2(struct bnx2x *bp, @@ -3684,7 +3686,7 @@ static void bnx2x_mcast_set_one_rule_e1(struct bnx2x *bp, * bnx2x_mcast_set_rdata_hdr_e1 - set header values in mac_configuration_cmd * * @bp: device handle - * @p: + * @p: ramrod parameters * @len: number of rules to handle */ static inline void bnx2x_mcast_set_rdata_hdr_e1(struct bnx2x *bp, @@ -3711,7 +3713,7 @@ static inline void bnx2x_mcast_set_rdata_hdr_e1(struct bnx2x *bp, * bnx2x_mcast_handle_restore_cmd_e1 - restore command for 57710 * * @bp: device handle - * @o: + * @o: multicast info * @start_idx: index in the registry to start from * @rdata_idx: index in the ramrod data to start from * @@ -3798,10 +3800,10 @@ static inline int bnx2x_mcast_handle_pending_cmds_e1( /** * bnx2x_get_fw_mac_addr - revert the bnx2x_set_fw_mac_addr(). * - * @fw_hi: - * @fw_mid: - * @fw_lo: - * @mac: + * @fw_hi: address + * @fw_mid: address + * @fw_lo: address + * @mac: mac address */ static inline void bnx2x_get_fw_mac_addr(__le16 *fw_hi, __le16 *fw_mid, __le16 *fw_lo, u8 *mac) @@ -3818,7 +3820,7 @@ static inline void bnx2x_get_fw_mac_addr(__le16 *fw_hi, __le16 *fw_mid, * bnx2x_mcast_refresh_registry_e1 - * * @bp: device handle - * @cnt: + * @o: multicast info * * Check the ramrod data first entry flag to see if it's a DELETE or ADD command * and update the registry correspondingly: if ADD - allocate a memory and add @@ -4311,7 +4313,7 @@ static bool bnx2x_credit_pool_get_entry_always_true( /** * bnx2x_init_credit_pool - initialize credit pool internals. * - * @p: + * @p: credit pool * @base: Base entry in the CAM to use. * @credit: pool size. * @@ -4725,8 +4727,8 @@ static int bnx2x_queue_wait_comp(struct bnx2x *bp, * bnx2x_queue_comp_cmd - complete the state change command. * * @bp: device handle - * @o: - * @cmd: + * @o: queue info + * @cmd: command to exec * * Checks that the arrived completion is expected. */ @@ -5477,8 +5479,8 @@ static int bnx2x_queue_send_cmd_e2(struct bnx2x *bp, * bnx2x_queue_chk_transition - check state machine of a regular Queue * * @bp: device handle - * @o: - * @params: + * @o: queue info + * @params: queue state * * (not Forwarding) * It both checks if the requested command is legal in a current @@ -5735,8 +5737,8 @@ static int bnx2x_func_wait_comp(struct bnx2x *bp, * bnx2x_func_state_change_comp - complete the state machine transition * * @bp: device handle - * @o: - * @cmd: + * @o: function info + * @cmd: more info * * Called on state change transition. Completes the state * machine transition only - no HW interaction. @@ -5776,8 +5778,8 @@ static inline int bnx2x_func_state_change_comp(struct bnx2x *bp, * bnx2x_func_comp_cmd - complete the state change command * * @bp: device handle - * @o: - * @cmd: + * @o: function info + * @cmd: more info * * Checks that the arrived completion is expected. */ @@ -5796,8 +5798,8 @@ static int bnx2x_func_comp_cmd(struct bnx2x *bp, * bnx2x_func_chk_transition - perform function state machine transition * * @bp: device handle - * @o: - * @params: + * @o: function info + * @params: state parameters * * It both checks if the requested command is legal in a current * state and, if it's legal, sets a `next_state' in the object diff --git a/drivers/net/ethernet/brocade/bna/bfa_cee.c b/drivers/net/ethernet/brocade/bna/bfa_cee.c index 09fb9315d1ae..06f221c44802 100644 --- a/drivers/net/ethernet/brocade/bna/bfa_cee.c +++ b/drivers/net/ethernet/brocade/bna/bfa_cee.c @@ -102,14 +102,10 @@ bfa_cee_get_stats_isr(struct bfa_cee *cee, enum bfa_status status) } /** - * bfa_cee_get_attr_isr() + * bfa_cee_reset_stats_isr - CEE ISR for reset-stats responses from f/w * - * @brief CEE ISR for reset-stats responses from f/w - * - * @param[in] cee - Pointer to the CEE module - * status - Return status from the f/w - * - * @return void + * @cee: Input Pointer to the CEE module + * @status: Return status from the f/w */ static void bfa_cee_reset_stats_isr(struct bfa_cee *cee, enum bfa_status status) @@ -148,9 +144,12 @@ bfa_nw_cee_mem_claim(struct bfa_cee *cee, u8 *dma_kva, u64 dma_pa) } /** - * bfa_cee_get_attr - Send the request to the f/w to fetch CEE attributes. + * bfa_nw_cee_get_attr - Send the request to the f/w to fetch CEE attributes. * * @cee: Pointer to the CEE module data structure. + * @attr: attribute requested + * @cbfn: function pointer + * @cbarg: function pointer arguments * * Return: status */ @@ -181,7 +180,9 @@ bfa_nw_cee_get_attr(struct bfa_cee *cee, struct bfa_cee_attr *attr, } /** - * bfa_cee_isrs - Handles Mail-box interrupts for CEE module. + * bfa_cee_isr - Handles Mail-box interrupts for CEE module. + * @cbarg: argument passed containing pointer to the CEE module data structure. + * @m: message pointer */ static void @@ -210,6 +211,7 @@ bfa_cee_isr(void *cbarg, struct bfi_mbmsg *m) /** * bfa_cee_notify - CEE module heart-beat failure handler. * + * @arg: argument passed containing pointer to the CEE module data structure. * @event: IOC event type */ diff --git a/drivers/net/ethernet/brocade/bna/bfa_ioc.c b/drivers/net/ethernet/brocade/bna/bfa_ioc.c index b9dd06b12945..fd805c685d92 100644 --- a/drivers/net/ethernet/brocade/bna/bfa_ioc.c +++ b/drivers/net/ethernet/brocade/bna/bfa_ioc.c @@ -1763,7 +1763,7 @@ bfa_ioc_flash_fwver_cmp(struct bfa_ioc *ioc, return BFI_IOC_IMG_VER_INCOMP; } -/** +/* * Returns TRUE if driver is willing to work with current smem f/w version. */ bool @@ -2469,6 +2469,7 @@ bfa_ioc_isr(struct bfa_ioc *ioc, struct bfi_mbmsg *m) * * @ioc: memory for IOC * @bfa: driver instance structure + * @cbfn: callback function */ void bfa_nw_ioc_attach(struct bfa_ioc *ioc, void *bfa, struct bfa_ioc_cbfn *cbfn) @@ -2500,7 +2501,9 @@ bfa_nw_ioc_detach(struct bfa_ioc *ioc) /** * bfa_nw_ioc_pci_init - Setup IOC PCI properties. * + * @ioc: memory for IOC * @pcidev: PCI device information for this IOC + * @clscode: class code */ void bfa_nw_ioc_pci_init(struct bfa_ioc *ioc, struct bfa_pcidev *pcidev, @@ -2569,6 +2572,7 @@ bfa_nw_ioc_pci_init(struct bfa_ioc *ioc, struct bfa_pcidev *pcidev, /** * bfa_nw_ioc_mem_claim - Initialize IOC dma memory * + * @ioc: memory for IOC * @dm_kva: kernel virtual address of IOC dma memory * @dm_pa: physical address of IOC dma memory */ @@ -2636,6 +2640,8 @@ bfa_nw_ioc_mbox_regisr(struct bfa_ioc *ioc, enum bfi_mclass mc, * * @ioc: IOC instance * @cmd: Mailbox command + * @cbfn: callback function + * @cbarg: arguments to callback * * Waits if mailbox is busy. Responsibility of caller to serialize */ diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index 6761f404b8aa..7034dad10cbd 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -458,9 +458,9 @@ static void macb_init_buffers(struct macb *bp) /** * macb_set_tx_clk() - Set a clock to a new frequency - * @clk Pointer to the clock to change - * @rate New frequency in Hz - * @dev Pointer to the struct net_device + * @clk: Pointer to the clock to change + * @speed: New frequency in Hz + * @dev: Pointer to the struct net_device */ static void macb_set_tx_clk(struct clk *clk, int speed, struct net_device *dev) { diff --git a/drivers/net/ethernet/calxeda/xgmac.c b/drivers/net/ethernet/calxeda/xgmac.c index 05a3d067c3fc..bbb453c6a5f7 100644 --- a/drivers/net/ethernet/calxeda/xgmac.c +++ b/drivers/net/ethernet/calxeda/xgmac.c @@ -1246,6 +1246,8 @@ static int xgmac_poll(struct napi_struct *napi, int budget) /** * xgmac_tx_timeout * @dev : Pointer to net device structure + * @txqueue: index of the hung transmit queue + * * Description: this function is called when a packet transmission fails to * complete within a reasonable tmrate. The driver will mark the error in the * netdev structure and arrange for the device to be reset to a sane state diff --git a/drivers/net/ethernet/cavium/liquidio/lio_core.c b/drivers/net/ethernet/cavium/liquidio/lio_core.c index e40c64b79f66..9ef172976b35 100644 --- a/drivers/net/ethernet/cavium/liquidio/lio_core.c +++ b/drivers/net/ethernet/cavium/liquidio/lio_core.c @@ -32,8 +32,8 @@ #define OCTNIC_MAX_SG MAX_SKB_FRAGS /** - * \brief Delete gather lists - * @param lio per-network private data + * lio_delete_glists - Delete gather lists + * @lio: per-network private data */ void lio_delete_glists(struct lio *lio) { @@ -73,8 +73,10 @@ void lio_delete_glists(struct lio *lio) } /** - * \brief Setup gather lists - * @param lio per-network private data + * lio_setup_glists - Setup gather lists + * @oct: octeon_device + * @lio: per-network private data + * @num_iqs: count of iqs to allocate */ int lio_setup_glists(struct octeon_device *oct, struct lio *lio, int num_iqs) { @@ -521,12 +523,12 @@ static void lio_update_txq_status(struct octeon_device *oct, int iq_num) } /** - * \brief Setup output queue - * @param oct octeon device - * @param q_no which queue - * @param num_descs how many descriptors - * @param desc_size size of each descriptor - * @param app_ctx application context + * octeon_setup_droq - Setup output queue + * @oct: octeon device + * @q_no: which queue + * @num_descs: how many descriptors + * @desc_size: size of each descriptor + * @app_ctx: application context */ static int octeon_setup_droq(struct octeon_device *oct, int q_no, int num_descs, int desc_size, void *app_ctx) @@ -555,16 +557,17 @@ static int octeon_setup_droq(struct octeon_device *oct, int q_no, int num_descs, return ret_val; } -/** Routine to push packets arriving on Octeon interface upto network layer. - * @param oct_id - octeon device id. - * @param skbuff - skbuff struct to be passed to network layer. - * @param len - size of total data received. - * @param rh - Control header associated with the packet - * @param param - additional control data with the packet - * @param arg - farg registered in droq_ops +/** + * liquidio_push_packet - Routine to push packets arriving on Octeon interface upto network layer. + * @octeon_id:octeon device id. + * @skbuff: skbuff struct to be passed to network layer. + * @len: size of total data received. + * @rh: Control header associated with the packet + * @param: additional control data with the packet + * @arg: farg registered in droq_ops */ static void -liquidio_push_packet(u32 octeon_id __attribute__((unused)), +liquidio_push_packet(u32 __maybe_unused octeon_id, void *skbuff, u32 len, union octeon_rh *rh, @@ -698,8 +701,8 @@ liquidio_push_packet(u32 octeon_id __attribute__((unused)), } /** - * \brief wrapper for calling napi_schedule - * @param param parameters to pass to napi_schedule + * napi_schedule_wrapper - wrapper for calling napi_schedule + * @param: parameters to pass to napi_schedule * * Used when scheduling on different CPUs */ @@ -711,8 +714,8 @@ static void napi_schedule_wrapper(void *param) } /** - * \brief callback when receive interrupt occurs and we are in NAPI mode - * @param arg pointer to octeon output queue + * liquidio_napi_drv_callback - callback when receive interrupt occurs and we are in NAPI mode + * @arg: pointer to octeon output queue */ static void liquidio_napi_drv_callback(void *arg) { @@ -737,9 +740,9 @@ static void liquidio_napi_drv_callback(void *arg) } /** - * \brief Entry point for NAPI polling - * @param napi NAPI structure - * @param budget maximum number of items to process + * liquidio_napi_poll - Entry point for NAPI polling + * @napi: NAPI structure + * @budget: maximum number of items to process */ static int liquidio_napi_poll(struct napi_struct *napi, int budget) { @@ -792,9 +795,11 @@ static int liquidio_napi_poll(struct napi_struct *napi, int budget) } /** - * \brief Setup input and output queues - * @param octeon_dev octeon device - * @param ifidx Interface index + * liquidio_setup_io_queues - Setup input and output queues + * @octeon_dev: octeon device + * @ifidx: Interface index + * @num_iqs: input io queue count + * @num_oqs: output io queue count * * Note: Queues are with respect to the octeon device. Thus * an input queue is for egress packets, and output queues @@ -927,7 +932,7 @@ int liquidio_schedule_msix_droq_pkt_handler(struct octeon_droq *droq, u64 ret) } irqreturn_t -liquidio_msix_intr_handler(int irq __attribute__((unused)), void *dev) +liquidio_msix_intr_handler(int __maybe_unused irq, void *dev) { struct octeon_ioq_vector *ioq_vector = (struct octeon_ioq_vector *)dev; struct octeon_device *oct = ioq_vector->oct_dev; @@ -943,8 +948,8 @@ liquidio_msix_intr_handler(int irq __attribute__((unused)), void *dev) } /** - * \brief Droq packet processor sceduler - * @param oct octeon device + * liquidio_schedule_droq_pkt_handlers - Droq packet processor sceduler + * @oct: octeon device */ static void liquidio_schedule_droq_pkt_handlers(struct octeon_device *oct) { @@ -972,13 +977,12 @@ static void liquidio_schedule_droq_pkt_handlers(struct octeon_device *oct) } /** - * \brief Interrupt handler for octeon - * @param irq unused - * @param dev octeon device + * liquidio_legacy_intr_handler - Interrupt handler for octeon + * @irq: unused + * @dev: octeon device */ static -irqreturn_t liquidio_legacy_intr_handler(int irq __attribute__((unused)), - void *dev) +irqreturn_t liquidio_legacy_intr_handler(int __maybe_unused irq, void *dev) { struct octeon_device *oct = (struct octeon_device *)dev; irqreturn_t ret; @@ -999,8 +1003,9 @@ irqreturn_t liquidio_legacy_intr_handler(int irq __attribute__((unused)), } /** - * \brief Setup interrupt for octeon device - * @param oct octeon device + * octeon_setup_interrupt - Setup interrupt for octeon device + * @oct: octeon device + * @num_ioqs: number of queues * * Enable interrupt in Octeon device as given in the PCI interrupt mask. */ @@ -1083,7 +1088,7 @@ int octeon_setup_interrupt(struct octeon_device *oct, u32 num_ioqs) dev_dbg(&oct->pci_dev->dev, "OCTEON: Enough MSI-X interrupts are allocated...\n"); num_ioq_vectors = oct->num_msix_irqs; - /** For PF, there is one non-ioq interrupt handler */ + /* For PF, there is one non-ioq interrupt handler */ if (OCTEON_CN23XX_PF(oct)) { num_ioq_vectors -= 1; @@ -1126,13 +1131,13 @@ int octeon_setup_interrupt(struct octeon_device *oct, u32 num_ioqs) dev_err(&oct->pci_dev->dev, "Request_irq failed for MSIX interrupt Error: %d\n", irqret); - /** Freeing the non-ioq irq vector here . */ + /* Freeing the non-ioq irq vector here . */ free_irq(msix_entries[num_ioq_vectors].vector, oct); while (i) { i--; - /** clearing affinity mask. */ + /* clearing affinity mask. */ irq_set_affinity_hint( msix_entries[i].vector, NULL); @@ -1197,8 +1202,9 @@ int octeon_setup_interrupt(struct octeon_device *oct, u32 num_ioqs) } /** - * \brief Net device change_mtu - * @param netdev network device + * liquidio_change_mtu - Net device change_mtu + * @netdev: network device + * @new_mtu: the new max transmit unit size */ int liquidio_change_mtu(struct net_device *netdev, int new_mtu) { diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c b/drivers/net/ethernet/cavium/liquidio/lio_main.c index 737ae69eec6e..8c9f792c4e54 100644 --- a/drivers/net/ethernet/cavium/liquidio/lio_main.c +++ b/drivers/net/ethernet/cavium/liquidio/lio_main.c @@ -69,9 +69,9 @@ MODULE_PARM_DESC(console_bitmask, "Bitmask indicating which consoles have debug output redirected to syslog."); /** - * \brief determines if a given console has debug enabled. - * @param console console to check - * @returns 1 = enabled. 0 otherwise + * octeon_console_debug_enabled - determines if a given console has debug enabled. + * @console: console to check + * Return: 1 = enabled. 0 otherwise */ static int octeon_console_debug_enabled(u32 console) { @@ -126,7 +126,7 @@ union tx_info { } s; }; -/** Octeon device properties to be used by the NIC module. +/* Octeon device properties to be used by the NIC module. * Each octeon device in the system will be represented * by this structure in the NIC module. */ @@ -222,8 +222,8 @@ static int lio_wait_for_oq_pkts(struct octeon_device *oct) } /** - * \brief Forces all IO queues off on a given device - * @param oct Pointer to Octeon device + * force_io_queues_off - Forces all IO queues off on a given device + * @oct: Pointer to Octeon device */ static void force_io_queues_off(struct octeon_device *oct) { @@ -238,8 +238,8 @@ static void force_io_queues_off(struct octeon_device *oct) } /** - * \brief Cause device to go quiet so it can be safely removed/reset/etc - * @param oct Pointer to Octeon device + * pcierror_quiesce_device - Cause device to go quiet so it can be safely removed/reset/etc + * @oct: Pointer to Octeon device */ static inline void pcierror_quiesce_device(struct octeon_device *oct) { @@ -283,8 +283,8 @@ static inline void pcierror_quiesce_device(struct octeon_device *oct) } /** - * \brief Cleanup PCI AER uncorrectable error status - * @param dev Pointer to PCI device + * cleanup_aer_uncorrect_error_status - Cleanup PCI AER uncorrectable error status + * @dev: Pointer to PCI device */ static void cleanup_aer_uncorrect_error_status(struct pci_dev *dev) { @@ -303,8 +303,8 @@ static void cleanup_aer_uncorrect_error_status(struct pci_dev *dev) } /** - * \brief Stop all PCI IO to a given device - * @param dev Pointer to Octeon device + * stop_pci_io - Stop all PCI IO to a given device + * @oct: Pointer to Octeon device */ static void stop_pci_io(struct octeon_device *oct) { @@ -332,9 +332,9 @@ static void stop_pci_io(struct octeon_device *oct) } /** - * \brief called when PCI error is detected - * @param pdev Pointer to PCI device - * @param state The current pci connection state + * liquidio_pcie_error_detected - called when PCI error is detected + * @pdev: Pointer to PCI device + * @state: The current pci connection state * * This function is called after a PCI bus error affecting * this device has been detected. @@ -362,11 +362,10 @@ static pci_ers_result_t liquidio_pcie_error_detected(struct pci_dev *pdev, } /** - * \brief mmio handler - * @param pdev Pointer to PCI device + * liquidio_pcie_mmio_enabled - mmio handler + * @pdev: Pointer to PCI device */ -static pci_ers_result_t liquidio_pcie_mmio_enabled( - struct pci_dev *pdev __attribute__((unused))) +static pci_ers_result_t liquidio_pcie_mmio_enabled(struct pci_dev __maybe_unused *pdev) { /* We should never hit this since we never ask for a reset for a Fatal * Error. We always return DISCONNECT in io_error above. @@ -376,14 +375,13 @@ static pci_ers_result_t liquidio_pcie_mmio_enabled( } /** - * \brief called after the pci bus has been reset. - * @param pdev Pointer to PCI device + * liquidio_pcie_slot_reset - called after the pci bus has been reset. + * @pdev: Pointer to PCI device * * Restart the card from scratch, as if from a cold-boot. Implementation * resembles the first-half of the octeon_resume routine. */ -static pci_ers_result_t liquidio_pcie_slot_reset( - struct pci_dev *pdev __attribute__((unused))) +static pci_ers_result_t liquidio_pcie_slot_reset(struct pci_dev __maybe_unused *pdev) { /* We should never hit this since we never ask for a reset for a Fatal * Error. We always return DISCONNECT in io_error above. @@ -393,14 +391,14 @@ static pci_ers_result_t liquidio_pcie_slot_reset( } /** - * \brief called when traffic can start flowing again. - * @param pdev Pointer to PCI device + * liquidio_pcie_resume - called when traffic can start flowing again. + * @pdev: Pointer to PCI device * * This callback is called when the error recovery driver tells us that * its OK to resume normal operation. Implementation resembles the * second-half of the octeon_resume routine. */ -static void liquidio_pcie_resume(struct pci_dev *pdev __attribute__((unused))) +static void liquidio_pcie_resume(struct pci_dev __maybe_unused *pdev) { /* Nothing to be done here. */ } @@ -447,7 +445,7 @@ static struct pci_driver liquidio_pci_driver = { }; /** - * \brief register PCI driver + * liquidio_init_pci - register PCI driver */ static int liquidio_init_pci(void) { @@ -455,7 +453,7 @@ static int liquidio_init_pci(void) } /** - * \brief unregister PCI driver + * liquidio_deinit_pci - unregister PCI driver */ static void liquidio_deinit_pci(void) { @@ -463,9 +461,9 @@ static void liquidio_deinit_pci(void) } /** - * \brief Check Tx queue status, and take appropriate action - * @param lio per-network private data - * @returns 0 if full, number of queues woken up otherwise + * check_txq_status - Check Tx queue status, and take appropriate action + * @lio: per-network private data + * Return: 0 if full, number of queues woken up otherwise */ static inline int check_txq_status(struct lio *lio) { @@ -491,8 +489,8 @@ static inline int check_txq_status(struct lio *lio) } /** - * \brief Print link information - * @param netdev network device + * print_link_info - Print link information + * @netdev: network device */ static void print_link_info(struct net_device *netdev) { @@ -513,8 +511,8 @@ static void print_link_info(struct net_device *netdev) } /** - * \brief Routine to notify MTU change - * @param work work_struct data structure + * octnet_link_status_change - Routine to notify MTU change + * @work: work_struct data structure */ static void octnet_link_status_change(struct work_struct *work) { @@ -531,8 +529,8 @@ static void octnet_link_status_change(struct work_struct *work) } /** - * \brief Sets up the mtu status change work - * @param netdev network device + * setup_link_status_change_wq - Sets up the mtu status change work + * @netdev: network device */ static inline int setup_link_status_change_wq(struct net_device *netdev) { @@ -563,9 +561,9 @@ static inline void cleanup_link_status_change_wq(struct net_device *netdev) } /** - * \brief Update link status - * @param netdev network device - * @param ls link status structure + * update_link_status - Update link status + * @netdev: network device + * @ls: link status structure * * Called on receipt of a link status response from the core application to * update each interface's link status. @@ -663,10 +661,9 @@ static void lio_sync_octeon_time(struct work_struct *work) } /** - * setup_sync_octeon_time_wq - Sets up the work to periodically update - * local time to octeon firmware + * setup_sync_octeon_time_wq - prepare work to periodically update local time to octeon firmware * - * @netdev - network device which should send time update to firmware + * @netdev: network device which should send time update to firmware **/ static inline int setup_sync_octeon_time_wq(struct net_device *netdev) { @@ -690,10 +687,12 @@ static inline int setup_sync_octeon_time_wq(struct net_device *netdev) } /** - * cleanup_sync_octeon_time_wq - stop scheduling and destroy the work created - * to periodically update local time to octeon firmware + * cleanup_sync_octeon_time_wq - destroy wq * - * @netdev - network device which should send time update to firmware + * @netdev: network device which should send time update to firmware + * + * Stop scheduling and destroy the work created to periodically update local + * time to octeon firmware. **/ static inline void cleanup_sync_octeon_time_wq(struct net_device *netdev) { @@ -828,13 +827,12 @@ static int liquidio_watchdog(void *param) } /** - * \brief PCI probe handler - * @param pdev PCI device structure - * @param ent unused + * liquidio_probe - PCI probe handler + * @pdev: PCI device structure + * @ent: unused */ static int -liquidio_probe(struct pci_dev *pdev, - const struct pci_device_id *ent __attribute__((unused))) +liquidio_probe(struct pci_dev *pdev, const struct pci_device_id __maybe_unused *ent) { struct octeon_device *oct_dev = NULL; struct handshake *hs; @@ -924,8 +922,8 @@ static bool fw_type_is_auto(void) } /** - * \brief PCI FLR for each Octeon device. - * @param oct octeon device + * octeon_pci_flr - PCI FLR for each Octeon device. + * @oct: octeon device */ static void octeon_pci_flr(struct octeon_device *oct) { @@ -951,9 +949,8 @@ static void octeon_pci_flr(struct octeon_device *oct) } /** - *\brief Destroy resources associated with octeon device - * @param pdev PCI device structure - * @param ent unused + * octeon_destroy_resources - Destroy resources associated with octeon device + * @oct: octeon device */ static void octeon_destroy_resources(struct octeon_device *oct) { @@ -1152,9 +1149,9 @@ static void octeon_destroy_resources(struct octeon_device *oct) } /** - * \brief Send Rx control command - * @param lio per-network private data - * @param start_stop whether to start or stop + * send_rx_ctrl_cmd - Send Rx control command + * @lio: per-network private data + * @start_stop: whether to start or stop */ static void send_rx_ctrl_cmd(struct lio *lio, int start_stop) { @@ -1210,9 +1207,9 @@ static void send_rx_ctrl_cmd(struct lio *lio, int start_stop) } /** - * \brief Destroy NIC device interface - * @param oct octeon device - * @param ifidx which interface to destroy + * liquidio_destroy_nic_device - Destroy NIC device interface + * @oct: octeon device + * @ifidx: which interface to destroy * * Cleanup associated with each interface for an Octeon device when NIC * module is being unloaded or if initialization fails during load. @@ -1272,8 +1269,8 @@ static void liquidio_destroy_nic_device(struct octeon_device *oct, int ifidx) } /** - * \brief Stop complete NIC functionality - * @param oct octeon device + * liquidio_stop_nic_module - Stop complete NIC functionality + * @oct: octeon device */ static int liquidio_stop_nic_module(struct octeon_device *oct) { @@ -1313,8 +1310,8 @@ static int liquidio_stop_nic_module(struct octeon_device *oct) } /** - * \brief Cleans up resources at unload time - * @param pdev PCI device structure + * liquidio_remove - Cleans up resources at unload time + * @pdev: PCI device structure */ static void liquidio_remove(struct pci_dev *pdev) { @@ -1346,8 +1343,8 @@ static void liquidio_remove(struct pci_dev *pdev) } /** - * \brief Identify the Octeon device and to map the BAR address space - * @param oct octeon device + * octeon_chip_specific_setup - Identify the Octeon device and to map the BAR address space + * @oct: octeon device */ static int octeon_chip_specific_setup(struct octeon_device *oct) { @@ -1390,8 +1387,8 @@ static int octeon_chip_specific_setup(struct octeon_device *oct) } /** - * \brief PCI initialization for each Octeon device. - * @param oct octeon device + * octeon_pci_os_setup - PCI initialization for each Octeon device. + * @oct: octeon device */ static int octeon_pci_os_setup(struct octeon_device *oct) { @@ -1414,8 +1411,8 @@ static int octeon_pci_os_setup(struct octeon_device *oct) } /** - * \brief Unmap and free network buffer - * @param buf buffer + * free_netbuf - Unmap and free network buffer + * @buf: buffer */ static void free_netbuf(void *buf) { @@ -1434,8 +1431,8 @@ static void free_netbuf(void *buf) } /** - * \brief Unmap and free gather buffer - * @param buf buffer + * free_netsgbuf - Unmap and free gather buffer + * @buf: buffer */ static void free_netsgbuf(void *buf) { @@ -1474,8 +1471,8 @@ static void free_netsgbuf(void *buf) } /** - * \brief Unmap and free gather buffer with response - * @param buf buffer + * free_netsgbuf_with_resp - Unmap and free gather buffer with response + * @buf: buffer */ static void free_netsgbuf_with_resp(void *buf) { @@ -1518,9 +1515,9 @@ static void free_netsgbuf_with_resp(void *buf) } /** - * \brief Adjust ptp frequency - * @param ptp PTP clock info - * @param ppb how much to adjust by, in parts-per-billion + * liquidio_ptp_adjfreq - Adjust ptp frequency + * @ptp: PTP clock info + * @ppb: how much to adjust by, in parts-per-billion */ static int liquidio_ptp_adjfreq(struct ptp_clock_info *ptp, s32 ppb) { @@ -1555,9 +1552,9 @@ static int liquidio_ptp_adjfreq(struct ptp_clock_info *ptp, s32 ppb) } /** - * \brief Adjust ptp time - * @param ptp PTP clock info - * @param delta how much to adjust by, in nanosecs + * liquidio_ptp_adjtime - Adjust ptp time + * @ptp: PTP clock info + * @delta: how much to adjust by, in nanosecs */ static int liquidio_ptp_adjtime(struct ptp_clock_info *ptp, s64 delta) { @@ -1572,9 +1569,9 @@ static int liquidio_ptp_adjtime(struct ptp_clock_info *ptp, s64 delta) } /** - * \brief Get hardware clock time, including any adjustment - * @param ptp PTP clock info - * @param ts timespec + * liquidio_ptp_gettime - Get hardware clock time, including any adjustment + * @ptp: PTP clock info + * @ts: timespec */ static int liquidio_ptp_gettime(struct ptp_clock_info *ptp, struct timespec64 *ts) @@ -1595,9 +1592,9 @@ static int liquidio_ptp_gettime(struct ptp_clock_info *ptp, } /** - * \brief Set hardware clock time. Reset adjustment - * @param ptp PTP clock info - * @param ts timespec + * liquidio_ptp_settime - Set hardware clock time. Reset adjustment + * @ptp: PTP clock info + * @ts: timespec */ static int liquidio_ptp_settime(struct ptp_clock_info *ptp, const struct timespec64 *ts) @@ -1618,22 +1615,22 @@ static int liquidio_ptp_settime(struct ptp_clock_info *ptp, } /** - * \brief Check if PTP is enabled - * @param ptp PTP clock info - * @param rq request - * @param on is it on + * liquidio_ptp_enable - Check if PTP is enabled + * @ptp: PTP clock info + * @rq: request + * @on: is it on */ static int -liquidio_ptp_enable(struct ptp_clock_info *ptp __attribute__((unused)), - struct ptp_clock_request *rq __attribute__((unused)), - int on __attribute__((unused))) +liquidio_ptp_enable(struct ptp_clock_info __maybe_unused *ptp, + struct ptp_clock_request __maybe_unused *rq, + int __maybe_unused on) { return -EOPNOTSUPP; } /** - * \brief Open PTP clock source - * @param netdev network device + * oct_ptp_open - Open PTP clock source + * @netdev: network device */ static void oct_ptp_open(struct net_device *netdev) { @@ -1665,8 +1662,8 @@ static void oct_ptp_open(struct net_device *netdev) } /** - * \brief Init PTP clock - * @param oct octeon device + * liquidio_ptp_init - Init PTP clock + * @oct: octeon device */ static void liquidio_ptp_init(struct octeon_device *oct) { @@ -1682,8 +1679,8 @@ static void liquidio_ptp_init(struct octeon_device *oct) } /** - * \brief Load firmware to device - * @param oct octeon device + * load_firmware - Load firmware to device + * @oct: octeon device * * Maps device to firmware filename, requests firmware, and downloads it */ @@ -1721,8 +1718,8 @@ static int load_firmware(struct octeon_device *oct) } /** - * \brief Poll routine for checking transmit queue status - * @param work work_struct data structure + * octnet_poll_check_txq_status - Poll routine for checking transmit queue status + * @work: work_struct data structure */ static void octnet_poll_check_txq_status(struct work_struct *work) { @@ -1738,8 +1735,8 @@ static void octnet_poll_check_txq_status(struct work_struct *work) } /** - * \brief Sets up the txq poll check - * @param netdev network device + * setup_tx_poll_fn - Sets up the txq poll check + * @netdev: network device */ static inline int setup_tx_poll_fn(struct net_device *netdev) { @@ -1771,8 +1768,8 @@ static inline void cleanup_tx_poll_fn(struct net_device *netdev) } /** - * \brief Net device open for LiquidIO - * @param netdev network device + * liquidio_open - Net device open for LiquidIO + * @netdev: network device */ static int liquidio_open(struct net_device *netdev) { @@ -1831,8 +1828,8 @@ static int liquidio_open(struct net_device *netdev) } /** - * \brief Net device stop for LiquidIO - * @param netdev network device + * liquidio_stop - Net device stop for LiquidIO + * @netdev: network device */ static int liquidio_stop(struct net_device *netdev) { @@ -1896,8 +1893,8 @@ static int liquidio_stop(struct net_device *netdev) } /** - * \brief Converts a mask based on net device flags - * @param netdev network device + * get_new_flags - Converts a mask based on net device flags + * @netdev: network device * * This routine generates a octnet_ifflags mask from the net device flags * received from the OS. @@ -1929,8 +1926,8 @@ static inline enum octnet_ifflags get_new_flags(struct net_device *netdev) } /** - * \brief Net device set_multicast_list - * @param netdev network device + * liquidio_set_mcast_list - Net device set_multicast_list + * @netdev: network device */ static void liquidio_set_mcast_list(struct net_device *netdev) { @@ -1977,8 +1974,9 @@ static void liquidio_set_mcast_list(struct net_device *netdev) } /** - * \brief Net device set_mac_address - * @param netdev network device + * liquidio_set_mac - Net device set_mac_address + * @netdev: network device + * @p: pointer to sockaddr */ static int liquidio_set_mac(struct net_device *netdev, void *p) { @@ -2096,10 +2094,9 @@ liquidio_get_stats64(struct net_device *netdev, } /** - * \brief Handler for SIOCSHWTSTAMP ioctl - * @param netdev network device - * @param ifr interface request - * @param cmd command + * hwtstamp_ioctl - Handler for SIOCSHWTSTAMP ioctl + * @netdev: network device + * @ifr: interface request */ static int hwtstamp_ioctl(struct net_device *netdev, struct ifreq *ifr) { @@ -2154,10 +2151,10 @@ static int hwtstamp_ioctl(struct net_device *netdev, struct ifreq *ifr) } /** - * \brief ioctl handler - * @param netdev network device - * @param ifr interface request - * @param cmd command + * liquidio_ioctl - ioctl handler + * @netdev: network device + * @ifr: interface request + * @cmd: command */ static int liquidio_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd) { @@ -2174,9 +2171,10 @@ static int liquidio_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd) } /** - * \brief handle a Tx timestamp response - * @param status response status - * @param buf pointer to skb + * handle_timestamp - handle a Tx timestamp response + * @oct: octeon device + * @status: response status + * @buf: pointer to skb */ static void handle_timestamp(struct octeon_device *oct, u32 status, @@ -2217,10 +2215,12 @@ static void handle_timestamp(struct octeon_device *oct, tx_buffer_free(skb); } -/* \brief Send a data packet that will be timestamped - * @param oct octeon device - * @param ndata pointer to network data - * @param finfo pointer to private network data +/** + * send_nic_timestamp_pkt - Send a data packet that will be timestamped + * @oct: octeon device + * @ndata: pointer to network data + * @finfo: pointer to private network data + * @xmit_more: more is coming */ static inline int send_nic_timestamp_pkt(struct octeon_device *oct, struct octnic_data_pkt *ndata, @@ -2276,10 +2276,12 @@ static inline int send_nic_timestamp_pkt(struct octeon_device *oct, return retval; } -/** \brief Transmit networks packets to the Octeon interface - * @param skbuff skbuff struct to be passed to network layer. - * @param netdev pointer to network device - * @returns whether the packet was transmitted to the device okay or not +/** + * liquidio_xmit - Transmit networks packets to the Octeon interface + * @skb: skbuff struct to be passed to network layer. + * @netdev: pointer to network device + * + * Return: whether the packet was transmitted to the device okay or not * (NETDEV_TX_OK or NETDEV_TX_BUSY) */ static netdev_tx_t liquidio_xmit(struct sk_buff *skb, struct net_device *netdev) @@ -2524,8 +2526,10 @@ static netdev_tx_t liquidio_xmit(struct sk_buff *skb, struct net_device *netdev) return NETDEV_TX_OK; } -/** \brief Network device Tx timeout - * @param netdev pointer to network device +/** + * liquidio_tx_timeout - Network device Tx timeout + * @netdev: pointer to network device + * @txqueue: index of the hung transmit queue */ static void liquidio_tx_timeout(struct net_device *netdev, unsigned int txqueue) { @@ -2597,12 +2601,12 @@ static int liquidio_vlan_rx_kill_vid(struct net_device *netdev, return ret; } -/** Sending command to enable/disable RX checksum offload - * @param netdev pointer to network device - * @param command OCTNET_CMD_TNL_RX_CSUM_CTL - * @param rx_cmd_bit OCTNET_CMD_RXCSUM_ENABLE/ - * OCTNET_CMD_RXCSUM_DISABLE - * @returns SUCCESS or FAILURE +/** + * liquidio_set_rxcsum_command - Sending command to enable/disable RX checksum offload + * @netdev: pointer to network device + * @command: OCTNET_CMD_TNL_RX_CSUM_CTL + * @rx_cmd: OCTNET_CMD_RXCSUM_ENABLE/OCTNET_CMD_RXCSUM_DISABLE + * Returns: SUCCESS or FAILURE */ static int liquidio_set_rxcsum_command(struct net_device *netdev, int command, u8 rx_cmd) @@ -2632,13 +2636,14 @@ static int liquidio_set_rxcsum_command(struct net_device *netdev, int command, return ret; } -/** Sending command to add/delete VxLAN UDP port to firmware - * @param netdev pointer to network device - * @param command OCTNET_CMD_VXLAN_PORT_CONFIG - * @param vxlan_port VxLAN port to be added or deleted - * @param vxlan_cmd_bit OCTNET_CMD_VXLAN_PORT_ADD, +/** + * liquidio_vxlan_port_command - Sending command to add/delete VxLAN UDP port to firmware + * @netdev: pointer to network device + * @command: OCTNET_CMD_VXLAN_PORT_CONFIG + * @vxlan_port: VxLAN port to be added or deleted + * @vxlan_cmd_bit: OCTNET_CMD_VXLAN_PORT_ADD, * OCTNET_CMD_VXLAN_PORT_DEL - * @returns SUCCESS or FAILURE + * Return: SUCCESS or FAILURE */ static int liquidio_vxlan_port_command(struct net_device *netdev, int command, u16 vxlan_port, u8 vxlan_cmd_bit) @@ -2698,10 +2703,11 @@ static const struct udp_tunnel_nic_info liquidio_udp_tunnels = { }, }; -/** \brief Net device fix features - * @param netdev pointer to network device - * @param request features requested - * @returns updated features list +/** + * liquidio_fix_features - Net device fix features + * @netdev: pointer to network device + * @request: features requested + * Return: updated features list */ static netdev_features_t liquidio_fix_features(struct net_device *netdev, netdev_features_t request) @@ -2737,9 +2743,10 @@ static netdev_features_t liquidio_fix_features(struct net_device *netdev, return request; } -/** \brief Net device set features - * @param netdev pointer to network device - * @param features features to enable/disable +/** + * liquidio_set_features - Net device set features + * @netdev: pointer to network device + * @features: features to enable/disable */ static int liquidio_set_features(struct net_device *netdev, netdev_features_t features) @@ -3224,7 +3231,8 @@ static const struct net_device_ops lionetdevops = { .ndo_get_port_parent_id = liquidio_get_port_parent_id, }; -/** \brief Entry point for the liquidio module +/** + * liquidio_init - Entry point for the liquidio module */ static int __init liquidio_init(void) { @@ -3307,8 +3315,8 @@ static int lio_nic_info(struct octeon_recv_info *recv_info, void *buf) } /** - * \brief Setup network interfaces - * @param octeon_dev octeon device + * setup_nic_devices - Setup network interfaces + * @octeon_dev: octeon device * * Called during init time for each device. It assumes the NIC * is already up and running. The link information for each @@ -3872,8 +3880,8 @@ static int liquidio_enable_sriov(struct pci_dev *dev, int num_vfs) #endif /** - * \brief initialize the NIC - * @param oct octeon device + * liquidio_init_nic_module - initialize the NIC + * @oct: octeon device * * This initialization routine is called once the Octeon device application is * up and running @@ -3928,9 +3936,10 @@ static int liquidio_init_nic_module(struct octeon_device *oct) } /** - * \brief starter callback that invokes the remaining initialization work after - * the NIC is up and running. - * @param octptr work struct work_struct + * nic_starter - finish init + * @work: work struct work_struct + * + * starter callback that invokes the remaining initialization work after the NIC is up and running. */ static void nic_starter(struct work_struct *work) { @@ -4023,8 +4032,8 @@ octeon_recv_vf_drv_notice(struct octeon_recv_info *recv_info, void *buf) } /** - * \brief Device initialization for each Octeon device that is probed - * @param octeon_dev octeon device + * octeon_device_init - Device initialization for each Octeon device that is probed + * @octeon_dev: octeon device */ static int octeon_device_init(struct octeon_device *octeon_dev) { @@ -4303,11 +4312,11 @@ static int octeon_device_init(struct octeon_device *octeon_dev) } /** - * \brief Debug console print function - * @param octeon_dev octeon device - * @param console_num console number - * @param prefix first portion of line to display - * @param suffix second portion of line to display + * octeon_dbg_console_print - Debug console print function + * @oct: octeon device + * @console_num: console number + * @prefix: first portion of line to display + * @suffix: second portion of line to display * * The OCTEON debug console outputs entire lines (excluding '\n'). * Normally, the line will be passed in the 'prefix' parameter. @@ -4330,7 +4339,7 @@ static int octeon_dbg_console_print(struct octeon_device *oct, u32 console_num, } /** - * \brief Exits the module + * liquidio_exit - Exits the module */ static void __exit liquidio_exit(void) { diff --git a/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c b/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c index 8c5879e31240..103440f97bc8 100644 --- a/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c +++ b/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c @@ -99,8 +99,8 @@ static int lio_wait_for_oq_pkts(struct octeon_device *oct) } /** - * \brief Cause device to go quiet so it can be safely removed/reset/etc - * @param oct Pointer to Octeon device + * pcierror_quiesce_device - Cause device to go quiet so it can be safely removed/reset/etc + * @oct: Pointer to Octeon device */ static void pcierror_quiesce_device(struct octeon_device *oct) { @@ -143,8 +143,8 @@ static void pcierror_quiesce_device(struct octeon_device *oct) } /** - * \brief Cleanup PCI AER uncorrectable error status - * @param dev Pointer to PCI device + * cleanup_aer_uncorrect_error_status - Cleanup PCI AER uncorrectable error status + * @dev: Pointer to PCI device */ static void cleanup_aer_uncorrect_error_status(struct pci_dev *dev) { @@ -163,8 +163,8 @@ static void cleanup_aer_uncorrect_error_status(struct pci_dev *dev) } /** - * \brief Stop all PCI IO to a given device - * @param dev Pointer to Octeon device + * stop_pci_io - Stop all PCI IO to a given device + * @oct: Pointer to Octeon device */ static void stop_pci_io(struct octeon_device *oct) { @@ -205,9 +205,9 @@ static void stop_pci_io(struct octeon_device *oct) } /** - * \brief called when PCI error is detected - * @param pdev Pointer to PCI device - * @param state The current pci connection state + * liquidio_pcie_error_detected - called when PCI error is detected + * @pdev: Pointer to PCI device + * @state: The current pci connection state * * This function is called after a PCI bus error affecting * this device has been detected. @@ -256,8 +256,8 @@ static struct pci_driver liquidio_vf_pci_driver = { }; /** - * \brief Print link information - * @param netdev network device + * print_link_info - Print link information + * @netdev: network device */ static void print_link_info(struct net_device *netdev) { @@ -278,8 +278,8 @@ static void print_link_info(struct net_device *netdev) } /** - * \brief Routine to notify MTU change - * @param work work_struct data structure + * octnet_link_status_change - Routine to notify MTU change + * @work: work_struct data structure */ static void octnet_link_status_change(struct work_struct *work) { @@ -296,8 +296,8 @@ static void octnet_link_status_change(struct work_struct *work) } /** - * \brief Sets up the mtu status change work - * @param netdev network device + * setup_link_status_change_wq - Sets up the mtu status change work + * @netdev: network device */ static int setup_link_status_change_wq(struct net_device *netdev) { @@ -328,9 +328,9 @@ static void cleanup_link_status_change_wq(struct net_device *netdev) } /** - * \brief Update link status - * @param netdev network device - * @param ls link status structure + * update_link_status - Update link status + * @netdev: network device + * @ls: link status structure * * Called on receipt of a link status response from the core application to * update each interface's link status. @@ -374,13 +374,13 @@ static void update_link_status(struct net_device *netdev, } /** - * \brief PCI probe handler - * @param pdev PCI device structure - * @param ent unused + * liquidio_vf_probe - PCI probe handler + * @pdev: PCI device structure + * @ent: unused */ static int liquidio_vf_probe(struct pci_dev *pdev, - const struct pci_device_id *ent __attribute__((unused))) + const struct pci_device_id __maybe_unused *ent) { struct octeon_device *oct_dev = NULL; @@ -416,8 +416,8 @@ liquidio_vf_probe(struct pci_dev *pdev, } /** - * \brief PCI FLR for each Octeon device. - * @param oct octeon device + * octeon_pci_flr - PCI FLR for each Octeon device. + * @oct: octeon device */ static void octeon_pci_flr(struct octeon_device *oct) { @@ -437,9 +437,8 @@ static void octeon_pci_flr(struct octeon_device *oct) } /** - *\brief Destroy resources associated with octeon device - * @param pdev PCI device structure - * @param ent unused + * octeon_destroy_resources - Destroy resources associated with octeon device + * @oct: octeon device */ static void octeon_destroy_resources(struct octeon_device *oct) { @@ -592,9 +591,9 @@ static void octeon_destroy_resources(struct octeon_device *oct) } /** - * \brief Send Rx control command - * @param lio per-network private data - * @param start_stop whether to start or stop + * send_rx_ctrl_cmd - Send Rx control command + * @lio: per-network private data + * @start_stop: whether to start or stop */ static void send_rx_ctrl_cmd(struct lio *lio, int start_stop) { @@ -644,9 +643,9 @@ static void send_rx_ctrl_cmd(struct lio *lio, int start_stop) } /** - * \brief Destroy NIC device interface - * @param oct octeon device - * @param ifidx which interface to destroy + * liquidio_destroy_nic_device - Destroy NIC device interface + * @oct: octeon device + * @ifidx: which interface to destroy * * Cleanup associated with each interface for an Octeon device when NIC * module is being unloaded or if initialization fails during load. @@ -704,8 +703,8 @@ static void liquidio_destroy_nic_device(struct octeon_device *oct, int ifidx) } /** - * \brief Stop complete NIC functionality - * @param oct octeon device + * liquidio_stop_nic_module - Stop complete NIC functionality + * @oct: octeon device */ static int liquidio_stop_nic_module(struct octeon_device *oct) { @@ -737,8 +736,8 @@ static int liquidio_stop_nic_module(struct octeon_device *oct) } /** - * \brief Cleans up resources at unload time - * @param pdev PCI device structure + * liquidio_vf_remove - Cleans up resources at unload time + * @pdev: PCI device structure */ static void liquidio_vf_remove(struct pci_dev *pdev) { @@ -763,8 +762,8 @@ static void liquidio_vf_remove(struct pci_dev *pdev) } /** - * \brief PCI initialization for each Octeon device. - * @param oct octeon device + * octeon_pci_os_setup - PCI initialization for each Octeon device. + * @oct: octeon device */ static int octeon_pci_os_setup(struct octeon_device *oct) { @@ -792,8 +791,8 @@ static int octeon_pci_os_setup(struct octeon_device *oct) } /** - * \brief Unmap and free network buffer - * @param buf buffer + * free_netbuf - Unmap and free network buffer + * @buf: buffer */ static void free_netbuf(void *buf) { @@ -812,8 +811,8 @@ static void free_netbuf(void *buf) } /** - * \brief Unmap and free gather buffer - * @param buf buffer + * free_netsgbuf - Unmap and free gather buffer + * @buf: buffer */ static void free_netsgbuf(void *buf) { @@ -853,8 +852,8 @@ static void free_netsgbuf(void *buf) } /** - * \brief Unmap and free gather buffer with response - * @param buf buffer + * free_netsgbuf_with_resp - Unmap and free gather buffer with response + * @buf: buffer */ static void free_netsgbuf_with_resp(void *buf) { @@ -897,8 +896,8 @@ static void free_netsgbuf_with_resp(void *buf) } /** - * \brief Net device open for LiquidIO - * @param netdev network device + * liquidio_open - Net device open for LiquidIO + * @netdev: network device */ static int liquidio_open(struct net_device *netdev) { @@ -941,8 +940,8 @@ static int liquidio_open(struct net_device *netdev) } /** - * \brief Net device stop for LiquidIO - * @param netdev network device + * liquidio_stop - jNet device stop for LiquidIO + * @netdev: network device */ static int liquidio_stop(struct net_device *netdev) { @@ -991,8 +990,8 @@ static int liquidio_stop(struct net_device *netdev) } /** - * \brief Converts a mask based on net device flags - * @param netdev network device + * get_new_flags - Converts a mask based on net device flags + * @netdev: network device * * This routine generates a octnet_ifflags mask from the net device flags * received from the OS. @@ -1060,8 +1059,8 @@ static void liquidio_set_uc_list(struct net_device *netdev) } /** - * \brief Net device set_multicast_list - * @param netdev network device + * liquidio_set_mcast_list - Net device set_multicast_list + * @netdev: network device */ static void liquidio_set_mcast_list(struct net_device *netdev) { @@ -1110,8 +1109,9 @@ static void liquidio_set_mcast_list(struct net_device *netdev) } /** - * \brief Net device set_mac_address - * @param netdev network device + * liquidio_set_mac - Net device set_mac_address + * @netdev: network device + * @p: opaque pointer to sockaddr */ static int liquidio_set_mac(struct net_device *netdev, void *p) { @@ -1229,10 +1229,9 @@ liquidio_get_stats64(struct net_device *netdev, } /** - * \brief Handler for SIOCSHWTSTAMP ioctl - * @param netdev network device - * @param ifr interface request - * @param cmd command + * hwtstamp_ioctl - Handler for SIOCSHWTSTAMP ioctl + * @netdev: network device + * @ifr: interface request */ static int hwtstamp_ioctl(struct net_device *netdev, struct ifreq *ifr) { @@ -1287,10 +1286,10 @@ static int hwtstamp_ioctl(struct net_device *netdev, struct ifreq *ifr) } /** - * \brief ioctl handler - * @param netdev network device - * @param ifr interface request - * @param cmd command + * liquidio_ioctl - ioctl handler + * @netdev: network device + * @ifr: interface request + * @cmd: command */ static int liquidio_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd) { @@ -1339,10 +1338,10 @@ static void handle_timestamp(struct octeon_device *oct, u32 status, void *buf) tx_buffer_free(skb); } -/* \brief Send a data packet that will be timestamped - * @param oct octeon device - * @param ndata pointer to network data - * @param finfo pointer to private network data +/* send_nic_timestamp_pkt - Send a data packet that will be timestamped + * @oct: octeon device + * @ndata: pointer to network data + * @finfo: pointer to private network data */ static int send_nic_timestamp_pkt(struct octeon_device *oct, struct octnic_data_pkt *ndata, @@ -1393,9 +1392,10 @@ static int send_nic_timestamp_pkt(struct octeon_device *oct, return retval; } -/** \brief Transmit networks packets to the Octeon interface - * @param skbuff skbuff struct to be passed to network layer. - * @param netdev pointer to network device +/** + * liquidio_xmit - Transmit networks packets to the Octeon interface + * @skb: skbuff struct to be passed to network layer. + * @netdev: pointer to network device * @returns whether the packet was transmitted to the device okay or not * (NETDEV_TX_OK or NETDEV_TX_BUSY) */ @@ -1623,8 +1623,10 @@ static netdev_tx_t liquidio_xmit(struct sk_buff *skb, struct net_device *netdev) return NETDEV_TX_OK; } -/** \brief Network device Tx timeout - * @param netdev pointer to network device +/** + * liquidio_tx_timeout - Network device Tx timeout + * @netdev: pointer to network device + * @txqueue: index of the hung transmit queue */ static void liquidio_tx_timeout(struct net_device *netdev, unsigned int txqueue) { @@ -1917,8 +1919,8 @@ static int lio_nic_info(struct octeon_recv_info *recv_info, void *buf) } /** - * \brief Setup network interfaces - * @param octeon_dev octeon device + * setup_nic_devices - Setup network interfaces + * @octeon_dev: octeon device * * Called during init time for each device. It assumes the NIC * is already up and running. The link information for each @@ -2229,8 +2231,8 @@ static int setup_nic_devices(struct octeon_device *octeon_dev) } /** - * \brief initialize the NIC - * @param oct octeon device + * liquidio_init_nic_module - initialize the NIC + * @oct: octeon device * * This initialization routine is called once the Octeon device application is * up and running @@ -2270,8 +2272,8 @@ static int liquidio_init_nic_module(struct octeon_device *oct) } /** - * \brief Device initialization for each Octeon device that is probed - * @param octeon_dev octeon device + * octeon_device_init - Device initialization for each Octeon device that is probed + * @oct: octeon device */ static int octeon_device_init(struct octeon_device *oct) { diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_console.c b/drivers/net/ethernet/cavium/liquidio/octeon_console.c index 0d2831d10f65..28feabec8fbb 100644 --- a/drivers/net/ethernet/cavium/liquidio/octeon_console.c +++ b/drivers/net/ethernet/cavium/liquidio/octeon_console.c @@ -15,7 +15,7 @@ * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE, TITLE, or * NONINFRINGEMENT. See the GNU General Public License for more details. ***********************************************************************/ -/** +/* * @file octeon_console.c */ #include <linux/moduleparam.h> @@ -131,7 +131,7 @@ struct octeon_pci_console_desc { /* Implicit storage for console_addr_array */ }; -/** +/* * This function is the implementation of the get macros defined * for individual structure members. The argument are generated * by the macros inorder to read only the needed memory. @@ -160,7 +160,7 @@ static inline u64 __cvmx_bootmem_desc_get(struct octeon_device *oct, } } -/** +/* * This function retrieves the string name of a named block. It is * more complicated than a simple memcpy() since the named block * descriptor may not be directly accessible. @@ -182,7 +182,7 @@ static void CVMX_BOOTMEM_NAMED_GET_NAME(struct octeon_device *oct, /* See header file for descriptions of functions */ -/** +/* * Check the version information on the bootmem descriptor * * @param exact_match @@ -323,7 +323,7 @@ static u64 cvmx_bootmem_phy_named_block_find(struct octeon_device *oct, return result; } -/** +/* * Find a named block on the remote Octeon * * @param name Name of block to find @@ -707,7 +707,7 @@ int octeon_add_console(struct octeon_device *oct, u32 console_num, return ret; } -/** +/* * Removes all consoles * * @param oct octeon device diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_device.c b/drivers/net/ethernet/cavium/liquidio/octeon_device.c index 1db29ffde3e5..e506cbed30b1 100644 --- a/drivers/net/ethernet/cavium/liquidio/octeon_device.c +++ b/drivers/net/ethernet/cavium/liquidio/octeon_device.c @@ -1307,7 +1307,7 @@ struct octeon_config *octeon_get_conf(struct octeon_device *oct) /* scratch register address is same in all the OCT-II and CN70XX models */ #define CNXX_SLI_SCRATCH1 0x3C0 -/** Get the octeon device pointer. +/* Get the octeon device pointer. * @param octeon_id - The id for which the octeon device pointer is required. * @return Success: Octeon device pointer. * @return Failure: NULL. @@ -1410,7 +1410,7 @@ int octeon_wait_for_ddr_init(struct octeon_device *oct, u32 *timeout) return ret; } -/** Get the octeon id assigned to the octeon device passed as argument. +/* Get the octeon id assigned to the octeon device passed as argument. * This function is exported to other modules. * @param dev - octeon device pointer passed as a void *. * @return octeon device id diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_droq.c b/drivers/net/ethernet/cavium/liquidio/octeon_droq.c index cf4fe5b17f8a..d4080bddcb6b 100644 --- a/drivers/net/ethernet/cavium/liquidio/octeon_droq.c +++ b/drivers/net/ethernet/cavium/liquidio/octeon_droq.c @@ -774,7 +774,7 @@ octeon_droq_process_packets(struct octeon_device *oct, return 0; } -/** +/* * Utility function to poll for packets. check_hw_for_packets must be * called before calling this routine. */ diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_mailbox.c b/drivers/net/ethernet/cavium/liquidio/octeon_mailbox.c index 614d07be7181..ad685f5d0a13 100644 --- a/drivers/net/ethernet/cavium/liquidio/octeon_mailbox.c +++ b/drivers/net/ethernet/cavium/liquidio/octeon_mailbox.c @@ -28,7 +28,7 @@ /** * octeon_mbox_read: - * @oct: Pointer mailbox + * @mbox: Pointer mailbox * * Reads the 8-bytes of data from the mbox register * Writes back the acknowldgement inidcating completion of read @@ -285,7 +285,8 @@ static int octeon_mbox_process_cmd(struct octeon_mbox *mbox, } /** - *octeon_mbox_process_message: + * octeon_mbox_process_message + * @mbox: mailbox * * Process the received mbox message. */ diff --git a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c index 387c357e1b8e..6ed58bc12020 100644 --- a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c +++ b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c @@ -148,7 +148,7 @@ struct workqueue_struct *cxgb3_wq; /** * link_report - show link status and link speed/duplex - * @p: the port whose settings are to be reported + * @dev: the port whose settings are to be reported * * Shows the link status, speed, and duplex of a port. */ @@ -304,8 +304,8 @@ void t3_os_link_changed(struct adapter *adapter, int port_id, int link_stat, /** * t3_os_phymod_changed - handle PHY module changes - * @phy: the PHY reporting the module change - * @mod_type: new module type + * @adap: the adapter associated with the link change + * @port_id: the port index whose limk status has changed * * This is the OS-dependent handler for PHY module changes. It is * invoked when a PHY module is removed or inserted for any OS-specific @@ -1200,7 +1200,7 @@ static void cxgb_vlan_mode(struct net_device *dev, netdev_features_t features) /** * cxgb_up - enable the adapter - * @adapter: adapter being enabled + * @adap: adapter being enabled * * Called when the first port is enabled, this function performs the * actions necessary to make an adapter operational, such as completing diff --git a/drivers/net/ethernet/chelsio/cxgb3/sge.c b/drivers/net/ethernet/chelsio/cxgb3/sge.c index ee6188dea705..9f5526bfec83 100644 --- a/drivers/net/ethernet/chelsio/cxgb3/sge.c +++ b/drivers/net/ethernet/chelsio/cxgb3/sge.c @@ -372,7 +372,7 @@ static void clear_rx_desc(struct pci_dev *pdev, const struct sge_fl *q, /** * free_rx_bufs - free the Rx buffers on an SGE free list * @pdev: the PCI device associated with the adapter - * @rxq: the SGE free list to clean up + * @q: the SGE free list to clean up * * Release the buffers on an SGE free-buffer Rx queue. HW fetching from * this queue should be stopped before calling this function. @@ -493,7 +493,7 @@ static inline void ring_fl_db(struct adapter *adap, struct sge_fl *q) /** * refill_fl - refill an SGE free-buffer list - * @adapter: the adapter + * @adap: the adapter * @q: the free-list to refill * @n: the number of new buffers to allocate * @gfp: the gfp flags for allocating new buffers @@ -568,7 +568,7 @@ static inline void __refill_fl(struct adapter *adap, struct sge_fl *fl) /** * recycle_rx_buf - recycle a receive buffer - * @adapter: the adapter + * @adap: the adapter * @q: the SGE free list * @idx: index of buffer to recycle * @@ -825,6 +825,7 @@ static struct sk_buff *get_packet(struct adapter *adap, struct sge_fl *fl, * get_packet_pg - return the next ingress packet buffer from a free list * @adap: the adapter that received the packet * @fl: the SGE free list holding the packet + * @q: the queue * @len: the packet length including any SGE padding * @drop_thres: # of remaining buffers before we start dropping packets * @@ -1173,6 +1174,7 @@ static void write_wr_hdr_sgl(unsigned int ndesc, struct sk_buff *skb, * @q: the Tx queue * @ndesc: number of descriptors the packet will occupy * @compl: the value of the COMPL bit to use + * @addr: address * * Generate a TX_PKT work request to send the supplied packet. */ @@ -1516,7 +1518,7 @@ static int ctrl_xmit(struct adapter *adap, struct sge_txq *q, /** * restart_ctrlq - restart a suspended control queue - * @qs: the queue set cotaining the control queue + * @data: the queue set containing the control queue * * Resumes transmission on a suspended Tx control queue. */ @@ -1622,6 +1624,7 @@ static void setup_deferred_unmapping(struct sk_buff *skb, struct pci_dev *pdev, * @pidx: index of the first Tx descriptor to write * @gen: the generation value to use * @ndesc: number of descriptors the packet will occupy + * @addr: the address * * Write an offload work request to send the supplied packet. The packet * data already carry the work request with most fields populated. @@ -1733,7 +1736,7 @@ again: reclaim_completed_tx(adap, q, TX_RECLAIM_CHUNK); /** * restart_offloadq - restart a suspended offload queue - * @qs: the queue set cotaining the offload queue + * @data: the queue set cotaining the offload queue * * Resumes transmission on a suspended Tx offload queue. */ @@ -1883,7 +1886,7 @@ static inline void deliver_partial_bundle(struct t3cdev *tdev, /** * ofld_poll - NAPI handler for offload packets in interrupt mode - * @dev: the network device doing the polling + * @napi: the network device doing the polling * @budget: polling budget * * The NAPI handler for offload packets when a response queue is serviced @@ -2007,7 +2010,7 @@ static void restart_tx(struct sge_qset *qs) /** * cxgb3_arp_process - process an ARP request probing a private IP address - * @adapter: the adapter + * @pi: the port info * @skb: the skbuff containing the ARP request * * Check if the ARP request is probing the private IP address @@ -2069,7 +2072,8 @@ static void cxgb3_process_iscsi_prov_pack(struct port_info *pi, * @adap: the adapter * @rq: the response queue that received the packet * @skb: the packet - * @pad: amount of padding at the start of the buffer + * @pad: padding + * @lro: large receive offload * * Process an ingress ethernet pakcet and deliver it to the stack. * The padding is 2 if the packet was delivered in an Rx buffer and 0 @@ -2239,7 +2243,7 @@ static inline void handle_rsp_cntrl_info(struct sge_qset *qs, u32 flags) /** * check_ring_db - check if we need to ring any doorbells - * @adapter: the adapter + * @adap: the adapter * @qs: the queue set whose Tx queues are to be examined * @sleeping: indicates which Tx queue sent GTS * @@ -2899,7 +2903,7 @@ void t3_sge_err_intr_handler(struct adapter *adapter) /** * sge_timer_tx - perform periodic maintenance of an SGE qset - * @data: the SGE queue set to maintain + * @t: a timer list containing the SGE queue set to maintain * * Runs periodically from a timer to perform maintenance of an SGE queue * set. It performs two tasks: @@ -2943,7 +2947,7 @@ static void sge_timer_tx(struct timer_list *t) /** * sge_timer_rx - perform periodic maintenance of an SGE qset - * @data: the SGE queue set to maintain + * @t: the timer list containing the SGE queue set to maintain * * a) Replenishes Rx queues that have run out due to memory shortage. * Normally new Rx buffers are added when existing ones are consumed but @@ -3021,7 +3025,7 @@ void t3_update_qset_coalesce(struct sge_qset *qs, const struct qset_params *p) * @irq_vec_idx: the IRQ vector index for response queue interrupts * @p: configuration parameters for this queue set * @ntxq: number of Tx queues for the queue set - * @netdev: net device associated with this queue set + * @dev: net device associated with this queue set * @netdevq: net device TX queue associated with this queue set * * Allocate resources and initialize an SGE queue set. A queue set diff --git a/drivers/net/ethernet/chelsio/cxgb3/t3_hw.c b/drivers/net/ethernet/chelsio/cxgb3/t3_hw.c index 311fed38c101..7ff31d1026fb 100644 --- a/drivers/net/ethernet/chelsio/cxgb3/t3_hw.c +++ b/drivers/net/ethernet/chelsio/cxgb3/t3_hw.c @@ -2484,6 +2484,7 @@ int t3_sge_disable_cqcntxt(struct adapter *adapter, unsigned int id) * @adapter: the adapter * @id: the context id * @op: the operation to perform + * @credits: credit value to write * * Perform the selected operation on an SGE completion queue context. * The caller is responsible for ensuring only one context operation @@ -2885,7 +2886,7 @@ static void init_cong_ctrl(unsigned short *a, unsigned short *b) * t3_load_mtus - write the MTU and congestion control HW tables * @adap: the adapter * @mtus: the unrestricted values for the MTU table - * @alphs: the values for the congestion control alpha parameter + * @alpha: the values for the congestion control alpha parameter * @beta: the values for the congestion control beta parameter * @mtu_cap: the maximum permitted effective MTU * @@ -3483,7 +3484,7 @@ static void get_pci_mode(struct adapter *adapter, struct pci_params *p) /** * init_link_config - initialize a link's SW state * @lc: structure holding the link state - * @ai: information about the current card + * @caps: information about the current card * * Initializes the SW state maintained for each link, including the link's * capabilities and default speed/duplex/flow-control/autonegotiation diff --git a/drivers/net/ethernet/cisco/enic/enic_api.c b/drivers/net/ethernet/cisco/enic/enic_api.c index b161f24522b8..89915681473c 100644 --- a/drivers/net/ethernet/cisco/enic/enic_api.c +++ b/drivers/net/ethernet/cisco/enic/enic_api.c @@ -1,4 +1,4 @@ -/** +/* * Copyright 2013 Cisco Systems, Inc. All rights reserved. * * This program is free software; you may redistribute it and/or modify diff --git a/drivers/net/ethernet/cisco/enic/enic_ethtool.c b/drivers/net/ethernet/cisco/enic/enic_ethtool.c index 4d8e0aa447fb..a4dd52bba2c3 100644 --- a/drivers/net/ethernet/cisco/enic/enic_ethtool.c +++ b/drivers/net/ethernet/cisco/enic/enic_ethtool.c @@ -1,4 +1,4 @@ -/** +/* * Copyright 2013 Cisco Systems, Inc. All rights reserved. * * This program is free software; you may redistribute it and/or modify diff --git a/drivers/net/ethernet/cortina/gemini.c b/drivers/net/ethernet/cortina/gemini.c index 07e9dee03c98..8df6f081f244 100644 --- a/drivers/net/ethernet/cortina/gemini.c +++ b/drivers/net/ethernet/cortina/gemini.c @@ -85,6 +85,8 @@ MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)"); /** * struct gmac_queue_page - page buffer per-page info + * @page: the page struct + * @mapping: the dma address handle */ struct gmac_queue_page { struct page *page; diff --git a/drivers/net/ethernet/ethoc.c b/drivers/net/ethernet/ethoc.c index a817ca661c1f..0981fe9652e5 100644 --- a/drivers/net/ethernet/ethoc.c +++ b/drivers/net/ethernet/ethoc.c @@ -177,6 +177,7 @@ MODULE_PARM_DESC(buffer_size, "DMA buffer allocation size"); * struct ethoc - driver-private device structure * @iobase: pointer to I/O memory region * @membase: pointer to buffer memory region + * @big_endian: just big or little (endian) * @num_bd: number of buffer descriptors * @num_tx: number of send buffers * @cur_tx: last send buffer written @@ -189,7 +190,10 @@ MODULE_PARM_DESC(buffer_size, "DMA buffer allocation size"); * @msg_enable: device state flags * @lock: device lock * @mdio: MDIO bus for PHY access + * @clk: clock * @phy_id: address of attached PHY + * @old_link: previous link info + * @old_duplex: previous duplex info */ struct ethoc { void __iomem *iobase; @@ -1015,7 +1019,7 @@ static const struct net_device_ops ethoc_netdev_ops = { /** * ethoc_probe - initialize OpenCores ethernet MAC - * pdev: platform device + * @pdev: platform device */ static int ethoc_probe(struct platform_device *pdev) { diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c index ceaf76158e23..03b3b4287fe8 100644 --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c @@ -1194,7 +1194,7 @@ static int dpaa2_eth_seed_pool(struct dpaa2_eth_priv *priv, u16 bpid) return 0; } -/** +/* * Drain the specified number of buffers from the DPNI's private buffer pool. * @count must not exceeed DPAA2_ETH_BUFS_PER_CMD */ diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/ethernet/freescale/fec_ptp.c index 0405a3975f3f..2e344aada4c6 100644 --- a/drivers/net/ethernet/freescale/fec_ptp.c +++ b/drivers/net/ethernet/freescale/fec_ptp.c @@ -512,7 +512,7 @@ int fec_ptp_get(struct net_device *ndev, struct ifreq *ifr) -EFAULT : 0; } -/** +/* * fec_time_keep - call timecounter_read every second to avoid timer overrun * because ENET just support 32bit counter, will timeout in 4s */ @@ -566,7 +566,8 @@ static irqreturn_t fec_pps_interrupt(int irq, void *dev_id) /** * fec_ptp_init - * @ndev: The FEC network adapter + * @pdev: The FEC network adapter + * @irq_idx: the interrupt index * * This function performs the required steps for enabling ptp * support. If ptp support has already been loaded it simply calls the diff --git a/drivers/net/ethernet/freescale/fman/fman.c b/drivers/net/ethernet/freescale/fman/fman.c index ef67e8599b39..ce0a121580f6 100644 --- a/drivers/net/ethernet/freescale/fman/fman.c +++ b/drivers/net/ethernet/freescale/fman/fman.c @@ -2063,11 +2063,11 @@ static int fman_set_exception(struct fman *fman, /** * fman_register_intr * @fman: A Pointer to FMan device - * @mod: Calling module + * @module: Calling module * @mod_id: Module id (if more than 1 exists, '0' if not) * @intr_type: Interrupt type (error/normal) selection. - * @f_isr: The interrupt service routine. - * @h_src_arg: Argument to be passed to f_isr. + * @isr_cb: The interrupt service routine. + * @src_arg: Argument to be passed to isr_cb. * * Used to register an event handler to be processed by FMan * @@ -2091,7 +2091,7 @@ EXPORT_SYMBOL(fman_register_intr); /** * fman_unregister_intr * @fman: A Pointer to FMan device - * @mod: Calling module + * @module: Calling module * @mod_id: Module id (if more than 1 exists, '0' if not) * @intr_type: Interrupt type (error/normal) selection. * @@ -2342,8 +2342,8 @@ EXPORT_SYMBOL(fman_get_bmi_max_fifo_size); /** * fman_get_revision - * @fman - Pointer to the FMan module - * @rev_info - A structure of revision information parameters. + * @fman: - Pointer to the FMan module + * @rev_info: - A structure of revision information parameters. * * Returns the FM revision * @@ -2508,7 +2508,7 @@ EXPORT_SYMBOL(fman_get_rx_extra_headroom); /** * fman_bind - * @dev: FMan OF device pointer + * @fm_dev: FMan OF device pointer * * Bind to a specific FMan device. * diff --git a/drivers/net/ethernet/freescale/fman/fman_muram.c b/drivers/net/ethernet/freescale/fman/fman_muram.c index 5ec94d243da0..7ad317e622bc 100644 --- a/drivers/net/ethernet/freescale/fman/fman_muram.c +++ b/drivers/net/ethernet/freescale/fman/fman_muram.c @@ -144,9 +144,9 @@ unsigned long fman_muram_alloc(struct muram_info *muram, size_t size) /** * fman_muram_free_mem - * muram: FM-MURAM module pointer. - * offset: offset of the memory region to be freed. - * size: size of the memory to be freed. + * @muram: FM-MURAM module pointer. + * @offset: offset of the memory region to be freed. + * @size: size of the memory to be freed. * * Free an allocated memory from FM-MURAM partition. */ diff --git a/drivers/net/ethernet/freescale/fman/fman_port.c b/drivers/net/ethernet/freescale/fman/fman_port.c index 624b2eb6f01d..d9baac0dbc7d 100644 --- a/drivers/net/ethernet/freescale/fman/fman_port.c +++ b/drivers/net/ethernet/freescale/fman/fman_port.c @@ -1410,9 +1410,11 @@ int fman_port_config(struct fman_port *port, struct fman_port_params *params) } EXPORT_SYMBOL(fman_port_config); -/** +/* * fman_port_use_kg_hash - * port: A pointer to a FM Port module. + * @port: A pointer to a FM Port module. + * @enable: enable or disable + * * Sets the HW KeyGen or the BMI as HW Parser next engine, enabling * or bypassing the KeyGen hashing of Rx traffic */ @@ -1430,7 +1432,8 @@ EXPORT_SYMBOL(fman_port_use_kg_hash); /** * fman_port_init - * port: A pointer to a FM Port module. + * @port: A pointer to a FM Port module. + * * Initializes the FM PORT module by defining the software structure and * configuring the hardware registers. * @@ -1524,8 +1527,8 @@ EXPORT_SYMBOL(fman_port_init); /** * fman_port_cfg_buf_prefix_content - * @port A pointer to a FM Port module. - * @buffer_prefix_content A structure of parameters describing + * @port: A pointer to a FM Port module. + * @buffer_prefix_content: A structure of parameters describing * the structure of the buffer. * Out parameter: * Start margin - offset of data from @@ -1570,7 +1573,7 @@ EXPORT_SYMBOL(fman_port_cfg_buf_prefix_content); /** * fman_port_disable - * port: A pointer to a FM Port module. + * @port: A pointer to a FM Port module. * * Gracefully disable an FM port. The port will not start new tasks after all * tasks associated with the port are terminated. @@ -1651,7 +1654,7 @@ EXPORT_SYMBOL(fman_port_disable); /** * fman_port_enable - * port: A pointer to a FM Port module. + * @port: A pointer to a FM Port module. * * A runtime routine provided to allow disable/enable of port. * @@ -1697,7 +1700,7 @@ EXPORT_SYMBOL(fman_port_enable); /** * fman_port_bind - * dev: FMan Port OF device pointer + * @dev: FMan Port OF device pointer * * Bind to a specific FMan Port. * @@ -1713,7 +1716,7 @@ EXPORT_SYMBOL(fman_port_bind); /** * fman_port_get_qman_channel_id - * port: Pointer to the FMan port devuce + * @port: Pointer to the FMan port devuce * * Get the QMan channel ID for the specific port * @@ -1727,7 +1730,7 @@ EXPORT_SYMBOL(fman_port_get_qman_channel_id); /** * fman_port_get_device - * port: Pointer to the FMan port device + * @port: Pointer to the FMan port device * * Get the 'struct device' associated to the specified FMan port device * diff --git a/drivers/net/ethernet/freescale/fman/mac.c b/drivers/net/ethernet/freescale/fman/mac.c index 43427c5b9396..901749a7a318 100644 --- a/drivers/net/ethernet/freescale/fman/mac.c +++ b/drivers/net/ethernet/freescale/fman/mac.c @@ -359,8 +359,8 @@ EXPORT_SYMBOL(fman_set_mac_active_pause); /** * fman_get_pause_cfg * @mac_dev: A pointer to the MAC device - * @rx: Return value for RX setting - * @tx: Return value for TX setting + * @rx_pause: Return value for RX setting + * @tx_pause: Return value for TX setting * * Determine the MAC RX/TX PAUSE frames settings based on PHY * autonegotiation or values set by eththool. diff --git a/drivers/net/ethernet/hisilicon/hns/hnae.c b/drivers/net/ethernet/hisilicon/hns/hnae.c index e017b7c34140..00fafc0f8512 100644 --- a/drivers/net/ethernet/hisilicon/hns/hnae.c +++ b/drivers/net/ethernet/hisilicon/hns/hnae.c @@ -270,7 +270,7 @@ static void hnae_fini_queue(struct hnae_queue *q) hnae_fini_ring(&q->rx_ring); } -/** +/* * ae_chain - define ae chain head */ static RAW_NOTIFIER_HEAD(ae_chain); diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c index 9a907947ba19..4a448138b4ec 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c @@ -374,11 +374,12 @@ static void hns_mac_param_get(struct mac_params *param, } /** - *hns_mac_queue_config_bc_en - set broadcast rx&tx enable - *@mac_cb: mac device - *@queue: queue number - *@en:enable - *retuen 0 - success , negative --fail + * hns_mac_queue_config_bc_en - set broadcast rx&tx enable + * @mac_cb: mac device + * @port_num: queue number + * @vlan_id: vlan id` + * @enable: enable + * return 0 - success , negative --fail */ static int hns_mac_port_config_bc_en(struct hns_mac_cb *mac_cb, u32 port_num, u16 vlan_id, bool enable) @@ -408,11 +409,11 @@ static int hns_mac_port_config_bc_en(struct hns_mac_cb *mac_cb, } /** - *hns_mac_vm_config_bc_en - set broadcast rx&tx enable - *@mac_cb: mac device - *@vmid: vm id - *@en:enable - *retuen 0 - success , negative --fail + * hns_mac_vm_config_bc_en - set broadcast rx&tx enable + * @mac_cb: mac device + * @vmid: vm id + * @enable: enable + * return 0 - success , negative --fail */ int hns_mac_vm_config_bc_en(struct hns_mac_cb *mac_cb, u32 vmid, bool enable) { @@ -542,8 +543,8 @@ void hns_mac_stop(struct hns_mac_cb *mac_cb) /** * hns_mac_get_autoneg - get auto autonegotiation * @mac_cb: mac control block - * @enable: enable or not - * retuen 0 - success , negative --fail + * @auto_neg: output pointer to autoneg result + * return 0 - success , negative --fail */ void hns_mac_get_autoneg(struct hns_mac_cb *mac_cb, u32 *auto_neg) { @@ -560,7 +561,7 @@ void hns_mac_get_autoneg(struct hns_mac_cb *mac_cb, u32 *auto_neg) * @mac_cb: mac control block * @rx_en: rx enable status * @tx_en: tx enable status - * retuen 0 - success , negative --fail + * return 0 - success , negative --fail */ void hns_mac_get_pauseparam(struct hns_mac_cb *mac_cb, u32 *rx_en, u32 *tx_en) { @@ -578,7 +579,7 @@ void hns_mac_get_pauseparam(struct hns_mac_cb *mac_cb, u32 *rx_en, u32 *tx_en) * hns_mac_set_autoneg - set auto autonegotiation * @mac_cb: mac control block * @enable: enable or not - * retuen 0 - success , negative --fail + * return 0 - success , negative --fail */ int hns_mac_set_autoneg(struct hns_mac_cb *mac_cb, u8 enable) { @@ -623,7 +624,7 @@ int hns_mac_set_pauseparam(struct hns_mac_cb *mac_cb, u32 rx_en, u32 tx_en) /** * hns_mac_init_ex - mac init * @mac_cb: mac control block - * retuen 0 - success , negative --fail + * return 0 - success , negative --fail */ static int hns_mac_init_ex(struct hns_mac_cb *mac_cb) { @@ -800,7 +801,6 @@ static const struct { /** *hns_mac_get_info - get mac information from device node *@mac_cb: mac device - *@np:device node * return: 0 --success, negative --fail */ static int hns_mac_get_info(struct hns_mac_cb *mac_cb) @@ -951,7 +951,7 @@ static int hns_mac_get_info(struct hns_mac_cb *mac_cb) /** * hns_mac_get_mode - get mac mode * @phy_if: phy interface - * retuen 0 - gmac, 1 - xgmac , negative --fail + * return 0 - gmac, 1 - xgmac , negative --fail */ static int hns_mac_get_mode(phy_interface_t phy_if) { diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c index acfa86e5296f..87d3db4666df 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c @@ -207,7 +207,7 @@ static int hns_dsaf_get_cfg(struct dsaf_device *dsaf_dev) /** * hns_dsaf_sbm_link_sram_init_en - config dsaf_sbm_init_en - * @dsaf_id: dsa fabric id + * @dsaf_dev: dsa fabric id */ static void hns_dsaf_sbm_link_sram_init_en(struct dsaf_device *dsaf_dev) { @@ -216,8 +216,8 @@ static void hns_dsaf_sbm_link_sram_init_en(struct dsaf_device *dsaf_dev) /** * hns_dsaf_reg_cnt_clr_ce - config hns_dsaf_reg_cnt_clr_ce - * @dsaf_id: dsa fabric id - * @hns_dsaf_reg_cnt_clr_ce: config value + * @dsaf_dev: dsa fabric id + * @reg_cnt_clr_ce: config value */ static void hns_dsaf_reg_cnt_clr_ce(struct dsaf_device *dsaf_dev, u32 reg_cnt_clr_ce) @@ -228,8 +228,8 @@ hns_dsaf_reg_cnt_clr_ce(struct dsaf_device *dsaf_dev, u32 reg_cnt_clr_ce) /** * hns_ppe_qid_cfg - config ppe qid - * @dsaf_id: dsa fabric id - * @pppe_qid_cfg: value array + * @dsaf_dev: dsa fabric id + * @qid_cfg: value array */ static void hns_dsaf_ppe_qid_cfg(struct dsaf_device *dsaf_dev, u32 qid_cfg) @@ -285,8 +285,8 @@ static void hns_dsaf_inner_qid_cfg(struct dsaf_device *dsaf_dev) /** * hns_dsaf_sw_port_type_cfg - cfg sw type - * @dsaf_id: dsa fabric id - * @psw_port_type: array + * @dsaf_dev: dsa fabric id + * @port_type: array */ static void hns_dsaf_sw_port_type_cfg(struct dsaf_device *dsaf_dev, enum dsaf_sw_port_type port_type) @@ -303,8 +303,8 @@ static void hns_dsaf_sw_port_type_cfg(struct dsaf_device *dsaf_dev, /** * hns_dsaf_stp_port_type_cfg - cfg stp type - * @dsaf_id: dsa fabric id - * @pstp_port_type: array + * @dsaf_dev: dsa fabric id + * @port_type: array */ static void hns_dsaf_stp_port_type_cfg(struct dsaf_device *dsaf_dev, enum dsaf_stp_port_type port_type) @@ -323,7 +323,7 @@ static void hns_dsaf_stp_port_type_cfg(struct dsaf_device *dsaf_dev, (AE_IS_VER1((dev)->dsaf_ver) ? DSAF_SBM_NUM : DSAFV2_SBM_NUM) /** * hns_dsaf_sbm_cfg - config sbm - * @dsaf_id: dsa fabric id + * @dsaf_dev: dsa fabric id */ static void hns_dsaf_sbm_cfg(struct dsaf_device *dsaf_dev) { @@ -342,7 +342,7 @@ static void hns_dsaf_sbm_cfg(struct dsaf_device *dsaf_dev) /** * hns_dsaf_sbm_cfg_mib_en - config sbm - * @dsaf_id: dsa fabric id + * @dsaf_dev: dsa fabric id */ static int hns_dsaf_sbm_cfg_mib_en(struct dsaf_device *dsaf_dev) { @@ -387,7 +387,7 @@ static int hns_dsaf_sbm_cfg_mib_en(struct dsaf_device *dsaf_dev) /** * hns_dsaf_sbm_bp_wl_cfg - config sbm - * @dsaf_id: dsa fabric id + * @dsaf_dev: dsa fabric id */ static void hns_dsaf_sbm_bp_wl_cfg(struct dsaf_device *dsaf_dev) { @@ -556,7 +556,7 @@ static void hns_dsafv2_sbm_bp_wl_cfg(struct dsaf_device *dsaf_dev) /** * hns_dsaf_voq_bp_all_thrd_cfg - voq - * @dsaf_id: dsa fabric id + * @dsaf_dev: dsa fabric id */ static void hns_dsaf_voq_bp_all_thrd_cfg(struct dsaf_device *dsaf_dev) { @@ -599,7 +599,7 @@ static void hns_dsaf_tbl_tcam_match_cfg( /** * hns_dsaf_tbl_tcam_data_cfg - tbl - * @dsaf_id: dsa fabric id + * @dsaf_dev: dsa fabric id * @ptbl_tcam_data: addr */ static void hns_dsaf_tbl_tcam_data_cfg( @@ -614,8 +614,8 @@ static void hns_dsaf_tbl_tcam_data_cfg( /** * dsaf_tbl_tcam_mcast_cfg - tbl - * @dsaf_id: dsa fabric id - * @ptbl_tcam_mcast: addr + * @dsaf_dev: dsa fabric id + * @mcast: addr */ static void hns_dsaf_tbl_tcam_mcast_cfg( struct dsaf_device *dsaf_dev, @@ -648,8 +648,8 @@ static void hns_dsaf_tbl_tcam_mcast_cfg( /** * hns_dsaf_tbl_tcam_ucast_cfg - tbl - * @dsaf_id: dsa fabric id - * @ptbl_tcam_ucast: addr + * @dsaf_dev: dsa fabric id + * @tbl_tcam_ucast: addr */ static void hns_dsaf_tbl_tcam_ucast_cfg( struct dsaf_device *dsaf_dev, @@ -674,8 +674,8 @@ static void hns_dsaf_tbl_tcam_ucast_cfg( /** * hns_dsaf_tbl_line_cfg - tbl - * @dsaf_id: dsa fabric id - * @ptbl_lin: addr + * @dsaf_dev: dsa fabric id + * @tbl_lin: addr */ static void hns_dsaf_tbl_line_cfg(struct dsaf_device *dsaf_dev, struct dsaf_tbl_line_cfg *tbl_lin) @@ -695,7 +695,7 @@ static void hns_dsaf_tbl_line_cfg(struct dsaf_device *dsaf_dev, /** * hns_dsaf_tbl_tcam_mcast_pul - tbl - * @dsaf_id: dsa fabric id + * @dsaf_dev: dsa fabric id */ static void hns_dsaf_tbl_tcam_mcast_pul(struct dsaf_device *dsaf_dev) { @@ -710,7 +710,7 @@ static void hns_dsaf_tbl_tcam_mcast_pul(struct dsaf_device *dsaf_dev) /** * hns_dsaf_tbl_line_pul - tbl - * @dsaf_id: dsa fabric id + * @dsaf_dev: dsa fabric id */ static void hns_dsaf_tbl_line_pul(struct dsaf_device *dsaf_dev) { @@ -725,7 +725,7 @@ static void hns_dsaf_tbl_line_pul(struct dsaf_device *dsaf_dev) /** * hns_dsaf_tbl_tcam_data_mcast_pul - tbl - * @dsaf_id: dsa fabric id + * @dsaf_dev: dsa fabric id */ static void hns_dsaf_tbl_tcam_data_mcast_pul( struct dsaf_device *dsaf_dev) @@ -743,7 +743,7 @@ static void hns_dsaf_tbl_tcam_data_mcast_pul( /** * hns_dsaf_tbl_tcam_data_ucast_pul - tbl - * @dsaf_id: dsa fabric id + * @dsaf_dev: dsa fabric id */ static void hns_dsaf_tbl_tcam_data_ucast_pul( struct dsaf_device *dsaf_dev) @@ -768,8 +768,7 @@ void hns_dsaf_set_promisc_mode(struct dsaf_device *dsaf_dev, u32 en) /** * hns_dsaf_tbl_stat_en - tbl - * @dsaf_id: dsa fabric id - * @ptbl_stat_en: addr + * @dsaf_dev: dsa fabric id */ static void hns_dsaf_tbl_stat_en(struct dsaf_device *dsaf_dev) { @@ -785,7 +784,7 @@ static void hns_dsaf_tbl_stat_en(struct dsaf_device *dsaf_dev) /** * hns_dsaf_rocee_bp_en - rocee back press enable - * @dsaf_id: dsa fabric id + * @dsaf_dev: dsa fabric id */ static void hns_dsaf_rocee_bp_en(struct dsaf_device *dsaf_dev) { @@ -852,9 +851,9 @@ static void hns_dsaf_int_tbl_src_clr(struct dsaf_device *dsaf_dev, /** * hns_dsaf_single_line_tbl_cfg - INT - * @dsaf_id: dsa fabric id - * @address: - * @ptbl_line: + * @dsaf_dev: dsa fabric id + * @address: the address + * @ptbl_line: the line */ static void hns_dsaf_single_line_tbl_cfg( struct dsaf_device *dsaf_dev, @@ -876,9 +875,10 @@ static void hns_dsaf_single_line_tbl_cfg( /** * hns_dsaf_tcam_uc_cfg - INT - * @dsaf_id: dsa fabric id - * @address, - * @ptbl_tcam_data, + * @dsaf_dev: dsa fabric id + * @address: the address + * @ptbl_tcam_data: the data + * @ptbl_tcam_ucast: unicast */ static void hns_dsaf_tcam_uc_cfg( struct dsaf_device *dsaf_dev, u32 address, @@ -904,7 +904,8 @@ static void hns_dsaf_tcam_uc_cfg( * @dsaf_dev: dsa fabric device struct pointer * @address: tcam index * @ptbl_tcam_data: tcam data struct pointer - * @ptbl_tcam_mcast: tcam mask struct pointer, it must be null for HNSv1 + * @ptbl_tcam_mask: tcam mask struct pointer, it must be null for HNSv1 + * @ptbl_tcam_mcast: tcam data struct pointer */ static void hns_dsaf_tcam_mc_cfg( struct dsaf_device *dsaf_dev, u32 address, @@ -933,8 +934,10 @@ static void hns_dsaf_tcam_mc_cfg( /** * hns_dsaf_tcam_uc_cfg_vague - INT * @dsaf_dev: dsa fabric device struct pointer - * @address, - * @ptbl_tcam_data, + * @address: the address + * @tcam_data: the data + * @tcam_mask: the mask + * @tcam_uc: the unicast data */ static void hns_dsaf_tcam_uc_cfg_vague(struct dsaf_device *dsaf_dev, u32 address, @@ -960,10 +963,10 @@ static void hns_dsaf_tcam_uc_cfg_vague(struct dsaf_device *dsaf_dev, /** * hns_dsaf_tcam_mc_cfg_vague - INT * @dsaf_dev: dsa fabric device struct pointer - * @address, - * @ptbl_tcam_data, - * @ptbl_tcam_mask - * @ptbl_tcam_mcast + * @address: the address + * @tcam_data: the data + * @tcam_mask: the mask + * @tcam_mc: the multicast data */ static void hns_dsaf_tcam_mc_cfg_vague(struct dsaf_device *dsaf_dev, u32 address, @@ -988,8 +991,8 @@ static void hns_dsaf_tcam_mc_cfg_vague(struct dsaf_device *dsaf_dev, /** * hns_dsaf_tcam_mc_invld - INT - * @dsaf_id: dsa fabric id - * @address + * @dsaf_dev: dsa fabric id + * @address: the address */ static void hns_dsaf_tcam_mc_invld(struct dsaf_device *dsaf_dev, u32 address) { @@ -1024,10 +1027,10 @@ hns_dsaf_tcam_addr_get(struct dsaf_drv_tbl_tcam_key *mac_key, u8 *addr) /** * hns_dsaf_tcam_uc_get - INT - * @dsaf_id: dsa fabric id - * @address - * @ptbl_tcam_data - * @ptbl_tcam_ucast + * @dsaf_dev: dsa fabric id + * @address: the address + * @ptbl_tcam_data: the data + * @ptbl_tcam_ucast: unicast */ static void hns_dsaf_tcam_uc_get( struct dsaf_device *dsaf_dev, u32 address, @@ -1077,10 +1080,10 @@ static void hns_dsaf_tcam_uc_get( /** * hns_dsaf_tcam_mc_get - INT - * @dsaf_id: dsa fabric id - * @address - * @ptbl_tcam_data - * @ptbl_tcam_ucast + * @dsaf_dev: dsa fabric id + * @address: the address + * @ptbl_tcam_data: the data + * @ptbl_tcam_mcast: tcam multicast data */ static void hns_dsaf_tcam_mc_get( struct dsaf_device *dsaf_dev, u32 address, @@ -1127,7 +1130,7 @@ static void hns_dsaf_tcam_mc_get( /** * hns_dsaf_tbl_line_init - INT - * @dsaf_id: dsa fabric id + * @dsaf_dev: dsa fabric id */ static void hns_dsaf_tbl_line_init(struct dsaf_device *dsaf_dev) { @@ -1141,7 +1144,7 @@ static void hns_dsaf_tbl_line_init(struct dsaf_device *dsaf_dev) /** * hns_dsaf_tbl_tcam_init - INT - * @dsaf_id: dsa fabric id + * @dsaf_dev: dsa fabric id */ static void hns_dsaf_tbl_tcam_init(struct dsaf_device *dsaf_dev) { @@ -1156,7 +1159,9 @@ static void hns_dsaf_tbl_tcam_init(struct dsaf_device *dsaf_dev) /** * hns_dsaf_pfc_en_cfg - dsaf pfc pause cfg - * @mac_cb: mac contrl block + * @dsaf_dev: dsa fabric id + * @mac_id: mac contrl block + * @tc_en: traffic class */ static void hns_dsaf_pfc_en_cfg(struct dsaf_device *dsaf_dev, int mac_id, int tc_en) @@ -1209,8 +1214,7 @@ void hns_dsaf_get_rx_mac_pause_en(struct dsaf_device *dsaf_dev, int mac_id, /** * hns_dsaf_tbl_tcam_init - INT - * @dsaf_id: dsa fabric id - * @dsaf_mode + * @dsaf_dev: dsa fabric id */ static void hns_dsaf_comm_init(struct dsaf_device *dsaf_dev) { @@ -1263,7 +1267,7 @@ static void hns_dsaf_comm_init(struct dsaf_device *dsaf_dev) /** * hns_dsaf_inode_init - INT - * @dsaf_id: dsa fabric id + * @dsaf_dev: dsa fabric id */ static void hns_dsaf_inode_init(struct dsaf_device *dsaf_dev) { @@ -1315,7 +1319,7 @@ static void hns_dsaf_inode_init(struct dsaf_device *dsaf_dev) /** * hns_dsaf_sbm_init - INT - * @dsaf_id: dsa fabric id + * @dsaf_dev: dsa fabric id */ static int hns_dsaf_sbm_init(struct dsaf_device *dsaf_dev) { @@ -1369,7 +1373,7 @@ static int hns_dsaf_sbm_init(struct dsaf_device *dsaf_dev) /** * hns_dsaf_tbl_init - INT - * @dsaf_id: dsa fabric id + * @dsaf_dev: dsa fabric id */ static void hns_dsaf_tbl_init(struct dsaf_device *dsaf_dev) { @@ -1381,7 +1385,7 @@ static void hns_dsaf_tbl_init(struct dsaf_device *dsaf_dev) /** * hns_dsaf_voq_init - INT - * @dsaf_id: dsa fabric id + * @dsaf_dev: dsa fabric id */ static void hns_dsaf_voq_init(struct dsaf_device *dsaf_dev) { @@ -1435,7 +1439,7 @@ static void hns_dsaf_remove_hw(struct dsaf_device *dsaf_dev) /** * hns_dsaf_init - init dsa fabric * @dsaf_dev: dsa fabric device struct pointer - * retuen 0 - success , negative --fail + * return 0 - success , negative --fail */ static int hns_dsaf_init(struct dsaf_device *dsaf_dev) { @@ -2099,7 +2103,7 @@ static struct dsaf_device *hns_dsaf_alloc_dev(struct device *dev, /** * hns_dsaf_free_dev - free dev mem - * @dev: struct device pointer + * @dsaf_dev: struct device pointer */ static void hns_dsaf_free_dev(struct dsaf_device *dsaf_dev) { @@ -2108,9 +2112,9 @@ static void hns_dsaf_free_dev(struct dsaf_device *dsaf_dev) /** * dsaf_pfc_unit_cnt - set pfc unit count - * @dsaf_id: dsa fabric id - * @pport_rate: value array - * @pdsaf_pfc_unit_cnt: value array + * @dsaf_dev: dsa fabric id + * @mac_id: id in use + * @rate: value array */ static void hns_dsaf_pfc_unit_cnt(struct dsaf_device *dsaf_dev, int mac_id, enum dsaf_port_rate_mode rate) @@ -2139,8 +2143,9 @@ static void hns_dsaf_pfc_unit_cnt(struct dsaf_device *dsaf_dev, int mac_id, /** * dsaf_port_work_rate_cfg - fifo - * @dsaf_id: dsa fabric id - * @xge_ge_work_mode + * @dsaf_dev: dsa fabric id + * @mac_id: mac contrl block + * @rate_mode: value array */ static void hns_dsaf_port_work_rate_cfg(struct dsaf_device *dsaf_dev, int mac_id, @@ -2253,7 +2258,8 @@ void hns_dsaf_update_stats(struct dsaf_device *dsaf_dev, u32 node_num) /** *hns_dsaf_get_regs - dump dsaf regs - *@dsaf_dev: dsaf device + *@ddev: dsaf device + *@port: port *@data:data for value of regs */ void hns_dsaf_get_regs(struct dsaf_device *ddev, u32 port, void *data) @@ -2690,6 +2696,7 @@ void hns_dsaf_get_stats(struct dsaf_device *ddev, u64 *data, int port) /** *hns_dsaf_get_sset_count - get dsaf string set count + *@dsaf_dev: dsaf device *@stringset: type of values in data *return dsaf string name count */ @@ -2711,6 +2718,7 @@ int hns_dsaf_get_sset_count(struct dsaf_device *dsaf_dev, int stringset) *@stringset:srting set index *@data:strings name value *@port:port index + *@dsaf_dev: dsaf device */ void hns_dsaf_get_strings(int stringset, u8 *data, int port, struct dsaf_device *dsaf_dev) @@ -2943,7 +2951,7 @@ int hns_dsaf_wait_pkt_clean(struct dsaf_device *dsaf_dev, int port) /** * dsaf_probe - probo dsaf dev * @pdev: dasf platform device - * retuen 0 - success , negative --fail + * return 0 - success , negative --fail */ static int hns_dsaf_probe(struct platform_device *pdev) { @@ -3038,8 +3046,8 @@ module_platform_driver(g_dsaf_driver); /** * hns_dsaf_roce_reset - reset dsaf and roce * @dsaf_fwnode: Pointer to framework node for the dasf - * @enable: false - request reset , true - drop reset - * retuen 0 - success , negative -fail + * @dereset: false - request reset , true - drop reset + * return 0 - success , negative -fail */ int hns_dsaf_roce_reset(struct fwnode_handle *dsaf_fwnode, bool dereset) { diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c index ed3829ae4ef1..d5c5887aa468 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c @@ -330,11 +330,11 @@ static void hns_dsaf_xge_srst_by_port_acpi(struct dsaf_device *dsaf_dev, * hns_dsaf_srst_chns - reset dsaf channels * @dsaf_dev: dsaf device struct pointer * @msk: xbar channels mask value: + * @dereset: false - request reset , true - drop reset * bit0-5 for xge0-5 * bit6-11 for ppe0-5 * bit12-17 for roce0-5 * bit18-19 for com/dfx - * @enable: false - request reset , true - drop reset */ static void hns_dsaf_srst_chns(struct dsaf_device *dsaf_dev, u32 msk, bool dereset) @@ -353,11 +353,11 @@ hns_dsaf_srst_chns(struct dsaf_device *dsaf_dev, u32 msk, bool dereset) * hns_dsaf_srst_chns - reset dsaf channels * @dsaf_dev: dsaf device struct pointer * @msk: xbar channels mask value: + * @dereset: false - request reset , true - drop reset * bit0-5 for xge0-5 * bit6-11 for ppe0-5 * bit12-17 for roce0-5 * bit18-19 for com/dfx - * @enable: false - request reset , true - drop reset */ static void hns_dsaf_srst_chns_acpi(struct dsaf_device *dsaf_dev, u32 msk, bool dereset) @@ -612,7 +612,8 @@ static int hns_mac_get_sfp_prsnt_acpi(struct hns_mac_cb *mac_cb, int *sfp_prsnt) /** * hns_mac_config_sds_loopback - set loop back for serdes * @mac_cb: mac control block - * retuen 0 == success + * @en: enable or disable + * return 0 == success */ static int hns_mac_config_sds_loopback(struct hns_mac_cb *mac_cb, bool en) { diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c index 2b34b553acf3..d0f8b1fff333 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c @@ -66,8 +66,8 @@ hns_ppe_common_get_ioaddr(struct ppe_common_cb *ppe_common) /** * hns_ppe_common_get_cfg - get ppe common config * @dsaf_dev: dasf device - * comm_index: common index - * retuen 0 - success , negative --fail + * @comm_index: common index + * return 0 - success , negative --fail */ static int hns_ppe_common_get_cfg(struct dsaf_device *dsaf_dev, int comm_index) { @@ -143,7 +143,7 @@ static void hns_ppe_set_vlan_strip(struct hns_ppe_cb *ppe_cb, int en) /** * hns_ppe_checksum_hw - set ppe checksum caculate - * @ppe_device: ppe device + * @ppe_cb: ppe device * @value: value */ static void hns_ppe_checksum_hw(struct hns_ppe_cb *ppe_cb, u32 value) @@ -179,7 +179,7 @@ static void hns_ppe_set_qid(struct ppe_common_cb *ppe_common, u32 qid) /** * hns_ppe_set_port_mode - set port mode - * @ppe_device: ppe device + * @ppe_cb: ppe device * @mode: port mode */ static void hns_ppe_set_port_mode(struct hns_ppe_cb *ppe_cb, @@ -344,7 +344,7 @@ static void hns_ppe_init_hw(struct hns_ppe_cb *ppe_cb) /** * ppe_uninit_hw - uninit ppe - * @ppe_device: ppe device + * @ppe_cb: ppe device */ static void hns_ppe_uninit_hw(struct hns_ppe_cb *ppe_cb) { @@ -384,7 +384,8 @@ void hns_ppe_uninit(struct dsaf_device *dsaf_dev) /** * hns_ppe_reset - reinit ppe/rcb hw * @dsaf_dev: dasf device - * retuen void + * @ppe_common_index: the index + * return void */ void hns_ppe_reset_common(struct dsaf_device *dsaf_dev, u8 ppe_common_index) { @@ -455,7 +456,7 @@ int hns_ppe_get_regs_count(void) /** * ppe_get_strings - get ppe srting - * @ppe_device: ppe device + * @ppe_cb: ppe device * @stringset: string set type * @data: output string */ @@ -513,7 +514,7 @@ void hns_ppe_get_stats(struct hns_ppe_cb *ppe_cb, u64 *data) /** * hns_ppe_init - init ppe device * @dsaf_dev: dasf device - * retuen 0 - success , negative --fail + * return 0 - success , negative --fail */ int hns_ppe_init(struct dsaf_device *dsaf_dev) { diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c index 5453597ec629..b6c8910cf7ba 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c @@ -34,7 +34,7 @@ /** *hns_rcb_wait_fbd_clean - clean fbd *@qs: ring struct pointer array - *@qnum: num of array + *@q_num: num of array *@flag: tx or rx flag */ void hns_rcb_wait_fbd_clean(struct hnae_queue **qs, int q_num, u32 flag) @@ -191,7 +191,8 @@ void hns_rcbv2_int_clr_hw(struct hnae_queue *q, u32 flag) /** *hns_rcb_ring_enable_hw - enable ring - *@ring: rcb ring + *@q: rcb ring + *@val: value to write */ void hns_rcb_ring_enable_hw(struct hnae_queue *q, u32 val) { @@ -844,7 +845,7 @@ void hns_rcb_update_stats(struct hnae_queue *queue) /** *hns_rcb_get_stats - get rcb statistic - *@ring: rcb ring + *@queue: rcb ring *@data:statistic value */ void hns_rcb_get_stats(struct hnae_queue *queue, u64 *data) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c index d832cd018c1c..7e3609ce112a 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c @@ -242,7 +242,8 @@ static void hns_xgmac_config_pad_and_crc(void *mac_drv, u8 newval) /** *hns_xgmac_pausefrm_cfg - set pause param about xgmac *@mac_drv: mac driver - *@newval:enable of pad and crc + *@rx_en: enable receive + *@tx_en: enable transmit */ static void hns_xgmac_pausefrm_cfg(void *mac_drv, u32 rx_en, u32 tx_en) { diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c b/drivers/net/ethernet/hisilicon/hns/hns_enet.c index b658b9de81d7..b9fd4a716527 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_enet.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_enet.c @@ -751,6 +751,8 @@ static void hns_update_rx_rate(struct hnae_ring *ring) /** * smooth_alg - smoothing algrithm for adjusting coalesce parameter + * @new_param: new value + * @old_param: old value **/ static u32 smooth_alg(u32 new_param, u32 old_param) { @@ -1828,7 +1830,7 @@ static int hns_nic_uc_unsync(struct net_device *netdev, } /** - * nic_set_multicast_list - set mutl mac address + * hns_set_multicast_list - set mutl mac address * @ndev: net device * * return void diff --git a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c index 4eb50296f653..f067320d426b 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c @@ -462,9 +462,9 @@ static int __lb_clean_rings(struct hns_nic_priv *priv, } /** - * nic_run_loopback_test - run loopback test - * @nic_dev: net device - * @loopback_type: loopback type + * __lb_run_test - run loopback test + * @ndev: net device + * @loop_mode: loopback type */ static int __lb_run_test(struct net_device *ndev, enum hnae_loop loop_mode) @@ -572,7 +572,7 @@ static int __lb_down(struct net_device *ndev, enum hnae_loop loop) /** * hns_nic_self_test - self test - * @dev: net device + * @ndev: net device * @eth_test: test cmd * @data: test result */ @@ -633,7 +633,7 @@ static void hns_nic_self_test(struct net_device *ndev, /** * hns_nic_get_drvinfo - get net driver info - * @dev: net device + * @net_dev: net device * @drvinfo: driver info */ static void hns_nic_get_drvinfo(struct net_device *net_dev, @@ -658,7 +658,7 @@ static void hns_nic_get_drvinfo(struct net_device *net_dev, /** * hns_get_ringparam - get ring parameter - * @dev: net device + * @net_dev: net device * @param: ethtool parameter */ static void hns_get_ringparam(struct net_device *net_dev, @@ -683,7 +683,7 @@ static void hns_get_ringparam(struct net_device *net_dev, /** * hns_get_pauseparam - get pause parameter - * @dev: net device + * @net_dev: net device * @param: pause parameter */ static void hns_get_pauseparam(struct net_device *net_dev, @@ -701,7 +701,7 @@ static void hns_get_pauseparam(struct net_device *net_dev, /** * hns_set_pauseparam - set pause parameter - * @dev: net device + * @net_dev: net device * @param: pause parameter * * Return 0 on success, negative on failure @@ -725,7 +725,7 @@ static int hns_set_pauseparam(struct net_device *net_dev, /** * hns_get_coalesce - get coalesce info. - * @dev: net device + * @net_dev: net device * @ec: coalesce info. * * Return 0 on success, negative on failure. @@ -769,7 +769,7 @@ static int hns_get_coalesce(struct net_device *net_dev, /** * hns_set_coalesce - set coalesce info. - * @dev: net device + * @net_dev: net device * @ec: coalesce info. * * Return 0 on success, negative on failure. @@ -808,7 +808,7 @@ static int hns_set_coalesce(struct net_device *net_dev, /** * hns_get_channels - get channel info. - * @dev: net device + * @net_dev: net device * @ch: channel info. */ static void @@ -825,7 +825,7 @@ hns_get_channels(struct net_device *net_dev, struct ethtool_channels *ch) /** * get_ethtool_stats - get detail statistics. - * @dev: net device + * @netdev: net device * @stats: statistics info. * @data: statistics data. */ @@ -883,8 +883,8 @@ static void hns_get_ethtool_stats(struct net_device *netdev, /** * get_strings: Return a set of strings that describe the requested objects - * @dev: net device - * @stats: string set ID. + * @netdev: net device + * @stringset: string set ID. * @data: objects data. */ static void hns_get_strings(struct net_device *netdev, u32 stringset, u8 *data) @@ -971,8 +971,8 @@ static void hns_get_strings(struct net_device *netdev, u32 stringset, u8 *data) } /** - * nic_get_sset_count - get string set count witch returned by nic_get_strings. - * @dev: net device + * hns_get_sset_count - get string set count witch returned by nic_get_strings. + * @netdev: net device * @stringset: string set index, 0: self test string; 1: statistics string. * * Return string set count. @@ -1006,7 +1006,7 @@ static int hns_get_sset_count(struct net_device *netdev, int stringset) /** * hns_phy_led_set - set phy LED status. - * @dev: net device + * @netdev: net device * @value: LED state. * * Return 0 on success, negative on failure. @@ -1027,8 +1027,8 @@ static int hns_phy_led_set(struct net_device *netdev, int value) } /** - * nic_set_phys_id - set phy identify LED. - * @dev: net device + * hns_set_phys_id - set phy identify LED. + * @netdev: net device * @state: LED state. * * Return 0 on success, negative on failure. @@ -1104,9 +1104,9 @@ hns_set_phys_id(struct net_device *netdev, enum ethtool_phys_id_state state) /** * hns_get_regs - get net device register - * @dev: net device + * @net_dev: net device * @cmd: ethtool cmd - * @date: register data + * @data: register data */ static void hns_get_regs(struct net_device *net_dev, struct ethtool_regs *cmd, void *data) @@ -1125,8 +1125,8 @@ static void hns_get_regs(struct net_device *net_dev, struct ethtool_regs *cmd, } /** - * nic_get_regs_len - get total register len. - * @dev: net device + * hns_get_regs_len - get total register len. + * @net_dev: net device * * Return total register len. */ @@ -1151,7 +1151,7 @@ static int hns_get_regs_len(struct net_device *net_dev) /** * hns_nic_nway_reset - nway reset - * @dev: net device + * @netdev: net device * * Return 0 on success, negative on failure */ diff --git a/drivers/net/ethernet/hisilicon/hns_mdio.c b/drivers/net/ethernet/hisilicon/hns_mdio.c index 7df5d7d211d4..883d0d7c6858 100644 --- a/drivers/net/ethernet/hisilicon/hns_mdio.c +++ b/drivers/net/ethernet/hisilicon/hns_mdio.c @@ -210,7 +210,7 @@ static void hns_mdio_cmd_write(struct hns_mdio_device *mdio_dev, * @bus: mdio bus * @phy_id: phy id * @regnum: register num - * @value: register value + * @data: register value * * Return 0 on success, negative on failure */ @@ -273,7 +273,6 @@ static int hns_mdio_write(struct mii_bus *bus, * @bus: mdio bus * @phy_id: phy id * @regnum: register num - * @value: register value * * Return phy register value */ diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c b/drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c index e0eb294779ec..5a6bbee819cd 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c @@ -784,7 +784,7 @@ static void free_cmdq(struct hinic_cmdq *cmdq) * init_cmdqs_ctxt - write the cmdq ctxt to HW after init all cmdq * @hwdev: the NIC HW device * @cmdqs: cmdqs to write the ctxts for - * &db_area: db_area for all the cmdqs + * @db_area: db_area for all the cmdqs * * Return 0 - Success, negative - Failure **/ diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c b/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c index 239685152f6e..7f1a92a6c7ec 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c @@ -437,6 +437,8 @@ static int get_base_qpn(struct hinic_hwdev *hwdev, u16 *base_qpn) /** * hinic_hwdev_ifup - Preparing the HW for passing IO * @hwdev: the NIC HW device + * @sq_depth: send queue depth + * @rq_depth: receive queue depth * * Return 0 - Success, negative - Failure **/ @@ -582,6 +584,7 @@ void hinic_hwdev_cb_unregister(struct hinic_hwdev *hwdev, /** * nic_mgmt_msg_handler - nic mgmt event handler * @handle: private data for the handler + * @cmd: the command * @buf_in: input buffer * @in_size: input size * @buf_out: output buffer @@ -909,6 +912,7 @@ int hinic_set_interrupt_cfg(struct hinic_hwdev *hwdev, /** * hinic_init_hwdev - Initialize the NIC HW * @pdev: the NIC pci device + * @devlink: struct devlink * * Return initialized NIC HW device * @@ -1121,7 +1125,7 @@ int hinic_hwdev_msix_cnt_set(struct hinic_hwdev *hwdev, u16 msix_index) * @msix_index: msix_index * @pending_limit: the maximum pending interrupt events (unit 8) * @coalesc_timer: coalesc period for interrupt (unit 8 us) - * @lli_timer: replenishing period for low latency credit (unit 8 us) + * @lli_timer_cfg: replenishing period for low latency credit (unit 8 us) * @lli_credit_limit: maximum credits for low latency msix messages (unit 8) * @resend_timer: maximum wait for resending msix (unit coalesc period) * diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c b/drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c index b30733f4a59e..83296c7aab90 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c @@ -188,6 +188,7 @@ static u8 eq_cons_idx_checksum_set(u32 val) /** * eq_update_ci - update the HW cons idx of event queue * @eq: the event queue to update the cons idx for + * @arm_state: to arm or not **/ static void eq_update_ci(struct hinic_eq *eq, u32 arm_state) { diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_if.c b/drivers/net/ethernet/huawei/hinic/hinic_hw_if.c index bc8925c0c982..50f14e014656 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_hw_if.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_if.c @@ -230,6 +230,7 @@ static int wait_hwif_ready(struct hinic_hwif *hwif) * @hwif: the HW interface of a pci function device * @attr0: the first attribute that was read from the hw * @attr1: the second attribute that was read from the hw + * @attr2: the second attribute that was read from the hw **/ static void set_hwif_attr(struct hinic_hwif *hwif, u32 attr0, u32 attr1, u32 attr2) diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_mgmt.c b/drivers/net/ethernet/huawei/hinic/hinic_hw_mgmt.c index c6ce5966284c..b6d5a34325f4 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_hw_mgmt.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_mgmt.c @@ -234,6 +234,7 @@ static int send_msg_to_mgmt(struct hinic_pf_to_mgmt *pf_to_mgmt, * @out_size: response length * @direction: the direction of the original message * @resp_msg_id: msg id to response for + * @timeout: the timeout value * * Return 0 - Success, negative - Failure **/ diff --git a/drivers/net/ethernet/huawei/hinic/hinic_main.c b/drivers/net/ethernet/huawei/hinic/hinic_main.c index 797c55a1d9c6..8039bd329b3c 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_main.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_main.c @@ -961,7 +961,7 @@ static void hinic_refresh_nic_cfg(struct hinic_dev *nic_dev) * @handle: nic device for the handler * @buf_in: input buffer * @in_size: input size - * @buf_in: output buffer + * @buf_out: output buffer * @out_size: returned output size * * Return 0 - Success, negative - Failure diff --git a/drivers/net/ethernet/micrel/ksz884x.c b/drivers/net/ethernet/micrel/ksz884x.c index c84a1e8c918b..920722273059 100644 --- a/drivers/net/ethernet/micrel/ksz884x.c +++ b/drivers/net/ethernet/micrel/ksz884x.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/** +/* * drivers/net/ethernet/micrel/ksx884x.c - Micrel KSZ8841/2 PCI Ethernet driver * * Copyright (c) 2009-2010 Micrel, Inc. @@ -959,7 +959,7 @@ struct ksz_sw_desc { * struct ksz_dma_buf - OS dependent DMA buffer data structure * @skb: Associated socket buffer. * @dma: Associated physical DMA address. - * len: Actual len used. + * @len: Actual len used. */ struct ksz_dma_buf { struct sk_buff *skb; @@ -1254,6 +1254,7 @@ struct ksz_port_info { * @multi_list_size: Multicast address list size. * @enabled: Indication of hardware enabled. * @rx_stop: Indication of receive process stop. + * @reserved2: none * @features: Hardware features to enable. * @overrides: Hardware features to override. * @parent: Pointer to parent, network device private structure. @@ -1447,7 +1448,7 @@ struct dev_info { * struct dev_priv - Network device private data structure * @adapter: Adapter device information. * @port: Port information. - * @monitor_time_info: Timer to monitor ports. + * @monitor_timer_info: Timer to monitor ports. * @proc_sem: Semaphore for proc accessing. * @id: Device ID. * @mii_if: MII interface information. @@ -1566,6 +1567,7 @@ static inline void hw_restore_intr(struct ksz_hw *hw, uint interrupt) /** * hw_block_intr - block hardware interrupts + * @hw: The hardware instance. * * This function blocks all interrupts of the hardware and returns the current * interrupt enable mask so that interrupts can be restored later. @@ -1818,6 +1820,7 @@ static void port_r_mib_cnt(struct ksz_hw *hw, int port, u16 addr, u64 *cnt) * port_r_mib_pkt - read dropped packet counts * @hw: The hardware instance. * @port: The port index. + * @last: last one * @cnt: Buffer to store the receive and transmit dropped packet counts. * * This routine reads the dropped packet counts of the port. @@ -1971,7 +1974,7 @@ static void port_cfg(struct ksz_hw *hw, int port, int offset, u16 bits, * port_chk_shift - check port bit * @hw: The hardware instance. * @port: The port index. - * @offset: The offset of the register. + * @addr: The offset of the register. * @shift: Number of bits to shift. * * This function checks whether the specified port is set in the register or @@ -1993,7 +1996,7 @@ static int port_chk_shift(struct ksz_hw *hw, int port, u32 addr, int shift) * port_cfg_shift - set port bit * @hw: The hardware instance. * @port: The port index. - * @offset: The offset of the register. + * @addr: The offset of the register. * @shift: Number of bits to shift. * @set: The flag indicating whether the port is to be set or not. * @@ -4424,6 +4427,8 @@ static int ksz_alloc_desc(struct dev_info *adapter) /** * free_dma_buf - release DMA buffer resources * @adapter: Adapter information structure. + * @dma_buf: pointer to buf + * @direction: to or from device * * This routine is just a helper function to release the DMA buffer resources. */ @@ -4561,6 +4566,7 @@ static void ksz_free_desc(struct dev_info *adapter) * ksz_free_buffers - free buffers used in the descriptors * @adapter: Adapter information structure. * @desc_info: Descriptor information structure. + * @direction: to or from device * * This local routine frees buffers used in the DMA buffers. */ @@ -4720,7 +4726,8 @@ static void send_packet(struct sk_buff *skb, struct net_device *dev) /** * transmit_cleanup - clean up transmit descriptors - * @dev: Network device. + * @hw_priv: Network device. + * @normal: break if owned * * This routine is called to clean up the transmitted buffers. */ @@ -4776,7 +4783,7 @@ static void transmit_cleanup(struct dev_info *hw_priv, int normal) /** * transmit_done - transmit done processing - * @dev: Network device. + * @hw_priv: Network device. * * This routine is called when the transmit interrupt is triggered, indicating * either a packet is sent successfully or there are transmit errors. @@ -4882,6 +4889,7 @@ static netdev_tx_t netdev_tx(struct sk_buff *skb, struct net_device *dev) /** * netdev_tx_timeout - transmit timeout processing * @dev: Network device. + * @txqueue: index of hanging queue * * This routine is called when the transmit timer expires. That indicates the * hardware is not running correctly because transmit interrupts are not @@ -6076,14 +6084,6 @@ static void netdev_get_drvinfo(struct net_device *dev, sizeof(info->bus_info)); } -/** - * netdev_get_regs_len - get length of register dump - * @dev: Network device. - * - * This function returns the length of the register dump. - * - * Return length of the register dump. - */ static struct hw_regs { int start; int end; @@ -6097,6 +6097,14 @@ static struct hw_regs { { 0, 0 } }; +/** + * netdev_get_regs_len - get length of register dump + * @dev: Network device. + * + * This function returns the length of the register dump. + * + * Return length of the register dump. + */ static int netdev_get_regs_len(struct net_device *dev) { struct hw_regs *range = hw_regs_range; @@ -6238,6 +6246,8 @@ static int netdev_get_eeprom_len(struct net_device *dev) return EEPROM_SIZE * 2; } +#define EEPROM_MAGIC 0x10A18842 + /** * netdev_get_eeprom - get EEPROM data * @dev: Network device. @@ -6248,8 +6258,6 @@ static int netdev_get_eeprom_len(struct net_device *dev) * * Return 0 if successful; otherwise an error code. */ -#define EEPROM_MAGIC 0x10A18842 - static int netdev_get_eeprom(struct net_device *dev, struct ethtool_eeprom *eeprom, u8 *data) { @@ -6386,7 +6394,7 @@ static int netdev_set_pauseparam(struct net_device *dev, /** * netdev_get_ringparam - get tx/rx ring parameters * @dev: Network device. - * @pause: Ethtool RING settings data structure. + * @ring: Ethtool RING settings data structure. * * This procedure returns the TX/RX ring settings. */ @@ -6690,7 +6698,7 @@ static void mib_monitor(struct timer_list *t) /** * dev_monitor - periodic monitoring - * @ptr: Network device pointer. + * @t: timer list containing a network device pointer. * * This routine is run in a kernel timer to monitor the network device. */ diff --git a/drivers/net/ethernet/microchip/encx24j600-regmap.c b/drivers/net/ethernet/microchip/encx24j600-regmap.c index 5bd7fb917b7a..796e46a53926 100644 --- a/drivers/net/ethernet/microchip/encx24j600-regmap.c +++ b/drivers/net/ethernet/microchip/encx24j600-regmap.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/** +/* * Register map access API - ENCX24J600 support * * Copyright 2015 Gridpoint diff --git a/drivers/net/ethernet/natsemi/ns83820.c b/drivers/net/ethernet/natsemi/ns83820.c index 8e24c7acf79b..1460d790240b 100644 --- a/drivers/net/ethernet/natsemi/ns83820.c +++ b/drivers/net/ethernet/natsemi/ns83820.c @@ -600,12 +600,14 @@ static void phy_intr(struct net_device *ndev) struct ns83820 *dev = PRIV(ndev); static const char *speeds[] = { "10", "100", "1000", "1000(?)", "1000F" }; u32 cfg, new_cfg; - u32 tbisr, tanar, tanlpar; + u32 tanar, tanlpar; int speed, fullduplex, newlinkstate; cfg = readl(dev->base + CFG) ^ SPDSTS_POLARITY; if (dev->CFG_cache & CFG_TBI_EN) { + u32 __maybe_unused tbisr; + /* we have an optical transceiver */ tbisr = readl(dev->base + TBISR); tanar = readl(dev->base + TANAR); @@ -1207,7 +1209,7 @@ static int ns83820_get_link_ksettings(struct net_device *ndev, struct ethtool_link_ksettings *cmd) { struct ns83820 *dev = PRIV(ndev); - u32 cfg, tanar, tbicr; + u32 cfg, __maybe_unused tanar, tbicr; int fullduplex = 0; u32 supported; diff --git a/drivers/net/ethernet/neterion/s2io.c b/drivers/net/ethernet/neterion/s2io.c index bc94970bea45..d13d92bf7447 100644 --- a/drivers/net/ethernet/neterion/s2io.c +++ b/drivers/net/ethernet/neterion/s2io.c @@ -1000,7 +1000,7 @@ static void free_shared_mem(struct s2io_nic *nic) } } -/** +/* * s2io_verify_pci_mode - */ @@ -1035,7 +1035,7 @@ static int s2io_on_nec_bridge(struct pci_dev *s2io_pdev) } static int bus_speed[8] = {33, 133, 133, 200, 266, 133, 200, 266}; -/** +/* * s2io_print_pci_mode - */ static int s2io_print_pci_mode(struct s2io_nic *nic) @@ -2064,6 +2064,9 @@ static void en_dis_able_nic_intrs(struct s2io_nic *nic, u16 mask, int flag) /** * verify_pcc_quiescent- Checks for PCC quiescent state + * @sp : private member of the device structure, which is a pointer to the + * s2io_nic structure. + * @flag: boolean controlling function path * Return: 1 If PCC is quiescence * 0 If PCC is not quiescence */ @@ -2099,6 +2102,8 @@ static int verify_pcc_quiescent(struct s2io_nic *sp, int flag) } /** * verify_xena_quiescence - Checks whether the H/W is ready + * @sp : private member of the device structure, which is a pointer to the + * s2io_nic structure. * Description: Returns whether the H/W is ready to go or not. Depending * on whether adapter enable bit was written or not the comparison * differs and the calling function passes the input argument flag to @@ -2305,6 +2310,9 @@ static int start_nic(struct s2io_nic *nic) } /** * s2io_txdl_getskb - Get the skb from txdl, unmap and return skb + * @fifo_data: fifo data pointer + * @txdlp: descriptor + * @get_off: unused */ static struct sk_buff *s2io_txdl_getskb(struct fifo_info *fifo_data, struct TxD *txdlp, int get_off) @@ -2391,7 +2399,7 @@ static void free_tx_buffers(struct s2io_nic *nic) /** * stop_nic - To stop the nic - * @nic ; device private variable. + * @nic : device private variable. * Description: * This function does exactly the opposite of what the start_nic() * function does. This function is called to stop the device. @@ -2419,7 +2427,8 @@ static void stop_nic(struct s2io_nic *nic) /** * fill_rx_buffers - Allocates the Rx side skbs - * @ring_info: per ring structure + * @nic : device private variable. + * @ring: per ring structure * @from_card_up: If this is true, we will map the buffer to get * the dma address for buf0 and buf1 to give it to the card. * Else we will sync the already mapped buffer to give it to the card. @@ -2864,7 +2873,7 @@ static void s2io_netpoll(struct net_device *dev) /** * rx_intr_handler - Rx interrupt handler - * @ring_info: per ring structure. + * @ring_data: per ring structure. * @budget: budget for napi processing. * Description: * If the interrupt is because of a received frame or if the @@ -2972,7 +2981,7 @@ static int rx_intr_handler(struct ring_info *ring_data, int budget) /** * tx_intr_handler - Transmit interrupt handler - * @nic : device private variable + * @fifo_data : fifo data pointer * Description: * If an interrupt was raised to indicate DMA complete of the * Tx packet, this function is called. It identifies the last TxD @@ -3153,6 +3162,8 @@ static u64 s2io_mdio_read(u32 mmd_type, u64 addr, struct net_device *dev) /** * s2io_chk_xpak_counter - Function to check the status of the xpak counters * @counter : counter value to be updated + * @regs_stat : registers status + * @index : index * @flag : flag to indicate the status * @type : counter type * Description: @@ -3309,8 +3320,9 @@ static void s2io_updt_xpak_counter(struct net_device *dev) /** * wait_for_cmd_complete - waits for a command to complete. - * @sp : private member of the device structure, which is a pointer to the - * s2io_nic structure. + * @addr: address + * @busy_bit: bit to check for busy + * @bit_state: state to check * Description: Function that waits for a command to Write into RMAC * ADDR DATA registers to be completed and returns either success or * error depending on whether the command was complete or not. @@ -4335,7 +4347,7 @@ static int do_s2io_chk_alarm_bit(u64 value, void __iomem *addr, /** * s2io_handle_errors - Xframe error indication handler - * @nic: device private variable + * @dev_id: opaque handle to dev * Description: Handle alarms such as loss of link, single or * double ECC errors, critical and serious errors. * Return Value: @@ -4739,7 +4751,7 @@ static irqreturn_t s2io_isr(int irq, void *dev_id) return IRQ_HANDLED; } -/** +/* * s2io_updt_stats - */ static void s2io_updt_stats(struct s2io_nic *sp) @@ -5168,7 +5180,7 @@ static u64 do_s2io_read_unicast_mc(struct s2io_nic *sp, int offset) return tmp64 >> 16; } -/** +/* * s2io_set_mac_addr - driver entry point */ @@ -5243,8 +5255,7 @@ static int do_s2io_prog_unicast(struct net_device *dev, u8 *addr) /** * s2io_ethtool_set_link_ksettings - Sets different link parameters. - * @sp : private member of the device structure, which is a pointer to the - * s2io_nic structure. + * @dev : pointer to netdev * @cmd: pointer to the structure with parameters given by ethtool to set * link information. * Description: @@ -5273,8 +5284,7 @@ s2io_ethtool_set_link_ksettings(struct net_device *dev, /** * s2io_ethtol_get_link_ksettings - Return link specific information. - * @sp : private member of the device structure, pointer to the - * s2io_nic structure. + * @dev: pointer to netdev * @cmd : pointer to the structure with parameters given by ethtool * to return link information. * Description: @@ -5313,8 +5323,7 @@ s2io_ethtool_get_link_ksettings(struct net_device *dev, /** * s2io_ethtool_gdrvinfo - Returns driver specific information. - * @sp : private member of the device structure, which is a pointer to the - * s2io_nic structure. + * @dev: pointer to netdev * @info : pointer to the structure with parameters given by ethtool to * return driver information. * Description: @@ -5335,11 +5344,10 @@ static void s2io_ethtool_gdrvinfo(struct net_device *dev, /** * s2io_ethtool_gregs - dumps the entire space of Xfame into the buffer. - * @sp: private member of the device structure, which is a pointer to the - * s2io_nic structure. + * @dev: pointer to netdev * @regs : pointer to the structure with parameters given by ethtool for - * dumping the registers. - * @reg_space: The input argument into which all the registers are dumped. + * dumping the registers. + * @space: The input argument into which all the registers are dumped. * Description: * Dumps the entire register space of xFrame NIC into the user given * buffer area. @@ -5471,8 +5479,7 @@ static void s2io_ethtool_gringparam(struct net_device *dev, /** * s2io_ethtool_getpause_data -Pause frame frame generation and reception. - * @sp : private member of the device structure, which is a pointer to the - * s2io_nic structure. + * @dev: pointer to netdev * @ep : pointer to the structure with pause parameters given by ethtool. * Description: * Returns the Pause frame generation and reception capability of the NIC. @@ -5496,8 +5503,7 @@ static void s2io_ethtool_getpause_data(struct net_device *dev, /** * s2io_ethtool_setpause_data - set/reset pause frame generation. - * @sp : private member of the device structure, which is a pointer to the - * s2io_nic structure. + * @dev: pointer to netdev * @ep : pointer to the structure with pause parameters given by ethtool. * Description: * It can be used to set or reset Pause frame generation or reception @@ -5526,6 +5532,7 @@ static int s2io_ethtool_setpause_data(struct net_device *dev, return 0; } +#define S2IO_DEV_ID 5 /** * read_eeprom - reads 4 bytes of data from user given offset. * @sp : private member of the device structure, which is a pointer to the @@ -5541,8 +5548,6 @@ static int s2io_ethtool_setpause_data(struct net_device *dev, * Return value: * -1 on failure and 0 on success. */ - -#define S2IO_DEV_ID 5 static int read_eeprom(struct s2io_nic *sp, int off, u64 *data) { int ret = -1; @@ -5734,8 +5739,7 @@ static void s2io_vpd_read(struct s2io_nic *nic) /** * s2io_ethtool_geeprom - reads the value stored in the Eeprom. - * @sp : private member of the device structure, which is a pointer to the - * s2io_nic structure. + * @dev: pointer to netdev * @eeprom : pointer to the user level structure provided by ethtool, * containing all relevant information. * @data_buf : user defined value to be written into Eeprom. @@ -5771,11 +5775,10 @@ static int s2io_ethtool_geeprom(struct net_device *dev, /** * s2io_ethtool_seeprom - tries to write the user provided value in Eeprom - * @sp : private member of the device structure, which is a pointer to the - * s2io_nic structure. + * @dev: pointer to netdev * @eeprom : pointer to the user level structure provided by ethtool, * containing all relevant information. - * @data_buf ; user defined value to be written into Eeprom. + * @data_buf : user defined value to be written into Eeprom. * Description: * Tries to write the user provided value in the Eeprom, at the offset * given by the user. @@ -6027,7 +6030,7 @@ static int s2io_bist_test(struct s2io_nic *sp, uint64_t *data) /** * s2io_link_test - verifies the link state of the nic - * @sp ; private member of the device structure, which is a pointer to the + * @sp: private member of the device structure, which is a pointer to the * s2io_nic structure. * @data: variable that returns the result of each of the test conducted by * the driver. @@ -6150,8 +6153,7 @@ static int s2io_rldram_test(struct s2io_nic *sp, uint64_t *data) /** * s2io_ethtool_test - conducts 6 tsets to determine the health of card. - * @sp : private member of the device structure, which is a pointer to the - * s2io_nic structure. + * @dev: pointer to netdev * @ethtest : pointer to a ethtool command specific structure that will be * returned to the user. * @data : variable that returns the result of each of the test @@ -6597,7 +6599,7 @@ static const struct ethtool_ops netdev_ethtool_ops = { /** * s2io_ioctl - Entry point for the Ioctl * @dev : Device pointer. - * @ifr : An IOCTL specefic structure, that can contain a pointer to + * @rq : An IOCTL specefic structure, that can contain a pointer to * a proprietary structure used to pass information to the driver. * @cmd : This is used to distinguish between the different commands that * can be passed to the IOCTL functions. @@ -6650,7 +6652,7 @@ static int s2io_change_mtu(struct net_device *dev, int new_mtu) /** * s2io_set_link - Set the LInk status - * @data: long pointer to device private structue + * @work: work struct containing a pointer to device private structue * Description: Sets the link status for the adapter */ @@ -7187,7 +7189,7 @@ static int s2io_card_up(struct s2io_nic *sp) /** * s2io_restart_nic - Resets the NIC. - * @data : long pointer to the device private structure + * @work : work struct containing a pointer to the device private structure * Description: * This function is scheduled to be run by the s2io_tx_watchdog * function after 0.5 secs to reset the NIC. The idea is to reduce @@ -7218,6 +7220,7 @@ static void s2io_restart_nic(struct work_struct *work) /** * s2io_tx_watchdog - Watchdog for transmit side. * @dev : Pointer to net device structure + * @txqueue: index of the hanging queue * Description: * This function is triggered if the Tx Queue is stopped * for a pre-defined amount of time when the Interface is still up. @@ -7242,11 +7245,8 @@ static void s2io_tx_watchdog(struct net_device *dev, unsigned int txqueue) /** * rx_osm_handler - To perform some OS related operations on SKB. - * @sp: private member of the device structure,pointer to s2io_nic structure. - * @skb : the socket buffer pointer. - * @len : length of the packet - * @cksum : FCS checksum of the frame. - * @ring_no : the ring from which this RxD was extracted. + * @ring_data : the ring from which this RxD was extracted. + * @rxdp: descriptor * Description: * This function is called by the Rx interrupt serivce routine to perform * some OS related operations on the SKB before passing it to the upper @@ -7576,9 +7576,10 @@ static int s2io_verify_parm(struct pci_dev *pdev, u8 *dev_intr_type, } /** - * rts_ds_steer - Receive traffic steering based on IPv4 or IPv6 TOS - * or Traffic class respectively. + * rts_ds_steer - Receive traffic steering based on IPv4 or IPv6 TOS or Traffic class respectively. * @nic: device private variable + * @ds_codepoint: data + * @ring: ring index * Description: The function configures the receive steering to * desired receive ring. * Return Value: SUCCESS on success and diff --git a/drivers/net/ethernet/neterion/vxge/vxge-config.c b/drivers/net/ethernet/neterion/vxge/vxge-config.c index 78eba10300ae..6aba267036dd 100644 --- a/drivers/net/ethernet/neterion/vxge/vxge-config.c +++ b/drivers/net/ethernet/neterion/vxge/vxge-config.c @@ -988,6 +988,9 @@ __vxge_hw_vpath_addr_get(struct __vxge_hw_virtualpath *vpath, /** * vxge_hw_device_hw_info_get - Get the hw information + * @bar0: the bar + * @hw_info: the hw_info struct + * * Returns the vpath mask that has the bits set for each vpath allocated * for the driver, FW version information, and the first mac address for * each vpath @@ -3926,7 +3929,7 @@ enum vxge_hw_status vxge_hw_vpath_rts_rth_itable_set( /** * vxge_hw_vpath_check_leak - Check for memory leak - * @ringh: Handle to the ring object used for receive + * @ring: Handle to the ring object used for receive * * If PRC_RXD_DOORBELL_VPn.NEW_QW_CNT is larger or equal to * PRC_CFG6_VPn.RXD_SPAT then a leak has occurred. diff --git a/drivers/net/ethernet/neterion/vxge/vxge-ethtool.c b/drivers/net/ethernet/neterion/vxge/vxge-ethtool.c index 03c3d1230c17..4d91026485ae 100644 --- a/drivers/net/ethernet/neterion/vxge/vxge-ethtool.c +++ b/drivers/net/ethernet/neterion/vxge/vxge-ethtool.c @@ -119,7 +119,7 @@ static void vxge_ethtool_gdrvinfo(struct net_device *dev, * @dev: device pointer. * @regs: pointer to the structure with parameters given by ethtool for * dumping the registers. - * @reg_space: The input argument into which all the registers are dumped. + * @space: The input argument into which all the registers are dumped. * * Dumps the vpath register space of Titan NIC into the user given * buffer area. diff --git a/drivers/net/ethernet/neterion/vxge/vxge-main.c b/drivers/net/ethernet/neterion/vxge/vxge-main.c index 7afdb3bc631c..87892bd992b1 100644 --- a/drivers/net/ethernet/neterion/vxge/vxge-main.c +++ b/drivers/net/ethernet/neterion/vxge/vxge-main.c @@ -1275,6 +1275,7 @@ static void vxge_set_multicast(struct net_device *dev) /** * vxge_set_mac_addr * @dev: pointer to the device structure + * @p: socket info * * Update entry "0" (default MAC addr) */ @@ -1799,7 +1800,7 @@ static void vxge_reset(struct work_struct *work) /** * vxge_poll - Receive handler when Receive Polling is used. - * @dev: pointer to the device structure. + * @napi: pointer to the napi structure. * @budget: Number of packets budgeted to be processed in this iteration. * * This function comes into picture only if Receive side is being handled @@ -3096,7 +3097,7 @@ static int vxge_change_mtu(struct net_device *dev, int new_mtu) /** * vxge_get_stats64 * @dev: pointer to the device structure - * @stats: pointer to struct rtnl_link_stats64 + * @net_stats: pointer to struct rtnl_link_stats64 * */ static void @@ -3245,7 +3246,7 @@ static int vxge_hwtstamp_get(struct vxgedev *vdev, void __user *data) /** * vxge_ioctl * @dev: Device pointer. - * @ifr: An IOCTL specific structure, that can contain a pointer to + * @rq: An IOCTL specific structure, that can contain a pointer to * a proprietary structure used to pass information to the driver. * @cmd: This is used to distinguish between the different commands that * can be passed to the IOCTL functions. @@ -3269,6 +3270,7 @@ static int vxge_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) /** * vxge_tx_watchdog * @dev: pointer to net device structure + * @txqueue: index of the hanging queue * * Watchdog for transmit side. * This function is triggered if the Tx Queue is stopped @@ -4002,6 +4004,7 @@ static void vxge_print_parm(struct vxgedev *vdev, u64 vpath_mask) /** * vxge_pm_suspend - vxge power management suspend entry point + * @dev_d: device pointer * */ static int __maybe_unused vxge_pm_suspend(struct device *dev_d) @@ -4010,6 +4013,7 @@ static int __maybe_unused vxge_pm_suspend(struct device *dev_d) } /** * vxge_pm_resume - vxge power management resume entry point + * @dev_d: device pointer * */ static int __maybe_unused vxge_pm_resume(struct device *dev_d) diff --git a/drivers/net/ethernet/neterion/vxge/vxge-traffic.c b/drivers/net/ethernet/neterion/vxge/vxge-traffic.c index bd525e8eda10..ee164970b267 100644 --- a/drivers/net/ethernet/neterion/vxge/vxge-traffic.c +++ b/drivers/net/ethernet/neterion/vxge/vxge-traffic.c @@ -278,7 +278,7 @@ void vxge_hw_vpath_dynamic_rti_rtimer_set(struct __vxge_hw_ring *ring) /** * vxge_hw_channel_msix_mask - Mask MSIX Vector. - * @channeh: Channel for rx or tx handle + * @channel: Channel for rx or tx handle * @msix_id: MSIX ID * * The function masks the msix interrupt for the given msix_id @@ -295,7 +295,7 @@ void vxge_hw_channel_msix_mask(struct __vxge_hw_channel *channel, int msix_id) /** * vxge_hw_channel_msix_unmask - Unmask the MSIX Vector. - * @channeh: Channel for rx or tx handle + * @channel: Channel for rx or tx handle * @msix_id: MSI ID * * The function unmasks the msix interrupt for the given msix_id @@ -350,8 +350,6 @@ u32 vxge_hw_device_set_intr_type(struct __vxge_hw_device *hldev, u32 intr_mode) /** * vxge_hw_device_intr_enable - Enable interrupts. * @hldev: HW device handle. - * @op: One of the enum vxge_hw_device_intr enumerated values specifying - * the type(s) of interrupts to enable. * * Enable Titan interrupts. The function is to be executed the last in * Titan initialization sequence. @@ -405,8 +403,6 @@ void vxge_hw_device_intr_enable(struct __vxge_hw_device *hldev) /** * vxge_hw_device_intr_disable - Disable Titan interrupts. * @hldev: HW device handle. - * @op: One of the enum vxge_hw_device_intr enumerated values specifying - * the type(s) of interrupts to disable. * * Disable Titan interrupts. * @@ -1406,7 +1402,7 @@ u32 vxge_hw_fifo_free_txdl_count_get(struct __vxge_hw_fifo *fifoh) /** * vxge_hw_fifo_txdl_reserve - Reserve fifo descriptor. - * @fifoh: Handle to the fifo object used for non offload send + * @fifo: Handle to the fifo object used for non offload send * @txdlh: Reserved descriptor. On success HW fills this "out" parameter * with a valid handle. * @txdl_priv: Buffer to return the pointer to per txdl space @@ -1517,8 +1513,6 @@ void vxge_hw_fifo_txdl_buffer_set(struct __vxge_hw_fifo *fifo, * vxge_hw_fifo_txdl_post - Post descriptor on the fifo channel. * @fifo: Handle to the fifo object used for non offload send * @txdlh: Descriptor obtained via vxge_hw_fifo_txdl_reserve() - * @frags: Number of contiguous buffers that are part of a single - * transmit operation. * * Post descriptor on the 'fifo' type channel for transmission. * Prior to posting the descriptor should be filled in accordance with @@ -1691,8 +1685,7 @@ void vxge_hw_fifo_txdl_free(struct __vxge_hw_fifo *fifo, void *txdlh) } /** - * vxge_hw_vpath_mac_addr_add - Add the mac address entry for this vpath - * to MAC address table. + * vxge_hw_vpath_mac_addr_add - Add the mac address entry for this vpath to MAC address table. * @vp: Vpath handle. * @macaddr: MAC address to be added for this vpath into the list * @macaddr_mask: MAC address mask for macaddr @@ -1757,13 +1750,13 @@ vxge_hw_vpath_mac_addr_add( } /** - * vxge_hw_vpath_mac_addr_get - Get the first mac address entry for this vpath - * from MAC address table. + * vxge_hw_vpath_mac_addr_get - Get the first mac address entry * @vp: Vpath handle. * @macaddr: First MAC address entry for this vpath in the list * @macaddr_mask: MAC address mask for macaddr * - * Returns the first mac address and mac address mask in the list for this + * Get the first mac address entry for this vpath from MAC address table. + * Return: the first mac address and mac address mask in the list for this * vpath. * see also: vxge_hw_vpath_mac_addr_get_next * @@ -1808,14 +1801,13 @@ vxge_hw_vpath_mac_addr_get( } /** - * vxge_hw_vpath_mac_addr_get_next - Get the next mac address entry for this - * vpath - * from MAC address table. + * vxge_hw_vpath_mac_addr_get_next - Get the next mac address entry * @vp: Vpath handle. * @macaddr: Next MAC address entry for this vpath in the list * @macaddr_mask: MAC address mask for macaddr * - * Returns the next mac address and mac address mask in the list for this + * Get the next mac address entry for this vpath from MAC address table. + * Return: the next mac address and mac address mask in the list for this * vpath. * see also: vxge_hw_vpath_mac_addr_get * @@ -1861,8 +1853,7 @@ vxge_hw_vpath_mac_addr_get_next( } /** - * vxge_hw_vpath_mac_addr_delete - Delete the mac address entry for this vpath - * to MAC address table. + * vxge_hw_vpath_mac_addr_delete - Delete the mac address entry for this vpath to MAC address table. * @vp: Vpath handle. * @macaddr: MAC address to be added for this vpath into the list * @macaddr_mask: MAC address mask for macaddr @@ -1908,8 +1899,7 @@ vxge_hw_vpath_mac_addr_delete( } /** - * vxge_hw_vpath_vid_add - Add the vlan id entry for this vpath - * to vlan id table. + * vxge_hw_vpath_vid_add - Add the vlan id entry for this vpath to vlan id table. * @vp: Vpath handle. * @vid: vlan id to be added for this vpath into the list * @@ -2403,9 +2393,11 @@ enum vxge_hw_status vxge_hw_vpath_poll_rx(struct __vxge_hw_ring *ring) } /** - * vxge_hw_vpath_poll_tx - Poll Tx for completed descriptors and process - * the same. + * vxge_hw_vpath_poll_tx - Poll Tx for completed descriptors and process the same. * @fifo: Handle to the fifo object used for non offload send + * @skb_ptr: pointer to skb + * @nr_skb: number of skbs + * @more: more is coming * * The function polls the Tx for the completed descriptors and calls * the driver via supplied completion callback. diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c index b36aa5bf3c5f..a58f14aca10c 100644 --- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c +++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c @@ -8,7 +8,7 @@ #include "pch_gbe.h" #include "pch_gbe_phy.h" -/** +/* * pch_gbe_stats - Stats item information */ struct pch_gbe_stats { @@ -24,7 +24,7 @@ struct pch_gbe_stats { .offset = offsetof(struct pch_gbe_hw_stats, m), \ } -/** +/* * pch_gbe_gstrings_stats - ethtool information status name list */ static const struct pch_gbe_stats pch_gbe_gstrings_stats[] = { diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c index 23f7c76737c9..ade8c44c01cd 100644 --- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c +++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c @@ -295,7 +295,7 @@ static s32 pch_gbe_mac_read_mac_addr(struct pch_gbe_hw *hw) /** * pch_gbe_wait_clr_bit - Wait to clear a bit * @reg: Pointer of register - * @busy: Busy bit + * @bit: Busy bit */ static void pch_gbe_wait_clr_bit(void *reg, u32 bit) { @@ -1034,7 +1034,7 @@ static void pch_gbe_set_mode(struct pch_gbe_adapter *adapter, u16 speed, /** * pch_gbe_watchdog - Watchdog process - * @data: Board private structure + * @t: timer list containing a Board private structure */ static void pch_gbe_watchdog(struct timer_list *t) { @@ -2270,6 +2270,7 @@ static int pch_gbe_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd) /** * pch_gbe_tx_timeout - Respond to a Tx Hang * @netdev: Network interface device structure + * @txqueue: index of hanging queue */ static void pch_gbe_tx_timeout(struct net_device *netdev, unsigned int txqueue) { diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_param.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_param.c index dceec80fd642..81fc5a6e3221 100644 --- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_param.c +++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_param.c @@ -13,7 +13,7 @@ #define OPTION_DISABLED 0 #define OPTION_ENABLED 1 -/** +/* * TxDescriptors - Transmit Descriptor Count * @Valid Range: PCH_GBE_MIN_TXD - PCH_GBE_MAX_TXD * @Default Value: PCH_GBE_DEFAULT_TXD @@ -22,7 +22,7 @@ static int TxDescriptors = OPTION_UNSET; module_param(TxDescriptors, int, 0); MODULE_PARM_DESC(TxDescriptors, "Number of transmit descriptors"); -/** +/* * RxDescriptors -Receive Descriptor Count * @Valid Range: PCH_GBE_MIN_RXD - PCH_GBE_MAX_RXD * @Default Value: PCH_GBE_DEFAULT_RXD @@ -31,7 +31,7 @@ static int RxDescriptors = OPTION_UNSET; module_param(RxDescriptors, int, 0); MODULE_PARM_DESC(RxDescriptors, "Number of receive descriptors"); -/** +/* * Speed - User Specified Speed Override * @Valid Range: 0, 10, 100, 1000 * - 0: auto-negotiate at all supported speeds @@ -44,7 +44,7 @@ static int Speed = OPTION_UNSET; module_param(Speed, int, 0); MODULE_PARM_DESC(Speed, "Speed setting"); -/** +/* * Duplex - User Specified Duplex Override * @Valid Range: 0-2 * - 0: auto-negotiate for duplex @@ -59,7 +59,7 @@ MODULE_PARM_DESC(Duplex, "Duplex setting"); #define HALF_DUPLEX 1 #define FULL_DUPLEX 2 -/** +/* * AutoNeg - Auto-negotiation Advertisement Override * @Valid Range: 0x01-0x0F, 0x20-0x2F * @@ -85,7 +85,7 @@ MODULE_PARM_DESC(AutoNeg, "Advertised auto-negotiation setting"); #define PHY_ADVERTISE_1000_FULL 0x0020 #define PCH_AUTONEG_ADVERTISE_DEFAULT 0x2F -/** +/* * FlowControl - User Specified Flow Control Override * @Valid Range: 0-3 * - 0: No Flow Control @@ -124,7 +124,7 @@ MODULE_PARM_DESC(XsumTX, "Disable or enable Transmit Checksum offload"); #define PCH_GBE_DEFAULT_TX_CSUM true /* trueorfalse */ -/** +/* * pch_gbe_option - Force the MAC's flow control settings * @hw: Pointer to the HW structure * Returns: diff --git a/drivers/net/ethernet/packetengines/yellowfin.c b/drivers/net/ethernet/packetengines/yellowfin.c index 3da075307178..d1dd9bc1bc7f 100644 --- a/drivers/net/ethernet/packetengines/yellowfin.c +++ b/drivers/net/ethernet/packetengines/yellowfin.c @@ -1060,7 +1060,7 @@ static int yellowfin_rx(struct net_device *dev) struct sk_buff *rx_skb = yp->rx_skbuff[entry]; s16 frame_status; u16 desc_status; - int data_size, yf_size; + int data_size, __maybe_unused yf_size; u8 *buf_addr; if(!desc->result_status) diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic.h b/drivers/net/ethernet/qlogic/netxen/netxen_nic.h index 86153660d245..e5c51256243a 100644 --- a/drivers/net/ethernet/qlogic/netxen/netxen_nic.h +++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic.h @@ -1189,9 +1189,6 @@ typedef struct { #define NX_FORCE_FW_RESET 0xdeaddead -/* Fw dump levels */ -static const u32 FW_DUMP_LEVELS[] = { 0x3, 0x7, 0xf, 0x1f, 0x3f, 0x7f, 0xff }; - /* Flash read/write address */ #define NX_FW_DUMP_REG1 0x00130060 #define NX_FW_DUMP_REG2 0x001e0000 diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c index c3f50ddbe824..dd22cb056d03 100644 --- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c +++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c @@ -814,6 +814,9 @@ netxen_get_dump_flag(struct net_device *netdev, struct ethtool_dump *dump) return 0; } +/* Fw dump levels */ +static const u32 FW_DUMP_LEVELS[] = { 0x3, 0x7, 0xf, 0x1f, 0x3f, 0x7f, 0xff }; + static int netxen_set_dump(struct net_device *netdev, struct ethtool_dump *val) { diff --git a/drivers/net/ethernet/qualcomm/emac/emac.c b/drivers/net/ethernet/qualcomm/emac/emac.c index 1166b98d8bb2..8543bf3c3484 100644 --- a/drivers/net/ethernet/qualcomm/emac/emac.c +++ b/drivers/net/ethernet/qualcomm/emac/emac.c @@ -292,6 +292,7 @@ static void emac_tx_timeout(struct net_device *netdev, unsigned int txqueue) /** * emac_update_hw_stats - read the EMAC stat registers + * @adpt: pointer to adapter struct * * Reads the stats registers and write the values to adpt->stats. * diff --git a/drivers/net/ethernet/realtek/8139cp.c b/drivers/net/ethernet/realtek/8139cp.c index e291e6ac40cb..2f2567341710 100644 --- a/drivers/net/ethernet/realtek/8139cp.c +++ b/drivers/net/ethernet/realtek/8139cp.c @@ -1261,6 +1261,8 @@ static void cp_tx_timeout(struct net_device *dev, unsigned int txqueue) cp_stop_hw(cp); cp_clean_rings(cp); rc = cp_init_rings(cp); + if (rc) + netif_dbg(cp, tx_err, cp->dev, "Init rings failed: %d\n", rc); cp_start_hw(cp); __cp_set_rx_mode(dev); cpw16_f(IntrMask, cp_norx_intr_mask); diff --git a/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c b/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c index 2cc8184b7e6b..971f1e54b652 100644 --- a/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c +++ b/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c @@ -97,7 +97,7 @@ void sxgbe_disable_eee_mode(struct sxgbe_priv_data * const priv) /** * sxgbe_eee_ctrl_timer - * @arg : data hook + * @t: timer list containing a data * Description: * If there is no data transfer and if we are not in LPI state, * then MAC Transmitter can be moved to LPI state. @@ -255,7 +255,7 @@ static void sxgbe_adjust_link(struct net_device *dev) /** * sxgbe_init_phy - PHY initialization - * @dev: net device structure + * @ndev: net device structure * Description: it initializes the driver's PHY state, and attaches the PHY * to the mac driver. * Return value: @@ -364,8 +364,11 @@ static int sxgbe_init_rx_buffers(struct net_device *dev, /** * sxgbe_free_rx_buffers - free what sxgbe_init_rx_buffers() allocated * @dev: net device structure + * @p: dec pointer + * @i: index + * @dma_buf_sz: size * @rx_ring: ring to be freed - * @rx_rsize: ring size + * * Description: this function initializes the DMA RX descriptor */ static void sxgbe_free_rx_buffers(struct net_device *dev, @@ -383,6 +386,7 @@ static void sxgbe_free_rx_buffers(struct net_device *dev, /** * init_tx_ring - init the TX descriptor ring * @dev: net device structure + * @queue_no: queue * @tx_ring: ring to be initialised * @tx_rsize: ring size * Description: this function initializes the DMA TX descriptor @@ -449,6 +453,7 @@ static void free_rx_ring(struct device *dev, struct sxgbe_rx_queue *rx_ring, /** * init_rx_ring - init the RX descriptor ring * @dev: net device structure + * @queue_no: queue * @rx_ring: ring to be initialised * @rx_rsize: ring size * Description: this function initializes the DMA RX descriptor @@ -548,7 +553,7 @@ static void free_tx_ring(struct device *dev, struct sxgbe_tx_queue *tx_ring, /** * init_dma_desc_rings - init the RX/TX descriptor rings - * @dev: net device structure + * @netd: net device structure * Description: this function initializes the DMA RX/TX descriptors * and allocates the socket buffers. It suppors the chained and ring * modes. @@ -724,7 +729,7 @@ static void sxgbe_mtl_operation_mode(struct sxgbe_priv_data *priv) /** * sxgbe_tx_queue_clean: - * @priv: driver private structure + * @tqueue: queue pointer * Description: it reclaims resources after transmission completes. */ static void sxgbe_tx_queue_clean(struct sxgbe_tx_queue *tqueue) @@ -807,6 +812,7 @@ static void sxgbe_tx_all_clean(struct sxgbe_priv_data * const priv) /** * sxgbe_restart_tx_queue: irq tx error mng function * @priv: driver private structure + * @queue_num: queue number * Description: it cleans the descriptors and restarts the transmission * in case of errors. */ @@ -1567,6 +1573,7 @@ static int sxgbe_poll(struct napi_struct *napi, int budget) /** * sxgbe_tx_timeout * @dev : Pointer to net device structure + * @txqueue: index of the hanging queue * Description: this function is called when a packet transmission fails to * complete within a reasonable time. The driver will mark the error in the * netdev structure and arrange for the device to be reset to a sane state diff --git a/drivers/net/ethernet/sfc/falcon/rx.c b/drivers/net/ethernet/sfc/falcon/rx.c index 05ea3523890a..966f13e7475d 100644 --- a/drivers/net/ethernet/sfc/falcon/rx.c +++ b/drivers/net/ethernet/sfc/falcon/rx.c @@ -140,6 +140,7 @@ static struct page *ef4_reuse_page(struct ef4_rx_queue *rx_queue) * ef4_init_rx_buffers - create EF4_RX_BATCH page-based RX buffers * * @rx_queue: Efx RX queue + * @atomic: control memory allocation flags * * This allocates a batch of pages, maps them for DMA, and populates * struct ef4_rx_buffers for each one. Return a negative error code or @@ -316,6 +317,7 @@ static void ef4_discard_rx_packet(struct ef4_channel *channel, * This will aim to fill the RX descriptor queue up to * @rx_queue->@max_fill. If there is insufficient atomic * memory to do so, a slow fill will be scheduled. + * @atomic: control memory allocation flags * * The caller must provide serialisation (none is used here). In practise, * this means this function must run from the NAPI handler, or be called diff --git a/drivers/net/ethernet/sfc/falcon/selftest.c b/drivers/net/ethernet/sfc/falcon/selftest.c index 147677c7c72f..6a454ac6f876 100644 --- a/drivers/net/ethernet/sfc/falcon/selftest.c +++ b/drivers/net/ethernet/sfc/falcon/selftest.c @@ -65,7 +65,7 @@ static const char *const ef4_interrupt_mode_names[] = { STRING_TABLE_LOOKUP(efx->interrupt_mode, ef4_interrupt_mode) /** - * ef4_loopback_state - persistent state during a loopback selftest + * struct ef4_loopback_state - persistent state during a loopback selftest * @flush: Drop all packets in ef4_loopback_rx_packet * @packet_count: Number of packets being used in this test * @skbs: An array of skbs transmitted diff --git a/drivers/net/ethernet/sfc/net_driver.h b/drivers/net/ethernet/sfc/net_driver.h index 3fd0b59107d1..f7d1eeb71de0 100644 --- a/drivers/net/ethernet/sfc/net_driver.h +++ b/drivers/net/ethernet/sfc/net_driver.h @@ -453,7 +453,7 @@ enum efx_sync_events_state { * were checked for expiry * @rfs_expire_index: next accelerated RFS filter ID to check for expiry * @n_rfs_succeeded: number of successful accelerated RFS filter insertions - * @n_rfs_failed; number of failed accelerated RFS filter insertions + * @n_rfs_failed: number of failed accelerated RFS filter insertions * @filter_work: Work item for efx_filter_rfs_expire() * @rps_flow_id: Flow IDs of filters allocated for accelerated RFS, * indexed by filter ID diff --git a/drivers/net/ethernet/sfc/ptp.c b/drivers/net/ethernet/sfc/ptp.c index bea4725a4499..00cbd3ac6d99 100644 --- a/drivers/net/ethernet/sfc/ptp.c +++ b/drivers/net/ethernet/sfc/ptp.c @@ -172,9 +172,11 @@ struct efx_ptp_match { /** * struct efx_ptp_event_rx - A PTP receive event (from MC) + * @link: list of events * @seq0: First part of (PTP) UUID * @seq1: Second part of (PTP) UUID and sequence number * @hwtimestamp: Event timestamp + * @expiry: Time which the packet arrived */ struct efx_ptp_event_rx { struct list_head link; @@ -222,11 +224,13 @@ struct efx_ptp_timeset { * reset (disable, enable). * @rxfilter_event: Receive filter when operating * @rxfilter_general: Receive filter when operating + * @rxfilter_installed: Receive filter installed * @config: Current timestamp configuration * @enabled: PTP operation enabled * @mode: Mode in which PTP operating (PTP version) * @ns_to_nic_time: Function to convert from scalar nanoseconds to NIC time * @nic_to_kernel_time: Function to convert from NIC to kernel time + * @nic_time: contains time details * @nic_time.minor_max: Wrap point for NIC minor times * @nic_time.sync_event_diff_min: Minimum acceptable difference between time * in packet prefix and last MCDI time sync event i.e. how much earlier than @@ -238,6 +242,7 @@ struct efx_ptp_timeset { * field in MCDI time sync event. * @min_synchronisation_ns: Minimum acceptable corrected sync window * @capabilities: Capabilities flags from the NIC + * @ts_corrections: contains corrections details * @ts_corrections.ptp_tx: Required driver correction of PTP packet transmit * timestamps * @ts_corrections.ptp_rx: Required driver correction of PTP packet receive @@ -263,6 +268,7 @@ struct efx_ptp_timeset { * @nic_ts_enabled: Flag indicating if NIC generated TS events are handled * @txbuf: Buffer for use when transmitting (PTP) packets to MC (avoids * allocations in main data path). + * @MC_CMD_PTP_IN_TRANSMIT_LENMAX: hack to get W=1 to compile * @good_syncs: Number of successful synchronisations. * @fast_syncs: Number of synchronisations requiring short delay * @bad_syncs: Number of failed synchronisations. diff --git a/drivers/net/ethernet/sis/sis900.c b/drivers/net/ethernet/sis/sis900.c index 869b7618e2ba..620c26f71be8 100644 --- a/drivers/net/ethernet/sis/sis900.c +++ b/drivers/net/ethernet/sis/sis900.c @@ -1301,7 +1301,7 @@ static void sis630_set_eq(struct net_device *net_dev, u8 revision) /** * sis900_timer - sis900 timer routine - * @data: pointer to sis900 net device + * @t: timer list containing a pointer to sis900 net device * * On each timer ticks we check two things, * link status (ON/OFF) and link mode (10/100/Full/Half) @@ -1535,6 +1535,7 @@ static void sis900_read_mode(struct net_device *net_dev, int *speed, int *duplex /** * sis900_tx_timeout - sis900 transmit timeout routine * @net_dev: the net device to transmit + * @txqueue: index of hanging queue * * print transmit timeout status * disable interrupts and do some tasks diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c index 2d5573b3dee1..6ef30252bfe0 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0-or-later /** - * dwmac-rk.c - Rockchip RK3288 DWMAC specific glue layer + * DOC: dwmac-rk.c - Rockchip RK3288 DWMAC specific glue layer * * Copyright (C) 2014 Chen-Zhi (Roger Chen) * diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 3fa24b310d20..505e3e0b8eb5 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -360,7 +360,7 @@ void stmmac_disable_eee_mode(struct stmmac_priv *priv) /** * stmmac_eee_ctrl_timer - EEE TX SW timer. - * @arg : data hook + * @t: timer_list struct containing private info * Description: * if there is no data transfer and if we are not in LPI state, * then MAC Transmitter can be moved to LPI state. @@ -735,7 +735,7 @@ static int stmmac_hwtstamp_set(struct net_device *dev, struct ifreq *ifr) * a proprietary structure used to pass information to the driver. * Description: * This function obtain the current hardware timestamping settings - as requested. + * as requested. */ static int stmmac_hwtstamp_get(struct net_device *dev, struct ifreq *ifr) { @@ -795,6 +795,7 @@ static void stmmac_release_ptp(struct stmmac_priv *priv) /** * stmmac_mac_flow_ctrl - Configure flow control in all queues * @priv: driver private structure + * @duplex: duplex passed to the next function * Description: It is used for configuring the flow control in all queues */ static void stmmac_mac_flow_ctrl(struct stmmac_priv *priv, u32 duplex) @@ -1961,6 +1962,7 @@ static void stmmac_dma_operation_mode(struct stmmac_priv *priv) /** * stmmac_tx_clean - to manage the transmission completion * @priv: driver private structure + * @budget: napi budget limiting this functions packet handling * @queue: TX queue index * Description: it reclaims the transmit resources after transmission completes. */ @@ -2353,7 +2355,7 @@ static void stmmac_tx_timer_arm(struct stmmac_priv *priv, u32 queue) /** * stmmac_tx_timer - mitigation sw timer for tx. - * @data: data pointer + * @t: data pointer * Description: * This is the timer handler to directly invoke the stmmac_tx_clean. */ @@ -2616,6 +2618,7 @@ static void stmmac_safety_feat_configuration(struct stmmac_priv *priv) /** * stmmac_hw_setup - setup mac in a usable state. * @dev : pointer to the device structure. + * @init_ptp: initialize PTP if set * Description: * this is the main function to setup the HW in a usable state because the * dma engine is reset, the core registers are configured (e.g. AXI, @@ -2969,7 +2972,7 @@ static bool stmmac_vlan_insert(struct stmmac_priv *priv, struct sk_buff *skb, * @priv: driver private structure * @des: buffer start address * @total_len: total length to fill in descriptors - * @last_segmant: condition for the last descriptor + * @last_segment: condition for the last descriptor * @queue: TX queue index * Description: * This function fills descriptor and request new descriptors according to @@ -3935,6 +3938,7 @@ static int stmmac_napi_poll_tx(struct napi_struct *napi, int budget) /** * stmmac_tx_timeout * @dev : Pointer to net device structure + * @txqueue: the index of the hanging transmit queue * Description: this function is called when a packet transmission fails to * complete within a reasonable time. The driver will mark the error in the * netdev structure and arrange for the device to be reset to a sane state @@ -5120,7 +5124,7 @@ EXPORT_SYMBOL_GPL(stmmac_suspend); /** * stmmac_reset_queues_param - reset queue parameters - * @dev: device pointer + * @priv: device pointer */ static void stmmac_reset_queues_param(struct stmmac_priv *priv) { diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c index f32317fa75c8..af34a4cadbb0 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c @@ -125,6 +125,7 @@ static struct stmmac_axi *stmmac_axi_setup(struct platform_device *pdev) /** * stmmac_mtl_setup - parse DT parameters for multiple queues configuration * @pdev: platform device + * @plat: enet data */ static int stmmac_mtl_setup(struct platform_device *pdev, struct plat_stmmacenet_data *plat) @@ -360,7 +361,7 @@ static int stmmac_dt_phy(struct plat_stmmacenet_data *plat, /** * stmmac_of_get_mac_mode - retrieves the interface of the MAC - * @np - device-tree node + * @np: - device-tree node * Description: * Similar to `of_get_phy_mode()`, this function will retrieve (from * the device-tree) the interface mode on the MAC side. This assumes diff --git a/drivers/net/ethernet/sun/cassini.c b/drivers/net/ethernet/sun/cassini.c index b624e177ec71..9ff894ba8d3e 100644 --- a/drivers/net/ethernet/sun/cassini.c +++ b/drivers/net/ethernet/sun/cassini.c @@ -454,8 +454,8 @@ static int cas_page_free(struct cas *cp, cas_page_t *page) #define RX_USED_ADD(x, y) ((x)->used += (y)) #define RX_USED_SET(x, y) ((x)->used = (y)) #else -#define RX_USED_ADD(x, y) -#define RX_USED_SET(x, y) +#define RX_USED_ADD(x, y) do { } while(0) +#define RX_USED_SET(x, y) do { } while(0) #endif /* local page allocation routines for the receive buffers. jumbo pages diff --git a/drivers/net/ethernet/tehuti/tehuti.c b/drivers/net/ethernet/tehuti/tehuti.c index e28727297563..036477aff29d 100644 --- a/drivers/net/ethernet/tehuti/tehuti.c +++ b/drivers/net/ethernet/tehuti/tehuti.c @@ -138,7 +138,10 @@ static void print_eth_id(struct net_device *ndev) * @priv: NIC private structure * @f: fifo to initialize * @fsz_type: fifo size type: 0-4KB, 1-8KB, 2-16KB, 3-32KB - * @reg_XXX: offsets of registers relative to base address + * @reg_CFG0: offsets of registers relative to base address + * @reg_CFG1: offsets of registers relative to base address + * @reg_RPTR: offsets of registers relative to base address + * @reg_WPTR: offsets of registers relative to base address * * 1K extra space is allocated at the end of the fifo to simplify * processing of descriptors that wraps around fifo's end @@ -558,7 +561,7 @@ static int bdx_reset(struct bdx_priv *priv) /** * bdx_close - Disables a network interface - * @netdev: network interface device structure + * @ndev: network interface device structure * * Returns 0, this is not allowed to fail * @@ -585,7 +588,7 @@ static int bdx_close(struct net_device *ndev) /** * bdx_open - Called when a network interface is made active - * @netdev: network interface device structure + * @ndev: network interface device structure * * Returns 0 on success, negative value on failure * @@ -698,7 +701,7 @@ static int bdx_ioctl(struct net_device *ndev, struct ifreq *ifr, int cmd) * __bdx_vlan_rx_vid - private helper for adding/killing VLAN vid * @ndev: network device * @vid: VLAN vid - * @op: add or kill operation + * @enable: enable or disable vlan * * Passes VLAN filter table to hardware */ @@ -729,6 +732,7 @@ static void __bdx_vlan_rx_vid(struct net_device *ndev, uint16_t vid, int enable) /** * bdx_vlan_rx_add_vid - kernel hook for adding VLAN vid to hw filtering table * @ndev: network device + * @proto: unused * @vid: VLAN vid to add */ static int bdx_vlan_rx_add_vid(struct net_device *ndev, __be16 proto, u16 vid) @@ -740,6 +744,7 @@ static int bdx_vlan_rx_add_vid(struct net_device *ndev, __be16 proto, u16 vid) /** * bdx_vlan_rx_kill_vid - kernel hook for killing VLAN vid in hw filtering table * @ndev: network device + * @proto: unused * @vid: VLAN vid to kill */ static int bdx_vlan_rx_kill_vid(struct net_device *ndev, __be16 proto, u16 vid) @@ -750,7 +755,7 @@ static int bdx_vlan_rx_kill_vid(struct net_device *ndev, __be16 proto, u16 vid) /** * bdx_change_mtu - Change the Maximum Transfer Unit - * @netdev: network interface device structure + * @ndev: network interface device structure * @new_mtu: new value for maximum frame size * * Returns 0 on success, negative on failure @@ -1756,6 +1761,8 @@ static void bdx_tx_cleanup(struct bdx_priv *priv) /** * bdx_tx_free_skbs - frees all skbs from TXD fifo. + * @priv: NIC private structure + * * It gets called when OS stops this dev, eg upon "ifconfig down" or rmmod */ static void bdx_tx_free_skbs(struct bdx_priv *priv) diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c b/drivers/net/ethernet/ti/davinci_cpdma.c index 6614fa3089b2..d2eab5cd1e0c 100644 --- a/drivers/net/ethernet/ti/davinci_cpdma.c +++ b/drivers/net/ethernet/ti/davinci_cpdma.c @@ -718,7 +718,7 @@ static void cpdma_chan_set_descs(struct cpdma_ctlr *ctlr, most_chan->desc_num += desc_cnt; } -/** +/* * cpdma_chan_split_pool - Splits ctrl pool between all channels. * Has to be called under ctlr lock */ diff --git a/drivers/net/ethernet/ti/davinci_emac.c b/drivers/net/ethernet/ti/davinci_emac.c index b36d0e412d23..c7031e1960d4 100644 --- a/drivers/net/ethernet/ti/davinci_emac.c +++ b/drivers/net/ethernet/ti/davinci_emac.c @@ -671,7 +671,7 @@ static int emac_hash_del(struct emac_priv *priv, u8 *mac_addr) * emac_add_mcast - Set multicast address in the EMAC adapter (Internal) * @priv: The DaVinci EMAC private adapter structure * @action: multicast operation to perform - * mac_addr: mac address to set + * @mac_addr: mac address to set * * Set multicast addresses in EMAC adapter - internal function * @@ -977,6 +977,7 @@ static int emac_dev_xmit(struct sk_buff *skb, struct net_device *ndev) /** * emac_dev_tx_timeout - EMAC Transmit timeout function * @ndev: The DaVinci EMAC network adapter + * @txqueue: the index of the hung transmit queue * * Called when system detects that a skb timeout period has expired * potentially due to a fault in the adapter in not being able to send @@ -1209,7 +1210,7 @@ static int emac_hw_enable(struct emac_priv *priv) /** * emac_poll - EMAC NAPI Poll function - * @ndev: The DaVinci EMAC network adapter + * @napi: pointer to the napi_struct containing The DaVinci EMAC network adapter * @budget: Number of receive packets to process (as told by NAPI layer) * * NAPI Poll function implemented to process packets as per budget. We check diff --git a/drivers/net/ethernet/via/via-rhine.c b/drivers/net/ethernet/via/via-rhine.c index 803247d51fe9..26e6b087c0e4 100644 --- a/drivers/net/ethernet/via/via-rhine.c +++ b/drivers/net/ethernet/via/via-rhine.c @@ -1515,7 +1515,7 @@ static void rhine_init_cam_filter(struct net_device *dev) /** * rhine_update_vcam - update VLAN CAM filters - * @rp: rhine_private data of this Rhine + * @dev: rhine_private data of this Rhine * * Update VLAN CAM filters to match configuration change. */ diff --git a/drivers/net/ethernet/via/via-velocity.c b/drivers/net/ethernet/via/via-velocity.c index 722b44604ea8..b65767f9e499 100644 --- a/drivers/net/ethernet/via/via-velocity.c +++ b/drivers/net/ethernet/via/via-velocity.c @@ -372,7 +372,7 @@ static const struct pci_device_id velocity_pci_id_table[] = { MODULE_DEVICE_TABLE(pci, velocity_pci_id_table); -/** +/* * Describe the OF device identifiers that we support in this * device driver. Used for devicetree nodes. */ @@ -384,7 +384,7 @@ MODULE_DEVICE_TABLE(of, velocity_of_ids); /** * get_chip_name - identifier to name - * @id: chip identifier + * @chip_id: chip identifier * * Given a chip identifier return a suitable description. Returns * a pointer a static string valid while the driver is loaded. @@ -748,7 +748,7 @@ static u32 mii_check_media_mode(struct mac_regs __iomem *regs) /** * velocity_mii_write - write MII data * @regs: velocity registers - * @index: MII register index + * @mii_addr: MII register index * @data: 16bit data for the MII register * * Perform a single write to an MII 16bit register. Returns zero @@ -869,6 +869,7 @@ static u32 check_connection_type(struct mac_regs __iomem *regs) /** * velocity_set_media_mode - set media mode + * @vptr: velocity adapter * @mii_status: old MII link state * * Check the media link state and configure the flow control @@ -1256,6 +1257,7 @@ static void mii_init(struct velocity_info *vptr, u32 mii_status) /** * setup_queue_timers - Setup interrupt timers + * @vptr: velocity adapter * * Setup interrupt frequency during suppression (timeout if the frame * count isn't filled). @@ -1280,8 +1282,7 @@ static void setup_queue_timers(struct velocity_info *vptr) /** * setup_adaptive_interrupts - Setup interrupt suppression - * - * @vptr velocity adapter + * @vptr: velocity adapter * * The velocity is able to suppress interrupt during high interrupt load. * This function turns on that feature. @@ -1722,6 +1723,7 @@ static int velocity_init_rings(struct velocity_info *vptr, int mtu) * velocity_free_tx_buf - free transmit buffer * @vptr: velocity * @tdinfo: buffer + * @td: transmit descriptor to free * * Release an transmit buffer. If the buffer was preallocated then * recycle it, if not then unmap the buffer. @@ -1896,7 +1898,7 @@ static void velocity_error(struct velocity_info *vptr, int status) /** * tx_srv - transmit interrupt service - * @vptr; Velocity + * @vptr: Velocity * * Scan the queues looking for transmitted packets that * we can complete and clean up. Update any statistics as @@ -1990,8 +1992,7 @@ static inline void velocity_rx_csum(struct rx_desc *rd, struct sk_buff *skb) * velocity_rx_copy - in place Rx copy for small packets * @rx_skb: network layer packet buffer candidate * @pkt_size: received data size - * @rd: receive packet descriptor - * @dev: network device + * @vptr: velocity adapter * * Replace the current skb that is scheduled for Rx processing by a * shorter, immediately allocated skb, if the received packet is small @@ -2097,6 +2098,7 @@ static int velocity_receive_frame(struct velocity_info *vptr, int idx) /** * velocity_rx_srv - service RX interrupt * @vptr: velocity + * @budget_left: remaining budget * * Walk the receive ring of the velocity adapter and remove * any received packets from the receive queue. Hand the ring @@ -2645,7 +2647,6 @@ static const struct net_device_ops velocity_netdev_ops = { /** * velocity_init_info - init private data - * @pdev: PCI device * @vptr: Velocity info * @info: Board type * @@ -2664,7 +2665,6 @@ static void velocity_init_info(struct velocity_info *vptr, /** * velocity_get_pci_info - retrieve PCI info for device * @vptr: velocity device - * @pdev: PCI device it matches * * Retrieve the PCI configuration space data that interests us from * the kernel PCI layer @@ -2701,7 +2701,6 @@ static int velocity_get_pci_info(struct velocity_info *vptr) /** * velocity_get_platform_info - retrieve platform info for device * @vptr: velocity device - * @pdev: platform device it matches * * Retrieve the Platform configuration data that interests us */ @@ -2751,8 +2750,9 @@ static u32 velocity_get_link(struct net_device *dev) /** * velocity_probe - set up discovered velocity device - * @pdev: PCI device - * @ent: PCI device table entry that matched + * @dev: PCI device + * @info: table of match + * @irq: interrupt info * @bustype: bus that device is connected to * * Configure a discovered adapter from scratch. Return a negative @@ -2969,6 +2969,7 @@ static int velocity_platform_remove(struct platform_device *pdev) #ifdef CONFIG_PM_SLEEP /** * wol_calc_crc - WOL CRC + * @size: size of the wake mask * @pattern: data pattern * @mask_pattern: mask * -- 2.27.0 ^ permalink raw reply related [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 11/11] drivers/net/ethernet: clean up mis-targeted comments @ 2020-09-11 1:23 ` Jesse Brandeburg 0 siblings, 0 replies; 68+ messages in thread From: Jesse Brandeburg @ 2020-09-11 1:23 UTC (permalink / raw) To: intel-wired-lan As part of the W=1 cleanups for ethernet, a million [1] driver comments had to be cleaned up to get the W=1 compilation to succeed. This change finally makes the drivers/net/ethernet tree compile with W=1 set on the command line. [1] - ok it wasn't quite a million, but it felt like it. Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> --- Testing Hints: build with W=1 in the drivers/net/ethernet directory, I used: make allmodconfig make modules_prepare make M=drivers/net/ethernet W=1 modules --- .../net/ethernet/atheros/atl1c/atl1c_main.c | 6 +- .../net/ethernet/atheros/atl1e/atl1e_main.c | 7 +- drivers/net/ethernet/atheros/atlx/atl1.c | 2 +- drivers/net/ethernet/atheros/atlx/atl2.c | 6 +- .../net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 2 + .../ethernet/broadcom/bnx2x/bnx2x_ethtool.c | 6 +- .../net/ethernet/broadcom/bnx2x/bnx2x_main.c | 12 +- .../net/ethernet/broadcom/bnx2x/bnx2x_sp.c | 98 ++--- drivers/net/ethernet/brocade/bna/bfa_cee.c | 20 +- drivers/net/ethernet/brocade/bna/bfa_ioc.c | 8 +- drivers/net/ethernet/cadence/macb_main.c | 6 +- drivers/net/ethernet/calxeda/xgmac.c | 2 + .../net/ethernet/cavium/liquidio/lio_core.c | 92 ++--- .../net/ethernet/cavium/liquidio/lio_main.c | 351 +++++++++--------- .../ethernet/cavium/liquidio/lio_vf_main.c | 158 ++++---- .../ethernet/cavium/liquidio/octeon_console.c | 12 +- .../ethernet/cavium/liquidio/octeon_device.c | 4 +- .../ethernet/cavium/liquidio/octeon_droq.c | 2 +- .../ethernet/cavium/liquidio/octeon_mailbox.c | 5 +- .../net/ethernet/chelsio/cxgb3/cxgb3_main.c | 8 +- drivers/net/ethernet/chelsio/cxgb3/sge.c | 28 +- drivers/net/ethernet/chelsio/cxgb3/t3_hw.c | 5 +- drivers/net/ethernet/cisco/enic/enic_api.c | 2 +- .../net/ethernet/cisco/enic/enic_ethtool.c | 2 +- drivers/net/ethernet/cortina/gemini.c | 2 + drivers/net/ethernet/ethoc.c | 6 +- .../net/ethernet/freescale/dpaa2/dpaa2-eth.c | 2 +- drivers/net/ethernet/freescale/fec_ptp.c | 5 +- drivers/net/ethernet/freescale/fman/fman.c | 14 +- .../net/ethernet/freescale/fman/fman_muram.c | 6 +- .../net/ethernet/freescale/fman/fman_port.c | 23 +- drivers/net/ethernet/freescale/fman/mac.c | 4 +- drivers/net/ethernet/hisilicon/hns/hnae.c | 2 +- .../net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 34 +- .../ethernet/hisilicon/hns/hns_dsaf_main.c | 148 ++++---- .../ethernet/hisilicon/hns/hns_dsaf_misc.c | 7 +- .../net/ethernet/hisilicon/hns/hns_dsaf_ppe.c | 17 +- .../net/ethernet/hisilicon/hns/hns_dsaf_rcb.c | 7 +- .../ethernet/hisilicon/hns/hns_dsaf_xgmac.c | 3 +- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 4 +- .../net/ethernet/hisilicon/hns/hns_ethtool.c | 48 +-- drivers/net/ethernet/hisilicon/hns_mdio.c | 3 +- .../net/ethernet/huawei/hinic/hinic_hw_cmdq.c | 2 +- .../net/ethernet/huawei/hinic/hinic_hw_dev.c | 6 +- .../net/ethernet/huawei/hinic/hinic_hw_eqs.c | 1 + .../net/ethernet/huawei/hinic/hinic_hw_if.c | 1 + .../net/ethernet/huawei/hinic/hinic_hw_mgmt.c | 1 + .../net/ethernet/huawei/hinic/hinic_main.c | 2 +- drivers/net/ethernet/micrel/ksz884x.c | 46 ++- .../ethernet/microchip/encx24j600-regmap.c | 2 +- drivers/net/ethernet/natsemi/ns83820.c | 6 +- drivers/net/ethernet/neterion/s2io.c | 91 ++--- .../net/ethernet/neterion/vxge/vxge-config.c | 5 +- .../net/ethernet/neterion/vxge/vxge-ethtool.c | 2 +- .../net/ethernet/neterion/vxge/vxge-main.c | 10 +- .../net/ethernet/neterion/vxge/vxge-traffic.c | 40 +- .../oki-semi/pch_gbe/pch_gbe_ethtool.c | 4 +- .../ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 5 +- .../ethernet/oki-semi/pch_gbe/pch_gbe_param.c | 14 +- .../net/ethernet/packetengines/yellowfin.c | 2 +- .../net/ethernet/qlogic/netxen/netxen_nic.h | 3 - .../qlogic/netxen/netxen_nic_ethtool.c | 3 + drivers/net/ethernet/qualcomm/emac/emac.c | 1 + drivers/net/ethernet/realtek/8139cp.c | 2 + .../net/ethernet/samsung/sxgbe/sxgbe_main.c | 17 +- drivers/net/ethernet/sfc/falcon/rx.c | 2 + drivers/net/ethernet/sfc/falcon/selftest.c | 2 +- drivers/net/ethernet/sfc/net_driver.h | 2 +- drivers/net/ethernet/sfc/ptp.c | 6 + drivers/net/ethernet/sis/sis900.c | 3 +- .../net/ethernet/stmicro/stmmac/dwmac-rk.c | 2 +- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 14 +- .../ethernet/stmicro/stmmac/stmmac_platform.c | 3 +- drivers/net/ethernet/sun/cassini.c | 4 +- drivers/net/ethernet/tehuti/tehuti.c | 17 +- drivers/net/ethernet/ti/davinci_cpdma.c | 2 +- drivers/net/ethernet/ti/davinci_emac.c | 5 +- drivers/net/ethernet/via/via-rhine.c | 2 +- drivers/net/ethernet/via/via-velocity.c | 27 +- 79 files changed, 828 insertions(+), 708 deletions(-) diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c index c7288e1fa3a2..00de463268a8 100644 --- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c +++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c @@ -204,7 +204,7 @@ static u32 atl1c_wait_until_idle(struct atl1c_hw *hw, u32 modu_ctrl) /** * atl1c_phy_config - Timer Call-back - * @data: pointer to netdev cast into an unsigned long + * @t: timer list containing pointer to netdev cast into an unsigned long */ static void atl1c_phy_config(struct timer_list *t) { @@ -346,6 +346,7 @@ static void atl1c_del_timer(struct atl1c_adapter *adapter) /** * atl1c_tx_timeout - Respond to a Tx Hang * @netdev: network interface device structure + * @txqueue: index of hanging tx queue */ static void atl1c_tx_timeout(struct net_device *netdev, unsigned int txqueue) { @@ -846,6 +847,7 @@ static inline void atl1c_clean_buffer(struct pci_dev *pdev, /** * atl1c_clean_tx_ring - Free Tx-skb * @adapter: board private structure + * @type: type of transmit queue */ static void atl1c_clean_tx_ring(struct atl1c_adapter *adapter, enum atl1c_trans_queue type) @@ -1861,6 +1863,8 @@ static void atl1c_clean_rx_irq(struct atl1c_adapter *adapter, /** * atl1c_clean - NAPI Rx polling callback + * @napi: napi info + * @budget: limit of packets to clean */ static int atl1c_clean(struct napi_struct *napi, int budget) { diff --git a/drivers/net/ethernet/atheros/atl1e/atl1e_main.c b/drivers/net/ethernet/atheros/atl1e/atl1e_main.c index fb78f6c31708..e43f71849daf 100644 --- a/drivers/net/ethernet/atheros/atl1e/atl1e_main.c +++ b/drivers/net/ethernet/atheros/atl1e/atl1e_main.c @@ -111,7 +111,7 @@ static inline void atl1e_irq_reset(struct atl1e_adapter *adapter) /** * atl1e_phy_config - Timer Call-back - * @data: pointer to netdev cast into an unsigned long + * @t: timer list containing pointer to netdev cast into an unsigned long */ static void atl1e_phy_config(struct timer_list *t) { @@ -196,7 +196,7 @@ static int atl1e_check_link(struct atl1e_adapter *adapter) /** * atl1e_link_chg_task - deal with link change event Out of interrupt context - * @netdev: network interface device structure + * @work: work struct with driver info */ static void atl1e_link_chg_task(struct work_struct *work) { @@ -246,6 +246,7 @@ static void atl1e_cancel_work(struct atl1e_adapter *adapter) /** * atl1e_tx_timeout - Respond to a Tx Hang * @netdev: network interface device structure + * @txqueue: the index of the hanging queue */ static void atl1e_tx_timeout(struct net_device *netdev, unsigned int txqueue) { @@ -1502,6 +1503,8 @@ static void atl1e_clean_rx_irq(struct atl1e_adapter *adapter, u8 que, /** * atl1e_clean - NAPI Rx polling callback + * @napi: napi info + * @budget: number of packets to clean */ static int atl1e_clean(struct napi_struct *napi, int budget) { diff --git a/drivers/net/ethernet/atheros/atlx/atl1.c b/drivers/net/ethernet/atheros/atlx/atl1.c index 60f8aa79deb2..eaf96d002fa5 100644 --- a/drivers/net/ethernet/atheros/atlx/atl1.c +++ b/drivers/net/ethernet/atheros/atlx/atl1.c @@ -2552,7 +2552,7 @@ static irqreturn_t atl1_intr(int irq, void *data) /** * atl1_phy_config - Timer Call-back - * @data: pointer to netdev cast into an unsigned long + * @t: timer_list containing pointer to netdev cast into an unsigned long */ static void atl1_phy_config(struct timer_list *t) { diff --git a/drivers/net/ethernet/atheros/atlx/atl2.c b/drivers/net/ethernet/atheros/atlx/atl2.c index e2526c0fb7cf..021fb0e6417a 100644 --- a/drivers/net/ethernet/atheros/atlx/atl2.c +++ b/drivers/net/ethernet/atheros/atlx/atl2.c @@ -994,6 +994,7 @@ static int atl2_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd) /** * atl2_tx_timeout - Respond to a Tx Hang * @netdev: network interface device structure + * @txqueue: index of the hanging transmit queue */ static void atl2_tx_timeout(struct net_device *netdev, unsigned int txqueue) { @@ -1005,7 +1006,7 @@ static void atl2_tx_timeout(struct net_device *netdev, unsigned int txqueue) /** * atl2_watchdog - Timer Call-back - * @data: pointer to netdev cast into an unsigned long + * @t: timer list containing a pointer to netdev cast into an unsigned long */ static void atl2_watchdog(struct timer_list *t) { @@ -1030,7 +1031,7 @@ static void atl2_watchdog(struct timer_list *t) /** * atl2_phy_config - Timer Call-back - * @data: pointer to netdev cast into an unsigned long + * @t: timer list containing a pointer to netdev cast into an unsigned long */ static void atl2_phy_config(struct timer_list *t) { @@ -1235,6 +1236,7 @@ static int atl2_check_link(struct atl2_adapter *adapter) /** * atl2_link_chg_task - deal with link change event Out of interrupt context + * @work: pointer to work struct with private info */ static void atl2_link_chg_task(struct work_struct *work) { diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c index 2c0ccd4fba9b..1a6ec1a12d53 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c @@ -504,6 +504,7 @@ static void bnx2x_tpa_start(struct bnx2x_fastpath *fp, u16 queue, * @len_on_bd: total length of the first packet for the * aggregation. * @pkt_len: length of all segments + * @num_of_coalesced_segs: count of segments * * Approximate value of the MSS for this aggregation calculated using * the first packet of it. @@ -1958,6 +1959,7 @@ void bnx2x_set_num_queues(struct bnx2x *bp) * bnx2x_set_real_num_queues - configure netdev->real_num_[tx,rx]_queues * * @bp: Driver handle + * @include_cnic: handle cnic case * * We currently support for at most 16 Tx queues for each CoS thus we will * allocate a multiple of 16 for ETH L2 rings according to the value of the diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c index 7cea33803f7f..32245bbe88a8 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c @@ -839,8 +839,9 @@ static bool bnx2x_is_wreg_in_chip(struct bnx2x *bp, /** * bnx2x_read_pages_regs - read "paged" registers * - * @bp device handle - * @p output buffer + * @bp: device handle + * @p: output buffer + * @preset: the preset value * * Reads "paged" memories: memories that may only be read by first writing to a * specific address ("write address") and then reading from a specific address @@ -3561,6 +3562,7 @@ static void bnx2x_get_channels(struct net_device *dev, * bnx2x_change_num_queues - change the number of RSS queues. * * @bp: bnx2x private structure + * @num_rss: rss count * * Re-configure interrupt mode to get the new number of MSI-X * vectors and re-add NAPI objects. diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c index 3c543dd7a8f3..207289fd16da 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c @@ -3086,9 +3086,9 @@ void bnx2x_func_init(struct bnx2x *bp, struct bnx2x_func_init_params *p) /** * bnx2x_get_common_flags - Return common flags * - * @bp device handle - * @fp queue handle - * @zero_stats TRUE if statistics zeroing is needed + * @bp: device handle + * @fp: queue handle + * @zero_stats: TRUE if statistics zeroing is needed * * Return the flags that are common for the Tx-only and not normal connections. */ @@ -13591,8 +13591,8 @@ static int bnx2x_set_qm_cid_count(struct bnx2x *bp) /** * bnx2x_get_num_none_def_sbs - return the number of none default SBs - * - * @dev: pci device + * @pdev: pci device + * @cnic_cnt: count * */ static int bnx2x_get_num_non_def_sbs(struct pci_dev *pdev, int cnic_cnt) @@ -14451,9 +14451,7 @@ module_exit(bnx2x_cleanup); /** * bnx2x_set_iscsi_eth_mac_addr - set iSCSI MAC(s). - * * @bp: driver handle - * @set: set or clear the CAM entry * * This function will wait until the ramrod completion returns. * Return 0 if success, -ENODEV if ramrod doesn't return. diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c index e26f4da5a6d7..6cd1523ad9e5 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c @@ -37,10 +37,12 @@ /** * bnx2x_exe_queue_init - init the Exe Queue object * + * @bp: driver handle * @o: pointer to the object * @exe_len: length * @owner: pointer to the owner * @validate: validate function pointer + * @remove: remove function pointer * @optimize: optimize function pointer * @exec: execute function pointer * @get: get function pointer @@ -103,7 +105,7 @@ static inline int bnx2x_exe_queue_length(struct bnx2x_exe_queue_obj *o) * * @bp: driver handle * @o: queue - * @cmd: new command to add + * @elem: new command to add * @restore: true - do not optimize the command * * If the element is optimized or is illegal, frees it. @@ -277,7 +279,7 @@ static void bnx2x_raw_set_pending(struct bnx2x_raw_obj *o) * * @bp: device handle * @state: state which is to be cleared - * @state_p: state buffer + * @pstate: state buffer * */ static inline int bnx2x_state_wait(struct bnx2x *bp, int state, @@ -424,8 +426,8 @@ static bool bnx2x_put_credit_vlan_mac(struct bnx2x_vlan_mac_obj *o) * @bp: device handle * @o: vlan_mac object * - * @details: Non-blocking implementation; should be called under execution - * queue lock. + * Context: Non-blocking implementation; should be called under execution + * queue lock. */ static int __bnx2x_vlan_mac_h_write_trylock(struct bnx2x *bp, struct bnx2x_vlan_mac_obj *o) @@ -445,7 +447,7 @@ static int __bnx2x_vlan_mac_h_write_trylock(struct bnx2x *bp, * @bp: device handle * @o: vlan_mac object * - * @details Should be called under execution queue lock; notice it might release + * details Should be called under execution queue lock; notice it might release * and reclaim it during its run. */ static void __bnx2x_vlan_mac_h_exec_pending(struct bnx2x *bp, @@ -475,7 +477,7 @@ static void __bnx2x_vlan_mac_h_exec_pending(struct bnx2x *bp, * @o: vlan_mac object * @ramrod_flags: ramrod flags of missed execution * - * @details Should be called under execution queue lock. + * Context: Should be called under execution queue lock. */ static void __bnx2x_vlan_mac_h_pend(struct bnx2x *bp, struct bnx2x_vlan_mac_obj *o, @@ -493,7 +495,7 @@ static void __bnx2x_vlan_mac_h_pend(struct bnx2x *bp, * @bp: device handle * @o: vlan_mac object * - * @details Should be called under execution queue lock. Notice if a pending + * Context: Should be called under execution queue lock. Notice if a pending * execution exists, it would perform it - possibly releasing and * reclaiming the execution queue lock. */ @@ -516,7 +518,7 @@ static void __bnx2x_vlan_mac_h_write_unlock(struct bnx2x *bp, * @bp: device handle * @o: vlan_mac object * - * @details Should be called under the execution queue lock. May sleep. May + * Context: Should be called under the execution queue lock. May sleep. May * release and reclaim execution queue lock during its run. */ static int __bnx2x_vlan_mac_h_read_lock(struct bnx2x *bp, @@ -536,7 +538,7 @@ static int __bnx2x_vlan_mac_h_read_lock(struct bnx2x *bp, * @bp: device handle * @o: vlan_mac object * - * @details May sleep. Claims and releases execution queue lock during its run. + * Context: May sleep. Claims and releases execution queue lock during its run. */ int bnx2x_vlan_mac_h_read_lock(struct bnx2x *bp, struct bnx2x_vlan_mac_obj *o) @@ -556,7 +558,7 @@ int bnx2x_vlan_mac_h_read_lock(struct bnx2x *bp, * @bp: device handle * @o: vlan_mac object * - * @details Should be called under execution queue lock. Notice if a pending + * Context: Should be called under execution queue lock. Notice if a pending * execution exists, it would be performed if this was the last * reader. possibly releasing and reclaiming the execution queue lock. */ @@ -591,7 +593,7 @@ static void __bnx2x_vlan_mac_h_read_unlock(struct bnx2x *bp, * @bp: device handle * @o: vlan_mac object * - * @details Notice if a pending execution exists, it would be performed if this + * Context: Notice if a pending execution exists, it would be performed if this * was the last reader. Claims and releases the execution queue lock * during its run. */ @@ -968,7 +970,7 @@ static void bnx2x_set_one_mac_e2(struct bnx2x *bp, * * @bp: device handle * @o: queue - * @type: + * @type: the type of echo * @cam_offset: offset in cam memory * @hdr: pointer to a header to setup * @@ -1608,8 +1610,8 @@ static int __bnx2x_vlan_mac_execute_step(struct bnx2x *bp, * * @bp: device handle * @o: bnx2x_vlan_mac_obj - * @cqe: - * @cont: if true schedule next execution chunk + * @cqe: completion element + * @ramrod_flags: if set schedule next execution chunk * */ static int bnx2x_complete_vlan_mac(struct bnx2x *bp, @@ -1656,7 +1658,7 @@ static int bnx2x_complete_vlan_mac(struct bnx2x *bp, * bnx2x_optimize_vlan_mac - optimize ADD and DEL commands. * * @bp: device handle - * @o: bnx2x_qable_obj + * @qo: bnx2x_qable_obj * @elem: bnx2x_exeq_elem */ static int bnx2x_optimize_vlan_mac(struct bnx2x *bp, @@ -1714,10 +1716,10 @@ static int bnx2x_optimize_vlan_mac(struct bnx2x *bp, * bnx2x_vlan_mac_get_registry_elem - prepare a registry element * * @bp: device handle - * @o: - * @elem: - * @restore: - * @re: + * @o: vlan object + * @elem: element + * @restore: to restore or not + * @re: registry * * prepare a registry element according to the current command request. */ @@ -1768,9 +1770,9 @@ static inline int bnx2x_vlan_mac_get_registry_elem( * bnx2x_execute_vlan_mac - execute vlan mac command * * @bp: device handle - * @qo: - * @exe_chunk: - * @ramrod_flags: + * @qo: bnx2x_qable_obj pointer + * @exe_chunk: chunk + * @ramrod_flags: flags * * go and send a ramrod! */ @@ -2006,8 +2008,8 @@ int bnx2x_config_vlan_mac(struct bnx2x *bp, * bnx2x_vlan_mac_del_all - delete elements with given vlan_mac_flags spec * * @bp: device handle - * @o: - * @vlan_mac_flags: + * @o: vlan object info + * @vlan_mac_flags: vlan flags * @ramrod_flags: execution flags to be used for this deletion * * if the last operation has completed successfully and there are no @@ -2767,7 +2769,7 @@ static int bnx2x_mcast_enqueue_cmd(struct bnx2x *bp, /** * bnx2x_mcast_get_next_bin - get the next set bin (index) * - * @o: + * @o: multicast object info * @last: index to start looking from (including) * * returns the next found (set) bin or a negative value if none is found. @@ -2892,7 +2894,7 @@ static void bnx2x_mcast_set_one_rule_e2(struct bnx2x *bp, * bnx2x_mcast_handle_restore_cmd_e2 - restore configuration from the registry * * @bp: device handle - * @o: + * @o: multicast object info * @start_bin: index in the registry to start from (including) * @rdata_idx: index in the ramrod data to start from * @@ -3202,11 +3204,11 @@ static inline void bnx2x_mcast_hdl_del(struct bnx2x *bp, } /** - * bnx2x_mcast_handle_current_cmd - + * bnx2x_mcast_handle_current_cmd - send command if room * * @bp: device handle - * @p: - * @cmd: + * @p: ramrod mcast info + * @cmd: command * @start_cnt: first line in the ramrod data that may be used * * This function is called iff there is enough place for the current command in @@ -3323,7 +3325,7 @@ static void bnx2x_mcast_revert_e2(struct bnx2x *bp, * bnx2x_mcast_set_rdata_hdr_e2 - sets a header values * * @bp: device handle - * @p: + * @p: ramrod parameters * @len: number of rules to handle */ static inline void bnx2x_mcast_set_rdata_hdr_e2(struct bnx2x *bp, @@ -3684,7 +3686,7 @@ static void bnx2x_mcast_set_one_rule_e1(struct bnx2x *bp, * bnx2x_mcast_set_rdata_hdr_e1 - set header values in mac_configuration_cmd * * @bp: device handle - * @p: + * @p: ramrod parameters * @len: number of rules to handle */ static inline void bnx2x_mcast_set_rdata_hdr_e1(struct bnx2x *bp, @@ -3711,7 +3713,7 @@ static inline void bnx2x_mcast_set_rdata_hdr_e1(struct bnx2x *bp, * bnx2x_mcast_handle_restore_cmd_e1 - restore command for 57710 * * @bp: device handle - * @o: + * @o: multicast info * @start_idx: index in the registry to start from * @rdata_idx: index in the ramrod data to start from * @@ -3798,10 +3800,10 @@ static inline int bnx2x_mcast_handle_pending_cmds_e1( /** * bnx2x_get_fw_mac_addr - revert the bnx2x_set_fw_mac_addr(). * - * @fw_hi: - * @fw_mid: - * @fw_lo: - * @mac: + * @fw_hi: address + * @fw_mid: address + * @fw_lo: address + * @mac: mac address */ static inline void bnx2x_get_fw_mac_addr(__le16 *fw_hi, __le16 *fw_mid, __le16 *fw_lo, u8 *mac) @@ -3818,7 +3820,7 @@ static inline void bnx2x_get_fw_mac_addr(__le16 *fw_hi, __le16 *fw_mid, * bnx2x_mcast_refresh_registry_e1 - * * @bp: device handle - * @cnt: + * @o: multicast info * * Check the ramrod data first entry flag to see if it's a DELETE or ADD command * and update the registry correspondingly: if ADD - allocate a memory and add @@ -4311,7 +4313,7 @@ static bool bnx2x_credit_pool_get_entry_always_true( /** * bnx2x_init_credit_pool - initialize credit pool internals. * - * @p: + * @p: credit pool * @base: Base entry in the CAM to use. * @credit: pool size. * @@ -4725,8 +4727,8 @@ static int bnx2x_queue_wait_comp(struct bnx2x *bp, * bnx2x_queue_comp_cmd - complete the state change command. * * @bp: device handle - * @o: - * @cmd: + * @o: queue info + * @cmd: command to exec * * Checks that the arrived completion is expected. */ @@ -5477,8 +5479,8 @@ static int bnx2x_queue_send_cmd_e2(struct bnx2x *bp, * bnx2x_queue_chk_transition - check state machine of a regular Queue * * @bp: device handle - * @o: - * @params: + * @o: queue info + * @params: queue state * * (not Forwarding) * It both checks if the requested command is legal in a current @@ -5735,8 +5737,8 @@ static int bnx2x_func_wait_comp(struct bnx2x *bp, * bnx2x_func_state_change_comp - complete the state machine transition * * @bp: device handle - * @o: - * @cmd: + * @o: function info + * @cmd: more info * * Called on state change transition. Completes the state * machine transition only - no HW interaction. @@ -5776,8 +5778,8 @@ static inline int bnx2x_func_state_change_comp(struct bnx2x *bp, * bnx2x_func_comp_cmd - complete the state change command * * @bp: device handle - * @o: - * @cmd: + * @o: function info + * @cmd: more info * * Checks that the arrived completion is expected. */ @@ -5796,8 +5798,8 @@ static int bnx2x_func_comp_cmd(struct bnx2x *bp, * bnx2x_func_chk_transition - perform function state machine transition * * @bp: device handle - * @o: - * @params: + * @o: function info + * @params: state parameters * * It both checks if the requested command is legal in a current * state and, if it's legal, sets a `next_state' in the object diff --git a/drivers/net/ethernet/brocade/bna/bfa_cee.c b/drivers/net/ethernet/brocade/bna/bfa_cee.c index 09fb9315d1ae..06f221c44802 100644 --- a/drivers/net/ethernet/brocade/bna/bfa_cee.c +++ b/drivers/net/ethernet/brocade/bna/bfa_cee.c @@ -102,14 +102,10 @@ bfa_cee_get_stats_isr(struct bfa_cee *cee, enum bfa_status status) } /** - * bfa_cee_get_attr_isr() + * bfa_cee_reset_stats_isr - CEE ISR for reset-stats responses from f/w * - * @brief CEE ISR for reset-stats responses from f/w - * - * @param[in] cee - Pointer to the CEE module - * status - Return status from the f/w - * - * @return void + * @cee: Input Pointer to the CEE module + * @status: Return status from the f/w */ static void bfa_cee_reset_stats_isr(struct bfa_cee *cee, enum bfa_status status) @@ -148,9 +144,12 @@ bfa_nw_cee_mem_claim(struct bfa_cee *cee, u8 *dma_kva, u64 dma_pa) } /** - * bfa_cee_get_attr - Send the request to the f/w to fetch CEE attributes. + * bfa_nw_cee_get_attr - Send the request to the f/w to fetch CEE attributes. * * @cee: Pointer to the CEE module data structure. + * @attr: attribute requested + * @cbfn: function pointer + * @cbarg: function pointer arguments * * Return: status */ @@ -181,7 +180,9 @@ bfa_nw_cee_get_attr(struct bfa_cee *cee, struct bfa_cee_attr *attr, } /** - * bfa_cee_isrs - Handles Mail-box interrupts for CEE module. + * bfa_cee_isr - Handles Mail-box interrupts for CEE module. + * @cbarg: argument passed containing pointer to the CEE module data structure. + * @m: message pointer */ static void @@ -210,6 +211,7 @@ bfa_cee_isr(void *cbarg, struct bfi_mbmsg *m) /** * bfa_cee_notify - CEE module heart-beat failure handler. * + * @arg: argument passed containing pointer to the CEE module data structure. * @event: IOC event type */ diff --git a/drivers/net/ethernet/brocade/bna/bfa_ioc.c b/drivers/net/ethernet/brocade/bna/bfa_ioc.c index b9dd06b12945..fd805c685d92 100644 --- a/drivers/net/ethernet/brocade/bna/bfa_ioc.c +++ b/drivers/net/ethernet/brocade/bna/bfa_ioc.c @@ -1763,7 +1763,7 @@ bfa_ioc_flash_fwver_cmp(struct bfa_ioc *ioc, return BFI_IOC_IMG_VER_INCOMP; } -/** +/* * Returns TRUE if driver is willing to work with current smem f/w version. */ bool @@ -2469,6 +2469,7 @@ bfa_ioc_isr(struct bfa_ioc *ioc, struct bfi_mbmsg *m) * * @ioc: memory for IOC * @bfa: driver instance structure + * @cbfn: callback function */ void bfa_nw_ioc_attach(struct bfa_ioc *ioc, void *bfa, struct bfa_ioc_cbfn *cbfn) @@ -2500,7 +2501,9 @@ bfa_nw_ioc_detach(struct bfa_ioc *ioc) /** * bfa_nw_ioc_pci_init - Setup IOC PCI properties. * + * @ioc: memory for IOC * @pcidev: PCI device information for this IOC + * @clscode: class code */ void bfa_nw_ioc_pci_init(struct bfa_ioc *ioc, struct bfa_pcidev *pcidev, @@ -2569,6 +2572,7 @@ bfa_nw_ioc_pci_init(struct bfa_ioc *ioc, struct bfa_pcidev *pcidev, /** * bfa_nw_ioc_mem_claim - Initialize IOC dma memory * + * @ioc: memory for IOC * @dm_kva: kernel virtual address of IOC dma memory * @dm_pa: physical address of IOC dma memory */ @@ -2636,6 +2640,8 @@ bfa_nw_ioc_mbox_regisr(struct bfa_ioc *ioc, enum bfi_mclass mc, * * @ioc: IOC instance * @cmd: Mailbox command + * @cbfn: callback function + * @cbarg: arguments to callback * * Waits if mailbox is busy. Responsibility of caller to serialize */ diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index 6761f404b8aa..7034dad10cbd 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -458,9 +458,9 @@ static void macb_init_buffers(struct macb *bp) /** * macb_set_tx_clk() - Set a clock to a new frequency - * @clk Pointer to the clock to change - * @rate New frequency in Hz - * @dev Pointer to the struct net_device + * @clk: Pointer to the clock to change + * @speed: New frequency in Hz + * @dev: Pointer to the struct net_device */ static void macb_set_tx_clk(struct clk *clk, int speed, struct net_device *dev) { diff --git a/drivers/net/ethernet/calxeda/xgmac.c b/drivers/net/ethernet/calxeda/xgmac.c index 05a3d067c3fc..bbb453c6a5f7 100644 --- a/drivers/net/ethernet/calxeda/xgmac.c +++ b/drivers/net/ethernet/calxeda/xgmac.c @@ -1246,6 +1246,8 @@ static int xgmac_poll(struct napi_struct *napi, int budget) /** * xgmac_tx_timeout * @dev : Pointer to net device structure + * @txqueue: index of the hung transmit queue + * * Description: this function is called when a packet transmission fails to * complete within a reasonable tmrate. The driver will mark the error in the * netdev structure and arrange for the device to be reset to a sane state diff --git a/drivers/net/ethernet/cavium/liquidio/lio_core.c b/drivers/net/ethernet/cavium/liquidio/lio_core.c index e40c64b79f66..9ef172976b35 100644 --- a/drivers/net/ethernet/cavium/liquidio/lio_core.c +++ b/drivers/net/ethernet/cavium/liquidio/lio_core.c @@ -32,8 +32,8 @@ #define OCTNIC_MAX_SG MAX_SKB_FRAGS /** - * \brief Delete gather lists - * @param lio per-network private data + * lio_delete_glists - Delete gather lists + * @lio: per-network private data */ void lio_delete_glists(struct lio *lio) { @@ -73,8 +73,10 @@ void lio_delete_glists(struct lio *lio) } /** - * \brief Setup gather lists - * @param lio per-network private data + * lio_setup_glists - Setup gather lists + * @oct: octeon_device + * @lio: per-network private data + * @num_iqs: count of iqs to allocate */ int lio_setup_glists(struct octeon_device *oct, struct lio *lio, int num_iqs) { @@ -521,12 +523,12 @@ static void lio_update_txq_status(struct octeon_device *oct, int iq_num) } /** - * \brief Setup output queue - * @param oct octeon device - * @param q_no which queue - * @param num_descs how many descriptors - * @param desc_size size of each descriptor - * @param app_ctx application context + * octeon_setup_droq - Setup output queue + * @oct: octeon device + * @q_no: which queue + * @num_descs: how many descriptors + * @desc_size: size of each descriptor + * @app_ctx: application context */ static int octeon_setup_droq(struct octeon_device *oct, int q_no, int num_descs, int desc_size, void *app_ctx) @@ -555,16 +557,17 @@ static int octeon_setup_droq(struct octeon_device *oct, int q_no, int num_descs, return ret_val; } -/** Routine to push packets arriving on Octeon interface upto network layer. - * @param oct_id - octeon device id. - * @param skbuff - skbuff struct to be passed to network layer. - * @param len - size of total data received. - * @param rh - Control header associated with the packet - * @param param - additional control data with the packet - * @param arg - farg registered in droq_ops +/** + * liquidio_push_packet - Routine to push packets arriving on Octeon interface upto network layer. + * @octeon_id:octeon device id. + * @skbuff: skbuff struct to be passed to network layer. + * @len: size of total data received. + * @rh: Control header associated with the packet + * @param: additional control data with the packet + * @arg: farg registered in droq_ops */ static void -liquidio_push_packet(u32 octeon_id __attribute__((unused)), +liquidio_push_packet(u32 __maybe_unused octeon_id, void *skbuff, u32 len, union octeon_rh *rh, @@ -698,8 +701,8 @@ liquidio_push_packet(u32 octeon_id __attribute__((unused)), } /** - * \brief wrapper for calling napi_schedule - * @param param parameters to pass to napi_schedule + * napi_schedule_wrapper - wrapper for calling napi_schedule + * @param: parameters to pass to napi_schedule * * Used when scheduling on different CPUs */ @@ -711,8 +714,8 @@ static void napi_schedule_wrapper(void *param) } /** - * \brief callback when receive interrupt occurs and we are in NAPI mode - * @param arg pointer to octeon output queue + * liquidio_napi_drv_callback - callback when receive interrupt occurs and we are in NAPI mode + * @arg: pointer to octeon output queue */ static void liquidio_napi_drv_callback(void *arg) { @@ -737,9 +740,9 @@ static void liquidio_napi_drv_callback(void *arg) } /** - * \brief Entry point for NAPI polling - * @param napi NAPI structure - * @param budget maximum number of items to process + * liquidio_napi_poll - Entry point for NAPI polling + * @napi: NAPI structure + * @budget: maximum number of items to process */ static int liquidio_napi_poll(struct napi_struct *napi, int budget) { @@ -792,9 +795,11 @@ static int liquidio_napi_poll(struct napi_struct *napi, int budget) } /** - * \brief Setup input and output queues - * @param octeon_dev octeon device - * @param ifidx Interface index + * liquidio_setup_io_queues - Setup input and output queues + * @octeon_dev: octeon device + * @ifidx: Interface index + * @num_iqs: input io queue count + * @num_oqs: output io queue count * * Note: Queues are with respect to the octeon device. Thus * an input queue is for egress packets, and output queues @@ -927,7 +932,7 @@ int liquidio_schedule_msix_droq_pkt_handler(struct octeon_droq *droq, u64 ret) } irqreturn_t -liquidio_msix_intr_handler(int irq __attribute__((unused)), void *dev) +liquidio_msix_intr_handler(int __maybe_unused irq, void *dev) { struct octeon_ioq_vector *ioq_vector = (struct octeon_ioq_vector *)dev; struct octeon_device *oct = ioq_vector->oct_dev; @@ -943,8 +948,8 @@ liquidio_msix_intr_handler(int irq __attribute__((unused)), void *dev) } /** - * \brief Droq packet processor sceduler - * @param oct octeon device + * liquidio_schedule_droq_pkt_handlers - Droq packet processor sceduler + * @oct: octeon device */ static void liquidio_schedule_droq_pkt_handlers(struct octeon_device *oct) { @@ -972,13 +977,12 @@ static void liquidio_schedule_droq_pkt_handlers(struct octeon_device *oct) } /** - * \brief Interrupt handler for octeon - * @param irq unused - * @param dev octeon device + * liquidio_legacy_intr_handler - Interrupt handler for octeon + * @irq: unused + * @dev: octeon device */ static -irqreturn_t liquidio_legacy_intr_handler(int irq __attribute__((unused)), - void *dev) +irqreturn_t liquidio_legacy_intr_handler(int __maybe_unused irq, void *dev) { struct octeon_device *oct = (struct octeon_device *)dev; irqreturn_t ret; @@ -999,8 +1003,9 @@ irqreturn_t liquidio_legacy_intr_handler(int irq __attribute__((unused)), } /** - * \brief Setup interrupt for octeon device - * @param oct octeon device + * octeon_setup_interrupt - Setup interrupt for octeon device + * @oct: octeon device + * @num_ioqs: number of queues * * Enable interrupt in Octeon device as given in the PCI interrupt mask. */ @@ -1083,7 +1088,7 @@ int octeon_setup_interrupt(struct octeon_device *oct, u32 num_ioqs) dev_dbg(&oct->pci_dev->dev, "OCTEON: Enough MSI-X interrupts are allocated...\n"); num_ioq_vectors = oct->num_msix_irqs; - /** For PF, there is one non-ioq interrupt handler */ + /* For PF, there is one non-ioq interrupt handler */ if (OCTEON_CN23XX_PF(oct)) { num_ioq_vectors -= 1; @@ -1126,13 +1131,13 @@ int octeon_setup_interrupt(struct octeon_device *oct, u32 num_ioqs) dev_err(&oct->pci_dev->dev, "Request_irq failed for MSIX interrupt Error: %d\n", irqret); - /** Freeing the non-ioq irq vector here . */ + /* Freeing the non-ioq irq vector here . */ free_irq(msix_entries[num_ioq_vectors].vector, oct); while (i) { i--; - /** clearing affinity mask. */ + /* clearing affinity mask. */ irq_set_affinity_hint( msix_entries[i].vector, NULL); @@ -1197,8 +1202,9 @@ int octeon_setup_interrupt(struct octeon_device *oct, u32 num_ioqs) } /** - * \brief Net device change_mtu - * @param netdev network device + * liquidio_change_mtu - Net device change_mtu + * @netdev: network device + * @new_mtu: the new max transmit unit size */ int liquidio_change_mtu(struct net_device *netdev, int new_mtu) { diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c b/drivers/net/ethernet/cavium/liquidio/lio_main.c index 737ae69eec6e..8c9f792c4e54 100644 --- a/drivers/net/ethernet/cavium/liquidio/lio_main.c +++ b/drivers/net/ethernet/cavium/liquidio/lio_main.c @@ -69,9 +69,9 @@ MODULE_PARM_DESC(console_bitmask, "Bitmask indicating which consoles have debug output redirected to syslog."); /** - * \brief determines if a given console has debug enabled. - * @param console console to check - * @returns 1 = enabled. 0 otherwise + * octeon_console_debug_enabled - determines if a given console has debug enabled. + * @console: console to check + * Return: 1 = enabled. 0 otherwise */ static int octeon_console_debug_enabled(u32 console) { @@ -126,7 +126,7 @@ union tx_info { } s; }; -/** Octeon device properties to be used by the NIC module. +/* Octeon device properties to be used by the NIC module. * Each octeon device in the system will be represented * by this structure in the NIC module. */ @@ -222,8 +222,8 @@ static int lio_wait_for_oq_pkts(struct octeon_device *oct) } /** - * \brief Forces all IO queues off on a given device - * @param oct Pointer to Octeon device + * force_io_queues_off - Forces all IO queues off on a given device + * @oct: Pointer to Octeon device */ static void force_io_queues_off(struct octeon_device *oct) { @@ -238,8 +238,8 @@ static void force_io_queues_off(struct octeon_device *oct) } /** - * \brief Cause device to go quiet so it can be safely removed/reset/etc - * @param oct Pointer to Octeon device + * pcierror_quiesce_device - Cause device to go quiet so it can be safely removed/reset/etc + * @oct: Pointer to Octeon device */ static inline void pcierror_quiesce_device(struct octeon_device *oct) { @@ -283,8 +283,8 @@ static inline void pcierror_quiesce_device(struct octeon_device *oct) } /** - * \brief Cleanup PCI AER uncorrectable error status - * @param dev Pointer to PCI device + * cleanup_aer_uncorrect_error_status - Cleanup PCI AER uncorrectable error status + * @dev: Pointer to PCI device */ static void cleanup_aer_uncorrect_error_status(struct pci_dev *dev) { @@ -303,8 +303,8 @@ static void cleanup_aer_uncorrect_error_status(struct pci_dev *dev) } /** - * \brief Stop all PCI IO to a given device - * @param dev Pointer to Octeon device + * stop_pci_io - Stop all PCI IO to a given device + * @oct: Pointer to Octeon device */ static void stop_pci_io(struct octeon_device *oct) { @@ -332,9 +332,9 @@ static void stop_pci_io(struct octeon_device *oct) } /** - * \brief called when PCI error is detected - * @param pdev Pointer to PCI device - * @param state The current pci connection state + * liquidio_pcie_error_detected - called when PCI error is detected + * @pdev: Pointer to PCI device + * @state: The current pci connection state * * This function is called after a PCI bus error affecting * this device has been detected. @@ -362,11 +362,10 @@ static pci_ers_result_t liquidio_pcie_error_detected(struct pci_dev *pdev, } /** - * \brief mmio handler - * @param pdev Pointer to PCI device + * liquidio_pcie_mmio_enabled - mmio handler + * @pdev: Pointer to PCI device */ -static pci_ers_result_t liquidio_pcie_mmio_enabled( - struct pci_dev *pdev __attribute__((unused))) +static pci_ers_result_t liquidio_pcie_mmio_enabled(struct pci_dev __maybe_unused *pdev) { /* We should never hit this since we never ask for a reset for a Fatal * Error. We always return DISCONNECT in io_error above. @@ -376,14 +375,13 @@ static pci_ers_result_t liquidio_pcie_mmio_enabled( } /** - * \brief called after the pci bus has been reset. - * @param pdev Pointer to PCI device + * liquidio_pcie_slot_reset - called after the pci bus has been reset. + * @pdev: Pointer to PCI device * * Restart the card from scratch, as if from a cold-boot. Implementation * resembles the first-half of the octeon_resume routine. */ -static pci_ers_result_t liquidio_pcie_slot_reset( - struct pci_dev *pdev __attribute__((unused))) +static pci_ers_result_t liquidio_pcie_slot_reset(struct pci_dev __maybe_unused *pdev) { /* We should never hit this since we never ask for a reset for a Fatal * Error. We always return DISCONNECT in io_error above. @@ -393,14 +391,14 @@ static pci_ers_result_t liquidio_pcie_slot_reset( } /** - * \brief called when traffic can start flowing again. - * @param pdev Pointer to PCI device + * liquidio_pcie_resume - called when traffic can start flowing again. + * @pdev: Pointer to PCI device * * This callback is called when the error recovery driver tells us that * its OK to resume normal operation. Implementation resembles the * second-half of the octeon_resume routine. */ -static void liquidio_pcie_resume(struct pci_dev *pdev __attribute__((unused))) +static void liquidio_pcie_resume(struct pci_dev __maybe_unused *pdev) { /* Nothing to be done here. */ } @@ -447,7 +445,7 @@ static struct pci_driver liquidio_pci_driver = { }; /** - * \brief register PCI driver + * liquidio_init_pci - register PCI driver */ static int liquidio_init_pci(void) { @@ -455,7 +453,7 @@ static int liquidio_init_pci(void) } /** - * \brief unregister PCI driver + * liquidio_deinit_pci - unregister PCI driver */ static void liquidio_deinit_pci(void) { @@ -463,9 +461,9 @@ static void liquidio_deinit_pci(void) } /** - * \brief Check Tx queue status, and take appropriate action - * @param lio per-network private data - * @returns 0 if full, number of queues woken up otherwise + * check_txq_status - Check Tx queue status, and take appropriate action + * @lio: per-network private data + * Return: 0 if full, number of queues woken up otherwise */ static inline int check_txq_status(struct lio *lio) { @@ -491,8 +489,8 @@ static inline int check_txq_status(struct lio *lio) } /** - * \brief Print link information - * @param netdev network device + * print_link_info - Print link information + * @netdev: network device */ static void print_link_info(struct net_device *netdev) { @@ -513,8 +511,8 @@ static void print_link_info(struct net_device *netdev) } /** - * \brief Routine to notify MTU change - * @param work work_struct data structure + * octnet_link_status_change - Routine to notify MTU change + * @work: work_struct data structure */ static void octnet_link_status_change(struct work_struct *work) { @@ -531,8 +529,8 @@ static void octnet_link_status_change(struct work_struct *work) } /** - * \brief Sets up the mtu status change work - * @param netdev network device + * setup_link_status_change_wq - Sets up the mtu status change work + * @netdev: network device */ static inline int setup_link_status_change_wq(struct net_device *netdev) { @@ -563,9 +561,9 @@ static inline void cleanup_link_status_change_wq(struct net_device *netdev) } /** - * \brief Update link status - * @param netdev network device - * @param ls link status structure + * update_link_status - Update link status + * @netdev: network device + * @ls: link status structure * * Called on receipt of a link status response from the core application to * update each interface's link status. @@ -663,10 +661,9 @@ static void lio_sync_octeon_time(struct work_struct *work) } /** - * setup_sync_octeon_time_wq - Sets up the work to periodically update - * local time to octeon firmware + * setup_sync_octeon_time_wq - prepare work to periodically update local time to octeon firmware * - * @netdev - network device which should send time update to firmware + * @netdev: network device which should send time update to firmware **/ static inline int setup_sync_octeon_time_wq(struct net_device *netdev) { @@ -690,10 +687,12 @@ static inline int setup_sync_octeon_time_wq(struct net_device *netdev) } /** - * cleanup_sync_octeon_time_wq - stop scheduling and destroy the work created - * to periodically update local time to octeon firmware + * cleanup_sync_octeon_time_wq - destroy wq * - * @netdev - network device which should send time update to firmware + * @netdev: network device which should send time update to firmware + * + * Stop scheduling and destroy the work created to periodically update local + * time to octeon firmware. **/ static inline void cleanup_sync_octeon_time_wq(struct net_device *netdev) { @@ -828,13 +827,12 @@ static int liquidio_watchdog(void *param) } /** - * \brief PCI probe handler - * @param pdev PCI device structure - * @param ent unused + * liquidio_probe - PCI probe handler + * @pdev: PCI device structure + * @ent: unused */ static int -liquidio_probe(struct pci_dev *pdev, - const struct pci_device_id *ent __attribute__((unused))) +liquidio_probe(struct pci_dev *pdev, const struct pci_device_id __maybe_unused *ent) { struct octeon_device *oct_dev = NULL; struct handshake *hs; @@ -924,8 +922,8 @@ static bool fw_type_is_auto(void) } /** - * \brief PCI FLR for each Octeon device. - * @param oct octeon device + * octeon_pci_flr - PCI FLR for each Octeon device. + * @oct: octeon device */ static void octeon_pci_flr(struct octeon_device *oct) { @@ -951,9 +949,8 @@ static void octeon_pci_flr(struct octeon_device *oct) } /** - *\brief Destroy resources associated with octeon device - * @param pdev PCI device structure - * @param ent unused + * octeon_destroy_resources - Destroy resources associated with octeon device + * @oct: octeon device */ static void octeon_destroy_resources(struct octeon_device *oct) { @@ -1152,9 +1149,9 @@ static void octeon_destroy_resources(struct octeon_device *oct) } /** - * \brief Send Rx control command - * @param lio per-network private data - * @param start_stop whether to start or stop + * send_rx_ctrl_cmd - Send Rx control command + * @lio: per-network private data + * @start_stop: whether to start or stop */ static void send_rx_ctrl_cmd(struct lio *lio, int start_stop) { @@ -1210,9 +1207,9 @@ static void send_rx_ctrl_cmd(struct lio *lio, int start_stop) } /** - * \brief Destroy NIC device interface - * @param oct octeon device - * @param ifidx which interface to destroy + * liquidio_destroy_nic_device - Destroy NIC device interface + * @oct: octeon device + * @ifidx: which interface to destroy * * Cleanup associated with each interface for an Octeon device when NIC * module is being unloaded or if initialization fails during load. @@ -1272,8 +1269,8 @@ static void liquidio_destroy_nic_device(struct octeon_device *oct, int ifidx) } /** - * \brief Stop complete NIC functionality - * @param oct octeon device + * liquidio_stop_nic_module - Stop complete NIC functionality + * @oct: octeon device */ static int liquidio_stop_nic_module(struct octeon_device *oct) { @@ -1313,8 +1310,8 @@ static int liquidio_stop_nic_module(struct octeon_device *oct) } /** - * \brief Cleans up resources at unload time - * @param pdev PCI device structure + * liquidio_remove - Cleans up resources at unload time + * @pdev: PCI device structure */ static void liquidio_remove(struct pci_dev *pdev) { @@ -1346,8 +1343,8 @@ static void liquidio_remove(struct pci_dev *pdev) } /** - * \brief Identify the Octeon device and to map the BAR address space - * @param oct octeon device + * octeon_chip_specific_setup - Identify the Octeon device and to map the BAR address space + * @oct: octeon device */ static int octeon_chip_specific_setup(struct octeon_device *oct) { @@ -1390,8 +1387,8 @@ static int octeon_chip_specific_setup(struct octeon_device *oct) } /** - * \brief PCI initialization for each Octeon device. - * @param oct octeon device + * octeon_pci_os_setup - PCI initialization for each Octeon device. + * @oct: octeon device */ static int octeon_pci_os_setup(struct octeon_device *oct) { @@ -1414,8 +1411,8 @@ static int octeon_pci_os_setup(struct octeon_device *oct) } /** - * \brief Unmap and free network buffer - * @param buf buffer + * free_netbuf - Unmap and free network buffer + * @buf: buffer */ static void free_netbuf(void *buf) { @@ -1434,8 +1431,8 @@ static void free_netbuf(void *buf) } /** - * \brief Unmap and free gather buffer - * @param buf buffer + * free_netsgbuf - Unmap and free gather buffer + * @buf: buffer */ static void free_netsgbuf(void *buf) { @@ -1474,8 +1471,8 @@ static void free_netsgbuf(void *buf) } /** - * \brief Unmap and free gather buffer with response - * @param buf buffer + * free_netsgbuf_with_resp - Unmap and free gather buffer with response + * @buf: buffer */ static void free_netsgbuf_with_resp(void *buf) { @@ -1518,9 +1515,9 @@ static void free_netsgbuf_with_resp(void *buf) } /** - * \brief Adjust ptp frequency - * @param ptp PTP clock info - * @param ppb how much to adjust by, in parts-per-billion + * liquidio_ptp_adjfreq - Adjust ptp frequency + * @ptp: PTP clock info + * @ppb: how much to adjust by, in parts-per-billion */ static int liquidio_ptp_adjfreq(struct ptp_clock_info *ptp, s32 ppb) { @@ -1555,9 +1552,9 @@ static int liquidio_ptp_adjfreq(struct ptp_clock_info *ptp, s32 ppb) } /** - * \brief Adjust ptp time - * @param ptp PTP clock info - * @param delta how much to adjust by, in nanosecs + * liquidio_ptp_adjtime - Adjust ptp time + * @ptp: PTP clock info + * @delta: how much to adjust by, in nanosecs */ static int liquidio_ptp_adjtime(struct ptp_clock_info *ptp, s64 delta) { @@ -1572,9 +1569,9 @@ static int liquidio_ptp_adjtime(struct ptp_clock_info *ptp, s64 delta) } /** - * \brief Get hardware clock time, including any adjustment - * @param ptp PTP clock info - * @param ts timespec + * liquidio_ptp_gettime - Get hardware clock time, including any adjustment + * @ptp: PTP clock info + * @ts: timespec */ static int liquidio_ptp_gettime(struct ptp_clock_info *ptp, struct timespec64 *ts) @@ -1595,9 +1592,9 @@ static int liquidio_ptp_gettime(struct ptp_clock_info *ptp, } /** - * \brief Set hardware clock time. Reset adjustment - * @param ptp PTP clock info - * @param ts timespec + * liquidio_ptp_settime - Set hardware clock time. Reset adjustment + * @ptp: PTP clock info + * @ts: timespec */ static int liquidio_ptp_settime(struct ptp_clock_info *ptp, const struct timespec64 *ts) @@ -1618,22 +1615,22 @@ static int liquidio_ptp_settime(struct ptp_clock_info *ptp, } /** - * \brief Check if PTP is enabled - * @param ptp PTP clock info - * @param rq request - * @param on is it on + * liquidio_ptp_enable - Check if PTP is enabled + * @ptp: PTP clock info + * @rq: request + * @on: is it on */ static int -liquidio_ptp_enable(struct ptp_clock_info *ptp __attribute__((unused)), - struct ptp_clock_request *rq __attribute__((unused)), - int on __attribute__((unused))) +liquidio_ptp_enable(struct ptp_clock_info __maybe_unused *ptp, + struct ptp_clock_request __maybe_unused *rq, + int __maybe_unused on) { return -EOPNOTSUPP; } /** - * \brief Open PTP clock source - * @param netdev network device + * oct_ptp_open - Open PTP clock source + * @netdev: network device */ static void oct_ptp_open(struct net_device *netdev) { @@ -1665,8 +1662,8 @@ static void oct_ptp_open(struct net_device *netdev) } /** - * \brief Init PTP clock - * @param oct octeon device + * liquidio_ptp_init - Init PTP clock + * @oct: octeon device */ static void liquidio_ptp_init(struct octeon_device *oct) { @@ -1682,8 +1679,8 @@ static void liquidio_ptp_init(struct octeon_device *oct) } /** - * \brief Load firmware to device - * @param oct octeon device + * load_firmware - Load firmware to device + * @oct: octeon device * * Maps device to firmware filename, requests firmware, and downloads it */ @@ -1721,8 +1718,8 @@ static int load_firmware(struct octeon_device *oct) } /** - * \brief Poll routine for checking transmit queue status - * @param work work_struct data structure + * octnet_poll_check_txq_status - Poll routine for checking transmit queue status + * @work: work_struct data structure */ static void octnet_poll_check_txq_status(struct work_struct *work) { @@ -1738,8 +1735,8 @@ static void octnet_poll_check_txq_status(struct work_struct *work) } /** - * \brief Sets up the txq poll check - * @param netdev network device + * setup_tx_poll_fn - Sets up the txq poll check + * @netdev: network device */ static inline int setup_tx_poll_fn(struct net_device *netdev) { @@ -1771,8 +1768,8 @@ static inline void cleanup_tx_poll_fn(struct net_device *netdev) } /** - * \brief Net device open for LiquidIO - * @param netdev network device + * liquidio_open - Net device open for LiquidIO + * @netdev: network device */ static int liquidio_open(struct net_device *netdev) { @@ -1831,8 +1828,8 @@ static int liquidio_open(struct net_device *netdev) } /** - * \brief Net device stop for LiquidIO - * @param netdev network device + * liquidio_stop - Net device stop for LiquidIO + * @netdev: network device */ static int liquidio_stop(struct net_device *netdev) { @@ -1896,8 +1893,8 @@ static int liquidio_stop(struct net_device *netdev) } /** - * \brief Converts a mask based on net device flags - * @param netdev network device + * get_new_flags - Converts a mask based on net device flags + * @netdev: network device * * This routine generates a octnet_ifflags mask from the net device flags * received from the OS. @@ -1929,8 +1926,8 @@ static inline enum octnet_ifflags get_new_flags(struct net_device *netdev) } /** - * \brief Net device set_multicast_list - * @param netdev network device + * liquidio_set_mcast_list - Net device set_multicast_list + * @netdev: network device */ static void liquidio_set_mcast_list(struct net_device *netdev) { @@ -1977,8 +1974,9 @@ static void liquidio_set_mcast_list(struct net_device *netdev) } /** - * \brief Net device set_mac_address - * @param netdev network device + * liquidio_set_mac - Net device set_mac_address + * @netdev: network device + * @p: pointer to sockaddr */ static int liquidio_set_mac(struct net_device *netdev, void *p) { @@ -2096,10 +2094,9 @@ liquidio_get_stats64(struct net_device *netdev, } /** - * \brief Handler for SIOCSHWTSTAMP ioctl - * @param netdev network device - * @param ifr interface request - * @param cmd command + * hwtstamp_ioctl - Handler for SIOCSHWTSTAMP ioctl + * @netdev: network device + * @ifr: interface request */ static int hwtstamp_ioctl(struct net_device *netdev, struct ifreq *ifr) { @@ -2154,10 +2151,10 @@ static int hwtstamp_ioctl(struct net_device *netdev, struct ifreq *ifr) } /** - * \brief ioctl handler - * @param netdev network device - * @param ifr interface request - * @param cmd command + * liquidio_ioctl - ioctl handler + * @netdev: network device + * @ifr: interface request + * @cmd: command */ static int liquidio_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd) { @@ -2174,9 +2171,10 @@ static int liquidio_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd) } /** - * \brief handle a Tx timestamp response - * @param status response status - * @param buf pointer to skb + * handle_timestamp - handle a Tx timestamp response + * @oct: octeon device + * @status: response status + * @buf: pointer to skb */ static void handle_timestamp(struct octeon_device *oct, u32 status, @@ -2217,10 +2215,12 @@ static void handle_timestamp(struct octeon_device *oct, tx_buffer_free(skb); } -/* \brief Send a data packet that will be timestamped - * @param oct octeon device - * @param ndata pointer to network data - * @param finfo pointer to private network data +/** + * send_nic_timestamp_pkt - Send a data packet that will be timestamped + * @oct: octeon device + * @ndata: pointer to network data + * @finfo: pointer to private network data + * @xmit_more: more is coming */ static inline int send_nic_timestamp_pkt(struct octeon_device *oct, struct octnic_data_pkt *ndata, @@ -2276,10 +2276,12 @@ static inline int send_nic_timestamp_pkt(struct octeon_device *oct, return retval; } -/** \brief Transmit networks packets to the Octeon interface - * @param skbuff skbuff struct to be passed to network layer. - * @param netdev pointer to network device - * @returns whether the packet was transmitted to the device okay or not +/** + * liquidio_xmit - Transmit networks packets to the Octeon interface + * @skb: skbuff struct to be passed to network layer. + * @netdev: pointer to network device + * + * Return: whether the packet was transmitted to the device okay or not * (NETDEV_TX_OK or NETDEV_TX_BUSY) */ static netdev_tx_t liquidio_xmit(struct sk_buff *skb, struct net_device *netdev) @@ -2524,8 +2526,10 @@ static netdev_tx_t liquidio_xmit(struct sk_buff *skb, struct net_device *netdev) return NETDEV_TX_OK; } -/** \brief Network device Tx timeout - * @param netdev pointer to network device +/** + * liquidio_tx_timeout - Network device Tx timeout + * @netdev: pointer to network device + * @txqueue: index of the hung transmit queue */ static void liquidio_tx_timeout(struct net_device *netdev, unsigned int txqueue) { @@ -2597,12 +2601,12 @@ static int liquidio_vlan_rx_kill_vid(struct net_device *netdev, return ret; } -/** Sending command to enable/disable RX checksum offload - * @param netdev pointer to network device - * @param command OCTNET_CMD_TNL_RX_CSUM_CTL - * @param rx_cmd_bit OCTNET_CMD_RXCSUM_ENABLE/ - * OCTNET_CMD_RXCSUM_DISABLE - * @returns SUCCESS or FAILURE +/** + * liquidio_set_rxcsum_command - Sending command to enable/disable RX checksum offload + * @netdev: pointer to network device + * @command: OCTNET_CMD_TNL_RX_CSUM_CTL + * @rx_cmd: OCTNET_CMD_RXCSUM_ENABLE/OCTNET_CMD_RXCSUM_DISABLE + * Returns: SUCCESS or FAILURE */ static int liquidio_set_rxcsum_command(struct net_device *netdev, int command, u8 rx_cmd) @@ -2632,13 +2636,14 @@ static int liquidio_set_rxcsum_command(struct net_device *netdev, int command, return ret; } -/** Sending command to add/delete VxLAN UDP port to firmware - * @param netdev pointer to network device - * @param command OCTNET_CMD_VXLAN_PORT_CONFIG - * @param vxlan_port VxLAN port to be added or deleted - * @param vxlan_cmd_bit OCTNET_CMD_VXLAN_PORT_ADD, +/** + * liquidio_vxlan_port_command - Sending command to add/delete VxLAN UDP port to firmware + * @netdev: pointer to network device + * @command: OCTNET_CMD_VXLAN_PORT_CONFIG + * @vxlan_port: VxLAN port to be added or deleted + * @vxlan_cmd_bit: OCTNET_CMD_VXLAN_PORT_ADD, * OCTNET_CMD_VXLAN_PORT_DEL - * @returns SUCCESS or FAILURE + * Return: SUCCESS or FAILURE */ static int liquidio_vxlan_port_command(struct net_device *netdev, int command, u16 vxlan_port, u8 vxlan_cmd_bit) @@ -2698,10 +2703,11 @@ static const struct udp_tunnel_nic_info liquidio_udp_tunnels = { }, }; -/** \brief Net device fix features - * @param netdev pointer to network device - * @param request features requested - * @returns updated features list +/** + * liquidio_fix_features - Net device fix features + * @netdev: pointer to network device + * @request: features requested + * Return: updated features list */ static netdev_features_t liquidio_fix_features(struct net_device *netdev, netdev_features_t request) @@ -2737,9 +2743,10 @@ static netdev_features_t liquidio_fix_features(struct net_device *netdev, return request; } -/** \brief Net device set features - * @param netdev pointer to network device - * @param features features to enable/disable +/** + * liquidio_set_features - Net device set features + * @netdev: pointer to network device + * @features: features to enable/disable */ static int liquidio_set_features(struct net_device *netdev, netdev_features_t features) @@ -3224,7 +3231,8 @@ static const struct net_device_ops lionetdevops = { .ndo_get_port_parent_id = liquidio_get_port_parent_id, }; -/** \brief Entry point for the liquidio module +/** + * liquidio_init - Entry point for the liquidio module */ static int __init liquidio_init(void) { @@ -3307,8 +3315,8 @@ static int lio_nic_info(struct octeon_recv_info *recv_info, void *buf) } /** - * \brief Setup network interfaces - * @param octeon_dev octeon device + * setup_nic_devices - Setup network interfaces + * @octeon_dev: octeon device * * Called during init time for each device. It assumes the NIC * is already up and running. The link information for each @@ -3872,8 +3880,8 @@ static int liquidio_enable_sriov(struct pci_dev *dev, int num_vfs) #endif /** - * \brief initialize the NIC - * @param oct octeon device + * liquidio_init_nic_module - initialize the NIC + * @oct: octeon device * * This initialization routine is called once the Octeon device application is * up and running @@ -3928,9 +3936,10 @@ static int liquidio_init_nic_module(struct octeon_device *oct) } /** - * \brief starter callback that invokes the remaining initialization work after - * the NIC is up and running. - * @param octptr work struct work_struct + * nic_starter - finish init + * @work: work struct work_struct + * + * starter callback that invokes the remaining initialization work after the NIC is up and running. */ static void nic_starter(struct work_struct *work) { @@ -4023,8 +4032,8 @@ octeon_recv_vf_drv_notice(struct octeon_recv_info *recv_info, void *buf) } /** - * \brief Device initialization for each Octeon device that is probed - * @param octeon_dev octeon device + * octeon_device_init - Device initialization for each Octeon device that is probed + * @octeon_dev: octeon device */ static int octeon_device_init(struct octeon_device *octeon_dev) { @@ -4303,11 +4312,11 @@ static int octeon_device_init(struct octeon_device *octeon_dev) } /** - * \brief Debug console print function - * @param octeon_dev octeon device - * @param console_num console number - * @param prefix first portion of line to display - * @param suffix second portion of line to display + * octeon_dbg_console_print - Debug console print function + * @oct: octeon device + * @console_num: console number + * @prefix: first portion of line to display + * @suffix: second portion of line to display * * The OCTEON debug console outputs entire lines (excluding '\n'). * Normally, the line will be passed in the 'prefix' parameter. @@ -4330,7 +4339,7 @@ static int octeon_dbg_console_print(struct octeon_device *oct, u32 console_num, } /** - * \brief Exits the module + * liquidio_exit - Exits the module */ static void __exit liquidio_exit(void) { diff --git a/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c b/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c index 8c5879e31240..103440f97bc8 100644 --- a/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c +++ b/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c @@ -99,8 +99,8 @@ static int lio_wait_for_oq_pkts(struct octeon_device *oct) } /** - * \brief Cause device to go quiet so it can be safely removed/reset/etc - * @param oct Pointer to Octeon device + * pcierror_quiesce_device - Cause device to go quiet so it can be safely removed/reset/etc + * @oct: Pointer to Octeon device */ static void pcierror_quiesce_device(struct octeon_device *oct) { @@ -143,8 +143,8 @@ static void pcierror_quiesce_device(struct octeon_device *oct) } /** - * \brief Cleanup PCI AER uncorrectable error status - * @param dev Pointer to PCI device + * cleanup_aer_uncorrect_error_status - Cleanup PCI AER uncorrectable error status + * @dev: Pointer to PCI device */ static void cleanup_aer_uncorrect_error_status(struct pci_dev *dev) { @@ -163,8 +163,8 @@ static void cleanup_aer_uncorrect_error_status(struct pci_dev *dev) } /** - * \brief Stop all PCI IO to a given device - * @param dev Pointer to Octeon device + * stop_pci_io - Stop all PCI IO to a given device + * @oct: Pointer to Octeon device */ static void stop_pci_io(struct octeon_device *oct) { @@ -205,9 +205,9 @@ static void stop_pci_io(struct octeon_device *oct) } /** - * \brief called when PCI error is detected - * @param pdev Pointer to PCI device - * @param state The current pci connection state + * liquidio_pcie_error_detected - called when PCI error is detected + * @pdev: Pointer to PCI device + * @state: The current pci connection state * * This function is called after a PCI bus error affecting * this device has been detected. @@ -256,8 +256,8 @@ static struct pci_driver liquidio_vf_pci_driver = { }; /** - * \brief Print link information - * @param netdev network device + * print_link_info - Print link information + * @netdev: network device */ static void print_link_info(struct net_device *netdev) { @@ -278,8 +278,8 @@ static void print_link_info(struct net_device *netdev) } /** - * \brief Routine to notify MTU change - * @param work work_struct data structure + * octnet_link_status_change - Routine to notify MTU change + * @work: work_struct data structure */ static void octnet_link_status_change(struct work_struct *work) { @@ -296,8 +296,8 @@ static void octnet_link_status_change(struct work_struct *work) } /** - * \brief Sets up the mtu status change work - * @param netdev network device + * setup_link_status_change_wq - Sets up the mtu status change work + * @netdev: network device */ static int setup_link_status_change_wq(struct net_device *netdev) { @@ -328,9 +328,9 @@ static void cleanup_link_status_change_wq(struct net_device *netdev) } /** - * \brief Update link status - * @param netdev network device - * @param ls link status structure + * update_link_status - Update link status + * @netdev: network device + * @ls: link status structure * * Called on receipt of a link status response from the core application to * update each interface's link status. @@ -374,13 +374,13 @@ static void update_link_status(struct net_device *netdev, } /** - * \brief PCI probe handler - * @param pdev PCI device structure - * @param ent unused + * liquidio_vf_probe - PCI probe handler + * @pdev: PCI device structure + * @ent: unused */ static int liquidio_vf_probe(struct pci_dev *pdev, - const struct pci_device_id *ent __attribute__((unused))) + const struct pci_device_id __maybe_unused *ent) { struct octeon_device *oct_dev = NULL; @@ -416,8 +416,8 @@ liquidio_vf_probe(struct pci_dev *pdev, } /** - * \brief PCI FLR for each Octeon device. - * @param oct octeon device + * octeon_pci_flr - PCI FLR for each Octeon device. + * @oct: octeon device */ static void octeon_pci_flr(struct octeon_device *oct) { @@ -437,9 +437,8 @@ static void octeon_pci_flr(struct octeon_device *oct) } /** - *\brief Destroy resources associated with octeon device - * @param pdev PCI device structure - * @param ent unused + * octeon_destroy_resources - Destroy resources associated with octeon device + * @oct: octeon device */ static void octeon_destroy_resources(struct octeon_device *oct) { @@ -592,9 +591,9 @@ static void octeon_destroy_resources(struct octeon_device *oct) } /** - * \brief Send Rx control command - * @param lio per-network private data - * @param start_stop whether to start or stop + * send_rx_ctrl_cmd - Send Rx control command + * @lio: per-network private data + * @start_stop: whether to start or stop */ static void send_rx_ctrl_cmd(struct lio *lio, int start_stop) { @@ -644,9 +643,9 @@ static void send_rx_ctrl_cmd(struct lio *lio, int start_stop) } /** - * \brief Destroy NIC device interface - * @param oct octeon device - * @param ifidx which interface to destroy + * liquidio_destroy_nic_device - Destroy NIC device interface + * @oct: octeon device + * @ifidx: which interface to destroy * * Cleanup associated with each interface for an Octeon device when NIC * module is being unloaded or if initialization fails during load. @@ -704,8 +703,8 @@ static void liquidio_destroy_nic_device(struct octeon_device *oct, int ifidx) } /** - * \brief Stop complete NIC functionality - * @param oct octeon device + * liquidio_stop_nic_module - Stop complete NIC functionality + * @oct: octeon device */ static int liquidio_stop_nic_module(struct octeon_device *oct) { @@ -737,8 +736,8 @@ static int liquidio_stop_nic_module(struct octeon_device *oct) } /** - * \brief Cleans up resources at unload time - * @param pdev PCI device structure + * liquidio_vf_remove - Cleans up resources at unload time + * @pdev: PCI device structure */ static void liquidio_vf_remove(struct pci_dev *pdev) { @@ -763,8 +762,8 @@ static void liquidio_vf_remove(struct pci_dev *pdev) } /** - * \brief PCI initialization for each Octeon device. - * @param oct octeon device + * octeon_pci_os_setup - PCI initialization for each Octeon device. + * @oct: octeon device */ static int octeon_pci_os_setup(struct octeon_device *oct) { @@ -792,8 +791,8 @@ static int octeon_pci_os_setup(struct octeon_device *oct) } /** - * \brief Unmap and free network buffer - * @param buf buffer + * free_netbuf - Unmap and free network buffer + * @buf: buffer */ static void free_netbuf(void *buf) { @@ -812,8 +811,8 @@ static void free_netbuf(void *buf) } /** - * \brief Unmap and free gather buffer - * @param buf buffer + * free_netsgbuf - Unmap and free gather buffer + * @buf: buffer */ static void free_netsgbuf(void *buf) { @@ -853,8 +852,8 @@ static void free_netsgbuf(void *buf) } /** - * \brief Unmap and free gather buffer with response - * @param buf buffer + * free_netsgbuf_with_resp - Unmap and free gather buffer with response + * @buf: buffer */ static void free_netsgbuf_with_resp(void *buf) { @@ -897,8 +896,8 @@ static void free_netsgbuf_with_resp(void *buf) } /** - * \brief Net device open for LiquidIO - * @param netdev network device + * liquidio_open - Net device open for LiquidIO + * @netdev: network device */ static int liquidio_open(struct net_device *netdev) { @@ -941,8 +940,8 @@ static int liquidio_open(struct net_device *netdev) } /** - * \brief Net device stop for LiquidIO - * @param netdev network device + * liquidio_stop - jNet device stop for LiquidIO + * @netdev: network device */ static int liquidio_stop(struct net_device *netdev) { @@ -991,8 +990,8 @@ static int liquidio_stop(struct net_device *netdev) } /** - * \brief Converts a mask based on net device flags - * @param netdev network device + * get_new_flags - Converts a mask based on net device flags + * @netdev: network device * * This routine generates a octnet_ifflags mask from the net device flags * received from the OS. @@ -1060,8 +1059,8 @@ static void liquidio_set_uc_list(struct net_device *netdev) } /** - * \brief Net device set_multicast_list - * @param netdev network device + * liquidio_set_mcast_list - Net device set_multicast_list + * @netdev: network device */ static void liquidio_set_mcast_list(struct net_device *netdev) { @@ -1110,8 +1109,9 @@ static void liquidio_set_mcast_list(struct net_device *netdev) } /** - * \brief Net device set_mac_address - * @param netdev network device + * liquidio_set_mac - Net device set_mac_address + * @netdev: network device + * @p: opaque pointer to sockaddr */ static int liquidio_set_mac(struct net_device *netdev, void *p) { @@ -1229,10 +1229,9 @@ liquidio_get_stats64(struct net_device *netdev, } /** - * \brief Handler for SIOCSHWTSTAMP ioctl - * @param netdev network device - * @param ifr interface request - * @param cmd command + * hwtstamp_ioctl - Handler for SIOCSHWTSTAMP ioctl + * @netdev: network device + * @ifr: interface request */ static int hwtstamp_ioctl(struct net_device *netdev, struct ifreq *ifr) { @@ -1287,10 +1286,10 @@ static int hwtstamp_ioctl(struct net_device *netdev, struct ifreq *ifr) } /** - * \brief ioctl handler - * @param netdev network device - * @param ifr interface request - * @param cmd command + * liquidio_ioctl - ioctl handler + * @netdev: network device + * @ifr: interface request + * @cmd: command */ static int liquidio_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd) { @@ -1339,10 +1338,10 @@ static void handle_timestamp(struct octeon_device *oct, u32 status, void *buf) tx_buffer_free(skb); } -/* \brief Send a data packet that will be timestamped - * @param oct octeon device - * @param ndata pointer to network data - * @param finfo pointer to private network data +/* send_nic_timestamp_pkt - Send a data packet that will be timestamped + * @oct: octeon device + * @ndata: pointer to network data + * @finfo: pointer to private network data */ static int send_nic_timestamp_pkt(struct octeon_device *oct, struct octnic_data_pkt *ndata, @@ -1393,9 +1392,10 @@ static int send_nic_timestamp_pkt(struct octeon_device *oct, return retval; } -/** \brief Transmit networks packets to the Octeon interface - * @param skbuff skbuff struct to be passed to network layer. - * @param netdev pointer to network device +/** + * liquidio_xmit - Transmit networks packets to the Octeon interface + * @skb: skbuff struct to be passed to network layer. + * @netdev: pointer to network device * @returns whether the packet was transmitted to the device okay or not * (NETDEV_TX_OK or NETDEV_TX_BUSY) */ @@ -1623,8 +1623,10 @@ static netdev_tx_t liquidio_xmit(struct sk_buff *skb, struct net_device *netdev) return NETDEV_TX_OK; } -/** \brief Network device Tx timeout - * @param netdev pointer to network device +/** + * liquidio_tx_timeout - Network device Tx timeout + * @netdev: pointer to network device + * @txqueue: index of the hung transmit queue */ static void liquidio_tx_timeout(struct net_device *netdev, unsigned int txqueue) { @@ -1917,8 +1919,8 @@ static int lio_nic_info(struct octeon_recv_info *recv_info, void *buf) } /** - * \brief Setup network interfaces - * @param octeon_dev octeon device + * setup_nic_devices - Setup network interfaces + * @octeon_dev: octeon device * * Called during init time for each device. It assumes the NIC * is already up and running. The link information for each @@ -2229,8 +2231,8 @@ static int setup_nic_devices(struct octeon_device *octeon_dev) } /** - * \brief initialize the NIC - * @param oct octeon device + * liquidio_init_nic_module - initialize the NIC + * @oct: octeon device * * This initialization routine is called once the Octeon device application is * up and running @@ -2270,8 +2272,8 @@ static int liquidio_init_nic_module(struct octeon_device *oct) } /** - * \brief Device initialization for each Octeon device that is probed - * @param octeon_dev octeon device + * octeon_device_init - Device initialization for each Octeon device that is probed + * @oct: octeon device */ static int octeon_device_init(struct octeon_device *oct) { diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_console.c b/drivers/net/ethernet/cavium/liquidio/octeon_console.c index 0d2831d10f65..28feabec8fbb 100644 --- a/drivers/net/ethernet/cavium/liquidio/octeon_console.c +++ b/drivers/net/ethernet/cavium/liquidio/octeon_console.c @@ -15,7 +15,7 @@ * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE, TITLE, or * NONINFRINGEMENT. See the GNU General Public License for more details. ***********************************************************************/ -/** +/* * @file octeon_console.c */ #include <linux/moduleparam.h> @@ -131,7 +131,7 @@ struct octeon_pci_console_desc { /* Implicit storage for console_addr_array */ }; -/** +/* * This function is the implementation of the get macros defined * for individual structure members. The argument are generated * by the macros inorder to read only the needed memory. @@ -160,7 +160,7 @@ static inline u64 __cvmx_bootmem_desc_get(struct octeon_device *oct, } } -/** +/* * This function retrieves the string name of a named block. It is * more complicated than a simple memcpy() since the named block * descriptor may not be directly accessible. @@ -182,7 +182,7 @@ static void CVMX_BOOTMEM_NAMED_GET_NAME(struct octeon_device *oct, /* See header file for descriptions of functions */ -/** +/* * Check the version information on the bootmem descriptor * * @param exact_match @@ -323,7 +323,7 @@ static u64 cvmx_bootmem_phy_named_block_find(struct octeon_device *oct, return result; } -/** +/* * Find a named block on the remote Octeon * * @param name Name of block to find @@ -707,7 +707,7 @@ int octeon_add_console(struct octeon_device *oct, u32 console_num, return ret; } -/** +/* * Removes all consoles * * @param oct octeon device diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_device.c b/drivers/net/ethernet/cavium/liquidio/octeon_device.c index 1db29ffde3e5..e506cbed30b1 100644 --- a/drivers/net/ethernet/cavium/liquidio/octeon_device.c +++ b/drivers/net/ethernet/cavium/liquidio/octeon_device.c @@ -1307,7 +1307,7 @@ struct octeon_config *octeon_get_conf(struct octeon_device *oct) /* scratch register address is same in all the OCT-II and CN70XX models */ #define CNXX_SLI_SCRATCH1 0x3C0 -/** Get the octeon device pointer. +/* Get the octeon device pointer. * @param octeon_id - The id for which the octeon device pointer is required. * @return Success: Octeon device pointer. * @return Failure: NULL. @@ -1410,7 +1410,7 @@ int octeon_wait_for_ddr_init(struct octeon_device *oct, u32 *timeout) return ret; } -/** Get the octeon id assigned to the octeon device passed as argument. +/* Get the octeon id assigned to the octeon device passed as argument. * This function is exported to other modules. * @param dev - octeon device pointer passed as a void *. * @return octeon device id diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_droq.c b/drivers/net/ethernet/cavium/liquidio/octeon_droq.c index cf4fe5b17f8a..d4080bddcb6b 100644 --- a/drivers/net/ethernet/cavium/liquidio/octeon_droq.c +++ b/drivers/net/ethernet/cavium/liquidio/octeon_droq.c @@ -774,7 +774,7 @@ octeon_droq_process_packets(struct octeon_device *oct, return 0; } -/** +/* * Utility function to poll for packets. check_hw_for_packets must be * called before calling this routine. */ diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_mailbox.c b/drivers/net/ethernet/cavium/liquidio/octeon_mailbox.c index 614d07be7181..ad685f5d0a13 100644 --- a/drivers/net/ethernet/cavium/liquidio/octeon_mailbox.c +++ b/drivers/net/ethernet/cavium/liquidio/octeon_mailbox.c @@ -28,7 +28,7 @@ /** * octeon_mbox_read: - * @oct: Pointer mailbox + * @mbox: Pointer mailbox * * Reads the 8-bytes of data from the mbox register * Writes back the acknowldgement inidcating completion of read @@ -285,7 +285,8 @@ static int octeon_mbox_process_cmd(struct octeon_mbox *mbox, } /** - *octeon_mbox_process_message: + * octeon_mbox_process_message + * @mbox: mailbox * * Process the received mbox message. */ diff --git a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c index 387c357e1b8e..6ed58bc12020 100644 --- a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c +++ b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c @@ -148,7 +148,7 @@ struct workqueue_struct *cxgb3_wq; /** * link_report - show link status and link speed/duplex - * @p: the port whose settings are to be reported + * @dev: the port whose settings are to be reported * * Shows the link status, speed, and duplex of a port. */ @@ -304,8 +304,8 @@ void t3_os_link_changed(struct adapter *adapter, int port_id, int link_stat, /** * t3_os_phymod_changed - handle PHY module changes - * @phy: the PHY reporting the module change - * @mod_type: new module type + * @adap: the adapter associated with the link change + * @port_id: the port index whose limk status has changed * * This is the OS-dependent handler for PHY module changes. It is * invoked when a PHY module is removed or inserted for any OS-specific @@ -1200,7 +1200,7 @@ static void cxgb_vlan_mode(struct net_device *dev, netdev_features_t features) /** * cxgb_up - enable the adapter - * @adapter: adapter being enabled + * @adap: adapter being enabled * * Called when the first port is enabled, this function performs the * actions necessary to make an adapter operational, such as completing diff --git a/drivers/net/ethernet/chelsio/cxgb3/sge.c b/drivers/net/ethernet/chelsio/cxgb3/sge.c index ee6188dea705..9f5526bfec83 100644 --- a/drivers/net/ethernet/chelsio/cxgb3/sge.c +++ b/drivers/net/ethernet/chelsio/cxgb3/sge.c @@ -372,7 +372,7 @@ static void clear_rx_desc(struct pci_dev *pdev, const struct sge_fl *q, /** * free_rx_bufs - free the Rx buffers on an SGE free list * @pdev: the PCI device associated with the adapter - * @rxq: the SGE free list to clean up + * @q: the SGE free list to clean up * * Release the buffers on an SGE free-buffer Rx queue. HW fetching from * this queue should be stopped before calling this function. @@ -493,7 +493,7 @@ static inline void ring_fl_db(struct adapter *adap, struct sge_fl *q) /** * refill_fl - refill an SGE free-buffer list - * @adapter: the adapter + * @adap: the adapter * @q: the free-list to refill * @n: the number of new buffers to allocate * @gfp: the gfp flags for allocating new buffers @@ -568,7 +568,7 @@ static inline void __refill_fl(struct adapter *adap, struct sge_fl *fl) /** * recycle_rx_buf - recycle a receive buffer - * @adapter: the adapter + * @adap: the adapter * @q: the SGE free list * @idx: index of buffer to recycle * @@ -825,6 +825,7 @@ static struct sk_buff *get_packet(struct adapter *adap, struct sge_fl *fl, * get_packet_pg - return the next ingress packet buffer from a free list * @adap: the adapter that received the packet * @fl: the SGE free list holding the packet + * @q: the queue * @len: the packet length including any SGE padding * @drop_thres: # of remaining buffers before we start dropping packets * @@ -1173,6 +1174,7 @@ static void write_wr_hdr_sgl(unsigned int ndesc, struct sk_buff *skb, * @q: the Tx queue * @ndesc: number of descriptors the packet will occupy * @compl: the value of the COMPL bit to use + * @addr: address * * Generate a TX_PKT work request to send the supplied packet. */ @@ -1516,7 +1518,7 @@ static int ctrl_xmit(struct adapter *adap, struct sge_txq *q, /** * restart_ctrlq - restart a suspended control queue - * @qs: the queue set cotaining the control queue + * @data: the queue set containing the control queue * * Resumes transmission on a suspended Tx control queue. */ @@ -1622,6 +1624,7 @@ static void setup_deferred_unmapping(struct sk_buff *skb, struct pci_dev *pdev, * @pidx: index of the first Tx descriptor to write * @gen: the generation value to use * @ndesc: number of descriptors the packet will occupy + * @addr: the address * * Write an offload work request to send the supplied packet. The packet * data already carry the work request with most fields populated. @@ -1733,7 +1736,7 @@ again: reclaim_completed_tx(adap, q, TX_RECLAIM_CHUNK); /** * restart_offloadq - restart a suspended offload queue - * @qs: the queue set cotaining the offload queue + * @data: the queue set cotaining the offload queue * * Resumes transmission on a suspended Tx offload queue. */ @@ -1883,7 +1886,7 @@ static inline void deliver_partial_bundle(struct t3cdev *tdev, /** * ofld_poll - NAPI handler for offload packets in interrupt mode - * @dev: the network device doing the polling + * @napi: the network device doing the polling * @budget: polling budget * * The NAPI handler for offload packets when a response queue is serviced @@ -2007,7 +2010,7 @@ static void restart_tx(struct sge_qset *qs) /** * cxgb3_arp_process - process an ARP request probing a private IP address - * @adapter: the adapter + * @pi: the port info * @skb: the skbuff containing the ARP request * * Check if the ARP request is probing the private IP address @@ -2069,7 +2072,8 @@ static void cxgb3_process_iscsi_prov_pack(struct port_info *pi, * @adap: the adapter * @rq: the response queue that received the packet * @skb: the packet - * @pad: amount of padding at the start of the buffer + * @pad: padding + * @lro: large receive offload * * Process an ingress ethernet pakcet and deliver it to the stack. * The padding is 2 if the packet was delivered in an Rx buffer and 0 @@ -2239,7 +2243,7 @@ static inline void handle_rsp_cntrl_info(struct sge_qset *qs, u32 flags) /** * check_ring_db - check if we need to ring any doorbells - * @adapter: the adapter + * @adap: the adapter * @qs: the queue set whose Tx queues are to be examined * @sleeping: indicates which Tx queue sent GTS * @@ -2899,7 +2903,7 @@ void t3_sge_err_intr_handler(struct adapter *adapter) /** * sge_timer_tx - perform periodic maintenance of an SGE qset - * @data: the SGE queue set to maintain + * @t: a timer list containing the SGE queue set to maintain * * Runs periodically from a timer to perform maintenance of an SGE queue * set. It performs two tasks: @@ -2943,7 +2947,7 @@ static void sge_timer_tx(struct timer_list *t) /** * sge_timer_rx - perform periodic maintenance of an SGE qset - * @data: the SGE queue set to maintain + * @t: the timer list containing the SGE queue set to maintain * * a) Replenishes Rx queues that have run out due to memory shortage. * Normally new Rx buffers are added when existing ones are consumed but @@ -3021,7 +3025,7 @@ void t3_update_qset_coalesce(struct sge_qset *qs, const struct qset_params *p) * @irq_vec_idx: the IRQ vector index for response queue interrupts * @p: configuration parameters for this queue set * @ntxq: number of Tx queues for the queue set - * @netdev: net device associated with this queue set + * @dev: net device associated with this queue set * @netdevq: net device TX queue associated with this queue set * * Allocate resources and initialize an SGE queue set. A queue set diff --git a/drivers/net/ethernet/chelsio/cxgb3/t3_hw.c b/drivers/net/ethernet/chelsio/cxgb3/t3_hw.c index 311fed38c101..7ff31d1026fb 100644 --- a/drivers/net/ethernet/chelsio/cxgb3/t3_hw.c +++ b/drivers/net/ethernet/chelsio/cxgb3/t3_hw.c @@ -2484,6 +2484,7 @@ int t3_sge_disable_cqcntxt(struct adapter *adapter, unsigned int id) * @adapter: the adapter * @id: the context id * @op: the operation to perform + * @credits: credit value to write * * Perform the selected operation on an SGE completion queue context. * The caller is responsible for ensuring only one context operation @@ -2885,7 +2886,7 @@ static void init_cong_ctrl(unsigned short *a, unsigned short *b) * t3_load_mtus - write the MTU and congestion control HW tables * @adap: the adapter * @mtus: the unrestricted values for the MTU table - * @alphs: the values for the congestion control alpha parameter + * @alpha: the values for the congestion control alpha parameter * @beta: the values for the congestion control beta parameter * @mtu_cap: the maximum permitted effective MTU * @@ -3483,7 +3484,7 @@ static void get_pci_mode(struct adapter *adapter, struct pci_params *p) /** * init_link_config - initialize a link's SW state * @lc: structure holding the link state - * @ai: information about the current card + * @caps: information about the current card * * Initializes the SW state maintained for each link, including the link's * capabilities and default speed/duplex/flow-control/autonegotiation diff --git a/drivers/net/ethernet/cisco/enic/enic_api.c b/drivers/net/ethernet/cisco/enic/enic_api.c index b161f24522b8..89915681473c 100644 --- a/drivers/net/ethernet/cisco/enic/enic_api.c +++ b/drivers/net/ethernet/cisco/enic/enic_api.c @@ -1,4 +1,4 @@ -/** +/* * Copyright 2013 Cisco Systems, Inc. All rights reserved. * * This program is free software; you may redistribute it and/or modify diff --git a/drivers/net/ethernet/cisco/enic/enic_ethtool.c b/drivers/net/ethernet/cisco/enic/enic_ethtool.c index 4d8e0aa447fb..a4dd52bba2c3 100644 --- a/drivers/net/ethernet/cisco/enic/enic_ethtool.c +++ b/drivers/net/ethernet/cisco/enic/enic_ethtool.c @@ -1,4 +1,4 @@ -/** +/* * Copyright 2013 Cisco Systems, Inc. All rights reserved. * * This program is free software; you may redistribute it and/or modify diff --git a/drivers/net/ethernet/cortina/gemini.c b/drivers/net/ethernet/cortina/gemini.c index 07e9dee03c98..8df6f081f244 100644 --- a/drivers/net/ethernet/cortina/gemini.c +++ b/drivers/net/ethernet/cortina/gemini.c @@ -85,6 +85,8 @@ MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)"); /** * struct gmac_queue_page - page buffer per-page info + * @page: the page struct + * @mapping: the dma address handle */ struct gmac_queue_page { struct page *page; diff --git a/drivers/net/ethernet/ethoc.c b/drivers/net/ethernet/ethoc.c index a817ca661c1f..0981fe9652e5 100644 --- a/drivers/net/ethernet/ethoc.c +++ b/drivers/net/ethernet/ethoc.c @@ -177,6 +177,7 @@ MODULE_PARM_DESC(buffer_size, "DMA buffer allocation size"); * struct ethoc - driver-private device structure * @iobase: pointer to I/O memory region * @membase: pointer to buffer memory region + * @big_endian: just big or little (endian) * @num_bd: number of buffer descriptors * @num_tx: number of send buffers * @cur_tx: last send buffer written @@ -189,7 +190,10 @@ MODULE_PARM_DESC(buffer_size, "DMA buffer allocation size"); * @msg_enable: device state flags * @lock: device lock * @mdio: MDIO bus for PHY access + * @clk: clock * @phy_id: address of attached PHY + * @old_link: previous link info + * @old_duplex: previous duplex info */ struct ethoc { void __iomem *iobase; @@ -1015,7 +1019,7 @@ static const struct net_device_ops ethoc_netdev_ops = { /** * ethoc_probe - initialize OpenCores ethernet MAC - * pdev: platform device + * @pdev: platform device */ static int ethoc_probe(struct platform_device *pdev) { diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c index ceaf76158e23..03b3b4287fe8 100644 --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c @@ -1194,7 +1194,7 @@ static int dpaa2_eth_seed_pool(struct dpaa2_eth_priv *priv, u16 bpid) return 0; } -/** +/* * Drain the specified number of buffers from the DPNI's private buffer pool. * @count must not exceeed DPAA2_ETH_BUFS_PER_CMD */ diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/ethernet/freescale/fec_ptp.c index 0405a3975f3f..2e344aada4c6 100644 --- a/drivers/net/ethernet/freescale/fec_ptp.c +++ b/drivers/net/ethernet/freescale/fec_ptp.c @@ -512,7 +512,7 @@ int fec_ptp_get(struct net_device *ndev, struct ifreq *ifr) -EFAULT : 0; } -/** +/* * fec_time_keep - call timecounter_read every second to avoid timer overrun * because ENET just support 32bit counter, will timeout in 4s */ @@ -566,7 +566,8 @@ static irqreturn_t fec_pps_interrupt(int irq, void *dev_id) /** * fec_ptp_init - * @ndev: The FEC network adapter + * @pdev: The FEC network adapter + * @irq_idx: the interrupt index * * This function performs the required steps for enabling ptp * support. If ptp support has already been loaded it simply calls the diff --git a/drivers/net/ethernet/freescale/fman/fman.c b/drivers/net/ethernet/freescale/fman/fman.c index ef67e8599b39..ce0a121580f6 100644 --- a/drivers/net/ethernet/freescale/fman/fman.c +++ b/drivers/net/ethernet/freescale/fman/fman.c @@ -2063,11 +2063,11 @@ static int fman_set_exception(struct fman *fman, /** * fman_register_intr * @fman: A Pointer to FMan device - * @mod: Calling module + * @module: Calling module * @mod_id: Module id (if more than 1 exists, '0' if not) * @intr_type: Interrupt type (error/normal) selection. - * @f_isr: The interrupt service routine. - * @h_src_arg: Argument to be passed to f_isr. + * @isr_cb: The interrupt service routine. + * @src_arg: Argument to be passed to isr_cb. * * Used to register an event handler to be processed by FMan * @@ -2091,7 +2091,7 @@ EXPORT_SYMBOL(fman_register_intr); /** * fman_unregister_intr * @fman: A Pointer to FMan device - * @mod: Calling module + * @module: Calling module * @mod_id: Module id (if more than 1 exists, '0' if not) * @intr_type: Interrupt type (error/normal) selection. * @@ -2342,8 +2342,8 @@ EXPORT_SYMBOL(fman_get_bmi_max_fifo_size); /** * fman_get_revision - * @fman - Pointer to the FMan module - * @rev_info - A structure of revision information parameters. + * @fman: - Pointer to the FMan module + * @rev_info: - A structure of revision information parameters. * * Returns the FM revision * @@ -2508,7 +2508,7 @@ EXPORT_SYMBOL(fman_get_rx_extra_headroom); /** * fman_bind - * @dev: FMan OF device pointer + * @fm_dev: FMan OF device pointer * * Bind to a specific FMan device. * diff --git a/drivers/net/ethernet/freescale/fman/fman_muram.c b/drivers/net/ethernet/freescale/fman/fman_muram.c index 5ec94d243da0..7ad317e622bc 100644 --- a/drivers/net/ethernet/freescale/fman/fman_muram.c +++ b/drivers/net/ethernet/freescale/fman/fman_muram.c @@ -144,9 +144,9 @@ unsigned long fman_muram_alloc(struct muram_info *muram, size_t size) /** * fman_muram_free_mem - * muram: FM-MURAM module pointer. - * offset: offset of the memory region to be freed. - * size: size of the memory to be freed. + * @muram: FM-MURAM module pointer. + * @offset: offset of the memory region to be freed. + * @size: size of the memory to be freed. * * Free an allocated memory from FM-MURAM partition. */ diff --git a/drivers/net/ethernet/freescale/fman/fman_port.c b/drivers/net/ethernet/freescale/fman/fman_port.c index 624b2eb6f01d..d9baac0dbc7d 100644 --- a/drivers/net/ethernet/freescale/fman/fman_port.c +++ b/drivers/net/ethernet/freescale/fman/fman_port.c @@ -1410,9 +1410,11 @@ int fman_port_config(struct fman_port *port, struct fman_port_params *params) } EXPORT_SYMBOL(fman_port_config); -/** +/* * fman_port_use_kg_hash - * port: A pointer to a FM Port module. + * @port: A pointer to a FM Port module. + * @enable: enable or disable + * * Sets the HW KeyGen or the BMI as HW Parser next engine, enabling * or bypassing the KeyGen hashing of Rx traffic */ @@ -1430,7 +1432,8 @@ EXPORT_SYMBOL(fman_port_use_kg_hash); /** * fman_port_init - * port: A pointer to a FM Port module. + * @port: A pointer to a FM Port module. + * * Initializes the FM PORT module by defining the software structure and * configuring the hardware registers. * @@ -1524,8 +1527,8 @@ EXPORT_SYMBOL(fman_port_init); /** * fman_port_cfg_buf_prefix_content - * @port A pointer to a FM Port module. - * @buffer_prefix_content A structure of parameters describing + * @port: A pointer to a FM Port module. + * @buffer_prefix_content: A structure of parameters describing * the structure of the buffer. * Out parameter: * Start margin - offset of data from @@ -1570,7 +1573,7 @@ EXPORT_SYMBOL(fman_port_cfg_buf_prefix_content); /** * fman_port_disable - * port: A pointer to a FM Port module. + * @port: A pointer to a FM Port module. * * Gracefully disable an FM port. The port will not start new tasks after all * tasks associated with the port are terminated. @@ -1651,7 +1654,7 @@ EXPORT_SYMBOL(fman_port_disable); /** * fman_port_enable - * port: A pointer to a FM Port module. + * @port: A pointer to a FM Port module. * * A runtime routine provided to allow disable/enable of port. * @@ -1697,7 +1700,7 @@ EXPORT_SYMBOL(fman_port_enable); /** * fman_port_bind - * dev: FMan Port OF device pointer + * @dev: FMan Port OF device pointer * * Bind to a specific FMan Port. * @@ -1713,7 +1716,7 @@ EXPORT_SYMBOL(fman_port_bind); /** * fman_port_get_qman_channel_id - * port: Pointer to the FMan port devuce + * @port: Pointer to the FMan port devuce * * Get the QMan channel ID for the specific port * @@ -1727,7 +1730,7 @@ EXPORT_SYMBOL(fman_port_get_qman_channel_id); /** * fman_port_get_device - * port: Pointer to the FMan port device + * @port: Pointer to the FMan port device * * Get the 'struct device' associated to the specified FMan port device * diff --git a/drivers/net/ethernet/freescale/fman/mac.c b/drivers/net/ethernet/freescale/fman/mac.c index 43427c5b9396..901749a7a318 100644 --- a/drivers/net/ethernet/freescale/fman/mac.c +++ b/drivers/net/ethernet/freescale/fman/mac.c @@ -359,8 +359,8 @@ EXPORT_SYMBOL(fman_set_mac_active_pause); /** * fman_get_pause_cfg * @mac_dev: A pointer to the MAC device - * @rx: Return value for RX setting - * @tx: Return value for TX setting + * @rx_pause: Return value for RX setting + * @tx_pause: Return value for TX setting * * Determine the MAC RX/TX PAUSE frames settings based on PHY * autonegotiation or values set by eththool. diff --git a/drivers/net/ethernet/hisilicon/hns/hnae.c b/drivers/net/ethernet/hisilicon/hns/hnae.c index e017b7c34140..00fafc0f8512 100644 --- a/drivers/net/ethernet/hisilicon/hns/hnae.c +++ b/drivers/net/ethernet/hisilicon/hns/hnae.c @@ -270,7 +270,7 @@ static void hnae_fini_queue(struct hnae_queue *q) hnae_fini_ring(&q->rx_ring); } -/** +/* * ae_chain - define ae chain head */ static RAW_NOTIFIER_HEAD(ae_chain); diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c index 9a907947ba19..4a448138b4ec 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c @@ -374,11 +374,12 @@ static void hns_mac_param_get(struct mac_params *param, } /** - *hns_mac_queue_config_bc_en - set broadcast rx&tx enable - *@mac_cb: mac device - *@queue: queue number - *@en:enable - *retuen 0 - success , negative --fail + * hns_mac_queue_config_bc_en - set broadcast rx&tx enable + * @mac_cb: mac device + * @port_num: queue number + * @vlan_id: vlan id` + * @enable: enable + * return 0 - success , negative --fail */ static int hns_mac_port_config_bc_en(struct hns_mac_cb *mac_cb, u32 port_num, u16 vlan_id, bool enable) @@ -408,11 +409,11 @@ static int hns_mac_port_config_bc_en(struct hns_mac_cb *mac_cb, } /** - *hns_mac_vm_config_bc_en - set broadcast rx&tx enable - *@mac_cb: mac device - *@vmid: vm id - *@en:enable - *retuen 0 - success , negative --fail + * hns_mac_vm_config_bc_en - set broadcast rx&tx enable + * @mac_cb: mac device + * @vmid: vm id + * @enable: enable + * return 0 - success , negative --fail */ int hns_mac_vm_config_bc_en(struct hns_mac_cb *mac_cb, u32 vmid, bool enable) { @@ -542,8 +543,8 @@ void hns_mac_stop(struct hns_mac_cb *mac_cb) /** * hns_mac_get_autoneg - get auto autonegotiation * @mac_cb: mac control block - * @enable: enable or not - * retuen 0 - success , negative --fail + * @auto_neg: output pointer to autoneg result + * return 0 - success , negative --fail */ void hns_mac_get_autoneg(struct hns_mac_cb *mac_cb, u32 *auto_neg) { @@ -560,7 +561,7 @@ void hns_mac_get_autoneg(struct hns_mac_cb *mac_cb, u32 *auto_neg) * @mac_cb: mac control block * @rx_en: rx enable status * @tx_en: tx enable status - * retuen 0 - success , negative --fail + * return 0 - success , negative --fail */ void hns_mac_get_pauseparam(struct hns_mac_cb *mac_cb, u32 *rx_en, u32 *tx_en) { @@ -578,7 +579,7 @@ void hns_mac_get_pauseparam(struct hns_mac_cb *mac_cb, u32 *rx_en, u32 *tx_en) * hns_mac_set_autoneg - set auto autonegotiation * @mac_cb: mac control block * @enable: enable or not - * retuen 0 - success , negative --fail + * return 0 - success , negative --fail */ int hns_mac_set_autoneg(struct hns_mac_cb *mac_cb, u8 enable) { @@ -623,7 +624,7 @@ int hns_mac_set_pauseparam(struct hns_mac_cb *mac_cb, u32 rx_en, u32 tx_en) /** * hns_mac_init_ex - mac init * @mac_cb: mac control block - * retuen 0 - success , negative --fail + * return 0 - success , negative --fail */ static int hns_mac_init_ex(struct hns_mac_cb *mac_cb) { @@ -800,7 +801,6 @@ static const struct { /** *hns_mac_get_info - get mac information from device node *@mac_cb: mac device - *@np:device node * return: 0 --success, negative --fail */ static int hns_mac_get_info(struct hns_mac_cb *mac_cb) @@ -951,7 +951,7 @@ static int hns_mac_get_info(struct hns_mac_cb *mac_cb) /** * hns_mac_get_mode - get mac mode * @phy_if: phy interface - * retuen 0 - gmac, 1 - xgmac , negative --fail + * return 0 - gmac, 1 - xgmac , negative --fail */ static int hns_mac_get_mode(phy_interface_t phy_if) { diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c index acfa86e5296f..87d3db4666df 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c @@ -207,7 +207,7 @@ static int hns_dsaf_get_cfg(struct dsaf_device *dsaf_dev) /** * hns_dsaf_sbm_link_sram_init_en - config dsaf_sbm_init_en - * @dsaf_id: dsa fabric id + * @dsaf_dev: dsa fabric id */ static void hns_dsaf_sbm_link_sram_init_en(struct dsaf_device *dsaf_dev) { @@ -216,8 +216,8 @@ static void hns_dsaf_sbm_link_sram_init_en(struct dsaf_device *dsaf_dev) /** * hns_dsaf_reg_cnt_clr_ce - config hns_dsaf_reg_cnt_clr_ce - * @dsaf_id: dsa fabric id - * @hns_dsaf_reg_cnt_clr_ce: config value + * @dsaf_dev: dsa fabric id + * @reg_cnt_clr_ce: config value */ static void hns_dsaf_reg_cnt_clr_ce(struct dsaf_device *dsaf_dev, u32 reg_cnt_clr_ce) @@ -228,8 +228,8 @@ hns_dsaf_reg_cnt_clr_ce(struct dsaf_device *dsaf_dev, u32 reg_cnt_clr_ce) /** * hns_ppe_qid_cfg - config ppe qid - * @dsaf_id: dsa fabric id - * @pppe_qid_cfg: value array + * @dsaf_dev: dsa fabric id + * @qid_cfg: value array */ static void hns_dsaf_ppe_qid_cfg(struct dsaf_device *dsaf_dev, u32 qid_cfg) @@ -285,8 +285,8 @@ static void hns_dsaf_inner_qid_cfg(struct dsaf_device *dsaf_dev) /** * hns_dsaf_sw_port_type_cfg - cfg sw type - * @dsaf_id: dsa fabric id - * @psw_port_type: array + * @dsaf_dev: dsa fabric id + * @port_type: array */ static void hns_dsaf_sw_port_type_cfg(struct dsaf_device *dsaf_dev, enum dsaf_sw_port_type port_type) @@ -303,8 +303,8 @@ static void hns_dsaf_sw_port_type_cfg(struct dsaf_device *dsaf_dev, /** * hns_dsaf_stp_port_type_cfg - cfg stp type - * @dsaf_id: dsa fabric id - * @pstp_port_type: array + * @dsaf_dev: dsa fabric id + * @port_type: array */ static void hns_dsaf_stp_port_type_cfg(struct dsaf_device *dsaf_dev, enum dsaf_stp_port_type port_type) @@ -323,7 +323,7 @@ static void hns_dsaf_stp_port_type_cfg(struct dsaf_device *dsaf_dev, (AE_IS_VER1((dev)->dsaf_ver) ? DSAF_SBM_NUM : DSAFV2_SBM_NUM) /** * hns_dsaf_sbm_cfg - config sbm - * @dsaf_id: dsa fabric id + * @dsaf_dev: dsa fabric id */ static void hns_dsaf_sbm_cfg(struct dsaf_device *dsaf_dev) { @@ -342,7 +342,7 @@ static void hns_dsaf_sbm_cfg(struct dsaf_device *dsaf_dev) /** * hns_dsaf_sbm_cfg_mib_en - config sbm - * @dsaf_id: dsa fabric id + * @dsaf_dev: dsa fabric id */ static int hns_dsaf_sbm_cfg_mib_en(struct dsaf_device *dsaf_dev) { @@ -387,7 +387,7 @@ static int hns_dsaf_sbm_cfg_mib_en(struct dsaf_device *dsaf_dev) /** * hns_dsaf_sbm_bp_wl_cfg - config sbm - * @dsaf_id: dsa fabric id + * @dsaf_dev: dsa fabric id */ static void hns_dsaf_sbm_bp_wl_cfg(struct dsaf_device *dsaf_dev) { @@ -556,7 +556,7 @@ static void hns_dsafv2_sbm_bp_wl_cfg(struct dsaf_device *dsaf_dev) /** * hns_dsaf_voq_bp_all_thrd_cfg - voq - * @dsaf_id: dsa fabric id + * @dsaf_dev: dsa fabric id */ static void hns_dsaf_voq_bp_all_thrd_cfg(struct dsaf_device *dsaf_dev) { @@ -599,7 +599,7 @@ static void hns_dsaf_tbl_tcam_match_cfg( /** * hns_dsaf_tbl_tcam_data_cfg - tbl - * @dsaf_id: dsa fabric id + * @dsaf_dev: dsa fabric id * @ptbl_tcam_data: addr */ static void hns_dsaf_tbl_tcam_data_cfg( @@ -614,8 +614,8 @@ static void hns_dsaf_tbl_tcam_data_cfg( /** * dsaf_tbl_tcam_mcast_cfg - tbl - * @dsaf_id: dsa fabric id - * @ptbl_tcam_mcast: addr + * @dsaf_dev: dsa fabric id + * @mcast: addr */ static void hns_dsaf_tbl_tcam_mcast_cfg( struct dsaf_device *dsaf_dev, @@ -648,8 +648,8 @@ static void hns_dsaf_tbl_tcam_mcast_cfg( /** * hns_dsaf_tbl_tcam_ucast_cfg - tbl - * @dsaf_id: dsa fabric id - * @ptbl_tcam_ucast: addr + * @dsaf_dev: dsa fabric id + * @tbl_tcam_ucast: addr */ static void hns_dsaf_tbl_tcam_ucast_cfg( struct dsaf_device *dsaf_dev, @@ -674,8 +674,8 @@ static void hns_dsaf_tbl_tcam_ucast_cfg( /** * hns_dsaf_tbl_line_cfg - tbl - * @dsaf_id: dsa fabric id - * @ptbl_lin: addr + * @dsaf_dev: dsa fabric id + * @tbl_lin: addr */ static void hns_dsaf_tbl_line_cfg(struct dsaf_device *dsaf_dev, struct dsaf_tbl_line_cfg *tbl_lin) @@ -695,7 +695,7 @@ static void hns_dsaf_tbl_line_cfg(struct dsaf_device *dsaf_dev, /** * hns_dsaf_tbl_tcam_mcast_pul - tbl - * @dsaf_id: dsa fabric id + * @dsaf_dev: dsa fabric id */ static void hns_dsaf_tbl_tcam_mcast_pul(struct dsaf_device *dsaf_dev) { @@ -710,7 +710,7 @@ static void hns_dsaf_tbl_tcam_mcast_pul(struct dsaf_device *dsaf_dev) /** * hns_dsaf_tbl_line_pul - tbl - * @dsaf_id: dsa fabric id + * @dsaf_dev: dsa fabric id */ static void hns_dsaf_tbl_line_pul(struct dsaf_device *dsaf_dev) { @@ -725,7 +725,7 @@ static void hns_dsaf_tbl_line_pul(struct dsaf_device *dsaf_dev) /** * hns_dsaf_tbl_tcam_data_mcast_pul - tbl - * @dsaf_id: dsa fabric id + * @dsaf_dev: dsa fabric id */ static void hns_dsaf_tbl_tcam_data_mcast_pul( struct dsaf_device *dsaf_dev) @@ -743,7 +743,7 @@ static void hns_dsaf_tbl_tcam_data_mcast_pul( /** * hns_dsaf_tbl_tcam_data_ucast_pul - tbl - * @dsaf_id: dsa fabric id + * @dsaf_dev: dsa fabric id */ static void hns_dsaf_tbl_tcam_data_ucast_pul( struct dsaf_device *dsaf_dev) @@ -768,8 +768,7 @@ void hns_dsaf_set_promisc_mode(struct dsaf_device *dsaf_dev, u32 en) /** * hns_dsaf_tbl_stat_en - tbl - * @dsaf_id: dsa fabric id - * @ptbl_stat_en: addr + * @dsaf_dev: dsa fabric id */ static void hns_dsaf_tbl_stat_en(struct dsaf_device *dsaf_dev) { @@ -785,7 +784,7 @@ static void hns_dsaf_tbl_stat_en(struct dsaf_device *dsaf_dev) /** * hns_dsaf_rocee_bp_en - rocee back press enable - * @dsaf_id: dsa fabric id + * @dsaf_dev: dsa fabric id */ static void hns_dsaf_rocee_bp_en(struct dsaf_device *dsaf_dev) { @@ -852,9 +851,9 @@ static void hns_dsaf_int_tbl_src_clr(struct dsaf_device *dsaf_dev, /** * hns_dsaf_single_line_tbl_cfg - INT - * @dsaf_id: dsa fabric id - * @address: - * @ptbl_line: + * @dsaf_dev: dsa fabric id + * @address: the address + * @ptbl_line: the line */ static void hns_dsaf_single_line_tbl_cfg( struct dsaf_device *dsaf_dev, @@ -876,9 +875,10 @@ static void hns_dsaf_single_line_tbl_cfg( /** * hns_dsaf_tcam_uc_cfg - INT - * @dsaf_id: dsa fabric id - * @address, - * @ptbl_tcam_data, + * @dsaf_dev: dsa fabric id + * @address: the address + * @ptbl_tcam_data: the data + * @ptbl_tcam_ucast: unicast */ static void hns_dsaf_tcam_uc_cfg( struct dsaf_device *dsaf_dev, u32 address, @@ -904,7 +904,8 @@ static void hns_dsaf_tcam_uc_cfg( * @dsaf_dev: dsa fabric device struct pointer * @address: tcam index * @ptbl_tcam_data: tcam data struct pointer - * @ptbl_tcam_mcast: tcam mask struct pointer, it must be null for HNSv1 + * @ptbl_tcam_mask: tcam mask struct pointer, it must be null for HNSv1 + * @ptbl_tcam_mcast: tcam data struct pointer */ static void hns_dsaf_tcam_mc_cfg( struct dsaf_device *dsaf_dev, u32 address, @@ -933,8 +934,10 @@ static void hns_dsaf_tcam_mc_cfg( /** * hns_dsaf_tcam_uc_cfg_vague - INT * @dsaf_dev: dsa fabric device struct pointer - * @address, - * @ptbl_tcam_data, + * @address: the address + * @tcam_data: the data + * @tcam_mask: the mask + * @tcam_uc: the unicast data */ static void hns_dsaf_tcam_uc_cfg_vague(struct dsaf_device *dsaf_dev, u32 address, @@ -960,10 +963,10 @@ static void hns_dsaf_tcam_uc_cfg_vague(struct dsaf_device *dsaf_dev, /** * hns_dsaf_tcam_mc_cfg_vague - INT * @dsaf_dev: dsa fabric device struct pointer - * @address, - * @ptbl_tcam_data, - * @ptbl_tcam_mask - * @ptbl_tcam_mcast + * @address: the address + * @tcam_data: the data + * @tcam_mask: the mask + * @tcam_mc: the multicast data */ static void hns_dsaf_tcam_mc_cfg_vague(struct dsaf_device *dsaf_dev, u32 address, @@ -988,8 +991,8 @@ static void hns_dsaf_tcam_mc_cfg_vague(struct dsaf_device *dsaf_dev, /** * hns_dsaf_tcam_mc_invld - INT - * @dsaf_id: dsa fabric id - * @address + * @dsaf_dev: dsa fabric id + * @address: the address */ static void hns_dsaf_tcam_mc_invld(struct dsaf_device *dsaf_dev, u32 address) { @@ -1024,10 +1027,10 @@ hns_dsaf_tcam_addr_get(struct dsaf_drv_tbl_tcam_key *mac_key, u8 *addr) /** * hns_dsaf_tcam_uc_get - INT - * @dsaf_id: dsa fabric id - * @address - * @ptbl_tcam_data - * @ptbl_tcam_ucast + * @dsaf_dev: dsa fabric id + * @address: the address + * @ptbl_tcam_data: the data + * @ptbl_tcam_ucast: unicast */ static void hns_dsaf_tcam_uc_get( struct dsaf_device *dsaf_dev, u32 address, @@ -1077,10 +1080,10 @@ static void hns_dsaf_tcam_uc_get( /** * hns_dsaf_tcam_mc_get - INT - * @dsaf_id: dsa fabric id - * @address - * @ptbl_tcam_data - * @ptbl_tcam_ucast + * @dsaf_dev: dsa fabric id + * @address: the address + * @ptbl_tcam_data: the data + * @ptbl_tcam_mcast: tcam multicast data */ static void hns_dsaf_tcam_mc_get( struct dsaf_device *dsaf_dev, u32 address, @@ -1127,7 +1130,7 @@ static void hns_dsaf_tcam_mc_get( /** * hns_dsaf_tbl_line_init - INT - * @dsaf_id: dsa fabric id + * @dsaf_dev: dsa fabric id */ static void hns_dsaf_tbl_line_init(struct dsaf_device *dsaf_dev) { @@ -1141,7 +1144,7 @@ static void hns_dsaf_tbl_line_init(struct dsaf_device *dsaf_dev) /** * hns_dsaf_tbl_tcam_init - INT - * @dsaf_id: dsa fabric id + * @dsaf_dev: dsa fabric id */ static void hns_dsaf_tbl_tcam_init(struct dsaf_device *dsaf_dev) { @@ -1156,7 +1159,9 @@ static void hns_dsaf_tbl_tcam_init(struct dsaf_device *dsaf_dev) /** * hns_dsaf_pfc_en_cfg - dsaf pfc pause cfg - * @mac_cb: mac contrl block + * @dsaf_dev: dsa fabric id + * @mac_id: mac contrl block + * @tc_en: traffic class */ static void hns_dsaf_pfc_en_cfg(struct dsaf_device *dsaf_dev, int mac_id, int tc_en) @@ -1209,8 +1214,7 @@ void hns_dsaf_get_rx_mac_pause_en(struct dsaf_device *dsaf_dev, int mac_id, /** * hns_dsaf_tbl_tcam_init - INT - * @dsaf_id: dsa fabric id - * @dsaf_mode + * @dsaf_dev: dsa fabric id */ static void hns_dsaf_comm_init(struct dsaf_device *dsaf_dev) { @@ -1263,7 +1267,7 @@ static void hns_dsaf_comm_init(struct dsaf_device *dsaf_dev) /** * hns_dsaf_inode_init - INT - * @dsaf_id: dsa fabric id + * @dsaf_dev: dsa fabric id */ static void hns_dsaf_inode_init(struct dsaf_device *dsaf_dev) { @@ -1315,7 +1319,7 @@ static void hns_dsaf_inode_init(struct dsaf_device *dsaf_dev) /** * hns_dsaf_sbm_init - INT - * @dsaf_id: dsa fabric id + * @dsaf_dev: dsa fabric id */ static int hns_dsaf_sbm_init(struct dsaf_device *dsaf_dev) { @@ -1369,7 +1373,7 @@ static int hns_dsaf_sbm_init(struct dsaf_device *dsaf_dev) /** * hns_dsaf_tbl_init - INT - * @dsaf_id: dsa fabric id + * @dsaf_dev: dsa fabric id */ static void hns_dsaf_tbl_init(struct dsaf_device *dsaf_dev) { @@ -1381,7 +1385,7 @@ static void hns_dsaf_tbl_init(struct dsaf_device *dsaf_dev) /** * hns_dsaf_voq_init - INT - * @dsaf_id: dsa fabric id + * @dsaf_dev: dsa fabric id */ static void hns_dsaf_voq_init(struct dsaf_device *dsaf_dev) { @@ -1435,7 +1439,7 @@ static void hns_dsaf_remove_hw(struct dsaf_device *dsaf_dev) /** * hns_dsaf_init - init dsa fabric * @dsaf_dev: dsa fabric device struct pointer - * retuen 0 - success , negative --fail + * return 0 - success , negative --fail */ static int hns_dsaf_init(struct dsaf_device *dsaf_dev) { @@ -2099,7 +2103,7 @@ static struct dsaf_device *hns_dsaf_alloc_dev(struct device *dev, /** * hns_dsaf_free_dev - free dev mem - * @dev: struct device pointer + * @dsaf_dev: struct device pointer */ static void hns_dsaf_free_dev(struct dsaf_device *dsaf_dev) { @@ -2108,9 +2112,9 @@ static void hns_dsaf_free_dev(struct dsaf_device *dsaf_dev) /** * dsaf_pfc_unit_cnt - set pfc unit count - * @dsaf_id: dsa fabric id - * @pport_rate: value array - * @pdsaf_pfc_unit_cnt: value array + * @dsaf_dev: dsa fabric id + * @mac_id: id in use + * @rate: value array */ static void hns_dsaf_pfc_unit_cnt(struct dsaf_device *dsaf_dev, int mac_id, enum dsaf_port_rate_mode rate) @@ -2139,8 +2143,9 @@ static void hns_dsaf_pfc_unit_cnt(struct dsaf_device *dsaf_dev, int mac_id, /** * dsaf_port_work_rate_cfg - fifo - * @dsaf_id: dsa fabric id - * @xge_ge_work_mode + * @dsaf_dev: dsa fabric id + * @mac_id: mac contrl block + * @rate_mode: value array */ static void hns_dsaf_port_work_rate_cfg(struct dsaf_device *dsaf_dev, int mac_id, @@ -2253,7 +2258,8 @@ void hns_dsaf_update_stats(struct dsaf_device *dsaf_dev, u32 node_num) /** *hns_dsaf_get_regs - dump dsaf regs - *@dsaf_dev: dsaf device + *@ddev: dsaf device + *@port: port *@data:data for value of regs */ void hns_dsaf_get_regs(struct dsaf_device *ddev, u32 port, void *data) @@ -2690,6 +2696,7 @@ void hns_dsaf_get_stats(struct dsaf_device *ddev, u64 *data, int port) /** *hns_dsaf_get_sset_count - get dsaf string set count + *@dsaf_dev: dsaf device *@stringset: type of values in data *return dsaf string name count */ @@ -2711,6 +2718,7 @@ int hns_dsaf_get_sset_count(struct dsaf_device *dsaf_dev, int stringset) *@stringset:srting set index *@data:strings name value *@port:port index + *@dsaf_dev: dsaf device */ void hns_dsaf_get_strings(int stringset, u8 *data, int port, struct dsaf_device *dsaf_dev) @@ -2943,7 +2951,7 @@ int hns_dsaf_wait_pkt_clean(struct dsaf_device *dsaf_dev, int port) /** * dsaf_probe - probo dsaf dev * @pdev: dasf platform device - * retuen 0 - success , negative --fail + * return 0 - success , negative --fail */ static int hns_dsaf_probe(struct platform_device *pdev) { @@ -3038,8 +3046,8 @@ module_platform_driver(g_dsaf_driver); /** * hns_dsaf_roce_reset - reset dsaf and roce * @dsaf_fwnode: Pointer to framework node for the dasf - * @enable: false - request reset , true - drop reset - * retuen 0 - success , negative -fail + * @dereset: false - request reset , true - drop reset + * return 0 - success , negative -fail */ int hns_dsaf_roce_reset(struct fwnode_handle *dsaf_fwnode, bool dereset) { diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c index ed3829ae4ef1..d5c5887aa468 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c @@ -330,11 +330,11 @@ static void hns_dsaf_xge_srst_by_port_acpi(struct dsaf_device *dsaf_dev, * hns_dsaf_srst_chns - reset dsaf channels * @dsaf_dev: dsaf device struct pointer * @msk: xbar channels mask value: + * @dereset: false - request reset , true - drop reset * bit0-5 for xge0-5 * bit6-11 for ppe0-5 * bit12-17 for roce0-5 * bit18-19 for com/dfx - * @enable: false - request reset , true - drop reset */ static void hns_dsaf_srst_chns(struct dsaf_device *dsaf_dev, u32 msk, bool dereset) @@ -353,11 +353,11 @@ hns_dsaf_srst_chns(struct dsaf_device *dsaf_dev, u32 msk, bool dereset) * hns_dsaf_srst_chns - reset dsaf channels * @dsaf_dev: dsaf device struct pointer * @msk: xbar channels mask value: + * @dereset: false - request reset , true - drop reset * bit0-5 for xge0-5 * bit6-11 for ppe0-5 * bit12-17 for roce0-5 * bit18-19 for com/dfx - * @enable: false - request reset , true - drop reset */ static void hns_dsaf_srst_chns_acpi(struct dsaf_device *dsaf_dev, u32 msk, bool dereset) @@ -612,7 +612,8 @@ static int hns_mac_get_sfp_prsnt_acpi(struct hns_mac_cb *mac_cb, int *sfp_prsnt) /** * hns_mac_config_sds_loopback - set loop back for serdes * @mac_cb: mac control block - * retuen 0 == success + * @en: enable or disable + * return 0 == success */ static int hns_mac_config_sds_loopback(struct hns_mac_cb *mac_cb, bool en) { diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c index 2b34b553acf3..d0f8b1fff333 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c @@ -66,8 +66,8 @@ hns_ppe_common_get_ioaddr(struct ppe_common_cb *ppe_common) /** * hns_ppe_common_get_cfg - get ppe common config * @dsaf_dev: dasf device - * comm_index: common index - * retuen 0 - success , negative --fail + * @comm_index: common index + * return 0 - success , negative --fail */ static int hns_ppe_common_get_cfg(struct dsaf_device *dsaf_dev, int comm_index) { @@ -143,7 +143,7 @@ static void hns_ppe_set_vlan_strip(struct hns_ppe_cb *ppe_cb, int en) /** * hns_ppe_checksum_hw - set ppe checksum caculate - * @ppe_device: ppe device + * @ppe_cb: ppe device * @value: value */ static void hns_ppe_checksum_hw(struct hns_ppe_cb *ppe_cb, u32 value) @@ -179,7 +179,7 @@ static void hns_ppe_set_qid(struct ppe_common_cb *ppe_common, u32 qid) /** * hns_ppe_set_port_mode - set port mode - * @ppe_device: ppe device + * @ppe_cb: ppe device * @mode: port mode */ static void hns_ppe_set_port_mode(struct hns_ppe_cb *ppe_cb, @@ -344,7 +344,7 @@ static void hns_ppe_init_hw(struct hns_ppe_cb *ppe_cb) /** * ppe_uninit_hw - uninit ppe - * @ppe_device: ppe device + * @ppe_cb: ppe device */ static void hns_ppe_uninit_hw(struct hns_ppe_cb *ppe_cb) { @@ -384,7 +384,8 @@ void hns_ppe_uninit(struct dsaf_device *dsaf_dev) /** * hns_ppe_reset - reinit ppe/rcb hw * @dsaf_dev: dasf device - * retuen void + * @ppe_common_index: the index + * return void */ void hns_ppe_reset_common(struct dsaf_device *dsaf_dev, u8 ppe_common_index) { @@ -455,7 +456,7 @@ int hns_ppe_get_regs_count(void) /** * ppe_get_strings - get ppe srting - * @ppe_device: ppe device + * @ppe_cb: ppe device * @stringset: string set type * @data: output string */ @@ -513,7 +514,7 @@ void hns_ppe_get_stats(struct hns_ppe_cb *ppe_cb, u64 *data) /** * hns_ppe_init - init ppe device * @dsaf_dev: dasf device - * retuen 0 - success , negative --fail + * return 0 - success , negative --fail */ int hns_ppe_init(struct dsaf_device *dsaf_dev) { diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c index 5453597ec629..b6c8910cf7ba 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c @@ -34,7 +34,7 @@ /** *hns_rcb_wait_fbd_clean - clean fbd *@qs: ring struct pointer array - *@qnum: num of array + *@q_num: num of array *@flag: tx or rx flag */ void hns_rcb_wait_fbd_clean(struct hnae_queue **qs, int q_num, u32 flag) @@ -191,7 +191,8 @@ void hns_rcbv2_int_clr_hw(struct hnae_queue *q, u32 flag) /** *hns_rcb_ring_enable_hw - enable ring - *@ring: rcb ring + *@q: rcb ring + *@val: value to write */ void hns_rcb_ring_enable_hw(struct hnae_queue *q, u32 val) { @@ -844,7 +845,7 @@ void hns_rcb_update_stats(struct hnae_queue *queue) /** *hns_rcb_get_stats - get rcb statistic - *@ring: rcb ring + *@queue: rcb ring *@data:statistic value */ void hns_rcb_get_stats(struct hnae_queue *queue, u64 *data) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c index d832cd018c1c..7e3609ce112a 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c @@ -242,7 +242,8 @@ static void hns_xgmac_config_pad_and_crc(void *mac_drv, u8 newval) /** *hns_xgmac_pausefrm_cfg - set pause param about xgmac *@mac_drv: mac driver - *@newval:enable of pad and crc + *@rx_en: enable receive + *@tx_en: enable transmit */ static void hns_xgmac_pausefrm_cfg(void *mac_drv, u32 rx_en, u32 tx_en) { diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c b/drivers/net/ethernet/hisilicon/hns/hns_enet.c index b658b9de81d7..b9fd4a716527 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_enet.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_enet.c @@ -751,6 +751,8 @@ static void hns_update_rx_rate(struct hnae_ring *ring) /** * smooth_alg - smoothing algrithm for adjusting coalesce parameter + * @new_param: new value + * @old_param: old value **/ static u32 smooth_alg(u32 new_param, u32 old_param) { @@ -1828,7 +1830,7 @@ static int hns_nic_uc_unsync(struct net_device *netdev, } /** - * nic_set_multicast_list - set mutl mac address + * hns_set_multicast_list - set mutl mac address * @ndev: net device * * return void diff --git a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c index 4eb50296f653..f067320d426b 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c @@ -462,9 +462,9 @@ static int __lb_clean_rings(struct hns_nic_priv *priv, } /** - * nic_run_loopback_test - run loopback test - * @nic_dev: net device - * @loopback_type: loopback type + * __lb_run_test - run loopback test + * @ndev: net device + * @loop_mode: loopback type */ static int __lb_run_test(struct net_device *ndev, enum hnae_loop loop_mode) @@ -572,7 +572,7 @@ static int __lb_down(struct net_device *ndev, enum hnae_loop loop) /** * hns_nic_self_test - self test - * @dev: net device + * @ndev: net device * @eth_test: test cmd * @data: test result */ @@ -633,7 +633,7 @@ static void hns_nic_self_test(struct net_device *ndev, /** * hns_nic_get_drvinfo - get net driver info - * @dev: net device + * @net_dev: net device * @drvinfo: driver info */ static void hns_nic_get_drvinfo(struct net_device *net_dev, @@ -658,7 +658,7 @@ static void hns_nic_get_drvinfo(struct net_device *net_dev, /** * hns_get_ringparam - get ring parameter - * @dev: net device + * @net_dev: net device * @param: ethtool parameter */ static void hns_get_ringparam(struct net_device *net_dev, @@ -683,7 +683,7 @@ static void hns_get_ringparam(struct net_device *net_dev, /** * hns_get_pauseparam - get pause parameter - * @dev: net device + * @net_dev: net device * @param: pause parameter */ static void hns_get_pauseparam(struct net_device *net_dev, @@ -701,7 +701,7 @@ static void hns_get_pauseparam(struct net_device *net_dev, /** * hns_set_pauseparam - set pause parameter - * @dev: net device + * @net_dev: net device * @param: pause parameter * * Return 0 on success, negative on failure @@ -725,7 +725,7 @@ static int hns_set_pauseparam(struct net_device *net_dev, /** * hns_get_coalesce - get coalesce info. - * @dev: net device + * @net_dev: net device * @ec: coalesce info. * * Return 0 on success, negative on failure. @@ -769,7 +769,7 @@ static int hns_get_coalesce(struct net_device *net_dev, /** * hns_set_coalesce - set coalesce info. - * @dev: net device + * @net_dev: net device * @ec: coalesce info. * * Return 0 on success, negative on failure. @@ -808,7 +808,7 @@ static int hns_set_coalesce(struct net_device *net_dev, /** * hns_get_channels - get channel info. - * @dev: net device + * @net_dev: net device * @ch: channel info. */ static void @@ -825,7 +825,7 @@ hns_get_channels(struct net_device *net_dev, struct ethtool_channels *ch) /** * get_ethtool_stats - get detail statistics. - * @dev: net device + * @netdev: net device * @stats: statistics info. * @data: statistics data. */ @@ -883,8 +883,8 @@ static void hns_get_ethtool_stats(struct net_device *netdev, /** * get_strings: Return a set of strings that describe the requested objects - * @dev: net device - * @stats: string set ID. + * @netdev: net device + * @stringset: string set ID. * @data: objects data. */ static void hns_get_strings(struct net_device *netdev, u32 stringset, u8 *data) @@ -971,8 +971,8 @@ static void hns_get_strings(struct net_device *netdev, u32 stringset, u8 *data) } /** - * nic_get_sset_count - get string set count witch returned by nic_get_strings. - * @dev: net device + * hns_get_sset_count - get string set count witch returned by nic_get_strings. + * @netdev: net device * @stringset: string set index, 0: self test string; 1: statistics string. * * Return string set count. @@ -1006,7 +1006,7 @@ static int hns_get_sset_count(struct net_device *netdev, int stringset) /** * hns_phy_led_set - set phy LED status. - * @dev: net device + * @netdev: net device * @value: LED state. * * Return 0 on success, negative on failure. @@ -1027,8 +1027,8 @@ static int hns_phy_led_set(struct net_device *netdev, int value) } /** - * nic_set_phys_id - set phy identify LED. - * @dev: net device + * hns_set_phys_id - set phy identify LED. + * @netdev: net device * @state: LED state. * * Return 0 on success, negative on failure. @@ -1104,9 +1104,9 @@ hns_set_phys_id(struct net_device *netdev, enum ethtool_phys_id_state state) /** * hns_get_regs - get net device register - * @dev: net device + * @net_dev: net device * @cmd: ethtool cmd - * @date: register data + * @data: register data */ static void hns_get_regs(struct net_device *net_dev, struct ethtool_regs *cmd, void *data) @@ -1125,8 +1125,8 @@ static void hns_get_regs(struct net_device *net_dev, struct ethtool_regs *cmd, } /** - * nic_get_regs_len - get total register len. - * @dev: net device + * hns_get_regs_len - get total register len. + * @net_dev: net device * * Return total register len. */ @@ -1151,7 +1151,7 @@ static int hns_get_regs_len(struct net_device *net_dev) /** * hns_nic_nway_reset - nway reset - * @dev: net device + * @netdev: net device * * Return 0 on success, negative on failure */ diff --git a/drivers/net/ethernet/hisilicon/hns_mdio.c b/drivers/net/ethernet/hisilicon/hns_mdio.c index 7df5d7d211d4..883d0d7c6858 100644 --- a/drivers/net/ethernet/hisilicon/hns_mdio.c +++ b/drivers/net/ethernet/hisilicon/hns_mdio.c @@ -210,7 +210,7 @@ static void hns_mdio_cmd_write(struct hns_mdio_device *mdio_dev, * @bus: mdio bus * @phy_id: phy id * @regnum: register num - * @value: register value + * @data: register value * * Return 0 on success, negative on failure */ @@ -273,7 +273,6 @@ static int hns_mdio_write(struct mii_bus *bus, * @bus: mdio bus * @phy_id: phy id * @regnum: register num - * @value: register value * * Return phy register value */ diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c b/drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c index e0eb294779ec..5a6bbee819cd 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c @@ -784,7 +784,7 @@ static void free_cmdq(struct hinic_cmdq *cmdq) * init_cmdqs_ctxt - write the cmdq ctxt to HW after init all cmdq * @hwdev: the NIC HW device * @cmdqs: cmdqs to write the ctxts for - * &db_area: db_area for all the cmdqs + * @db_area: db_area for all the cmdqs * * Return 0 - Success, negative - Failure **/ diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c b/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c index 239685152f6e..7f1a92a6c7ec 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c @@ -437,6 +437,8 @@ static int get_base_qpn(struct hinic_hwdev *hwdev, u16 *base_qpn) /** * hinic_hwdev_ifup - Preparing the HW for passing IO * @hwdev: the NIC HW device + * @sq_depth: send queue depth + * @rq_depth: receive queue depth * * Return 0 - Success, negative - Failure **/ @@ -582,6 +584,7 @@ void hinic_hwdev_cb_unregister(struct hinic_hwdev *hwdev, /** * nic_mgmt_msg_handler - nic mgmt event handler * @handle: private data for the handler + * @cmd: the command * @buf_in: input buffer * @in_size: input size * @buf_out: output buffer @@ -909,6 +912,7 @@ int hinic_set_interrupt_cfg(struct hinic_hwdev *hwdev, /** * hinic_init_hwdev - Initialize the NIC HW * @pdev: the NIC pci device + * @devlink: struct devlink * * Return initialized NIC HW device * @@ -1121,7 +1125,7 @@ int hinic_hwdev_msix_cnt_set(struct hinic_hwdev *hwdev, u16 msix_index) * @msix_index: msix_index * @pending_limit: the maximum pending interrupt events (unit 8) * @coalesc_timer: coalesc period for interrupt (unit 8 us) - * @lli_timer: replenishing period for low latency credit (unit 8 us) + * @lli_timer_cfg: replenishing period for low latency credit (unit 8 us) * @lli_credit_limit: maximum credits for low latency msix messages (unit 8) * @resend_timer: maximum wait for resending msix (unit coalesc period) * diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c b/drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c index b30733f4a59e..83296c7aab90 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c @@ -188,6 +188,7 @@ static u8 eq_cons_idx_checksum_set(u32 val) /** * eq_update_ci - update the HW cons idx of event queue * @eq: the event queue to update the cons idx for + * @arm_state: to arm or not **/ static void eq_update_ci(struct hinic_eq *eq, u32 arm_state) { diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_if.c b/drivers/net/ethernet/huawei/hinic/hinic_hw_if.c index bc8925c0c982..50f14e014656 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_hw_if.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_if.c @@ -230,6 +230,7 @@ static int wait_hwif_ready(struct hinic_hwif *hwif) * @hwif: the HW interface of a pci function device * @attr0: the first attribute that was read from the hw * @attr1: the second attribute that was read from the hw + * @attr2: the second attribute that was read from the hw **/ static void set_hwif_attr(struct hinic_hwif *hwif, u32 attr0, u32 attr1, u32 attr2) diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_mgmt.c b/drivers/net/ethernet/huawei/hinic/hinic_hw_mgmt.c index c6ce5966284c..b6d5a34325f4 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_hw_mgmt.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_mgmt.c @@ -234,6 +234,7 @@ static int send_msg_to_mgmt(struct hinic_pf_to_mgmt *pf_to_mgmt, * @out_size: response length * @direction: the direction of the original message * @resp_msg_id: msg id to response for + * @timeout: the timeout value * * Return 0 - Success, negative - Failure **/ diff --git a/drivers/net/ethernet/huawei/hinic/hinic_main.c b/drivers/net/ethernet/huawei/hinic/hinic_main.c index 797c55a1d9c6..8039bd329b3c 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_main.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_main.c @@ -961,7 +961,7 @@ static void hinic_refresh_nic_cfg(struct hinic_dev *nic_dev) * @handle: nic device for the handler * @buf_in: input buffer * @in_size: input size - * @buf_in: output buffer + * @buf_out: output buffer * @out_size: returned output size * * Return 0 - Success, negative - Failure diff --git a/drivers/net/ethernet/micrel/ksz884x.c b/drivers/net/ethernet/micrel/ksz884x.c index c84a1e8c918b..920722273059 100644 --- a/drivers/net/ethernet/micrel/ksz884x.c +++ b/drivers/net/ethernet/micrel/ksz884x.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/** +/* * drivers/net/ethernet/micrel/ksx884x.c - Micrel KSZ8841/2 PCI Ethernet driver * * Copyright (c) 2009-2010 Micrel, Inc. @@ -959,7 +959,7 @@ struct ksz_sw_desc { * struct ksz_dma_buf - OS dependent DMA buffer data structure * @skb: Associated socket buffer. * @dma: Associated physical DMA address. - * len: Actual len used. + * @len: Actual len used. */ struct ksz_dma_buf { struct sk_buff *skb; @@ -1254,6 +1254,7 @@ struct ksz_port_info { * @multi_list_size: Multicast address list size. * @enabled: Indication of hardware enabled. * @rx_stop: Indication of receive process stop. + * @reserved2: none * @features: Hardware features to enable. * @overrides: Hardware features to override. * @parent: Pointer to parent, network device private structure. @@ -1447,7 +1448,7 @@ struct dev_info { * struct dev_priv - Network device private data structure * @adapter: Adapter device information. * @port: Port information. - * @monitor_time_info: Timer to monitor ports. + * @monitor_timer_info: Timer to monitor ports. * @proc_sem: Semaphore for proc accessing. * @id: Device ID. * @mii_if: MII interface information. @@ -1566,6 +1567,7 @@ static inline void hw_restore_intr(struct ksz_hw *hw, uint interrupt) /** * hw_block_intr - block hardware interrupts + * @hw: The hardware instance. * * This function blocks all interrupts of the hardware and returns the current * interrupt enable mask so that interrupts can be restored later. @@ -1818,6 +1820,7 @@ static void port_r_mib_cnt(struct ksz_hw *hw, int port, u16 addr, u64 *cnt) * port_r_mib_pkt - read dropped packet counts * @hw: The hardware instance. * @port: The port index. + * @last: last one * @cnt: Buffer to store the receive and transmit dropped packet counts. * * This routine reads the dropped packet counts of the port. @@ -1971,7 +1974,7 @@ static void port_cfg(struct ksz_hw *hw, int port, int offset, u16 bits, * port_chk_shift - check port bit * @hw: The hardware instance. * @port: The port index. - * @offset: The offset of the register. + * @addr: The offset of the register. * @shift: Number of bits to shift. * * This function checks whether the specified port is set in the register or @@ -1993,7 +1996,7 @@ static int port_chk_shift(struct ksz_hw *hw, int port, u32 addr, int shift) * port_cfg_shift - set port bit * @hw: The hardware instance. * @port: The port index. - * @offset: The offset of the register. + * @addr: The offset of the register. * @shift: Number of bits to shift. * @set: The flag indicating whether the port is to be set or not. * @@ -4424,6 +4427,8 @@ static int ksz_alloc_desc(struct dev_info *adapter) /** * free_dma_buf - release DMA buffer resources * @adapter: Adapter information structure. + * @dma_buf: pointer to buf + * @direction: to or from device * * This routine is just a helper function to release the DMA buffer resources. */ @@ -4561,6 +4566,7 @@ static void ksz_free_desc(struct dev_info *adapter) * ksz_free_buffers - free buffers used in the descriptors * @adapter: Adapter information structure. * @desc_info: Descriptor information structure. + * @direction: to or from device * * This local routine frees buffers used in the DMA buffers. */ @@ -4720,7 +4726,8 @@ static void send_packet(struct sk_buff *skb, struct net_device *dev) /** * transmit_cleanup - clean up transmit descriptors - * @dev: Network device. + * @hw_priv: Network device. + * @normal: break if owned * * This routine is called to clean up the transmitted buffers. */ @@ -4776,7 +4783,7 @@ static void transmit_cleanup(struct dev_info *hw_priv, int normal) /** * transmit_done - transmit done processing - * @dev: Network device. + * @hw_priv: Network device. * * This routine is called when the transmit interrupt is triggered, indicating * either a packet is sent successfully or there are transmit errors. @@ -4882,6 +4889,7 @@ static netdev_tx_t netdev_tx(struct sk_buff *skb, struct net_device *dev) /** * netdev_tx_timeout - transmit timeout processing * @dev: Network device. + * @txqueue: index of hanging queue * * This routine is called when the transmit timer expires. That indicates the * hardware is not running correctly because transmit interrupts are not @@ -6076,14 +6084,6 @@ static void netdev_get_drvinfo(struct net_device *dev, sizeof(info->bus_info)); } -/** - * netdev_get_regs_len - get length of register dump - * @dev: Network device. - * - * This function returns the length of the register dump. - * - * Return length of the register dump. - */ static struct hw_regs { int start; int end; @@ -6097,6 +6097,14 @@ static struct hw_regs { { 0, 0 } }; +/** + * netdev_get_regs_len - get length of register dump + * @dev: Network device. + * + * This function returns the length of the register dump. + * + * Return length of the register dump. + */ static int netdev_get_regs_len(struct net_device *dev) { struct hw_regs *range = hw_regs_range; @@ -6238,6 +6246,8 @@ static int netdev_get_eeprom_len(struct net_device *dev) return EEPROM_SIZE * 2; } +#define EEPROM_MAGIC 0x10A18842 + /** * netdev_get_eeprom - get EEPROM data * @dev: Network device. @@ -6248,8 +6258,6 @@ static int netdev_get_eeprom_len(struct net_device *dev) * * Return 0 if successful; otherwise an error code. */ -#define EEPROM_MAGIC 0x10A18842 - static int netdev_get_eeprom(struct net_device *dev, struct ethtool_eeprom *eeprom, u8 *data) { @@ -6386,7 +6394,7 @@ static int netdev_set_pauseparam(struct net_device *dev, /** * netdev_get_ringparam - get tx/rx ring parameters * @dev: Network device. - * @pause: Ethtool RING settings data structure. + * @ring: Ethtool RING settings data structure. * * This procedure returns the TX/RX ring settings. */ @@ -6690,7 +6698,7 @@ static void mib_monitor(struct timer_list *t) /** * dev_monitor - periodic monitoring - * @ptr: Network device pointer. + * @t: timer list containing a network device pointer. * * This routine is run in a kernel timer to monitor the network device. */ diff --git a/drivers/net/ethernet/microchip/encx24j600-regmap.c b/drivers/net/ethernet/microchip/encx24j600-regmap.c index 5bd7fb917b7a..796e46a53926 100644 --- a/drivers/net/ethernet/microchip/encx24j600-regmap.c +++ b/drivers/net/ethernet/microchip/encx24j600-regmap.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/** +/* * Register map access API - ENCX24J600 support * * Copyright 2015 Gridpoint diff --git a/drivers/net/ethernet/natsemi/ns83820.c b/drivers/net/ethernet/natsemi/ns83820.c index 8e24c7acf79b..1460d790240b 100644 --- a/drivers/net/ethernet/natsemi/ns83820.c +++ b/drivers/net/ethernet/natsemi/ns83820.c @@ -600,12 +600,14 @@ static void phy_intr(struct net_device *ndev) struct ns83820 *dev = PRIV(ndev); static const char *speeds[] = { "10", "100", "1000", "1000(?)", "1000F" }; u32 cfg, new_cfg; - u32 tbisr, tanar, tanlpar; + u32 tanar, tanlpar; int speed, fullduplex, newlinkstate; cfg = readl(dev->base + CFG) ^ SPDSTS_POLARITY; if (dev->CFG_cache & CFG_TBI_EN) { + u32 __maybe_unused tbisr; + /* we have an optical transceiver */ tbisr = readl(dev->base + TBISR); tanar = readl(dev->base + TANAR); @@ -1207,7 +1209,7 @@ static int ns83820_get_link_ksettings(struct net_device *ndev, struct ethtool_link_ksettings *cmd) { struct ns83820 *dev = PRIV(ndev); - u32 cfg, tanar, tbicr; + u32 cfg, __maybe_unused tanar, tbicr; int fullduplex = 0; u32 supported; diff --git a/drivers/net/ethernet/neterion/s2io.c b/drivers/net/ethernet/neterion/s2io.c index bc94970bea45..d13d92bf7447 100644 --- a/drivers/net/ethernet/neterion/s2io.c +++ b/drivers/net/ethernet/neterion/s2io.c @@ -1000,7 +1000,7 @@ static void free_shared_mem(struct s2io_nic *nic) } } -/** +/* * s2io_verify_pci_mode - */ @@ -1035,7 +1035,7 @@ static int s2io_on_nec_bridge(struct pci_dev *s2io_pdev) } static int bus_speed[8] = {33, 133, 133, 200, 266, 133, 200, 266}; -/** +/* * s2io_print_pci_mode - */ static int s2io_print_pci_mode(struct s2io_nic *nic) @@ -2064,6 +2064,9 @@ static void en_dis_able_nic_intrs(struct s2io_nic *nic, u16 mask, int flag) /** * verify_pcc_quiescent- Checks for PCC quiescent state + * @sp : private member of the device structure, which is a pointer to the + * s2io_nic structure. + * @flag: boolean controlling function path * Return: 1 If PCC is quiescence * 0 If PCC is not quiescence */ @@ -2099,6 +2102,8 @@ static int verify_pcc_quiescent(struct s2io_nic *sp, int flag) } /** * verify_xena_quiescence - Checks whether the H/W is ready + * @sp : private member of the device structure, which is a pointer to the + * s2io_nic structure. * Description: Returns whether the H/W is ready to go or not. Depending * on whether adapter enable bit was written or not the comparison * differs and the calling function passes the input argument flag to @@ -2305,6 +2310,9 @@ static int start_nic(struct s2io_nic *nic) } /** * s2io_txdl_getskb - Get the skb from txdl, unmap and return skb + * @fifo_data: fifo data pointer + * @txdlp: descriptor + * @get_off: unused */ static struct sk_buff *s2io_txdl_getskb(struct fifo_info *fifo_data, struct TxD *txdlp, int get_off) @@ -2391,7 +2399,7 @@ static void free_tx_buffers(struct s2io_nic *nic) /** * stop_nic - To stop the nic - * @nic ; device private variable. + * @nic : device private variable. * Description: * This function does exactly the opposite of what the start_nic() * function does. This function is called to stop the device. @@ -2419,7 +2427,8 @@ static void stop_nic(struct s2io_nic *nic) /** * fill_rx_buffers - Allocates the Rx side skbs - * @ring_info: per ring structure + * @nic : device private variable. + * @ring: per ring structure * @from_card_up: If this is true, we will map the buffer to get * the dma address for buf0 and buf1 to give it to the card. * Else we will sync the already mapped buffer to give it to the card. @@ -2864,7 +2873,7 @@ static void s2io_netpoll(struct net_device *dev) /** * rx_intr_handler - Rx interrupt handler - * @ring_info: per ring structure. + * @ring_data: per ring structure. * @budget: budget for napi processing. * Description: * If the interrupt is because of a received frame or if the @@ -2972,7 +2981,7 @@ static int rx_intr_handler(struct ring_info *ring_data, int budget) /** * tx_intr_handler - Transmit interrupt handler - * @nic : device private variable + * @fifo_data : fifo data pointer * Description: * If an interrupt was raised to indicate DMA complete of the * Tx packet, this function is called. It identifies the last TxD @@ -3153,6 +3162,8 @@ static u64 s2io_mdio_read(u32 mmd_type, u64 addr, struct net_device *dev) /** * s2io_chk_xpak_counter - Function to check the status of the xpak counters * @counter : counter value to be updated + * @regs_stat : registers status + * @index : index * @flag : flag to indicate the status * @type : counter type * Description: @@ -3309,8 +3320,9 @@ static void s2io_updt_xpak_counter(struct net_device *dev) /** * wait_for_cmd_complete - waits for a command to complete. - * @sp : private member of the device structure, which is a pointer to the - * s2io_nic structure. + * @addr: address + * @busy_bit: bit to check for busy + * @bit_state: state to check * Description: Function that waits for a command to Write into RMAC * ADDR DATA registers to be completed and returns either success or * error depending on whether the command was complete or not. @@ -4335,7 +4347,7 @@ static int do_s2io_chk_alarm_bit(u64 value, void __iomem *addr, /** * s2io_handle_errors - Xframe error indication handler - * @nic: device private variable + * @dev_id: opaque handle to dev * Description: Handle alarms such as loss of link, single or * double ECC errors, critical and serious errors. * Return Value: @@ -4739,7 +4751,7 @@ static irqreturn_t s2io_isr(int irq, void *dev_id) return IRQ_HANDLED; } -/** +/* * s2io_updt_stats - */ static void s2io_updt_stats(struct s2io_nic *sp) @@ -5168,7 +5180,7 @@ static u64 do_s2io_read_unicast_mc(struct s2io_nic *sp, int offset) return tmp64 >> 16; } -/** +/* * s2io_set_mac_addr - driver entry point */ @@ -5243,8 +5255,7 @@ static int do_s2io_prog_unicast(struct net_device *dev, u8 *addr) /** * s2io_ethtool_set_link_ksettings - Sets different link parameters. - * @sp : private member of the device structure, which is a pointer to the - * s2io_nic structure. + * @dev : pointer to netdev * @cmd: pointer to the structure with parameters given by ethtool to set * link information. * Description: @@ -5273,8 +5284,7 @@ s2io_ethtool_set_link_ksettings(struct net_device *dev, /** * s2io_ethtol_get_link_ksettings - Return link specific information. - * @sp : private member of the device structure, pointer to the - * s2io_nic structure. + * @dev: pointer to netdev * @cmd : pointer to the structure with parameters given by ethtool * to return link information. * Description: @@ -5313,8 +5323,7 @@ s2io_ethtool_get_link_ksettings(struct net_device *dev, /** * s2io_ethtool_gdrvinfo - Returns driver specific information. - * @sp : private member of the device structure, which is a pointer to the - * s2io_nic structure. + * @dev: pointer to netdev * @info : pointer to the structure with parameters given by ethtool to * return driver information. * Description: @@ -5335,11 +5344,10 @@ static void s2io_ethtool_gdrvinfo(struct net_device *dev, /** * s2io_ethtool_gregs - dumps the entire space of Xfame into the buffer. - * @sp: private member of the device structure, which is a pointer to the - * s2io_nic structure. + * @dev: pointer to netdev * @regs : pointer to the structure with parameters given by ethtool for - * dumping the registers. - * @reg_space: The input argument into which all the registers are dumped. + * dumping the registers. + * @space: The input argument into which all the registers are dumped. * Description: * Dumps the entire register space of xFrame NIC into the user given * buffer area. @@ -5471,8 +5479,7 @@ static void s2io_ethtool_gringparam(struct net_device *dev, /** * s2io_ethtool_getpause_data -Pause frame frame generation and reception. - * @sp : private member of the device structure, which is a pointer to the - * s2io_nic structure. + * @dev: pointer to netdev * @ep : pointer to the structure with pause parameters given by ethtool. * Description: * Returns the Pause frame generation and reception capability of the NIC. @@ -5496,8 +5503,7 @@ static void s2io_ethtool_getpause_data(struct net_device *dev, /** * s2io_ethtool_setpause_data - set/reset pause frame generation. - * @sp : private member of the device structure, which is a pointer to the - * s2io_nic structure. + * @dev: pointer to netdev * @ep : pointer to the structure with pause parameters given by ethtool. * Description: * It can be used to set or reset Pause frame generation or reception @@ -5526,6 +5532,7 @@ static int s2io_ethtool_setpause_data(struct net_device *dev, return 0; } +#define S2IO_DEV_ID 5 /** * read_eeprom - reads 4 bytes of data from user given offset. * @sp : private member of the device structure, which is a pointer to the @@ -5541,8 +5548,6 @@ static int s2io_ethtool_setpause_data(struct net_device *dev, * Return value: * -1 on failure and 0 on success. */ - -#define S2IO_DEV_ID 5 static int read_eeprom(struct s2io_nic *sp, int off, u64 *data) { int ret = -1; @@ -5734,8 +5739,7 @@ static void s2io_vpd_read(struct s2io_nic *nic) /** * s2io_ethtool_geeprom - reads the value stored in the Eeprom. - * @sp : private member of the device structure, which is a pointer to the - * s2io_nic structure. + * @dev: pointer to netdev * @eeprom : pointer to the user level structure provided by ethtool, * containing all relevant information. * @data_buf : user defined value to be written into Eeprom. @@ -5771,11 +5775,10 @@ static int s2io_ethtool_geeprom(struct net_device *dev, /** * s2io_ethtool_seeprom - tries to write the user provided value in Eeprom - * @sp : private member of the device structure, which is a pointer to the - * s2io_nic structure. + * @dev: pointer to netdev * @eeprom : pointer to the user level structure provided by ethtool, * containing all relevant information. - * @data_buf ; user defined value to be written into Eeprom. + * @data_buf : user defined value to be written into Eeprom. * Description: * Tries to write the user provided value in the Eeprom, at the offset * given by the user. @@ -6027,7 +6030,7 @@ static int s2io_bist_test(struct s2io_nic *sp, uint64_t *data) /** * s2io_link_test - verifies the link state of the nic - * @sp ; private member of the device structure, which is a pointer to the + * @sp: private member of the device structure, which is a pointer to the * s2io_nic structure. * @data: variable that returns the result of each of the test conducted by * the driver. @@ -6150,8 +6153,7 @@ static int s2io_rldram_test(struct s2io_nic *sp, uint64_t *data) /** * s2io_ethtool_test - conducts 6 tsets to determine the health of card. - * @sp : private member of the device structure, which is a pointer to the - * s2io_nic structure. + * @dev: pointer to netdev * @ethtest : pointer to a ethtool command specific structure that will be * returned to the user. * @data : variable that returns the result of each of the test @@ -6597,7 +6599,7 @@ static const struct ethtool_ops netdev_ethtool_ops = { /** * s2io_ioctl - Entry point for the Ioctl * @dev : Device pointer. - * @ifr : An IOCTL specefic structure, that can contain a pointer to + * @rq : An IOCTL specefic structure, that can contain a pointer to * a proprietary structure used to pass information to the driver. * @cmd : This is used to distinguish between the different commands that * can be passed to the IOCTL functions. @@ -6650,7 +6652,7 @@ static int s2io_change_mtu(struct net_device *dev, int new_mtu) /** * s2io_set_link - Set the LInk status - * @data: long pointer to device private structue + * @work: work struct containing a pointer to device private structue * Description: Sets the link status for the adapter */ @@ -7187,7 +7189,7 @@ static int s2io_card_up(struct s2io_nic *sp) /** * s2io_restart_nic - Resets the NIC. - * @data : long pointer to the device private structure + * @work : work struct containing a pointer to the device private structure * Description: * This function is scheduled to be run by the s2io_tx_watchdog * function after 0.5 secs to reset the NIC. The idea is to reduce @@ -7218,6 +7220,7 @@ static void s2io_restart_nic(struct work_struct *work) /** * s2io_tx_watchdog - Watchdog for transmit side. * @dev : Pointer to net device structure + * @txqueue: index of the hanging queue * Description: * This function is triggered if the Tx Queue is stopped * for a pre-defined amount of time when the Interface is still up. @@ -7242,11 +7245,8 @@ static void s2io_tx_watchdog(struct net_device *dev, unsigned int txqueue) /** * rx_osm_handler - To perform some OS related operations on SKB. - * @sp: private member of the device structure,pointer to s2io_nic structure. - * @skb : the socket buffer pointer. - * @len : length of the packet - * @cksum : FCS checksum of the frame. - * @ring_no : the ring from which this RxD was extracted. + * @ring_data : the ring from which this RxD was extracted. + * @rxdp: descriptor * Description: * This function is called by the Rx interrupt serivce routine to perform * some OS related operations on the SKB before passing it to the upper @@ -7576,9 +7576,10 @@ static int s2io_verify_parm(struct pci_dev *pdev, u8 *dev_intr_type, } /** - * rts_ds_steer - Receive traffic steering based on IPv4 or IPv6 TOS - * or Traffic class respectively. + * rts_ds_steer - Receive traffic steering based on IPv4 or IPv6 TOS or Traffic class respectively. * @nic: device private variable + * @ds_codepoint: data + * @ring: ring index * Description: The function configures the receive steering to * desired receive ring. * Return Value: SUCCESS on success and diff --git a/drivers/net/ethernet/neterion/vxge/vxge-config.c b/drivers/net/ethernet/neterion/vxge/vxge-config.c index 78eba10300ae..6aba267036dd 100644 --- a/drivers/net/ethernet/neterion/vxge/vxge-config.c +++ b/drivers/net/ethernet/neterion/vxge/vxge-config.c @@ -988,6 +988,9 @@ __vxge_hw_vpath_addr_get(struct __vxge_hw_virtualpath *vpath, /** * vxge_hw_device_hw_info_get - Get the hw information + * @bar0: the bar + * @hw_info: the hw_info struct + * * Returns the vpath mask that has the bits set for each vpath allocated * for the driver, FW version information, and the first mac address for * each vpath @@ -3926,7 +3929,7 @@ enum vxge_hw_status vxge_hw_vpath_rts_rth_itable_set( /** * vxge_hw_vpath_check_leak - Check for memory leak - * @ringh: Handle to the ring object used for receive + * @ring: Handle to the ring object used for receive * * If PRC_RXD_DOORBELL_VPn.NEW_QW_CNT is larger or equal to * PRC_CFG6_VPn.RXD_SPAT then a leak has occurred. diff --git a/drivers/net/ethernet/neterion/vxge/vxge-ethtool.c b/drivers/net/ethernet/neterion/vxge/vxge-ethtool.c index 03c3d1230c17..4d91026485ae 100644 --- a/drivers/net/ethernet/neterion/vxge/vxge-ethtool.c +++ b/drivers/net/ethernet/neterion/vxge/vxge-ethtool.c @@ -119,7 +119,7 @@ static void vxge_ethtool_gdrvinfo(struct net_device *dev, * @dev: device pointer. * @regs: pointer to the structure with parameters given by ethtool for * dumping the registers. - * @reg_space: The input argument into which all the registers are dumped. + * @space: The input argument into which all the registers are dumped. * * Dumps the vpath register space of Titan NIC into the user given * buffer area. diff --git a/drivers/net/ethernet/neterion/vxge/vxge-main.c b/drivers/net/ethernet/neterion/vxge/vxge-main.c index 7afdb3bc631c..87892bd992b1 100644 --- a/drivers/net/ethernet/neterion/vxge/vxge-main.c +++ b/drivers/net/ethernet/neterion/vxge/vxge-main.c @@ -1275,6 +1275,7 @@ static void vxge_set_multicast(struct net_device *dev) /** * vxge_set_mac_addr * @dev: pointer to the device structure + * @p: socket info * * Update entry "0" (default MAC addr) */ @@ -1799,7 +1800,7 @@ static void vxge_reset(struct work_struct *work) /** * vxge_poll - Receive handler when Receive Polling is used. - * @dev: pointer to the device structure. + * @napi: pointer to the napi structure. * @budget: Number of packets budgeted to be processed in this iteration. * * This function comes into picture only if Receive side is being handled @@ -3096,7 +3097,7 @@ static int vxge_change_mtu(struct net_device *dev, int new_mtu) /** * vxge_get_stats64 * @dev: pointer to the device structure - * @stats: pointer to struct rtnl_link_stats64 + * @net_stats: pointer to struct rtnl_link_stats64 * */ static void @@ -3245,7 +3246,7 @@ static int vxge_hwtstamp_get(struct vxgedev *vdev, void __user *data) /** * vxge_ioctl * @dev: Device pointer. - * @ifr: An IOCTL specific structure, that can contain a pointer to + * @rq: An IOCTL specific structure, that can contain a pointer to * a proprietary structure used to pass information to the driver. * @cmd: This is used to distinguish between the different commands that * can be passed to the IOCTL functions. @@ -3269,6 +3270,7 @@ static int vxge_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) /** * vxge_tx_watchdog * @dev: pointer to net device structure + * @txqueue: index of the hanging queue * * Watchdog for transmit side. * This function is triggered if the Tx Queue is stopped @@ -4002,6 +4004,7 @@ static void vxge_print_parm(struct vxgedev *vdev, u64 vpath_mask) /** * vxge_pm_suspend - vxge power management suspend entry point + * @dev_d: device pointer * */ static int __maybe_unused vxge_pm_suspend(struct device *dev_d) @@ -4010,6 +4013,7 @@ static int __maybe_unused vxge_pm_suspend(struct device *dev_d) } /** * vxge_pm_resume - vxge power management resume entry point + * @dev_d: device pointer * */ static int __maybe_unused vxge_pm_resume(struct device *dev_d) diff --git a/drivers/net/ethernet/neterion/vxge/vxge-traffic.c b/drivers/net/ethernet/neterion/vxge/vxge-traffic.c index bd525e8eda10..ee164970b267 100644 --- a/drivers/net/ethernet/neterion/vxge/vxge-traffic.c +++ b/drivers/net/ethernet/neterion/vxge/vxge-traffic.c @@ -278,7 +278,7 @@ void vxge_hw_vpath_dynamic_rti_rtimer_set(struct __vxge_hw_ring *ring) /** * vxge_hw_channel_msix_mask - Mask MSIX Vector. - * @channeh: Channel for rx or tx handle + * @channel: Channel for rx or tx handle * @msix_id: MSIX ID * * The function masks the msix interrupt for the given msix_id @@ -295,7 +295,7 @@ void vxge_hw_channel_msix_mask(struct __vxge_hw_channel *channel, int msix_id) /** * vxge_hw_channel_msix_unmask - Unmask the MSIX Vector. - * @channeh: Channel for rx or tx handle + * @channel: Channel for rx or tx handle * @msix_id: MSI ID * * The function unmasks the msix interrupt for the given msix_id @@ -350,8 +350,6 @@ u32 vxge_hw_device_set_intr_type(struct __vxge_hw_device *hldev, u32 intr_mode) /** * vxge_hw_device_intr_enable - Enable interrupts. * @hldev: HW device handle. - * @op: One of the enum vxge_hw_device_intr enumerated values specifying - * the type(s) of interrupts to enable. * * Enable Titan interrupts. The function is to be executed the last in * Titan initialization sequence. @@ -405,8 +403,6 @@ void vxge_hw_device_intr_enable(struct __vxge_hw_device *hldev) /** * vxge_hw_device_intr_disable - Disable Titan interrupts. * @hldev: HW device handle. - * @op: One of the enum vxge_hw_device_intr enumerated values specifying - * the type(s) of interrupts to disable. * * Disable Titan interrupts. * @@ -1406,7 +1402,7 @@ u32 vxge_hw_fifo_free_txdl_count_get(struct __vxge_hw_fifo *fifoh) /** * vxge_hw_fifo_txdl_reserve - Reserve fifo descriptor. - * @fifoh: Handle to the fifo object used for non offload send + * @fifo: Handle to the fifo object used for non offload send * @txdlh: Reserved descriptor. On success HW fills this "out" parameter * with a valid handle. * @txdl_priv: Buffer to return the pointer to per txdl space @@ -1517,8 +1513,6 @@ void vxge_hw_fifo_txdl_buffer_set(struct __vxge_hw_fifo *fifo, * vxge_hw_fifo_txdl_post - Post descriptor on the fifo channel. * @fifo: Handle to the fifo object used for non offload send * @txdlh: Descriptor obtained via vxge_hw_fifo_txdl_reserve() - * @frags: Number of contiguous buffers that are part of a single - * transmit operation. * * Post descriptor on the 'fifo' type channel for transmission. * Prior to posting the descriptor should be filled in accordance with @@ -1691,8 +1685,7 @@ void vxge_hw_fifo_txdl_free(struct __vxge_hw_fifo *fifo, void *txdlh) } /** - * vxge_hw_vpath_mac_addr_add - Add the mac address entry for this vpath - * to MAC address table. + * vxge_hw_vpath_mac_addr_add - Add the mac address entry for this vpath to MAC address table. * @vp: Vpath handle. * @macaddr: MAC address to be added for this vpath into the list * @macaddr_mask: MAC address mask for macaddr @@ -1757,13 +1750,13 @@ vxge_hw_vpath_mac_addr_add( } /** - * vxge_hw_vpath_mac_addr_get - Get the first mac address entry for this vpath - * from MAC address table. + * vxge_hw_vpath_mac_addr_get - Get the first mac address entry * @vp: Vpath handle. * @macaddr: First MAC address entry for this vpath in the list * @macaddr_mask: MAC address mask for macaddr * - * Returns the first mac address and mac address mask in the list for this + * Get the first mac address entry for this vpath from MAC address table. + * Return: the first mac address and mac address mask in the list for this * vpath. * see also: vxge_hw_vpath_mac_addr_get_next * @@ -1808,14 +1801,13 @@ vxge_hw_vpath_mac_addr_get( } /** - * vxge_hw_vpath_mac_addr_get_next - Get the next mac address entry for this - * vpath - * from MAC address table. + * vxge_hw_vpath_mac_addr_get_next - Get the next mac address entry * @vp: Vpath handle. * @macaddr: Next MAC address entry for this vpath in the list * @macaddr_mask: MAC address mask for macaddr * - * Returns the next mac address and mac address mask in the list for this + * Get the next mac address entry for this vpath from MAC address table. + * Return: the next mac address and mac address mask in the list for this * vpath. * see also: vxge_hw_vpath_mac_addr_get * @@ -1861,8 +1853,7 @@ vxge_hw_vpath_mac_addr_get_next( } /** - * vxge_hw_vpath_mac_addr_delete - Delete the mac address entry for this vpath - * to MAC address table. + * vxge_hw_vpath_mac_addr_delete - Delete the mac address entry for this vpath to MAC address table. * @vp: Vpath handle. * @macaddr: MAC address to be added for this vpath into the list * @macaddr_mask: MAC address mask for macaddr @@ -1908,8 +1899,7 @@ vxge_hw_vpath_mac_addr_delete( } /** - * vxge_hw_vpath_vid_add - Add the vlan id entry for this vpath - * to vlan id table. + * vxge_hw_vpath_vid_add - Add the vlan id entry for this vpath to vlan id table. * @vp: Vpath handle. * @vid: vlan id to be added for this vpath into the list * @@ -2403,9 +2393,11 @@ enum vxge_hw_status vxge_hw_vpath_poll_rx(struct __vxge_hw_ring *ring) } /** - * vxge_hw_vpath_poll_tx - Poll Tx for completed descriptors and process - * the same. + * vxge_hw_vpath_poll_tx - Poll Tx for completed descriptors and process the same. * @fifo: Handle to the fifo object used for non offload send + * @skb_ptr: pointer to skb + * @nr_skb: number of skbs + * @more: more is coming * * The function polls the Tx for the completed descriptors and calls * the driver via supplied completion callback. diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c index b36aa5bf3c5f..a58f14aca10c 100644 --- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c +++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c @@ -8,7 +8,7 @@ #include "pch_gbe.h" #include "pch_gbe_phy.h" -/** +/* * pch_gbe_stats - Stats item information */ struct pch_gbe_stats { @@ -24,7 +24,7 @@ struct pch_gbe_stats { .offset = offsetof(struct pch_gbe_hw_stats, m), \ } -/** +/* * pch_gbe_gstrings_stats - ethtool information status name list */ static const struct pch_gbe_stats pch_gbe_gstrings_stats[] = { diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c index 23f7c76737c9..ade8c44c01cd 100644 --- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c +++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c @@ -295,7 +295,7 @@ static s32 pch_gbe_mac_read_mac_addr(struct pch_gbe_hw *hw) /** * pch_gbe_wait_clr_bit - Wait to clear a bit * @reg: Pointer of register - * @busy: Busy bit + * @bit: Busy bit */ static void pch_gbe_wait_clr_bit(void *reg, u32 bit) { @@ -1034,7 +1034,7 @@ static void pch_gbe_set_mode(struct pch_gbe_adapter *adapter, u16 speed, /** * pch_gbe_watchdog - Watchdog process - * @data: Board private structure + * @t: timer list containing a Board private structure */ static void pch_gbe_watchdog(struct timer_list *t) { @@ -2270,6 +2270,7 @@ static int pch_gbe_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd) /** * pch_gbe_tx_timeout - Respond to a Tx Hang * @netdev: Network interface device structure + * @txqueue: index of hanging queue */ static void pch_gbe_tx_timeout(struct net_device *netdev, unsigned int txqueue) { diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_param.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_param.c index dceec80fd642..81fc5a6e3221 100644 --- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_param.c +++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_param.c @@ -13,7 +13,7 @@ #define OPTION_DISABLED 0 #define OPTION_ENABLED 1 -/** +/* * TxDescriptors - Transmit Descriptor Count * @Valid Range: PCH_GBE_MIN_TXD - PCH_GBE_MAX_TXD * @Default Value: PCH_GBE_DEFAULT_TXD @@ -22,7 +22,7 @@ static int TxDescriptors = OPTION_UNSET; module_param(TxDescriptors, int, 0); MODULE_PARM_DESC(TxDescriptors, "Number of transmit descriptors"); -/** +/* * RxDescriptors -Receive Descriptor Count * @Valid Range: PCH_GBE_MIN_RXD - PCH_GBE_MAX_RXD * @Default Value: PCH_GBE_DEFAULT_RXD @@ -31,7 +31,7 @@ static int RxDescriptors = OPTION_UNSET; module_param(RxDescriptors, int, 0); MODULE_PARM_DESC(RxDescriptors, "Number of receive descriptors"); -/** +/* * Speed - User Specified Speed Override * @Valid Range: 0, 10, 100, 1000 * - 0: auto-negotiate at all supported speeds @@ -44,7 +44,7 @@ static int Speed = OPTION_UNSET; module_param(Speed, int, 0); MODULE_PARM_DESC(Speed, "Speed setting"); -/** +/* * Duplex - User Specified Duplex Override * @Valid Range: 0-2 * - 0: auto-negotiate for duplex @@ -59,7 +59,7 @@ MODULE_PARM_DESC(Duplex, "Duplex setting"); #define HALF_DUPLEX 1 #define FULL_DUPLEX 2 -/** +/* * AutoNeg - Auto-negotiation Advertisement Override * @Valid Range: 0x01-0x0F, 0x20-0x2F * @@ -85,7 +85,7 @@ MODULE_PARM_DESC(AutoNeg, "Advertised auto-negotiation setting"); #define PHY_ADVERTISE_1000_FULL 0x0020 #define PCH_AUTONEG_ADVERTISE_DEFAULT 0x2F -/** +/* * FlowControl - User Specified Flow Control Override * @Valid Range: 0-3 * - 0: No Flow Control @@ -124,7 +124,7 @@ MODULE_PARM_DESC(XsumTX, "Disable or enable Transmit Checksum offload"); #define PCH_GBE_DEFAULT_TX_CSUM true /* trueorfalse */ -/** +/* * pch_gbe_option - Force the MAC's flow control settings * @hw: Pointer to the HW structure * Returns: diff --git a/drivers/net/ethernet/packetengines/yellowfin.c b/drivers/net/ethernet/packetengines/yellowfin.c index 3da075307178..d1dd9bc1bc7f 100644 --- a/drivers/net/ethernet/packetengines/yellowfin.c +++ b/drivers/net/ethernet/packetengines/yellowfin.c @@ -1060,7 +1060,7 @@ static int yellowfin_rx(struct net_device *dev) struct sk_buff *rx_skb = yp->rx_skbuff[entry]; s16 frame_status; u16 desc_status; - int data_size, yf_size; + int data_size, __maybe_unused yf_size; u8 *buf_addr; if(!desc->result_status) diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic.h b/drivers/net/ethernet/qlogic/netxen/netxen_nic.h index 86153660d245..e5c51256243a 100644 --- a/drivers/net/ethernet/qlogic/netxen/netxen_nic.h +++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic.h @@ -1189,9 +1189,6 @@ typedef struct { #define NX_FORCE_FW_RESET 0xdeaddead -/* Fw dump levels */ -static const u32 FW_DUMP_LEVELS[] = { 0x3, 0x7, 0xf, 0x1f, 0x3f, 0x7f, 0xff }; - /* Flash read/write address */ #define NX_FW_DUMP_REG1 0x00130060 #define NX_FW_DUMP_REG2 0x001e0000 diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c index c3f50ddbe824..dd22cb056d03 100644 --- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c +++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c @@ -814,6 +814,9 @@ netxen_get_dump_flag(struct net_device *netdev, struct ethtool_dump *dump) return 0; } +/* Fw dump levels */ +static const u32 FW_DUMP_LEVELS[] = { 0x3, 0x7, 0xf, 0x1f, 0x3f, 0x7f, 0xff }; + static int netxen_set_dump(struct net_device *netdev, struct ethtool_dump *val) { diff --git a/drivers/net/ethernet/qualcomm/emac/emac.c b/drivers/net/ethernet/qualcomm/emac/emac.c index 1166b98d8bb2..8543bf3c3484 100644 --- a/drivers/net/ethernet/qualcomm/emac/emac.c +++ b/drivers/net/ethernet/qualcomm/emac/emac.c @@ -292,6 +292,7 @@ static void emac_tx_timeout(struct net_device *netdev, unsigned int txqueue) /** * emac_update_hw_stats - read the EMAC stat registers + * @adpt: pointer to adapter struct * * Reads the stats registers and write the values to adpt->stats. * diff --git a/drivers/net/ethernet/realtek/8139cp.c b/drivers/net/ethernet/realtek/8139cp.c index e291e6ac40cb..2f2567341710 100644 --- a/drivers/net/ethernet/realtek/8139cp.c +++ b/drivers/net/ethernet/realtek/8139cp.c @@ -1261,6 +1261,8 @@ static void cp_tx_timeout(struct net_device *dev, unsigned int txqueue) cp_stop_hw(cp); cp_clean_rings(cp); rc = cp_init_rings(cp); + if (rc) + netif_dbg(cp, tx_err, cp->dev, "Init rings failed: %d\n", rc); cp_start_hw(cp); __cp_set_rx_mode(dev); cpw16_f(IntrMask, cp_norx_intr_mask); diff --git a/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c b/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c index 2cc8184b7e6b..971f1e54b652 100644 --- a/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c +++ b/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c @@ -97,7 +97,7 @@ void sxgbe_disable_eee_mode(struct sxgbe_priv_data * const priv) /** * sxgbe_eee_ctrl_timer - * @arg : data hook + * @t: timer list containing a data * Description: * If there is no data transfer and if we are not in LPI state, * then MAC Transmitter can be moved to LPI state. @@ -255,7 +255,7 @@ static void sxgbe_adjust_link(struct net_device *dev) /** * sxgbe_init_phy - PHY initialization - * @dev: net device structure + * @ndev: net device structure * Description: it initializes the driver's PHY state, and attaches the PHY * to the mac driver. * Return value: @@ -364,8 +364,11 @@ static int sxgbe_init_rx_buffers(struct net_device *dev, /** * sxgbe_free_rx_buffers - free what sxgbe_init_rx_buffers() allocated * @dev: net device structure + * @p: dec pointer + * @i: index + * @dma_buf_sz: size * @rx_ring: ring to be freed - * @rx_rsize: ring size + * * Description: this function initializes the DMA RX descriptor */ static void sxgbe_free_rx_buffers(struct net_device *dev, @@ -383,6 +386,7 @@ static void sxgbe_free_rx_buffers(struct net_device *dev, /** * init_tx_ring - init the TX descriptor ring * @dev: net device structure + * @queue_no: queue * @tx_ring: ring to be initialised * @tx_rsize: ring size * Description: this function initializes the DMA TX descriptor @@ -449,6 +453,7 @@ static void free_rx_ring(struct device *dev, struct sxgbe_rx_queue *rx_ring, /** * init_rx_ring - init the RX descriptor ring * @dev: net device structure + * @queue_no: queue * @rx_ring: ring to be initialised * @rx_rsize: ring size * Description: this function initializes the DMA RX descriptor @@ -548,7 +553,7 @@ static void free_tx_ring(struct device *dev, struct sxgbe_tx_queue *tx_ring, /** * init_dma_desc_rings - init the RX/TX descriptor rings - * @dev: net device structure + * @netd: net device structure * Description: this function initializes the DMA RX/TX descriptors * and allocates the socket buffers. It suppors the chained and ring * modes. @@ -724,7 +729,7 @@ static void sxgbe_mtl_operation_mode(struct sxgbe_priv_data *priv) /** * sxgbe_tx_queue_clean: - * @priv: driver private structure + * @tqueue: queue pointer * Description: it reclaims resources after transmission completes. */ static void sxgbe_tx_queue_clean(struct sxgbe_tx_queue *tqueue) @@ -807,6 +812,7 @@ static void sxgbe_tx_all_clean(struct sxgbe_priv_data * const priv) /** * sxgbe_restart_tx_queue: irq tx error mng function * @priv: driver private structure + * @queue_num: queue number * Description: it cleans the descriptors and restarts the transmission * in case of errors. */ @@ -1567,6 +1573,7 @@ static int sxgbe_poll(struct napi_struct *napi, int budget) /** * sxgbe_tx_timeout * @dev : Pointer to net device structure + * @txqueue: index of the hanging queue * Description: this function is called when a packet transmission fails to * complete within a reasonable time. The driver will mark the error in the * netdev structure and arrange for the device to be reset to a sane state diff --git a/drivers/net/ethernet/sfc/falcon/rx.c b/drivers/net/ethernet/sfc/falcon/rx.c index 05ea3523890a..966f13e7475d 100644 --- a/drivers/net/ethernet/sfc/falcon/rx.c +++ b/drivers/net/ethernet/sfc/falcon/rx.c @@ -140,6 +140,7 @@ static struct page *ef4_reuse_page(struct ef4_rx_queue *rx_queue) * ef4_init_rx_buffers - create EF4_RX_BATCH page-based RX buffers * * @rx_queue: Efx RX queue + * @atomic: control memory allocation flags * * This allocates a batch of pages, maps them for DMA, and populates * struct ef4_rx_buffers for each one. Return a negative error code or @@ -316,6 +317,7 @@ static void ef4_discard_rx_packet(struct ef4_channel *channel, * This will aim to fill the RX descriptor queue up to * @rx_queue->@max_fill. If there is insufficient atomic * memory to do so, a slow fill will be scheduled. + * @atomic: control memory allocation flags * * The caller must provide serialisation (none is used here). In practise, * this means this function must run from the NAPI handler, or be called diff --git a/drivers/net/ethernet/sfc/falcon/selftest.c b/drivers/net/ethernet/sfc/falcon/selftest.c index 147677c7c72f..6a454ac6f876 100644 --- a/drivers/net/ethernet/sfc/falcon/selftest.c +++ b/drivers/net/ethernet/sfc/falcon/selftest.c @@ -65,7 +65,7 @@ static const char *const ef4_interrupt_mode_names[] = { STRING_TABLE_LOOKUP(efx->interrupt_mode, ef4_interrupt_mode) /** - * ef4_loopback_state - persistent state during a loopback selftest + * struct ef4_loopback_state - persistent state during a loopback selftest * @flush: Drop all packets in ef4_loopback_rx_packet * @packet_count: Number of packets being used in this test * @skbs: An array of skbs transmitted diff --git a/drivers/net/ethernet/sfc/net_driver.h b/drivers/net/ethernet/sfc/net_driver.h index 3fd0b59107d1..f7d1eeb71de0 100644 --- a/drivers/net/ethernet/sfc/net_driver.h +++ b/drivers/net/ethernet/sfc/net_driver.h @@ -453,7 +453,7 @@ enum efx_sync_events_state { * were checked for expiry * @rfs_expire_index: next accelerated RFS filter ID to check for expiry * @n_rfs_succeeded: number of successful accelerated RFS filter insertions - * @n_rfs_failed; number of failed accelerated RFS filter insertions + * @n_rfs_failed: number of failed accelerated RFS filter insertions * @filter_work: Work item for efx_filter_rfs_expire() * @rps_flow_id: Flow IDs of filters allocated for accelerated RFS, * indexed by filter ID diff --git a/drivers/net/ethernet/sfc/ptp.c b/drivers/net/ethernet/sfc/ptp.c index bea4725a4499..00cbd3ac6d99 100644 --- a/drivers/net/ethernet/sfc/ptp.c +++ b/drivers/net/ethernet/sfc/ptp.c @@ -172,9 +172,11 @@ struct efx_ptp_match { /** * struct efx_ptp_event_rx - A PTP receive event (from MC) + * @link: list of events * @seq0: First part of (PTP) UUID * @seq1: Second part of (PTP) UUID and sequence number * @hwtimestamp: Event timestamp + * @expiry: Time which the packet arrived */ struct efx_ptp_event_rx { struct list_head link; @@ -222,11 +224,13 @@ struct efx_ptp_timeset { * reset (disable, enable). * @rxfilter_event: Receive filter when operating * @rxfilter_general: Receive filter when operating + * @rxfilter_installed: Receive filter installed * @config: Current timestamp configuration * @enabled: PTP operation enabled * @mode: Mode in which PTP operating (PTP version) * @ns_to_nic_time: Function to convert from scalar nanoseconds to NIC time * @nic_to_kernel_time: Function to convert from NIC to kernel time + * @nic_time: contains time details * @nic_time.minor_max: Wrap point for NIC minor times * @nic_time.sync_event_diff_min: Minimum acceptable difference between time * in packet prefix and last MCDI time sync event i.e. how much earlier than @@ -238,6 +242,7 @@ struct efx_ptp_timeset { * field in MCDI time sync event. * @min_synchronisation_ns: Minimum acceptable corrected sync window * @capabilities: Capabilities flags from the NIC + * @ts_corrections: contains corrections details * @ts_corrections.ptp_tx: Required driver correction of PTP packet transmit * timestamps * @ts_corrections.ptp_rx: Required driver correction of PTP packet receive @@ -263,6 +268,7 @@ struct efx_ptp_timeset { * @nic_ts_enabled: Flag indicating if NIC generated TS events are handled * @txbuf: Buffer for use when transmitting (PTP) packets to MC (avoids * allocations in main data path). + * @MC_CMD_PTP_IN_TRANSMIT_LENMAX: hack to get W=1 to compile * @good_syncs: Number of successful synchronisations. * @fast_syncs: Number of synchronisations requiring short delay * @bad_syncs: Number of failed synchronisations. diff --git a/drivers/net/ethernet/sis/sis900.c b/drivers/net/ethernet/sis/sis900.c index 869b7618e2ba..620c26f71be8 100644 --- a/drivers/net/ethernet/sis/sis900.c +++ b/drivers/net/ethernet/sis/sis900.c @@ -1301,7 +1301,7 @@ static void sis630_set_eq(struct net_device *net_dev, u8 revision) /** * sis900_timer - sis900 timer routine - * @data: pointer to sis900 net device + * @t: timer list containing a pointer to sis900 net device * * On each timer ticks we check two things, * link status (ON/OFF) and link mode (10/100/Full/Half) @@ -1535,6 +1535,7 @@ static void sis900_read_mode(struct net_device *net_dev, int *speed, int *duplex /** * sis900_tx_timeout - sis900 transmit timeout routine * @net_dev: the net device to transmit + * @txqueue: index of hanging queue * * print transmit timeout status * disable interrupts and do some tasks diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c index 2d5573b3dee1..6ef30252bfe0 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0-or-later /** - * dwmac-rk.c - Rockchip RK3288 DWMAC specific glue layer + * DOC: dwmac-rk.c - Rockchip RK3288 DWMAC specific glue layer * * Copyright (C) 2014 Chen-Zhi (Roger Chen) * diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 3fa24b310d20..505e3e0b8eb5 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -360,7 +360,7 @@ void stmmac_disable_eee_mode(struct stmmac_priv *priv) /** * stmmac_eee_ctrl_timer - EEE TX SW timer. - * @arg : data hook + * @t: timer_list struct containing private info * Description: * if there is no data transfer and if we are not in LPI state, * then MAC Transmitter can be moved to LPI state. @@ -735,7 +735,7 @@ static int stmmac_hwtstamp_set(struct net_device *dev, struct ifreq *ifr) * a proprietary structure used to pass information to the driver. * Description: * This function obtain the current hardware timestamping settings - as requested. + * as requested. */ static int stmmac_hwtstamp_get(struct net_device *dev, struct ifreq *ifr) { @@ -795,6 +795,7 @@ static void stmmac_release_ptp(struct stmmac_priv *priv) /** * stmmac_mac_flow_ctrl - Configure flow control in all queues * @priv: driver private structure + * @duplex: duplex passed to the next function * Description: It is used for configuring the flow control in all queues */ static void stmmac_mac_flow_ctrl(struct stmmac_priv *priv, u32 duplex) @@ -1961,6 +1962,7 @@ static void stmmac_dma_operation_mode(struct stmmac_priv *priv) /** * stmmac_tx_clean - to manage the transmission completion * @priv: driver private structure + * @budget: napi budget limiting this functions packet handling * @queue: TX queue index * Description: it reclaims the transmit resources after transmission completes. */ @@ -2353,7 +2355,7 @@ static void stmmac_tx_timer_arm(struct stmmac_priv *priv, u32 queue) /** * stmmac_tx_timer - mitigation sw timer for tx. - * @data: data pointer + * @t: data pointer * Description: * This is the timer handler to directly invoke the stmmac_tx_clean. */ @@ -2616,6 +2618,7 @@ static void stmmac_safety_feat_configuration(struct stmmac_priv *priv) /** * stmmac_hw_setup - setup mac in a usable state. * @dev : pointer to the device structure. + * @init_ptp: initialize PTP if set * Description: * this is the main function to setup the HW in a usable state because the * dma engine is reset, the core registers are configured (e.g. AXI, @@ -2969,7 +2972,7 @@ static bool stmmac_vlan_insert(struct stmmac_priv *priv, struct sk_buff *skb, * @priv: driver private structure * @des: buffer start address * @total_len: total length to fill in descriptors - * @last_segmant: condition for the last descriptor + * @last_segment: condition for the last descriptor * @queue: TX queue index * Description: * This function fills descriptor and request new descriptors according to @@ -3935,6 +3938,7 @@ static int stmmac_napi_poll_tx(struct napi_struct *napi, int budget) /** * stmmac_tx_timeout * @dev : Pointer to net device structure + * @txqueue: the index of the hanging transmit queue * Description: this function is called when a packet transmission fails to * complete within a reasonable time. The driver will mark the error in the * netdev structure and arrange for the device to be reset to a sane state @@ -5120,7 +5124,7 @@ EXPORT_SYMBOL_GPL(stmmac_suspend); /** * stmmac_reset_queues_param - reset queue parameters - * @dev: device pointer + * @priv: device pointer */ static void stmmac_reset_queues_param(struct stmmac_priv *priv) { diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c index f32317fa75c8..af34a4cadbb0 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c @@ -125,6 +125,7 @@ static struct stmmac_axi *stmmac_axi_setup(struct platform_device *pdev) /** * stmmac_mtl_setup - parse DT parameters for multiple queues configuration * @pdev: platform device + * @plat: enet data */ static int stmmac_mtl_setup(struct platform_device *pdev, struct plat_stmmacenet_data *plat) @@ -360,7 +361,7 @@ static int stmmac_dt_phy(struct plat_stmmacenet_data *plat, /** * stmmac_of_get_mac_mode - retrieves the interface of the MAC - * @np - device-tree node + * @np: - device-tree node * Description: * Similar to `of_get_phy_mode()`, this function will retrieve (from * the device-tree) the interface mode on the MAC side. This assumes diff --git a/drivers/net/ethernet/sun/cassini.c b/drivers/net/ethernet/sun/cassini.c index b624e177ec71..9ff894ba8d3e 100644 --- a/drivers/net/ethernet/sun/cassini.c +++ b/drivers/net/ethernet/sun/cassini.c @@ -454,8 +454,8 @@ static int cas_page_free(struct cas *cp, cas_page_t *page) #define RX_USED_ADD(x, y) ((x)->used += (y)) #define RX_USED_SET(x, y) ((x)->used = (y)) #else -#define RX_USED_ADD(x, y) -#define RX_USED_SET(x, y) +#define RX_USED_ADD(x, y) do { } while(0) +#define RX_USED_SET(x, y) do { } while(0) #endif /* local page allocation routines for the receive buffers. jumbo pages diff --git a/drivers/net/ethernet/tehuti/tehuti.c b/drivers/net/ethernet/tehuti/tehuti.c index e28727297563..036477aff29d 100644 --- a/drivers/net/ethernet/tehuti/tehuti.c +++ b/drivers/net/ethernet/tehuti/tehuti.c @@ -138,7 +138,10 @@ static void print_eth_id(struct net_device *ndev) * @priv: NIC private structure * @f: fifo to initialize * @fsz_type: fifo size type: 0-4KB, 1-8KB, 2-16KB, 3-32KB - * @reg_XXX: offsets of registers relative to base address + * @reg_CFG0: offsets of registers relative to base address + * @reg_CFG1: offsets of registers relative to base address + * @reg_RPTR: offsets of registers relative to base address + * @reg_WPTR: offsets of registers relative to base address * * 1K extra space is allocated at the end of the fifo to simplify * processing of descriptors that wraps around fifo's end @@ -558,7 +561,7 @@ static int bdx_reset(struct bdx_priv *priv) /** * bdx_close - Disables a network interface - * @netdev: network interface device structure + * @ndev: network interface device structure * * Returns 0, this is not allowed to fail * @@ -585,7 +588,7 @@ static int bdx_close(struct net_device *ndev) /** * bdx_open - Called when a network interface is made active - * @netdev: network interface device structure + * @ndev: network interface device structure * * Returns 0 on success, negative value on failure * @@ -698,7 +701,7 @@ static int bdx_ioctl(struct net_device *ndev, struct ifreq *ifr, int cmd) * __bdx_vlan_rx_vid - private helper for adding/killing VLAN vid * @ndev: network device * @vid: VLAN vid - * @op: add or kill operation + * @enable: enable or disable vlan * * Passes VLAN filter table to hardware */ @@ -729,6 +732,7 @@ static void __bdx_vlan_rx_vid(struct net_device *ndev, uint16_t vid, int enable) /** * bdx_vlan_rx_add_vid - kernel hook for adding VLAN vid to hw filtering table * @ndev: network device + * @proto: unused * @vid: VLAN vid to add */ static int bdx_vlan_rx_add_vid(struct net_device *ndev, __be16 proto, u16 vid) @@ -740,6 +744,7 @@ static int bdx_vlan_rx_add_vid(struct net_device *ndev, __be16 proto, u16 vid) /** * bdx_vlan_rx_kill_vid - kernel hook for killing VLAN vid in hw filtering table * @ndev: network device + * @proto: unused * @vid: VLAN vid to kill */ static int bdx_vlan_rx_kill_vid(struct net_device *ndev, __be16 proto, u16 vid) @@ -750,7 +755,7 @@ static int bdx_vlan_rx_kill_vid(struct net_device *ndev, __be16 proto, u16 vid) /** * bdx_change_mtu - Change the Maximum Transfer Unit - * @netdev: network interface device structure + * @ndev: network interface device structure * @new_mtu: new value for maximum frame size * * Returns 0 on success, negative on failure @@ -1756,6 +1761,8 @@ static void bdx_tx_cleanup(struct bdx_priv *priv) /** * bdx_tx_free_skbs - frees all skbs from TXD fifo. + * @priv: NIC private structure + * * It gets called when OS stops this dev, eg upon "ifconfig down" or rmmod */ static void bdx_tx_free_skbs(struct bdx_priv *priv) diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c b/drivers/net/ethernet/ti/davinci_cpdma.c index 6614fa3089b2..d2eab5cd1e0c 100644 --- a/drivers/net/ethernet/ti/davinci_cpdma.c +++ b/drivers/net/ethernet/ti/davinci_cpdma.c @@ -718,7 +718,7 @@ static void cpdma_chan_set_descs(struct cpdma_ctlr *ctlr, most_chan->desc_num += desc_cnt; } -/** +/* * cpdma_chan_split_pool - Splits ctrl pool between all channels. * Has to be called under ctlr lock */ diff --git a/drivers/net/ethernet/ti/davinci_emac.c b/drivers/net/ethernet/ti/davinci_emac.c index b36d0e412d23..c7031e1960d4 100644 --- a/drivers/net/ethernet/ti/davinci_emac.c +++ b/drivers/net/ethernet/ti/davinci_emac.c @@ -671,7 +671,7 @@ static int emac_hash_del(struct emac_priv *priv, u8 *mac_addr) * emac_add_mcast - Set multicast address in the EMAC adapter (Internal) * @priv: The DaVinci EMAC private adapter structure * @action: multicast operation to perform - * mac_addr: mac address to set + * @mac_addr: mac address to set * * Set multicast addresses in EMAC adapter - internal function * @@ -977,6 +977,7 @@ static int emac_dev_xmit(struct sk_buff *skb, struct net_device *ndev) /** * emac_dev_tx_timeout - EMAC Transmit timeout function * @ndev: The DaVinci EMAC network adapter + * @txqueue: the index of the hung transmit queue * * Called when system detects that a skb timeout period has expired * potentially due to a fault in the adapter in not being able to send @@ -1209,7 +1210,7 @@ static int emac_hw_enable(struct emac_priv *priv) /** * emac_poll - EMAC NAPI Poll function - * @ndev: The DaVinci EMAC network adapter + * @napi: pointer to the napi_struct containing The DaVinci EMAC network adapter * @budget: Number of receive packets to process (as told by NAPI layer) * * NAPI Poll function implemented to process packets as per budget. We check diff --git a/drivers/net/ethernet/via/via-rhine.c b/drivers/net/ethernet/via/via-rhine.c index 803247d51fe9..26e6b087c0e4 100644 --- a/drivers/net/ethernet/via/via-rhine.c +++ b/drivers/net/ethernet/via/via-rhine.c @@ -1515,7 +1515,7 @@ static void rhine_init_cam_filter(struct net_device *dev) /** * rhine_update_vcam - update VLAN CAM filters - * @rp: rhine_private data of this Rhine + * @dev: rhine_private data of this Rhine * * Update VLAN CAM filters to match configuration change. */ diff --git a/drivers/net/ethernet/via/via-velocity.c b/drivers/net/ethernet/via/via-velocity.c index 722b44604ea8..b65767f9e499 100644 --- a/drivers/net/ethernet/via/via-velocity.c +++ b/drivers/net/ethernet/via/via-velocity.c @@ -372,7 +372,7 @@ static const struct pci_device_id velocity_pci_id_table[] = { MODULE_DEVICE_TABLE(pci, velocity_pci_id_table); -/** +/* * Describe the OF device identifiers that we support in this * device driver. Used for devicetree nodes. */ @@ -384,7 +384,7 @@ MODULE_DEVICE_TABLE(of, velocity_of_ids); /** * get_chip_name - identifier to name - * @id: chip identifier + * @chip_id: chip identifier * * Given a chip identifier return a suitable description. Returns * a pointer a static string valid while the driver is loaded. @@ -748,7 +748,7 @@ static u32 mii_check_media_mode(struct mac_regs __iomem *regs) /** * velocity_mii_write - write MII data * @regs: velocity registers - * @index: MII register index + * @mii_addr: MII register index * @data: 16bit data for the MII register * * Perform a single write to an MII 16bit register. Returns zero @@ -869,6 +869,7 @@ static u32 check_connection_type(struct mac_regs __iomem *regs) /** * velocity_set_media_mode - set media mode + * @vptr: velocity adapter * @mii_status: old MII link state * * Check the media link state and configure the flow control @@ -1256,6 +1257,7 @@ static void mii_init(struct velocity_info *vptr, u32 mii_status) /** * setup_queue_timers - Setup interrupt timers + * @vptr: velocity adapter * * Setup interrupt frequency during suppression (timeout if the frame * count isn't filled). @@ -1280,8 +1282,7 @@ static void setup_queue_timers(struct velocity_info *vptr) /** * setup_adaptive_interrupts - Setup interrupt suppression - * - * @vptr velocity adapter + * @vptr: velocity adapter * * The velocity is able to suppress interrupt during high interrupt load. * This function turns on that feature. @@ -1722,6 +1723,7 @@ static int velocity_init_rings(struct velocity_info *vptr, int mtu) * velocity_free_tx_buf - free transmit buffer * @vptr: velocity * @tdinfo: buffer + * @td: transmit descriptor to free * * Release an transmit buffer. If the buffer was preallocated then * recycle it, if not then unmap the buffer. @@ -1896,7 +1898,7 @@ static void velocity_error(struct velocity_info *vptr, int status) /** * tx_srv - transmit interrupt service - * @vptr; Velocity + * @vptr: Velocity * * Scan the queues looking for transmitted packets that * we can complete and clean up. Update any statistics as @@ -1990,8 +1992,7 @@ static inline void velocity_rx_csum(struct rx_desc *rd, struct sk_buff *skb) * velocity_rx_copy - in place Rx copy for small packets * @rx_skb: network layer packet buffer candidate * @pkt_size: received data size - * @rd: receive packet descriptor - * @dev: network device + * @vptr: velocity adapter * * Replace the current skb that is scheduled for Rx processing by a * shorter, immediately allocated skb, if the received packet is small @@ -2097,6 +2098,7 @@ static int velocity_receive_frame(struct velocity_info *vptr, int idx) /** * velocity_rx_srv - service RX interrupt * @vptr: velocity + * @budget_left: remaining budget * * Walk the receive ring of the velocity adapter and remove * any received packets from the receive queue. Hand the ring @@ -2645,7 +2647,6 @@ static const struct net_device_ops velocity_netdev_ops = { /** * velocity_init_info - init private data - * @pdev: PCI device * @vptr: Velocity info * @info: Board type * @@ -2664,7 +2665,6 @@ static void velocity_init_info(struct velocity_info *vptr, /** * velocity_get_pci_info - retrieve PCI info for device * @vptr: velocity device - * @pdev: PCI device it matches * * Retrieve the PCI configuration space data that interests us from * the kernel PCI layer @@ -2701,7 +2701,6 @@ static int velocity_get_pci_info(struct velocity_info *vptr) /** * velocity_get_platform_info - retrieve platform info for device * @vptr: velocity device - * @pdev: platform device it matches * * Retrieve the Platform configuration data that interests us */ @@ -2751,8 +2750,9 @@ static u32 velocity_get_link(struct net_device *dev) /** * velocity_probe - set up discovered velocity device - * @pdev: PCI device - * @ent: PCI device table entry that matched + * @dev: PCI device + * @info: table of match + * @irq: interrupt info * @bustype: bus that device is connected to * * Configure a discovered adapter from scratch. Return a negative @@ -2969,6 +2969,7 @@ static int velocity_platform_remove(struct platform_device *pdev) #ifdef CONFIG_PM_SLEEP /** * wol_calc_crc - WOL CRC + * @size: size of the wake mask * @pattern: data pattern * @mask_pattern: mask * -- 2.27.0 ^ permalink raw reply related [flat|nested] 68+ messages in thread
* Re: [RFC PATCH net-next v1 11/11] drivers/net/ethernet: clean up mis-targeted comments 2020-09-11 1:23 ` [Intel-wired-lan] " Jesse Brandeburg @ 2020-09-11 17:26 ` Edward Cree -1 siblings, 0 replies; 68+ messages in thread From: Edward Cree @ 2020-09-11 17:26 UTC (permalink / raw) To: Jesse Brandeburg, netdev; +Cc: intel-wired-lan On 11/09/2020 02:23, Jesse Brandeburg wrote: > As part of the W=1 cleanups for ethernet, a million [1] driver comments > had to be cleaned up to get the W=1 compilation to succeed. This > change finally makes the drivers/net/ethernet tree compile with > W=1 set on the command line. > > [1] - ok it wasn't quite a million, but it felt like it. > > Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> > > --- > @@ -263,6 +268,7 @@ struct efx_ptp_timeset { > * @nic_ts_enabled: Flag indicating if NIC generated TS events are handled > * @txbuf: Buffer for use when transmitting (PTP) packets to MC (avoids > * allocations in main data path). > + * @MC_CMD_PTP_IN_TRANSMIT_LENMAX: hack to get W=1 to compile I think I'd rather have a bogus warning than bogus kerneldocto suppress it; please drop this line (and encourage toolchain folks to figure out how to get kerneldoc to ignore macros it can't understand). Apart from that, the sfc and sfc/falcon parts LGTM. -ed ^ permalink raw reply [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 11/11] drivers/net/ethernet: clean up mis-targeted comments @ 2020-09-11 17:26 ` Edward Cree 0 siblings, 0 replies; 68+ messages in thread From: Edward Cree @ 2020-09-11 17:26 UTC (permalink / raw) To: intel-wired-lan On 11/09/2020 02:23, Jesse Brandeburg wrote: > As part of the W=1 cleanups for ethernet, a million [1] driver comments > had to be cleaned up to get the W=1 compilation to succeed. This > change finally makes the drivers/net/ethernet tree compile with > W=1 set on the command line. > > [1] - ok it wasn't quite a million, but it felt like it. > > Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> > > --- > @@ -263,6 +268,7 @@ struct efx_ptp_timeset { > * @nic_ts_enabled: Flag indicating if NIC generated TS events are handled > * @txbuf: Buffer for use when transmitting (PTP) packets to MC (avoids > * allocations in main data path). > + * @MC_CMD_PTP_IN_TRANSMIT_LENMAX: hack to get W=1 to compile I think I'd rather have a bogus warning than bogus kerneldocto suppress it; ?please drop this line (and encourage toolchain folks to figure out how to ?get kerneldoc to ignore macros it can't understand). Apart from that, the sfc and sfc/falcon parts LGTM. -ed ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [RFC PATCH net-next v1 11/11] drivers/net/ethernet: clean up mis-targeted comments 2020-09-11 17:26 ` [Intel-wired-lan] " Edward Cree @ 2020-09-11 21:42 ` Jesse Brandeburg -1 siblings, 0 replies; 68+ messages in thread From: Jesse Brandeburg @ 2020-09-11 21:42 UTC (permalink / raw) To: Edward Cree; +Cc: netdev, intel-wired-lan Edward Cree wrote: > On 11/09/2020 02:23, Jesse Brandeburg wrote: > > + * @MC_CMD_PTP_IN_TRANSMIT_LENMAX: hack to get W=1 to compile > I think I'd rather have a bogus warning than bogus kerneldocto suppress it; > please drop this line (and encourage toolchain folks to figure out how to > get kerneldoc to ignore macros it can't understand). > Apart from that, the sfc and sfc/falcon parts LGTM. > > -ed Thanks Ed, I think I might just remove the /** on that function then (removing it from kdoc processing), would that be acceptable in the meantime? Of course I'd remove the line I added as well. - Jesse ^ permalink raw reply [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 11/11] drivers/net/ethernet: clean up mis-targeted comments @ 2020-09-11 21:42 ` Jesse Brandeburg 0 siblings, 0 replies; 68+ messages in thread From: Jesse Brandeburg @ 2020-09-11 21:42 UTC (permalink / raw) To: intel-wired-lan Edward Cree wrote: > On 11/09/2020 02:23, Jesse Brandeburg wrote: > > + * @MC_CMD_PTP_IN_TRANSMIT_LENMAX: hack to get W=1 to compile > I think I'd rather have a bogus warning than bogus kerneldocto suppress it; > ?please drop this line (and encourage toolchain folks to figure out how to > ?get kerneldoc to ignore macros it can't understand). > Apart from that, the sfc and sfc/falcon parts LGTM. > > -ed Thanks Ed, I think I might just remove the /** on that function then (removing it from kdoc processing), would that be acceptable in the meantime? Of course I'd remove the line I added as well. - Jesse ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [RFC PATCH net-next v1 11/11] drivers/net/ethernet: clean up mis-targeted comments 2020-09-11 21:42 ` [Intel-wired-lan] " Jesse Brandeburg @ 2020-09-11 21:55 ` Edward Cree -1 siblings, 0 replies; 68+ messages in thread From: Edward Cree @ 2020-09-11 21:55 UTC (permalink / raw) To: Jesse Brandeburg; +Cc: netdev, intel-wired-lan On 11/09/2020 22:42, Jesse Brandeburg wrote: > Thanks Ed, I think I might just remove the /** on that function then > (removing it from kdoc processing) I dunno, that means a) kerneldoc won't generate html for this struct b) new additions to the struct without corresponding kerneldoc won't generate warnings both of which are not ideal outcomes. I realise there's value in having totally warning-clean code, but in this case I think this one warning, even though it's indicating a toolchain problem rather than a codebase problem, should better stay (if only to put pressure on the toolchain to fix it). Otherwise, when and if the toolchain is fixed, what's the chance we'll remember to put the /** back? That's just my opinion, though; I won't block patches that disagree. -ed ^ permalink raw reply [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 11/11] drivers/net/ethernet: clean up mis-targeted comments @ 2020-09-11 21:55 ` Edward Cree 0 siblings, 0 replies; 68+ messages in thread From: Edward Cree @ 2020-09-11 21:55 UTC (permalink / raw) To: intel-wired-lan On 11/09/2020 22:42, Jesse Brandeburg wrote: > Thanks Ed, I think I might just remove the /** on that function then > (removing it from kdoc processing) I dunno, that means a) kerneldoc won't generate html for this struct b) new additions to the struct without corresponding kerneldoc won't ?? generate warnings ?both of which are not ideal outcomes. I realise there's value in having totally warning-clean code, but in ?this case I think this one warning, even though it's indicating a ?toolchain problem rather than a codebase problem, should better stay ?(if only to put pressure on the toolchain to fix it). Otherwise, when and if the toolchain is fixed, what's the chance we'll ?remember to put the /** back? That's just my opinion, though; I won't block patches that disagree. -ed ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [RFC PATCH net-next v1 11/11] drivers/net/ethernet: clean up mis-targeted comments 2020-09-11 21:55 ` [Intel-wired-lan] " Edward Cree @ 2020-09-11 22:26 ` Jakub Kicinski -1 siblings, 0 replies; 68+ messages in thread From: Jakub Kicinski @ 2020-09-11 22:26 UTC (permalink / raw) To: Edward Cree; +Cc: Jesse Brandeburg, netdev, intel-wired-lan On Fri, 11 Sep 2020 22:55:54 +0100 Edward Cree wrote: > On 11/09/2020 22:42, Jesse Brandeburg wrote: > > Thanks Ed, I think I might just remove the /** on that function then > > (removing it from kdoc processing) > I dunno, that means > a) kerneldoc won't generate html for this struct > b) new additions to the struct without corresponding kerneldoc won't > generate warnings > both of which are not ideal outcomes. > I realise there's value in having totally warning-clean code, but in > this case I think this one warning, even though it's indicating a > toolchain problem rather than a codebase problem, should better stay > (if only to put pressure on the toolchain to fix it). > Otherwise, when and if the toolchain is fixed, what's the chance we'll > remember to put the /** back? > > That's just my opinion, though; I won't block patches that disagree. "Toolchain" sounds a little grand in this context, the script that parses kdoc does basic regexps to convert the standard kernel macros: # replace DECLARE_BITMAP $members =~ s/__ETHTOOL_DECLARE_LINK_MODE_MASK\s*\(([^\)]+)\)/DECLARE_BITMAP($1, __ETHTOOL_LINK_MODE_MASK_NBITS)/gos; $members =~ s/DECLARE_BITMAP\s*\(([^,)]+),\s*([^,)]+)\)/unsigned long $1\[BITS_TO_LONGS($2)\]/gos; # replace DECLARE_HASHTABLE $members =~ s/DECLARE_HASHTABLE\s*\(([^,)]+),\s*([^,)]+)\)/unsigned long $1\[1 << (($2) - 1)\]/gos; # replace DECLARE_KFIFO $members =~ s/DECLARE_KFIFO\s*\(([^,)]+),\s*([^,)]+),\s*([^,)]+)\)/$2 \*$1/gos; # replace DECLARE_KFIFO_PTR $members =~ s/DECLARE_KFIFO_PTR\s*\(([^,)]+),\s*([^,)]+)\)/$2 \*$1/gos; IDK if we can expect it to understand random driver's macros.. This is the only use of _MCDI_DECLARE_BUF() in the tree, how about converting the declaration to: #declare _MCDI_BUF_LEN(_len) DIV_ROUND_UP(_len, 4) efx_dword_t txbuf[_MCDI_BUF_LEN(MC_CMD_PTP_IN_TRANSMIT_LENMAX)]; Would that work? ^ permalink raw reply [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 11/11] drivers/net/ethernet: clean up mis-targeted comments @ 2020-09-11 22:26 ` Jakub Kicinski 0 siblings, 0 replies; 68+ messages in thread From: Jakub Kicinski @ 2020-09-11 22:26 UTC (permalink / raw) To: intel-wired-lan On Fri, 11 Sep 2020 22:55:54 +0100 Edward Cree wrote: > On 11/09/2020 22:42, Jesse Brandeburg wrote: > > Thanks Ed, I think I might just remove the /** on that function then > > (removing it from kdoc processing) > I dunno, that means > a) kerneldoc won't generate html for this struct > b) new additions to the struct without corresponding kerneldoc won't > ?? generate warnings > ?both of which are not ideal outcomes. > I realise there's value in having totally warning-clean code, but in > ?this case I think this one warning, even though it's indicating a > ?toolchain problem rather than a codebase problem, should better stay > ?(if only to put pressure on the toolchain to fix it). > Otherwise, when and if the toolchain is fixed, what's the chance we'll > ?remember to put the /** back? > > That's just my opinion, though; I won't block patches that disagree. "Toolchain" sounds a little grand in this context, the script that parses kdoc does basic regexps to convert the standard kernel macros: # replace DECLARE_BITMAP $members =~ s/__ETHTOOL_DECLARE_LINK_MODE_MASK\s*\(([^\)]+)\)/DECLARE_BITMAP($1, __ETHTOOL_LINK_MODE_MASK_NBITS)/gos; $members =~ s/DECLARE_BITMAP\s*\(([^,)]+),\s*([^,)]+)\)/unsigned long $1\[BITS_TO_LONGS($2)\]/gos; # replace DECLARE_HASHTABLE $members =~ s/DECLARE_HASHTABLE\s*\(([^,)]+),\s*([^,)]+)\)/unsigned long $1\[1 << (($2) - 1)\]/gos; # replace DECLARE_KFIFO $members =~ s/DECLARE_KFIFO\s*\(([^,)]+),\s*([^,)]+),\s*([^,)]+)\)/$2 \*$1/gos; # replace DECLARE_KFIFO_PTR $members =~ s/DECLARE_KFIFO_PTR\s*\(([^,)]+),\s*([^,)]+)\)/$2 \*$1/gos; IDK if we can expect it to understand random driver's macros.. This is the only use of _MCDI_DECLARE_BUF() in the tree, how about converting the declaration to: #declare _MCDI_BUF_LEN(_len) DIV_ROUND_UP(_len, 4) efx_dword_t txbuf[_MCDI_BUF_LEN(MC_CMD_PTP_IN_TRANSMIT_LENMAX)]; Would that work? ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [RFC PATCH net-next v1 11/11] drivers/net/ethernet: clean up mis-targeted comments 2020-09-11 22:26 ` [Intel-wired-lan] " Jakub Kicinski @ 2020-09-11 23:11 ` Edward Cree -1 siblings, 0 replies; 68+ messages in thread From: Edward Cree @ 2020-09-11 23:11 UTC (permalink / raw) To: Jakub Kicinski; +Cc: Jesse Brandeburg, netdev, intel-wired-lan On 11/09/2020 23:26, Jakub Kicinski wrote: > "Toolchain" sounds a little grand in this context, the script that > parses kdoc does basic regexps to convert the standard kernel macros: > ... > IDK if we can expect it to understand random driver's macros.. I wasn't suggesting it should _understand_ this macro, justrecognise when something _is_ a macro it doesn't understand, and refrain from warning about it in that case. But I don't know how hard that would be to achieve — not being fluent in Perl, scripts/kernel-doc is mostly line noise to me. My best guess is that on seeing 'DECLARE_A_THING(name, argument);' it reads it as though it were 'DECLARE_A_THING name, argument;', mistaking the macro name for a type. I think the only way non-macro declarations can legitimately contain parens is in function pointer types, in which case the contents of the parens are part of the type and not declared identifiers. So shouldn't kernel-doc ignore anything within parens? > This is the only use of _MCDI_DECLARE_BUF() in the tree Well, except for mcdi.h's #define MCDI_DECLARE_BUF(_name, _len) _MCDI_DECLARE_BUF(_name, _len) = {{{0}}} > , how about converting the declaration to: > > #declare _MCDI_BUF_LEN(_len) DIV_ROUND_UP(_len, 4) > > efx_dword_t txbuf[_MCDI_BUF_LEN(MC_CMD_PTP_IN_TRANSMIT_LENMAX)]; > > Would that work? That could work, yes. Though, probably lose the leading underscore in that case. -ed ^ permalink raw reply [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 11/11] drivers/net/ethernet: clean up mis-targeted comments @ 2020-09-11 23:11 ` Edward Cree 0 siblings, 0 replies; 68+ messages in thread From: Edward Cree @ 2020-09-11 23:11 UTC (permalink / raw) To: intel-wired-lan On 11/09/2020 23:26, Jakub Kicinski wrote: > "Toolchain" sounds a little grand in this context, the script that > parses kdoc does basic regexps to convert the standard kernel macros: > ... > IDK if we can expect it to understand random driver's macros.. I wasn't suggesting it should _understand_ this macro, justrecognise ?when something _is_ a macro it doesn't understand, and refrain from ?warning about it in that case. But I don't know how hard that would be to achieve ? not being fluent ?in Perl, scripts/kernel-doc is mostly line noise to me.? My best ?guess is that on seeing 'DECLARE_A_THING(name, argument);' it reads ?it as though it were 'DECLARE_A_THING name, argument;', mistaking ?the macro name for a type. I think the only way non-macro declarations can legitimately contain ?parens is in function pointer types, in which case the contents of ?the parens are part of the type and not declared identifiers.? So ?shouldn't kernel-doc ignore anything within parens? > This is the only use of _MCDI_DECLARE_BUF() in the tree Well, except for mcdi.h's ??? #define MCDI_DECLARE_BUF(_name, _len) _MCDI_DECLARE_BUF(_name, _len) = {{{0}}} > , how about converting the declaration to: > > #declare _MCDI_BUF_LEN(_len) DIV_ROUND_UP(_len, 4) > > efx_dword_t txbuf[_MCDI_BUF_LEN(MC_CMD_PTP_IN_TRANSMIT_LENMAX)]; > > Would that work? That could work, yes.? Though, probably lose the leading underscore ?in that case. -ed ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [RFC PATCH net-next v1 11/11] drivers/net/ethernet: clean up mis-targeted comments 2020-09-11 23:11 ` [Intel-wired-lan] " Edward Cree @ 2020-09-12 0:49 ` Jesse Brandeburg -1 siblings, 0 replies; 68+ messages in thread From: Jesse Brandeburg @ 2020-09-12 0:49 UTC (permalink / raw) To: Edward Cree; +Cc: Jakub Kicinski, netdev, intel-wired-lan Edward Cree wrote: > On 11/09/2020 23:26, Jakub Kicinski wrote: > > #declare _MCDI_BUF_LEN(_len) DIV_ROUND_UP(_len, 4) > > > > efx_dword_t txbuf[_MCDI_BUF_LEN(MC_CMD_PTP_IN_TRANSMIT_LENMAX)]; > > > > Would that work? > That could work, yes. Though, probably lose the leading underscore > in that case. Ok, I made a split-out patch for that change in v2, it seems to work once I found a name that didn't collide. Thanks for the useful discussion! ^ permalink raw reply [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 11/11] drivers/net/ethernet: clean up mis-targeted comments @ 2020-09-12 0:49 ` Jesse Brandeburg 0 siblings, 0 replies; 68+ messages in thread From: Jesse Brandeburg @ 2020-09-12 0:49 UTC (permalink / raw) To: intel-wired-lan Edward Cree wrote: > On 11/09/2020 23:26, Jakub Kicinski wrote: > > #declare _MCDI_BUF_LEN(_len) DIV_ROUND_UP(_len, 4) > > > > efx_dword_t txbuf[_MCDI_BUF_LEN(MC_CMD_PTP_IN_TRANSMIT_LENMAX)]; > > > > Would that work? > That could work, yes.? Though, probably lose the leading underscore > ?in that case. Ok, I made a split-out patch for that change in v2, it seems to work once I found a name that didn't collide. Thanks for the useful discussion! ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [RFC PATCH net-next v1 11/11] drivers/net/ethernet: clean up mis-targeted comments 2020-09-11 23:11 ` [Intel-wired-lan] " Edward Cree @ 2020-09-14 3:04 ` Andrew Lunn -1 siblings, 0 replies; 68+ messages in thread From: Andrew Lunn @ 2020-09-14 3:04 UTC (permalink / raw) To: Edward Cree; +Cc: Jakub Kicinski, Jesse Brandeburg, netdev, intel-wired-lan On Sat, Sep 12, 2020 at 12:11:20AM +0100, Edward Cree wrote: > On 11/09/2020 23:26, Jakub Kicinski wrote: > > "Toolchain" sounds a little grand in this context, the script that > > parses kdoc does basic regexps to convert the standard kernel macros: > > ... > > IDK if we can expect it to understand random driver's macros.. > I wasn't suggesting it should _understand_ this macro, justrecognise > when something _is_ a macro it doesn't understand, and refrain from > warning about it in that case. Is it possible to get the C preprocessor to expand the macros without stripping the comments? Run the kerneldoc validator on that? Andrew ^ permalink raw reply [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 11/11] drivers/net/ethernet: clean up mis-targeted comments @ 2020-09-14 3:04 ` Andrew Lunn 0 siblings, 0 replies; 68+ messages in thread From: Andrew Lunn @ 2020-09-14 3:04 UTC (permalink / raw) To: intel-wired-lan On Sat, Sep 12, 2020 at 12:11:20AM +0100, Edward Cree wrote: > On 11/09/2020 23:26, Jakub Kicinski wrote: > > "Toolchain" sounds a little grand in this context, the script that > > parses kdoc does basic regexps to convert the standard kernel macros: > > ... > > IDK if we can expect it to understand random driver's macros.. > I wasn't suggesting it should _understand_ this macro, justrecognise > ?when something _is_ a macro it doesn't understand, and refrain from > ?warning about it in that case. Is it possible to get the C preprocessor to expand the macros without stripping the comments? Run the kerneldoc validator on that? Andrew ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [RFC PATCH net-next v1 00/11] make drivers/net/ethernet W=1 clean 2020-09-11 1:23 ` [Intel-wired-lan] " Jesse Brandeburg @ 2020-09-11 14:55 ` Jakub Kicinski -1 siblings, 0 replies; 68+ messages in thread From: Jakub Kicinski @ 2020-09-11 14:55 UTC (permalink / raw) To: Jesse Brandeburg; +Cc: netdev, intel-wired-lan On Thu, 10 Sep 2020 18:23:26 -0700 Jesse Brandeburg wrote: > This series is a placeholder to show I've about finished this work. > > After applying the patches below, the drivers/net/ethernet > directory can be built as modules with W=1 with no warnings. > > This series removes 1,283 warnings and hopefully allows the ethernet > directory to move forward from here without more warnings being added. > > Some of these patches are already sent to Intel Wired Lan, but the rest > of the series titled drivers/net/ethernet affects other drivers, not > just Intel, but they depend on the first five. Great stuff. Much easier to apply one large series than a thousand small patches. I haven't read all the comment changes but FWIW: Reviewed-by: Jakub Kicinski <kuba@kernel.org> I feel slightly bad for saying this but I think your config did not include all the drivers, 'cause I'm still getting some warnings after patch 11. Regardless this is impressive effort, thanks! ^ permalink raw reply [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 00/11] make drivers/net/ethernet W=1 clean @ 2020-09-11 14:55 ` Jakub Kicinski 0 siblings, 0 replies; 68+ messages in thread From: Jakub Kicinski @ 2020-09-11 14:55 UTC (permalink / raw) To: intel-wired-lan On Thu, 10 Sep 2020 18:23:26 -0700 Jesse Brandeburg wrote: > This series is a placeholder to show I've about finished this work. > > After applying the patches below, the drivers/net/ethernet > directory can be built as modules with W=1 with no warnings. > > This series removes 1,283 warnings and hopefully allows the ethernet > directory to move forward from here without more warnings being added. > > Some of these patches are already sent to Intel Wired Lan, but the rest > of the series titled drivers/net/ethernet affects other drivers, not > just Intel, but they depend on the first five. Great stuff. Much easier to apply one large series than a thousand small patches. I haven't read all the comment changes but FWIW: Reviewed-by: Jakub Kicinski <kuba@kernel.org> I feel slightly bad for saying this but I think your config did not include all the drivers, 'cause I'm still getting some warnings after patch 11. Regardless this is impressive effort, thanks! ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [RFC PATCH net-next v1 00/11] make drivers/net/ethernet W=1 clean 2020-09-11 14:55 ` [Intel-wired-lan] " Jakub Kicinski @ 2020-09-11 19:00 ` Jesse Brandeburg -1 siblings, 0 replies; 68+ messages in thread From: Jesse Brandeburg @ 2020-09-11 19:00 UTC (permalink / raw) To: Jakub Kicinski; +Cc: netdev, intel-wired-lan Jakub Kicinski wrote: > On Thu, 10 Sep 2020 18:23:26 -0700 Jesse Brandeburg wrote: > > Some of these patches are already sent to Intel Wired Lan, but the rest > > of the series titled drivers/net/ethernet affects other drivers, not > > just Intel, but they depend on the first five. > > Great stuff. Much easier to apply one large series than a thousand > small patches. I haven't read all the comment changes but FWIW: > > Reviewed-by: Jakub Kicinski <kuba@kernel.org> Thanks! > I feel slightly bad for saying this but I think your config did not > include all the drivers, 'cause I'm still getting some warnings after > patch 11. Regardless this is impressive effort, thanks! No worries! I want to get it right, can you share your methodology? I saw from some other message that you're doing make CC="ccache gcc" allmodconfig make CC="ccache gcc" -j 64 W=1 C=1 Is that the right sequence? did you start with a make mrproper as well? I may have missed some drivers when I did this: make allyesconfig make menuconfig <turn on all "Ethernet Drivers" = m manually> but I'd like to target the actual job you're running and use that as the short-term goal. Also, if you have any comments about the removal of the lvalue from some of the register read operations, I figure that is the riskiest part of all this. ^ permalink raw reply [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 00/11] make drivers/net/ethernet W=1 clean @ 2020-09-11 19:00 ` Jesse Brandeburg 0 siblings, 0 replies; 68+ messages in thread From: Jesse Brandeburg @ 2020-09-11 19:00 UTC (permalink / raw) To: intel-wired-lan Jakub Kicinski wrote: > On Thu, 10 Sep 2020 18:23:26 -0700 Jesse Brandeburg wrote: > > Some of these patches are already sent to Intel Wired Lan, but the rest > > of the series titled drivers/net/ethernet affects other drivers, not > > just Intel, but they depend on the first five. > > Great stuff. Much easier to apply one large series than a thousand > small patches. I haven't read all the comment changes but FWIW: > > Reviewed-by: Jakub Kicinski <kuba@kernel.org> Thanks! > I feel slightly bad for saying this but I think your config did not > include all the drivers, 'cause I'm still getting some warnings after > patch 11. Regardless this is impressive effort, thanks! No worries! I want to get it right, can you share your methodology? I saw from some other message that you're doing make CC="ccache gcc" allmodconfig make CC="ccache gcc" -j 64 W=1 C=1 Is that the right sequence? did you start with a make mrproper as well? I may have missed some drivers when I did this: make allyesconfig make menuconfig <turn on all "Ethernet Drivers" = m manually> but I'd like to target the actual job you're running and use that as the short-term goal. Also, if you have any comments about the removal of the lvalue from some of the register read operations, I figure that is the riskiest part of all this. ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [RFC PATCH net-next v1 00/11] make drivers/net/ethernet W=1 clean 2020-09-11 19:00 ` [Intel-wired-lan] " Jesse Brandeburg @ 2020-09-11 20:12 ` Jakub Kicinski -1 siblings, 0 replies; 68+ messages in thread From: Jakub Kicinski @ 2020-09-11 20:12 UTC (permalink / raw) To: Jesse Brandeburg; +Cc: netdev, intel-wired-lan On Fri, 11 Sep 2020 12:00:05 -0700 Jesse Brandeburg wrote: > > I feel slightly bad for saying this but I think your config did not > > include all the drivers, 'cause I'm still getting some warnings after > > patch 11. Regardless this is impressive effort, thanks! > > No worries! I want to get it right, can you share your methodology? > > I saw from some other message that you're doing > make CC="ccache gcc" allmodconfig > make CC="ccache gcc" -j 64 W=1 C=1 > > Is that the right sequence? Yes, that's it. > did you start with a make mrproper as well? Nope, the machine is barely keeping up as is ;) > I may have missed some drivers when I did this: > make allyesconfig > make menuconfig > <turn on all "Ethernet Drivers" = m manually> Yeah, maybe you need COMPILE_TEST? (full list of the warnings triggered by the last patch at the end of the email) > but I'd like to target the actual job you're running and use that as > the short-term goal. If the code is of any use: https://github.com/kuba-moo/nipa But it expects to run against a patchwork instance. > Also, if you have any comments about the removal of the lvalue from > some of the register read operations, I figure that is the riskiest > part of all this. Nothing looked suspicious to me. Besides if the compiler is warning that the variable is unused I'm pretty sure it will optimize that variable out, anyway so machine code shouldn't change with this series. ../drivers/net/ethernet/atheros/atlx/atl1.c:1999:26: warning: cast to restricted __le16 ../drivers/net/ethernet/atheros/atlx/atl1.c:2060:33: warning: cast to restricted __le16 ../drivers/net/ethernet/atheros/atlx/atl1.c:2125:45: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atlx/atl1.c:2125:45: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2125:45: right side has type int ../drivers/net/ethernet/atheros/atlx/atl1.c:2127:45: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atlx/atl1.c:2127:45: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2127:45: right side has type unsigned int ../drivers/net/ethernet/atheros/atlx/atl1.c:2130:45: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atlx/atl1.c:2130:45: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2130:45: right side has type int ../drivers/net/ethernet/atheros/atlx/atl1.c:2131:45: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atlx/atl1.c:2131:45: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2131:45: right side has type int ../drivers/net/ethernet/atheros/atlx/atl1.c:2141:45: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atlx/atl1.c:2141:45: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2141:45: right side has type int ../drivers/net/ethernet/atheros/atlx/atl1.c:2145:37: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atlx/atl1.c:2145:37: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2145:37: right side has type int ../drivers/net/ethernet/atheros/atlx/atl1.c:2147:37: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atlx/atl1.c:2147:37: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2147:37: right side has type unsigned int ../drivers/net/ethernet/atheros/atlx/atl1.c:2149:37: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atlx/atl1.c:2149:37: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2149:37: right side has type int ../drivers/net/ethernet/atheros/atlx/atl1.c:2151:37: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atlx/atl1.c:2151:37: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2151:37: right side has type int ../drivers/net/ethernet/atheros/atlx/atl1.c:2173:29: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atlx/atl1.c:2173:29: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2173:29: right side has type int ../drivers/net/ethernet/atheros/atlx/atl1.c:2175:29: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atlx/atl1.c:2175:29: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2175:29: right side has type int ../drivers/net/ethernet/atheros/atlx/atl1.c:2177:29: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atlx/atl1.c:2177:29: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2177:29: right side has type int ../drivers/net/ethernet/atheros/atlx/atl1.c:2206:23: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atlx/atl1.c:2303:28: warning: invalid assignment: &= ../drivers/net/ethernet/atheros/atlx/atl1.c:2303:28: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2303:28: right side has type int ../drivers/net/ethernet/atheros/atlx/atl1.c:2304:32: warning: restricted __le16 degrades to integer ../drivers/net/ethernet/atheros/atlx/atl1.c:2304:28: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atlx/atl1.c:2304:28: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2304:28: right side has type int ../drivers/net/ethernet/atheros/atlx/atl1.c:2311:27: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atlx/atl1.c:2315:44: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atlx/atl1.c:2315:44: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2315:44: right side has type int ../drivers/net/ethernet/atheros/atlx/atl1.c:2317:44: warning: invalid assignment: &= ../drivers/net/ethernet/atheros/atlx/atl1.c:2317:44: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2317:44: right side has type int ../drivers/net/ethernet/atheros/atlx/atl1.c:2321:36: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atlx/atl1.c:2321:36: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2321:36: right side has type int ../drivers/net/ethernet/atheros/atlx/atl1.c:2401:29: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atlx/atl1.c:2401:29: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2401:29: right side has type int ../drivers/net/ethernet/atheros/atlx/atl1.c:2402:29: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atlx/atl1.c:2402:29: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2402:29: right side has type int ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1923:28: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1923:28: expected unsigned short [assigned] [usertype] clscode ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1923:28: got restricted __be16 [usertype] ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1924:25: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1924:25: expected unsigned short [assigned] [usertype] rsvd ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1924:25: got restricted __be16 [usertype] ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1926:29: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1926:29: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1926:29: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1926:29: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1926:29: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1926:29: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1937:29: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1937:29: expected unsigned short [assigned] [usertype] clscode ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1937:29: got restricted __be16 [usertype] ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1938:26: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1938:26: expected unsigned short [assigned] [usertype] rsvd ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1938:26: got restricted __be16 [usertype] ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1940:30: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1940:30: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1940:30: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1940:30: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1940:30: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1940:30: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1903:24: warning: incorrect type in argument 1 (different base types) ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1903:24: expected unsigned int val ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1903:24: got restricted __le32 [usertype] ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2105:31: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2105:31: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2105:31: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2105:31: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2105:31: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2105:31: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2106:31: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2106:31: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2106:31: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2106:31: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2106:31: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2106:31: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2107:31: warning: cast to restricted __be16 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2107:31: warning: cast to restricted __be16 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2107:31: warning: cast to restricted __be16 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2107:31: warning: cast to restricted __be16 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2209:26: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2209:26: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2209:26: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2209:26: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2209:26: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2209:26: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2422:25: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2422:25: expected unsigned int [usertype] ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2422:25: got restricted __be32 [usertype] ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3068:21: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3068:21: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3068:21: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3068:21: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3068:21: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3068:21: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3070:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3070:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3070:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3070:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3070:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3070:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3073:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3073:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3073:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3073:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3073:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3073:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3101:21: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3101:21: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3101:21: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3101:21: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3101:21: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3101:21: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3103:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3103:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3103:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3103:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3103:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3103:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3106:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3106:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3106:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3106:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3106:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3106:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3140:26: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3140:26: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3140:26: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3140:26: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3140:26: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3140:26: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3147:40: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3147:40: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3147:40: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3147:40: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3147:40: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3147:40: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3148:39: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3148:39: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3148:39: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3148:39: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3148:39: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3148:39: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3151:41: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3151:41: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3151:41: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3151:41: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3151:41: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3151:41: warning: too many warnings ../drivers/net/ethernet/brocade/bna/bfa_cee.c:42:25: warning: cast to restricted __be16 ../drivers/net/ethernet/brocade/bna/bfa_cee.c:42:25: warning: cast to restricted __be16 ../drivers/net/ethernet/brocade/bna/bfa_cee.c:42:25: warning: cast to restricted __be16 ../drivers/net/ethernet/brocade/bna/bfa_cee.c:42:25: warning: cast to restricted __be16 ../drivers/net/ethernet/brocade/bna/bfa_cee.c:44:25: warning: cast to restricted __be16 ../drivers/net/ethernet/brocade/bna/bfa_cee.c:44:25: warning: cast to restricted __be16 ../drivers/net/ethernet/brocade/bna/bfa_cee.c:44:25: warning: cast to restricted __be16 ../drivers/net/ethernet/brocade/bna/bfa_cee.c:44:25: warning: cast to restricted __be16 ../drivers/net/ethernet/brocade/bna/bfa_cee.c:34:29: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_cee.c:34:29: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_cee.c:34:29: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_cee.c:34:29: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_cee.c:34:29: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_cee.c:34:29: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_cee.c: note: in included file (through ../drivers/net/ethernet/brocade/bna/bfa_cee.h): ../drivers/net/ethernet/brocade/bna/bfa_ioc.h:55:34: warning: cast from restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.h:56:34: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:280:16: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/cadence/macb_main.c:280:16: expected unsigned int [usertype] bottom ../drivers/net/ethernet/cadence/macb_main.c:280:16: got restricted __le32 [usertype] ../drivers/net/ethernet/cadence/macb_main.c:282:13: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/cadence/macb_main.c:282:13: expected unsigned short [usertype] top ../drivers/net/ethernet/cadence/macb_main.c:282:13: got restricted __le16 [usertype] ../drivers/net/ethernet/cadence/macb_main.c:3087:39: warning: restricted __be32 degrades to integer ../drivers/net/ethernet/cadence/macb_main.c:3092:39: warning: restricted __be32 degrades to integer ../drivers/net/ethernet/cadence/macb_main.c:3097:40: warning: restricted __be16 degrades to integer ../drivers/net/ethernet/cadence/macb_main.c:3097:69: warning: restricted __be16 degrades to integer ../drivers/net/ethernet/cadence/macb_main.c:3119:20: warning: restricted __be32 degrades to integer ../drivers/net/ethernet/cadence/macb_main.c:3123:20: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/cadence/macb_main.c:3123:20: expected unsigned int [assigned] [usertype] w0 ../drivers/net/ethernet/cadence/macb_main.c:3123:20: got restricted __be32 [usertype] ip4src ../drivers/net/ethernet/cadence/macb_main.c:3133:20: warning: restricted __be32 degrades to integer ../drivers/net/ethernet/cadence/macb_main.c:3137:20: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/cadence/macb_main.c:3137:20: expected unsigned int [assigned] [usertype] w0 ../drivers/net/ethernet/cadence/macb_main.c:3137:20: got restricted __be32 [usertype] ip4dst ../drivers/net/ethernet/cadence/macb_main.c:3147:21: warning: restricted __be16 degrades to integer ../drivers/net/ethernet/cadence/macb_main.c:3147:50: warning: restricted __be16 degrades to integer ../drivers/net/ethernet/cadence/macb_main.c:3153:30: warning: restricted __be16 degrades to integer ../drivers/net/ethernet/cadence/macb_main.c:3154:30: warning: restricted __be16 degrades to integer ../drivers/net/ethernet/cadence/macb_main.c:3161:36: warning: restricted __be16 degrades to integer ../drivers/net/ethernet/cadence/macb_main.c:3162:38: warning: restricted __be16 degrades to integer ../drivers/net/ethernet/cadence/macb_main.c:3165:38: warning: restricted __be16 degrades to integer ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: incorrect type in argument 1 (different base types) ../drivers/net/ethernet/cadence/macb_main.c:3201:9: expected unsigned int [usertype] val ../drivers/net/ethernet/cadence/macb_main.c:3201:9: got restricted __be32 [usertype] ip4src ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: incorrect type in argument 1 (different base types) ../drivers/net/ethernet/cadence/macb_main.c:3201:9: expected unsigned int [usertype] val ../drivers/net/ethernet/cadence/macb_main.c:3201:9: got restricted __be32 [usertype] ip4dst ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: cast from restricted __be16 ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: incorrect type in argument 1 (different base types) ../drivers/net/ethernet/cadence/macb_main.c:3201:9: expected unsigned short [usertype] val ../drivers/net/ethernet/cadence/macb_main.c:3201:9: got restricted __be16 [usertype] psrc ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: cast from restricted __be16 ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: cast from restricted __be16 ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: cast from restricted __be16 ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: incorrect type in argument 1 (different base types) ../drivers/net/ethernet/cadence/macb_main.c:3201:9: expected unsigned short [usertype] val ../drivers/net/ethernet/cadence/macb_main.c:3201:9: got restricted __be16 [usertype] pdst ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: cast from restricted __be16 ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: cast from restricted __be16 ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: incorrect type in argument 1 (different base types) ../drivers/net/ethernet/cadence/macb_main.c:3254:25: expected unsigned int [usertype] val ../drivers/net/ethernet/cadence/macb_main.c:3254:25: got restricted __be32 [usertype] ip4src ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: incorrect type in argument 1 (different base types) ../drivers/net/ethernet/cadence/macb_main.c:3254:25: expected unsigned int [usertype] val ../drivers/net/ethernet/cadence/macb_main.c:3254:25: got restricted __be32 [usertype] ip4dst ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: cast from restricted __be16 ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: incorrect type in argument 1 (different base types) ../drivers/net/ethernet/cadence/macb_main.c:3254:25: expected unsigned short [usertype] val ../drivers/net/ethernet/cadence/macb_main.c:3254:25: got restricted __be16 [usertype] psrc ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: cast from restricted __be16 ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: cast from restricted __be16 ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: cast from restricted __be16 ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: incorrect type in argument 1 (different base types) ../drivers/net/ethernet/cadence/macb_main.c:3254:25: expected unsigned short [usertype] val ../drivers/net/ethernet/cadence/macb_main.c:3254:25: got restricted __be16 [usertype] pdst ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: cast from restricted __be16 ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: cast from restricted __be16 ../drivers/net/ethernet/cisco/enic/enic_ethtool.c:441:38: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/cisco/enic/enic_ethtool.c:441:38: expected restricted __be32 [usertype] ip4src ../drivers/net/ethernet/cisco/enic/enic_ethtool.c:441:38: got unsigned int [usertype] ../drivers/net/ethernet/cisco/enic/enic_ethtool.c:444:38: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/cisco/enic/enic_ethtool.c:444:38: expected restricted __be32 [usertype] ip4dst ../drivers/net/ethernet/cisco/enic/enic_ethtool.c:444:38: got unsigned int [usertype] ../drivers/net/ethernet/cisco/enic/enic_ethtool.c:447:36: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/cisco/enic/enic_ethtool.c:447:36: expected restricted __be16 [usertype] psrc ../drivers/net/ethernet/cisco/enic/enic_ethtool.c:447:36: got unsigned short [usertype] ../drivers/net/ethernet/cisco/enic/enic_ethtool.c:450:36: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/cisco/enic/enic_ethtool.c:450:36: expected restricted __be16 [usertype] pdst ../drivers/net/ethernet/cisco/enic/enic_ethtool.c:450:36: got unsigned short [usertype] ../drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:521:30: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:521:30: expected restricted __be16 [usertype] l2t_idx ../drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:521:30: got restricted __be32 [usertype] ../drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:279:11: warning: symbol 'dmae_reg_go_c' was not declared. Should it be static? ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1446:45: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1474:46: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1663:44: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1663:44: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1663:44: right side has type int ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1666:44: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1666:44: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1666:44: right side has type unsigned int ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1669:44: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1669:44: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1669:44: right side has type int ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1671:44: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1671:44: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1671:44: right side has type int ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1688:36: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1688:36: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1688:36: right side has type int ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1690:36: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1690:36: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1690:36: right side has type int ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1692:36: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1692:36: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1692:36: right side has type int ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1715:23: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1732:42: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1733:27: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1732:32: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1732:32: expected restricted __le32 [usertype] word2 ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1732:32: got unsigned int ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1777:42: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1778:27: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1777:32: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1777:32: expected restricted __le32 [usertype] word2 ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1777:32: got unsigned int ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1827:50: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1828:43: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1827:40: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1827:40: expected restricted __le32 [usertype] word2 ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1827:40: got unsigned int ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1833:17: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1835:28: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1835:28: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1835:28: right side has type int ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1838:24: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1838:24: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1838:24: right side has type int ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1887:28: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1887:28: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1887:28: right side has type int ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1889:28: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1889:28: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1889:28: right side has type int ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1894:28: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1894:28: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1894:28: right side has type int ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1897:28: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1897:28: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1897:28: right side has type int ../drivers/net/ethernet/chelsio/cxgb3/t3_hw.c:681:67: warning: incorrect type in argument 3 (different base types) ../drivers/net/ethernet/chelsio/cxgb3/t3_hw.c:681:67: expected restricted __le32 [usertype] data ../drivers/net/ethernet/chelsio/cxgb3/t3_hw.c:681:67: got int ../drivers/net/ethernet/chelsio/cxgb3/t3_hw.c:898:31: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/chelsio/cxgb3/t3_hw.c:898:31: expected unsigned int [usertype] ../drivers/net/ethernet/chelsio/cxgb3/t3_hw.c:898:31: got restricted __be32 [usertype] ../drivers/net/ethernet/chelsio/cxgb3/t3_hw.c:3666:52: warning: dubious: !x | y ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1804:21: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1805:39: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1818:24: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1827:26: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1827:26: warning: cast to restricted __le16 ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1831:41: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1848:24: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1851:25: warning: restricted __le16 degrades to integer ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1851:25: warning: restricted __le16 degrades to integer ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1852:32: warning: cast to restricted __le16 ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1761:28: warning: invalid assignment: &= ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1761:28: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1761:28: right side has type unsigned int ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1774:25: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2007:47: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2007:47: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2007:47: right side has type int ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2029:37: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2029:37: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2029:37: right side has type int ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2030:37: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2030:37: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2030:37: right side has type int ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2032:39: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2032:39: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2032:39: right side has type int ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2035:31: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2035:31: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2035:31: right side has type int ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2036:31: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2036:31: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2036:31: right side has type int ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2038:31: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2038:31: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2038:31: right side has type int ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2056:39: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2056:39: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2056:39: right side has type int ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2058:39: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2058:39: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2058:39: right side has type int ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2060:39: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2060:39: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2060:39: right side has type int ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2103:19: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2172:24: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2172:24: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2172:24: right side has type int ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2228:22: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2228:22: expected unsigned short [usertype] vlan ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2228:22: got restricted __le16 [usertype] ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2229:17: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2229:17: expected restricted __le16 [usertype] tag ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2229:17: got int ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2230:28: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2230:28: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2230:28: right side has type int ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2235:28: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2235:28: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2235:28: right side has type int ../drivers/net/ethernet/chelsio/cxgb3/sge.c:2373:50: warning: incorrect type in argument 1 (different base types) ../drivers/net/ethernet/chelsio/cxgb3/sge.c:2373:50: expected unsigned int [usertype] rss ../drivers/net/ethernet/chelsio/cxgb3/sge.c:2373:50: got restricted __be32 [assigned] [usertype] rss_hi ../drivers/net/ethernet/chelsio/cxgb3/sge.c:2436:43: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/chelsio/cxgb3/sge.c:2436:43: expected restricted __wsum [usertype] csum ../drivers/net/ethernet/chelsio/cxgb3/sge.c:2436:43: got restricted __be32 [assigned] [usertype] rss_hi ../drivers/net/ethernet/chelsio/cxgb3/sge.c:2437:47: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/chelsio/cxgb3/sge.c:2437:47: expected unsigned int [usertype] priority ../drivers/net/ethernet/chelsio/cxgb3/sge.c:2437:47: got restricted __be32 [assigned] [usertype] rss_lo ../drivers/net/ethernet/chelsio/cxgb3/sge.c:2118:16: warning: cast to restricted __be32 ../drivers/net/ethernet/chelsio/cxgb3/sge.c:2118:16: warning: cast to restricted __be32 ../drivers/net/ethernet/chelsio/cxgb3/sge.c:2118:16: warning: cast to restricted __be32 ../drivers/net/ethernet/chelsio/cxgb3/sge.c:2118:16: warning: cast to restricted __be32 ../drivers/net/ethernet/chelsio/cxgb3/sge.c:2118:16: warning: cast to restricted __be32 ../drivers/net/ethernet/chelsio/cxgb3/sge.c:2118:16: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_main.c:831:25: warning: cast to restricted __be16 ../drivers/net/ethernet/huawei/hinic/hinic_main.c:831:25: warning: cast to restricted __be16 ../drivers/net/ethernet/huawei/hinic/hinic_main.c:831:25: warning: cast to restricted __be16 ../drivers/net/ethernet/huawei/hinic/hinic_main.c:831:25: warning: cast to restricted __be16 ../drivers/net/ethernet/micrel/ksz884x.c:3519:50: warning: restricted pci_power_t degrades to integer ../drivers/net/ethernet/micrel/ksz884x.c:3840:37: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:3840:37: expected unsigned int [usertype] next ../drivers/net/ethernet/micrel/ksz884x.c:3840:37: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:3842:29: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:3842:29: expected unsigned int [usertype] next ../drivers/net/ethernet/micrel/ksz884x.c:3842:29: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:3844:33: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:3844:33: expected unsigned int [usertype] data ../drivers/net/ethernet/micrel/ksz884x.c:3844:33: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:4750:31: warning: cast to restricted __le32 ../drivers/net/ethernet/micrel/ksz884x.c:5043:31: warning: cast to restricted __le32 ../drivers/net/ethernet/micrel/ksz884x.c:5079:31: warning: cast to restricted __le32 ../drivers/net/ethernet/micrel/ksz884x.c:5124:31: warning: cast to restricted __le32 ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: expected unsigned int [usertype] data ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: expected unsigned int [usertype] data ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:1619:25: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1619:25: expected unsigned int [usertype] addr ../drivers/net/ethernet/micrel/ksz884x.c:1619:25: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: expected unsigned int [usertype] data ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: expected unsigned int [usertype] data ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:1639:25: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1639:25: expected unsigned int [usertype] addr ../drivers/net/ethernet/micrel/ksz884x.c:1639:25: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:1639:25: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1639:25: expected unsigned int [usertype] addr ../drivers/net/ethernet/micrel/ksz884x.c:1639:25: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: expected unsigned int [usertype] data ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: expected unsigned int [usertype] data ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: expected unsigned int [usertype] data ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: expected unsigned int [usertype] data ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:1639:25: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1639:25: expected unsigned int [usertype] addr ../drivers/net/ethernet/micrel/ksz884x.c:1639:25: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:1595:30: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1595:30: expected unsigned int [usertype] data ../drivers/net/ethernet/micrel/ksz884x.c:1595:30: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:4966:18: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:4966:18: expected unsigned short protocol ../drivers/net/ethernet/micrel/ksz884x.c:4966:18: got restricted __be16 [usertype] protocol ../drivers/net/ethernet/micrel/ksz884x.c:4969:25: warning: restricted __be16 degrades to integer ../drivers/net/ethernet/micrel/ksz884x.c:4970:26: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:4970:26: expected unsigned short protocol ../drivers/net/ethernet/micrel/ksz884x.c:4970:26: got restricted __be16 [usertype] tot_len ../drivers/net/ethernet/micrel/ksz884x.c:4974:25: warning: restricted __be16 degrades to integer ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: expected unsigned int [usertype] data ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: expected unsigned int [usertype] data ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:4966:18: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:4966:18: expected unsigned short protocol ../drivers/net/ethernet/micrel/ksz884x.c:4966:18: got restricted __be16 [usertype] protocol ../drivers/net/ethernet/micrel/ksz884x.c:4969:25: warning: restricted __be16 degrades to integer ../drivers/net/ethernet/micrel/ksz884x.c:4970:26: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:4970:26: expected unsigned short protocol ../drivers/net/ethernet/micrel/ksz884x.c:4970:26: got restricted __be16 [usertype] tot_len ../drivers/net/ethernet/micrel/ksz884x.c:4974:25: warning: restricted __be16 degrades to integer ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: expected unsigned int [usertype] data ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: expected unsigned int [usertype] data ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:4966:18: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:4966:18: expected unsigned short protocol ../drivers/net/ethernet/micrel/ksz884x.c:4966:18: got restricted __be16 [usertype] protocol ../drivers/net/ethernet/micrel/ksz884x.c:4969:25: warning: restricted __be16 degrades to integer ../drivers/net/ethernet/micrel/ksz884x.c:4970:26: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:4970:26: expected unsigned short protocol ../drivers/net/ethernet/micrel/ksz884x.c:4970:26: got restricted __be16 [usertype] tot_len ../drivers/net/ethernet/micrel/ksz884x.c:4974:25: warning: restricted __be16 degrades to integer ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: expected unsigned int [usertype] data ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: expected unsigned int [usertype] data ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: got restricted __le32 [usertype] ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:333:17: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:333:17: expected unsigned int [addressable] [usertype] db_info ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:333:17: got restricted __be32 [usertype] ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:413:23: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:413:23: expected unsigned long long [usertype] ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:413:23: got restricted __be64 [usertype] ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:536:27: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:536:27: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:536:27: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:536:27: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:536:27: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:536:27: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:577:21: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:577:21: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:577:21: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:577:21: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:577:21: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:577:21: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:625:14: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:625:14: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:625:14: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:625:14: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:625:14: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:625:14: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:630:19: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:630:19: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:630:19: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:630:19: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:630:19: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:630:19: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:661:30: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:661:30: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:661:30: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:661:30: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:661:30: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:661:30: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:707:31: warning: cast to restricted __be64 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:707:31: warning: cast to restricted __be64 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:707:31: warning: cast to restricted __be64 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:707:31: warning: cast to restricted __be64 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:707:31: warning: cast to restricted __be64 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:707:31: warning: cast to restricted __be64 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:707:31: warning: cast to restricted __be64 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:707:31: warning: cast to restricted __be64 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:707:31: warning: cast to restricted __be64 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:707:31: warning: cast to restricted __be64 ../drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c:324:24: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c:324:24: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c:324:24: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c:324:24: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c:324:24: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c:324:24: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c:617:25: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c:617:25: expected unsigned int [usertype] ../drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c:617:25: got restricted __be32 [usertype] ../drivers/net/ethernet/natsemi/ns83820.c:900:39: warning: cast to restricted __be16 ../drivers/net/ethernet/natsemi/ns83820.c:900:39: warning: cast to restricted __be16 ../drivers/net/ethernet/natsemi/ns83820.c:900:39: warning: cast to restricted __be16 ../drivers/net/ethernet/natsemi/ns83820.c:900:39: warning: cast to restricted __be16 ../drivers/net/ethernet/natsemi/ns83820.c:1119:42: warning: restricted __be16 degrades to integer ../drivers/net/ethernet/natsemi/ns83820.c:1982:29: warning: cast to restricted __le32 ../drivers/net/ethernet/neterion/s2io.c:6951:41: warning: cast to restricted __be32 ../drivers/net/ethernet/neterion/s2io.c:6951:41: warning: cast to restricted __be32 ../drivers/net/ethernet/neterion/s2io.c:6951:41: warning: cast to restricted __be32 ../drivers/net/ethernet/neterion/s2io.c:6951:41: warning: cast to restricted __be32 ../drivers/net/ethernet/neterion/s2io.c:6951:41: warning: cast to restricted __be32 ../drivers/net/ethernet/neterion/s2io.c:6951:41: warning: cast to restricted __be32 ../drivers/net/ethernet/neterion/s2io.c: note: in included file: ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (4c0d000000000000 becomes 0) ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (4c0d000000000000 becomes 0) ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (f00000000000000 becomes 0) ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (ffbbffbbffbbffbb becomes ffbbffbb) ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (ffbbffbbffbbffbb becomes ffbbffbb) ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (4c0d000000000000 becomes 0) ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (4c0d000000000000 becomes 0) ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (4c0d000000000000 becomes 0) ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (4c0d000000000000 becomes 0) ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (7f00000001 becomes 1) ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (102030405060000 becomes 5060000) ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (feffffffffff0000 becomes ffff0000) ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (4c0d000000000000 becomes 0) ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (4c0d000000000000 becomes 0) ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (4c0d000000000000 becomes 0) ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (4c0d000000000000 becomes 0) ../drivers/net/ethernet/neterion/vxge/vxge-config.c:890:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:890:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:890:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:890:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:890:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:890:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:890:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:890:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:890:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:890:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:891:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:891:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:891:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:891:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:891:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:891:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:891:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:891:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:891:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:891:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:903:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:903:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:903:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:903:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:903:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:903:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:903:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:903:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:903:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:903:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:904:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:904:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:904:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:904:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:904:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:904:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:904:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:904:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:904:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:904:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:918:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:918:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:918:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:918:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:918:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:918:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:918:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:918:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:918:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:918:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:919:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:919:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:919:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:919:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:919:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:919:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:919:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:919:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:919:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:919:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:157:1: warning: context imbalance in 'vxge_hw_vpath_fw_api' - different lock contexts for basic block ../drivers/net/ethernet/neterion/vxge/vxge-traffic.c: note: in included file: ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (1000000000000000 becomes 0) ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (100000000000000 becomes 0) ../drivers/net/ethernet/neterion/vxge/vxge-config.c: note: in included file: ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (8000000000000000 becomes 0) ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (100000000000000 becomes 0) ../drivers/net/ethernet/packetengines/yellowfin.c:1248:37: warning: cast from restricted __le32 ../drivers/net/ethernet/packetengines/yellowfin.c:1248:37: warning: cast from restricted __le32 ../drivers/net/ethernet/packetengines/yellowfin.c:1248:37: warning: cast from restricted __le32 ../drivers/net/ethernet/packetengines/yellowfin.c:1248:37: warning: cast from restricted __le32 ../drivers/net/ethernet/packetengines/yellowfin.c:1248:37: warning: cast from restricted __le32 ../drivers/net/ethernet/packetengines/yellowfin.c:1248:37: warning: cast from restricted __le32 ../drivers/net/ethernet/packetengines/yellowfin.c:1248:37: warning: cast from restricted __le32 ../drivers/net/ethernet/packetengines/yellowfin.c:1248:37: warning: cast from restricted __le32 ../drivers/net/ethernet/packetengines/yellowfin.c:1248:37: warning: cast from restricted __le32 ../drivers/net/ethernet/packetengines/yellowfin.c:1253:49: warning: cast from restricted __le32 ../drivers/net/ethernet/packetengines/yellowfin.c:1253:49: warning: cast from restricted __le32 ../drivers/net/ethernet/packetengines/yellowfin.c:1253:49: warning: cast from restricted __le32 ../drivers/net/ethernet/packetengines/yellowfin.c:1253:49: warning: cast from restricted __le32 ../drivers/net/ethernet/packetengines/yellowfin.c:1253:49: warning: cast from restricted __le32 ../drivers/net/ethernet/packetengines/yellowfin.c:1253:49: warning: cast from restricted __le32 ../drivers/net/ethernet/packetengines/yellowfin.c:1253:49: warning: cast from restricted __le32 ../drivers/net/ethernet/packetengines/yellowfin.c:1253:49: warning: cast from restricted __le32 ../drivers/net/ethernet/packetengines/yellowfin.c:1253:49: warning: cast from restricted __le32 ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:2135:41: warning: incorrect type in argument 1 (different address spaces) ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:2135:41: expected void *reg ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:2135:41: got unsigned int [noderef] __iomem * ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:157:33: warning: incorrect type in argument 2 (different base types) ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:157:33: expected unsigned short [usertype] uid_hi ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:157:33: got restricted __be16 [usertype] ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:157:45: warning: incorrect type in argument 3 (different base types) ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:157:45: expected unsigned int [usertype] uid_lo ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:157:45: got restricted __be32 [usertype] ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:157:56: warning: incorrect type in argument 4 (different base types) ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:157:56: expected unsigned short [usertype] seqid ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:157:56: got restricted __be16 [usertype] ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:306:26: warning: incorrect type in argument 1 (different address spaces) ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:306:26: expected void const [noderef] __iomem * ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:306:26: got void *reg ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:336:33: warning: incorrect type in argument 1 (different address spaces) ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:336:33: expected void *reg ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:336:33: got unsigned int [noderef] __iomem * ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:343:33: warning: incorrect type in argument 1 (different address spaces) ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:343:33: expected void *reg ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:343:33: got unsigned int [noderef] __iomem * ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:356:33: warning: incorrect type in argument 1 (different address spaces) ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:356:33: expected void *reg ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:356:33: got unsigned int [noderef] __iomem * ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:397:33: warning: incorrect type in argument 1 (different address spaces) ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:397:33: expected void *reg ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:397:33: got unsigned int [noderef] __iomem * ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:466:41: warning: incorrect type in argument 1 (different address spaces) ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:466:41: expected void *reg ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:466:41: got unsigned int [noderef] __iomem * ../drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c:1035:24: warning: cast to restricted __le64 ../drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c:1037:24: warning: cast to restricted __le64 ../drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c:2133:17: warning: cast truncates bits from constant value (42110030 becomes 30) ../drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c:2133:17: warning: cast truncates bits from constant value (42110030 becomes 30) ../drivers/net/ethernet/neterion/vxge/vxge-main.c:116:27: warning: context imbalance in 'vxge_poll_inta' - different lock contexts for basic block ../drivers/net/ethernet/neterion/vxge/vxge-main.c:116:27: warning: context imbalance in 'vxge_netpoll' - different lock contexts for basic block ../drivers/net/ethernet/neterion/vxge/vxge-main.c:116:27: warning: context imbalance in 'vxge_tx_msix_handle' - different lock contexts for basic block ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:573:25: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:576:38: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:575:31: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:575:62: warning: incorrect type in initializer (different base types) ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:575:62: expected restricted __le32 [usertype] offs ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:575:62: got unsigned int ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:577:35: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:579:21: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:580:66: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:603:54: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:603:64: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:603:20: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:617:22: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:629:63: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:629:26: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:628:20: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:635:18: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:635:55: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:634:16: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:638:21: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:638:50: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:652:22: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:664:63: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:664:26: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:663:20: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:670:18: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:670:55: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:669:16: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:672:21: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:672:50: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:699:55: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:699:65: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:699:20: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:705:25: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:712:38: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:711:24: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:711:22: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:711:22: expected restricted __le32 [usertype] offs ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:711:22: got unsigned int ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:713:25: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:714:32: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:719:33: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:720:62: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:768:19: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:768:19: warning: incorrect type in initializer (different base types) ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:768:19: expected int idx ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:768:19: got restricted __le32 [usertype] ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:779:26: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:778:16: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:778:14: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:778:14: expected restricted __le32 [usertype] offs ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:778:14: got unsigned int ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:781:48: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:790:22: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:790:22: expected unsigned int [usertype] offs ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:790:22: got restricted __le32 [usertype] ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:803:22: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:803:22: expected unsigned int [usertype] offs ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:803:22: got restricted __le32 [usertype] ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:835:38: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:836:33: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:849:33: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:849:24: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:849:48: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:849:45: warning: incorrect type in return expression (different base types) ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:849:45: expected restricted __le32 ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:849:45: got unsigned int ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:862:28: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:864:25: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:864:45: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:865:58: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:864:70: warning: incorrect type in return expression (different base types) ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:864:70: expected restricted __le32 ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:864:70: got unsigned int ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:913:21: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:913:21: expected unsigned int [usertype] val ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:913:21: got restricted __le32 ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1001:72: warning: incorrect type in argument 3 (different base types) ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1001:72: expected unsigned long long [usertype] ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1001:72: got restricted __le64 [assigned] [usertype] data ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1016:60: warning: incorrect type in argument 3 (different base types) ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1016:60: expected unsigned long long [usertype] ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1016:60: got restricted __le64 [assigned] [usertype] data ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1027:60: warning: incorrect type in argument 3 (different base types) ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1027:60: expected unsigned long long [usertype] ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1027:60: got restricted __le64 [assigned] [usertype] data ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1101:23: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1101:23: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1101:23: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1125:24: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1125:24: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1125:24: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1125:22: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1125:22: expected restricted __le32 [addressable] [usertype] flash_fw_ver ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1125:22: got unsigned int ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1129:46: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1141:21: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c:894:25: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c:894:25: expected unsigned int [usertype] ../drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c:894:25: got restricted __le32 [usertype] ../drivers/net/ethernet/qlogic/netxen/netxen_nic_ctx.c:201:31: warning: cast to restricted __le32 ../drivers/net/ethernet/sun/cassini.c:236:9: warning: context imbalance in 'cas_shutdown' - different lock contexts for basic block ../drivers/net/ethernet/sun/cassini.c:236:9: warning: context imbalance in 'cas_reset_task' - different lock contexts for basic block ../drivers/net/ethernet/via/via-rhine.c:1149:39: warning: cast removes address space '__iomem' of expression ../drivers/net/ethernet/sun/cassini.c:236:9: warning: context imbalance in 'cas_link_timer' - different lock contexts for basic block ../drivers/net/ethernet/sun/cassini.c:236:9: warning: context imbalance in 'cas_open' - different lock contexts for basic block ../drivers/net/ethernet/sun/cassini.c:236:9: warning: context imbalance in 'cas_close' - different lock contexts for basic block ../drivers/net/ethernet/sun/cassini.c:236:9: warning: context imbalance in 'cas_suspend' - different lock contexts for basic block ../drivers/net/ethernet/sun/cassini.c:236:9: warning: context imbalance in 'cas_resume' - different lock contexts for basic block ../drivers/net/ethernet/via/via-velocity.c: note: in included file: ../drivers/net/ethernet/via/via-velocity.h:237:24: warning: mixed bitwiseness ../drivers/net/ethernet/via/via-velocity.c:88:26: warning: incorrect type in initializer (different address spaces) ../drivers/net/ethernet/via/via-velocity.c:88:26: expected void *addr ../drivers/net/ethernet/via/via-velocity.c:88:26: got struct mac_regs [noderef] __iomem *mac_regs ../drivers/net/ethernet/via/via-velocity.c:91:49: warning: incorrect type in argument 2 (different base types) ../drivers/net/ethernet/via/via-velocity.c:91:49: expected restricted pci_power_t [usertype] state ../drivers/net/ethernet/via/via-velocity.c:91:49: got char state ../drivers/net/ethernet/via/via-velocity.c:93:36: warning: incorrect type in argument 2 (different address spaces) ../drivers/net/ethernet/via/via-velocity.c:93:36: expected void volatile [noderef] __iomem *addr ../drivers/net/ethernet/via/via-velocity.c:93:36: got void * ../drivers/net/ethernet/via/via-velocity.c:1745:34: warning: cast from restricted __le16 ../drivers/net/ethernet/via/via-velocity.c:1745:34: warning: cast from restricted __le16 ../drivers/net/ethernet/via/via-velocity.c:1745:34: warning: cast from restricted __le16 ../drivers/net/ethernet/via/via-velocity.c:1745:34: warning: cast from restricted __le16 ../drivers/net/ethernet/via/via-velocity.c:1745:34: warning: cast from restricted __le16 ../drivers/net/ethernet/via/via-velocity.c:1745:34: warning: cast from restricted __le16 ../drivers/net/ethernet/via/via-velocity.c:1748:17: warning: cast to restricted __le16 ../drivers/net/ethernet/via/via-velocity.c:2241:40: warning: incorrect type in argument 2 (different base types) ../drivers/net/ethernet/via/via-velocity.c:2241:40: expected char state ../drivers/net/ethernet/via/via-velocity.c:2241:40: got restricted pci_power_t [usertype] ../drivers/net/ethernet/via/via-velocity.c:2249:48: warning: incorrect type in argument 2 (different base types) ../drivers/net/ethernet/via/via-velocity.c:2249:48: expected char state ../drivers/net/ethernet/via/via-velocity.c:2249:48: got restricted pci_power_t [usertype] ../drivers/net/ethernet/via/via-velocity.c:2436:48: warning: incorrect type in argument 2 (different base types) ../drivers/net/ethernet/via/via-velocity.c:2436:48: expected char state ../drivers/net/ethernet/via/via-velocity.c:2436:48: got restricted pci_power_t [usertype] ../drivers/net/ethernet/via/via-velocity.c:2449:48: warning: incorrect type in argument 2 (different base types) ../drivers/net/ethernet/via/via-velocity.c:2449:48: expected char state ../drivers/net/ethernet/via/via-velocity.c:2449:48: got restricted pci_power_t [usertype] ../drivers/net/ethernet/via/via-velocity.c:2874:40: warning: incorrect type in argument 2 (different base types) ../drivers/net/ethernet/via/via-velocity.c:2874:40: expected char state ../drivers/net/ethernet/via/via-velocity.c:2874:40: got restricted pci_power_t [usertype] ../drivers/net/ethernet/via/via-velocity.c:3149:48: warning: incorrect type in argument 2 (different base types) ../drivers/net/ethernet/via/via-velocity.c:3149:48: expected char state ../drivers/net/ethernet/via/via-velocity.c:3149:48: got restricted pci_power_t [usertype] ../drivers/net/ethernet/via/via-velocity.c:3155:48: warning: incorrect type in argument 2 (different base types) ../drivers/net/ethernet/via/via-velocity.c:3155:48: expected char state ../drivers/net/ethernet/via/via-velocity.c:3155:48: got restricted pci_power_t [usertype] ../drivers/net/ethernet/via/via-velocity.c:3207:40: warning: incorrect type in argument 2 (different base types) ../drivers/net/ethernet/via/via-velocity.c:3207:40: expected char state ../drivers/net/ethernet/via/via-velocity.c:3207:40: got restricted pci_power_t [usertype] ../drivers/net/ethernet/via/via-velocity.c:3277:48: warning: incorrect type in argument 2 (different base types) ../drivers/net/ethernet/via/via-velocity.c:3277:48: expected char state ../drivers/net/ethernet/via/via-velocity.c:3277:48: got restricted pci_power_t [usertype] ../drivers/net/ethernet/via/via-velocity.c:3294:48: warning: incorrect type in argument 2 (different base types) ../drivers/net/ethernet/via/via-velocity.c:3294:48: expected char state ../drivers/net/ethernet/via/via-velocity.c:3294:48: got restricted pci_power_t [usertype] ../drivers/net/ethernet/ethoc.c:317:13: warning: incorrect type in assignment (different address spaces) ../drivers/net/ethernet/ethoc.c:317:13: expected void *vma ../drivers/net/ethernet/ethoc.c:317:13: got void [noderef] __iomem *membase ../drivers/net/ethernet/ethoc.c:454:67: warning: incorrect type in argument 2 (different address spaces) ../drivers/net/ethernet/ethoc.c:454:67: expected void const volatile [noderef] __iomem * ../drivers/net/ethernet/ethoc.c:454:67: got void *src ../drivers/net/ethernet/ethoc.c:912:21: warning: incorrect type in argument 1 (different address spaces) ../drivers/net/ethernet/ethoc.c:912:21: expected void volatile [noderef] __iomem * ../drivers/net/ethernet/ethoc.c:912:21: got void *[assigned] dest ../drivers/net/ethernet/ethoc.c:1112:31: warning: incorrect type in assignment (different address spaces) ../drivers/net/ethernet/ethoc.c:1112:31: expected void [noderef] __iomem *membase ../drivers/net/ethernet/ethoc.c:1112:31: got void * ^ permalink raw reply [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 00/11] make drivers/net/ethernet W=1 clean @ 2020-09-11 20:12 ` Jakub Kicinski 0 siblings, 0 replies; 68+ messages in thread From: Jakub Kicinski @ 2020-09-11 20:12 UTC (permalink / raw) To: intel-wired-lan On Fri, 11 Sep 2020 12:00:05 -0700 Jesse Brandeburg wrote: > > I feel slightly bad for saying this but I think your config did not > > include all the drivers, 'cause I'm still getting some warnings after > > patch 11. Regardless this is impressive effort, thanks! > > No worries! I want to get it right, can you share your methodology? > > I saw from some other message that you're doing > make CC="ccache gcc" allmodconfig > make CC="ccache gcc" -j 64 W=1 C=1 > > Is that the right sequence? Yes, that's it. > did you start with a make mrproper as well? Nope, the machine is barely keeping up as is ;) > I may have missed some drivers when I did this: > make allyesconfig > make menuconfig > <turn on all "Ethernet Drivers" = m manually> Yeah, maybe you need COMPILE_TEST? (full list of the warnings triggered by the last patch at the end of the email) > but I'd like to target the actual job you're running and use that as > the short-term goal. If the code is of any use: https://github.com/kuba-moo/nipa But it expects to run against a patchwork instance. > Also, if you have any comments about the removal of the lvalue from > some of the register read operations, I figure that is the riskiest > part of all this. Nothing looked suspicious to me. Besides if the compiler is warning that the variable is unused I'm pretty sure it will optimize that variable out, anyway so machine code shouldn't change with this series. ../drivers/net/ethernet/atheros/atlx/atl1.c:1999:26: warning: cast to restricted __le16 ../drivers/net/ethernet/atheros/atlx/atl1.c:2060:33: warning: cast to restricted __le16 ../drivers/net/ethernet/atheros/atlx/atl1.c:2125:45: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atlx/atl1.c:2125:45: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2125:45: right side has type int ../drivers/net/ethernet/atheros/atlx/atl1.c:2127:45: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atlx/atl1.c:2127:45: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2127:45: right side has type unsigned int ../drivers/net/ethernet/atheros/atlx/atl1.c:2130:45: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atlx/atl1.c:2130:45: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2130:45: right side has type int ../drivers/net/ethernet/atheros/atlx/atl1.c:2131:45: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atlx/atl1.c:2131:45: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2131:45: right side has type int ../drivers/net/ethernet/atheros/atlx/atl1.c:2141:45: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atlx/atl1.c:2141:45: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2141:45: right side has type int ../drivers/net/ethernet/atheros/atlx/atl1.c:2145:37: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atlx/atl1.c:2145:37: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2145:37: right side has type int ../drivers/net/ethernet/atheros/atlx/atl1.c:2147:37: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atlx/atl1.c:2147:37: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2147:37: right side has type unsigned int ../drivers/net/ethernet/atheros/atlx/atl1.c:2149:37: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atlx/atl1.c:2149:37: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2149:37: right side has type int ../drivers/net/ethernet/atheros/atlx/atl1.c:2151:37: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atlx/atl1.c:2151:37: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2151:37: right side has type int ../drivers/net/ethernet/atheros/atlx/atl1.c:2173:29: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atlx/atl1.c:2173:29: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2173:29: right side has type int ../drivers/net/ethernet/atheros/atlx/atl1.c:2175:29: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atlx/atl1.c:2175:29: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2175:29: right side has type int ../drivers/net/ethernet/atheros/atlx/atl1.c:2177:29: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atlx/atl1.c:2177:29: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2177:29: right side has type int ../drivers/net/ethernet/atheros/atlx/atl1.c:2206:23: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atlx/atl1.c:2303:28: warning: invalid assignment: &= ../drivers/net/ethernet/atheros/atlx/atl1.c:2303:28: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2303:28: right side has type int ../drivers/net/ethernet/atheros/atlx/atl1.c:2304:32: warning: restricted __le16 degrades to integer ../drivers/net/ethernet/atheros/atlx/atl1.c:2304:28: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atlx/atl1.c:2304:28: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2304:28: right side has type int ../drivers/net/ethernet/atheros/atlx/atl1.c:2311:27: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atlx/atl1.c:2315:44: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atlx/atl1.c:2315:44: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2315:44: right side has type int ../drivers/net/ethernet/atheros/atlx/atl1.c:2317:44: warning: invalid assignment: &= ../drivers/net/ethernet/atheros/atlx/atl1.c:2317:44: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2317:44: right side has type int ../drivers/net/ethernet/atheros/atlx/atl1.c:2321:36: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atlx/atl1.c:2321:36: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2321:36: right side has type int ../drivers/net/ethernet/atheros/atlx/atl1.c:2401:29: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atlx/atl1.c:2401:29: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2401:29: right side has type int ../drivers/net/ethernet/atheros/atlx/atl1.c:2402:29: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atlx/atl1.c:2402:29: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atlx/atl1.c:2402:29: right side has type int ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1923:28: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1923:28: expected unsigned short [assigned] [usertype] clscode ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1923:28: got restricted __be16 [usertype] ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1924:25: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1924:25: expected unsigned short [assigned] [usertype] rsvd ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1924:25: got restricted __be16 [usertype] ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1926:29: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1926:29: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1926:29: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1926:29: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1926:29: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1926:29: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1937:29: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1937:29: expected unsigned short [assigned] [usertype] clscode ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1937:29: got restricted __be16 [usertype] ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1938:26: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1938:26: expected unsigned short [assigned] [usertype] rsvd ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1938:26: got restricted __be16 [usertype] ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1940:30: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1940:30: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1940:30: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1940:30: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1940:30: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1940:30: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1903:24: warning: incorrect type in argument 1 (different base types) ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1903:24: expected unsigned int val ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:1903:24: got restricted __le32 [usertype] ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2105:31: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2105:31: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2105:31: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2105:31: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2105:31: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2105:31: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2106:31: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2106:31: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2106:31: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2106:31: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2106:31: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2106:31: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2107:31: warning: cast to restricted __be16 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2107:31: warning: cast to restricted __be16 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2107:31: warning: cast to restricted __be16 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2107:31: warning: cast to restricted __be16 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2209:26: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2209:26: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2209:26: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2209:26: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2209:26: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2209:26: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2422:25: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2422:25: expected unsigned int [usertype] ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:2422:25: got restricted __be32 [usertype] ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3068:21: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3068:21: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3068:21: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3068:21: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3068:21: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3068:21: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3070:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3070:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3070:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3070:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3070:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3070:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3073:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3073:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3073:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3073:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3073:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3073:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3101:21: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3101:21: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3101:21: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3101:21: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3101:21: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3101:21: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3103:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3103:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3103:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3103:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3103:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3103:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3106:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3106:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3106:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3106:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3106:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3106:23: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3140:26: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3140:26: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3140:26: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3140:26: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3140:26: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3140:26: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3147:40: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3147:40: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3147:40: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3147:40: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3147:40: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3147:40: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3148:39: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3148:39: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3148:39: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3148:39: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3148:39: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3148:39: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3151:41: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3151:41: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3151:41: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3151:41: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3151:41: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.c:3151:41: warning: too many warnings ../drivers/net/ethernet/brocade/bna/bfa_cee.c:42:25: warning: cast to restricted __be16 ../drivers/net/ethernet/brocade/bna/bfa_cee.c:42:25: warning: cast to restricted __be16 ../drivers/net/ethernet/brocade/bna/bfa_cee.c:42:25: warning: cast to restricted __be16 ../drivers/net/ethernet/brocade/bna/bfa_cee.c:42:25: warning: cast to restricted __be16 ../drivers/net/ethernet/brocade/bna/bfa_cee.c:44:25: warning: cast to restricted __be16 ../drivers/net/ethernet/brocade/bna/bfa_cee.c:44:25: warning: cast to restricted __be16 ../drivers/net/ethernet/brocade/bna/bfa_cee.c:44:25: warning: cast to restricted __be16 ../drivers/net/ethernet/brocade/bna/bfa_cee.c:44:25: warning: cast to restricted __be16 ../drivers/net/ethernet/brocade/bna/bfa_cee.c:34:29: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_cee.c:34:29: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_cee.c:34:29: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_cee.c:34:29: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_cee.c:34:29: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_cee.c:34:29: warning: cast to restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_cee.c: note: in included file (through ../drivers/net/ethernet/brocade/bna/bfa_cee.h): ../drivers/net/ethernet/brocade/bna/bfa_ioc.h:55:34: warning: cast from restricted __be32 ../drivers/net/ethernet/brocade/bna/bfa_ioc.h:56:34: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:280:16: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/cadence/macb_main.c:280:16: expected unsigned int [usertype] bottom ../drivers/net/ethernet/cadence/macb_main.c:280:16: got restricted __le32 [usertype] ../drivers/net/ethernet/cadence/macb_main.c:282:13: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/cadence/macb_main.c:282:13: expected unsigned short [usertype] top ../drivers/net/ethernet/cadence/macb_main.c:282:13: got restricted __le16 [usertype] ../drivers/net/ethernet/cadence/macb_main.c:3087:39: warning: restricted __be32 degrades to integer ../drivers/net/ethernet/cadence/macb_main.c:3092:39: warning: restricted __be32 degrades to integer ../drivers/net/ethernet/cadence/macb_main.c:3097:40: warning: restricted __be16 degrades to integer ../drivers/net/ethernet/cadence/macb_main.c:3097:69: warning: restricted __be16 degrades to integer ../drivers/net/ethernet/cadence/macb_main.c:3119:20: warning: restricted __be32 degrades to integer ../drivers/net/ethernet/cadence/macb_main.c:3123:20: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/cadence/macb_main.c:3123:20: expected unsigned int [assigned] [usertype] w0 ../drivers/net/ethernet/cadence/macb_main.c:3123:20: got restricted __be32 [usertype] ip4src ../drivers/net/ethernet/cadence/macb_main.c:3133:20: warning: restricted __be32 degrades to integer ../drivers/net/ethernet/cadence/macb_main.c:3137:20: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/cadence/macb_main.c:3137:20: expected unsigned int [assigned] [usertype] w0 ../drivers/net/ethernet/cadence/macb_main.c:3137:20: got restricted __be32 [usertype] ip4dst ../drivers/net/ethernet/cadence/macb_main.c:3147:21: warning: restricted __be16 degrades to integer ../drivers/net/ethernet/cadence/macb_main.c:3147:50: warning: restricted __be16 degrades to integer ../drivers/net/ethernet/cadence/macb_main.c:3153:30: warning: restricted __be16 degrades to integer ../drivers/net/ethernet/cadence/macb_main.c:3154:30: warning: restricted __be16 degrades to integer ../drivers/net/ethernet/cadence/macb_main.c:3161:36: warning: restricted __be16 degrades to integer ../drivers/net/ethernet/cadence/macb_main.c:3162:38: warning: restricted __be16 degrades to integer ../drivers/net/ethernet/cadence/macb_main.c:3165:38: warning: restricted __be16 degrades to integer ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: incorrect type in argument 1 (different base types) ../drivers/net/ethernet/cadence/macb_main.c:3201:9: expected unsigned int [usertype] val ../drivers/net/ethernet/cadence/macb_main.c:3201:9: got restricted __be32 [usertype] ip4src ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: incorrect type in argument 1 (different base types) ../drivers/net/ethernet/cadence/macb_main.c:3201:9: expected unsigned int [usertype] val ../drivers/net/ethernet/cadence/macb_main.c:3201:9: got restricted __be32 [usertype] ip4dst ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: cast from restricted __be16 ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: incorrect type in argument 1 (different base types) ../drivers/net/ethernet/cadence/macb_main.c:3201:9: expected unsigned short [usertype] val ../drivers/net/ethernet/cadence/macb_main.c:3201:9: got restricted __be16 [usertype] psrc ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: cast from restricted __be16 ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: cast from restricted __be16 ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: cast from restricted __be16 ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: incorrect type in argument 1 (different base types) ../drivers/net/ethernet/cadence/macb_main.c:3201:9: expected unsigned short [usertype] val ../drivers/net/ethernet/cadence/macb_main.c:3201:9: got restricted __be16 [usertype] pdst ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: cast from restricted __be16 ../drivers/net/ethernet/cadence/macb_main.c:3201:9: warning: cast from restricted __be16 ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: incorrect type in argument 1 (different base types) ../drivers/net/ethernet/cadence/macb_main.c:3254:25: expected unsigned int [usertype] val ../drivers/net/ethernet/cadence/macb_main.c:3254:25: got restricted __be32 [usertype] ip4src ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: incorrect type in argument 1 (different base types) ../drivers/net/ethernet/cadence/macb_main.c:3254:25: expected unsigned int [usertype] val ../drivers/net/ethernet/cadence/macb_main.c:3254:25: got restricted __be32 [usertype] ip4dst ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: cast from restricted __be32 ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: cast from restricted __be16 ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: incorrect type in argument 1 (different base types) ../drivers/net/ethernet/cadence/macb_main.c:3254:25: expected unsigned short [usertype] val ../drivers/net/ethernet/cadence/macb_main.c:3254:25: got restricted __be16 [usertype] psrc ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: cast from restricted __be16 ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: cast from restricted __be16 ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: cast from restricted __be16 ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: incorrect type in argument 1 (different base types) ../drivers/net/ethernet/cadence/macb_main.c:3254:25: expected unsigned short [usertype] val ../drivers/net/ethernet/cadence/macb_main.c:3254:25: got restricted __be16 [usertype] pdst ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: cast from restricted __be16 ../drivers/net/ethernet/cadence/macb_main.c:3254:25: warning: cast from restricted __be16 ../drivers/net/ethernet/cisco/enic/enic_ethtool.c:441:38: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/cisco/enic/enic_ethtool.c:441:38: expected restricted __be32 [usertype] ip4src ../drivers/net/ethernet/cisco/enic/enic_ethtool.c:441:38: got unsigned int [usertype] ../drivers/net/ethernet/cisco/enic/enic_ethtool.c:444:38: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/cisco/enic/enic_ethtool.c:444:38: expected restricted __be32 [usertype] ip4dst ../drivers/net/ethernet/cisco/enic/enic_ethtool.c:444:38: got unsigned int [usertype] ../drivers/net/ethernet/cisco/enic/enic_ethtool.c:447:36: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/cisco/enic/enic_ethtool.c:447:36: expected restricted __be16 [usertype] psrc ../drivers/net/ethernet/cisco/enic/enic_ethtool.c:447:36: got unsigned short [usertype] ../drivers/net/ethernet/cisco/enic/enic_ethtool.c:450:36: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/cisco/enic/enic_ethtool.c:450:36: expected restricted __be16 [usertype] pdst ../drivers/net/ethernet/cisco/enic/enic_ethtool.c:450:36: got unsigned short [usertype] ../drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:521:30: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:521:30: expected restricted __be16 [usertype] l2t_idx ../drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c:521:30: got restricted __be32 [usertype] ../drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:279:11: warning: symbol 'dmae_reg_go_c' was not declared. Should it be static? ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1446:45: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1474:46: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1663:44: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1663:44: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1663:44: right side has type int ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1666:44: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1666:44: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1666:44: right side has type unsigned int ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1669:44: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1669:44: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1669:44: right side has type int ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1671:44: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1671:44: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1671:44: right side has type int ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1688:36: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1688:36: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1688:36: right side has type int ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1690:36: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1690:36: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1690:36: right side has type int ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1692:36: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1692:36: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1692:36: right side has type int ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1715:23: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1732:42: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1733:27: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1732:32: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1732:32: expected restricted __le32 [usertype] word2 ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1732:32: got unsigned int ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1777:42: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1778:27: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1777:32: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1777:32: expected restricted __le32 [usertype] word2 ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1777:32: got unsigned int ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1827:50: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1828:43: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1827:40: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1827:40: expected restricted __le32 [usertype] word2 ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1827:40: got unsigned int ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1833:17: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1835:28: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1835:28: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1835:28: right side has type int ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1838:24: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1838:24: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1838:24: right side has type int ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1887:28: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1887:28: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1887:28: right side has type int ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1889:28: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1889:28: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1889:28: right side has type int ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1894:28: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1894:28: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1894:28: right side has type int ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1897:28: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1897:28: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1e/atl1e_main.c:1897:28: right side has type int ../drivers/net/ethernet/chelsio/cxgb3/t3_hw.c:681:67: warning: incorrect type in argument 3 (different base types) ../drivers/net/ethernet/chelsio/cxgb3/t3_hw.c:681:67: expected restricted __le32 [usertype] data ../drivers/net/ethernet/chelsio/cxgb3/t3_hw.c:681:67: got int ../drivers/net/ethernet/chelsio/cxgb3/t3_hw.c:898:31: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/chelsio/cxgb3/t3_hw.c:898:31: expected unsigned int [usertype] ../drivers/net/ethernet/chelsio/cxgb3/t3_hw.c:898:31: got restricted __be32 [usertype] ../drivers/net/ethernet/chelsio/cxgb3/t3_hw.c:3666:52: warning: dubious: !x | y ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1804:21: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1805:39: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1818:24: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1827:26: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1827:26: warning: cast to restricted __le16 ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1831:41: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1848:24: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1851:25: warning: restricted __le16 degrades to integer ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1851:25: warning: restricted __le16 degrades to integer ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1852:32: warning: cast to restricted __le16 ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1761:28: warning: invalid assignment: &= ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1761:28: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1761:28: right side has type unsigned int ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1774:25: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2007:47: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2007:47: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2007:47: right side has type int ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2029:37: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2029:37: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2029:37: right side has type int ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2030:37: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2030:37: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2030:37: right side has type int ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2032:39: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2032:39: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2032:39: right side has type int ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2035:31: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2035:31: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2035:31: right side has type int ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2036:31: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2036:31: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2036:31: right side has type int ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2038:31: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2038:31: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2038:31: right side has type int ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2056:39: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2056:39: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2056:39: right side has type int ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2058:39: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2058:39: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2058:39: right side has type int ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2060:39: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2060:39: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2060:39: right side has type int ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2103:19: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2172:24: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2172:24: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2172:24: right side has type int ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2228:22: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2228:22: expected unsigned short [usertype] vlan ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2228:22: got restricted __le16 [usertype] ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2229:17: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2229:17: expected restricted __le16 [usertype] tag ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2229:17: got int ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2230:28: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2230:28: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2230:28: right side has type int ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2235:28: warning: invalid assignment: |= ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2235:28: left side has type restricted __le32 ../drivers/net/ethernet/atheros/atl1c/atl1c_main.c:2235:28: right side has type int ../drivers/net/ethernet/chelsio/cxgb3/sge.c:2373:50: warning: incorrect type in argument 1 (different base types) ../drivers/net/ethernet/chelsio/cxgb3/sge.c:2373:50: expected unsigned int [usertype] rss ../drivers/net/ethernet/chelsio/cxgb3/sge.c:2373:50: got restricted __be32 [assigned] [usertype] rss_hi ../drivers/net/ethernet/chelsio/cxgb3/sge.c:2436:43: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/chelsio/cxgb3/sge.c:2436:43: expected restricted __wsum [usertype] csum ../drivers/net/ethernet/chelsio/cxgb3/sge.c:2436:43: got restricted __be32 [assigned] [usertype] rss_hi ../drivers/net/ethernet/chelsio/cxgb3/sge.c:2437:47: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/chelsio/cxgb3/sge.c:2437:47: expected unsigned int [usertype] priority ../drivers/net/ethernet/chelsio/cxgb3/sge.c:2437:47: got restricted __be32 [assigned] [usertype] rss_lo ../drivers/net/ethernet/chelsio/cxgb3/sge.c:2118:16: warning: cast to restricted __be32 ../drivers/net/ethernet/chelsio/cxgb3/sge.c:2118:16: warning: cast to restricted __be32 ../drivers/net/ethernet/chelsio/cxgb3/sge.c:2118:16: warning: cast to restricted __be32 ../drivers/net/ethernet/chelsio/cxgb3/sge.c:2118:16: warning: cast to restricted __be32 ../drivers/net/ethernet/chelsio/cxgb3/sge.c:2118:16: warning: cast to restricted __be32 ../drivers/net/ethernet/chelsio/cxgb3/sge.c:2118:16: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_main.c:831:25: warning: cast to restricted __be16 ../drivers/net/ethernet/huawei/hinic/hinic_main.c:831:25: warning: cast to restricted __be16 ../drivers/net/ethernet/huawei/hinic/hinic_main.c:831:25: warning: cast to restricted __be16 ../drivers/net/ethernet/huawei/hinic/hinic_main.c:831:25: warning: cast to restricted __be16 ../drivers/net/ethernet/micrel/ksz884x.c:3519:50: warning: restricted pci_power_t degrades to integer ../drivers/net/ethernet/micrel/ksz884x.c:3840:37: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:3840:37: expected unsigned int [usertype] next ../drivers/net/ethernet/micrel/ksz884x.c:3840:37: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:3842:29: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:3842:29: expected unsigned int [usertype] next ../drivers/net/ethernet/micrel/ksz884x.c:3842:29: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:3844:33: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:3844:33: expected unsigned int [usertype] data ../drivers/net/ethernet/micrel/ksz884x.c:3844:33: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:4750:31: warning: cast to restricted __le32 ../drivers/net/ethernet/micrel/ksz884x.c:5043:31: warning: cast to restricted __le32 ../drivers/net/ethernet/micrel/ksz884x.c:5079:31: warning: cast to restricted __le32 ../drivers/net/ethernet/micrel/ksz884x.c:5124:31: warning: cast to restricted __le32 ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: expected unsigned int [usertype] data ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: expected unsigned int [usertype] data ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:1619:25: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1619:25: expected unsigned int [usertype] addr ../drivers/net/ethernet/micrel/ksz884x.c:1619:25: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: expected unsigned int [usertype] data ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: expected unsigned int [usertype] data ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:1639:25: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1639:25: expected unsigned int [usertype] addr ../drivers/net/ethernet/micrel/ksz884x.c:1639:25: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:1639:25: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1639:25: expected unsigned int [usertype] addr ../drivers/net/ethernet/micrel/ksz884x.c:1639:25: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: expected unsigned int [usertype] data ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: expected unsigned int [usertype] data ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: expected unsigned int [usertype] data ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: expected unsigned int [usertype] data ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:1639:25: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1639:25: expected unsigned int [usertype] addr ../drivers/net/ethernet/micrel/ksz884x.c:1639:25: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:1595:30: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1595:30: expected unsigned int [usertype] data ../drivers/net/ethernet/micrel/ksz884x.c:1595:30: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:4966:18: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:4966:18: expected unsigned short protocol ../drivers/net/ethernet/micrel/ksz884x.c:4966:18: got restricted __be16 [usertype] protocol ../drivers/net/ethernet/micrel/ksz884x.c:4969:25: warning: restricted __be16 degrades to integer ../drivers/net/ethernet/micrel/ksz884x.c:4970:26: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:4970:26: expected unsigned short protocol ../drivers/net/ethernet/micrel/ksz884x.c:4970:26: got restricted __be16 [usertype] tot_len ../drivers/net/ethernet/micrel/ksz884x.c:4974:25: warning: restricted __be16 degrades to integer ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: expected unsigned int [usertype] data ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: expected unsigned int [usertype] data ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:4966:18: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:4966:18: expected unsigned short protocol ../drivers/net/ethernet/micrel/ksz884x.c:4966:18: got restricted __be16 [usertype] protocol ../drivers/net/ethernet/micrel/ksz884x.c:4969:25: warning: restricted __be16 degrades to integer ../drivers/net/ethernet/micrel/ksz884x.c:4970:26: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:4970:26: expected unsigned short protocol ../drivers/net/ethernet/micrel/ksz884x.c:4970:26: got restricted __be16 [usertype] tot_len ../drivers/net/ethernet/micrel/ksz884x.c:4974:25: warning: restricted __be16 degrades to integer ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: expected unsigned int [usertype] data ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: expected unsigned int [usertype] data ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:4966:18: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:4966:18: expected unsigned short protocol ../drivers/net/ethernet/micrel/ksz884x.c:4966:18: got restricted __be16 [usertype] protocol ../drivers/net/ethernet/micrel/ksz884x.c:4969:25: warning: restricted __be16 degrades to integer ../drivers/net/ethernet/micrel/ksz884x.c:4970:26: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:4970:26: expected unsigned short protocol ../drivers/net/ethernet/micrel/ksz884x.c:4970:26: got restricted __be16 [usertype] tot_len ../drivers/net/ethernet/micrel/ksz884x.c:4974:25: warning: restricted __be16 degrades to integer ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: expected unsigned int [usertype] data ../drivers/net/ethernet/micrel/ksz884x.c:1603:37: got restricted __le32 [usertype] ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: expected unsigned int [usertype] data ../drivers/net/ethernet/micrel/ksz884x.c:1605:30: got restricted __le32 [usertype] ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:333:17: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:333:17: expected unsigned int [addressable] [usertype] db_info ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:333:17: got restricted __be32 [usertype] ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:413:23: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:413:23: expected unsigned long long [usertype] ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:413:23: got restricted __be64 [usertype] ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:536:27: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:536:27: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:536:27: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:536:27: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:536:27: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:536:27: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:577:21: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:577:21: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:577:21: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:577:21: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:577:21: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:577:21: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:625:14: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:625:14: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:625:14: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:625:14: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:625:14: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:625:14: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:630:19: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:630:19: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:630:19: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:630:19: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:630:19: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:630:19: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:661:30: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:661:30: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:661:30: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:661:30: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:661:30: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:661:30: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:707:31: warning: cast to restricted __be64 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:707:31: warning: cast to restricted __be64 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:707:31: warning: cast to restricted __be64 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:707:31: warning: cast to restricted __be64 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:707:31: warning: cast to restricted __be64 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:707:31: warning: cast to restricted __be64 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:707:31: warning: cast to restricted __be64 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:707:31: warning: cast to restricted __be64 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:707:31: warning: cast to restricted __be64 ../drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:707:31: warning: cast to restricted __be64 ../drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c:324:24: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c:324:24: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c:324:24: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c:324:24: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c:324:24: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c:324:24: warning: cast to restricted __be32 ../drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c:617:25: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c:617:25: expected unsigned int [usertype] ../drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c:617:25: got restricted __be32 [usertype] ../drivers/net/ethernet/natsemi/ns83820.c:900:39: warning: cast to restricted __be16 ../drivers/net/ethernet/natsemi/ns83820.c:900:39: warning: cast to restricted __be16 ../drivers/net/ethernet/natsemi/ns83820.c:900:39: warning: cast to restricted __be16 ../drivers/net/ethernet/natsemi/ns83820.c:900:39: warning: cast to restricted __be16 ../drivers/net/ethernet/natsemi/ns83820.c:1119:42: warning: restricted __be16 degrades to integer ../drivers/net/ethernet/natsemi/ns83820.c:1982:29: warning: cast to restricted __le32 ../drivers/net/ethernet/neterion/s2io.c:6951:41: warning: cast to restricted __be32 ../drivers/net/ethernet/neterion/s2io.c:6951:41: warning: cast to restricted __be32 ../drivers/net/ethernet/neterion/s2io.c:6951:41: warning: cast to restricted __be32 ../drivers/net/ethernet/neterion/s2io.c:6951:41: warning: cast to restricted __be32 ../drivers/net/ethernet/neterion/s2io.c:6951:41: warning: cast to restricted __be32 ../drivers/net/ethernet/neterion/s2io.c:6951:41: warning: cast to restricted __be32 ../drivers/net/ethernet/neterion/s2io.c: note: in included file: ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (4c0d000000000000 becomes 0) ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (4c0d000000000000 becomes 0) ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (f00000000000000 becomes 0) ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (ffbbffbbffbbffbb becomes ffbbffbb) ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (ffbbffbbffbbffbb becomes ffbbffbb) ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (4c0d000000000000 becomes 0) ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (4c0d000000000000 becomes 0) ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (4c0d000000000000 becomes 0) ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (4c0d000000000000 becomes 0) ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (7f00000001 becomes 1) ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (102030405060000 becomes 5060000) ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (feffffffffff0000 becomes ffff0000) ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (4c0d000000000000 becomes 0) ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (4c0d000000000000 becomes 0) ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (4c0d000000000000 becomes 0) ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (4c0d000000000000 becomes 0) ../drivers/net/ethernet/neterion/vxge/vxge-config.c:890:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:890:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:890:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:890:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:890:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:890:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:890:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:890:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:890:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:890:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:891:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:891:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:891:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:891:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:891:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:891:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:891:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:891:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:891:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:891:37: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:903:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:903:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:903:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:903:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:903:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:903:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:903:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:903:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:903:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:903:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:904:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:904:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:904:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:904:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:904:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:904:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:904:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:904:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:904:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:904:35: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:918:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:918:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:918:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:918:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:918:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:918:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:918:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:918:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:918:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:918:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:919:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:919:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:919:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:919:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:919:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:919:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:919:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:919:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:919:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:919:46: warning: cast to restricted __be64 ../drivers/net/ethernet/neterion/vxge/vxge-config.c:157:1: warning: context imbalance in 'vxge_hw_vpath_fw_api' - different lock contexts for basic block ../drivers/net/ethernet/neterion/vxge/vxge-traffic.c: note: in included file: ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (1000000000000000 becomes 0) ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (100000000000000 becomes 0) ../drivers/net/ethernet/neterion/vxge/vxge-config.c: note: in included file: ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (8000000000000000 becomes 0) ../include/linux/io-64-nonatomic-lo-hi.h:21:16: warning: cast truncates bits from constant value (100000000000000 becomes 0) ../drivers/net/ethernet/packetengines/yellowfin.c:1248:37: warning: cast from restricted __le32 ../drivers/net/ethernet/packetengines/yellowfin.c:1248:37: warning: cast from restricted __le32 ../drivers/net/ethernet/packetengines/yellowfin.c:1248:37: warning: cast from restricted __le32 ../drivers/net/ethernet/packetengines/yellowfin.c:1248:37: warning: cast from restricted __le32 ../drivers/net/ethernet/packetengines/yellowfin.c:1248:37: warning: cast from restricted __le32 ../drivers/net/ethernet/packetengines/yellowfin.c:1248:37: warning: cast from restricted __le32 ../drivers/net/ethernet/packetengines/yellowfin.c:1248:37: warning: cast from restricted __le32 ../drivers/net/ethernet/packetengines/yellowfin.c:1248:37: warning: cast from restricted __le32 ../drivers/net/ethernet/packetengines/yellowfin.c:1248:37: warning: cast from restricted __le32 ../drivers/net/ethernet/packetengines/yellowfin.c:1253:49: warning: cast from restricted __le32 ../drivers/net/ethernet/packetengines/yellowfin.c:1253:49: warning: cast from restricted __le32 ../drivers/net/ethernet/packetengines/yellowfin.c:1253:49: warning: cast from restricted __le32 ../drivers/net/ethernet/packetengines/yellowfin.c:1253:49: warning: cast from restricted __le32 ../drivers/net/ethernet/packetengines/yellowfin.c:1253:49: warning: cast from restricted __le32 ../drivers/net/ethernet/packetengines/yellowfin.c:1253:49: warning: cast from restricted __le32 ../drivers/net/ethernet/packetengines/yellowfin.c:1253:49: warning: cast from restricted __le32 ../drivers/net/ethernet/packetengines/yellowfin.c:1253:49: warning: cast from restricted __le32 ../drivers/net/ethernet/packetengines/yellowfin.c:1253:49: warning: cast from restricted __le32 ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:2135:41: warning: incorrect type in argument 1 (different address spaces) ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:2135:41: expected void *reg ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:2135:41: got unsigned int [noderef] __iomem * ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:157:33: warning: incorrect type in argument 2 (different base types) ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:157:33: expected unsigned short [usertype] uid_hi ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:157:33: got restricted __be16 [usertype] ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:157:45: warning: incorrect type in argument 3 (different base types) ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:157:45: expected unsigned int [usertype] uid_lo ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:157:45: got restricted __be32 [usertype] ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:157:56: warning: incorrect type in argument 4 (different base types) ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:157:56: expected unsigned short [usertype] seqid ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:157:56: got restricted __be16 [usertype] ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:306:26: warning: incorrect type in argument 1 (different address spaces) ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:306:26: expected void const [noderef] __iomem * ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:306:26: got void *reg ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:336:33: warning: incorrect type in argument 1 (different address spaces) ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:336:33: expected void *reg ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:336:33: got unsigned int [noderef] __iomem * ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:343:33: warning: incorrect type in argument 1 (different address spaces) ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:343:33: expected void *reg ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:343:33: got unsigned int [noderef] __iomem * ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:356:33: warning: incorrect type in argument 1 (different address spaces) ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:356:33: expected void *reg ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:356:33: got unsigned int [noderef] __iomem * ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:397:33: warning: incorrect type in argument 1 (different address spaces) ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:397:33: expected void *reg ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:397:33: got unsigned int [noderef] __iomem * ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:466:41: warning: incorrect type in argument 1 (different address spaces) ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:466:41: expected void *reg ../drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:466:41: got unsigned int [noderef] __iomem * ../drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c:1035:24: warning: cast to restricted __le64 ../drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c:1037:24: warning: cast to restricted __le64 ../drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c:2133:17: warning: cast truncates bits from constant value (42110030 becomes 30) ../drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c:2133:17: warning: cast truncates bits from constant value (42110030 becomes 30) ../drivers/net/ethernet/neterion/vxge/vxge-main.c:116:27: warning: context imbalance in 'vxge_poll_inta' - different lock contexts for basic block ../drivers/net/ethernet/neterion/vxge/vxge-main.c:116:27: warning: context imbalance in 'vxge_netpoll' - different lock contexts for basic block ../drivers/net/ethernet/neterion/vxge/vxge-main.c:116:27: warning: context imbalance in 'vxge_tx_msix_handle' - different lock contexts for basic block ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:573:25: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:576:38: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:575:31: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:575:62: warning: incorrect type in initializer (different base types) ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:575:62: expected restricted __le32 [usertype] offs ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:575:62: got unsigned int ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:577:35: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:579:21: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:580:66: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:603:54: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:603:64: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:603:20: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:617:22: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:629:63: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:629:26: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:628:20: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:635:18: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:635:55: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:634:16: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:638:21: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:638:50: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:652:22: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:664:63: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:664:26: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:663:20: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:670:18: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:670:55: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:669:16: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:672:21: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:672:50: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:699:55: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:699:65: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:699:20: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:705:25: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:712:38: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:711:24: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:711:22: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:711:22: expected restricted __le32 [usertype] offs ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:711:22: got unsigned int ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:713:25: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:714:32: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:719:33: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:720:62: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:768:19: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:768:19: warning: incorrect type in initializer (different base types) ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:768:19: expected int idx ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:768:19: got restricted __le32 [usertype] ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:779:26: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:778:16: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:778:14: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:778:14: expected restricted __le32 [usertype] offs ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:778:14: got unsigned int ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:781:48: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:790:22: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:790:22: expected unsigned int [usertype] offs ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:790:22: got restricted __le32 [usertype] ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:803:22: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:803:22: expected unsigned int [usertype] offs ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:803:22: got restricted __le32 [usertype] ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:835:38: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:836:33: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:849:33: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:849:24: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:849:48: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:849:45: warning: incorrect type in return expression (different base types) ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:849:45: expected restricted __le32 ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:849:45: got unsigned int ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:862:28: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:864:25: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:864:45: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:865:58: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:864:70: warning: incorrect type in return expression (different base types) ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:864:70: expected restricted __le32 ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:864:70: got unsigned int ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:913:21: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:913:21: expected unsigned int [usertype] val ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:913:21: got restricted __le32 ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1001:72: warning: incorrect type in argument 3 (different base types) ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1001:72: expected unsigned long long [usertype] ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1001:72: got restricted __le64 [assigned] [usertype] data ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1016:60: warning: incorrect type in argument 3 (different base types) ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1016:60: expected unsigned long long [usertype] ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1016:60: got restricted __le64 [assigned] [usertype] data ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1027:60: warning: incorrect type in argument 3 (different base types) ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1027:60: expected unsigned long long [usertype] ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1027:60: got restricted __le64 [assigned] [usertype] data ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1101:23: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1101:23: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1101:23: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1125:24: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1125:24: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1125:24: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1125:22: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1125:22: expected restricted __le32 [addressable] [usertype] flash_fw_ver ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1125:22: got unsigned int ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1129:46: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c:1141:21: warning: restricted __le32 degrades to integer ../drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c:894:25: warning: incorrect type in assignment (different base types) ../drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c:894:25: expected unsigned int [usertype] ../drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c:894:25: got restricted __le32 [usertype] ../drivers/net/ethernet/qlogic/netxen/netxen_nic_ctx.c:201:31: warning: cast to restricted __le32 ../drivers/net/ethernet/sun/cassini.c:236:9: warning: context imbalance in 'cas_shutdown' - different lock contexts for basic block ../drivers/net/ethernet/sun/cassini.c:236:9: warning: context imbalance in 'cas_reset_task' - different lock contexts for basic block ../drivers/net/ethernet/via/via-rhine.c:1149:39: warning: cast removes address space '__iomem' of expression ../drivers/net/ethernet/sun/cassini.c:236:9: warning: context imbalance in 'cas_link_timer' - different lock contexts for basic block ../drivers/net/ethernet/sun/cassini.c:236:9: warning: context imbalance in 'cas_open' - different lock contexts for basic block ../drivers/net/ethernet/sun/cassini.c:236:9: warning: context imbalance in 'cas_close' - different lock contexts for basic block ../drivers/net/ethernet/sun/cassini.c:236:9: warning: context imbalance in 'cas_suspend' - different lock contexts for basic block ../drivers/net/ethernet/sun/cassini.c:236:9: warning: context imbalance in 'cas_resume' - different lock contexts for basic block ../drivers/net/ethernet/via/via-velocity.c: note: in included file: ../drivers/net/ethernet/via/via-velocity.h:237:24: warning: mixed bitwiseness ../drivers/net/ethernet/via/via-velocity.c:88:26: warning: incorrect type in initializer (different address spaces) ../drivers/net/ethernet/via/via-velocity.c:88:26: expected void *addr ../drivers/net/ethernet/via/via-velocity.c:88:26: got struct mac_regs [noderef] __iomem *mac_regs ../drivers/net/ethernet/via/via-velocity.c:91:49: warning: incorrect type in argument 2 (different base types) ../drivers/net/ethernet/via/via-velocity.c:91:49: expected restricted pci_power_t [usertype] state ../drivers/net/ethernet/via/via-velocity.c:91:49: got char state ../drivers/net/ethernet/via/via-velocity.c:93:36: warning: incorrect type in argument 2 (different address spaces) ../drivers/net/ethernet/via/via-velocity.c:93:36: expected void volatile [noderef] __iomem *addr ../drivers/net/ethernet/via/via-velocity.c:93:36: got void * ../drivers/net/ethernet/via/via-velocity.c:1745:34: warning: cast from restricted __le16 ../drivers/net/ethernet/via/via-velocity.c:1745:34: warning: cast from restricted __le16 ../drivers/net/ethernet/via/via-velocity.c:1745:34: warning: cast from restricted __le16 ../drivers/net/ethernet/via/via-velocity.c:1745:34: warning: cast from restricted __le16 ../drivers/net/ethernet/via/via-velocity.c:1745:34: warning: cast from restricted __le16 ../drivers/net/ethernet/via/via-velocity.c:1745:34: warning: cast from restricted __le16 ../drivers/net/ethernet/via/via-velocity.c:1748:17: warning: cast to restricted __le16 ../drivers/net/ethernet/via/via-velocity.c:2241:40: warning: incorrect type in argument 2 (different base types) ../drivers/net/ethernet/via/via-velocity.c:2241:40: expected char state ../drivers/net/ethernet/via/via-velocity.c:2241:40: got restricted pci_power_t [usertype] ../drivers/net/ethernet/via/via-velocity.c:2249:48: warning: incorrect type in argument 2 (different base types) ../drivers/net/ethernet/via/via-velocity.c:2249:48: expected char state ../drivers/net/ethernet/via/via-velocity.c:2249:48: got restricted pci_power_t [usertype] ../drivers/net/ethernet/via/via-velocity.c:2436:48: warning: incorrect type in argument 2 (different base types) ../drivers/net/ethernet/via/via-velocity.c:2436:48: expected char state ../drivers/net/ethernet/via/via-velocity.c:2436:48: got restricted pci_power_t [usertype] ../drivers/net/ethernet/via/via-velocity.c:2449:48: warning: incorrect type in argument 2 (different base types) ../drivers/net/ethernet/via/via-velocity.c:2449:48: expected char state ../drivers/net/ethernet/via/via-velocity.c:2449:48: got restricted pci_power_t [usertype] ../drivers/net/ethernet/via/via-velocity.c:2874:40: warning: incorrect type in argument 2 (different base types) ../drivers/net/ethernet/via/via-velocity.c:2874:40: expected char state ../drivers/net/ethernet/via/via-velocity.c:2874:40: got restricted pci_power_t [usertype] ../drivers/net/ethernet/via/via-velocity.c:3149:48: warning: incorrect type in argument 2 (different base types) ../drivers/net/ethernet/via/via-velocity.c:3149:48: expected char state ../drivers/net/ethernet/via/via-velocity.c:3149:48: got restricted pci_power_t [usertype] ../drivers/net/ethernet/via/via-velocity.c:3155:48: warning: incorrect type in argument 2 (different base types) ../drivers/net/ethernet/via/via-velocity.c:3155:48: expected char state ../drivers/net/ethernet/via/via-velocity.c:3155:48: got restricted pci_power_t [usertype] ../drivers/net/ethernet/via/via-velocity.c:3207:40: warning: incorrect type in argument 2 (different base types) ../drivers/net/ethernet/via/via-velocity.c:3207:40: expected char state ../drivers/net/ethernet/via/via-velocity.c:3207:40: got restricted pci_power_t [usertype] ../drivers/net/ethernet/via/via-velocity.c:3277:48: warning: incorrect type in argument 2 (different base types) ../drivers/net/ethernet/via/via-velocity.c:3277:48: expected char state ../drivers/net/ethernet/via/via-velocity.c:3277:48: got restricted pci_power_t [usertype] ../drivers/net/ethernet/via/via-velocity.c:3294:48: warning: incorrect type in argument 2 (different base types) ../drivers/net/ethernet/via/via-velocity.c:3294:48: expected char state ../drivers/net/ethernet/via/via-velocity.c:3294:48: got restricted pci_power_t [usertype] ../drivers/net/ethernet/ethoc.c:317:13: warning: incorrect type in assignment (different address spaces) ../drivers/net/ethernet/ethoc.c:317:13: expected void *vma ../drivers/net/ethernet/ethoc.c:317:13: got void [noderef] __iomem *membase ../drivers/net/ethernet/ethoc.c:454:67: warning: incorrect type in argument 2 (different address spaces) ../drivers/net/ethernet/ethoc.c:454:67: expected void const volatile [noderef] __iomem * ../drivers/net/ethernet/ethoc.c:454:67: got void *src ../drivers/net/ethernet/ethoc.c:912:21: warning: incorrect type in argument 1 (different address spaces) ../drivers/net/ethernet/ethoc.c:912:21: expected void volatile [noderef] __iomem * ../drivers/net/ethernet/ethoc.c:912:21: got void *[assigned] dest ../drivers/net/ethernet/ethoc.c:1112:31: warning: incorrect type in assignment (different address spaces) ../drivers/net/ethernet/ethoc.c:1112:31: expected void [noderef] __iomem *membase ../drivers/net/ethernet/ethoc.c:1112:31: got void * ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [RFC PATCH net-next v1 00/11] make drivers/net/ethernet W=1 clean 2020-09-11 20:12 ` [Intel-wired-lan] " Jakub Kicinski @ 2020-09-11 21:34 ` Jesse Brandeburg -1 siblings, 0 replies; 68+ messages in thread From: Jesse Brandeburg @ 2020-09-11 21:34 UTC (permalink / raw) To: Jakub Kicinski; +Cc: netdev, intel-wired-lan Jakub Kicinski wrote: > Yeah, maybe you need COMPILE_TEST? (full list of the warnings triggered > by the last patch at the end of the email) Ah, good idea, I checked and I have that set, however, I understand what's going on now. > > but I'd like to target the actual job you're running and use that as > > the short-term goal. > > If the code is of any use: > > https://github.com/kuba-moo/nipa > > But it expects to run against a patchwork instance. Thanks! that's interesting on it's own! > > > Also, if you have any comments about the removal of the lvalue from > > some of the register read operations, I figure that is the riskiest > > part of all this. > > Nothing looked suspicious to me. Besides if the compiler is warning that > the variable is unused I'm pretty sure it will optimize that variable > out, anyway so machine code shouldn't change with this series. Good point, I'll check that. > ../drivers/net/ethernet/atheros/atlx/atl1.c:1999:26: warning: cast to restricted __le16 > ../drivers/net/ethernet/atheros/atlx/atl1.c:2060:33: warning: cast to restricted __le16 > ../drivers/net/ethernet/atheros/atlx/atl1.c:2125:45: warning: invalid assignment: |= > ../drivers/net/ethernet/atheros/atlx/atl1.c:2125:45: left side has type restricted __le32 <snip> If I'm not mistaken *all* the warnings you had listed are from C=1 (sparse) which would be best fixed with a second set of patches. This set of patches only aimed to get rid of the W=1 (gcc warnings and kdoc warnings from scripts/kernel-doc) If you run the commands separately you'll see what I mean. make W=1 M=drivers/net/ethernet make C=2 M=drivers/net/ethernet C=2 will force the sparse check but unfortunately will also rebuild everything again. I see about 1188 unique sparse warnings in drivers/net/ethernet and only 16 unique errors from sparse. It's a lot but fixable. However my experience with these warnings is that I could break something in fixing them on drivers I can't test. I just did some spelunking on the sparse warnings, there are only 82 different ones (many are repeated). About half are context imbalances where a lock maybe isn't released. I would bet a bunch are undetected bugs. TL;DR Here is a list of driver files with sparse warnings from C=1, maybe we can encourage some others to help me fix them? drivers/net/ethernet/3com/3c509.c drivers/net/ethernet/3com/3c574_cs.c drivers/net/ethernet/3com/3c589_cs.c drivers/net/ethernet/3com/3c59x.c drivers/net/ethernet/3com/typhoon.c drivers/net/ethernet/8390/axnet_cs.c drivers/net/ethernet/8390/ne2k-pci.c drivers/net/ethernet/8390/pcnet_cs.c drivers/net/ethernet/adaptec/starfire.c drivers/net/ethernet/alacritech/slicoss.c drivers/net/ethernet/alteon/acenic.c drivers/net/ethernet/amd/pcnet32.c drivers/net/ethernet/aquantia/atlantic/hw_atl2/hw_atl2.c drivers/net/ethernet/arc/emac_main.c drivers/net/ethernet/atheros/alx/main.c drivers/net/ethernet/atheros/atl1c/atl1c_hw.c drivers/net/ethernet/atheros/atl1c/atl1c_main.c drivers/net/ethernet/atheros/atl1e/atl1e_main.c drivers/net/ethernet/atheros/atlx/atl1.c drivers/net/ethernet/broadcom/bnx2.c drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c drivers/net/ethernet/broadcom/cnic.c drivers/net/ethernet/broadcom/tg3.c drivers/net/ethernet/brocade/bna/bfa_cee.c drivers/net/ethernet/brocade/bna/bfa_ioc.c drivers/net/ethernet/brocade/bna/bfa_ioc.h drivers/net/ethernet/brocade/bna/bfa_msgq.c drivers/net/ethernet/brocade/bna/bnad.c drivers/net/ethernet/brocade/bna/bna_enet.c drivers/net/ethernet/brocade/bna/bna_tx_rx.c drivers/net/ethernet/cadence/macb_main.c drivers/net/ethernet/cavium/liquidio/cn23xx_pf_device.c drivers/net/ethernet/cavium/liquidio/cn23xx_vf_device.c drivers/net/ethernet/cavium/liquidio/lio_core.c drivers/net/ethernet/cavium/liquidio/lio_main.c drivers/net/ethernet/cavium/liquidio/lio_vf_main.c drivers/net/ethernet/cavium/liquidio/lio_vf_rep.c drivers/net/ethernet/cavium/liquidio/octeon_mailbox.c drivers/net/ethernet/cavium/liquidio/request_manager.c drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c drivers/net/ethernet/chelsio/cxgb3/sge.c drivers/net/ethernet/chelsio/cxgb3/t3_hw.c drivers/net/ethernet/chelsio/cxgb4vf/sge.c drivers/net/ethernet/chelsio/cxgb/sge.c drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_cm.c drivers/net/ethernet/chelsio/libcxgb/libcxgb_ppm.c drivers/net/ethernet/cisco/enic/enic_ethtool.c drivers/net/ethernet/cisco/enic/enic_main.c drivers/net/ethernet/cisco/enic/enic_pp.c drivers/net/ethernet/cisco/enic/vnic_vic.c drivers/net/ethernet/dlink/dl2k.c drivers/net/ethernet/dlink/sundance.c drivers/net/ethernet/emulex/benet/be_cmds.c drivers/net/ethernet/emulex/benet/be_main.c drivers/net/ethernet/ethoc.c drivers/net/ethernet/freescale/dpaa2/dpmac.c drivers/net/ethernet/freescale/enetc/enetc_ethtool.c drivers/net/ethernet/freescale/enetc/enetc_hw.h drivers/net/ethernet/freescale/enetc/enetc_qos.c drivers/net/ethernet/freescale/fsl_pq_mdio.c drivers/net/ethernet/freescale/gianfar.c drivers/net/ethernet/freescale/xgmac_mdio.c drivers/net/ethernet/huawei/hinic/hinic_common.c drivers/net/ethernet/huawei/hinic/hinic_hw_api_cmd.c drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c drivers/net/ethernet/huawei/hinic/hinic_hw_io.c drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c drivers/net/ethernet/huawei/hinic/hinic_hw_qp.c drivers/net/ethernet/huawei/hinic/hinic_hw_wq.c drivers/net/ethernet/huawei/hinic/hinic_main.c drivers/net/ethernet/huawei/hinic/hinic_port.c drivers/net/ethernet/huawei/hinic/hinic_rx.c drivers/net/ethernet/huawei/hinic/hinic_tx.c drivers/net/ethernet/intel/e1000/e1000_ethtool.c drivers/net/ethernet/intel/e100.c drivers/net/ethernet/intel/fm10k/fm10k_pci.c drivers/net/ethernet/intel/i40e/i40e_main.c drivers/net/ethernet/intel/i40e/i40e_txrx.c drivers/net/ethernet/intel/i40e/i40e_xsk.c drivers/net/ethernet/intel/igb/igb_ethtool.c drivers/net/ethernet/intel/igb/igb_main.c drivers/net/ethernet/intel/igb/igb_ptp.c drivers/net/ethernet/intel/igbvf/netdev.c drivers/net/ethernet/intel/igc/igc_dump.c drivers/net/ethernet/intel/igc/igc_ethtool.c drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c drivers/net/ethernet/jme.c drivers/net/ethernet/marvell/mv643xx_eth.c drivers/net/ethernet/marvell/mvneta.c drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c drivers/net/ethernet/marvell/octeontx2/af/rvu.c drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c drivers/net/ethernet/marvell/skge.c drivers/net/ethernet/marvell/sky2.c drivers/net/ethernet/micrel/ks8851_par.c drivers/net/ethernet/micrel/ksz884x.c drivers/net/ethernet/myricom/myri10ge/myri10ge.c drivers/net/ethernet/natsemi/ns83820.c drivers/net/ethernet/neterion/s2io.c drivers/net/ethernet/neterion/vxge/vxge-config.c drivers/net/ethernet/neterion/vxge/vxge-main.c drivers/net/ethernet/nvidia/forcedeth.c drivers/net/ethernet/nxp/lpc_eth.c drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c drivers/net/ethernet/packetengines/hamachi.c drivers/net/ethernet/qlogic/netxen/netxen_nic_ctx.c drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c drivers/net/ethernet/qlogic/qed/qed_mcp.c drivers/net/ethernet/qualcomm/emac/emac-mac.c drivers/net/ethernet/qualcomm/qca_7k_common.c drivers/net/ethernet/realtek/8139too.c drivers/net/ethernet/renesas/sh_eth.c drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c drivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c drivers/net/ethernet/sun/cassini.c drivers/net/ethernet/synopsys/dwc-xlgmac-hw.c drivers/net/ethernet/ti/tlan.c drivers/net/ethernet/via/via-rhine.c drivers/net/ethernet/via/via-velocity.c drivers/net/ethernet/via/via-velocity.h drivers/net/ethernet/xilinx/ll_temac_main.c drivers/net/ethernet/xilinx/xilinx_axienet_main.c ^ permalink raw reply [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 00/11] make drivers/net/ethernet W=1 clean @ 2020-09-11 21:34 ` Jesse Brandeburg 0 siblings, 0 replies; 68+ messages in thread From: Jesse Brandeburg @ 2020-09-11 21:34 UTC (permalink / raw) To: intel-wired-lan Jakub Kicinski wrote: > Yeah, maybe you need COMPILE_TEST? (full list of the warnings triggered > by the last patch at the end of the email) Ah, good idea, I checked and I have that set, however, I understand what's going on now. > > but I'd like to target the actual job you're running and use that as > > the short-term goal. > > If the code is of any use: > > https://github.com/kuba-moo/nipa > > But it expects to run against a patchwork instance. Thanks! that's interesting on it's own! > > > Also, if you have any comments about the removal of the lvalue from > > some of the register read operations, I figure that is the riskiest > > part of all this. > > Nothing looked suspicious to me. Besides if the compiler is warning that > the variable is unused I'm pretty sure it will optimize that variable > out, anyway so machine code shouldn't change with this series. Good point, I'll check that. > ../drivers/net/ethernet/atheros/atlx/atl1.c:1999:26: warning: cast to restricted __le16 > ../drivers/net/ethernet/atheros/atlx/atl1.c:2060:33: warning: cast to restricted __le16 > ../drivers/net/ethernet/atheros/atlx/atl1.c:2125:45: warning: invalid assignment: |= > ../drivers/net/ethernet/atheros/atlx/atl1.c:2125:45: left side has type restricted __le32 <snip> If I'm not mistaken *all* the warnings you had listed are from C=1 (sparse) which would be best fixed with a second set of patches. This set of patches only aimed to get rid of the W=1 (gcc warnings and kdoc warnings from scripts/kernel-doc) If you run the commands separately you'll see what I mean. make W=1 M=drivers/net/ethernet make C=2 M=drivers/net/ethernet C=2 will force the sparse check but unfortunately will also rebuild everything again. I see about 1188 unique sparse warnings in drivers/net/ethernet and only 16 unique errors from sparse. It's a lot but fixable. However my experience with these warnings is that I could break something in fixing them on drivers I can't test. I just did some spelunking on the sparse warnings, there are only 82 different ones (many are repeated). About half are context imbalances where a lock maybe isn't released. I would bet a bunch are undetected bugs. TL;DR Here is a list of driver files with sparse warnings from C=1, maybe we can encourage some others to help me fix them? drivers/net/ethernet/3com/3c509.c drivers/net/ethernet/3com/3c574_cs.c drivers/net/ethernet/3com/3c589_cs.c drivers/net/ethernet/3com/3c59x.c drivers/net/ethernet/3com/typhoon.c drivers/net/ethernet/8390/axnet_cs.c drivers/net/ethernet/8390/ne2k-pci.c drivers/net/ethernet/8390/pcnet_cs.c drivers/net/ethernet/adaptec/starfire.c drivers/net/ethernet/alacritech/slicoss.c drivers/net/ethernet/alteon/acenic.c drivers/net/ethernet/amd/pcnet32.c drivers/net/ethernet/aquantia/atlantic/hw_atl2/hw_atl2.c drivers/net/ethernet/arc/emac_main.c drivers/net/ethernet/atheros/alx/main.c drivers/net/ethernet/atheros/atl1c/atl1c_hw.c drivers/net/ethernet/atheros/atl1c/atl1c_main.c drivers/net/ethernet/atheros/atl1e/atl1e_main.c drivers/net/ethernet/atheros/atlx/atl1.c drivers/net/ethernet/broadcom/bnx2.c drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c drivers/net/ethernet/broadcom/cnic.c drivers/net/ethernet/broadcom/tg3.c drivers/net/ethernet/brocade/bna/bfa_cee.c drivers/net/ethernet/brocade/bna/bfa_ioc.c drivers/net/ethernet/brocade/bna/bfa_ioc.h drivers/net/ethernet/brocade/bna/bfa_msgq.c drivers/net/ethernet/brocade/bna/bnad.c drivers/net/ethernet/brocade/bna/bna_enet.c drivers/net/ethernet/brocade/bna/bna_tx_rx.c drivers/net/ethernet/cadence/macb_main.c drivers/net/ethernet/cavium/liquidio/cn23xx_pf_device.c drivers/net/ethernet/cavium/liquidio/cn23xx_vf_device.c drivers/net/ethernet/cavium/liquidio/lio_core.c drivers/net/ethernet/cavium/liquidio/lio_main.c drivers/net/ethernet/cavium/liquidio/lio_vf_main.c drivers/net/ethernet/cavium/liquidio/lio_vf_rep.c drivers/net/ethernet/cavium/liquidio/octeon_mailbox.c drivers/net/ethernet/cavium/liquidio/request_manager.c drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c drivers/net/ethernet/chelsio/cxgb3/sge.c drivers/net/ethernet/chelsio/cxgb3/t3_hw.c drivers/net/ethernet/chelsio/cxgb4vf/sge.c drivers/net/ethernet/chelsio/cxgb/sge.c drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_cm.c drivers/net/ethernet/chelsio/libcxgb/libcxgb_ppm.c drivers/net/ethernet/cisco/enic/enic_ethtool.c drivers/net/ethernet/cisco/enic/enic_main.c drivers/net/ethernet/cisco/enic/enic_pp.c drivers/net/ethernet/cisco/enic/vnic_vic.c drivers/net/ethernet/dlink/dl2k.c drivers/net/ethernet/dlink/sundance.c drivers/net/ethernet/emulex/benet/be_cmds.c drivers/net/ethernet/emulex/benet/be_main.c drivers/net/ethernet/ethoc.c drivers/net/ethernet/freescale/dpaa2/dpmac.c drivers/net/ethernet/freescale/enetc/enetc_ethtool.c drivers/net/ethernet/freescale/enetc/enetc_hw.h drivers/net/ethernet/freescale/enetc/enetc_qos.c drivers/net/ethernet/freescale/fsl_pq_mdio.c drivers/net/ethernet/freescale/gianfar.c drivers/net/ethernet/freescale/xgmac_mdio.c drivers/net/ethernet/huawei/hinic/hinic_common.c drivers/net/ethernet/huawei/hinic/hinic_hw_api_cmd.c drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c drivers/net/ethernet/huawei/hinic/hinic_hw_io.c drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c drivers/net/ethernet/huawei/hinic/hinic_hw_qp.c drivers/net/ethernet/huawei/hinic/hinic_hw_wq.c drivers/net/ethernet/huawei/hinic/hinic_main.c drivers/net/ethernet/huawei/hinic/hinic_port.c drivers/net/ethernet/huawei/hinic/hinic_rx.c drivers/net/ethernet/huawei/hinic/hinic_tx.c drivers/net/ethernet/intel/e1000/e1000_ethtool.c drivers/net/ethernet/intel/e100.c drivers/net/ethernet/intel/fm10k/fm10k_pci.c drivers/net/ethernet/intel/i40e/i40e_main.c drivers/net/ethernet/intel/i40e/i40e_txrx.c drivers/net/ethernet/intel/i40e/i40e_xsk.c drivers/net/ethernet/intel/igb/igb_ethtool.c drivers/net/ethernet/intel/igb/igb_main.c drivers/net/ethernet/intel/igb/igb_ptp.c drivers/net/ethernet/intel/igbvf/netdev.c drivers/net/ethernet/intel/igc/igc_dump.c drivers/net/ethernet/intel/igc/igc_ethtool.c drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c drivers/net/ethernet/jme.c drivers/net/ethernet/marvell/mv643xx_eth.c drivers/net/ethernet/marvell/mvneta.c drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c drivers/net/ethernet/marvell/octeontx2/af/rvu.c drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c drivers/net/ethernet/marvell/skge.c drivers/net/ethernet/marvell/sky2.c drivers/net/ethernet/micrel/ks8851_par.c drivers/net/ethernet/micrel/ksz884x.c drivers/net/ethernet/myricom/myri10ge/myri10ge.c drivers/net/ethernet/natsemi/ns83820.c drivers/net/ethernet/neterion/s2io.c drivers/net/ethernet/neterion/vxge/vxge-config.c drivers/net/ethernet/neterion/vxge/vxge-main.c drivers/net/ethernet/nvidia/forcedeth.c drivers/net/ethernet/nxp/lpc_eth.c drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c drivers/net/ethernet/packetengines/hamachi.c drivers/net/ethernet/qlogic/netxen/netxen_nic_ctx.c drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c drivers/net/ethernet/qlogic/qed/qed_mcp.c drivers/net/ethernet/qualcomm/emac/emac-mac.c drivers/net/ethernet/qualcomm/qca_7k_common.c drivers/net/ethernet/realtek/8139too.c drivers/net/ethernet/renesas/sh_eth.c drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c drivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c drivers/net/ethernet/sun/cassini.c drivers/net/ethernet/synopsys/dwc-xlgmac-hw.c drivers/net/ethernet/ti/tlan.c drivers/net/ethernet/via/via-rhine.c drivers/net/ethernet/via/via-velocity.c drivers/net/ethernet/via/via-velocity.h drivers/net/ethernet/xilinx/ll_temac_main.c drivers/net/ethernet/xilinx/xilinx_axienet_main.c ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [RFC PATCH net-next v1 00/11] make drivers/net/ethernet W=1 clean 2020-09-11 21:34 ` [Intel-wired-lan] " Jesse Brandeburg @ 2020-09-11 22:16 ` Jakub Kicinski -1 siblings, 0 replies; 68+ messages in thread From: Jakub Kicinski @ 2020-09-11 22:16 UTC (permalink / raw) To: Jesse Brandeburg; +Cc: netdev, intel-wired-lan On Fri, 11 Sep 2020 14:34:05 -0700 Jesse Brandeburg wrote: > If I'm not mistaken *all* the warnings you had listed are from C=1 > (sparse) which would be best fixed with a second set of patches. This > set of patches only aimed to get rid of the W=1 (gcc warnings and kdoc > warnings from scripts/kernel-doc) Oh damn, you're right. I got fooled by my own logs :/ ^ permalink raw reply [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 00/11] make drivers/net/ethernet W=1 clean @ 2020-09-11 22:16 ` Jakub Kicinski 0 siblings, 0 replies; 68+ messages in thread From: Jakub Kicinski @ 2020-09-11 22:16 UTC (permalink / raw) To: intel-wired-lan On Fri, 11 Sep 2020 14:34:05 -0700 Jesse Brandeburg wrote: > If I'm not mistaken *all* the warnings you had listed are from C=1 > (sparse) which would be best fixed with a second set of patches. This > set of patches only aimed to get rid of the W=1 (gcc warnings and kdoc > warnings from scripts/kernel-doc) Oh damn, you're right. I got fooled by my own logs :/ ^ permalink raw reply [flat|nested] 68+ messages in thread
* Re: [RFC PATCH net-next v1 00/11] make drivers/net/ethernet W=1 clean 2020-09-11 21:34 ` [Intel-wired-lan] " Jesse Brandeburg @ 2020-09-11 22:43 ` Vladimir Oltean -1 siblings, 0 replies; 68+ messages in thread From: Vladimir Oltean @ 2020-09-11 22:43 UTC (permalink / raw) To: Jesse Brandeburg; +Cc: Jakub Kicinski, netdev, intel-wired-lan On Fri, Sep 11, 2020 at 02:34:05PM -0700, Jesse Brandeburg wrote: > Here is a list of driver files with sparse warnings from C=1, maybe we > can encourage some others to help me fix them? I can take care of drivers/net/ethernet/freescale, thanks for the effort so far! I'll try to send a patch tomorrow. -Vladimir ^ permalink raw reply [flat|nested] 68+ messages in thread
* [Intel-wired-lan] [RFC PATCH net-next v1 00/11] make drivers/net/ethernet W=1 clean @ 2020-09-11 22:43 ` Vladimir Oltean 0 siblings, 0 replies; 68+ messages in thread From: Vladimir Oltean @ 2020-09-11 22:43 UTC (permalink / raw) To: intel-wired-lan On Fri, Sep 11, 2020 at 02:34:05PM -0700, Jesse Brandeburg wrote: > Here is a list of driver files with sparse warnings from C=1, maybe we > can encourage some others to help me fix them? I can take care of drivers/net/ethernet/freescale, thanks for the effort so far! I'll try to send a patch tomorrow. -Vladimir ^ permalink raw reply [flat|nested] 68+ messages in thread
end of thread, other threads:[~2020-09-23 3:57 UTC | newest] Thread overview: 68+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-09-11 1:23 [RFC PATCH net-next v1 00/11] make drivers/net/ethernet W=1 clean Jesse Brandeburg 2020-09-11 1:23 ` [Intel-wired-lan] " Jesse Brandeburg 2020-09-11 1:23 ` [RFC PATCH net-next v1 01/11] i40e: prepare flash string in a simpler way Jesse Brandeburg 2020-09-11 1:23 ` [Intel-wired-lan] " Jesse Brandeburg 2020-09-11 1:23 ` [RFC PATCH net-next v1 02/11] i40e: clean up W=1 warnings in i40e Jesse Brandeburg 2020-09-11 1:23 ` [Intel-wired-lan] " Jesse Brandeburg 2020-09-23 2:02 ` Brown, Aaron F 2020-09-23 2:02 ` Brown, Aaron F 2020-09-11 1:23 ` [RFC PATCH net-next v1 03/11] iavf: clean up W=1 warnings in iavf Jesse Brandeburg 2020-09-11 1:23 ` [Intel-wired-lan] " Jesse Brandeburg 2020-09-23 3:12 ` Brown, Aaron F 2020-09-11 1:23 ` [RFC PATCH net-next v1 04/11] ixgbe: clean up W=1 warnings in ixgbe Jesse Brandeburg 2020-09-11 1:23 ` [Intel-wired-lan] " Jesse Brandeburg 2020-09-23 3:57 ` Brown, Aaron F 2020-09-11 1:23 ` [RFC PATCH net-next v1 05/11] intel-ethernet: make W=1 build cleanly Jesse Brandeburg 2020-09-11 1:23 ` [Intel-wired-lan] " Jesse Brandeburg 2020-09-11 17:43 ` Vinicius Costa Gomes 2020-09-11 17:43 ` Vinicius Costa Gomes 2020-09-11 23:06 ` Jacob Keller 2020-09-11 23:28 ` Jesse Brandeburg 2020-09-11 23:28 ` Jesse Brandeburg 2020-09-11 1:23 ` [RFC PATCH net-next v1 06/11] drivers/net/ethernet: clean up unused assignments Jesse Brandeburg 2020-09-11 1:23 ` [Intel-wired-lan] " Jesse Brandeburg 2020-09-11 17:16 ` Edward Cree 2020-09-11 17:16 ` [Intel-wired-lan] " Edward Cree 2020-09-11 23:03 ` Jacob Keller 2020-09-11 23:18 ` Jesse Brandeburg 2020-09-11 1:23 ` [RFC PATCH net-next v1 07/11] drivers/net/ethernet: rid ethernet of no-prototype warnings Jesse Brandeburg 2020-09-11 1:23 ` [Intel-wired-lan] " Jesse Brandeburg 2020-09-11 1:23 ` [RFC PATCH net-next v1 08/11] drivers/net/ethernet: handle one warning explicitly Jesse Brandeburg 2020-09-11 1:23 ` [Intel-wired-lan] " Jesse Brandeburg 2020-09-11 22:56 ` Jacob Keller 2020-09-11 22:56 ` [Intel-wired-lan] " Jacob Keller 2020-09-11 1:23 ` [RFC PATCH net-next v1 09/11] drivers/net/ethernet: add some basic kdoc tags Jesse Brandeburg 2020-09-11 1:23 ` [Intel-wired-lan] " Jesse Brandeburg 2020-09-11 1:23 ` [RFC PATCH net-next v1 10/11] drivers/net/ethernet: remove incorrectly formatted doc Jesse Brandeburg 2020-09-11 1:23 ` [Intel-wired-lan] " Jesse Brandeburg 2020-09-11 22:59 ` Jacob Keller 2020-09-11 23:25 ` Jesse Brandeburg 2020-09-14 23:06 ` Jacob Keller 2020-09-11 1:23 ` [RFC PATCH net-next v1 11/11] drivers/net/ethernet: clean up mis-targeted comments Jesse Brandeburg 2020-09-11 1:23 ` [Intel-wired-lan] " Jesse Brandeburg 2020-09-11 17:26 ` Edward Cree 2020-09-11 17:26 ` [Intel-wired-lan] " Edward Cree 2020-09-11 21:42 ` Jesse Brandeburg 2020-09-11 21:42 ` [Intel-wired-lan] " Jesse Brandeburg 2020-09-11 21:55 ` Edward Cree 2020-09-11 21:55 ` [Intel-wired-lan] " Edward Cree 2020-09-11 22:26 ` Jakub Kicinski 2020-09-11 22:26 ` [Intel-wired-lan] " Jakub Kicinski 2020-09-11 23:11 ` Edward Cree 2020-09-11 23:11 ` [Intel-wired-lan] " Edward Cree 2020-09-12 0:49 ` Jesse Brandeburg 2020-09-12 0:49 ` [Intel-wired-lan] " Jesse Brandeburg 2020-09-14 3:04 ` Andrew Lunn 2020-09-14 3:04 ` [Intel-wired-lan] " Andrew Lunn 2020-09-11 14:55 ` [RFC PATCH net-next v1 00/11] make drivers/net/ethernet W=1 clean Jakub Kicinski 2020-09-11 14:55 ` [Intel-wired-lan] " Jakub Kicinski 2020-09-11 19:00 ` Jesse Brandeburg 2020-09-11 19:00 ` [Intel-wired-lan] " Jesse Brandeburg 2020-09-11 20:12 ` Jakub Kicinski 2020-09-11 20:12 ` [Intel-wired-lan] " Jakub Kicinski 2020-09-11 21:34 ` Jesse Brandeburg 2020-09-11 21:34 ` [Intel-wired-lan] " Jesse Brandeburg 2020-09-11 22:16 ` Jakub Kicinski 2020-09-11 22:16 ` [Intel-wired-lan] " Jakub Kicinski 2020-09-11 22:43 ` Vladimir Oltean 2020-09-11 22:43 ` [Intel-wired-lan] " Vladimir Oltean
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.