All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: anant.thazhemadam@gmail.com
Cc: greg@kroah.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, kuba@kernel.org,
	syzbot+09a5d591c1f98cf5efcb@syzkaller.appspotmail.com,
	linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH] net: fix uninit value error in __sys_sendmmsg
Date: Sun, 13 Sep 2020 14:25:22 -0700 (PDT)	[thread overview]
Message-ID: <20200913.142522.1753407855743748880.davem@davemloft.net> (raw)
In-Reply-To: <89526337-9657-8f4d-3022-9f2ad830fbe9@gmail.com>

From: Anant Thazhemadam <anant.thazhemadam@gmail.com>
Date: Sun, 13 Sep 2020 11:50:52 +0530

> My apologies. I think I ended up overlooking the build warning.

You "think" you overlooked the build warning?  You don't actually
know?

If you aren't willing to even make sure the build is clean after your
changes, why should we be willing to review and integrate your changes?

This kind of carelessness costs other developers their valuable time,
please treat it with more respect than you have.

Thank you.


WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: anant.thazhemadam@gmail.com
Cc: greg@kroah.com, linux-kernel@vger.kernel.org,
	syzbot+09a5d591c1f98cf5efcb@syzkaller.appspotmail.com,
	netdev@vger.kernel.org, kuba@kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH] net: fix uninit value error in __sys_sendmmsg
Date: Sun, 13 Sep 2020 14:25:22 -0700 (PDT)	[thread overview]
Message-ID: <20200913.142522.1753407855743748880.davem@davemloft.net> (raw)
In-Reply-To: <89526337-9657-8f4d-3022-9f2ad830fbe9@gmail.com>

From: Anant Thazhemadam <anant.thazhemadam@gmail.com>
Date: Sun, 13 Sep 2020 11:50:52 +0530

> My apologies. I think I ended up overlooking the build warning.

You "think" you overlooked the build warning?  You don't actually
know?

If you aren't willing to even make sure the build is clean after your
changes, why should we be willing to review and integrate your changes?

This kind of carelessness costs other developers their valuable time,
please treat it with more respect than you have.

Thank you.

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

  reply	other threads:[~2020-09-13 21:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-13  5:56 [PATCH] net: fix uninit value error in __sys_sendmmsg Anant Thazhemadam
2020-09-13  5:56 ` [Linux-kernel-mentees] " Anant Thazhemadam
2020-09-13  6:13 ` Greg KH
2020-09-13  6:13   ` Greg KH
2020-09-13  6:20   ` Anant Thazhemadam
2020-09-13  6:20     ` Anant Thazhemadam
2020-09-13 21:25     ` David Miller [this message]
2020-09-13 21:25       ` David Miller
2020-09-14  5:09       ` Anant Thazhemadam
2020-09-14  7:58   ` David Laight
2020-09-14  7:58     ` David Laight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200913.142522.1753407855743748880.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=anant.thazhemadam@gmail.com \
    --cc=greg@kroah.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=syzbot+09a5d591c1f98cf5efcb@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.