* [PATCH v3 0/2] Fixes for am65x and j721e dss dt-schema
@ 2020-09-16 13:10 ` Tomi Valkeinen
0 siblings, 0 replies; 10+ messages in thread
From: Tomi Valkeinen @ 2020-09-16 13:10 UTC (permalink / raw)
To: dri-devel
Cc: devicetree, Rob Herring, Jyri Sarha, Tero Kristo, Nishanth Menon,
Laurent Pinchart, Tomi Valkeinen
Hi,
This is version three of the series:
https://www.spinics.net/lists/arm-kernel/msg836244.html
There are no changes to the yaml in this version, but I am resending as
I missed cc'ing dri-devel previously.
I have also added Rob's reviewed-bys, and sending only the dt-schema
changes.
Tomi
Tomi Valkeinen (2):
dt-bindings: display: ti,am65x-dss: add missing properties to
dt-schema
dt-bindings: display: ti,j721e-dss: add missing properties to
dt-schema
.../devicetree/bindings/display/ti/ti,am65x-dss.yaml | 11 +++++++++++
.../devicetree/bindings/display/ti/ti,j721e-dss.yaml | 11 +++++++++++
2 files changed, 22 insertions(+)
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v3 0/2] Fixes for am65x and j721e dss dt-schema
@ 2020-09-16 13:10 ` Tomi Valkeinen
0 siblings, 0 replies; 10+ messages in thread
From: Tomi Valkeinen @ 2020-09-16 13:10 UTC (permalink / raw)
To: dri-devel
Cc: Nishanth Menon, devicetree, Tomi Valkeinen, Jyri Sarha,
Tero Kristo, Rob Herring, Laurent Pinchart
Hi,
This is version three of the series:
https://www.spinics.net/lists/arm-kernel/msg836244.html
There are no changes to the yaml in this version, but I am resending as
I missed cc'ing dri-devel previously.
I have also added Rob's reviewed-bys, and sending only the dt-schema
changes.
Tomi
Tomi Valkeinen (2):
dt-bindings: display: ti,am65x-dss: add missing properties to
dt-schema
dt-bindings: display: ti,j721e-dss: add missing properties to
dt-schema
.../devicetree/bindings/display/ti/ti,am65x-dss.yaml | 11 +++++++++++
.../devicetree/bindings/display/ti/ti,j721e-dss.yaml | 11 +++++++++++
2 files changed, 22 insertions(+)
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v3 1/2] dt-bindings: display: ti,am65x-dss: add missing properties to dt-schema
2020-09-16 13:10 ` Tomi Valkeinen
@ 2020-09-16 13:10 ` Tomi Valkeinen
-1 siblings, 0 replies; 10+ messages in thread
From: Tomi Valkeinen @ 2020-09-16 13:10 UTC (permalink / raw)
To: dri-devel
Cc: devicetree, Rob Herring, Jyri Sarha, Tero Kristo, Nishanth Menon,
Laurent Pinchart, Tomi Valkeinen, Rob Herring
Add assigned-clocks, assigned-clock-parents and dma-coherent optional
properties.
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
.../devicetree/bindings/display/ti/ti,am65x-dss.yaml | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
index 4f9185462ed3..4dc30738ee57 100644
--- a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
+++ b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
@@ -55,6 +55,14 @@ properties:
- const: vp1
- const: vp2
+ assigned-clocks:
+ minItems: 1
+ maxItems: 3
+
+ assigned-clock-parents:
+ minItems: 1
+ maxItems: 3
+
interrupts:
maxItems: 1
@@ -62,6 +70,9 @@ properties:
maxItems: 1
description: phandle to the associated power domain
+ dma-coherent:
+ type: boolean
+
ports:
type: object
description:
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v3 1/2] dt-bindings: display: ti, am65x-dss: add missing properties to dt-schema
@ 2020-09-16 13:10 ` Tomi Valkeinen
0 siblings, 0 replies; 10+ messages in thread
From: Tomi Valkeinen @ 2020-09-16 13:10 UTC (permalink / raw)
To: dri-devel
Cc: Nishanth Menon, devicetree, Tomi Valkeinen, Jyri Sarha,
Tero Kristo, Rob Herring, Laurent Pinchart
Add assigned-clocks, assigned-clock-parents and dma-coherent optional
properties.
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
.../devicetree/bindings/display/ti/ti,am65x-dss.yaml | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
index 4f9185462ed3..4dc30738ee57 100644
--- a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
+++ b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
@@ -55,6 +55,14 @@ properties:
- const: vp1
- const: vp2
+ assigned-clocks:
+ minItems: 1
+ maxItems: 3
+
+ assigned-clock-parents:
+ minItems: 1
+ maxItems: 3
+
interrupts:
maxItems: 1
@@ -62,6 +70,9 @@ properties:
maxItems: 1
description: phandle to the associated power domain
+ dma-coherent:
+ type: boolean
+
ports:
type: object
description:
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v3 2/2] dt-bindings: display: ti,j721e-dss: add missing properties to dt-schema
2020-09-16 13:10 ` Tomi Valkeinen
@ 2020-09-16 13:10 ` Tomi Valkeinen
-1 siblings, 0 replies; 10+ messages in thread
From: Tomi Valkeinen @ 2020-09-16 13:10 UTC (permalink / raw)
To: dri-devel
Cc: devicetree, Rob Herring, Jyri Sarha, Tero Kristo, Nishanth Menon,
Laurent Pinchart, Tomi Valkeinen, Rob Herring
Add assigned-clocks, assigned-clock-parents and dma-coherent optional
properties.
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
.../devicetree/bindings/display/ti/ti,j721e-dss.yaml | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/ti/ti,j721e-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,j721e-dss.yaml
index 173730d56334..c9a947d55fa4 100644
--- a/Documentation/devicetree/bindings/display/ti/ti,j721e-dss.yaml
+++ b/Documentation/devicetree/bindings/display/ti/ti,j721e-dss.yaml
@@ -77,6 +77,14 @@ properties:
- const: vp3
- const: vp4
+ assigned-clocks:
+ minItems: 1
+ maxItems: 5
+
+ assigned-clock-parents:
+ minItems: 1
+ maxItems: 5
+
interrupts:
items:
- description: common_m DSS Master common
@@ -95,6 +103,9 @@ properties:
maxItems: 1
description: phandle to the associated power domain
+ dma-coherent:
+ type: boolean
+
ports:
type: object
description:
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v3 2/2] dt-bindings: display: ti, j721e-dss: add missing properties to dt-schema
@ 2020-09-16 13:10 ` Tomi Valkeinen
0 siblings, 0 replies; 10+ messages in thread
From: Tomi Valkeinen @ 2020-09-16 13:10 UTC (permalink / raw)
To: dri-devel
Cc: Nishanth Menon, devicetree, Tomi Valkeinen, Jyri Sarha,
Tero Kristo, Rob Herring, Laurent Pinchart
Add assigned-clocks, assigned-clock-parents and dma-coherent optional
properties.
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
.../devicetree/bindings/display/ti/ti,j721e-dss.yaml | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/ti/ti,j721e-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,j721e-dss.yaml
index 173730d56334..c9a947d55fa4 100644
--- a/Documentation/devicetree/bindings/display/ti/ti,j721e-dss.yaml
+++ b/Documentation/devicetree/bindings/display/ti/ti,j721e-dss.yaml
@@ -77,6 +77,14 @@ properties:
- const: vp3
- const: vp4
+ assigned-clocks:
+ minItems: 1
+ maxItems: 5
+
+ assigned-clock-parents:
+ minItems: 1
+ maxItems: 5
+
interrupts:
items:
- description: common_m DSS Master common
@@ -95,6 +103,9 @@ properties:
maxItems: 1
description: phandle to the associated power domain
+ dma-coherent:
+ type: boolean
+
ports:
type: object
description:
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: display: ti,am65x-dss: add missing properties to dt-schema
2020-09-16 13:10 ` [PATCH v3 1/2] dt-bindings: display: ti, am65x-dss: " Tomi Valkeinen
@ 2020-09-18 1:18 ` Laurent Pinchart
-1 siblings, 0 replies; 10+ messages in thread
From: Laurent Pinchart @ 2020-09-18 1:18 UTC (permalink / raw)
To: Tomi Valkeinen
Cc: dri-devel, devicetree, Rob Herring, Jyri Sarha, Tero Kristo,
Nishanth Menon, Rob Herring
Hi Tomi,
Thank you for the patch.
On Wed, Sep 16, 2020 at 04:10:08PM +0300, Tomi Valkeinen wrote:
> Add assigned-clocks, assigned-clock-parents and dma-coherent optional
> properties.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/display/ti/ti,am65x-dss.yaml | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
> index 4f9185462ed3..4dc30738ee57 100644
> --- a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
> +++ b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
> @@ -55,6 +55,14 @@ properties:
> - const: vp1
> - const: vp2
>
> + assigned-clocks:
> + minItems: 1
> + maxItems: 3
> +
> + assigned-clock-parents:
> + minItems: 1
> + maxItems: 3
> +
Those properties can occur in any node that has clocks. Do we need to
specify them explicitly in every schema ?
> interrupts:
> maxItems: 1
>
> @@ -62,6 +70,9 @@ properties:
> maxItems: 1
> description: phandle to the associated power domain
>
> + dma-coherent:
> + type: boolean
> +
> ports:
> type: object
> description:
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: display: ti,am65x-dss: add missing properties to dt-schema
@ 2020-09-18 1:18 ` Laurent Pinchart
0 siblings, 0 replies; 10+ messages in thread
From: Laurent Pinchart @ 2020-09-18 1:18 UTC (permalink / raw)
To: Tomi Valkeinen
Cc: Nishanth Menon, devicetree, Jyri Sarha, Tero Kristo, Rob Herring,
dri-devel
Hi Tomi,
Thank you for the patch.
On Wed, Sep 16, 2020 at 04:10:08PM +0300, Tomi Valkeinen wrote:
> Add assigned-clocks, assigned-clock-parents and dma-coherent optional
> properties.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/display/ti/ti,am65x-dss.yaml | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
> index 4f9185462ed3..4dc30738ee57 100644
> --- a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
> +++ b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
> @@ -55,6 +55,14 @@ properties:
> - const: vp1
> - const: vp2
>
> + assigned-clocks:
> + minItems: 1
> + maxItems: 3
> +
> + assigned-clock-parents:
> + minItems: 1
> + maxItems: 3
> +
Those properties can occur in any node that has clocks. Do we need to
specify them explicitly in every schema ?
> interrupts:
> maxItems: 1
>
> @@ -62,6 +70,9 @@ properties:
> maxItems: 1
> description: phandle to the associated power domain
>
> + dma-coherent:
> + type: boolean
> +
> ports:
> type: object
> description:
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: display: ti,am65x-dss: add missing properties to dt-schema
2020-09-18 1:18 ` Laurent Pinchart
@ 2020-09-18 8:12 ` Tomi Valkeinen
-1 siblings, 0 replies; 10+ messages in thread
From: Tomi Valkeinen @ 2020-09-18 8:12 UTC (permalink / raw)
To: Laurent Pinchart
Cc: dri-devel, devicetree, Rob Herring, Jyri Sarha, Tero Kristo,
Nishanth Menon, Rob Herring
On 18/09/2020 04:18, Laurent Pinchart wrote:
> Hi Tomi,
>
> Thank you for the patch.
>
> On Wed, Sep 16, 2020 at 04:10:08PM +0300, Tomi Valkeinen wrote:
>> Add assigned-clocks, assigned-clock-parents and dma-coherent optional
>> properties.
>>
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> ---
>> .../devicetree/bindings/display/ti/ti,am65x-dss.yaml | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
>> index 4f9185462ed3..4dc30738ee57 100644
>> --- a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
>> +++ b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
>> @@ -55,6 +55,14 @@ properties:
>> - const: vp1
>> - const: vp2
>>
>> + assigned-clocks:
>> + minItems: 1
>> + maxItems: 3
>> +
>> + assigned-clock-parents:
>> + minItems: 1
>> + maxItems: 3
>> +
>
> Those properties can occur in any node that has clocks. Do we need to
> specify them explicitly in every schema ?
I don't really know the dt-schema stuff well enough yet to have a good answer, but if this
information would come from somewhere else, it would somehow need to know:
- are there clocks in this schema (i.e. is assigned-clocks allowed or not)
- how many clocks there are (for min and max items)
This would also apply to assigned-clock-rates.
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: display: ti,am65x-dss: add missing properties to dt-schema
@ 2020-09-18 8:12 ` Tomi Valkeinen
0 siblings, 0 replies; 10+ messages in thread
From: Tomi Valkeinen @ 2020-09-18 8:12 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Nishanth Menon, devicetree, Jyri Sarha, Tero Kristo, Rob Herring,
dri-devel
On 18/09/2020 04:18, Laurent Pinchart wrote:
> Hi Tomi,
>
> Thank you for the patch.
>
> On Wed, Sep 16, 2020 at 04:10:08PM +0300, Tomi Valkeinen wrote:
>> Add assigned-clocks, assigned-clock-parents and dma-coherent optional
>> properties.
>>
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> ---
>> .../devicetree/bindings/display/ti/ti,am65x-dss.yaml | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
>> index 4f9185462ed3..4dc30738ee57 100644
>> --- a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
>> +++ b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
>> @@ -55,6 +55,14 @@ properties:
>> - const: vp1
>> - const: vp2
>>
>> + assigned-clocks:
>> + minItems: 1
>> + maxItems: 3
>> +
>> + assigned-clock-parents:
>> + minItems: 1
>> + maxItems: 3
>> +
>
> Those properties can occur in any node that has clocks. Do we need to
> specify them explicitly in every schema ?
I don't really know the dt-schema stuff well enough yet to have a good answer, but if this
information would come from somewhere else, it would somehow need to know:
- are there clocks in this schema (i.e. is assigned-clocks allowed or not)
- how many clocks there are (for min and max items)
This would also apply to assigned-clock-rates.
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-09-18 8:12 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-16 13:10 [PATCH v3 0/2] Fixes for am65x and j721e dss dt-schema Tomi Valkeinen
2020-09-16 13:10 ` Tomi Valkeinen
2020-09-16 13:10 ` [PATCH v3 1/2] dt-bindings: display: ti,am65x-dss: add missing properties to dt-schema Tomi Valkeinen
2020-09-16 13:10 ` [PATCH v3 1/2] dt-bindings: display: ti, am65x-dss: " Tomi Valkeinen
2020-09-18 1:18 ` [PATCH v3 1/2] dt-bindings: display: ti,am65x-dss: " Laurent Pinchart
2020-09-18 1:18 ` Laurent Pinchart
2020-09-18 8:12 ` Tomi Valkeinen
2020-09-18 8:12 ` Tomi Valkeinen
2020-09-16 13:10 ` [PATCH v3 2/2] dt-bindings: display: ti,j721e-dss: " Tomi Valkeinen
2020-09-16 13:10 ` [PATCH v3 2/2] dt-bindings: display: ti, j721e-dss: " Tomi Valkeinen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.