* [PATCH] i40e: Fix use of uninitialized variable
@ 2020-09-16 20:49 ` Alex Dewar
0 siblings, 0 replies; 4+ messages in thread
From: Alex Dewar @ 2020-09-16 20:49 UTC (permalink / raw)
Cc: Alex Dewar, Jeff Kirsher, David S. Miller, Jakub Kicinski,
Tony Nguyen, Björn Töpel, intel-wired-lan, netdev,
linux-kernel
In i40e_clean_rx_irq_zc(), the variable failure is only set when a
condition is met, but then its value is used unconditionally. Fix this.
Addresses-Coverity: 1496986 ("Uninitialized value")
Fixes: 8cbf74149903 ("i40e, xsk: move buffer allocation out of the Rx processing loop")
Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
---
drivers/net/ethernet/intel/i40e/i40e_xsk.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_xsk.c b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
index 6acede0acdca..18c05d23e15e 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_xsk.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
@@ -364,8 +364,8 @@ int i40e_clean_rx_irq_zc(struct i40e_ring *rx_ring, int budget)
napi_gro_receive(&rx_ring->q_vector->napi, skb);
}
- if (cleaned_count >= I40E_RX_BUFFER_WRITE)
- failure = !i40e_alloc_rx_buffers_zc(rx_ring, cleaned_count);
+ failure = (cleaned_count >= I40E_RX_BUFFER_WRITE) &&
+ !i40e_alloc_rx_buffers_zc(rx_ring, cleaned_count);
i40e_finalize_xdp_rx(rx_ring, xdp_xmit);
i40e_update_rx_stats(rx_ring, total_rx_bytes, total_rx_packets);
--
2.28.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Intel-wired-lan] [PATCH] i40e: Fix use of uninitialized variable
@ 2020-09-16 20:49 ` Alex Dewar
0 siblings, 0 replies; 4+ messages in thread
From: Alex Dewar @ 2020-09-16 20:49 UTC (permalink / raw)
To: intel-wired-lan
In i40e_clean_rx_irq_zc(), the variable failure is only set when a
condition is met, but then its value is used unconditionally. Fix this.
Addresses-Coverity: 1496986 ("Uninitialized value")
Fixes: 8cbf74149903 ("i40e, xsk: move buffer allocation out of the Rx processing loop")
Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
---
drivers/net/ethernet/intel/i40e/i40e_xsk.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_xsk.c b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
index 6acede0acdca..18c05d23e15e 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_xsk.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
@@ -364,8 +364,8 @@ int i40e_clean_rx_irq_zc(struct i40e_ring *rx_ring, int budget)
napi_gro_receive(&rx_ring->q_vector->napi, skb);
}
- if (cleaned_count >= I40E_RX_BUFFER_WRITE)
- failure = !i40e_alloc_rx_buffers_zc(rx_ring, cleaned_count);
+ failure = (cleaned_count >= I40E_RX_BUFFER_WRITE) &&
+ !i40e_alloc_rx_buffers_zc(rx_ring, cleaned_count);
i40e_finalize_xdp_rx(rx_ring, xdp_xmit);
i40e_update_rx_stats(rx_ring, total_rx_bytes, total_rx_packets);
--
2.28.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] i40e: Fix use of uninitialized variable
2020-09-16 20:49 ` [Intel-wired-lan] " Alex Dewar
@ 2020-09-17 21:11 ` Nguyen, Anthony L
-1 siblings, 0 replies; 4+ messages in thread
From: Nguyen, Anthony L @ 2020-09-17 21:11 UTC (permalink / raw)
To: alex.dewar90
Cc: netdev, davem, Kirsher, Jeffrey T, intel-wired-lan, kuba,
linux-kernel, Topel, Bjorn
On Wed, 2020-09-16 at 21:49 +0100, Alex Dewar wrote:
> In i40e_clean_rx_irq_zc(), the variable failure is only set when a
> condition is met, but then its value is used unconditionally. Fix
> this.
>
> Addresses-Coverity: 1496986 ("Uninitialized value")
> Fixes: 8cbf74149903 ("i40e, xsk: move buffer allocation out of the Rx
> processing loop")
> Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
Thanks for the patch Alex, however, Dan Carpenter has already submitted
a patch for the same reported issue:
https://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200916143228.GA764370@mwanda/
Thanks,
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-wired-lan] [PATCH] i40e: Fix use of uninitialized variable
@ 2020-09-17 21:11 ` Nguyen, Anthony L
0 siblings, 0 replies; 4+ messages in thread
From: Nguyen, Anthony L @ 2020-09-17 21:11 UTC (permalink / raw)
To: intel-wired-lan
On Wed, 2020-09-16 at 21:49 +0100, Alex Dewar wrote:
> In i40e_clean_rx_irq_zc(), the variable failure is only set when a
> condition is met, but then its value is used unconditionally. Fix
> this.
>
> Addresses-Coverity: 1496986 ("Uninitialized value")
> Fixes: 8cbf74149903 ("i40e, xsk: move buffer allocation out of the Rx
> processing loop")
> Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
Thanks for the patch Alex, however, Dan Carpenter has already submitted
a patch for the same reported issue:
https://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200916143228.GA764370 at mwanda/
Thanks,
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-17 21:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-16 20:49 [PATCH] i40e: Fix use of uninitialized variable Alex Dewar
2020-09-16 20:49 ` [Intel-wired-lan] " Alex Dewar
2020-09-17 21:11 ` Nguyen, Anthony L
2020-09-17 21:11 ` [Intel-wired-lan] " Nguyen, Anthony L
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.