From: Christoph Hellwig <hch@lst.de> To: Andrew Morton <akpm@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, Jani Nikula <jani.nikula@linux.intel.com>, Joonas Lahtinen <joonas.lahtinen@linux.intel.com>, Rodrigo Vivi <rodrigo.vivi@intel.com>, Minchan Kim <minchan@kernel.org>, Nitin Gupta <ngupta@vflare.org>, x86@kernel.org, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org Subject: remove alloc_vm_area Date: Fri, 18 Sep 2020 18:37:18 +0200 [thread overview] Message-ID: <20200918163724.2511-1-hch@lst.de> (raw) Hi Andrew, this series removes alloc_vm_area, which was left over from the big vmalloc interface rework. It is a rather arkane interface, basicaly the equivalent of get_vm_area + actually faulting in all PTEs in the allocated area. It was originally addeds for Xen (which isn't modular to start with), and then grew users in zsmalloc and i915 which seems to mostly qualify as abuses of the interface, especially for i915 as a random driver should not set up PTE bits directly. Note that my laptop doesn't seem to actually exercise the new vmap_pfn path, so careful review from the i915 maintainers is very welcome. Also I wonder why zsmalloc is even doing the manual allocation of kernel virtual address space plus mapping into it. IMHO zsmalloc should be using our normal vm_map_ram / vm_unmap_ram interface instead of being so special, which would also allow building it as a module again for the virtual mapping case. Diffstat: arch/x86/xen/grant-table.c | 27 +++++--- drivers/gpu/drm/i915/Kconfig | 1 drivers/gpu/drm/i915/gem/i915_gem_pages.c | 101 +++++++++++++----------------- drivers/gpu/drm/i915/gt/shmem_utils.c | 90 +++++++++++--------------- drivers/xen/xenbus/xenbus_client.c | 30 ++++---- include/linux/vmalloc.h | 6 - mm/Kconfig | 3 mm/nommu.c | 7 -- mm/vmalloc.c | 93 +++++++++++++-------------- mm/zsmalloc.c | 2 10 files changed, 172 insertions(+), 188 deletions(-)
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de> To: Andrew Morton <akpm@linux-foundation.org> Cc: Juergen Gross <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, linux-mm@kvack.org, Peter Zijlstra <peterz@infradead.org>, intel-gfx@lists.freedesktop.org, x86@kernel.org, linux-kernel@vger.kernel.org, Minchan Kim <minchan@kernel.org>, dri-devel@lists.freedesktop.org, xen-devel@lists.xenproject.org, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Nitin Gupta <ngupta@vflare.org> Subject: [Intel-gfx] remove alloc_vm_area Date: Fri, 18 Sep 2020 18:37:18 +0200 [thread overview] Message-ID: <20200918163724.2511-1-hch@lst.de> (raw) Hi Andrew, this series removes alloc_vm_area, which was left over from the big vmalloc interface rework. It is a rather arkane interface, basicaly the equivalent of get_vm_area + actually faulting in all PTEs in the allocated area. It was originally addeds for Xen (which isn't modular to start with), and then grew users in zsmalloc and i915 which seems to mostly qualify as abuses of the interface, especially for i915 as a random driver should not set up PTE bits directly. Note that my laptop doesn't seem to actually exercise the new vmap_pfn path, so careful review from the i915 maintainers is very welcome. Also I wonder why zsmalloc is even doing the manual allocation of kernel virtual address space plus mapping into it. IMHO zsmalloc should be using our normal vm_map_ram / vm_unmap_ram interface instead of being so special, which would also allow building it as a module again for the virtual mapping case. Diffstat: arch/x86/xen/grant-table.c | 27 +++++--- drivers/gpu/drm/i915/Kconfig | 1 drivers/gpu/drm/i915/gem/i915_gem_pages.c | 101 +++++++++++++----------------- drivers/gpu/drm/i915/gt/shmem_utils.c | 90 +++++++++++--------------- drivers/xen/xenbus/xenbus_client.c | 30 ++++---- include/linux/vmalloc.h | 6 - mm/Kconfig | 3 mm/nommu.c | 7 -- mm/vmalloc.c | 93 +++++++++++++-------------- mm/zsmalloc.c | 2 10 files changed, 172 insertions(+), 188 deletions(-) _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2020-09-18 16:40 UTC|newest] Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-18 16:37 Christoph Hellwig [this message] 2020-09-18 16:37 ` [Intel-gfx] remove alloc_vm_area Christoph Hellwig 2020-09-18 16:37 ` [PATCH 1/6] zsmalloc: switch from alloc_vm_area to get_vm_area Christoph Hellwig 2020-09-18 16:37 ` [Intel-gfx] " Christoph Hellwig 2020-09-21 17:42 ` Minchan Kim 2020-09-21 17:42 ` [Intel-gfx] " Minchan Kim 2020-09-21 17:42 ` Minchan Kim 2020-09-21 18:17 ` Christoph Hellwig 2020-09-21 18:17 ` [Intel-gfx] " Christoph Hellwig 2020-09-21 18:42 ` Minchan Kim 2020-09-21 18:42 ` [Intel-gfx] " Minchan Kim 2020-09-21 18:42 ` Minchan Kim 2020-09-21 18:43 ` Christoph Hellwig 2020-09-21 18:43 ` [Intel-gfx] " Christoph Hellwig 2020-09-18 16:37 ` [PATCH 2/6] mm: add a vmap_pfn function Christoph Hellwig 2020-09-18 16:37 ` [Intel-gfx] " Christoph Hellwig 2020-09-18 16:37 ` [PATCH 3/6] drm/i915: use vmap in shmem_pin_map Christoph Hellwig 2020-09-18 16:37 ` [Intel-gfx] " Christoph Hellwig 2020-09-21 19:11 ` Matthew Wilcox 2020-09-21 19:11 ` [Intel-gfx] " Matthew Wilcox 2020-09-21 19:11 ` Matthew Wilcox 2020-09-22 6:22 ` Christoph Hellwig 2020-09-22 6:22 ` [Intel-gfx] " Christoph Hellwig 2020-09-22 8:23 ` Tvrtko Ursulin 2020-09-22 8:23 ` Tvrtko Ursulin 2020-09-22 8:23 ` Tvrtko Ursulin 2020-09-22 14:31 ` Christoph Hellwig 2020-09-22 14:31 ` Christoph Hellwig 2020-09-22 16:13 ` Tvrtko Ursulin 2020-09-22 16:13 ` Tvrtko Ursulin 2020-09-22 16:13 ` Tvrtko Ursulin 2020-09-22 16:33 ` Christoph Hellwig 2020-09-22 16:33 ` Christoph Hellwig 2020-09-22 17:04 ` Tvrtko Ursulin 2020-09-22 17:04 ` Tvrtko Ursulin 2020-09-22 17:04 ` Tvrtko Ursulin 2020-09-23 6:11 ` Christoph Hellwig 2020-09-23 6:11 ` Christoph Hellwig 2020-09-22 11:21 ` Matthew Wilcox 2020-09-22 11:21 ` [Intel-gfx] " Matthew Wilcox 2020-09-22 11:21 ` Matthew Wilcox 2020-09-22 14:39 ` Christoph Hellwig 2020-09-22 14:39 ` [Intel-gfx] " Christoph Hellwig 2020-09-22 14:53 ` Matthew Wilcox 2020-09-22 14:53 ` [Intel-gfx] " Matthew Wilcox 2020-09-22 14:53 ` Matthew Wilcox 2020-09-18 16:37 ` [PATCH 4/6] drm/i915: use vmap in i915_gem_object_map Christoph Hellwig 2020-09-18 16:37 ` [Intel-gfx] " Christoph Hellwig 2020-09-23 9:52 ` Tvrtko Ursulin 2020-09-23 9:52 ` Tvrtko Ursulin 2020-09-23 9:52 ` Tvrtko Ursulin 2020-09-23 13:41 ` Christoph Hellwig 2020-09-23 13:41 ` Christoph Hellwig 2020-09-23 13:58 ` Tvrtko Ursulin 2020-09-23 13:58 ` Tvrtko Ursulin 2020-09-23 13:58 ` Tvrtko Ursulin 2020-09-23 14:44 ` Christoph Hellwig 2020-09-23 14:44 ` Christoph Hellwig 2020-09-24 12:22 ` Tvrtko Ursulin 2020-09-24 12:22 ` Tvrtko Ursulin 2020-09-24 12:22 ` Tvrtko Ursulin 2020-09-24 13:23 ` Christoph Hellwig 2020-09-24 13:23 ` Christoph Hellwig 2020-09-18 16:37 ` [PATCH 5/6] xen/xenbus: use apply_to_page_range directly in xenbus_map_ring_pv Christoph Hellwig 2020-09-18 16:37 ` [Intel-gfx] " Christoph Hellwig 2020-09-18 16:37 ` [PATCH 6/6] x86/xen: open code alloc_vm_area in arch_gnttab_valloc Christoph Hellwig 2020-09-18 16:37 ` [Intel-gfx] " Christoph Hellwig 2020-09-21 20:44 ` boris.ostrovsky 2020-09-21 20:44 ` [Intel-gfx] " boris.ostrovsky 2020-09-21 20:44 ` boris.ostrovsky 2020-09-22 14:58 ` Christoph Hellwig 2020-09-22 14:58 ` [Intel-gfx] " Christoph Hellwig 2020-09-22 15:24 ` boris.ostrovsky 2020-09-22 15:24 ` [Intel-gfx] " boris.ostrovsky 2020-09-22 15:24 ` boris.ostrovsky 2020-09-22 15:27 ` Christoph Hellwig 2020-09-22 15:27 ` [Intel-gfx] " Christoph Hellwig 2020-09-22 15:34 ` boris.ostrovsky 2020-09-22 15:34 ` [Intel-gfx] " boris.ostrovsky 2020-09-22 15:34 ` boris.ostrovsky 2020-09-18 17:03 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/6] zsmalloc: switch from alloc_vm_area to get_vm_area Patchwork 2020-09-21 17:50 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/6] zsmalloc: switch from alloc_vm_area to get_vm_area (rev2) Patchwork 2020-09-21 18:47 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/6] zsmalloc: switch from alloc_vm_area to get_vm_area (rev3) Patchwork 2020-09-22 14:44 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/6] zsmalloc: switch from alloc_vm_area to get_vm_area (rev4) Patchwork 2020-09-22 15:01 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/6] zsmalloc: switch from alloc_vm_area to get_vm_area (rev5) Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200918163724.2511-1-hch@lst.de \ --to=hch@lst.de \ --cc=akpm@linux-foundation.org \ --cc=boris.ostrovsky@oracle.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=jani.nikula@linux.intel.com \ --cc=jgross@suse.com \ --cc=joonas.lahtinen@linux.intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=minchan@kernel.org \ --cc=ngupta@vflare.org \ --cc=peterz@infradead.org \ --cc=rodrigo.vivi@intel.com \ --cc=sstabellini@kernel.org \ --cc=x86@kernel.org \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.