All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	qemu-riscv@nongnu.org, "David Hildenbrand" <david@redhat.com>,
	qemu-ppc@nongnu.org, "Cornelia Huck" <cohuck@redhat.com>,
	qemu-devel@nongnu.org, qemu-s390x@nongnu.org,
	qemu-arm@nongnu.org,
	"Alistair Francis" <Alistair.Francis@wdc.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"David Gibson" <david@gibson.dropbear.id.au>
Subject: Re: [PATCH v2 0/6] qom: Allow object to be aligned
Date: Fri, 18 Sep 2020 14:00:06 -0400	[thread overview]
Message-ID: <20200918180006.GC7594@habkost.net> (raw)
In-Reply-To: <20200916004638.2444147-1-richard.henderson@linaro.org>

On Tue, Sep 15, 2020 at 05:46:32PM -0700, Richard Henderson wrote:
> I've seen some failures on arm and s390x hosts after
> enabling host vector support.  It turns out that the
> malloc for these hosts does not provide 16-byte alignment.
> 
> We already have a function that can alloc with alignment,
> but we need to pass this down from the structure.  We also
> don't want to use this function unconditionally, because
> the windows version does page allocation, which would be
> overkill for the vast majority of the objects allocated.

I'm queueing patches 2-6.  Thanks!

-- 
Eduardo



WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Habkost <ehabkost@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Alistair Francis" <Alistair.Francis@wdc.com>,
	"David Hildenbrand" <david@redhat.com>,
	"Cornelia Huck" <cohuck@redhat.com>,
	qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org,
	qemu-s390x@nongnu.org
Subject: Re: [PATCH v2 0/6] qom: Allow object to be aligned
Date: Fri, 18 Sep 2020 14:00:06 -0400	[thread overview]
Message-ID: <20200918180006.GC7594@habkost.net> (raw)
In-Reply-To: <20200916004638.2444147-1-richard.henderson@linaro.org>

On Tue, Sep 15, 2020 at 05:46:32PM -0700, Richard Henderson wrote:
> I've seen some failures on arm and s390x hosts after
> enabling host vector support.  It turns out that the
> malloc for these hosts does not provide 16-byte alignment.
> 
> We already have a function that can alloc with alignment,
> but we need to pass this down from the structure.  We also
> don't want to use this function unconditionally, because
> the windows version does page allocation, which would be
> overkill for the vast majority of the objects allocated.

I'm queueing patches 2-6.  Thanks!

-- 
Eduardo



  parent reply	other threads:[~2020-09-18 18:02 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-16  0:46 [PATCH v2 0/6] qom: Allow object to be aligned Richard Henderson
2020-09-16  0:46 ` Richard Henderson
2020-09-16  0:46 ` [PATCH v2 1/6] util/oslib-win32: Use _aligned_malloc for qemu_try_memalign Richard Henderson
2020-09-16  3:39   ` Stefan Weil
2020-09-17 18:43   ` Eduardo Habkost
2020-09-17 20:34     ` Richard Henderson
2020-09-16  0:46 ` [PATCH v2 2/6] qom: Allow objects to be allocated with increased alignment Richard Henderson
2020-09-16  0:46 ` [PATCH v2 3/6] target/arm: Set instance_align on CPUARM TypeInfo Richard Henderson
2020-09-16  0:46 ` [PATCH v2 4/6] target/ppc: Set instance_align on PowerPCCPU TypeInfo Richard Henderson
2020-09-16  2:18   ` David Gibson
2020-09-16  0:46 ` [PATCH v2 5/6] target/riscv: Set instance_align on RISCVCPU TypeInfo Richard Henderson
2020-09-16  0:46   ` Richard Henderson
2020-09-16 14:58   ` Alistair Francis
2020-09-16 14:58     ` Alistair Francis
2020-09-16  0:46 ` [PATCH v2 6/6] target/s390x: Set instance_align on S390CPU TypeInfo Richard Henderson
2020-09-18 18:00 ` Eduardo Habkost [this message]
2020-09-18 18:00   ` [PATCH v2 0/6] qom: Allow object to be aligned Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200918180006.GC7594@habkost.net \
    --to=ehabkost@redhat.com \
    --cc=Alistair.Francis@wdc.com \
    --cc=berrange@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=david@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.