From: Vivek Goyal <vgoyal@redhat.com> To: Miklos Szeredi <miklos@szeredi.hu> Cc: virtio-fs-list <virtio-fs@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com> Subject: Re: [PATCH] virtiofsd: Used glib "shared" thread pool Date: Tue, 22 Sep 2020 13:29:57 -0400 [thread overview] Message-ID: <20200922172957.GB57620@redhat.com> (raw) In-Reply-To: <CAJfpegujM0ygoBT5uPf4zBUDiphDTwgu97NfqaEgaa8HoSnuRw@mail.gmail.com> On Tue, Sep 22, 2020 at 02:03:18PM +0200, Miklos Szeredi wrote: > On Mon, Sep 21, 2020 at 11:32 PM Vivek Goyal <vgoyal@redhat.com> wrote: > > > glib offers thread pools and it seems to support "exclusive" and "shared" > > thread pools. > > > > > > https://developer.gnome.org/glib/stable/glib-Thread-Pools.html#g-thread-pool-new > > > > Currently we use "exlusive" thread pools but its performance seems to be > > poor. I tried using "shared" thread pools and performance seems much > > better. I posted performance results here. > > > > https://www.redhat.com/archives/virtio-fs/2020-September/msg00080.html > > > > So lets switch to shared thread pools. We can think of making it optional > > once somebody can show in what cases exclusive thread pools offer better > > results. For now, my simple performance tests across the board see > > better results with shared thread pools. > > > > Needs this as well: I was wondering why I did not face this issue. I think my glib is old (glib2, 2.58.3) from fedora 29 and this change about sched_getattr seems relatively recent. commit 8aeca4fa647bfd0f35c4a86b1e6ca6e955519ca5 Author: Sebastian Dröge <sebastian@centricular.com> Date: Tue Dec 24 15:33:30 2019 +0200 GThreadPool - Don't inherit thread priorities when creating new threads I think my glib2 does not have this change and probably that's why seccomp did not trigger. Vivek > > --- qemu.orig/tools/virtiofsd/passthrough_seccomp.c 2020-09-16 > 20:21:13.168686176 +0200 > +++ qemu/tools/virtiofsd/passthrough_seccomp.c 2020-09-22 > 14:01:38.499164501 +0200 > @@ -94,6 +94,8 @@ static const int syscall_whitelist[] = { > SCMP_SYS(rt_sigaction), > SCMP_SYS(rt_sigprocmask), > SCMP_SYS(rt_sigreturn), > + SCMP_SYS(sched_getattr), > + SCMP_SYS(sched_setattr), > SCMP_SYS(sendmsg), > SCMP_SYS(setresgid), > SCMP_SYS(setresuid), > > Thanks, > Miklos
WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal@redhat.com> To: Miklos Szeredi <miklos@szeredi.hu> Cc: virtio-fs-list <virtio-fs@redhat.com>, qemu-devel@nongnu.org Subject: Re: [Virtio-fs] [PATCH] virtiofsd: Used glib "shared" thread pool Date: Tue, 22 Sep 2020 13:29:57 -0400 [thread overview] Message-ID: <20200922172957.GB57620@redhat.com> (raw) In-Reply-To: <CAJfpegujM0ygoBT5uPf4zBUDiphDTwgu97NfqaEgaa8HoSnuRw@mail.gmail.com> On Tue, Sep 22, 2020 at 02:03:18PM +0200, Miklos Szeredi wrote: > On Mon, Sep 21, 2020 at 11:32 PM Vivek Goyal <vgoyal@redhat.com> wrote: > > > glib offers thread pools and it seems to support "exclusive" and "shared" > > thread pools. > > > > > > https://developer.gnome.org/glib/stable/glib-Thread-Pools.html#g-thread-pool-new > > > > Currently we use "exlusive" thread pools but its performance seems to be > > poor. I tried using "shared" thread pools and performance seems much > > better. I posted performance results here. > > > > https://www.redhat.com/archives/virtio-fs/2020-September/msg00080.html > > > > So lets switch to shared thread pools. We can think of making it optional > > once somebody can show in what cases exclusive thread pools offer better > > results. For now, my simple performance tests across the board see > > better results with shared thread pools. > > > > Needs this as well: I was wondering why I did not face this issue. I think my glib is old (glib2, 2.58.3) from fedora 29 and this change about sched_getattr seems relatively recent. commit 8aeca4fa647bfd0f35c4a86b1e6ca6e955519ca5 Author: Sebastian Dröge <sebastian@centricular.com> Date: Tue Dec 24 15:33:30 2019 +0200 GThreadPool - Don't inherit thread priorities when creating new threads I think my glib2 does not have this change and probably that's why seccomp did not trigger. Vivek > > --- qemu.orig/tools/virtiofsd/passthrough_seccomp.c 2020-09-16 > 20:21:13.168686176 +0200 > +++ qemu/tools/virtiofsd/passthrough_seccomp.c 2020-09-22 > 14:01:38.499164501 +0200 > @@ -94,6 +94,8 @@ static const int syscall_whitelist[] = { > SCMP_SYS(rt_sigaction), > SCMP_SYS(rt_sigprocmask), > SCMP_SYS(rt_sigreturn), > + SCMP_SYS(sched_getattr), > + SCMP_SYS(sched_setattr), > SCMP_SYS(sendmsg), > SCMP_SYS(setresgid), > SCMP_SYS(setresuid), > > Thanks, > Miklos
next prev parent reply other threads:[~2020-09-22 17:34 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-21 21:32 [PATCH] virtiofsd: Used glib "shared" thread pool Vivek Goyal 2020-09-21 21:32 ` [Virtio-fs] " Vivek Goyal 2020-09-22 12:03 ` Miklos Szeredi 2020-09-22 12:03 ` [Virtio-fs] " Miklos Szeredi 2020-09-22 12:40 ` Vivek Goyal 2020-09-22 12:40 ` [Virtio-fs] " Vivek Goyal 2020-09-22 17:29 ` Vivek Goyal [this message] 2020-09-22 17:29 ` Vivek Goyal 2020-09-22 12:59 ` Daniel P. Berrangé 2020-09-22 12:59 ` [Virtio-fs] " Daniel P. Berrangé 2020-09-22 17:42 ` Vivek Goyal 2020-09-22 17:42 ` [Virtio-fs] " Vivek Goyal 2020-09-22 17:46 ` Daniel P. Berrangé 2020-09-22 17:46 ` [Virtio-fs] " Daniel P. Berrangé 2020-09-23 12:22 ` Stefan Hajnoczi 2020-09-23 12:22 ` [Virtio-fs] " Stefan Hajnoczi 2020-09-24 9:29 ` Dr. David Alan Gilbert 2020-09-24 9:29 ` [Virtio-fs] " Dr. David Alan Gilbert
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200922172957.GB57620@redhat.com \ --to=vgoyal@redhat.com \ --cc=dgilbert@redhat.com \ --cc=miklos@szeredi.hu \ --cc=qemu-devel@nongnu.org \ --cc=stefanha@redhat.com \ --cc=virtio-fs@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.