From: "Dr. David Alan Gilbert" <dgilbert@redhat.com> To: Vivek Goyal <vgoyal@redhat.com> Cc: virtio-fs-list <virtio-fs@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Miklos Szeredi <miklos@szeredi.hu> Subject: Re: [PATCH] virtiofsd: Used glib "shared" thread pool Date: Thu, 24 Sep 2020 10:29:35 +0100 [thread overview] Message-ID: <20200924092935.GC2792@work-vm> (raw) In-Reply-To: <20200921213216.GE13362@redhat.com> * Vivek Goyal (vgoyal@redhat.com) wrote: > glib offers thread pools and it seems to support "exclusive" and "shared" > thread pools. > > https://developer.gnome.org/glib/stable/glib-Thread-Pools.html#g-thread-pool-new > > Currently we use "exlusive" thread pools but its performance seems to be > poor. I tried using "shared" thread pools and performance seems much > better. I posted performance results here. > > https://www.redhat.com/archives/virtio-fs/2020-September/msg00080.html > > So lets switch to shared thread pools. We can think of making it optional > once somebody can show in what cases exclusive thread pools offer better > results. For now, my simple performance tests across the board see > better results with shared thread pools. > > Signed-off-by: Vivek Goyal <vgoyal@redhat.com> Queued (with Miklos's seccomp fix); although my gut feeling is we'll be coming back to this again to understand how the threading should work. Dave > --- > tools/virtiofsd/fuse_virtio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: qemu/tools/virtiofsd/fuse_virtio.c > =================================================================== > --- qemu.orig/tools/virtiofsd/fuse_virtio.c 2020-09-21 17:28:27.444438015 -0400 > +++ qemu/tools/virtiofsd/fuse_virtio.c 2020-09-21 17:28:30.584568910 -0400 > @@ -695,7 +695,7 @@ static void *fv_queue_thread(void *opaqu > struct fuse_session *se = qi->virtio_dev->se; > GThreadPool *pool; > > - pool = g_thread_pool_new(fv_queue_worker, qi, se->thread_pool_size, TRUE, > + pool = g_thread_pool_new(fv_queue_worker, qi, se->thread_pool_size, FALSE, > NULL); > if (!pool) { > fuse_log(FUSE_LOG_ERR, "%s: g_thread_pool_new failed\n", __func__); -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
WARNING: multiple messages have this Message-ID (diff)
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com> To: Vivek Goyal <vgoyal@redhat.com> Cc: virtio-fs-list <virtio-fs@redhat.com>, qemu-devel@nongnu.org, Miklos Szeredi <miklos@szeredi.hu> Subject: Re: [Virtio-fs] [PATCH] virtiofsd: Used glib "shared" thread pool Date: Thu, 24 Sep 2020 10:29:35 +0100 [thread overview] Message-ID: <20200924092935.GC2792@work-vm> (raw) In-Reply-To: <20200921213216.GE13362@redhat.com> * Vivek Goyal (vgoyal@redhat.com) wrote: > glib offers thread pools and it seems to support "exclusive" and "shared" > thread pools. > > https://developer.gnome.org/glib/stable/glib-Thread-Pools.html#g-thread-pool-new > > Currently we use "exlusive" thread pools but its performance seems to be > poor. I tried using "shared" thread pools and performance seems much > better. I posted performance results here. > > https://www.redhat.com/archives/virtio-fs/2020-September/msg00080.html > > So lets switch to shared thread pools. We can think of making it optional > once somebody can show in what cases exclusive thread pools offer better > results. For now, my simple performance tests across the board see > better results with shared thread pools. > > Signed-off-by: Vivek Goyal <vgoyal@redhat.com> Queued (with Miklos's seccomp fix); although my gut feeling is we'll be coming back to this again to understand how the threading should work. Dave > --- > tools/virtiofsd/fuse_virtio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: qemu/tools/virtiofsd/fuse_virtio.c > =================================================================== > --- qemu.orig/tools/virtiofsd/fuse_virtio.c 2020-09-21 17:28:27.444438015 -0400 > +++ qemu/tools/virtiofsd/fuse_virtio.c 2020-09-21 17:28:30.584568910 -0400 > @@ -695,7 +695,7 @@ static void *fv_queue_thread(void *opaqu > struct fuse_session *se = qi->virtio_dev->se; > GThreadPool *pool; > > - pool = g_thread_pool_new(fv_queue_worker, qi, se->thread_pool_size, TRUE, > + pool = g_thread_pool_new(fv_queue_worker, qi, se->thread_pool_size, FALSE, > NULL); > if (!pool) { > fuse_log(FUSE_LOG_ERR, "%s: g_thread_pool_new failed\n", __func__); -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2020-09-24 10:23 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-21 21:32 [PATCH] virtiofsd: Used glib "shared" thread pool Vivek Goyal 2020-09-21 21:32 ` [Virtio-fs] " Vivek Goyal 2020-09-22 12:03 ` Miklos Szeredi 2020-09-22 12:03 ` [Virtio-fs] " Miklos Szeredi 2020-09-22 12:40 ` Vivek Goyal 2020-09-22 12:40 ` [Virtio-fs] " Vivek Goyal 2020-09-22 17:29 ` Vivek Goyal 2020-09-22 17:29 ` [Virtio-fs] " Vivek Goyal 2020-09-22 12:59 ` Daniel P. Berrangé 2020-09-22 12:59 ` [Virtio-fs] " Daniel P. Berrangé 2020-09-22 17:42 ` Vivek Goyal 2020-09-22 17:42 ` [Virtio-fs] " Vivek Goyal 2020-09-22 17:46 ` Daniel P. Berrangé 2020-09-22 17:46 ` [Virtio-fs] " Daniel P. Berrangé 2020-09-23 12:22 ` Stefan Hajnoczi 2020-09-23 12:22 ` [Virtio-fs] " Stefan Hajnoczi 2020-09-24 9:29 ` Dr. David Alan Gilbert [this message] 2020-09-24 9:29 ` Dr. David Alan Gilbert
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200924092935.GC2792@work-vm \ --to=dgilbert@redhat.com \ --cc=miklos@szeredi.hu \ --cc=qemu-devel@nongnu.org \ --cc=stefanha@redhat.com \ --cc=vgoyal@redhat.com \ --cc=virtio-fs@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.