All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] MAINTAINERS: Update section for cpuidle-psci
@ 2020-08-14 12:37 ` Ulf Hansson
  0 siblings, 0 replies; 16+ messages in thread
From: Ulf Hansson @ 2020-08-14 12:37 UTC (permalink / raw)
  To: Sudeep Holla, Lorenzo Pieralisi, linux-pm
  Cc: Rafael J . Wysocki, Daniel Lezcano, Lina Iyer, Lukasz Luba,
	Vincent Guittot, Stephen Boyd, Bjorn Andersson,
	Benjamin Gaignard, Ulf Hansson, linux-arm-kernel

Extend the file pattern to also include cpuidle-psci.h and
cpuidle-psci-domain.c. Moreover, add myself as a co-maintainer,
particularly to help with the support for PM domains.

Cc: Sudeep Holla <sudeep.holla@arm.com>
Cc: Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index f9ae8ea54e27..66821197175e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4556,10 +4556,11 @@ F:	drivers/cpuidle/cpuidle-exynos.c
 CPUIDLE DRIVER - ARM PSCI
 M:	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
 M:	Sudeep Holla <sudeep.holla@arm.com>
+M:	Ulf Hansson <ulf.hansson@linaro.org>
 L:	linux-pm@vger.kernel.org
 L:	linux-arm-kernel@lists.infradead.org
 S:	Supported
-F:	drivers/cpuidle/cpuidle-psci.c
+F:	drivers/cpuidle/cpuidle-psci*
 
 CRAMFS FILESYSTEM
 M:	Nicolas Pitre <nico@fluxnic.net>
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH] MAINTAINERS: Update section for cpuidle-psci
@ 2020-08-14 12:37 ` Ulf Hansson
  0 siblings, 0 replies; 16+ messages in thread
From: Ulf Hansson @ 2020-08-14 12:37 UTC (permalink / raw)
  To: Sudeep Holla, Lorenzo Pieralisi, linux-pm
  Cc: Ulf Hansson, Vincent Guittot, Benjamin Gaignard, Stephen Boyd,
	Daniel Lezcano, Rafael J . Wysocki, Lina Iyer, Bjorn Andersson,
	linux-arm-kernel, Lukasz Luba

Extend the file pattern to also include cpuidle-psci.h and
cpuidle-psci-domain.c. Moreover, add myself as a co-maintainer,
particularly to help with the support for PM domains.

Cc: Sudeep Holla <sudeep.holla@arm.com>
Cc: Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index f9ae8ea54e27..66821197175e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4556,10 +4556,11 @@ F:	drivers/cpuidle/cpuidle-exynos.c
 CPUIDLE DRIVER - ARM PSCI
 M:	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
 M:	Sudeep Holla <sudeep.holla@arm.com>
+M:	Ulf Hansson <ulf.hansson@linaro.org>
 L:	linux-pm@vger.kernel.org
 L:	linux-arm-kernel@lists.infradead.org
 S:	Supported
-F:	drivers/cpuidle/cpuidle-psci.c
+F:	drivers/cpuidle/cpuidle-psci*
 
 CRAMFS FILESYSTEM
 M:	Nicolas Pitre <nico@fluxnic.net>
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: [PATCH] MAINTAINERS: Update section for cpuidle-psci
  2020-08-14 12:37 ` Ulf Hansson
@ 2020-09-21 15:49   ` Rafael J. Wysocki
  -1 siblings, 0 replies; 16+ messages in thread
From: Rafael J. Wysocki @ 2020-09-21 15:49 UTC (permalink / raw)
  To: Ulf Hansson
  Cc: Sudeep Holla, Lorenzo Pieralisi, Linux PM, Rafael J . Wysocki,
	Daniel Lezcano, Lina Iyer, Lukasz Luba, Vincent Guittot,
	Stephen Boyd, Bjorn Andersson, Benjamin Gaignard, Linux ARM

On Fri, Aug 14, 2020 at 2:37 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
> Extend the file pattern to also include cpuidle-psci.h and
> cpuidle-psci-domain.c. Moreover, add myself as a co-maintainer,
> particularly to help with the support for PM domains.
>
> Cc: Sudeep Holla <sudeep.holla@arm.com>
> Cc: Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

Any objections from the original maintainers?

> ---
>  MAINTAINERS | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f9ae8ea54e27..66821197175e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4556,10 +4556,11 @@ F:      drivers/cpuidle/cpuidle-exynos.c
>  CPUIDLE DRIVER - ARM PSCI
>  M:     Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
>  M:     Sudeep Holla <sudeep.holla@arm.com>
> +M:     Ulf Hansson <ulf.hansson@linaro.org>
>  L:     linux-pm@vger.kernel.org
>  L:     linux-arm-kernel@lists.infradead.org
>  S:     Supported
> -F:     drivers/cpuidle/cpuidle-psci.c
> +F:     drivers/cpuidle/cpuidle-psci*
>
>  CRAMFS FILESYSTEM
>  M:     Nicolas Pitre <nico@fluxnic.net>
> --
> 2.25.1
>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] MAINTAINERS: Update section for cpuidle-psci
@ 2020-09-21 15:49   ` Rafael J. Wysocki
  0 siblings, 0 replies; 16+ messages in thread
From: Rafael J. Wysocki @ 2020-09-21 15:49 UTC (permalink / raw)
  To: Ulf Hansson
  Cc: Lorenzo Pieralisi, Vincent Guittot, Benjamin Gaignard, Linux PM,
	Stephen Boyd, Daniel Lezcano, Rafael J . Wysocki, Lina Iyer,
	Bjorn Andersson, Linux ARM, Sudeep Holla, Lukasz Luba

On Fri, Aug 14, 2020 at 2:37 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
> Extend the file pattern to also include cpuidle-psci.h and
> cpuidle-psci-domain.c. Moreover, add myself as a co-maintainer,
> particularly to help with the support for PM domains.
>
> Cc: Sudeep Holla <sudeep.holla@arm.com>
> Cc: Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

Any objections from the original maintainers?

> ---
>  MAINTAINERS | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f9ae8ea54e27..66821197175e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4556,10 +4556,11 @@ F:      drivers/cpuidle/cpuidle-exynos.c
>  CPUIDLE DRIVER - ARM PSCI
>  M:     Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
>  M:     Sudeep Holla <sudeep.holla@arm.com>
> +M:     Ulf Hansson <ulf.hansson@linaro.org>
>  L:     linux-pm@vger.kernel.org
>  L:     linux-arm-kernel@lists.infradead.org
>  S:     Supported
> -F:     drivers/cpuidle/cpuidle-psci.c
> +F:     drivers/cpuidle/cpuidle-psci*
>
>  CRAMFS FILESYSTEM
>  M:     Nicolas Pitre <nico@fluxnic.net>
> --
> 2.25.1
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] MAINTAINERS: Update section for cpuidle-psci
  2020-09-21 15:49   ` Rafael J. Wysocki
@ 2020-09-23  8:11     ` Lorenzo Pieralisi
  -1 siblings, 0 replies; 16+ messages in thread
From: Lorenzo Pieralisi @ 2020-09-23  8:11 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Ulf Hansson, Sudeep Holla, Linux PM, Rafael J . Wysocki,
	Daniel Lezcano, Lina Iyer, Lukasz Luba, Vincent Guittot,
	Stephen Boyd, Bjorn Andersson, Benjamin Gaignard, Linux ARM

On Mon, Sep 21, 2020 at 05:49:52PM +0200, Rafael J. Wysocki wrote:
> On Fri, Aug 14, 2020 at 2:37 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> >
> > Extend the file pattern to also include cpuidle-psci.h and
> > cpuidle-psci-domain.c. Moreover, add myself as a co-maintainer,
> > particularly to help with the support for PM domains.
> >
> > Cc: Sudeep Holla <sudeep.holla@arm.com>
> > Cc: Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>
> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> 
> Any objections from the original maintainers?

The PSCI driver providing support for platform coordinated idle states
(that this patch is targeting AFAICS) does not require more maintainers,
that support is complete and Sudeep and I will take care of refactoring
and fixes.

If the OSI bits in it require a specific maintainer I would prefer those
bits to be moved into a specific file and maintainership added
_explicitly_ for that file only.

Thanks,
Lorenzo

> >  MAINTAINERS | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index f9ae8ea54e27..66821197175e 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -4556,10 +4556,11 @@ F:      drivers/cpuidle/cpuidle-exynos.c
> >  CPUIDLE DRIVER - ARM PSCI
> >  M:     Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> >  M:     Sudeep Holla <sudeep.holla@arm.com>
> > +M:     Ulf Hansson <ulf.hansson@linaro.org>
> >  L:     linux-pm@vger.kernel.org
> >  L:     linux-arm-kernel@lists.infradead.org
> >  S:     Supported
> > -F:     drivers/cpuidle/cpuidle-psci.c
> > +F:     drivers/cpuidle/cpuidle-psci*
> >
> >  CRAMFS FILESYSTEM
> >  M:     Nicolas Pitre <nico@fluxnic.net>
> > --
> > 2.25.1
> >

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] MAINTAINERS: Update section for cpuidle-psci
@ 2020-09-23  8:11     ` Lorenzo Pieralisi
  0 siblings, 0 replies; 16+ messages in thread
From: Lorenzo Pieralisi @ 2020-09-23  8:11 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Ulf Hansson, Vincent Guittot, Benjamin Gaignard, Linux PM,
	Stephen Boyd, Daniel Lezcano, Rafael J . Wysocki, Lina Iyer,
	Bjorn Andersson, Linux ARM, Sudeep Holla, Lukasz Luba

On Mon, Sep 21, 2020 at 05:49:52PM +0200, Rafael J. Wysocki wrote:
> On Fri, Aug 14, 2020 at 2:37 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> >
> > Extend the file pattern to also include cpuidle-psci.h and
> > cpuidle-psci-domain.c. Moreover, add myself as a co-maintainer,
> > particularly to help with the support for PM domains.
> >
> > Cc: Sudeep Holla <sudeep.holla@arm.com>
> > Cc: Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>
> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> 
> Any objections from the original maintainers?

The PSCI driver providing support for platform coordinated idle states
(that this patch is targeting AFAICS) does not require more maintainers,
that support is complete and Sudeep and I will take care of refactoring
and fixes.

If the OSI bits in it require a specific maintainer I would prefer those
bits to be moved into a specific file and maintainership added
_explicitly_ for that file only.

Thanks,
Lorenzo

> >  MAINTAINERS | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index f9ae8ea54e27..66821197175e 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -4556,10 +4556,11 @@ F:      drivers/cpuidle/cpuidle-exynos.c
> >  CPUIDLE DRIVER - ARM PSCI
> >  M:     Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> >  M:     Sudeep Holla <sudeep.holla@arm.com>
> > +M:     Ulf Hansson <ulf.hansson@linaro.org>
> >  L:     linux-pm@vger.kernel.org
> >  L:     linux-arm-kernel@lists.infradead.org
> >  S:     Supported
> > -F:     drivers/cpuidle/cpuidle-psci.c
> > +F:     drivers/cpuidle/cpuidle-psci*
> >
> >  CRAMFS FILESYSTEM
> >  M:     Nicolas Pitre <nico@fluxnic.net>
> > --
> > 2.25.1
> >

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] MAINTAINERS: Update section for cpuidle-psci
  2020-09-23  8:11     ` Lorenzo Pieralisi
@ 2020-09-23 13:44       ` Ulf Hansson
  -1 siblings, 0 replies; 16+ messages in thread
From: Ulf Hansson @ 2020-09-23 13:44 UTC (permalink / raw)
  To: Lorenzo Pieralisi
  Cc: Rafael J. Wysocki, Sudeep Holla, Linux PM, Rafael J . Wysocki,
	Daniel Lezcano, Lina Iyer, Lukasz Luba, Vincent Guittot,
	Stephen Boyd, Bjorn Andersson, Benjamin Gaignard, Linux ARM

On Wed, 23 Sep 2020 at 10:11, Lorenzo Pieralisi
<lorenzo.pieralisi@arm.com> wrote:
>
> On Mon, Sep 21, 2020 at 05:49:52PM +0200, Rafael J. Wysocki wrote:
> > On Fri, Aug 14, 2020 at 2:37 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> > >
> > > Extend the file pattern to also include cpuidle-psci.h and
> > > cpuidle-psci-domain.c. Moreover, add myself as a co-maintainer,
> > > particularly to help with the support for PM domains.
> > >
> > > Cc: Sudeep Holla <sudeep.holla@arm.com>
> > > Cc: Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>
> > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> >
> > Any objections from the original maintainers?
>
> The PSCI driver providing support for platform coordinated idle states
> (that this patch is targeting AFAICS) does not require more maintainers,
> that support is complete and Sudeep and I will take care of refactoring
> and fixes.
>
> If the OSI bits in it require a specific maintainer I would prefer those
> bits to be moved into a specific file and maintainership added
> _explicitly_ for that file only.

My main concern is that the OSI support (and some related changes for
genpd) is still being worked upon. The corresponding code deserves to
be looked after by someone. I offer my help with this.

I guess we can split up the code as you suggest, but perhaps another
way would be to explicitly state my part of the responsibility in
MAINTAINERS. Along the lines of this:

M:     Ulf Hansson <ulf.hansson@linaro.org> # OSI support / PM domains

Would that be okay to you?

Kind regards
Uffe

>
> Thanks,
> Lorenzo
>
> > >  MAINTAINERS | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index f9ae8ea54e27..66821197175e 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -4556,10 +4556,11 @@ F:      drivers/cpuidle/cpuidle-exynos.c
> > >  CPUIDLE DRIVER - ARM PSCI
> > >  M:     Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> > >  M:     Sudeep Holla <sudeep.holla@arm.com>
> > > +M:     Ulf Hansson <ulf.hansson@linaro.org>
> > >  L:     linux-pm@vger.kernel.org
> > >  L:     linux-arm-kernel@lists.infradead.org
> > >  S:     Supported
> > > -F:     drivers/cpuidle/cpuidle-psci.c
> > > +F:     drivers/cpuidle/cpuidle-psci*
> > >
> > >  CRAMFS FILESYSTEM
> > >  M:     Nicolas Pitre <nico@fluxnic.net>
> > > --
> > > 2.25.1
> > >

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] MAINTAINERS: Update section for cpuidle-psci
@ 2020-09-23 13:44       ` Ulf Hansson
  0 siblings, 0 replies; 16+ messages in thread
From: Ulf Hansson @ 2020-09-23 13:44 UTC (permalink / raw)
  To: Lorenzo Pieralisi
  Cc: Vincent Guittot, Benjamin Gaignard, Linux PM, Stephen Boyd,
	Daniel Lezcano, Rafael J . Wysocki, Lina Iyer, Bjorn Andersson,
	Linux ARM, Sudeep Holla, Rafael J. Wysocki, Lukasz Luba

On Wed, 23 Sep 2020 at 10:11, Lorenzo Pieralisi
<lorenzo.pieralisi@arm.com> wrote:
>
> On Mon, Sep 21, 2020 at 05:49:52PM +0200, Rafael J. Wysocki wrote:
> > On Fri, Aug 14, 2020 at 2:37 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> > >
> > > Extend the file pattern to also include cpuidle-psci.h and
> > > cpuidle-psci-domain.c. Moreover, add myself as a co-maintainer,
> > > particularly to help with the support for PM domains.
> > >
> > > Cc: Sudeep Holla <sudeep.holla@arm.com>
> > > Cc: Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>
> > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> >
> > Any objections from the original maintainers?
>
> The PSCI driver providing support for platform coordinated idle states
> (that this patch is targeting AFAICS) does not require more maintainers,
> that support is complete and Sudeep and I will take care of refactoring
> and fixes.
>
> If the OSI bits in it require a specific maintainer I would prefer those
> bits to be moved into a specific file and maintainership added
> _explicitly_ for that file only.

My main concern is that the OSI support (and some related changes for
genpd) is still being worked upon. The corresponding code deserves to
be looked after by someone. I offer my help with this.

I guess we can split up the code as you suggest, but perhaps another
way would be to explicitly state my part of the responsibility in
MAINTAINERS. Along the lines of this:

M:     Ulf Hansson <ulf.hansson@linaro.org> # OSI support / PM domains

Would that be okay to you?

Kind regards
Uffe

>
> Thanks,
> Lorenzo
>
> > >  MAINTAINERS | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index f9ae8ea54e27..66821197175e 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -4556,10 +4556,11 @@ F:      drivers/cpuidle/cpuidle-exynos.c
> > >  CPUIDLE DRIVER - ARM PSCI
> > >  M:     Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> > >  M:     Sudeep Holla <sudeep.holla@arm.com>
> > > +M:     Ulf Hansson <ulf.hansson@linaro.org>
> > >  L:     linux-pm@vger.kernel.org
> > >  L:     linux-arm-kernel@lists.infradead.org
> > >  S:     Supported
> > > -F:     drivers/cpuidle/cpuidle-psci.c
> > > +F:     drivers/cpuidle/cpuidle-psci*
> > >
> > >  CRAMFS FILESYSTEM
> > >  M:     Nicolas Pitre <nico@fluxnic.net>
> > > --
> > > 2.25.1
> > >

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] MAINTAINERS: Update section for cpuidle-psci
  2020-09-23 13:44       ` Ulf Hansson
@ 2020-09-30  9:12         ` Lorenzo Pieralisi
  -1 siblings, 0 replies; 16+ messages in thread
From: Lorenzo Pieralisi @ 2020-09-30  9:12 UTC (permalink / raw)
  To: Ulf Hansson
  Cc: Rafael J. Wysocki, Sudeep Holla, Linux PM, Rafael J . Wysocki,
	Daniel Lezcano, Lina Iyer, Lukasz Luba, Vincent Guittot,
	Stephen Boyd, Bjorn Andersson, Benjamin Gaignard, Linux ARM

On Wed, Sep 23, 2020 at 03:44:53PM +0200, Ulf Hansson wrote:
> On Wed, 23 Sep 2020 at 10:11, Lorenzo Pieralisi
> <lorenzo.pieralisi@arm.com> wrote:
> >
> > On Mon, Sep 21, 2020 at 05:49:52PM +0200, Rafael J. Wysocki wrote:
> > > On Fri, Aug 14, 2020 at 2:37 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> > > >
> > > > Extend the file pattern to also include cpuidle-psci.h and
> > > > cpuidle-psci-domain.c. Moreover, add myself as a co-maintainer,
> > > > particularly to help with the support for PM domains.
> > > >
> > > > Cc: Sudeep Holla <sudeep.holla@arm.com>
> > > > Cc: Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>
> > > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> > >
> > > Any objections from the original maintainers?
> >
> > The PSCI driver providing support for platform coordinated idle states
> > (that this patch is targeting AFAICS) does not require more maintainers,
> > that support is complete and Sudeep and I will take care of refactoring
> > and fixes.
> >
> > If the OSI bits in it require a specific maintainer I would prefer those
> > bits to be moved into a specific file and maintainership added
> > _explicitly_ for that file only.
> 
> My main concern is that the OSI support (and some related changes for
> genpd) is still being worked upon. The corresponding code deserves to
> be looked after by someone. I offer my help with this.

All OSI changes can go into cpuidle-psci-domain.c, you can add a
maintainer entry for that.

> I guess we can split up the code as you suggest, but perhaps another
> way would be to explicitly state my part of the responsibility in
> MAINTAINERS. Along the lines of this:
> 
> M:     Ulf Hansson <ulf.hansson@linaro.org> # OSI support / PM domains
> 
> Would that be okay to you?

No because there should be no need, as I have already said. If you need
to change cpuidle-psci.c send patches please and we will review them.

Thanks,
Lorenzo

> > Thanks,
> > Lorenzo
> >
> > > >  MAINTAINERS | 3 ++-
> > > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > index f9ae8ea54e27..66821197175e 100644
> > > > --- a/MAINTAINERS
> > > > +++ b/MAINTAINERS
> > > > @@ -4556,10 +4556,11 @@ F:      drivers/cpuidle/cpuidle-exynos.c
> > > >  CPUIDLE DRIVER - ARM PSCI
> > > >  M:     Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> > > >  M:     Sudeep Holla <sudeep.holla@arm.com>
> > > > +M:     Ulf Hansson <ulf.hansson@linaro.org>
> > > >  L:     linux-pm@vger.kernel.org
> > > >  L:     linux-arm-kernel@lists.infradead.org
> > > >  S:     Supported
> > > > -F:     drivers/cpuidle/cpuidle-psci.c
> > > > +F:     drivers/cpuidle/cpuidle-psci*
> > > >
> > > >  CRAMFS FILESYSTEM
> > > >  M:     Nicolas Pitre <nico@fluxnic.net>
> > > > --
> > > > 2.25.1
> > > >

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] MAINTAINERS: Update section for cpuidle-psci
@ 2020-09-30  9:12         ` Lorenzo Pieralisi
  0 siblings, 0 replies; 16+ messages in thread
From: Lorenzo Pieralisi @ 2020-09-30  9:12 UTC (permalink / raw)
  To: Ulf Hansson
  Cc: Vincent Guittot, Benjamin Gaignard, Linux PM, Stephen Boyd,
	Daniel Lezcano, Rafael J . Wysocki, Lina Iyer, Bjorn Andersson,
	Linux ARM, Sudeep Holla, Rafael J. Wysocki, Lukasz Luba

On Wed, Sep 23, 2020 at 03:44:53PM +0200, Ulf Hansson wrote:
> On Wed, 23 Sep 2020 at 10:11, Lorenzo Pieralisi
> <lorenzo.pieralisi@arm.com> wrote:
> >
> > On Mon, Sep 21, 2020 at 05:49:52PM +0200, Rafael J. Wysocki wrote:
> > > On Fri, Aug 14, 2020 at 2:37 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> > > >
> > > > Extend the file pattern to also include cpuidle-psci.h and
> > > > cpuidle-psci-domain.c. Moreover, add myself as a co-maintainer,
> > > > particularly to help with the support for PM domains.
> > > >
> > > > Cc: Sudeep Holla <sudeep.holla@arm.com>
> > > > Cc: Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>
> > > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> > >
> > > Any objections from the original maintainers?
> >
> > The PSCI driver providing support for platform coordinated idle states
> > (that this patch is targeting AFAICS) does not require more maintainers,
> > that support is complete and Sudeep and I will take care of refactoring
> > and fixes.
> >
> > If the OSI bits in it require a specific maintainer I would prefer those
> > bits to be moved into a specific file and maintainership added
> > _explicitly_ for that file only.
> 
> My main concern is that the OSI support (and some related changes for
> genpd) is still being worked upon. The corresponding code deserves to
> be looked after by someone. I offer my help with this.

All OSI changes can go into cpuidle-psci-domain.c, you can add a
maintainer entry for that.

> I guess we can split up the code as you suggest, but perhaps another
> way would be to explicitly state my part of the responsibility in
> MAINTAINERS. Along the lines of this:
> 
> M:     Ulf Hansson <ulf.hansson@linaro.org> # OSI support / PM domains
> 
> Would that be okay to you?

No because there should be no need, as I have already said. If you need
to change cpuidle-psci.c send patches please and we will review them.

Thanks,
Lorenzo

> > Thanks,
> > Lorenzo
> >
> > > >  MAINTAINERS | 3 ++-
> > > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > index f9ae8ea54e27..66821197175e 100644
> > > > --- a/MAINTAINERS
> > > > +++ b/MAINTAINERS
> > > > @@ -4556,10 +4556,11 @@ F:      drivers/cpuidle/cpuidle-exynos.c
> > > >  CPUIDLE DRIVER - ARM PSCI
> > > >  M:     Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> > > >  M:     Sudeep Holla <sudeep.holla@arm.com>
> > > > +M:     Ulf Hansson <ulf.hansson@linaro.org>
> > > >  L:     linux-pm@vger.kernel.org
> > > >  L:     linux-arm-kernel@lists.infradead.org
> > > >  S:     Supported
> > > > -F:     drivers/cpuidle/cpuidle-psci.c
> > > > +F:     drivers/cpuidle/cpuidle-psci*
> > > >
> > > >  CRAMFS FILESYSTEM
> > > >  M:     Nicolas Pitre <nico@fluxnic.net>
> > > > --
> > > > 2.25.1
> > > >

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] MAINTAINERS: Update section for cpuidle-psci
  2020-09-30  9:12         ` Lorenzo Pieralisi
@ 2020-09-30  9:46           ` Ulf Hansson
  -1 siblings, 0 replies; 16+ messages in thread
From: Ulf Hansson @ 2020-09-30  9:46 UTC (permalink / raw)
  To: Lorenzo Pieralisi
  Cc: Rafael J. Wysocki, Sudeep Holla, Linux PM, Rafael J . Wysocki,
	Daniel Lezcano, Lina Iyer, Lukasz Luba, Vincent Guittot,
	Stephen Boyd, Bjorn Andersson, Benjamin Gaignard, Linux ARM

On Wed, 30 Sep 2020 at 11:13, Lorenzo Pieralisi
<lorenzo.pieralisi@arm.com> wrote:
>
> On Wed, Sep 23, 2020 at 03:44:53PM +0200, Ulf Hansson wrote:
> > On Wed, 23 Sep 2020 at 10:11, Lorenzo Pieralisi
> > <lorenzo.pieralisi@arm.com> wrote:
> > >
> > > On Mon, Sep 21, 2020 at 05:49:52PM +0200, Rafael J. Wysocki wrote:
> > > > On Fri, Aug 14, 2020 at 2:37 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> > > > >
> > > > > Extend the file pattern to also include cpuidle-psci.h and
> > > > > cpuidle-psci-domain.c. Moreover, add myself as a co-maintainer,
> > > > > particularly to help with the support for PM domains.
> > > > >
> > > > > Cc: Sudeep Holla <sudeep.holla@arm.com>
> > > > > Cc: Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>
> > > > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> > > >
> > > > Any objections from the original maintainers?
> > >
> > > The PSCI driver providing support for platform coordinated idle states
> > > (that this patch is targeting AFAICS) does not require more maintainers,
> > > that support is complete and Sudeep and I will take care of refactoring
> > > and fixes.
> > >
> > > If the OSI bits in it require a specific maintainer I would prefer those
> > > bits to be moved into a specific file and maintainership added
> > > _explicitly_ for that file only.
> >
> > My main concern is that the OSI support (and some related changes for
> > genpd) is still being worked upon. The corresponding code deserves to
> > be looked after by someone. I offer my help with this.
>
> All OSI changes can go into cpuidle-psci-domain.c, you can add a
> maintainer entry for that.

Alright. Most of the things are already in there, but I will try to
move the rest as well then.

>
> > I guess we can split up the code as you suggest, but perhaps another
> > way would be to explicitly state my part of the responsibility in
> > MAINTAINERS. Along the lines of this:
> >
> > M:     Ulf Hansson <ulf.hansson@linaro.org> # OSI support / PM domains
> >
> > Would that be okay to you?
>
> No because there should be no need, as I have already said. If you need
> to change cpuidle-psci.c send patches please and we will review them.

I sent a small series "Enable s2idle when using PSCI OSI [1]" a month
ago, but haven't received any feedback. I guess moving all OSI parts
to cpuidle-psci-domain.c would help, as we wouldn't need to bother you
with these OSI specific things then.

[...]

Kind regards
Uffe

[1]
https://www.spinics.net/lists/arm-kernel/msg833933.html

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] MAINTAINERS: Update section for cpuidle-psci
@ 2020-09-30  9:46           ` Ulf Hansson
  0 siblings, 0 replies; 16+ messages in thread
From: Ulf Hansson @ 2020-09-30  9:46 UTC (permalink / raw)
  To: Lorenzo Pieralisi
  Cc: Vincent Guittot, Benjamin Gaignard, Linux PM, Stephen Boyd,
	Daniel Lezcano, Rafael J . Wysocki, Lina Iyer, Bjorn Andersson,
	Linux ARM, Sudeep Holla, Rafael J. Wysocki, Lukasz Luba

On Wed, 30 Sep 2020 at 11:13, Lorenzo Pieralisi
<lorenzo.pieralisi@arm.com> wrote:
>
> On Wed, Sep 23, 2020 at 03:44:53PM +0200, Ulf Hansson wrote:
> > On Wed, 23 Sep 2020 at 10:11, Lorenzo Pieralisi
> > <lorenzo.pieralisi@arm.com> wrote:
> > >
> > > On Mon, Sep 21, 2020 at 05:49:52PM +0200, Rafael J. Wysocki wrote:
> > > > On Fri, Aug 14, 2020 at 2:37 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> > > > >
> > > > > Extend the file pattern to also include cpuidle-psci.h and
> > > > > cpuidle-psci-domain.c. Moreover, add myself as a co-maintainer,
> > > > > particularly to help with the support for PM domains.
> > > > >
> > > > > Cc: Sudeep Holla <sudeep.holla@arm.com>
> > > > > Cc: Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>
> > > > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> > > >
> > > > Any objections from the original maintainers?
> > >
> > > The PSCI driver providing support for platform coordinated idle states
> > > (that this patch is targeting AFAICS) does not require more maintainers,
> > > that support is complete and Sudeep and I will take care of refactoring
> > > and fixes.
> > >
> > > If the OSI bits in it require a specific maintainer I would prefer those
> > > bits to be moved into a specific file and maintainership added
> > > _explicitly_ for that file only.
> >
> > My main concern is that the OSI support (and some related changes for
> > genpd) is still being worked upon. The corresponding code deserves to
> > be looked after by someone. I offer my help with this.
>
> All OSI changes can go into cpuidle-psci-domain.c, you can add a
> maintainer entry for that.

Alright. Most of the things are already in there, but I will try to
move the rest as well then.

>
> > I guess we can split up the code as you suggest, but perhaps another
> > way would be to explicitly state my part of the responsibility in
> > MAINTAINERS. Along the lines of this:
> >
> > M:     Ulf Hansson <ulf.hansson@linaro.org> # OSI support / PM domains
> >
> > Would that be okay to you?
>
> No because there should be no need, as I have already said. If you need
> to change cpuidle-psci.c send patches please and we will review them.

I sent a small series "Enable s2idle when using PSCI OSI [1]" a month
ago, but haven't received any feedback. I guess moving all OSI parts
to cpuidle-psci-domain.c would help, as we wouldn't need to bother you
with these OSI specific things then.

[...]

Kind regards
Uffe

[1]
https://www.spinics.net/lists/arm-kernel/msg833933.html

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] MAINTAINERS: Update section for cpuidle-psci
  2020-09-30  9:12         ` Lorenzo Pieralisi
@ 2020-09-30 10:16           ` Sudeep Holla
  -1 siblings, 0 replies; 16+ messages in thread
From: Sudeep Holla @ 2020-09-30 10:16 UTC (permalink / raw)
  To: Lorenzo Pieralisi
  Cc: Ulf Hansson, Rafael J. Wysocki, Linux PM, Rafael J . Wysocki,
	Daniel Lezcano, Lina Iyer, Lukasz Luba, Vincent Guittot,
	Stephen Boyd, Bjorn Andersson, Benjamin Gaignard, Sudeep Holla,
	Linux ARM

On Wed, Sep 30, 2020 at 10:12:54AM +0100, Lorenzo Pieralisi wrote:
> On Wed, Sep 23, 2020 at 03:44:53PM +0200, Ulf Hansson wrote:
> > On Wed, 23 Sep 2020 at 10:11, Lorenzo Pieralisi
> > <lorenzo.pieralisi@arm.com> wrote:
> > >
> > > On Mon, Sep 21, 2020 at 05:49:52PM +0200, Rafael J. Wysocki wrote:
> > > > On Fri, Aug 14, 2020 at 2:37 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> > > > >
> > > > > Extend the file pattern to also include cpuidle-psci.h and
> > > > > cpuidle-psci-domain.c. Moreover, add myself as a co-maintainer,
> > > > > particularly to help with the support for PM domains.
> > > > >
> > > > > Cc: Sudeep Holla <sudeep.holla@arm.com>
> > > > > Cc: Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>
> > > > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> > > >
> > > > Any objections from the original maintainers?
> > >
> > > The PSCI driver providing support for platform coordinated idle states
> > > (that this patch is targeting AFAICS) does not require more maintainers,
> > > that support is complete and Sudeep and I will take care of refactoring
> > > and fixes.
> > >
> > > If the OSI bits in it require a specific maintainer I would prefer those
> > > bits to be moved into a specific file and maintainership added
> > > _explicitly_ for that file only.
> >
> > My main concern is that the OSI support (and some related changes for
> > genpd) is still being worked upon. The corresponding code deserves to
> > be looked after by someone. I offer my help with this.
>
> All OSI changes can go into cpuidle-psci-domain.c, you can add a
> maintainer entry for that.
>
> > I guess we can split up the code as you suggest, but perhaps another
> > way would be to explicitly state my part of the responsibility in
> > MAINTAINERS. Along the lines of this:
> >
> > M:     Ulf Hansson <ulf.hansson@linaro.org> # OSI support / PM domains
> >
> > Would that be okay to you?
>
> No because there should be no need, as I have already said. If you need
> to change cpuidle-psci.c send patches please and we will review them.
>

I agree and recollect that was the main idea when we moved all the OSI
specific PM domain code to separate file.

--
Regards,
Sudeep

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] MAINTAINERS: Update section for cpuidle-psci
@ 2020-09-30 10:16           ` Sudeep Holla
  0 siblings, 0 replies; 16+ messages in thread
From: Sudeep Holla @ 2020-09-30 10:16 UTC (permalink / raw)
  To: Lorenzo Pieralisi
  Cc: Ulf Hansson, Vincent Guittot, Benjamin Gaignard, Linux PM,
	Stephen Boyd, Daniel Lezcano, Rafael J . Wysocki, Lina Iyer,
	Bjorn Andersson, Linux ARM, Sudeep Holla, Rafael J. Wysocki,
	Lukasz Luba

On Wed, Sep 30, 2020 at 10:12:54AM +0100, Lorenzo Pieralisi wrote:
> On Wed, Sep 23, 2020 at 03:44:53PM +0200, Ulf Hansson wrote:
> > On Wed, 23 Sep 2020 at 10:11, Lorenzo Pieralisi
> > <lorenzo.pieralisi@arm.com> wrote:
> > >
> > > On Mon, Sep 21, 2020 at 05:49:52PM +0200, Rafael J. Wysocki wrote:
> > > > On Fri, Aug 14, 2020 at 2:37 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> > > > >
> > > > > Extend the file pattern to also include cpuidle-psci.h and
> > > > > cpuidle-psci-domain.c. Moreover, add myself as a co-maintainer,
> > > > > particularly to help with the support for PM domains.
> > > > >
> > > > > Cc: Sudeep Holla <sudeep.holla@arm.com>
> > > > > Cc: Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>
> > > > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> > > >
> > > > Any objections from the original maintainers?
> > >
> > > The PSCI driver providing support for platform coordinated idle states
> > > (that this patch is targeting AFAICS) does not require more maintainers,
> > > that support is complete and Sudeep and I will take care of refactoring
> > > and fixes.
> > >
> > > If the OSI bits in it require a specific maintainer I would prefer those
> > > bits to be moved into a specific file and maintainership added
> > > _explicitly_ for that file only.
> >
> > My main concern is that the OSI support (and some related changes for
> > genpd) is still being worked upon. The corresponding code deserves to
> > be looked after by someone. I offer my help with this.
>
> All OSI changes can go into cpuidle-psci-domain.c, you can add a
> maintainer entry for that.
>
> > I guess we can split up the code as you suggest, but perhaps another
> > way would be to explicitly state my part of the responsibility in
> > MAINTAINERS. Along the lines of this:
> >
> > M:     Ulf Hansson <ulf.hansson@linaro.org> # OSI support / PM domains
> >
> > Would that be okay to you?
>
> No because there should be no need, as I have already said. If you need
> to change cpuidle-psci.c send patches please and we will review them.
>

I agree and recollect that was the main idea when we moved all the OSI
specific PM domain code to separate file.

--
Regards,
Sudeep

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] MAINTAINERS: Update section for cpuidle-psci
  2020-09-30  9:46           ` Ulf Hansson
@ 2020-09-30 10:18             ` Sudeep Holla
  -1 siblings, 0 replies; 16+ messages in thread
From: Sudeep Holla @ 2020-09-30 10:18 UTC (permalink / raw)
  To: Ulf Hansson
  Cc: Lorenzo Pieralisi, Rafael J. Wysocki, Linux PM,
	Rafael J . Wysocki, Daniel Lezcano, Lina Iyer, Lukasz Luba,
	Vincent Guittot, Stephen Boyd, Bjorn Andersson,
	Benjamin Gaignard, Sudeep Holla, Linux ARM

On Wed, Sep 30, 2020 at 11:46:19AM +0200, Ulf Hansson wrote:
> On Wed, 30 Sep 2020 at 11:13, Lorenzo Pieralisi
> <lorenzo.pieralisi@arm.com> wrote:
> >
> > On Wed, Sep 23, 2020 at 03:44:53PM +0200, Ulf Hansson wrote:
> > > On Wed, 23 Sep 2020 at 10:11, Lorenzo Pieralisi
> > > <lorenzo.pieralisi@arm.com> wrote:
> > > >
> > > > On Mon, Sep 21, 2020 at 05:49:52PM +0200, Rafael J. Wysocki wrote:
> > > > > On Fri, Aug 14, 2020 at 2:37 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> > > > > >
> > > > > > Extend the file pattern to also include cpuidle-psci.h and
> > > > > > cpuidle-psci-domain.c. Moreover, add myself as a co-maintainer,
> > > > > > particularly to help with the support for PM domains.
> > > > > >
> > > > > > Cc: Sudeep Holla <sudeep.holla@arm.com>
> > > > > > Cc: Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>
> > > > > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> > > > >
> > > > > Any objections from the original maintainers?
> > > >
> > > > The PSCI driver providing support for platform coordinated idle states
> > > > (that this patch is targeting AFAICS) does not require more maintainers,
> > > > that support is complete and Sudeep and I will take care of refactoring
> > > > and fixes.
> > > >
> > > > If the OSI bits in it require a specific maintainer I would prefer those
> > > > bits to be moved into a specific file and maintainership added
> > > > _explicitly_ for that file only.
> > >
> > > My main concern is that the OSI support (and some related changes for
> > > genpd) is still being worked upon. The corresponding code deserves to
> > > be looked after by someone. I offer my help with this.
> >
> > All OSI changes can go into cpuidle-psci-domain.c, you can add a
> > maintainer entry for that.
>
> Alright. Most of the things are already in there, but I will try to
> move the rest as well then.
>
> >
> > > I guess we can split up the code as you suggest, but perhaps another
> > > way would be to explicitly state my part of the responsibility in
> > > MAINTAINERS. Along the lines of this:
> > >
> > > M:     Ulf Hansson <ulf.hansson@linaro.org> # OSI support / PM domains
> > >
> > > Would that be okay to you?
> >
> > No because there should be no need, as I have already said. If you need
> > to change cpuidle-psci.c send patches please and we will review them.
>
> I sent a small series "Enable s2idle when using PSCI OSI [1]" a month
> ago, but haven't received any feedback. I guess moving all OSI parts
> to cpuidle-psci-domain.c would help, as we wouldn't need to bother you
> with these OSI specific things then.
>

As I mentioned in one of the thread, I was confused with multiple series
at the same time and I believe there were S2I/S2R related patches from
you and one more person. I was confused and about to go on vacation.
I will take a look at it.

--
Regards,
Sudeep

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] MAINTAINERS: Update section for cpuidle-psci
@ 2020-09-30 10:18             ` Sudeep Holla
  0 siblings, 0 replies; 16+ messages in thread
From: Sudeep Holla @ 2020-09-30 10:18 UTC (permalink / raw)
  To: Ulf Hansson
  Cc: Lorenzo Pieralisi, Vincent Guittot, Benjamin Gaignard, Linux PM,
	Stephen Boyd, Daniel Lezcano, Rafael J . Wysocki, Lina Iyer,
	Bjorn Andersson, Linux ARM, Sudeep Holla, Rafael J. Wysocki,
	Lukasz Luba

On Wed, Sep 30, 2020 at 11:46:19AM +0200, Ulf Hansson wrote:
> On Wed, 30 Sep 2020 at 11:13, Lorenzo Pieralisi
> <lorenzo.pieralisi@arm.com> wrote:
> >
> > On Wed, Sep 23, 2020 at 03:44:53PM +0200, Ulf Hansson wrote:
> > > On Wed, 23 Sep 2020 at 10:11, Lorenzo Pieralisi
> > > <lorenzo.pieralisi@arm.com> wrote:
> > > >
> > > > On Mon, Sep 21, 2020 at 05:49:52PM +0200, Rafael J. Wysocki wrote:
> > > > > On Fri, Aug 14, 2020 at 2:37 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> > > > > >
> > > > > > Extend the file pattern to also include cpuidle-psci.h and
> > > > > > cpuidle-psci-domain.c. Moreover, add myself as a co-maintainer,
> > > > > > particularly to help with the support for PM domains.
> > > > > >
> > > > > > Cc: Sudeep Holla <sudeep.holla@arm.com>
> > > > > > Cc: Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>
> > > > > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> > > > >
> > > > > Any objections from the original maintainers?
> > > >
> > > > The PSCI driver providing support for platform coordinated idle states
> > > > (that this patch is targeting AFAICS) does not require more maintainers,
> > > > that support is complete and Sudeep and I will take care of refactoring
> > > > and fixes.
> > > >
> > > > If the OSI bits in it require a specific maintainer I would prefer those
> > > > bits to be moved into a specific file and maintainership added
> > > > _explicitly_ for that file only.
> > >
> > > My main concern is that the OSI support (and some related changes for
> > > genpd) is still being worked upon. The corresponding code deserves to
> > > be looked after by someone. I offer my help with this.
> >
> > All OSI changes can go into cpuidle-psci-domain.c, you can add a
> > maintainer entry for that.
>
> Alright. Most of the things are already in there, but I will try to
> move the rest as well then.
>
> >
> > > I guess we can split up the code as you suggest, but perhaps another
> > > way would be to explicitly state my part of the responsibility in
> > > MAINTAINERS. Along the lines of this:
> > >
> > > M:     Ulf Hansson <ulf.hansson@linaro.org> # OSI support / PM domains
> > >
> > > Would that be okay to you?
> >
> > No because there should be no need, as I have already said. If you need
> > to change cpuidle-psci.c send patches please and we will review them.
>
> I sent a small series "Enable s2idle when using PSCI OSI [1]" a month
> ago, but haven't received any feedback. I guess moving all OSI parts
> to cpuidle-psci-domain.c would help, as we wouldn't need to bother you
> with these OSI specific things then.
>

As I mentioned in one of the thread, I was confused with multiple series
at the same time and I believe there were S2I/S2R related patches from
you and one more person. I was confused and about to go on vacation.
I will take a look at it.

--
Regards,
Sudeep

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2020-09-30 10:20 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-14 12:37 [PATCH] MAINTAINERS: Update section for cpuidle-psci Ulf Hansson
2020-08-14 12:37 ` Ulf Hansson
2020-09-21 15:49 ` Rafael J. Wysocki
2020-09-21 15:49   ` Rafael J. Wysocki
2020-09-23  8:11   ` Lorenzo Pieralisi
2020-09-23  8:11     ` Lorenzo Pieralisi
2020-09-23 13:44     ` Ulf Hansson
2020-09-23 13:44       ` Ulf Hansson
2020-09-30  9:12       ` Lorenzo Pieralisi
2020-09-30  9:12         ` Lorenzo Pieralisi
2020-09-30  9:46         ` Ulf Hansson
2020-09-30  9:46           ` Ulf Hansson
2020-09-30 10:18           ` Sudeep Holla
2020-09-30 10:18             ` Sudeep Holla
2020-09-30 10:16         ` Sudeep Holla
2020-09-30 10:16           ` Sudeep Holla

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.