From: Quentin Perret <qperret@google.com>
To: Ionela Voinescu <ionela.voinescu@arm.com>
Cc: mingo@redhat.com, peterz@infradead.org,
vincent.guittot@linaro.org, catalin.marinas@arm.com,
will@kernel.org, rjw@rjwysocki.net, viresh.kumar@linaro.org,
dietmar.eggemann@arm.com, valentin.schneider@arm.com,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: rebuild sched domains on invariance status changes
Date: Fri, 25 Sep 2020 14:59:00 +0100 [thread overview]
Message-ID: <20200925135900.GA11648@google.com> (raw)
In-Reply-To: <20200924161002.GC17927@arm.com>
Hey Ionela,
On Thursday 24 Sep 2020 at 17:10:02 (+0100), Ionela Voinescu wrote:
> I'm not sure what is a good way of fixing this.. I could add more info
> to the warning to suggest it might be temporary ("Disabling EAS:
> frequency-invariant load tracking currently not supported"). For further
> debugging there are the additional prints guarded by sched_debug().
>
> I'll look over the code some more to see if other ideas pop out. Any
> suggestions are appreciated.
Right, I'm not seeing anything perfect here, but I think I'd be
personally happy with this message being entirely guarded by
sched_debug(), like we do for asym CPU capacities for instance.
It's not easy to see if EAS has started at all w/o sched debug anyway,
so I expect folks who need it to enable the debug stuff during
bring-up. With a descriptive enough warn message, that should be just
fine. But that's my 2p, so I'm happy to hear if others disagree.
Thanks,
Quentin
WARNING: multiple messages have this Message-ID (diff)
From: Quentin Perret <qperret@google.com>
To: Ionela Voinescu <ionela.voinescu@arm.com>
Cc: vincent.guittot@linaro.org, linux-pm@vger.kernel.org,
peterz@infradead.org, catalin.marinas@arm.com, rjw@rjwysocki.net,
linux-kernel@vger.kernel.org, valentin.schneider@arm.com,
mingo@redhat.com, viresh.kumar@linaro.org, will@kernel.org,
dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] arm64: rebuild sched domains on invariance status changes
Date: Fri, 25 Sep 2020 14:59:00 +0100 [thread overview]
Message-ID: <20200925135900.GA11648@google.com> (raw)
In-Reply-To: <20200924161002.GC17927@arm.com>
Hey Ionela,
On Thursday 24 Sep 2020 at 17:10:02 (+0100), Ionela Voinescu wrote:
> I'm not sure what is a good way of fixing this.. I could add more info
> to the warning to suggest it might be temporary ("Disabling EAS:
> frequency-invariant load tracking currently not supported"). For further
> debugging there are the additional prints guarded by sched_debug().
>
> I'll look over the code some more to see if other ideas pop out. Any
> suggestions are appreciated.
Right, I'm not seeing anything perfect here, but I think I'd be
personally happy with this message being entirely guarded by
sched_debug(), like we do for asym CPU capacities for instance.
It's not easy to see if EAS has started at all w/o sched debug anyway,
so I expect folks who need it to enable the debug stuff during
bring-up. With a descriptive enough warn message, that should be just
fine. But that's my 2p, so I'm happy to hear if others disagree.
Thanks,
Quentin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-25 13:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 12:39 [PATCH 0/3] condition EAS enablement on FI support Ionela Voinescu
2020-09-24 12:39 ` Ionela Voinescu
2020-09-24 12:39 ` [PATCH 1/3] sched/topology,schedutil: wrap sched domains rebuild Ionela Voinescu
2020-09-24 12:39 ` Ionela Voinescu
2020-09-24 13:34 ` Quentin Perret
2020-09-24 13:34 ` Quentin Perret
2020-09-24 16:07 ` Ionela Voinescu
2020-09-24 16:07 ` Ionela Voinescu
2020-09-24 12:39 ` [PATCH 2/3] sched/topology: condition EAS enablement on FIE support Ionela Voinescu
2020-09-24 12:39 ` Ionela Voinescu
2020-09-24 12:39 ` [PATCH 3/3] arm64: rebuild sched domains on invariance status changes Ionela Voinescu
2020-09-24 12:39 ` Ionela Voinescu
2020-09-24 13:39 ` Quentin Perret
2020-09-24 13:39 ` Quentin Perret
2020-09-24 16:10 ` Ionela Voinescu
2020-09-24 16:10 ` Ionela Voinescu
2020-09-25 13:59 ` Quentin Perret [this message]
2020-09-25 13:59 ` Quentin Perret
2020-09-28 11:55 ` Dietmar Eggemann
2020-09-28 11:55 ` Dietmar Eggemann
2020-09-28 14:23 ` Ionela Voinescu
2020-09-28 14:23 ` Ionela Voinescu
2020-09-24 13:37 ` [PATCH 0/3] condition EAS enablement on FI support Quentin Perret
2020-09-24 13:37 ` Quentin Perret
2020-09-24 16:08 ` Ionela Voinescu
2020-09-24 16:08 ` Ionela Voinescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200925135900.GA11648@google.com \
--to=qperret@google.com \
--cc=catalin.marinas@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=ionela.voinescu@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.