* [PATCH] f2fs: compress: fix to disallow enabling compress on non-empty file
@ 2020-09-18 3:03 ` Chao Yu
0 siblings, 0 replies; 12+ messages in thread
From: Chao Yu @ 2020-09-18 3:03 UTC (permalink / raw)
To: jaegeuk; +Cc: linux-f2fs-devel, linux-kernel, chao, Chao Yu
Compressed inode and normal inode has different layout, so we should
disallow enabling compress on non-empty file to avoid race condition
during inode .i_addr array parsing and updating.
Signed-off-by: Chao Yu <yuchao0@huawei.com>
---
fs/f2fs/file.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 58e464cc15f0..139fdfc1dc55 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -1821,6 +1821,8 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask)
if (iflags & F2FS_COMPR_FL) {
if (!f2fs_may_compress(inode))
return -EINVAL;
+ if (inode->i_size)
+ return -EINVAL;
set_compress_context(inode);
}
--
2.26.2
^ permalink raw reply related [flat|nested] 12+ messages in thread* [f2fs-dev] [PATCH] f2fs: compress: fix to disallow enabling compress on non-empty file
@ 2020-09-18 3:03 ` Chao Yu
0 siblings, 0 replies; 12+ messages in thread
From: Chao Yu @ 2020-09-18 3:03 UTC (permalink / raw)
To: jaegeuk; +Cc: linux-kernel, linux-f2fs-devel
Compressed inode and normal inode has different layout, so we should
disallow enabling compress on non-empty file to avoid race condition
during inode .i_addr array parsing and updating.
Signed-off-by: Chao Yu <yuchao0@huawei.com>
---
fs/f2fs/file.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 58e464cc15f0..139fdfc1dc55 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -1821,6 +1821,8 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask)
if (iflags & F2FS_COMPR_FL) {
if (!f2fs_may_compress(inode))
return -EINVAL;
+ if (inode->i_size)
+ return -EINVAL;
set_compress_context(inode);
}
--
2.26.2
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH] f2fs: compress: fix to disallow enabling compress on non-empty file
2020-09-18 3:03 ` [f2fs-dev] " Chao Yu
@ 2020-09-24 20:03 ` Jaegeuk Kim
-1 siblings, 0 replies; 12+ messages in thread
From: Jaegeuk Kim @ 2020-09-24 20:03 UTC (permalink / raw)
To: Chao Yu; +Cc: linux-f2fs-devel, linux-kernel, chao
On 09/18, Chao Yu wrote:
> Compressed inode and normal inode has different layout, so we should
> disallow enabling compress on non-empty file to avoid race condition
> during inode .i_addr array parsing and updating.
>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
> fs/f2fs/file.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index 58e464cc15f0..139fdfc1dc55 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -1821,6 +1821,8 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask)
> if (iflags & F2FS_COMPR_FL) {
> if (!f2fs_may_compress(inode))
> return -EINVAL;
> + if (inode->i_size)
Changed like this.
+ if (S_ISREG(inode->i_mode) && inode->i_size)
> + return -EINVAL;
>
> set_compress_context(inode);
> }
> --
> 2.26.2
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [f2fs-dev] [PATCH] f2fs: compress: fix to disallow enabling compress on non-empty file
@ 2020-09-24 20:03 ` Jaegeuk Kim
0 siblings, 0 replies; 12+ messages in thread
From: Jaegeuk Kim @ 2020-09-24 20:03 UTC (permalink / raw)
To: Chao Yu; +Cc: linux-kernel, linux-f2fs-devel
On 09/18, Chao Yu wrote:
> Compressed inode and normal inode has different layout, so we should
> disallow enabling compress on non-empty file to avoid race condition
> during inode .i_addr array parsing and updating.
>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
> fs/f2fs/file.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index 58e464cc15f0..139fdfc1dc55 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -1821,6 +1821,8 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask)
> if (iflags & F2FS_COMPR_FL) {
> if (!f2fs_may_compress(inode))
> return -EINVAL;
> + if (inode->i_size)
Changed like this.
+ if (S_ISREG(inode->i_mode) && inode->i_size)
> + return -EINVAL;
>
> set_compress_context(inode);
> }
> --
> 2.26.2
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] f2fs: compress: fix to disallow enabling compress on non-empty file
2020-09-24 20:03 ` [f2fs-dev] " Jaegeuk Kim
@ 2020-09-25 0:57 ` Chao Yu
-1 siblings, 0 replies; 12+ messages in thread
From: Chao Yu @ 2020-09-25 0:57 UTC (permalink / raw)
To: Jaegeuk Kim; +Cc: linux-f2fs-devel, linux-kernel, chao
On 2020/9/25 4:03, Jaegeuk Kim wrote:
> On 09/18, Chao Yu wrote:
>> Compressed inode and normal inode has different layout, so we should
>> disallow enabling compress on non-empty file to avoid race condition
>> during inode .i_addr array parsing and updating.
>>
>> Signed-off-by: Chao Yu <yuchao0@huawei.com>
>> ---
>> fs/f2fs/file.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
>> index 58e464cc15f0..139fdfc1dc55 100644
>> --- a/fs/f2fs/file.c
>> +++ b/fs/f2fs/file.c
>> @@ -1821,6 +1821,8 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask)
>> if (iflags & F2FS_COMPR_FL) {
>> if (!f2fs_may_compress(inode))
>> return -EINVAL;
>> + if (inode->i_size)
>
> Changed like this.
>
> + if (S_ISREG(inode->i_mode) && inode->i_size)
My bad, thanks for fixing this. :)
Thanks,
>
>
>> + return -EINVAL;
>>
>> set_compress_context(inode);
>> }
>> --
>> 2.26.2
> .
>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [f2fs-dev] [PATCH] f2fs: compress: fix to disallow enabling compress on non-empty file
@ 2020-09-25 0:57 ` Chao Yu
0 siblings, 0 replies; 12+ messages in thread
From: Chao Yu @ 2020-09-25 0:57 UTC (permalink / raw)
To: Jaegeuk Kim; +Cc: linux-kernel, linux-f2fs-devel
On 2020/9/25 4:03, Jaegeuk Kim wrote:
> On 09/18, Chao Yu wrote:
>> Compressed inode and normal inode has different layout, so we should
>> disallow enabling compress on non-empty file to avoid race condition
>> during inode .i_addr array parsing and updating.
>>
>> Signed-off-by: Chao Yu <yuchao0@huawei.com>
>> ---
>> fs/f2fs/file.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
>> index 58e464cc15f0..139fdfc1dc55 100644
>> --- a/fs/f2fs/file.c
>> +++ b/fs/f2fs/file.c
>> @@ -1821,6 +1821,8 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask)
>> if (iflags & F2FS_COMPR_FL) {
>> if (!f2fs_may_compress(inode))
>> return -EINVAL;
>> + if (inode->i_size)
>
> Changed like this.
>
> + if (S_ISREG(inode->i_mode) && inode->i_size)
My bad, thanks for fixing this. :)
Thanks,
>
>
>> + return -EINVAL;
>>
>> set_compress_context(inode);
>> }
>> --
>> 2.26.2
> .
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [f2fs-dev] [PATCH] f2fs: compress: fix to disallow enabling compress on non-empty file
2020-09-25 0:57 ` [f2fs-dev] " Chao Yu
(?)
@ 2020-09-25 9:10 ` Chao Yu
2020-09-25 17:07 ` Jaegeuk Kim
-1 siblings, 1 reply; 12+ messages in thread
From: Chao Yu @ 2020-09-25 9:10 UTC (permalink / raw)
To: Jaegeuk Kim; +Cc: linux-f2fs-devel
Jaegeuk,
I noticed that in dev branch there are several patches which have not been
sent to mailing list, could you please send them out?
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: compress: fix to disallow enabling compress on non-empty file
2020-09-25 9:10 ` Chao Yu
@ 2020-09-25 17:07 ` Jaegeuk Kim
2020-09-25 23:16 ` Chao Yu
0 siblings, 1 reply; 12+ messages in thread
From: Jaegeuk Kim @ 2020-09-25 17:07 UTC (permalink / raw)
To: Chao Yu; +Cc: linux-f2fs-devel
On 09/25, Chao Yu wrote:
> Jaegeuk,
>
> I noticed that in dev branch there are several patches which have not been
> sent to mailing list, could you please send them out?
Chao, which patches?
>
> Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: compress: fix to disallow enabling compress on non-empty file
2020-09-25 17:07 ` Jaegeuk Kim
@ 2020-09-25 23:16 ` Chao Yu
2020-09-25 23:23 ` Jaegeuk Kim
0 siblings, 1 reply; 12+ messages in thread
From: Chao Yu @ 2020-09-25 23:16 UTC (permalink / raw)
To: Jaegeuk Kim, Chao Yu; +Cc: linux-f2fs-devel
On 2020-9-26 1:07, Jaegeuk Kim wrote:
> On 09/25, Chao Yu wrote:
>> Jaegeuk,
>>
>> I noticed that in dev branch there are several patches which have not been
>> sent to mailing list, could you please send them out?
>
> Chao, which patches?
Jaegeuk, they are
f2fs: point man pages for some f2fs utils
f2fs: fix slab leak of rpages pointer
Thanks,
>
>>
>> Thanks,
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: compress: fix to disallow enabling compress on non-empty file
2020-09-25 23:16 ` Chao Yu
@ 2020-09-25 23:23 ` Jaegeuk Kim
2020-09-25 23:26 ` Jaegeuk Kim
0 siblings, 1 reply; 12+ messages in thread
From: Jaegeuk Kim @ 2020-09-25 23:23 UTC (permalink / raw)
To: Chao Yu; +Cc: linux-f2fs-devel
On 09/26, Chao Yu wrote:
> On 2020-9-26 1:07, Jaegeuk Kim wrote:
> > On 09/25, Chao Yu wrote:
> > > Jaegeuk,
> > >
> > > I noticed that in dev branch there are several patches which have not been
> > > sent to mailing list, could you please send them out?
> >
> > Chao, which patches?
>
> Jaegeuk, they are
>
> f2fs: point man pages for some f2fs utils
Ah, just sent.
> f2fs: fix slab leak of rpages pointer
I did before?
>
> Thanks,
>
> >
> > >
> > > Thanks,
> >
> >
> > _______________________________________________
> > Linux-f2fs-devel mailing list
> > Linux-f2fs-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
> >
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: compress: fix to disallow enabling compress on non-empty file
2020-09-25 23:23 ` Jaegeuk Kim
@ 2020-09-25 23:26 ` Jaegeuk Kim
2020-09-25 23:51 ` Chao Yu
0 siblings, 1 reply; 12+ messages in thread
From: Jaegeuk Kim @ 2020-09-25 23:26 UTC (permalink / raw)
To: Chao Yu; +Cc: linux-f2fs-devel
On 09/25, Jaegeuk Kim wrote:
> On 09/26, Chao Yu wrote:
> > On 2020-9-26 1:07, Jaegeuk Kim wrote:
> > > On 09/25, Chao Yu wrote:
> > > > Jaegeuk,
> > > >
> > > > I noticed that in dev branch there are several patches which have not been
> > > > sent to mailing list, could you please send them out?
> > >
> > > Chao, which patches?
> >
> > Jaegeuk, they are
> >
> > f2fs: point man pages for some f2fs utils
>
> Ah, just sent.
>
> > f2fs: fix slab leak of rpages pointer
>
> I did before?
I missed to add f2fs mailing list. Resent them.
>
> >
> > Thanks,
> >
> > >
> > > >
> > > > Thanks,
> > >
> > >
> > > _______________________________________________
> > > Linux-f2fs-devel mailing list
> > > Linux-f2fs-devel@lists.sourceforge.net
> > > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
> > >
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: compress: fix to disallow enabling compress on non-empty file
2020-09-25 23:26 ` Jaegeuk Kim
@ 2020-09-25 23:51 ` Chao Yu
0 siblings, 0 replies; 12+ messages in thread
From: Chao Yu @ 2020-09-25 23:51 UTC (permalink / raw)
To: Jaegeuk Kim; +Cc: linux-f2fs-devel
On 2020-9-26 7:26, Jaegeuk Kim wrote:
> On 09/25, Jaegeuk Kim wrote:
>> On 09/26, Chao Yu wrote:
>>> On 2020-9-26 1:07, Jaegeuk Kim wrote:
>>>> On 09/25, Chao Yu wrote:
>>>>> Jaegeuk,
>>>>>
>>>>> I noticed that in dev branch there are several patches which have not been
>>>>> sent to mailing list, could you please send them out?
>>>>
>>>> Chao, which patches?
>>>
>>> Jaegeuk, they are
>>>
>>> f2fs: point man pages for some f2fs utils
>>
>> Ah, just sent.
>>
>>> f2fs: fix slab leak of rpages pointer
>>
>> I did before?
>
> I missed to add f2fs mailing list. Resent them.
Jaegeuk, thanks, :)
Thanks,
>
>>
>>>
>>> Thanks,
>>>
>>>>
>>>>>
>>>>> Thanks,
>>>>
>>>>
>>>> _______________________________________________
>>>> Linux-f2fs-devel mailing list
>>>> Linux-f2fs-devel@lists.sourceforge.net
>>>> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
>>>>
>>
>>
>> _______________________________________________
>> Linux-f2fs-devel mailing list
>> Linux-f2fs-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2020-09-25 23:52 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-18 3:03 [PATCH] f2fs: compress: fix to disallow enabling compress on non-empty file Chao Yu
2020-09-18 3:03 ` [f2fs-dev] " Chao Yu
2020-09-24 20:03 ` Jaegeuk Kim
2020-09-24 20:03 ` [f2fs-dev] " Jaegeuk Kim
2020-09-25 0:57 ` Chao Yu
2020-09-25 0:57 ` [f2fs-dev] " Chao Yu
2020-09-25 9:10 ` Chao Yu
2020-09-25 17:07 ` Jaegeuk Kim
2020-09-25 23:16 ` Chao Yu
2020-09-25 23:23 ` Jaegeuk Kim
2020-09-25 23:26 ` Jaegeuk Kim
2020-09-25 23:51 ` Chao Yu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.