* [PATCH] qcow2: Use L1E_SIZE in qcow2_write_l1_entry()
@ 2020-09-28 16:23 Alberto Garcia
2020-09-29 16:08 ` Eric Blake
2020-10-02 7:52 ` Kevin Wolf
0 siblings, 2 replies; 3+ messages in thread
From: Alberto Garcia @ 2020-09-28 16:23 UTC (permalink / raw)
To: qemu-devel; +Cc: Kevin Wolf, Alberto Garcia, qemu-block, Max Reitz
We overlooked these in 02b1ecfa100e7ecc2306560cd27a4a2622bfeb04
Signed-off-by: Alberto Garcia <berto@igalia.com>
---
block/qcow2-cluster.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index 9acc6ce4ae..aa87d3e99b 100644
--- a/block/qcow2-cluster.c
+++ b/block/qcow2-cluster.c
@@ -240,14 +240,14 @@ int qcow2_write_l1_entry(BlockDriverState *bs, int l1_index)
}
ret = qcow2_pre_write_overlap_check(bs, QCOW2_OL_ACTIVE_L1,
- s->l1_table_offset + 8 * l1_start_index, bufsize, false);
+ s->l1_table_offset + L1E_SIZE * l1_start_index, bufsize, false);
if (ret < 0) {
return ret;
}
BLKDBG_EVENT(bs->file, BLKDBG_L1_UPDATE);
ret = bdrv_pwrite_sync(bs->file,
- s->l1_table_offset + 8 * l1_start_index,
+ s->l1_table_offset + L1E_SIZE * l1_start_index,
buf, bufsize);
if (ret < 0) {
return ret;
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] qcow2: Use L1E_SIZE in qcow2_write_l1_entry()
2020-09-28 16:23 [PATCH] qcow2: Use L1E_SIZE in qcow2_write_l1_entry() Alberto Garcia
@ 2020-09-29 16:08 ` Eric Blake
2020-10-02 7:52 ` Kevin Wolf
1 sibling, 0 replies; 3+ messages in thread
From: Eric Blake @ 2020-09-29 16:08 UTC (permalink / raw)
To: Alberto Garcia, qemu-devel; +Cc: Kevin Wolf, qemu-block, Max Reitz
[-- Attachment #1.1: Type: text/plain, Size: 1334 bytes --]
On 9/28/20 11:23 AM, Alberto Garcia wrote:
> We overlooked these in 02b1ecfa100e7ecc2306560cd27a4a2622bfeb04
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
> block/qcow2-cluster.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
> diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
> index 9acc6ce4ae..aa87d3e99b 100644
> --- a/block/qcow2-cluster.c
> +++ b/block/qcow2-cluster.c
> @@ -240,14 +240,14 @@ int qcow2_write_l1_entry(BlockDriverState *bs, int l1_index)
> }
>
> ret = qcow2_pre_write_overlap_check(bs, QCOW2_OL_ACTIVE_L1,
> - s->l1_table_offset + 8 * l1_start_index, bufsize, false);
> + s->l1_table_offset + L1E_SIZE * l1_start_index, bufsize, false);
> if (ret < 0) {
> return ret;
> }
>
> BLKDBG_EVENT(bs->file, BLKDBG_L1_UPDATE);
> ret = bdrv_pwrite_sync(bs->file,
> - s->l1_table_offset + 8 * l1_start_index,
> + s->l1_table_offset + L1E_SIZE * l1_start_index,
> buf, bufsize);
> if (ret < 0) {
> return ret;
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] qcow2: Use L1E_SIZE in qcow2_write_l1_entry()
2020-09-28 16:23 [PATCH] qcow2: Use L1E_SIZE in qcow2_write_l1_entry() Alberto Garcia
2020-09-29 16:08 ` Eric Blake
@ 2020-10-02 7:52 ` Kevin Wolf
1 sibling, 0 replies; 3+ messages in thread
From: Kevin Wolf @ 2020-10-02 7:52 UTC (permalink / raw)
To: Alberto Garcia; +Cc: qemu-devel, qemu-block, Max Reitz
Am 28.09.2020 um 18:23 hat Alberto Garcia geschrieben:
> We overlooked these in 02b1ecfa100e7ecc2306560cd27a4a2622bfeb04
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-02 7:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-28 16:23 [PATCH] qcow2: Use L1E_SIZE in qcow2_write_l1_entry() Alberto Garcia
2020-09-29 16:08 ` Eric Blake
2020-10-02 7:52 ` Kevin Wolf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.