All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: "Surendrakumar Upadhyay,
	TejaskumarX"  <tejaskumarx.surendrakumar.upadhyay@intel.com>,
	"Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
	"airlied@linux.ie" <airlied@linux.ie>,
	"daniel@ffwll.ch" <daniel@ffwll.ch>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Ausmus, James" <james.ausmus@intel.com>,
	"Roper, Matthew D" <matthew.d.roper@intel.com>,
	"Souza, Jose" <jose.souza@intel.com>,
	"ville.syrjala@linux.intel.com" <ville.syrjala@linux.intel.com>,
	"Pandey, Hariom" <hariom.pandey@intel.com>
Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2
Date: Mon, 28 Sep 2020 16:07:39 -0700	[thread overview]
Message-ID: <20200928230739.vpj22bwebqhtehuk@ldmartin-desk1> (raw)
In-Reply-To: <871rilq0um.fsf@intel.com>

On Mon, Sep 28, 2020 at 08:15:29PM +0300, Jani Nikula wrote:
>On Mon, 28 Sep 2020, "Surendrakumar Upadhyay, TejaskumarX"	<tejaskumarx.surendrakumar.upadhyay@intel.com> wrote:
>> This is a good example of a potential trap that having
>> IS_ELKHARTLAKE() cover both ELK and JSP creates. An unsuspecting coder
>> might change the if ladder to have IS_ELKHARTLAKE() first, and the
>> subsequent IS_JASPERLAKE() branch would never be taken.
>>
>> BR,
>> Jani.
>>
>> Tejas : In that case I will put attention note in comment about
>> platform checks such that ladder distrubance can be avoided. What you
>> suggest?

>The solution is to make IS_ELKHARTLAKE() mean ELK and only ELK.

Since we are talking about the TLA for JSL in the other patch, for
elkhartlake it is EHL, not ELK. ELK is something else, but I'm not sure
what:

$ git grep -w ELK -- drivers/gpu/drm/
drivers/gpu/drm/i915/gem/i915_gem_stolen.c:             IS_GM45(i915) ? "CTG" : "ELK", reg_val);
drivers/gpu/drm/i915/gem/i915_gem_stolen.c:      * Whether ILK really reuses the ELK register for this is unclear.
drivers/gpu/drm/i915/intel_pm.c:         * Not 100% sure which way ELK should go here as the
drivers/gpu/drm/i915/intel_pm.c:         * assume ELK doesn't need this.

Lucas De Marchi

>
>BR,
>Jani.
>
>
>-- 
>Jani Nikula, Intel Open Source Graphics Center

WARNING: multiple messages have this Message-ID (diff)
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: "Pandey, Hariom" <hariom.pandey@intel.com>,
	"Ausmus, James" <james.ausmus@intel.com>,
	"airlied@linux.ie" <airlied@linux.ie>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"Souza, Jose" <jose.souza@intel.com>,
	"Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
	"Surendrakumar Upadhyay,
	TejaskumarX" <tejaskumarx.surendrakumar.upadhyay@intel.com>
Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2
Date: Mon, 28 Sep 2020 16:07:39 -0700	[thread overview]
Message-ID: <20200928230739.vpj22bwebqhtehuk@ldmartin-desk1> (raw)
In-Reply-To: <871rilq0um.fsf@intel.com>

On Mon, Sep 28, 2020 at 08:15:29PM +0300, Jani Nikula wrote:
>On Mon, 28 Sep 2020, "Surendrakumar Upadhyay, TejaskumarX"	<tejaskumarx.surendrakumar.upadhyay@intel.com> wrote:
>> This is a good example of a potential trap that having
>> IS_ELKHARTLAKE() cover both ELK and JSP creates. An unsuspecting coder
>> might change the if ladder to have IS_ELKHARTLAKE() first, and the
>> subsequent IS_JASPERLAKE() branch would never be taken.
>>
>> BR,
>> Jani.
>>
>> Tejas : In that case I will put attention note in comment about
>> platform checks such that ladder distrubance can be avoided. What you
>> suggest?

>The solution is to make IS_ELKHARTLAKE() mean ELK and only ELK.

Since we are talking about the TLA for JSL in the other patch, for
elkhartlake it is EHL, not ELK. ELK is something else, but I'm not sure
what:

$ git grep -w ELK -- drivers/gpu/drm/
drivers/gpu/drm/i915/gem/i915_gem_stolen.c:             IS_GM45(i915) ? "CTG" : "ELK", reg_val);
drivers/gpu/drm/i915/gem/i915_gem_stolen.c:      * Whether ILK really reuses the ELK register for this is unclear.
drivers/gpu/drm/i915/intel_pm.c:         * Not 100% sure which way ELK should go here as the
drivers/gpu/drm/i915/intel_pm.c:         * assume ELK doesn't need this.

Lucas De Marchi

>
>BR,
>Jani.
>
>
>-- 
>Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: "Pandey, Hariom" <hariom.pandey@intel.com>,
	"airlied@linux.ie" <airlied@linux.ie>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2
Date: Mon, 28 Sep 2020 16:07:39 -0700	[thread overview]
Message-ID: <20200928230739.vpj22bwebqhtehuk@ldmartin-desk1> (raw)
In-Reply-To: <871rilq0um.fsf@intel.com>

On Mon, Sep 28, 2020 at 08:15:29PM +0300, Jani Nikula wrote:
>On Mon, 28 Sep 2020, "Surendrakumar Upadhyay, TejaskumarX"	<tejaskumarx.surendrakumar.upadhyay@intel.com> wrote:
>> This is a good example of a potential trap that having
>> IS_ELKHARTLAKE() cover both ELK and JSP creates. An unsuspecting coder
>> might change the if ladder to have IS_ELKHARTLAKE() first, and the
>> subsequent IS_JASPERLAKE() branch would never be taken.
>>
>> BR,
>> Jani.
>>
>> Tejas : In that case I will put attention note in comment about
>> platform checks such that ladder distrubance can be avoided. What you
>> suggest?

>The solution is to make IS_ELKHARTLAKE() mean ELK and only ELK.

Since we are talking about the TLA for JSL in the other patch, for
elkhartlake it is EHL, not ELK. ELK is something else, but I'm not sure
what:

$ git grep -w ELK -- drivers/gpu/drm/
drivers/gpu/drm/i915/gem/i915_gem_stolen.c:             IS_GM45(i915) ? "CTG" : "ELK", reg_val);
drivers/gpu/drm/i915/gem/i915_gem_stolen.c:      * Whether ILK really reuses the ELK register for this is unclear.
drivers/gpu/drm/i915/intel_pm.c:         * Not 100% sure which way ELK should go here as the
drivers/gpu/drm/i915/intel_pm.c:         * assume ELK doesn't need this.

Lucas De Marchi

>
>BR,
>Jani.
>
>
>-- 
>Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2020-09-28 23:15 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-28  8:09 [PATCH 0/2] drm/i915/jsl: Update JasperLake Voltage swing table Tejas Upadhyay
2020-09-28  8:09 ` [Intel-gfx] " Tejas Upadhyay
2020-09-28  8:09 ` Tejas Upadhyay
2020-09-28  8:09 ` [PATCH 1/2] drm/i915/jsl: Split EHL/JSL platform info and PCI ids Tejas Upadhyay
2020-09-28  8:09   ` [Intel-gfx] " Tejas Upadhyay
2020-09-28  8:09   ` Tejas Upadhyay
2020-09-28 13:37   ` Jani Nikula
2020-09-28 13:37     ` [Intel-gfx] " Jani Nikula
2020-09-28 13:37     ` Jani Nikula
2020-09-28 16:31     ` Surendrakumar Upadhyay, TejaskumarX
2020-09-28 16:31       ` [Intel-gfx] " Surendrakumar Upadhyay, TejaskumarX
2020-09-28 17:14       ` Jani Nikula
2020-09-28 17:14         ` [Intel-gfx] " Jani Nikula
2020-09-28 17:14         ` Jani Nikula
2020-09-28 17:24         ` Matt Roper
2020-09-28 17:24           ` [Intel-gfx] " Matt Roper
2020-09-28 17:24           ` Matt Roper
2020-09-28 17:30           ` Surendrakumar Upadhyay, TejaskumarX
2020-09-28 17:30             ` [Intel-gfx] " Surendrakumar Upadhyay, TejaskumarX
2020-09-28 17:32           ` Jani Nikula
2020-09-28 17:32             ` [Intel-gfx] " Jani Nikula
2020-09-28 17:32             ` Jani Nikula
2020-09-28  8:09 ` [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2 Tejas Upadhyay
2020-09-28  8:09   ` [Intel-gfx] " Tejas Upadhyay
2020-09-28  8:09   ` Tejas Upadhyay
2020-09-28 13:43   ` [Intel-gfx] " Jani Nikula
2020-09-28 13:43     ` Jani Nikula
2020-09-28 13:43     ` Jani Nikula
2020-09-28 14:15     ` James Ausmus
2020-09-28 14:15       ` James Ausmus
2020-09-28 14:15       ` James Ausmus
2020-09-28 15:02       ` Ville Syrjälä
2020-09-28 15:02         ` Ville Syrjälä
2020-09-28 15:02         ` Ville Syrjälä
2020-09-28 17:20         ` Jani Nikula
2020-09-28 17:20           ` Jani Nikula
2020-09-28 17:20           ` Jani Nikula
2020-09-29 12:45           ` Ville Syrjälä
2020-09-29 12:45             ` Ville Syrjälä
2020-09-29 12:45             ` Ville Syrjälä
2020-09-28 16:34     ` Surendrakumar Upadhyay, TejaskumarX
2020-09-28 16:34       ` Surendrakumar Upadhyay, TejaskumarX
2020-09-28 17:15       ` Jani Nikula
2020-09-28 17:15         ` Jani Nikula
2020-09-28 17:15         ` Jani Nikula
2020-09-28 23:07         ` Lucas De Marchi [this message]
2020-09-28 23:07           ` Lucas De Marchi
2020-09-28 23:07           ` Lucas De Marchi
2020-09-28 23:10           ` Matt Roper
2020-09-28 23:10             ` Matt Roper
2020-09-28 23:10             ` Matt Roper
2020-09-29  7:30             ` Jani Nikula
2020-09-29  7:30               ` Jani Nikula
2020-09-29  7:30               ` Jani Nikula
2020-09-28  8:51 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/jsl: Update JasperLake Voltage swing table Patchwork
2020-09-28  8:52 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-09-28  9:13 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-09-28 12:14 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200928230739.vpj22bwebqhtehuk@ldmartin-desk1 \
    --to=lucas.demarchi@intel.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hariom.pandey@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=james.ausmus@intel.com \
    --cc=jani.nikula@linux.intel.com \
    --cc=jose.souza@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew.d.roper@intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=tejaskumarx.surendrakumar.upadhyay@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.