From: Marco Elver <elver@google.com> To: elver@google.com, akpm@linux-foundation.org, glider@google.com Cc: hpa@zytor.com, paulmck@kernel.org, andreyknvl@google.com, aryabinin@virtuozzo.com, luto@kernel.org, bp@alien8.de, catalin.marinas@arm.com, cl@linux.com, dave.hansen@linux.intel.com, rientjes@google.com, dvyukov@google.com, edumazet@google.com, gregkh@linuxfoundation.org, hdanton@sina.com, mingo@redhat.com, jannh@google.com, Jonathan.Cameron@huawei.com, corbet@lwn.net, iamjoonsoo.kim@lge.com, keescook@chromium.org, mark.rutland@arm.com, penberg@kernel.org, peterz@infradead.org, sjpark@amazon.com, tglx@linutronix.de, vbabka@suse.cz, will@kernel.org, x86@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org Subject: [PATCH v4 08/11] kfence, lockdep: make KFENCE compatible with lockdep Date: Tue, 29 Sep 2020 15:38:11 +0200 [thread overview] Message-ID: <20200929133814.2834621-9-elver@google.com> (raw) In-Reply-To: <20200929133814.2834621-1-elver@google.com> Lockdep checks that dynamic key registration is only performed on keys that are not static objects. With KFENCE, it is possible that such a dynamically allocated key is a KFENCE object which may, however, be allocated from a static memory pool (if HAVE_ARCH_KFENCE_STATIC_POOL). Therefore, ignore KFENCE-allocated objects in static_obj(). Reviewed-by: Dmitry Vyukov <dvyukov@google.com> Co-developed-by: Alexander Potapenko <glider@google.com> Signed-off-by: Alexander Potapenko <glider@google.com> Signed-off-by: Marco Elver <elver@google.com> --- kernel/locking/lockdep.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c index 54b74fabf40c..0cf5d5ecbd31 100644 --- a/kernel/locking/lockdep.c +++ b/kernel/locking/lockdep.c @@ -38,6 +38,7 @@ #include <linux/seq_file.h> #include <linux/spinlock.h> #include <linux/kallsyms.h> +#include <linux/kfence.h> #include <linux/interrupt.h> #include <linux/stacktrace.h> #include <linux/debug_locks.h> @@ -755,6 +756,13 @@ static int static_obj(const void *obj) if (arch_is_kernel_initmem_freed(addr)) return 0; + /* + * KFENCE objects may be allocated from a static memory pool, but are + * not actually static objects. + */ + if (is_kfence_address(obj)) + return 0; + /* * static variable? */ -- 2.28.0.709.gb0816b6eb0-goog
WARNING: multiple messages have this Message-ID (diff)
From: Marco Elver <elver@google.com> To: elver@google.com, akpm@linux-foundation.org, glider@google.com Cc: mark.rutland@arm.com, hdanton@sina.com, linux-doc@vger.kernel.org, peterz@infradead.org, catalin.marinas@arm.com, dave.hansen@linux.intel.com, linux-mm@kvack.org, edumazet@google.com, hpa@zytor.com, cl@linux.com, will@kernel.org, sjpark@amazon.com, corbet@lwn.net, x86@kernel.org, kasan-dev@googlegroups.com, mingo@redhat.com, vbabka@suse.cz, rientjes@google.com, aryabinin@virtuozzo.com, keescook@chromium.org, paulmck@kernel.org, jannh@google.com, andreyknvl@google.com, bp@alien8.de, luto@kernel.org, Jonathan.Cameron@huawei.com, tglx@linutronix.de, dvyukov@google.com, linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, penberg@kernel.org, iamjoonsoo.kim@lge.com Subject: [PATCH v4 08/11] kfence, lockdep: make KFENCE compatible with lockdep Date: Tue, 29 Sep 2020 15:38:11 +0200 [thread overview] Message-ID: <20200929133814.2834621-9-elver@google.com> (raw) In-Reply-To: <20200929133814.2834621-1-elver@google.com> Lockdep checks that dynamic key registration is only performed on keys that are not static objects. With KFENCE, it is possible that such a dynamically allocated key is a KFENCE object which may, however, be allocated from a static memory pool (if HAVE_ARCH_KFENCE_STATIC_POOL). Therefore, ignore KFENCE-allocated objects in static_obj(). Reviewed-by: Dmitry Vyukov <dvyukov@google.com> Co-developed-by: Alexander Potapenko <glider@google.com> Signed-off-by: Alexander Potapenko <glider@google.com> Signed-off-by: Marco Elver <elver@google.com> --- kernel/locking/lockdep.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c index 54b74fabf40c..0cf5d5ecbd31 100644 --- a/kernel/locking/lockdep.c +++ b/kernel/locking/lockdep.c @@ -38,6 +38,7 @@ #include <linux/seq_file.h> #include <linux/spinlock.h> #include <linux/kallsyms.h> +#include <linux/kfence.h> #include <linux/interrupt.h> #include <linux/stacktrace.h> #include <linux/debug_locks.h> @@ -755,6 +756,13 @@ static int static_obj(const void *obj) if (arch_is_kernel_initmem_freed(addr)) return 0; + /* + * KFENCE objects may be allocated from a static memory pool, but are + * not actually static objects. + */ + if (is_kfence_address(obj)) + return 0; + /* * static variable? */ -- 2.28.0.709.gb0816b6eb0-goog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-29 13:39 UTC|newest] Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-29 13:38 [PATCH v4 00/11] KFENCE: A low-overhead sampling-based memory safety error detector Marco Elver 2020-09-29 13:38 ` Marco Elver 2020-09-29 13:38 ` Marco Elver 2020-09-29 13:38 ` [PATCH v4 01/11] mm: add Kernel Electric-Fence infrastructure Marco Elver 2020-09-29 13:38 ` Marco Elver 2020-09-29 13:38 ` Marco Elver 2020-10-02 6:33 ` Jann Horn 2020-10-02 6:33 ` Jann Horn 2020-10-02 6:33 ` Jann Horn 2020-10-02 7:53 ` Jann Horn 2020-10-02 7:53 ` Jann Horn 2020-10-02 7:53 ` Jann Horn 2020-10-02 14:22 ` Dmitry Vyukov 2020-10-02 14:22 ` Dmitry Vyukov 2020-10-02 14:22 ` Dmitry Vyukov 2020-10-02 15:06 ` Mark Rutland 2020-10-02 15:06 ` Mark Rutland 2020-10-02 18:27 ` Jann Horn 2020-10-02 18:27 ` Jann Horn 2020-10-02 18:27 ` Jann Horn 2020-10-05 18:59 ` Marco Elver 2020-10-05 18:59 ` Marco Elver 2020-10-05 18:59 ` Marco Elver 2020-10-02 17:19 ` Marco Elver 2020-10-02 17:19 ` Marco Elver 2020-10-02 19:31 ` Jann Horn 2020-10-02 19:31 ` Jann Horn 2020-10-02 19:31 ` Jann Horn 2020-10-02 21:12 ` Marco Elver 2020-10-02 21:12 ` Marco Elver 2020-10-02 21:28 ` Marco Elver 2020-10-02 21:28 ` Marco Elver 2020-10-02 21:28 ` Marco Elver 2020-10-02 22:27 ` Jann Horn 2020-10-02 22:27 ` Jann Horn 2020-10-02 22:27 ` Jann Horn 2020-10-12 14:20 ` Marco Elver 2020-10-12 14:20 ` Marco Elver 2020-10-12 14:20 ` Marco Elver 2020-09-29 13:38 ` [PATCH v4 02/11] x86, kfence: enable KFENCE for x86 Marco Elver 2020-09-29 13:38 ` Marco Elver 2020-09-29 13:38 ` Marco Elver 2020-10-02 5:45 ` Jann Horn 2020-10-02 5:45 ` Jann Horn 2020-10-02 5:45 ` Jann Horn 2020-10-07 13:08 ` Marco Elver 2020-10-07 13:08 ` Marco Elver 2020-10-07 13:08 ` Marco Elver 2020-10-07 14:14 ` Jann Horn 2020-10-07 14:14 ` Jann Horn 2020-10-07 14:14 ` Jann Horn 2020-10-07 14:41 ` Marco Elver 2020-10-07 14:41 ` Marco Elver 2020-10-07 14:41 ` Marco Elver 2020-10-09 17:40 ` Marco Elver 2020-10-09 17:40 ` Marco Elver 2020-10-02 6:08 ` Jann Horn 2020-10-02 6:08 ` Jann Horn 2020-10-02 6:08 ` Jann Horn 2020-09-29 13:38 ` [PATCH v4 03/11] arm64, kfence: enable KFENCE for ARM64 Marco Elver 2020-09-29 13:38 ` Marco Elver 2020-09-29 13:38 ` Marco Elver 2020-10-02 6:47 ` Jann Horn 2020-10-02 6:47 ` Jann Horn 2020-10-02 6:47 ` Jann Horn 2020-10-02 14:18 ` Marco Elver 2020-10-02 14:18 ` Marco Elver 2020-10-02 14:18 ` Marco Elver 2020-10-02 16:10 ` Jann Horn 2020-10-02 16:10 ` Jann Horn 2020-10-02 16:10 ` Jann Horn 2020-09-29 13:38 ` [PATCH v4 04/11] mm, kfence: insert KFENCE hooks for SLAB Marco Elver 2020-09-29 13:38 ` Marco Elver 2020-09-29 13:38 ` Marco Elver 2020-09-29 13:38 ` [PATCH v4 05/11] mm, kfence: insert KFENCE hooks for SLUB Marco Elver 2020-09-29 13:38 ` Marco Elver 2020-09-29 13:38 ` Marco Elver 2020-10-02 7:07 ` Jann Horn 2020-10-02 7:07 ` Jann Horn 2020-10-02 7:07 ` Jann Horn 2020-10-05 9:29 ` Alexander Potapenko 2020-10-05 9:29 ` Alexander Potapenko 2020-10-05 9:29 ` Alexander Potapenko 2020-09-29 13:38 ` [PATCH v4 06/11] kfence, kasan: make KFENCE compatible with KASAN Marco Elver 2020-09-29 13:38 ` Marco Elver 2020-09-29 13:38 ` Marco Elver 2020-09-29 13:38 ` [PATCH v4 07/11] kfence, kmemleak: make KFENCE compatible with KMEMLEAK Marco Elver 2020-09-29 13:38 ` Marco Elver 2020-09-29 13:38 ` Marco Elver 2020-09-29 13:38 ` Marco Elver [this message] 2020-09-29 13:38 ` [PATCH v4 08/11] kfence, lockdep: make KFENCE compatible with lockdep Marco Elver 2020-09-29 13:38 ` Marco Elver 2020-09-29 13:38 ` [PATCH v4 09/11] kfence, Documentation: add KFENCE documentation Marco Elver 2020-09-29 13:38 ` Marco Elver 2020-09-29 13:38 ` Marco Elver 2020-09-29 13:38 ` [PATCH v4 10/11] kfence: add test suite Marco Elver 2020-09-29 13:38 ` Marco Elver 2020-09-29 13:38 ` Marco Elver 2020-09-29 13:38 ` [PATCH v4 11/11] MAINTAINERS: Add entry for KFENCE Marco Elver 2020-09-29 13:38 ` Marco Elver 2020-09-29 13:38 ` Marco Elver 2020-09-29 14:21 ` SeongJae Park 2020-09-29 14:21 ` SeongJae Park
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200929133814.2834621-9-elver@google.com \ --to=elver@google.com \ --cc=Jonathan.Cameron@huawei.com \ --cc=akpm@linux-foundation.org \ --cc=andreyknvl@google.com \ --cc=aryabinin@virtuozzo.com \ --cc=bp@alien8.de \ --cc=catalin.marinas@arm.com \ --cc=cl@linux.com \ --cc=corbet@lwn.net \ --cc=dave.hansen@linux.intel.com \ --cc=dvyukov@google.com \ --cc=edumazet@google.com \ --cc=glider@google.com \ --cc=gregkh@linuxfoundation.org \ --cc=hdanton@sina.com \ --cc=hpa@zytor.com \ --cc=iamjoonsoo.kim@lge.com \ --cc=jannh@google.com \ --cc=kasan-dev@googlegroups.com \ --cc=keescook@chromium.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=luto@kernel.org \ --cc=mark.rutland@arm.com \ --cc=mingo@redhat.com \ --cc=paulmck@kernel.org \ --cc=penberg@kernel.org \ --cc=peterz@infradead.org \ --cc=rientjes@google.com \ --cc=sjpark@amazon.com \ --cc=tglx@linutronix.de \ --cc=vbabka@suse.cz \ --cc=will@kernel.org \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.