Re: [patch V2 33/36] net: libertas: Use netif_rx_any_context()

From: James Cameron <quozl@laptop.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Andrew Lunn <andrew@lunn.ch>,
	Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
	linux-doc@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
	Chris Snook <chris.snook@gmail.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Christian Benvenuti <benve@cisco.com>,
	Arend van Spriel <arend.vanspriel@broadcom.com>,
	Govindarajulu Varadarajan <_govind@gmx.com>,
	Vishal Kulkarni <vishal@chelsio.com>,
	Luca Coelho <luciano.coelho@intel.com>,
	Edward Cree <ecree@solarflare.com>,
	libertas-dev@lists.infradead.org, brcm80211-dev-list@cypress.com,
	brcm80211-dev-list.pdl@broadcom.com,
	Ping-Ke Shih <pkshih@realtek.com>,
	Johannes Berg <johannes.berg@intel.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
	Intel Linux Wireless <linuxwifi@intel.com>,
	Russell King <linux@armlinux.org.uk>,
	Matthew Wilcox <willy@infradead.org>,
	intel-wired-lan@lists.osuosl.org,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Martin Habets <mhabets@solarflare.com>,
	Ulrich Kunitz <kune@deine-taler.de>,
	Jay Cliburn <jcliburn@gmail.com>,
	Paul McKenney <paulmck@kernel.org>,
	Stanislaw Gruszka <stf_xl@wp.pl>, Jouni Malinen <j@w1.fi>,
	Hante Meuleman <hante.meuleman@broadcom.com>,
	Pascal Terjan <pterjan@google.com>,
	Amitkumar Karwar <amitkarwar@gmail.com>,
	Wright Feng <wright.feng@cypress.com>,
	Daniel Drake <dsd@gentoo.org>,
	Pensando Drivers <drivers@pensando.io>,
	Kalle Valo <kvalo@codeaurora.org>,
	Franky Lin <franky.lin@broadcom.com>,
	Solarflare linux maintainers <linux-net-drivers@solarflare.com>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Chi-Hsien Lin <chi-hsien.lin@cypress.com>,
	Xinming Hu <huxinming820@gmail.com>,
	netdev@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-wireless@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Ganapathi Bhat <ganapathi.bhat@nxp.com>,
	Stanislav Yakovlev <stas.yakovlev@gmail.com>,
	Jon Mason <jdmason@kudzu.us>,
	Shannon Nelson <snelson@pensando.io>,
	Dave Miller <davem@davemloft.net>,
	Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
	Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [patch V2 33/36] net: libertas: Use netif_rx_any_context()
Date: Wed, 30 Sep 2020 07:53:03 +1000	[thread overview]
Message-ID: <20200929215302.GB16571@laptop.org> (raw)
In-Reply-To: <20200929203502.769744809@linutronix.de>

On Tue, Sep 29, 2020 at 10:25:42PM +0200, Thomas Gleixner wrote:
> From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> 
> The usage of in_interrupt() in non-core code is phased out. Ideally the
> information of the calling context should be passed by the callers or the
> functions be split as appropriate.
> 
> libertas uses in_interupt() to select the netif_rx*() variant which matches
> the calling context. The attempt to consolidate the code by passing an
> arguemnt or by distangling it failed due lack of knowledge about this
> driver and because the call chains are hard to follow.
> 
> As a stop gap use netif_rx_any_context() which invokes the correct code
> path depending on context and confines the in_interrupt() usage to core
> code.
> 
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Acked-by: Kalle Valo <kvalo@codeaurora.org>

Reviewed-by: James Cameron <quozl@laptop.org>

-- 
James Cameron
http://quozl.netrek.org/