From: Pratyush Yadav <p.yadav@ti.com>
To: <Tudor.Ambarus@microchip.com>
Cc: <miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
<nsekhar@ti.com>, <boris.brezillon@collabora.com>
Subject: Re: [PATCH v13 10/15] mtd: spi-nor: sfdp: detect Soft Reset sequence support from BFPT
Date: Wed, 30 Sep 2020 13:01:13 +0530 [thread overview]
Message-ID: <20200930073111.sk67oqn6hkihmrfd@ti.com> (raw)
In-Reply-To: <8346524d-487b-a147-6183-e8055a7ff54a@microchip.com>
On 30/09/20 07:23AM, Tudor.Ambarus@microchip.com wrote:
> On 9/16/20 3:44 PM, Pratyush Yadav wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> >
> > A Soft Reset sequence will return the flash to Power-on-Reset (POR)
> > state. It consists of two commands: Soft Reset Enable and Soft Reset.
> > Find out if the sequence is supported from BFPT DWORD 16.
> >
> > Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
> > ---
> > drivers/mtd/spi-nor/core.h | 1 +
> > drivers/mtd/spi-nor/sfdp.c | 4 ++++
> > drivers/mtd/spi-nor/sfdp.h | 2 ++
> > 3 files changed, 7 insertions(+)
> >
> > diff --git a/drivers/mtd/spi-nor/sfdp.h b/drivers/mtd/spi-nor/sfdp.h
> > index 6d7243067252..8ae55e98084e 100644
> > --- a/drivers/mtd/spi-nor/sfdp.h
> > +++ b/drivers/mtd/spi-nor/sfdp.h
> > @@ -90,6 +90,8 @@ struct sfdp_bfpt {
> > #define BFPT_DWORD15_QER_SR2_BIT1_NO_RD (0x4UL << 20)
> > #define BFPT_DWORD15_QER_SR2_BIT1 (0x5UL << 20) /* Spansion */
> >
> > +#define BFPT_DWORD16_SOFT_RST BIT(12)
>
> the name is too generic. How about
>
> #define BFPT_DWORD16_SWRST_EN_RST BIT(12)
Ok.
>
> > +
> > #define BFPT_DWORD18_CMD_EXT_MASK GENMASK(30, 29)
> > #define BFPT_DWORD18_CMD_EXT_REP (0x0UL << 29) /* Repeat */
> > #define BFPT_DWORD18_CMD_EXT_INV (0x1UL << 29) /* Invert */
--
Regards,
Pratyush Yadav
Texas Instruments India
WARNING: multiple messages have this Message-ID (diff)
From: Pratyush Yadav <p.yadav@ti.com>
To: <Tudor.Ambarus@microchip.com>
Cc: vigneshr@ti.com, richard@nod.at, nsekhar@ti.com,
linux-kernel@vger.kernel.org, boris.brezillon@collabora.com,
linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com
Subject: Re: [PATCH v13 10/15] mtd: spi-nor: sfdp: detect Soft Reset sequence support from BFPT
Date: Wed, 30 Sep 2020 13:01:13 +0530 [thread overview]
Message-ID: <20200930073111.sk67oqn6hkihmrfd@ti.com> (raw)
In-Reply-To: <8346524d-487b-a147-6183-e8055a7ff54a@microchip.com>
On 30/09/20 07:23AM, Tudor.Ambarus@microchip.com wrote:
> On 9/16/20 3:44 PM, Pratyush Yadav wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> >
> > A Soft Reset sequence will return the flash to Power-on-Reset (POR)
> > state. It consists of two commands: Soft Reset Enable and Soft Reset.
> > Find out if the sequence is supported from BFPT DWORD 16.
> >
> > Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
> > ---
> > drivers/mtd/spi-nor/core.h | 1 +
> > drivers/mtd/spi-nor/sfdp.c | 4 ++++
> > drivers/mtd/spi-nor/sfdp.h | 2 ++
> > 3 files changed, 7 insertions(+)
> >
> > diff --git a/drivers/mtd/spi-nor/sfdp.h b/drivers/mtd/spi-nor/sfdp.h
> > index 6d7243067252..8ae55e98084e 100644
> > --- a/drivers/mtd/spi-nor/sfdp.h
> > +++ b/drivers/mtd/spi-nor/sfdp.h
> > @@ -90,6 +90,8 @@ struct sfdp_bfpt {
> > #define BFPT_DWORD15_QER_SR2_BIT1_NO_RD (0x4UL << 20)
> > #define BFPT_DWORD15_QER_SR2_BIT1 (0x5UL << 20) /* Spansion */
> >
> > +#define BFPT_DWORD16_SOFT_RST BIT(12)
>
> the name is too generic. How about
>
> #define BFPT_DWORD16_SWRST_EN_RST BIT(12)
Ok.
>
> > +
> > #define BFPT_DWORD18_CMD_EXT_MASK GENMASK(30, 29)
> > #define BFPT_DWORD18_CMD_EXT_REP (0x0UL << 29) /* Repeat */
> > #define BFPT_DWORD18_CMD_EXT_INV (0x1UL << 29) /* Invert */
--
Regards,
Pratyush Yadav
Texas Instruments India
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-09-30 7:31 UTC|newest]
Thread overview: 114+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 12:44 [PATCH v13 00/15] mtd: spi-nor: add xSPI Octal DTR support Pratyush Yadav
2020-09-16 12:44 ` Pratyush Yadav
2020-09-16 12:44 ` Pratyush Yadav
2020-09-16 12:44 ` [PATCH v13 01/15] mtd: spi-nor: core: use EOPNOTSUPP instead of ENOTSUPP Pratyush Yadav
2020-09-16 12:44 ` Pratyush Yadav
2020-09-16 12:44 ` Pratyush Yadav
2020-09-29 11:30 ` Tudor.Ambarus
2020-09-29 11:30 ` Tudor.Ambarus
2020-09-16 12:44 ` [PATCH v13 02/15] mtd: spi-nor: core: add spi_nor_{read,write}_reg() helpers Pratyush Yadav
2020-09-16 12:44 ` [PATCH v13 02/15] mtd: spi-nor: core: add spi_nor_{read, write}_reg() helpers Pratyush Yadav
2020-09-16 12:44 ` [PATCH v13 02/15] mtd: spi-nor: core: add spi_nor_{read,write}_reg() helpers Pratyush Yadav
2020-09-29 11:38 ` Tudor.Ambarus
2020-09-29 11:38 ` Tudor.Ambarus
2020-09-29 12:54 ` Pratyush Yadav
2020-09-29 12:54 ` Pratyush Yadav
2020-09-16 12:44 ` [PATCH v13 03/15] mtd: spi-nor: core: add spi_nor_controller_ops_erase helper Pratyush Yadav
2020-09-16 12:44 ` Pratyush Yadav
2020-09-16 12:44 ` Pratyush Yadav
2020-09-16 12:44 ` [PATCH v13 04/15] mtd: spi-nor: add support for DTR protocol Pratyush Yadav
2020-09-16 12:44 ` Pratyush Yadav
2020-09-16 12:44 ` Pratyush Yadav
2020-09-16 12:44 ` [PATCH v13 05/15] mtd: spi-nor: sfdp: get command opcode extension type from BFPT Pratyush Yadav
2020-09-16 12:44 ` Pratyush Yadav
2020-09-16 12:44 ` Pratyush Yadav
2020-09-30 6:17 ` Tudor.Ambarus
2020-09-30 6:17 ` Tudor.Ambarus
2020-09-16 12:44 ` [PATCH v13 06/15] mtd: spi-nor: sfdp: parse xSPI Profile 1.0 table Pratyush Yadav
2020-09-16 12:44 ` Pratyush Yadav
2020-09-16 12:44 ` Pratyush Yadav
2020-09-30 6:44 ` Tudor.Ambarus
2020-09-30 6:44 ` Tudor.Ambarus
2020-09-30 6:53 ` Pratyush Yadav
2020-09-30 6:53 ` Pratyush Yadav
2020-09-16 12:44 ` [PATCH v13 07/15] mtd: spi-nor: core: use dummy cycle and address width info from SFDP Pratyush Yadav
2020-09-16 12:44 ` Pratyush Yadav
2020-09-16 12:44 ` Pratyush Yadav
2020-09-30 6:46 ` Tudor.Ambarus
2020-09-30 6:46 ` Tudor.Ambarus
2020-09-16 12:44 ` [PATCH v13 08/15] mtd: spi-nor: core: do 2 byte reads for SR and FSR in DTR mode Pratyush Yadav
2020-09-16 12:44 ` Pratyush Yadav
2020-09-16 12:44 ` Pratyush Yadav
2020-09-30 6:50 ` Tudor.Ambarus
2020-09-30 6:50 ` Tudor.Ambarus
2020-09-30 6:55 ` Pratyush Yadav
2020-09-30 6:55 ` Pratyush Yadav
2020-09-16 12:44 ` [PATCH v13 09/15] mtd: spi-nor: core: enable octal DTR mode when possible Pratyush Yadav
2020-09-16 12:44 ` Pratyush Yadav
2020-09-16 12:44 ` Pratyush Yadav
2020-09-29 11:26 ` Tudor.Ambarus
2020-09-29 11:26 ` Tudor.Ambarus
2020-09-29 12:51 ` Pratyush Yadav
2020-09-29 12:51 ` Pratyush Yadav
2020-09-29 13:05 ` Tudor.Ambarus
2020-09-29 13:05 ` Tudor.Ambarus
2020-09-30 7:11 ` Tudor.Ambarus
2020-09-30 7:11 ` Tudor.Ambarus
2020-09-16 12:44 ` [PATCH v13 10/15] mtd: spi-nor: sfdp: detect Soft Reset sequence support from BFPT Pratyush Yadav
2020-09-16 12:44 ` Pratyush Yadav
2020-09-16 12:44 ` Pratyush Yadav
2020-09-30 7:23 ` Tudor.Ambarus
2020-09-30 7:23 ` Tudor.Ambarus
2020-09-30 7:31 ` Pratyush Yadav [this message]
2020-09-30 7:31 ` Pratyush Yadav
2020-09-16 12:44 ` [PATCH v13 11/15] mtd: spi-nor: core: perform a Soft Reset on shutdown Pratyush Yadav
2020-09-16 12:44 ` Pratyush Yadav
2020-09-16 12:44 ` Pratyush Yadav
2020-09-29 13:08 ` Pratyush Yadav
2020-09-29 13:08 ` Pratyush Yadav
2020-09-30 7:32 ` Tudor.Ambarus
2020-09-30 7:32 ` Tudor.Ambarus
2020-09-30 7:43 ` Pratyush Yadav
2020-09-30 7:43 ` Pratyush Yadav
2020-09-16 12:44 ` [PATCH v13 12/15] mtd: spi-nor: core: disable Octal DTR mode on suspend Pratyush Yadav
2020-09-16 12:44 ` Pratyush Yadav
2020-09-16 12:44 ` Pratyush Yadav
2020-09-30 7:40 ` Tudor.Ambarus
2020-09-30 7:40 ` Tudor.Ambarus
2020-09-30 7:44 ` Pratyush Yadav
2020-09-30 7:44 ` Pratyush Yadav
2020-09-16 12:44 ` [PATCH v13 13/15] mtd: spi-nor: core: expose spi_nor_default_setup() in core.h Pratyush Yadav
2020-09-16 12:44 ` Pratyush Yadav
2020-09-16 12:44 ` Pratyush Yadav
2020-09-30 7:51 ` Tudor.Ambarus
2020-09-30 7:51 ` Tudor.Ambarus
2020-09-30 8:03 ` Pratyush Yadav
2020-09-30 8:03 ` Pratyush Yadav
2020-09-16 12:44 ` [PATCH v13 14/15] mtd: spi-nor: spansion: add support for Cypress Semper flash Pratyush Yadav
2020-09-16 12:44 ` Pratyush Yadav
2020-09-16 12:44 ` Pratyush Yadav
2020-09-30 8:36 ` Tudor.Ambarus
2020-09-30 8:36 ` Tudor.Ambarus
2020-09-30 12:32 ` Pratyush Yadav
2020-09-30 12:32 ` Pratyush Yadav
2020-09-16 12:44 ` [PATCH v13 15/15] mtd: spi-nor: micron-st: allow using MT35XU512ABA in Octal DTR mode Pratyush Yadav
2020-09-16 12:44 ` Pratyush Yadav
2020-09-16 12:44 ` Pratyush Yadav
2020-09-30 9:12 ` Tudor.Ambarus
2020-09-30 9:12 ` Tudor.Ambarus
2020-09-29 9:59 ` [RFC PATCH 0/3] mtd: spi-nor: Tackle stateful modes Tudor Ambarus
2020-09-29 9:59 ` Tudor Ambarus
2020-09-29 9:59 ` [RFC PATCH 1/3] mtd: spi-nor: Introduce SNOR_F_IO_MODE_EN_VOLATILE Tudor Ambarus
2020-09-29 9:59 ` Tudor Ambarus
2020-09-29 16:45 ` Vignesh Raghavendra
2020-09-29 16:45 ` Vignesh Raghavendra
2020-09-29 9:59 ` [RFC PATCH 2/3] mtd: spi-nor: Introduce MTD_SPI_NOR_ALLOW_STATEFUL_MODES Tudor Ambarus
2020-09-29 9:59 ` Tudor Ambarus
2020-09-29 16:45 ` Vignesh Raghavendra
2020-09-29 16:45 ` Vignesh Raghavendra
2020-09-29 9:59 ` [RFC PATCH 3/3] mtd: spi-nor: Parse SFDP SCCR Map Tudor Ambarus
2020-09-29 9:59 ` Tudor Ambarus
2020-09-30 9:57 ` [PATCH v13 00/15] mtd: spi-nor: add xSPI Octal DTR support Tudor.Ambarus
2020-09-30 9:57 ` Tudor.Ambarus
2020-09-30 12:01 ` Pratyush Yadav
2020-09-30 12:01 ` Pratyush Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200930073111.sk67oqn6hkihmrfd@ti.com \
--to=p.yadav@ti.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=boris.brezillon@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=nsekhar@ti.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.