All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Nick Terrell <terrelln@fb.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	Nick Terrell <nickrterrell@gmail.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	Btrfs BTRFS <linux-btrfs@vger.kernel.org>,
	"squashfs-devel@lists.sourceforge.net" 
	<squashfs-devel@lists.sourceforge.net>,
	"linux-f2fs-devel@lists.sourceforge.net" 
	<linux-f2fs-devel@lists.sourceforge.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Kernel Team <Kernel-team@fb.com>, Chris Mason <clm@fb.com>,
	Petr Malat <oss@malat.biz>, Johannes Weiner <jweiner@fb.com>,
	Niket Agarwal <niketa@fb.com>, Yann Collet <cyan@fb.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v4 0/9] Update to zstd-1.4.6
Date: Fri, 2 Oct 2020 07:54:54 +0100	[thread overview]
Message-ID: <20201002065454.GA29993@infradead.org> (raw)
In-Reply-To: <8743398B-0BBB-424E-A6A7-9D8AE4EFE8ED@fb.com>

On Wed, Sep 30, 2020 at 08:05:45PM +0000, Nick Terrell wrote:
> 
> 
> > On Sep 29, 2020, at 11:53 PM, Christoph Hellwig <hch@infradead.org> wrote:
> > 
> > As you keep resend this I keep retelling you that should not do it.
> > Please provide a proper Linux API, and switch to that.  Versioned APIs
> > have absolutely no business in the Linux kernel.
> 
> The API is not versioned. We provide a stable ABI for a large section of our API,
> and the parts that aren???t ABI stable don???t change in semantics, and undergo long
> deprecation periods before being removed.
> 
> The change of callers is a one-time change to transition from the existing API
> in the kernel, which was never upstream's API, to upstream's API.

Again, please transition it to a sane kernel API.  We don't have an
"upstream" in this case.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Nick Terrell <terrelln@fb.com>
Cc: "squashfs-devel@lists.sourceforge.net"
	<squashfs-devel@lists.sourceforge.net>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Nick Terrell <nickrterrell@gmail.com>, Yann Collet <cyan@fb.com>,
	Petr Malat <oss@malat.biz>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-f2fs-devel@lists.sourceforge.net"
	<linux-f2fs-devel@lists.sourceforge.net>,
	Christoph Hellwig <hch@infradead.org>, Chris Mason <clm@fb.com>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Kernel Team <Kernel-team@fb.com>, Niket Agarwal <niketa@fb.com>,
	Btrfs BTRFS <linux-btrfs@vger.kernel.org>,
	Johannes Weiner <jweiner@fb.com>
Subject: Re: [f2fs-dev] [PATCH v4 0/9] Update to zstd-1.4.6
Date: Fri, 2 Oct 2020 07:54:54 +0100	[thread overview]
Message-ID: <20201002065454.GA29993@infradead.org> (raw)
In-Reply-To: <8743398B-0BBB-424E-A6A7-9D8AE4EFE8ED@fb.com>

On Wed, Sep 30, 2020 at 08:05:45PM +0000, Nick Terrell wrote:
> 
> 
> > On Sep 29, 2020, at 11:53 PM, Christoph Hellwig <hch@infradead.org> wrote:
> > 
> > As you keep resend this I keep retelling you that should not do it.
> > Please provide a proper Linux API, and switch to that.  Versioned APIs
> > have absolutely no business in the Linux kernel.
> 
> The API is not versioned. We provide a stable ABI for a large section of our API,
> and the parts that aren???t ABI stable don???t change in semantics, and undergo long
> deprecation periods before being removed.
> 
> The change of callers is a one-time change to transition from the existing API
> in the kernel, which was never upstream's API, to upstream's API.

Again, please transition it to a sane kernel API.  We don't have an
"upstream" in this case.


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  reply	other threads:[~2020-10-02  6:55 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30  6:53 [PATCH v4 0/9] Update to zstd-1.4.6 Nick Terrell
2020-09-30  6:53 ` [f2fs-dev] " Nick Terrell
2020-09-30  6:53 ` [PATCH v4 1/9] lib: zstd: Add zstd compatibility wrapper Nick Terrell
2020-09-30  6:53   ` [f2fs-dev] " Nick Terrell
2020-09-30  6:53 ` [PATCH v4 2/9] lib: zstd: Add decompress_sources.h for decompress_unzstd Nick Terrell
2020-09-30  6:53   ` [f2fs-dev] " Nick Terrell
2020-09-30  6:53 ` [PATCH v4 3/9] lib: zstd: Upgrade to latest upstream zstd version 1.4.6 Nick Terrell
2020-09-30  6:53   ` [f2fs-dev] " Nick Terrell
2020-10-01 20:50   ` kernel test robot
2020-10-01 20:50     ` kernel test robot
2020-10-01 20:50   ` [PATCH] lib: zstd: fix semicolon.cocci warnings kernel test robot
2020-10-01 20:50     ` kernel test robot
2020-10-01 20:50     ` [f2fs-dev] " kernel test robot
2020-09-30  6:53 ` [PATCH v4 4/9] crypto: zstd: Switch to zstd-1.4.6 API Nick Terrell
2020-09-30  6:53   ` [f2fs-dev] " Nick Terrell
2020-09-30  6:53 ` [PATCH v4 5/9] btrfs: zstd: Switch to the " Nick Terrell
2020-09-30  6:53   ` [f2fs-dev] " Nick Terrell
2020-09-30  6:53 ` [PATCH v4 6/9] f2fs: " Nick Terrell
2020-09-30  6:53   ` [f2fs-dev] " Nick Terrell
2020-09-30  6:53 ` [PATCH v4 7/9] squashfs: " Nick Terrell
2020-09-30  6:53   ` [f2fs-dev] " Nick Terrell
2020-09-30  6:53 ` [PATCH v4 8/9] lib: unzstd: " Nick Terrell
2020-09-30  6:53   ` [f2fs-dev] " Nick Terrell
2020-09-30  6:53 ` [PATCH v4 9/9] lib: zstd: Remove zstd compatibility wrapper Nick Terrell
2020-09-30  6:53   ` [f2fs-dev] " Nick Terrell
2020-09-30  6:53 ` [PATCH v4 0/9] Update to zstd-1.4.6 Christoph Hellwig
2020-09-30  6:53   ` [f2fs-dev] " Christoph Hellwig
2020-09-30 20:05   ` Nick Terrell
2020-09-30 20:05     ` [f2fs-dev] " Nick Terrell via Linux-f2fs-devel
2020-10-02  6:54     ` Christoph Hellwig [this message]
2020-10-02  6:54       ` Christoph Hellwig
2020-10-02 13:42       ` Chris Mason
2020-10-02 13:42         ` [f2fs-dev] " Chris Mason via Linux-f2fs-devel
2020-09-30 20:49 ` [GIT PULL][PATCH " Nick Terrell
2020-09-30 20:49   ` [f2fs-dev] " Nick Terrell via Linux-f2fs-devel
2020-10-01 10:18   ` David Sterba
2020-10-01 10:18     ` [f2fs-dev] " David Sterba
2020-10-01 18:35     ` Nick Terrell
2020-10-01 18:35       ` [f2fs-dev] " Nick Terrell via Linux-f2fs-devel
2020-10-02  6:56       ` Christoph Hellwig
2020-10-02  6:56         ` [f2fs-dev] " Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201002065454.GA29993@infradead.org \
    --to=hch@infradead.org \
    --cc=Kernel-team@fb.com \
    --cc=clm@fb.com \
    --cc=cyan@fb.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=jweiner@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nickrterrell@gmail.com \
    --cc=niketa@fb.com \
    --cc=oss@malat.biz \
    --cc=squashfs-devel@lists.sourceforge.net \
    --cc=terrelln@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.