From: Moritz Fischer <mdf@kernel.org> To: Tom Rix <trix@redhat.com> Cc: Moritz Fischer <mdf@kernel.org>, linux-fpga@vger.kernel.org, hao.wu@intel.com, michal.simek@xilinx.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, russell.h.weight@intel.com, matthew.gerlach@intel.com Subject: Re: [PATCH 03/10] fpga: fpga-mgr: dfl-fme-mgr: Simplify registration Date: Sun, 4 Oct 2020 16:40:08 -0700 [thread overview] Message-ID: <20201004234008.GB111357@epycbox.lan> (raw) In-Reply-To: <408267d9-1026-1a80-56c9-3a8beaaa2b82@redhat.com> On Sun, Oct 04, 2020 at 11:22:31AM -0700, Tom Rix wrote: > > On 10/3/20 10:14 PM, Moritz Fischer wrote: > > Simplify registration using new devm_fpga_mgr_register() API. > > > > Signed-off-by: Moritz Fischer <mdf@kernel.org> > > --- > > drivers/fpga/dfl-fme-mgr.c | 12 +----------- > > 1 file changed, 1 insertion(+), 11 deletions(-) > > > > diff --git a/drivers/fpga/dfl-fme-mgr.c b/drivers/fpga/dfl-fme-mgr.c > > index b3f7eee3c93f..3fc2be87d059 100644 > > --- a/drivers/fpga/dfl-fme-mgr.c > > +++ b/drivers/fpga/dfl-fme-mgr.c > > @@ -316,16 +316,7 @@ static int fme_mgr_probe(struct platform_device *pdev) > > mgr->compat_id = compat_id; > > platform_set_drvdata(pdev, mgr); > Nice catch. Will fix. > Is this call is still needed ? > > Tom > > > > > - return fpga_mgr_register(mgr); > > -} > > - > > -static int fme_mgr_remove(struct platform_device *pdev) > > -{ > > - struct fpga_manager *mgr = platform_get_drvdata(pdev); > > - > > - fpga_mgr_unregister(mgr); > > - > > - return 0; > > + return devm_fpga_mgr_register(dev, mgr); > > } > > > > static struct platform_driver fme_mgr_driver = { > > @@ -333,7 +324,6 @@ static struct platform_driver fme_mgr_driver = { > > .name = DFL_FPGA_FME_MGR, > > }, > > .probe = fme_mgr_probe, > > - .remove = fme_mgr_remove, > > }; > > > > module_platform_driver(fme_mgr_driver); > Cheers, Moritz
WARNING: multiple messages have this Message-ID (diff)
From: Moritz Fischer <mdf@kernel.org> To: Tom Rix <trix@redhat.com> Cc: russell.h.weight@intel.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, matthew.gerlach@intel.com, michal.simek@xilinx.com, Moritz Fischer <mdf@kernel.org>, linux-arm-kernel@lists.infradead.org, hao.wu@intel.com Subject: Re: [PATCH 03/10] fpga: fpga-mgr: dfl-fme-mgr: Simplify registration Date: Sun, 4 Oct 2020 16:40:08 -0700 [thread overview] Message-ID: <20201004234008.GB111357@epycbox.lan> (raw) In-Reply-To: <408267d9-1026-1a80-56c9-3a8beaaa2b82@redhat.com> On Sun, Oct 04, 2020 at 11:22:31AM -0700, Tom Rix wrote: > > On 10/3/20 10:14 PM, Moritz Fischer wrote: > > Simplify registration using new devm_fpga_mgr_register() API. > > > > Signed-off-by: Moritz Fischer <mdf@kernel.org> > > --- > > drivers/fpga/dfl-fme-mgr.c | 12 +----------- > > 1 file changed, 1 insertion(+), 11 deletions(-) > > > > diff --git a/drivers/fpga/dfl-fme-mgr.c b/drivers/fpga/dfl-fme-mgr.c > > index b3f7eee3c93f..3fc2be87d059 100644 > > --- a/drivers/fpga/dfl-fme-mgr.c > > +++ b/drivers/fpga/dfl-fme-mgr.c > > @@ -316,16 +316,7 @@ static int fme_mgr_probe(struct platform_device *pdev) > > mgr->compat_id = compat_id; > > platform_set_drvdata(pdev, mgr); > Nice catch. Will fix. > Is this call is still needed ? > > Tom > > > > > - return fpga_mgr_register(mgr); > > -} > > - > > -static int fme_mgr_remove(struct platform_device *pdev) > > -{ > > - struct fpga_manager *mgr = platform_get_drvdata(pdev); > > - > > - fpga_mgr_unregister(mgr); > > - > > - return 0; > > + return devm_fpga_mgr_register(dev, mgr); > > } > > > > static struct platform_driver fme_mgr_driver = { > > @@ -333,7 +324,6 @@ static struct platform_driver fme_mgr_driver = { > > .name = DFL_FPGA_FME_MGR, > > }, > > .probe = fme_mgr_probe, > > - .remove = fme_mgr_remove, > > }; > > > > module_platform_driver(fme_mgr_driver); > Cheers, Moritz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-04 23:40 UTC|newest] Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-04 5:14 [PATCH 00/10] Introduce devm_fpga_mgr_register() Moritz Fischer 2020-10-04 5:14 ` Moritz Fischer 2020-10-04 5:14 ` [PATCH 01/10] fpga: fpga-mgr: Add devm_fpga_mgr_register() API Moritz Fischer 2020-10-04 5:14 ` Moritz Fischer 2020-10-04 18:08 ` Tom Rix 2020-10-04 18:08 ` Tom Rix 2020-10-05 5:18 ` Wu, Hao 2020-10-05 5:18 ` Wu, Hao 2020-10-05 16:45 ` Moritz Fischer 2020-10-05 16:45 ` Moritz Fischer 2020-10-04 5:14 ` [PATCH 02/10] fpga: fpga-mgr: altera-ps-spi: Simplify registration Moritz Fischer 2020-10-04 5:14 ` Moritz Fischer 2020-10-04 18:15 ` Tom Rix 2020-10-04 18:15 ` Tom Rix 2020-10-04 5:14 ` [PATCH 03/10] fpga: fpga-mgr: dfl-fme-mgr: " Moritz Fischer 2020-10-04 5:14 ` Moritz Fischer 2020-10-04 18:22 ` Tom Rix 2020-10-04 18:22 ` Tom Rix 2020-10-04 23:40 ` Moritz Fischer [this message] 2020-10-04 23:40 ` Moritz Fischer 2020-10-04 5:14 ` [PATCH 04/10] fpga: fpga-mgr: ice40-spi: " Moritz Fischer 2020-10-04 5:14 ` Moritz Fischer 2020-10-04 18:24 ` Tom Rix 2020-10-04 18:24 ` Tom Rix 2020-10-04 5:14 ` [PATCH 05/10] fpga: fpga-mgr: machxo2-spi: " Moritz Fischer 2020-10-04 5:14 ` Moritz Fischer 2020-10-04 18:25 ` Tom Rix 2020-10-04 18:25 ` Tom Rix 2020-10-04 5:14 ` [PATCH 06/10] fpga: fpga-mgr: socfpga: " Moritz Fischer 2020-10-04 5:14 ` Moritz Fischer 2020-10-04 18:27 ` Tom Rix 2020-10-04 18:27 ` Tom Rix 2020-10-04 5:14 ` [PATCH 07/10] fpga: fpga-mgr: ts73xx: " Moritz Fischer 2020-10-04 5:14 ` Moritz Fischer 2020-10-04 18:27 ` Tom Rix 2020-10-04 18:27 ` Tom Rix 2020-10-04 5:14 ` [PATCH 08/10] fpga: fpga-mgr: xilinx-spi: " Moritz Fischer 2020-10-04 5:14 ` Moritz Fischer 2020-10-04 18:28 ` Tom Rix 2020-10-04 18:28 ` Tom Rix 2020-10-04 5:14 ` [PATCH 09/10] fpga: fpga-mgr: zynqmp: " Moritz Fischer 2020-10-04 5:14 ` Moritz Fischer 2020-10-04 18:33 ` Tom Rix 2020-10-04 18:33 ` Tom Rix 2020-10-04 5:14 ` [PATCH 10/10] fpga: fpga-mgr: altera-pr-ip: " Moritz Fischer 2020-10-04 5:14 ` Moritz Fischer 2020-10-04 18:47 ` Tom Rix 2020-10-04 18:47 ` Tom Rix 2020-10-04 23:39 ` Moritz Fischer 2020-10-04 23:39 ` Moritz Fischer 2020-11-03 7:14 [PATCH 00/10] Introduce devm_fpga_mgr_register() API Moritz Fischer 2020-11-03 7:14 ` [PATCH 03/10] fpga: fpga-mgr: dfl-fme-mgr: Simplify registration Moritz Fischer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201004234008.GB111357@epycbox.lan \ --to=mdf@kernel.org \ --cc=hao.wu@intel.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-fpga@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=matthew.gerlach@intel.com \ --cc=michal.simek@xilinx.com \ --cc=russell.h.weight@intel.com \ --cc=trix@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.