From: Jordan Crouse <jcrouse@codeaurora.org> To: Rob Clark <robdclark@gmail.com> Cc: dri-devel@lists.freedesktop.org, Rob Clark <robdclark@chromium.org>, "open list:DRM DRIVER FOR MSM ADRENO GPU" <freedreno@lists.freedesktop.org>, David Airlie <airlied@linux.ie>, "open list:DRM DRIVER FOR MSM ADRENO GPU" <linux-arm-msm@vger.kernel.org>, open list <linux-kernel@vger.kernel.org>, Daniel Vetter <daniel@ffwll.ch>, Sean Paul <sean@poorly.run> Subject: Re: [Freedreno] [PATCH 08/14] drm/msm: Remove obj->gpu Date: Mon, 5 Oct 2020 08:28:58 -0600 [thread overview] Message-ID: <20201005142858.GG4204@jcrouse1-lnx.qualcomm.com> (raw) In-Reply-To: <20201004192152.3298573-9-robdclark@gmail.com> On Sun, Oct 04, 2020 at 12:21:40PM -0700, Rob Clark wrote: > From: Rob Clark <robdclark@chromium.org> > > It cannot be atomically updated with obj->active_count, and the only > purpose is a useless WARN_ON() (which becomes a buggy WARN_ON() once > retire_submits() is not serialized with incoming submits via > struct_mutex) Somebody will prove me wrong but the longer we go without 2D the less likely it is that we'll ever see it. Reviewed-by: Jordan Crouse <jcrouse@codeaurora.org> > Signed-off-by: Rob Clark <robdclark@chromium.org> > --- > drivers/gpu/drm/msm/msm_gem.c | 2 -- > drivers/gpu/drm/msm/msm_gem.h | 1 - > drivers/gpu/drm/msm/msm_gpu.c | 5 ----- > 3 files changed, 8 deletions(-) > > diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c > index b04ed8b52f9d..c52a3969e60b 100644 > --- a/drivers/gpu/drm/msm/msm_gem.c > +++ b/drivers/gpu/drm/msm/msm_gem.c > @@ -753,7 +753,6 @@ void msm_gem_active_get(struct drm_gem_object *obj, struct msm_gpu *gpu) > > if (!atomic_fetch_inc(&msm_obj->active_count)) { > mutex_lock(&priv->mm_lock); > - msm_obj->gpu = gpu; > list_del_init(&msm_obj->mm_list); > list_add_tail(&msm_obj->mm_list, &gpu->active_list); > mutex_unlock(&priv->mm_lock); > @@ -769,7 +768,6 @@ void msm_gem_active_put(struct drm_gem_object *obj) > > if (!atomic_dec_return(&msm_obj->active_count)) { > mutex_lock(&priv->mm_lock); > - msm_obj->gpu = NULL; > list_del_init(&msm_obj->mm_list); > list_add_tail(&msm_obj->mm_list, &priv->inactive_list); > mutex_unlock(&priv->mm_lock); > diff --git a/drivers/gpu/drm/msm/msm_gem.h b/drivers/gpu/drm/msm/msm_gem.h > index e05b1530aca6..61147bd96b06 100644 > --- a/drivers/gpu/drm/msm/msm_gem.h > +++ b/drivers/gpu/drm/msm/msm_gem.h > @@ -64,7 +64,6 @@ struct msm_gem_object { > * > */ > struct list_head mm_list; > - struct msm_gpu *gpu; /* non-null if active */ > > /* Transiently in the process of submit ioctl, objects associated > * with the submit are on submit->bo_list.. this only lasts for > diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c > index fd3fc6f36ab1..c9ff19a75169 100644 > --- a/drivers/gpu/drm/msm/msm_gpu.c > +++ b/drivers/gpu/drm/msm/msm_gpu.c > @@ -800,11 +800,6 @@ void msm_gpu_submit(struct msm_gpu *gpu, struct msm_gem_submit *submit) > struct drm_gem_object *drm_obj = &msm_obj->base; > uint64_t iova; > > - /* can't happen yet.. but when we add 2d support we'll have > - * to deal w/ cross-ring synchronization: > - */ > - WARN_ON(is_active(msm_obj) && (msm_obj->gpu != gpu)); > - > /* submit takes a reference to the bo and iova until retired: */ > drm_gem_object_get(&msm_obj->base); > msm_gem_get_and_pin_iova(&msm_obj->base, submit->aspace, &iova); > -- > 2.26.2 > > _______________________________________________ > Freedreno mailing list > Freedreno@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/freedreno -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: Jordan Crouse <jcrouse@codeaurora.org> To: Rob Clark <robdclark@gmail.com> Cc: Rob Clark <robdclark@chromium.org>, David Airlie <airlied@linux.ie>, "open list:DRM DRIVER FOR MSM ADRENO GPU" <linux-arm-msm@vger.kernel.org>, open list <linux-kernel@vger.kernel.org>, dri-devel@lists.freedesktop.org, Sean Paul <sean@poorly.run>, "open list:DRM DRIVER FOR MSM ADRENO GPU" <freedreno@lists.freedesktop.org> Subject: Re: [Freedreno] [PATCH 08/14] drm/msm: Remove obj->gpu Date: Mon, 5 Oct 2020 08:28:58 -0600 [thread overview] Message-ID: <20201005142858.GG4204@jcrouse1-lnx.qualcomm.com> (raw) In-Reply-To: <20201004192152.3298573-9-robdclark@gmail.com> On Sun, Oct 04, 2020 at 12:21:40PM -0700, Rob Clark wrote: > From: Rob Clark <robdclark@chromium.org> > > It cannot be atomically updated with obj->active_count, and the only > purpose is a useless WARN_ON() (which becomes a buggy WARN_ON() once > retire_submits() is not serialized with incoming submits via > struct_mutex) Somebody will prove me wrong but the longer we go without 2D the less likely it is that we'll ever see it. Reviewed-by: Jordan Crouse <jcrouse@codeaurora.org> > Signed-off-by: Rob Clark <robdclark@chromium.org> > --- > drivers/gpu/drm/msm/msm_gem.c | 2 -- > drivers/gpu/drm/msm/msm_gem.h | 1 - > drivers/gpu/drm/msm/msm_gpu.c | 5 ----- > 3 files changed, 8 deletions(-) > > diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c > index b04ed8b52f9d..c52a3969e60b 100644 > --- a/drivers/gpu/drm/msm/msm_gem.c > +++ b/drivers/gpu/drm/msm/msm_gem.c > @@ -753,7 +753,6 @@ void msm_gem_active_get(struct drm_gem_object *obj, struct msm_gpu *gpu) > > if (!atomic_fetch_inc(&msm_obj->active_count)) { > mutex_lock(&priv->mm_lock); > - msm_obj->gpu = gpu; > list_del_init(&msm_obj->mm_list); > list_add_tail(&msm_obj->mm_list, &gpu->active_list); > mutex_unlock(&priv->mm_lock); > @@ -769,7 +768,6 @@ void msm_gem_active_put(struct drm_gem_object *obj) > > if (!atomic_dec_return(&msm_obj->active_count)) { > mutex_lock(&priv->mm_lock); > - msm_obj->gpu = NULL; > list_del_init(&msm_obj->mm_list); > list_add_tail(&msm_obj->mm_list, &priv->inactive_list); > mutex_unlock(&priv->mm_lock); > diff --git a/drivers/gpu/drm/msm/msm_gem.h b/drivers/gpu/drm/msm/msm_gem.h > index e05b1530aca6..61147bd96b06 100644 > --- a/drivers/gpu/drm/msm/msm_gem.h > +++ b/drivers/gpu/drm/msm/msm_gem.h > @@ -64,7 +64,6 @@ struct msm_gem_object { > * > */ > struct list_head mm_list; > - struct msm_gpu *gpu; /* non-null if active */ > > /* Transiently in the process of submit ioctl, objects associated > * with the submit are on submit->bo_list.. this only lasts for > diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c > index fd3fc6f36ab1..c9ff19a75169 100644 > --- a/drivers/gpu/drm/msm/msm_gpu.c > +++ b/drivers/gpu/drm/msm/msm_gpu.c > @@ -800,11 +800,6 @@ void msm_gpu_submit(struct msm_gpu *gpu, struct msm_gem_submit *submit) > struct drm_gem_object *drm_obj = &msm_obj->base; > uint64_t iova; > > - /* can't happen yet.. but when we add 2d support we'll have > - * to deal w/ cross-ring synchronization: > - */ > - WARN_ON(is_active(msm_obj) && (msm_obj->gpu != gpu)); > - > /* submit takes a reference to the bo and iova until retired: */ > drm_gem_object_get(&msm_obj->base); > msm_gem_get_and_pin_iova(&msm_obj->base, submit->aspace, &iova); > -- > 2.26.2 > > _______________________________________________ > Freedreno mailing list > Freedreno@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/freedreno -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-10-05 14:29 UTC|newest] Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-04 19:21 [PATCH 00/14] drm/msm: de-struct_mutex-ification Rob Clark 2020-10-04 19:21 ` Rob Clark 2020-10-04 19:21 ` [PATCH 01/14] drm/msm: Use correct drm_gem_object_put() in fail case Rob Clark 2020-10-04 19:21 ` Rob Clark 2020-10-04 19:21 ` [PATCH 02/14] drm/msm: Drop chatty trace Rob Clark 2020-10-04 19:21 ` Rob Clark 2020-10-05 14:15 ` [Freedreno] " Jordan Crouse 2020-10-05 14:15 ` Jordan Crouse 2020-10-04 19:21 ` [PATCH 03/14] drm/msm: Move update_fences() Rob Clark 2020-10-04 19:21 ` Rob Clark 2020-10-05 14:16 ` [Freedreno] " Jordan Crouse 2020-10-05 14:16 ` Jordan Crouse 2020-10-04 19:21 ` [PATCH 04/14] drm/msm: Add priv->mm_lock to protect active/inactive lists Rob Clark 2020-10-04 19:21 ` Rob Clark 2020-10-04 22:15 ` Daniel Vetter 2020-10-04 22:15 ` Daniel Vetter 2020-10-05 0:10 ` Rob Clark 2020-10-05 0:10 ` Rob Clark 2020-10-05 14:19 ` [Freedreno] " Jordan Crouse 2020-10-05 14:19 ` Jordan Crouse 2020-10-04 19:21 ` [PATCH 05/14] drm/msm: Document and rename preempt_lock Rob Clark 2020-10-04 19:21 ` Rob Clark 2020-10-05 14:22 ` Jordan Crouse 2020-10-05 14:22 ` Jordan Crouse 2020-10-04 19:21 ` [PATCH 06/14] drm/msm: Protect ring->submits with it's own lock Rob Clark 2020-10-04 19:21 ` Rob Clark 2020-10-05 14:23 ` [Freedreno] " Jordan Crouse 2020-10-05 14:23 ` Jordan Crouse 2020-10-04 19:21 ` [PATCH 07/14] drm/msm: Refcount submits Rob Clark 2020-10-04 19:21 ` Rob Clark 2020-10-05 13:56 ` Daniel Vetter 2020-10-05 13:56 ` Daniel Vetter 2020-10-05 16:24 ` Rob Clark 2020-10-05 16:24 ` Rob Clark 2020-10-05 14:27 ` [Freedreno] " Jordan Crouse 2020-10-05 14:27 ` Jordan Crouse 2020-10-04 19:21 ` [PATCH 08/14] drm/msm: Remove obj->gpu Rob Clark 2020-10-04 19:21 ` Rob Clark 2020-10-05 14:28 ` Jordan Crouse [this message] 2020-10-05 14:28 ` [Freedreno] " Jordan Crouse 2020-10-04 19:21 ` [PATCH 09/14] drm/msm: Drop struct_mutex from the retire path Rob Clark 2020-10-04 19:21 ` Rob Clark 2020-10-05 14:29 ` [Freedreno] " Jordan Crouse 2020-10-05 14:29 ` Jordan Crouse 2020-10-04 19:21 ` [PATCH 10/14] drm/msm: Drop struct_mutex in free_object() path Rob Clark 2020-10-04 19:21 ` Rob Clark 2020-10-04 19:21 ` [PATCH 11/14] drm/msm: remove msm_gem_free_work Rob Clark 2020-10-04 19:21 ` Rob Clark 2020-10-04 19:21 ` [PATCH 12/14] drm/msm: drop struct_mutex in madvise path Rob Clark 2020-10-04 19:21 ` Rob Clark 2020-10-04 19:21 ` [PATCH 13/14] drm/msm: Drop struct_mutex in shrinker path Rob Clark 2020-10-04 19:21 ` Rob Clark 2020-10-05 9:24 ` Hillf Danton 2020-10-05 14:02 ` Daniel Vetter 2020-10-05 14:02 ` Daniel Vetter 2020-10-05 16:17 ` Kristian Høgsberg 2020-10-05 16:17 ` Kristian Høgsberg 2020-10-06 0:44 ` Hillf Danton 2020-10-06 3:40 ` Rob Clark 2020-10-06 3:40 ` Rob Clark 2020-10-06 8:24 ` Hillf Danton 2020-10-06 9:35 ` Daniel Vetter 2020-10-06 9:35 ` Daniel Vetter 2020-10-05 16:49 ` Rob Clark 2020-10-05 16:49 ` Rob Clark 2020-10-05 18:18 ` Daniel Vetter 2020-10-05 18:18 ` Daniel Vetter 2020-10-04 19:21 ` [PATCH 14/14] drm/msm: Don't implicit-sync if only a single ring Rob Clark 2020-10-04 19:21 ` Rob Clark 2020-10-05 16:24 ` [Freedreno] [PATCH 00/14] drm/msm: de-struct_mutex-ification Kristian Høgsberg 2020-10-05 16:24 ` Kristian Høgsberg 2020-10-05 18:20 ` Daniel Vetter 2020-10-05 18:20 ` Daniel Vetter 2020-10-06 3:25 ` Rob Clark 2020-10-06 3:25 ` Rob Clark
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201005142858.GG4204@jcrouse1-lnx.qualcomm.com \ --to=jcrouse@codeaurora.org \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robdclark@chromium.org \ --cc=robdclark@gmail.com \ --cc=sean@poorly.run \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.