From: Greg KH <greg@kroah.com>
To: Joel Stanley <joel@jms.id.au>
Cc: Ryan Chen <ryan_chen@aspeedtech.com>,
Andrew Jeffery <andrew@aj.id.au>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-usb@vger.kernel.org, BMC-SW <bmc-sw@aspeedtech.com>,
Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig
Date: Fri, 9 Oct 2020 07:46:50 +0200 [thread overview]
Message-ID: <20201009054650.GA117723@kroah.com> (raw)
In-Reply-To: <CACPK8Xd0h_2yGeyOjrpqV2_X8f4stZA_ur72b4Y4Nx91GrbXag@mail.gmail.com>
On Fri, Oct 09, 2020 at 04:55:19AM +0000, Joel Stanley wrote:
> On Fri, 9 Oct 2020 at 04:45, Greg KH <greg@kroah.com> wrote:
> >
> > On Fri, Oct 09, 2020 at 10:49:35AM +0800, Ryan Chen wrote:
> > > v2:
> > > -Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support.
> > > v1:
> > > -Enable UHCI driver in aspeed_g5_defconfig.
> > >
> > > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com>
> >
> > Why do you need this in a defconfig?
>
> I would prefer configurations that are being used to be present in the
> defconfig so we can test it. I think this is a sensible change.
Then it needs to be described in the changelog, otherwise we have no
idea why this is happening :)
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Joel Stanley <joel@jms.id.au>
Cc: BMC-SW <bmc-sw@aspeedtech.com>,
Ryan Chen <ryan_chen@aspeedtech.com>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>,
Andrew Jeffery <andrew@aj.id.au>,
linux-usb@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Alan Stern <stern@rowland.harvard.edu>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig
Date: Fri, 9 Oct 2020 07:46:50 +0200 [thread overview]
Message-ID: <20201009054650.GA117723@kroah.com> (raw)
In-Reply-To: <CACPK8Xd0h_2yGeyOjrpqV2_X8f4stZA_ur72b4Y4Nx91GrbXag@mail.gmail.com>
On Fri, Oct 09, 2020 at 04:55:19AM +0000, Joel Stanley wrote:
> On Fri, 9 Oct 2020 at 04:45, Greg KH <greg@kroah.com> wrote:
> >
> > On Fri, Oct 09, 2020 at 10:49:35AM +0800, Ryan Chen wrote:
> > > v2:
> > > -Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support.
> > > v1:
> > > -Enable UHCI driver in aspeed_g5_defconfig.
> > >
> > > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com>
> >
> > Why do you need this in a defconfig?
>
> I would prefer configurations that are being used to be present in the
> defconfig so we can test it. I think this is a sensible change.
Then it needs to be described in the changelog, otherwise we have no
idea why this is happening :)
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-09 5:46 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 4:08 [PATCH 0/3] Enable USB host for AST2600 Ryan Chen
2020-09-30 4:08 ` Ryan Chen
2020-09-30 4:08 ` [PATCH 1/3] configs: aspeed: enable UHCI driver in defconfig Ryan Chen
2020-09-30 4:08 ` Ryan Chen
2020-09-30 16:50 ` Tao Ren
2020-09-30 16:50 ` Tao Ren
2020-10-07 11:22 ` Joel Stanley
2020-10-07 11:22 ` Joel Stanley
2020-09-30 4:08 ` [PATCH 2/3] usb: host: add uhci compatible support for ast2600-uhci Ryan Chen
2020-09-30 4:08 ` Ryan Chen
2020-09-30 16:52 ` Tao Ren
2020-09-30 16:52 ` Tao Ren
2020-10-07 11:25 ` Joel Stanley
2020-10-07 11:25 ` Joel Stanley
2020-10-07 14:58 ` Alan Stern
2020-10-07 14:58 ` Alan Stern
2020-09-30 4:08 ` [PATCH 3/3] ARM: dts: add ehci uhci enable in evb dts Ryan Chen
2020-09-30 4:08 ` Ryan Chen
2020-09-30 16:54 ` Tao Ren
2020-09-30 16:54 ` Tao Ren
2020-10-07 11:27 ` Joel Stanley
2020-10-07 11:27 ` Joel Stanley
2020-10-09 2:49 ` [PATCH v2 0/3] Enable USB host for AST2600 Ryan Chen
2020-10-09 2:49 ` Ryan Chen
2020-10-09 2:49 ` [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig Ryan Chen
2020-10-09 2:49 ` Ryan Chen
2020-10-09 4:45 ` Greg KH
2020-10-09 4:45 ` Greg KH
2020-10-09 4:55 ` Joel Stanley
2020-10-09 4:55 ` Joel Stanley
2020-10-09 5:46 ` Greg KH [this message]
2020-10-09 5:46 ` Greg KH
2020-10-09 5:59 ` Ryan Chen
2020-10-09 5:59 ` Ryan Chen
2020-10-09 6:01 ` Ryan Chen
2020-10-09 6:01 ` Ryan Chen
2020-10-09 2:49 ` [PATCH v2 2/3] usb: host: add uhci compatible support for ast2600-uhci Ryan Chen
2020-10-09 2:49 ` Ryan Chen
2020-10-09 4:45 ` Greg KH
2020-10-09 4:45 ` Greg KH
2020-10-09 2:49 ` [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dts Ryan Chen
2020-10-09 2:49 ` Ryan Chen
2020-10-09 8:22 ` Sergei Shtylyov
2020-10-09 8:22 ` Sergei Shtylyov
2020-10-12 0:43 ` Ryan Chen
2020-10-12 0:43 ` Ryan Chen
2020-10-21 23:44 ` Andrew Jeffery
2020-10-21 23:44 ` Andrew Jeffery
2020-10-22 7:21 ` Ryan Chen
2020-10-22 7:21 ` Ryan Chen
2020-10-07 5:45 ` [PATCH 0/3] Enable USB host for AST2600 Ryan Chen
2020-10-07 5:45 ` Ryan Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201009054650.GA117723@kroah.com \
--to=greg@kroah.com \
--cc=andrew@aj.id.au \
--cc=bmc-sw@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ryan_chen@aspeedtech.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.