From: Alan Stern <stern@rowland.harvard.edu>
To: Joel Stanley <joel@jms.id.au>
Cc: Ryan Chen <ryan_chen@aspeedtech.com>,
Andrew Jeffery <andrew@aj.id.au>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-usb@vger.kernel.org, bmc-sw@aspeedtech.com
Subject: Re: [PATCH 2/3] usb: host: add uhci compatible support for ast2600-uhci
Date: Wed, 7 Oct 2020 10:58:09 -0400 [thread overview]
Message-ID: <20201007145809.GA456169@rowland.harvard.edu> (raw)
In-Reply-To: <CACPK8Xc2Y1njgtrtjO1bdmkcQR7jDu+oaOBc3R+CWtn+UrEOhQ@mail.gmail.com>
On Wed, Oct 07, 2020 at 11:25:04AM +0000, Joel Stanley wrote:
> On Wed, 30 Sep 2020 at 04:08, Ryan Chen <ryan_chen@aspeedtech.com> wrote:
> >
> > Add support for AST2600 SOC UHCI driver.
> >
> > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com>
>
> Reviewed-by: Joel Stanley <joel@jms.id.au>
>
> USB maintainers, can you please take this patch (2/3)? I will take the
> others in this series through the aspeed tree.
>
> Cheers,
>
> Joel
>
>
> > ---
> > drivers/usb/host/uhci-platform.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/host/uhci-platform.c b/drivers/usb/host/uhci-platform.c
> > index 70dbd95c3f06..fa40fe125c2a 100644
> > --- a/drivers/usb/host/uhci-platform.c
> > +++ b/drivers/usb/host/uhci-platform.c
> > @@ -113,7 +113,8 @@ static int uhci_hcd_platform_probe(struct platform_device *pdev)
> > num_ports);
> > }
> > if (of_device_is_compatible(np, "aspeed,ast2400-uhci") ||
> > - of_device_is_compatible(np, "aspeed,ast2500-uhci")) {
> > + of_device_is_compatible(np, "aspeed,ast2500-uhci") ||
> > + of_device_is_compatible(np, "aspeed,ast2600-uhci")) {
> > uhci->is_aspeed = 1;
> > dev_info(&pdev->dev,
> > "Enabled Aspeed implementation workarounds\n");
> > --
> > 2.17.1
> >
The indentation of the continuation lines isn't good, because the
continued parts are aligned with the lines in the conditional block.
They should be visually distinct. Either align with the "of_device..."
at the start or indent by two extra tab stops.
Once this is fixed, you can add:
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Alan Stern
WARNING: multiple messages have this Message-ID (diff)
From: Alan Stern <stern@rowland.harvard.edu>
To: Joel Stanley <joel@jms.id.au>
Cc: bmc-sw@aspeedtech.com, Ryan Chen <ryan_chen@aspeedtech.com>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>,
Andrew Jeffery <andrew@aj.id.au>,
linux-usb@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/3] usb: host: add uhci compatible support for ast2600-uhci
Date: Wed, 7 Oct 2020 10:58:09 -0400 [thread overview]
Message-ID: <20201007145809.GA456169@rowland.harvard.edu> (raw)
In-Reply-To: <CACPK8Xc2Y1njgtrtjO1bdmkcQR7jDu+oaOBc3R+CWtn+UrEOhQ@mail.gmail.com>
On Wed, Oct 07, 2020 at 11:25:04AM +0000, Joel Stanley wrote:
> On Wed, 30 Sep 2020 at 04:08, Ryan Chen <ryan_chen@aspeedtech.com> wrote:
> >
> > Add support for AST2600 SOC UHCI driver.
> >
> > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com>
>
> Reviewed-by: Joel Stanley <joel@jms.id.au>
>
> USB maintainers, can you please take this patch (2/3)? I will take the
> others in this series through the aspeed tree.
>
> Cheers,
>
> Joel
>
>
> > ---
> > drivers/usb/host/uhci-platform.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/host/uhci-platform.c b/drivers/usb/host/uhci-platform.c
> > index 70dbd95c3f06..fa40fe125c2a 100644
> > --- a/drivers/usb/host/uhci-platform.c
> > +++ b/drivers/usb/host/uhci-platform.c
> > @@ -113,7 +113,8 @@ static int uhci_hcd_platform_probe(struct platform_device *pdev)
> > num_ports);
> > }
> > if (of_device_is_compatible(np, "aspeed,ast2400-uhci") ||
> > - of_device_is_compatible(np, "aspeed,ast2500-uhci")) {
> > + of_device_is_compatible(np, "aspeed,ast2500-uhci") ||
> > + of_device_is_compatible(np, "aspeed,ast2600-uhci")) {
> > uhci->is_aspeed = 1;
> > dev_info(&pdev->dev,
> > "Enabled Aspeed implementation workarounds\n");
> > --
> > 2.17.1
> >
The indentation of the continuation lines isn't good, because the
continued parts are aligned with the lines in the conditional block.
They should be visually distinct. Either align with the "of_device..."
at the start or indent by two extra tab stops.
Once this is fixed, you can add:
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Alan Stern
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-07 14:58 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 4:08 [PATCH 0/3] Enable USB host for AST2600 Ryan Chen
2020-09-30 4:08 ` Ryan Chen
2020-09-30 4:08 ` [PATCH 1/3] configs: aspeed: enable UHCI driver in defconfig Ryan Chen
2020-09-30 4:08 ` Ryan Chen
2020-09-30 16:50 ` Tao Ren
2020-09-30 16:50 ` Tao Ren
2020-10-07 11:22 ` Joel Stanley
2020-10-07 11:22 ` Joel Stanley
2020-09-30 4:08 ` [PATCH 2/3] usb: host: add uhci compatible support for ast2600-uhci Ryan Chen
2020-09-30 4:08 ` Ryan Chen
2020-09-30 16:52 ` Tao Ren
2020-09-30 16:52 ` Tao Ren
2020-10-07 11:25 ` Joel Stanley
2020-10-07 11:25 ` Joel Stanley
2020-10-07 14:58 ` Alan Stern [this message]
2020-10-07 14:58 ` Alan Stern
2020-09-30 4:08 ` [PATCH 3/3] ARM: dts: add ehci uhci enable in evb dts Ryan Chen
2020-09-30 4:08 ` Ryan Chen
2020-09-30 16:54 ` Tao Ren
2020-09-30 16:54 ` Tao Ren
2020-10-07 11:27 ` Joel Stanley
2020-10-07 11:27 ` Joel Stanley
2020-10-09 2:49 ` [PATCH v2 0/3] Enable USB host for AST2600 Ryan Chen
2020-10-09 2:49 ` Ryan Chen
2020-10-09 2:49 ` [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig Ryan Chen
2020-10-09 2:49 ` Ryan Chen
2020-10-09 4:45 ` Greg KH
2020-10-09 4:45 ` Greg KH
2020-10-09 4:55 ` Joel Stanley
2020-10-09 4:55 ` Joel Stanley
2020-10-09 5:46 ` Greg KH
2020-10-09 5:46 ` Greg KH
2020-10-09 5:59 ` Ryan Chen
2020-10-09 5:59 ` Ryan Chen
2020-10-09 6:01 ` Ryan Chen
2020-10-09 6:01 ` Ryan Chen
2020-10-09 2:49 ` [PATCH v2 2/3] usb: host: add uhci compatible support for ast2600-uhci Ryan Chen
2020-10-09 2:49 ` Ryan Chen
2020-10-09 4:45 ` Greg KH
2020-10-09 4:45 ` Greg KH
2020-10-09 2:49 ` [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dts Ryan Chen
2020-10-09 2:49 ` Ryan Chen
2020-10-09 8:22 ` Sergei Shtylyov
2020-10-09 8:22 ` Sergei Shtylyov
2020-10-12 0:43 ` Ryan Chen
2020-10-12 0:43 ` Ryan Chen
2020-10-21 23:44 ` Andrew Jeffery
2020-10-21 23:44 ` Andrew Jeffery
2020-10-22 7:21 ` Ryan Chen
2020-10-22 7:21 ` Ryan Chen
2020-10-07 5:45 ` [PATCH 0/3] Enable USB host for AST2600 Ryan Chen
2020-10-07 5:45 ` Ryan Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201007145809.GA456169@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=andrew@aj.id.au \
--cc=bmc-sw@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ryan_chen@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.