From: Hoegeun Kwon <hoegeun.kwon@samsung.com>
To: maxime@cerno.tech, eric@anholt.net, airlied@linux.ie,
daniel@ffwll.ch, robh+dt@kernel.org
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
dave.stevenson@raspberrypi.com, sungguk.na@samsung.com,
hoegeun.kwon@samsung.com
Subject: [PATCH 0/1] drm/vc4: drv: Add error handding for bind
Date: Tue, 27 Oct 2020 13:14:41 +0900 [thread overview]
Message-ID: <20201027041442.30352-1-hoegeun.kwon@samsung.com> (raw)
In-Reply-To: CGME20201027041534epcas1p22f6b232a4d6be92dcc807f28baedab44@epcas1p2.samsung.com
Hello all,
There is a problem that if vc4_drm bind fails, a memory leak occurs on
the drm_property_create side as shown below. Add error handding for
drm_mode_config.
unreferenced object 0xffffff80f5a7a6c8 (size 576):
comm "swapper/0", pid 1, jiffies 4294892559 (age 181.448s)
hex dump (first 32 bytes):
00 00 1e 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
f8 f1 0e f5 80 ff ff ff e0 a6 a7 f5 80 ff ff ff ................
backtrace:
[<00000000fd3656dc>] kmem_cache_alloc+0x1a4/0x328
[<000000009dfa1aab>] radix_tree_node_alloc.constprop.19+0x50/0x108
[<00000000a9f1657b>] idr_get_free+0x21c/0x2b8
[<0000000099f2eea6>] idr_alloc_u32+0x68/0xf0
[<00000000525beb52>] idr_alloc+0x44/0x80
[<00000000dbfbaa4b>] __drm_mode_object_add+0x64/0xc0
[<000000002c24dfc8>] drm_mode_object_add+0x3c/0x50
[<00000000f45b491f>] drm_property_create+0xf0/0x1a0
[<000000002e1a296b>] drm_connector_create_standard_properties+0x30/0x130
[<000000007c53e4bd>] drm_mode_config_init+0x138/0x498
[<00000000cc1b0767>] vc4_drm_bind+0x168/0x1f8
[<0000000041d69f98>] try_to_bring_up_master+0x180/0x1e8
[<00000000d1e1caae>] component_master_add_with_match+0xbc/0x108
[<0000000085cea46d>] vc4_platform_drm_probe+0xd8/0x108
[<00000000eacabf20>] platform_drv_probe+0x58/0xa8
[<000000003822d094>] really_probe+0x10c/0x350
Best regards,
Hoegeun
Hoegeun Kwon (1):
drm/vc4: drv: Add error handding for bind
drivers/gpu/drm/vc4/vc4_drv.c | 1 +
1 file changed, 1 insertion(+)
--
2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Hoegeun Kwon <hoegeun.kwon@samsung.com>
To: maxime@cerno.tech, eric@anholt.net, airlied@linux.ie,
daniel@ffwll.ch, robh+dt@kernel.org
Cc: devicetree@vger.kernel.org, sungguk.na@samsung.com,
dave.stevenson@raspberrypi.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org, hoegeun.kwon@samsung.com,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/1] drm/vc4: drv: Add error handding for bind
Date: Tue, 27 Oct 2020 13:14:41 +0900 [thread overview]
Message-ID: <20201027041442.30352-1-hoegeun.kwon@samsung.com> (raw)
In-Reply-To: CGME20201027041534epcas1p22f6b232a4d6be92dcc807f28baedab44@epcas1p2.samsung.com
Hello all,
There is a problem that if vc4_drm bind fails, a memory leak occurs on
the drm_property_create side as shown below. Add error handding for
drm_mode_config.
unreferenced object 0xffffff80f5a7a6c8 (size 576):
comm "swapper/0", pid 1, jiffies 4294892559 (age 181.448s)
hex dump (first 32 bytes):
00 00 1e 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
f8 f1 0e f5 80 ff ff ff e0 a6 a7 f5 80 ff ff ff ................
backtrace:
[<00000000fd3656dc>] kmem_cache_alloc+0x1a4/0x328
[<000000009dfa1aab>] radix_tree_node_alloc.constprop.19+0x50/0x108
[<00000000a9f1657b>] idr_get_free+0x21c/0x2b8
[<0000000099f2eea6>] idr_alloc_u32+0x68/0xf0
[<00000000525beb52>] idr_alloc+0x44/0x80
[<00000000dbfbaa4b>] __drm_mode_object_add+0x64/0xc0
[<000000002c24dfc8>] drm_mode_object_add+0x3c/0x50
[<00000000f45b491f>] drm_property_create+0xf0/0x1a0
[<000000002e1a296b>] drm_connector_create_standard_properties+0x30/0x130
[<000000007c53e4bd>] drm_mode_config_init+0x138/0x498
[<00000000cc1b0767>] vc4_drm_bind+0x168/0x1f8
[<0000000041d69f98>] try_to_bring_up_master+0x180/0x1e8
[<00000000d1e1caae>] component_master_add_with_match+0xbc/0x108
[<0000000085cea46d>] vc4_platform_drm_probe+0xd8/0x108
[<00000000eacabf20>] platform_drv_probe+0x58/0xa8
[<000000003822d094>] really_probe+0x10c/0x350
Best regards,
Hoegeun
Hoegeun Kwon (1):
drm/vc4: drv: Add error handding for bind
drivers/gpu/drm/vc4/vc4_drv.c | 1 +
1 file changed, 1 insertion(+)
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Hoegeun Kwon <hoegeun.kwon@samsung.com>
To: maxime@cerno.tech, eric@anholt.net, airlied@linux.ie,
daniel@ffwll.ch, robh+dt@kernel.org
Cc: devicetree@vger.kernel.org, sungguk.na@samsung.com,
dave.stevenson@raspberrypi.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org, hoegeun.kwon@samsung.com,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/1] drm/vc4: drv: Add error handding for bind
Date: Tue, 27 Oct 2020 13:14:41 +0900 [thread overview]
Message-ID: <20201027041442.30352-1-hoegeun.kwon@samsung.com> (raw)
In-Reply-To: CGME20201027041534epcas1p22f6b232a4d6be92dcc807f28baedab44@epcas1p2.samsung.com
Hello all,
There is a problem that if vc4_drm bind fails, a memory leak occurs on
the drm_property_create side as shown below. Add error handding for
drm_mode_config.
unreferenced object 0xffffff80f5a7a6c8 (size 576):
comm "swapper/0", pid 1, jiffies 4294892559 (age 181.448s)
hex dump (first 32 bytes):
00 00 1e 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
f8 f1 0e f5 80 ff ff ff e0 a6 a7 f5 80 ff ff ff ................
backtrace:
[<00000000fd3656dc>] kmem_cache_alloc+0x1a4/0x328
[<000000009dfa1aab>] radix_tree_node_alloc.constprop.19+0x50/0x108
[<00000000a9f1657b>] idr_get_free+0x21c/0x2b8
[<0000000099f2eea6>] idr_alloc_u32+0x68/0xf0
[<00000000525beb52>] idr_alloc+0x44/0x80
[<00000000dbfbaa4b>] __drm_mode_object_add+0x64/0xc0
[<000000002c24dfc8>] drm_mode_object_add+0x3c/0x50
[<00000000f45b491f>] drm_property_create+0xf0/0x1a0
[<000000002e1a296b>] drm_connector_create_standard_properties+0x30/0x130
[<000000007c53e4bd>] drm_mode_config_init+0x138/0x498
[<00000000cc1b0767>] vc4_drm_bind+0x168/0x1f8
[<0000000041d69f98>] try_to_bring_up_master+0x180/0x1e8
[<00000000d1e1caae>] component_master_add_with_match+0xbc/0x108
[<0000000085cea46d>] vc4_platform_drm_probe+0xd8/0x108
[<00000000eacabf20>] platform_drv_probe+0x58/0xa8
[<000000003822d094>] really_probe+0x10c/0x350
Best regards,
Hoegeun
Hoegeun Kwon (1):
drm/vc4: drv: Add error handding for bind
drivers/gpu/drm/vc4/vc4_drv.c | 1 +
1 file changed, 1 insertion(+)
--
2.17.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next parent reply other threads:[~2020-10-27 4:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20201027041534epcas1p22f6b232a4d6be92dcc807f28baedab44@epcas1p2.samsung.com>
2020-10-27 4:14 ` Hoegeun Kwon [this message]
2020-10-27 4:14 ` [PATCH 0/1] drm/vc4: drv: Add error handding for bind Hoegeun Kwon
2020-10-27 4:14 ` Hoegeun Kwon
[not found] ` <CGME20201027041535epcas1p489bbfe80b461f1e5c5deca1a571f1f35@epcas1p4.samsung.com>
2020-10-27 4:14 ` [PATCH 1/1] " Hoegeun Kwon
2020-10-27 4:14 ` Hoegeun Kwon
2020-10-27 4:14 ` Hoegeun Kwon
2020-10-27 14:54 ` Maxime Ripard
2020-10-27 14:54 ` Maxime Ripard
2020-10-27 14:54 ` Maxime Ripard
2020-10-28 11:29 ` Daniel Vetter
2020-10-28 11:29 ` Daniel Vetter
2020-10-28 11:29 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027041442.30352-1-hoegeun.kwon@samsung.com \
--to=hoegeun.kwon@samsung.com \
--cc=airlied@linux.ie \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=daniel@ffwll.ch \
--cc=dave.stevenson@raspberrypi.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=maxime@cerno.tech \
--cc=robh+dt@kernel.org \
--cc=sungguk.na@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.