All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Gloria Tsai <Gloria.Tsai@ssstc.com>
Cc: Jongpil Jung <jongpuls@gmail.com>,
	Sagi Grimberg <sagi@grimberg.me>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	Jens Axboe <axboe@fb.com>,
	"dj54.sohn@samsung.com" <dj54.sohn@samsung.com>,
	"jongpil19.jung@samsung.com" <jongpil19.jung@samsung.com>,
	"jongheony.kim@samsung.com" <jongheony.kim@samsung.com>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH V3 1/1] nvme: Add quirk for LiteON CL1 devices running FW 220TQ,22001
Date: Thu, 29 Oct 2020 12:15:21 +0900	[thread overview]
Message-ID: <20201029031521.GC20928@redsun51.ssa.fujisawa.hgst.com> (raw)
In-Reply-To: <20201029023306.GB20928@redsun51.ssa.fujisawa.hgst.com>

On Thu, Oct 29, 2020 at 11:33:06AM +0900, Keith Busch wrote:
> On Thu, Oct 29, 2020 at 02:20:27AM +0000, Gloria Tsai wrote:
> > Corrected the description of this bug that SSD will not do GC after receiving shutdown cmd.
> > Do GC before shutdown -> delete IO Q -> shutdown from host -> breakup GC -> D3hot -> enter PS4 -> have a chance swap block -> use wrong pointer on device SRAM -> over program
> 
> What do you mean by "wrong pointer"? At the place in the sequence you're
> referring to, the PCI BME is disabled: you can't access *any* host RAM,
> so there's no "correct" pointer either.

Re-reading your message, I do see you said "device" rather than "host",
so my response may not be relevant.

WARNING: multiple messages have this Message-ID (diff)
From: Keith Busch <kbusch@kernel.org>
To: Gloria Tsai <Gloria.Tsai@ssstc.com>
Cc: Jongpil Jung <jongpuls@gmail.com>,
	Sagi Grimberg <sagi@grimberg.me>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	Jens Axboe <axboe@fb.com>,
	"dj54.sohn@samsung.com" <dj54.sohn@samsung.com>,
	"jongpil19.jung@samsung.com" <jongpil19.jung@samsung.com>,
	"jongheony.kim@samsung.com" <jongheony.kim@samsung.com>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH V3 1/1] nvme: Add quirk for LiteON CL1 devices running FW 220TQ,22001
Date: Thu, 29 Oct 2020 12:15:21 +0900	[thread overview]
Message-ID: <20201029031521.GC20928@redsun51.ssa.fujisawa.hgst.com> (raw)
In-Reply-To: <20201029023306.GB20928@redsun51.ssa.fujisawa.hgst.com>

On Thu, Oct 29, 2020 at 11:33:06AM +0900, Keith Busch wrote:
> On Thu, Oct 29, 2020 at 02:20:27AM +0000, Gloria Tsai wrote:
> > Corrected the description of this bug that SSD will not do GC after receiving shutdown cmd.
> > Do GC before shutdown -> delete IO Q -> shutdown from host -> breakup GC -> D3hot -> enter PS4 -> have a chance swap block -> use wrong pointer on device SRAM -> over program
> 
> What do you mean by "wrong pointer"? At the place in the sequence you're
> referring to, the PCI BME is disabled: you can't access *any* host RAM,
> so there's no "correct" pointer either.

Re-reading your message, I do see you said "device" rather than "host",
so my response may not be relevant.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2020-10-29  8:03 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-28  9:14 [PATCH V3 1/1] nvme: Add quirk for LiteON CL1 devices running FW 220TQ,22001 Jongpil Jung
2020-10-28  9:14 ` Jongpil Jung
2020-10-28 17:17 ` Christoph Hellwig
2020-10-28 17:17   ` Christoph Hellwig
2020-10-29  2:20   ` Gloria Tsai
2020-10-29  2:20     ` Gloria Tsai
2020-10-29  2:33     ` Keith Busch
2020-10-29  2:33       ` Keith Busch
2020-10-29  3:15       ` Keith Busch [this message]
2020-10-29  3:15         ` Keith Busch
2020-10-29  3:21         ` Gloria Tsai
2020-10-29  3:21           ` Gloria Tsai
2020-10-29 14:55 ` Christoph Hellwig
2020-10-29 14:55   ` Christoph Hellwig
2020-11-02 18:13   ` Christoph Hellwig
2020-11-02 18:13     ` Christoph Hellwig
2020-11-03  2:21     ` Gloria Tsai
2020-11-03  2:21       ` Gloria Tsai
2020-11-03  9:23       ` Christoph Hellwig
2020-11-03  9:23         ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201029031521.GC20928@redsun51.ssa.fujisawa.hgst.com \
    --to=kbusch@kernel.org \
    --cc=Gloria.Tsai@ssstc.com \
    --cc=axboe@fb.com \
    --cc=dj54.sohn@samsung.com \
    --cc=hch@lst.de \
    --cc=jongheony.kim@samsung.com \
    --cc=jongpil19.jung@samsung.com \
    --cc=jongpuls@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.