From: Gloria Tsai <Gloria.Tsai@ssstc.com>
To: Christoph Hellwig <hch@lst.de>, Jongpil Jung <jongpuls@gmail.com>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Sagi Grimberg <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jongpil19.jung@samsung.com" <jongpil19.jung@samsung.com>,
"jongheony.kim@samsung.com" <jongheony.kim@samsung.com>,
"dj54.sohn@samsung.com" <dj54.sohn@samsung.com>
Subject: RE: [PATCH V3 1/1] nvme: Add quirk for LiteON CL1 devices running FW 220TQ,22001
Date: Thu, 29 Oct 2020 02:20:27 +0000 [thread overview]
Message-ID: <HK2PR02MB4004EC30D14A16B59FD22A44EE140@HK2PR02MB4004.apcprd02.prod.outlook.com> (raw)
In-Reply-To: <20201028171726.GA9897@lst.de>
Corrected the description of this bug that SSD will not do GC after receiving shutdown cmd.
Do GC before shutdown -> delete IO Q -> shutdown from host -> breakup GC -> D3hot -> enter PS4 -> have a chance swap block -> use wrong pointer on device SRAM -> over program
SSD gets in low power mode only in suspend, this issue only happens in low power mode.
As for Hibernate, power off, unbinding the driver or even warm boot, EC boot, SSD won't be in low power state, so there'll be no problem.
Regards,
Gloria Tsai
_____________________________________
Sales PM Division
Solid State Storage Technology Corporation
TEL: +886-3-612-3888 ext. 2201
E-Mail: gloria.tsai@ssstc.com
_____________________________________
-----Original Message-----
From: Christoph Hellwig <hch@lst.de>
Sent: Thursday, October 29, 2020 1:17 AM
To: Jongpil Jung <jongpuls@gmail.com>
Cc: Keith Busch <kbusch@kernel.org>; Jens Axboe <axboe@fb.com>; Christoph Hellwig <hch@lst.de>; Sagi Grimberg <sagi@grimberg.me>; linux-nvme@lists.infradead.org; linux-kernel@vger.kernel.org; Gloria Tsai <Gloria.Tsai@ssstc.com>; jongpil19.jung@samsung.com; jongheony.kim@samsung.com; dj54.sohn@samsung.com
Subject: Re: [PATCH V3 1/1] nvme: Add quirk for LiteON CL1 devices running FW 220TQ,22001
This message was sent from outside of the company. Please do not click links or open attachments unless you recognize the source of this email and know the content is safe.
On Wed, Oct 28, 2020 at 06:14:21PM +0900, Jongpil Jung wrote:
> LiteON(SSSTC) CL1 device running FW 220TQ,22001 has bugs with simple
> suspend.
>
> When NVMe device receive D3hot from host, NVMe firmware will do
> garbage collection. While NVMe device do Garbage collection, firmware
> has chance to going incorrect address.
I'm still lost on what this means. The device doesn't receive 'D3hot'
from the host, it receives a shutdown request. And we don't just do that when hibernating, but also when doing an actual shutdown, a suspend to disk, unbinding the driver, etc. So if the device has a problem with shutdowns we really are in trouble.
WARNING: multiple messages have this Message-ID (diff)
From: Gloria Tsai <Gloria.Tsai@ssstc.com>
To: Christoph Hellwig <hch@lst.de>, Jongpil Jung <jongpuls@gmail.com>
Cc: Sagi Grimberg <sagi@grimberg.me>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Jens Axboe <axboe@fb.com>,
"jongpil19.jung@samsung.com" <jongpil19.jung@samsung.com>,
"dj54.sohn@samsung.com" <dj54.sohn@samsung.com>,
Keith Busch <kbusch@kernel.org>,
"jongheony.kim@samsung.com" <jongheony.kim@samsung.com>
Subject: RE: [PATCH V3 1/1] nvme: Add quirk for LiteON CL1 devices running FW 220TQ,22001
Date: Thu, 29 Oct 2020 02:20:27 +0000 [thread overview]
Message-ID: <HK2PR02MB4004EC30D14A16B59FD22A44EE140@HK2PR02MB4004.apcprd02.prod.outlook.com> (raw)
In-Reply-To: <20201028171726.GA9897@lst.de>
Corrected the description of this bug that SSD will not do GC after receiving shutdown cmd.
Do GC before shutdown -> delete IO Q -> shutdown from host -> breakup GC -> D3hot -> enter PS4 -> have a chance swap block -> use wrong pointer on device SRAM -> over program
SSD gets in low power mode only in suspend, this issue only happens in low power mode.
As for Hibernate, power off, unbinding the driver or even warm boot, EC boot, SSD won't be in low power state, so there'll be no problem.
Regards,
Gloria Tsai
_____________________________________
Sales PM Division
Solid State Storage Technology Corporation
TEL: +886-3-612-3888 ext. 2201
E-Mail: gloria.tsai@ssstc.com
_____________________________________
-----Original Message-----
From: Christoph Hellwig <hch@lst.de>
Sent: Thursday, October 29, 2020 1:17 AM
To: Jongpil Jung <jongpuls@gmail.com>
Cc: Keith Busch <kbusch@kernel.org>; Jens Axboe <axboe@fb.com>; Christoph Hellwig <hch@lst.de>; Sagi Grimberg <sagi@grimberg.me>; linux-nvme@lists.infradead.org; linux-kernel@vger.kernel.org; Gloria Tsai <Gloria.Tsai@ssstc.com>; jongpil19.jung@samsung.com; jongheony.kim@samsung.com; dj54.sohn@samsung.com
Subject: Re: [PATCH V3 1/1] nvme: Add quirk for LiteON CL1 devices running FW 220TQ,22001
This message was sent from outside of the company. Please do not click links or open attachments unless you recognize the source of this email and know the content is safe.
On Wed, Oct 28, 2020 at 06:14:21PM +0900, Jongpil Jung wrote:
> LiteON(SSSTC) CL1 device running FW 220TQ,22001 has bugs with simple
> suspend.
>
> When NVMe device receive D3hot from host, NVMe firmware will do
> garbage collection. While NVMe device do Garbage collection, firmware
> has chance to going incorrect address.
I'm still lost on what this means. The device doesn't receive 'D3hot'
from the host, it receives a shutdown request. And we don't just do that when hibernating, but also when doing an actual shutdown, a suspend to disk, unbinding the driver, etc. So if the device has a problem with shutdowns we really are in trouble.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-10-29 2:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 9:14 [PATCH V3 1/1] nvme: Add quirk for LiteON CL1 devices running FW 220TQ,22001 Jongpil Jung
2020-10-28 9:14 ` Jongpil Jung
2020-10-28 17:17 ` Christoph Hellwig
2020-10-28 17:17 ` Christoph Hellwig
2020-10-29 2:20 ` Gloria Tsai [this message]
2020-10-29 2:20 ` Gloria Tsai
2020-10-29 2:33 ` Keith Busch
2020-10-29 2:33 ` Keith Busch
2020-10-29 3:15 ` Keith Busch
2020-10-29 3:15 ` Keith Busch
2020-10-29 3:21 ` Gloria Tsai
2020-10-29 3:21 ` Gloria Tsai
2020-10-29 14:55 ` Christoph Hellwig
2020-10-29 14:55 ` Christoph Hellwig
2020-11-02 18:13 ` Christoph Hellwig
2020-11-02 18:13 ` Christoph Hellwig
2020-11-03 2:21 ` Gloria Tsai
2020-11-03 2:21 ` Gloria Tsai
2020-11-03 9:23 ` Christoph Hellwig
2020-11-03 9:23 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=HK2PR02MB4004EC30D14A16B59FD22A44EE140@HK2PR02MB4004.apcprd02.prod.outlook.com \
--to=gloria.tsai@ssstc.com \
--cc=axboe@fb.com \
--cc=dj54.sohn@samsung.com \
--cc=hch@lst.de \
--cc=jongheony.kim@samsung.com \
--cc=jongpil19.jung@samsung.com \
--cc=jongpuls@gmail.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.