All of lore.kernel.org
 help / color / mirror / Atom feed
From: Coiby Xu <coiby.xu@gmail.com>
To: Patrice CHOTARD <patrice.chotard@st.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	"moderated list:ARM/STI ARCHITECTURE" 
	<linux-arm-kernel@lists.infradead.org>,
	"open list:WATCHDOG DEVICE DRIVERS"
	<linux-watchdog@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] watchdog: st_lpc_wdt: remove unnecessary CONFIG_PM_SLEEP
Date: Thu, 29 Oct 2020 22:51:55 +0800	[thread overview]
Message-ID: <20201029145155.7ihr3nfjuuufao4d@Rk> (raw)
In-Reply-To: <23c07a77-2ce3-1ebd-c8d7-001cd896f157@st.com>

On Thu, Oct 29, 2020 at 07:58:30AM +0000, Patrice CHOTARD wrote:
>Hi Coiby
>
>On 10/29/20 8:53 AM, Coiby Xu wrote:
>> SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG.
>>
>> Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
>> ---
>>  drivers/watchdog/st_lpc_wdt.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/watchdog/st_lpc_wdt.c b/drivers/watchdog/st_lpc_wdt.c
>> index 14ab6559c748..c1428d63dc9e 100644
>> --- a/drivers/watchdog/st_lpc_wdt.c
>> +++ b/drivers/watchdog/st_lpc_wdt.c
>> @@ -248,7 +248,6 @@ static int st_wdog_remove(struct platform_device *pdev)
>>  	return 0;
>>  }
>>
>> -#ifdef CONFIG_PM_SLEEP
>>  static int st_wdog_suspend(struct device *dev)
>>  {
>>  	struct st_wdog *st_wdog = watchdog_get_drvdata(&st_wdog_dev);
>> @@ -285,7 +284,6 @@ static int st_wdog_resume(struct device *dev)
>>
>>  	return 0;
>>  }
>> -#endif
>>
>>  static SIMPLE_DEV_PM_OPS(st_wdog_pm_ops,
>>  			 st_wdog_suspend,
>
>Reviewed-by: Patrice Chotard <patrice.chotard@st.com>
>
Thank you for reviewing the patch and giving the credit despite
the compiling issue with CONFIG_PM_SLEEP disabled as pointed by
Guenter and others:)

>Thanks
>
>Patrice

--
Best regards,
Coiby

WARNING: multiple messages have this Message-ID (diff)
From: Coiby Xu <coiby.xu@gmail.com>
To: Patrice CHOTARD <patrice.chotard@st.com>
Cc: open list <linux-kernel@vger.kernel.org>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	"moderated list:ARM/STI ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>,
	Guenter Roeck <linux@roeck-us.net>,
	"open list:WATCHDOG DEVICE DRIVERS"
	<linux-watchdog@vger.kernel.org>
Subject: Re: [PATCH 2/3] watchdog: st_lpc_wdt: remove unnecessary CONFIG_PM_SLEEP
Date: Thu, 29 Oct 2020 22:51:55 +0800	[thread overview]
Message-ID: <20201029145155.7ihr3nfjuuufao4d@Rk> (raw)
In-Reply-To: <23c07a77-2ce3-1ebd-c8d7-001cd896f157@st.com>

On Thu, Oct 29, 2020 at 07:58:30AM +0000, Patrice CHOTARD wrote:
>Hi Coiby
>
>On 10/29/20 8:53 AM, Coiby Xu wrote:
>> SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG.
>>
>> Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
>> ---
>>  drivers/watchdog/st_lpc_wdt.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/watchdog/st_lpc_wdt.c b/drivers/watchdog/st_lpc_wdt.c
>> index 14ab6559c748..c1428d63dc9e 100644
>> --- a/drivers/watchdog/st_lpc_wdt.c
>> +++ b/drivers/watchdog/st_lpc_wdt.c
>> @@ -248,7 +248,6 @@ static int st_wdog_remove(struct platform_device *pdev)
>>  	return 0;
>>  }
>>
>> -#ifdef CONFIG_PM_SLEEP
>>  static int st_wdog_suspend(struct device *dev)
>>  {
>>  	struct st_wdog *st_wdog = watchdog_get_drvdata(&st_wdog_dev);
>> @@ -285,7 +284,6 @@ static int st_wdog_resume(struct device *dev)
>>
>>  	return 0;
>>  }
>> -#endif
>>
>>  static SIMPLE_DEV_PM_OPS(st_wdog_pm_ops,
>>  			 st_wdog_suspend,
>
>Reviewed-by: Patrice Chotard <patrice.chotard@st.com>
>
Thank you for reviewing the patch and giving the credit despite
the compiling issue with CONFIG_PM_SLEEP disabled as pointed by
Guenter and others:)

>Thanks
>
>Patrice

--
Best regards,
Coiby

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-10-29 14:52 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-29  7:53 [PATCH 1/3] ACPI: watchdog: remove unnecessary CONFIG_PM_SLEEP Coiby Xu
2020-10-29  7:53 ` [PATCH 2/3] watchdog: st_lpc_wdt: " Coiby Xu
2020-10-29  7:53   ` Coiby Xu
2020-10-29  7:58   ` Patrice CHOTARD
2020-10-29  7:58     ` Patrice CHOTARD
2020-10-29 13:13     ` Patrice CHOTARD
2020-10-29 13:13       ` Patrice CHOTARD
2020-10-29 14:51     ` Coiby Xu [this message]
2020-10-29 14:51       ` Coiby Xu
2020-10-29 13:03   ` Guenter Roeck
2020-10-29 13:03     ` Guenter Roeck
2020-10-29  7:53 ` [PATCH 3/3] watchdog: sirfsoc_wdt: " Coiby Xu
2020-10-29  7:53   ` Coiby Xu
2020-10-29 13:05   ` Guenter Roeck
2020-10-29 13:05     ` Guenter Roeck
2020-10-29 14:30     ` Coiby Xu
2020-10-29 14:30       ` Coiby Xu
2020-10-29 13:02 ` [PATCH 1/3] ACPI: watchdog: " Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201029145155.7ihr3nfjuuufao4d@Rk \
    --to=coiby.xu@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=patrice.chotard@st.com \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.