All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Coiby Xu <coiby.xu@gmail.com>, Wim Van Sebroeck <wim@linux-watchdog.org>
Cc: Barry Song <baohua@kernel.org>,
	"open list:WATCHDOG DEVICE DRIVERS"
	<linux-watchdog@vger.kernel.org>,
	"moderated list:ARM/CSR SIRFPRIMA2 MACHINE SUPPORT" 
	<linux-arm-kernel@lists.infradead.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] watchdog: sirfsoc_wdt: remove unnecessary CONFIG_PM_SLEEP
Date: Thu, 29 Oct 2020 06:05:21 -0700	[thread overview]
Message-ID: <41e73435-375f-1865-69ce-462395476258@roeck-us.net> (raw)
In-Reply-To: <20201029075327.228570-3-coiby.xu@gmail.com>

On 10/29/20 12:53 AM, Coiby Xu wrote:
> SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG.
> 
> Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
> ---
>  drivers/watchdog/sirfsoc_wdt.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/watchdog/sirfsoc_wdt.c b/drivers/watchdog/sirfsoc_wdt.c
> index 734cf2966ecb..dc8341cd7d44 100644
> --- a/drivers/watchdog/sirfsoc_wdt.c
> +++ b/drivers/watchdog/sirfsoc_wdt.c
> @@ -170,7 +170,6 @@ static int sirfsoc_wdt_probe(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -#ifdef	CONFIG_PM_SLEEP
>  static int sirfsoc_wdt_suspend(struct device *dev)

And again: __maybe_unused

I would suggest to test compile the code with CONFIG_PM_SLEEP disabled.

>  {
>  	return 0;
> @@ -189,7 +188,6 @@ static int sirfsoc_wdt_resume(struct device *dev)
>  
>  	return 0;
>  }
> -#endif
>  
>  static SIMPLE_DEV_PM_OPS(sirfsoc_wdt_pm_ops,
>  		sirfsoc_wdt_suspend, sirfsoc_wdt_resume);
> 


WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Coiby Xu <coiby.xu@gmail.com>, Wim Van Sebroeck <wim@linux-watchdog.org>
Cc: Barry Song <baohua@kernel.org>,
	"open list:WATCHDOG DEVICE DRIVERS"
	<linux-watchdog@vger.kernel.org>,
	"moderated list:ARM/CSR SIRFPRIMA2 MACHINE SUPPORT"
	<linux-arm-kernel@lists.infradead.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] watchdog: sirfsoc_wdt: remove unnecessary CONFIG_PM_SLEEP
Date: Thu, 29 Oct 2020 06:05:21 -0700	[thread overview]
Message-ID: <41e73435-375f-1865-69ce-462395476258@roeck-us.net> (raw)
In-Reply-To: <20201029075327.228570-3-coiby.xu@gmail.com>

On 10/29/20 12:53 AM, Coiby Xu wrote:
> SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG.
> 
> Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
> ---
>  drivers/watchdog/sirfsoc_wdt.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/watchdog/sirfsoc_wdt.c b/drivers/watchdog/sirfsoc_wdt.c
> index 734cf2966ecb..dc8341cd7d44 100644
> --- a/drivers/watchdog/sirfsoc_wdt.c
> +++ b/drivers/watchdog/sirfsoc_wdt.c
> @@ -170,7 +170,6 @@ static int sirfsoc_wdt_probe(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -#ifdef	CONFIG_PM_SLEEP
>  static int sirfsoc_wdt_suspend(struct device *dev)

And again: __maybe_unused

I would suggest to test compile the code with CONFIG_PM_SLEEP disabled.

>  {
>  	return 0;
> @@ -189,7 +188,6 @@ static int sirfsoc_wdt_resume(struct device *dev)
>  
>  	return 0;
>  }
> -#endif
>  
>  static SIMPLE_DEV_PM_OPS(sirfsoc_wdt_pm_ops,
>  		sirfsoc_wdt_suspend, sirfsoc_wdt_resume);
> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-10-29 13:05 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-29  7:53 [PATCH 1/3] ACPI: watchdog: remove unnecessary CONFIG_PM_SLEEP Coiby Xu
2020-10-29  7:53 ` [PATCH 2/3] watchdog: st_lpc_wdt: " Coiby Xu
2020-10-29  7:53   ` Coiby Xu
2020-10-29  7:58   ` Patrice CHOTARD
2020-10-29  7:58     ` Patrice CHOTARD
2020-10-29 13:13     ` Patrice CHOTARD
2020-10-29 13:13       ` Patrice CHOTARD
2020-10-29 14:51     ` Coiby Xu
2020-10-29 14:51       ` Coiby Xu
2020-10-29 13:03   ` Guenter Roeck
2020-10-29 13:03     ` Guenter Roeck
2020-10-29  7:53 ` [PATCH 3/3] watchdog: sirfsoc_wdt: " Coiby Xu
2020-10-29  7:53   ` Coiby Xu
2020-10-29 13:05   ` Guenter Roeck [this message]
2020-10-29 13:05     ` Guenter Roeck
2020-10-29 14:30     ` Coiby Xu
2020-10-29 14:30       ` Coiby Xu
2020-10-29 13:02 ` [PATCH 1/3] ACPI: watchdog: " Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41e73435-375f-1865-69ce-462395476258@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=baohua@kernel.org \
    --cc=coiby.xu@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.