Re: [PATCHv2 1/4] perf/core: Export is_kernel_event()

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCHv2 1/4] perf/core: Export is_kernel_event()
Date: Sat, 31 Oct 2020 15:35:32 +0800	[thread overview]
Message-ID: <202010311505.AVo65OBZ-lkp@intel.com> (raw)
In-Reply-To: <fbe7bf4fb07ecd8c77cf0321555eabc84421ed41.1603363729.git.saiprakash.ranjan@codeaurora.org>

[-- Attachment #1: Type: text/plain, Size: 5491 bytes --]

Hi Sai,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on f4cb5e9daedf56671badc93ac7f364043aa33886]

url:    https://github.com/0day-ci/linux/commits/Sai-Prakash-Ranjan/coresight-etf-etb10-etr-Fix-NULL-pointer-dereference-crashes/20201022-185929
base:    f4cb5e9daedf56671badc93ac7f364043aa33886
config: powerpc-mpc8540_ads_defconfig (attached as .config)
compiler: powerpc-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/f5ab45a4aa0d4c3be07201c8d5599e6dcc37226c
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Sai-Prakash-Ranjan/coresight-etf-etb10-etr-Fix-NULL-pointer-dereference-crashes/20201022-185929
        git checkout f5ab45a4aa0d4c3be07201c8d5599e6dcc37226c
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/trace_events.h:10,
                    from include/trace/syscall.h:7,
                    from include/linux/syscalls.h:84,
                    from arch/powerpc/kernel/syscalls.c:19:
>> include/linux/perf_event.h:1511:13: error: 'is_kernel_event' defined but not used [-Werror=unused-function]
    1511 | static bool is_kernel_event(struct perf_event *event) { return false; }
         |             ^~~~~~~~~~~~~~~
   cc1: all warnings being treated as errors
--
   arch/powerpc/kernel/traps.c:1663:6: error: no previous prototype for 'stack_overflow_exception' [-Werror=missing-prototypes]
    1663 | void stack_overflow_exception(struct pt_regs *regs)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~
   arch/powerpc/kernel/traps.c:1993:6: error: no previous prototype for 'DebugException' [-Werror=missing-prototypes]
    1993 | void DebugException(struct pt_regs *regs, unsigned long debug_status)
         |      ^~~~~~~~~~~~~~
   arch/powerpc/kernel/traps.c:2098:6: error: no previous prototype for 'CacheLockingException' [-Werror=missing-prototypes]
    2098 | void CacheLockingException(struct pt_regs *regs, unsigned long address,
         |      ^~~~~~~~~~~~~~~~~~~~~
   arch/powerpc/kernel/traps.c:2112:6: error: no previous prototype for 'SPEFloatingPointException' [-Werror=missing-prototypes]
    2112 | void SPEFloatingPointException(struct pt_regs *regs)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~
   arch/powerpc/kernel/traps.c:2164:6: error: no previous prototype for 'SPEFloatingPointRoundException' [-Werror=missing-prototypes]
    2164 | void SPEFloatingPointRoundException(struct pt_regs *regs)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   In file included from arch/powerpc/include/asm/emulated_ops.h:10,
                    from arch/powerpc/kernel/traps.c:41:
>> include/linux/perf_event.h:1511:13: error: 'is_kernel_event' defined but not used [-Werror=unused-function]
    1511 | static bool is_kernel_event(struct perf_event *event) { return false; }
         |             ^~~~~~~~~~~~~~~
   cc1: all warnings being treated as errors

vim +/is_kernel_event +1511 include/linux/perf_event.h

  1478	
  1479	typedef int (perf_ksymbol_get_name_f)(char *name, int name_len, void *data);
  1480	static inline void perf_event_ksymbol(u16 ksym_type, u64 addr, u32 len,
  1481					      bool unregister, const char *sym)	{ }
  1482	static inline void perf_event_bpf_event(struct bpf_prog *prog,
  1483						enum perf_bpf_event_type type,
  1484						u16 flags)			{ }
  1485	static inline void perf_event_exec(void)				{ }
  1486	static inline void perf_event_comm(struct task_struct *tsk, bool exec)	{ }
  1487	static inline void perf_event_namespaces(struct task_struct *tsk)	{ }
  1488	static inline void perf_event_fork(struct task_struct *tsk)		{ }
  1489	static inline void perf_event_text_poke(const void *addr,
  1490						const void *old_bytes,
  1491						size_t old_len,
  1492						const void *new_bytes,
  1493						size_t new_len)			{ }
  1494	static inline void perf_event_init(void)				{ }
  1495	static inline int  perf_swevent_get_recursion_context(void)		{ return -1; }
  1496	static inline void perf_swevent_put_recursion_context(int rctx)		{ }
  1497	static inline u64 perf_swevent_set_period(struct perf_event *event)	{ return 0; }
  1498	static inline void perf_event_enable(struct perf_event *event)		{ }
  1499	static inline void perf_event_disable(struct perf_event *event)		{ }
  1500	static inline int __perf_event_disable(void *info)			{ return -1; }
  1501	static inline void perf_event_task_tick(void)				{ }
  1502	static inline int perf_event_release_kernel(struct perf_event *event)	{ return 0; }
  1503	static inline int perf_event_period(struct perf_event *event, u64 value)
  1504	{
  1505		return -EINVAL;
  1506	}
  1507	static inline u64 perf_event_pause(struct perf_event *event, bool reset)
  1508	{
  1509		return 0;
  1510	}
> 1511	static bool is_kernel_event(struct perf_event *event) { return false; }
  1512	#endif
  1513	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 12526 bytes --]