From: Greg KH <gregkh@linuxfoundation.org> To: Prasad Sodagudi <psodagud@codeaurora.org> Cc: rostedt@goodmis.org, mingo@redhat.com, keescook@chromium.org, catalin.marinas@arm.com, saiprakash.ranjan@codeaurora.org, will@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, anton@enomsg.org, arnd@arndb.de, ccross@android.com, jbaron@akamai.com, jim.cromie@gmail.com, joe@perches.com, joel@joelfernandes.org Subject: Re: [PATCH v2] tracing: Add register read and write tracing support Date: Fri, 6 Nov 2020 07:49:29 +0100 [thread overview] Message-ID: <20201106064929.GC697514@kroah.com> (raw) In-Reply-To: <1604631386-178312-2-git-send-email-psodagud@codeaurora.org> On Thu, Nov 05, 2020 at 06:56:26PM -0800, Prasad Sodagudi wrote: > Add register read/write operations tracing support. > ftrace events helps to trace register read and write > location details of memory mapped IO registers. This sentance does not parse for me, can you please rework it? > These trace logs helps to debug un clocked access > of peripherals. "un clocked"? What does that mean? And you do have 72 columns to fill, please use it :) > > Signed-off-by: Prasad Sodagudi <psodagud@codeaurora.org> > --- > arch/arm64/include/asm/io.h | 9 ++++++++ > arch/arm64/kernel/image-vars.h | 8 +++++++ You are only adding it for arm64, why not add the generic support first, and then add it for all "major" arches afterwards? > include/linux/iorw.h | 38 +++++++++++++++++++++++++++++++ > include/trace/events/rwio.h | 51 ++++++++++++++++++++++++++++++++++++++++++ > kernel/trace/Kconfig | 11 +++++++++ > kernel/trace/Makefile | 1 + > kernel/trace/trace_readwrite.c | 31 +++++++++++++++++++++++++ > 7 files changed, 149 insertions(+) > create mode 100644 include/linux/iorw.h > create mode 100644 include/trace/events/rwio.h > create mode 100644 kernel/trace/trace_readwrite.c > > diff --git a/arch/arm64/include/asm/io.h b/arch/arm64/include/asm/io.h > index fd172c4..bcfc65c 100644 > --- a/arch/arm64/include/asm/io.h > +++ b/arch/arm64/include/asm/io.h > @@ -9,6 +9,7 @@ > #define __ASM_IO_H > > #include <linux/types.h> > +#include <linux/iorw.h> > #include <linux/pgtable.h> > > #include <asm/byteorder.h> > @@ -24,24 +25,28 @@ > #define __raw_writeb __raw_writeb > static inline void __raw_writeb(u8 val, volatile void __iomem *addr) > { > + log_write_io(addr); > asm volatile("strb %w0, [%1]" : : "rZ" (val), "r" (addr)); Why are you not logging the value here, and everywhere else? You need to document why that is somewhere, as it's the most obvious question you will get. thanks, greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org> To: Prasad Sodagudi <psodagud@codeaurora.org> Cc: saiprakash.ranjan@codeaurora.org, keescook@chromium.org, arnd@arndb.de, jim.cromie@gmail.com, catalin.marinas@arm.com, anton@enomsg.org, linux-kernel@vger.kernel.org, rostedt@goodmis.org, ccross@android.com, joel@joelfernandes.org, jbaron@akamai.com, mingo@redhat.com, linux-arm-msm@vger.kernel.org, joe@perches.com, will@kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] tracing: Add register read and write tracing support Date: Fri, 6 Nov 2020 07:49:29 +0100 [thread overview] Message-ID: <20201106064929.GC697514@kroah.com> (raw) In-Reply-To: <1604631386-178312-2-git-send-email-psodagud@codeaurora.org> On Thu, Nov 05, 2020 at 06:56:26PM -0800, Prasad Sodagudi wrote: > Add register read/write operations tracing support. > ftrace events helps to trace register read and write > location details of memory mapped IO registers. This sentance does not parse for me, can you please rework it? > These trace logs helps to debug un clocked access > of peripherals. "un clocked"? What does that mean? And you do have 72 columns to fill, please use it :) > > Signed-off-by: Prasad Sodagudi <psodagud@codeaurora.org> > --- > arch/arm64/include/asm/io.h | 9 ++++++++ > arch/arm64/kernel/image-vars.h | 8 +++++++ You are only adding it for arm64, why not add the generic support first, and then add it for all "major" arches afterwards? > include/linux/iorw.h | 38 +++++++++++++++++++++++++++++++ > include/trace/events/rwio.h | 51 ++++++++++++++++++++++++++++++++++++++++++ > kernel/trace/Kconfig | 11 +++++++++ > kernel/trace/Makefile | 1 + > kernel/trace/trace_readwrite.c | 31 +++++++++++++++++++++++++ > 7 files changed, 149 insertions(+) > create mode 100644 include/linux/iorw.h > create mode 100644 include/trace/events/rwio.h > create mode 100644 kernel/trace/trace_readwrite.c > > diff --git a/arch/arm64/include/asm/io.h b/arch/arm64/include/asm/io.h > index fd172c4..bcfc65c 100644 > --- a/arch/arm64/include/asm/io.h > +++ b/arch/arm64/include/asm/io.h > @@ -9,6 +9,7 @@ > #define __ASM_IO_H > > #include <linux/types.h> > +#include <linux/iorw.h> > #include <linux/pgtable.h> > > #include <asm/byteorder.h> > @@ -24,24 +25,28 @@ > #define __raw_writeb __raw_writeb > static inline void __raw_writeb(u8 val, volatile void __iomem *addr) > { > + log_write_io(addr); > asm volatile("strb %w0, [%1]" : : "rZ" (val), "r" (addr)); Why are you not logging the value here, and everywhere else? You need to document why that is somewhere, as it's the most obvious question you will get. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-06 6:49 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-06 2:56 [PATCH 2] Register read and writes tracing Prasad Sodagudi 2020-11-06 2:56 ` Prasad Sodagudi 2020-11-06 2:56 ` [PATCH v2] tracing: Add register read and write tracing support Prasad Sodagudi 2020-11-06 2:56 ` Prasad Sodagudi 2020-11-06 6:49 ` Greg KH [this message] 2020-11-06 6:49 ` Greg KH 2020-11-06 9:09 ` Will Deacon 2020-11-06 9:09 ` Will Deacon 2020-11-06 3:58 ` [PATCH 2] Register read and writes tracing Florian Fainelli 2020-11-06 3:58 ` Florian Fainelli
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201106064929.GC697514@kroah.com \ --to=gregkh@linuxfoundation.org \ --cc=anton@enomsg.org \ --cc=arnd@arndb.de \ --cc=catalin.marinas@arm.com \ --cc=ccross@android.com \ --cc=jbaron@akamai.com \ --cc=jim.cromie@gmail.com \ --cc=joe@perches.com \ --cc=joel@joelfernandes.org \ --cc=keescook@chromium.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@redhat.com \ --cc=psodagud@codeaurora.org \ --cc=rostedt@goodmis.org \ --cc=saiprakash.ranjan@codeaurora.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.