Re: [RFC PATCH v3.1 16/27] mmc: sdhci-uhs2: add set_ios()

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4291 bytes --]

Hi AKASHI,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on linus/master]
[also build test WARNING on v5.10-rc2]
[cannot apply to v3.1 next-20201105]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/AKASHI-Takahiro/Add-support-UHS-II-for-GL9755/20201106-103058
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 521b619acdc8f1f5acdac15b84f81fd9515b2aff
config: x86_64-randconfig-a006-20201104 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 09ec07827b1128504457a93dee80b2ceee1af600)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/063ac5682a9b21093065d2025ab3fbf8e92864ae
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review AKASHI-Takahiro/Add-support-UHS-II-for-GL9755/20201106-103058
        git checkout 063ac5682a9b21093065d2025ab3fbf8e92864ae
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/mmc/host/sdhci-uhs2.c:113:6: warning: variable 'pwr' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
           if (mode != MMC_POWER_OFF) {
               ^~~~~~~~~~~~~~~~~~~~~
   drivers/mmc/host/sdhci-uhs2.c:122:19: note: uninitialized use occurs here
           if (host->pwr == pwr)
                            ^~~
   drivers/mmc/host/sdhci-uhs2.c:113:2: note: remove the 'if' if its condition is always true
           if (mode != MMC_POWER_OFF) {
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/mmc/host/sdhci-uhs2.c:105:8: note: initialize the variable 'pwr' to silence this warning
           u8 pwr;
                 ^
                  = '\0'
>> drivers/mmc/host/sdhci-uhs2.c:357:6: warning: no previous prototype for function 'sdhci_uhs2_set_ios' [-Wmissing-prototypes]
   void sdhci_uhs2_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
        ^
   drivers/mmc/host/sdhci-uhs2.c:357:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void sdhci_uhs2_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
   ^
   static 
   drivers/mmc/host/sdhci-uhs2.c:394:12: warning: unused function 'sdhci_uhs2_host_ops_init' [-Wunused-function]
   static int sdhci_uhs2_host_ops_init(struct sdhci_host *host)
              ^
   3 warnings generated.

vim +/sdhci_uhs2_set_ios +357 drivers/mmc/host/sdhci-uhs2.c

   356	
 > 357	void sdhci_uhs2_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
   358	{
   359		struct sdhci_host *host = mmc_priv(mmc);
   360	
   361		if (!(host->version >= SDHCI_SPEC_400) ||
   362		    !(host->mmc->flags & MMC_UHS2_SUPPORT &&
   363		      host->mmc->caps & MMC_CAP_UHS2)) {
   364			sdhci_set_ios(mmc, ios);
   365			return;
   366		}
   367	
   368		if (ios->power_mode == MMC_POWER_UNDEFINED)
   369			return;
   370	
   371		if (host->flags & SDHCI_DEVICE_DEAD) {
   372			if (!IS_ERR(mmc->supply.vmmc) &&
   373			    ios->power_mode == MMC_POWER_OFF)
   374				mmc_regulator_set_ocr(mmc, mmc->supply.vmmc, 0);
   375			if (!IS_ERR_OR_NULL(mmc->supply.vmmc2) &&
   376			    ios->power_mode == MMC_POWER_OFF)
   377				mmc_regulator_set_ocr(mmc, mmc->supply.vmmc2, 0);
   378			return;
   379		}
   380	
   381		/* FIXME: host->timing = ios->timing */
   382	
   383		sdhci_set_ios_common(mmc, ios);
   384	
   385		__sdhci_uhs2_set_ios(mmc, ios);
   386	}
   387	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34794 bytes --]