All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] checkpatch: fix typo and remove duplicate word
@ 2020-11-13 13:57 ` Dwaipayan Ray
  0 siblings, 0 replies; 9+ messages in thread
From: Dwaipayan Ray @ 2020-11-13 13:57 UTC (permalink / raw)
  To: joe; +Cc: linux-kernel-mentees, dwaipayanray1, linux-kernel, lukas.bulwahn

Delete repeated word in scripts/checkpatch.pl:
"are are" -> "are"

Fix typos:
"commments" -> "comments"
"falsly" -> "falsely"

Signed-off-by: Dwaipayan Ray <dwaipayanray1@gmail.com>
---
 scripts/checkpatch.pl | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 2749f32dffe9..041b82f6669e 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2841,7 +2841,7 @@ sub process {
 
 
 				# stable@vger.kernel.org or stable@kernel.org shouldn't
-				# have an email name. In addition commments should strictly
+				# have an email name. In addition comments should strictly
 				# begin with a #
 				if ($email =~ /^.*stable\@(?:vger\.)?kernel\.org/i) {
 					if (($comment ne "" && $comment !~ /^#.+/) ||
@@ -5000,7 +5000,7 @@ sub process {
 ## 		    $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) {
 ##
 ## 			# Remove any bracketed sections to ensure we do not
-## 			# falsly report the parameters of functions.
+## 			# falsely report the parameters of functions.
 ## 			my $ln = $line;
 ## 			while ($ln =~ s/\([^\(\)]*\)//g) {
 ## 			}
@@ -7109,7 +7109,7 @@ sub process {
 		exit(0);
 	}
 
-	# This is not a patch, and we are are in 'no-patch' mode so
+	# This is not a patch, and we are in 'no-patch' mode so
 	# just keep quiet.
 	if (!$chk_patch && !$is_patch) {
 		exit(0);
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [Linux-kernel-mentees] [PATCH] checkpatch: fix typo and remove duplicate word
@ 2020-11-13 13:57 ` Dwaipayan Ray
  0 siblings, 0 replies; 9+ messages in thread
From: Dwaipayan Ray @ 2020-11-13 13:57 UTC (permalink / raw)
  To: joe; +Cc: dwaipayanray1, linux-kernel-mentees, linux-kernel

Delete repeated word in scripts/checkpatch.pl:
"are are" -> "are"

Fix typos:
"commments" -> "comments"
"falsly" -> "falsely"

Signed-off-by: Dwaipayan Ray <dwaipayanray1@gmail.com>
---
 scripts/checkpatch.pl | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 2749f32dffe9..041b82f6669e 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2841,7 +2841,7 @@ sub process {
 
 
 				# stable@vger.kernel.org or stable@kernel.org shouldn't
-				# have an email name. In addition commments should strictly
+				# have an email name. In addition comments should strictly
 				# begin with a #
 				if ($email =~ /^.*stable\@(?:vger\.)?kernel\.org/i) {
 					if (($comment ne "" && $comment !~ /^#.+/) ||
@@ -5000,7 +5000,7 @@ sub process {
 ## 		    $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) {
 ##
 ## 			# Remove any bracketed sections to ensure we do not
-## 			# falsly report the parameters of functions.
+## 			# falsely report the parameters of functions.
 ## 			my $ln = $line;
 ## 			while ($ln =~ s/\([^\(\)]*\)//g) {
 ## 			}
@@ -7109,7 +7109,7 @@ sub process {
 		exit(0);
 	}
 
-	# This is not a patch, and we are are in 'no-patch' mode so
+	# This is not a patch, and we are in 'no-patch' mode so
 	# just keep quiet.
 	if (!$chk_patch && !$is_patch) {
 		exit(0);
-- 
2.27.0

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: [PATCH] checkpatch: fix typo and remove duplicate word
  2020-11-13 13:57 ` [Linux-kernel-mentees] " Dwaipayan Ray
@ 2020-11-13 15:00   ` Joe Perches
  -1 siblings, 0 replies; 9+ messages in thread
From: Joe Perches @ 2020-11-13 15:00 UTC (permalink / raw)
  To: Dwaipayan Ray; +Cc: linux-kernel-mentees, linux-kernel, lukas.bulwahn

On Fri, 2020-11-13 at 19:27 +0530, Dwaipayan Ray wrote:
> Delete repeated word in scripts/checkpatch.pl:
> "are are" -> "are"
> 
> Fix typos:
> "commments" -> "comments"
> "falsly" -> "falsely"
> 
> Signed-off-by: Dwaipayan Ray <dwaipayanray1@gmail.com>
> ---

style: this should have subject prefix:

"[PATCH V2] checkpatch: Fix spelling errors and remove repeated word"

And here below the --- line you should add a V2 changelog like:

o Add correction for falsly

Other than that, you might consider sending a V3 just to get
used the proper patch resubmission form but thanks.

>  scripts/checkpatch.pl | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 2749f32dffe9..041b82f6669e 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2841,7 +2841,7 @@ sub process {
>  
> 
>  
> 
>  				# stable@vger.kernel.org or stable@kernel.org shouldn't
> -				# have an email name. In addition commments should strictly
> +				# have an email name. In addition comments should strictly
>  				# begin with a #
>  				if ($email =~ /^.*stable\@(?:vger\.)?kernel\.org/i) {
>  					if (($comment ne "" && $comment !~ /^#.+/) ||
> @@ -5000,7 +5000,7 @@ sub process {
>  ## 		    $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) {
>  ##
>  ## 			# Remove any bracketed sections to ensure we do not
> -## 			# falsly report the parameters of functions.
> +## 			# falsely report the parameters of functions.
>  ## 			my $ln = $line;
>  ## 			while ($ln =~ s/\([^\(\)]*\)//g) {
>  ## 			}
> @@ -7109,7 +7109,7 @@ sub process {
>  		exit(0);
>  	}
>  
> 
> -	# This is not a patch, and we are are in 'no-patch' mode so
> +	# This is not a patch, and we are in 'no-patch' mode so
>  	# just keep quiet.
>  	if (!$chk_patch && !$is_patch) {
>  		exit(0);



^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [Linux-kernel-mentees] [PATCH] checkpatch: fix typo and remove duplicate word
@ 2020-11-13 15:00   ` Joe Perches
  0 siblings, 0 replies; 9+ messages in thread
From: Joe Perches @ 2020-11-13 15:00 UTC (permalink / raw)
  To: Dwaipayan Ray; +Cc: linux-kernel-mentees, linux-kernel

On Fri, 2020-11-13 at 19:27 +0530, Dwaipayan Ray wrote:
> Delete repeated word in scripts/checkpatch.pl:
> "are are" -> "are"
> 
> Fix typos:
> "commments" -> "comments"
> "falsly" -> "falsely"
> 
> Signed-off-by: Dwaipayan Ray <dwaipayanray1@gmail.com>
> ---

style: this should have subject prefix:

"[PATCH V2] checkpatch: Fix spelling errors and remove repeated word"

And here below the --- line you should add a V2 changelog like:

o Add correction for falsly

Other than that, you might consider sending a V3 just to get
used the proper patch resubmission form but thanks.

>  scripts/checkpatch.pl | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 2749f32dffe9..041b82f6669e 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2841,7 +2841,7 @@ sub process {
>  
> 
>  
> 
>  				# stable@vger.kernel.org or stable@kernel.org shouldn't
> -				# have an email name. In addition commments should strictly
> +				# have an email name. In addition comments should strictly
>  				# begin with a #
>  				if ($email =~ /^.*stable\@(?:vger\.)?kernel\.org/i) {
>  					if (($comment ne "" && $comment !~ /^#.+/) ||
> @@ -5000,7 +5000,7 @@ sub process {
>  ## 		    $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) {
>  ##
>  ## 			# Remove any bracketed sections to ensure we do not
> -## 			# falsly report the parameters of functions.
> +## 			# falsely report the parameters of functions.
>  ## 			my $ln = $line;
>  ## 			while ($ln =~ s/\([^\(\)]*\)//g) {
>  ## 			}
> @@ -7109,7 +7109,7 @@ sub process {
>  		exit(0);
>  	}
>  
> 
> -	# This is not a patch, and we are are in 'no-patch' mode so
> +	# This is not a patch, and we are in 'no-patch' mode so
>  	# just keep quiet.
>  	if (!$chk_patch && !$is_patch) {
>  		exit(0);


_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] checkpatch: fix typo and remove duplicate word
  2020-11-13 15:00   ` [Linux-kernel-mentees] " Joe Perches
@ 2020-11-13 15:08     ` Dwaipayan Ray
  -1 siblings, 0 replies; 9+ messages in thread
From: Dwaipayan Ray @ 2020-11-13 15:08 UTC (permalink / raw)
  To: Joe Perches; +Cc: linux-kernel-mentees, linux-kernel, Lukas Bulwahn

On Fri, Nov 13, 2020 at 8:30 PM Joe Perches <joe@perches.com> wrote:
>
> On Fri, 2020-11-13 at 19:27 +0530, Dwaipayan Ray wrote:
> > Delete repeated word in scripts/checkpatch.pl:
> > "are are" -> "are"
> >
> > Fix typos:
> > "commments" -> "comments"
> > "falsly" -> "falsely"
> >
> > Signed-off-by: Dwaipayan Ray <dwaipayanray1@gmail.com>
> > ---
>
> style: this should have subject prefix:
>
> "[PATCH V2] checkpatch: Fix spelling errors and remove repeated word"
>
> And here below the --- line you should add a V2 changelog like:
>
> o Add correction for falsly
>
> Other than that, you might consider sending a V3 just to get
> used the proper patch resubmission form but thanks.
>

Thanks, I will do that.

Regards,
Dwaipayan.

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [Linux-kernel-mentees] [PATCH] checkpatch: fix typo and remove duplicate word
@ 2020-11-13 15:08     ` Dwaipayan Ray
  0 siblings, 0 replies; 9+ messages in thread
From: Dwaipayan Ray @ 2020-11-13 15:08 UTC (permalink / raw)
  To: Joe Perches; +Cc: linux-kernel-mentees, linux-kernel

On Fri, Nov 13, 2020 at 8:30 PM Joe Perches <joe@perches.com> wrote:
>
> On Fri, 2020-11-13 at 19:27 +0530, Dwaipayan Ray wrote:
> > Delete repeated word in scripts/checkpatch.pl:
> > "are are" -> "are"
> >
> > Fix typos:
> > "commments" -> "comments"
> > "falsly" -> "falsely"
> >
> > Signed-off-by: Dwaipayan Ray <dwaipayanray1@gmail.com>
> > ---
>
> style: this should have subject prefix:
>
> "[PATCH V2] checkpatch: Fix spelling errors and remove repeated word"
>
> And here below the --- line you should add a V2 changelog like:
>
> o Add correction for falsly
>
> Other than that, you might consider sending a V3 just to get
> used the proper patch resubmission form but thanks.
>

Thanks, I will do that.

Regards,
Dwaipayan.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] checkpatch: fix typo and remove duplicate word
  2020-11-13 13:34 ` Lukas Bulwahn
@ 2020-11-13 13:48   ` Dwaipayan Ray
  0 siblings, 0 replies; 9+ messages in thread
From: Dwaipayan Ray @ 2020-11-13 13:48 UTC (permalink / raw)
  To: Lukas Bulwahn
  Cc: Joe Perches, linux-kernel-mentees, Linux Kernel Mailing List

On Fri, Nov 13, 2020 at 7:04 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
>
> On Fri, Nov 13, 2020 at 2:11 PM Dwaipayan Ray <dwaipayanray1@gmail.com> wrote:
> >
> > Delete repeated word in scripts/checkpatch.pl.
> > "are are" -> "are"
> >
> > Fix typo "commments" -> "comments"
> >
> > Signed-off-by: Dwaipayan Ray <dwaipayanray1@gmail.com>
>
> Does this make checkpatch.pl pass checkpatch without any further warnings?
>
> Nice idea to check if checkpatch.pl still fulfills the checkpatch
> rules we created...
>

Yes, all the rules pass.
$ ./scripts/checkpatch.pl --codespell --strict -f scripts/checkpatch.pl
gives:
total: 0 errors, 0 warnings, 10 checks, 7233 lines checked

9 of those checks are false positives. There is another misspelled
word:
#5003: FILE: scripts/checkpatch.pl:5003:
+## # falsly report the parameters of functions.

I will add that and resend.

Thanks,
Dwaipayan.

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] checkpatch: fix typo and remove duplicate word
  2020-11-13 13:10 Dwaipayan Ray
@ 2020-11-13 13:34 ` Lukas Bulwahn
  2020-11-13 13:48   ` Dwaipayan Ray
  0 siblings, 1 reply; 9+ messages in thread
From: Lukas Bulwahn @ 2020-11-13 13:34 UTC (permalink / raw)
  To: Dwaipayan Ray
  Cc: Joe Perches, linux-kernel-mentees, Linux Kernel Mailing List

On Fri, Nov 13, 2020 at 2:11 PM Dwaipayan Ray <dwaipayanray1@gmail.com> wrote:
>
> Delete repeated word in scripts/checkpatch.pl.
> "are are" -> "are"
>
> Fix typo "commments" -> "comments"
>
> Signed-off-by: Dwaipayan Ray <dwaipayanray1@gmail.com>

Does this make checkpatch.pl pass checkpatch without any further warnings?

Nice idea to check if checkpatch.pl still fulfills the checkpatch
rules we created...

Lukas

> ---
>  scripts/checkpatch.pl | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 2749f32dffe9..e7fd2d6279cf 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2841,7 +2841,7 @@ sub process {
>
>
>                                 # stable@vger.kernel.org or stable@kernel.org shouldn't
> -                               # have an email name. In addition commments should strictly
> +                               # have an email name. In addition comments should strictly
>                                 # begin with a #
>                                 if ($email =~ /^.*stable\@(?:vger\.)?kernel\.org/i) {
>                                         if (($comment ne "" && $comment !~ /^#.+/) ||
> @@ -7109,7 +7109,7 @@ sub process {
>                 exit(0);
>         }
>
> -       # This is not a patch, and we are are in 'no-patch' mode so
> +       # This is not a patch, and we are in 'no-patch' mode so
>         # just keep quiet.
>         if (!$chk_patch && !$is_patch) {
>                 exit(0);
> --
> 2.27.0
>

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [PATCH] checkpatch: fix typo and remove duplicate word
@ 2020-11-13 13:10 Dwaipayan Ray
  2020-11-13 13:34 ` Lukas Bulwahn
  0 siblings, 1 reply; 9+ messages in thread
From: Dwaipayan Ray @ 2020-11-13 13:10 UTC (permalink / raw)
  To: joe; +Cc: linux-kernel-mentees, dwaipayanray1, linux-kernel, lukas.bulwahn

Delete repeated word in scripts/checkpatch.pl.
"are are" -> "are"

Fix typo "commments" -> "comments"

Signed-off-by: Dwaipayan Ray <dwaipayanray1@gmail.com>
---
 scripts/checkpatch.pl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 2749f32dffe9..e7fd2d6279cf 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2841,7 +2841,7 @@ sub process {
 
 
 				# stable@vger.kernel.org or stable@kernel.org shouldn't
-				# have an email name. In addition commments should strictly
+				# have an email name. In addition comments should strictly
 				# begin with a #
 				if ($email =~ /^.*stable\@(?:vger\.)?kernel\.org/i) {
 					if (($comment ne "" && $comment !~ /^#.+/) ||
@@ -7109,7 +7109,7 @@ sub process {
 		exit(0);
 	}
 
-	# This is not a patch, and we are are in 'no-patch' mode so
+	# This is not a patch, and we are in 'no-patch' mode so
 	# just keep quiet.
 	if (!$chk_patch && !$is_patch) {
 		exit(0);
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-11-13 15:11 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-13 13:57 [PATCH] checkpatch: fix typo and remove duplicate word Dwaipayan Ray
2020-11-13 13:57 ` [Linux-kernel-mentees] " Dwaipayan Ray
2020-11-13 15:00 ` Joe Perches
2020-11-13 15:00   ` [Linux-kernel-mentees] " Joe Perches
2020-11-13 15:08   ` Dwaipayan Ray
2020-11-13 15:08     ` [Linux-kernel-mentees] " Dwaipayan Ray
  -- strict thread matches above, loose matches on Subject: below --
2020-11-13 13:10 Dwaipayan Ray
2020-11-13 13:34 ` Lukas Bulwahn
2020-11-13 13:48   ` Dwaipayan Ray

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.