From: Nishanth Menon <nm@ti.com>
To: Sekhar Nori <nsekhar@ti.com>, Lokesh Vutla <lokeshvutla@ti.com>
Cc: Faiz Abbas <faiz_abbas@ti.com>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <t-kristo@ti.com>,
<robh+dt@kernel.org>,
Grygorii Strashko <grygorii.strashko@ti.com>
Subject: Re: [PATCH 1/3] arm64: dts: ti: k3-j7200-main: Add gpio nodes in main domain
Date: Fri, 13 Nov 2020 12:40:20 -0600 [thread overview]
Message-ID: <20201113184020.drntugqsnj7dzsnh@ultimatum> (raw)
In-Reply-To: <6ce6de4b-6e4d-1d2d-aa7a-570d1796d668@ti.com>
On 23:59-20201113, Sekhar Nori wrote:
[..]
> > dtbs_check: we added:
> > arch/arm64/boot/dts/ti/k3-j7200-main.dtsi: /bus@100000/gpio@600000: Missing #address-cells in interrupt provider
> > arch/arm64/boot/dts/ti/k3-j7200-main.dtsi: /bus@100000/gpio@610000: Missing #address-cells in interrupt provider
> > arch/arm64/boot/dts/ti/k3-j7200-main.dtsi: /bus@100000/gpio@620000: Missing #address-cells in interrupt provider
> > arch/arm64/boot/dts/ti/k3-j7200-main.dtsi: /bus@100000/gpio@630000: Missing #address-cells in interrupt provider
>
> Hmm, running dtbs_check, I did not really see this. These are all the
> warnings I see for TI platforms: https://pastebin.ubuntu.com/p/m2my62mjQq/
Here is the full list of checks I ran through with kernel_patch_verify
(docker)
https://pastebin.ubuntu.com/p/tcnWw89CMD/
See lines 128 onwards for this series. kernel_patch_verify does'nt
complain on existing warnings, but just prints when there are additional
ones added in. Also make sure we have the right dtc as well
dtc 1.6.0 and dt_schema 2020.8.1 was used.
>
> The tree I am testing is linux-next of 12th Nov + these three patches
> applied.
>
> Also, #address-cells for interrupt provider being compulsory does not
> make full sense to me. Nothing in
> Documentation/devicetree/bindings/interrupt-controller/interrupts.txt or
> Documentation/devicetree/bindings/gpio/gpio-davinci.txt suggests that as
> well.
>
> Existing GPIO nodes for AM654 or J721E does not have #address-cells as well.
>
> Adding Grygorii as well, in case he knows more about this.
Yes - we need to have this conversation in the community :) I had
tagged this internally already during the 5.10 merge cycle that we
need to clean up the #address-cells warning and in some cases, maybe
the bindings are probably not accurate to attempt an enforcement.
I'd really like a conclusion on the topic as I recollect Lokesh and
Grygorii had a debate internally, but reached no conclusion, lets get
the wisdom of the community to help us here.
[1] https://github.com/nmenon/kernel_patch_verify/blob/master/kpv
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Menon <nm@ti.com>
To: Sekhar Nori <nsekhar@ti.com>, Lokesh Vutla <lokeshvutla@ti.com>
Cc: devicetree@vger.kernel.org,
Grygorii Strashko <grygorii.strashko@ti.com>,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
t-kristo@ti.com, Faiz Abbas <faiz_abbas@ti.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] arm64: dts: ti: k3-j7200-main: Add gpio nodes in main domain
Date: Fri, 13 Nov 2020 12:40:20 -0600 [thread overview]
Message-ID: <20201113184020.drntugqsnj7dzsnh@ultimatum> (raw)
In-Reply-To: <6ce6de4b-6e4d-1d2d-aa7a-570d1796d668@ti.com>
On 23:59-20201113, Sekhar Nori wrote:
[..]
> > dtbs_check: we added:
> > arch/arm64/boot/dts/ti/k3-j7200-main.dtsi: /bus@100000/gpio@600000: Missing #address-cells in interrupt provider
> > arch/arm64/boot/dts/ti/k3-j7200-main.dtsi: /bus@100000/gpio@610000: Missing #address-cells in interrupt provider
> > arch/arm64/boot/dts/ti/k3-j7200-main.dtsi: /bus@100000/gpio@620000: Missing #address-cells in interrupt provider
> > arch/arm64/boot/dts/ti/k3-j7200-main.dtsi: /bus@100000/gpio@630000: Missing #address-cells in interrupt provider
>
> Hmm, running dtbs_check, I did not really see this. These are all the
> warnings I see for TI platforms: https://pastebin.ubuntu.com/p/m2my62mjQq/
Here is the full list of checks I ran through with kernel_patch_verify
(docker)
https://pastebin.ubuntu.com/p/tcnWw89CMD/
See lines 128 onwards for this series. kernel_patch_verify does'nt
complain on existing warnings, but just prints when there are additional
ones added in. Also make sure we have the right dtc as well
dtc 1.6.0 and dt_schema 2020.8.1 was used.
>
> The tree I am testing is linux-next of 12th Nov + these three patches
> applied.
>
> Also, #address-cells for interrupt provider being compulsory does not
> make full sense to me. Nothing in
> Documentation/devicetree/bindings/interrupt-controller/interrupts.txt or
> Documentation/devicetree/bindings/gpio/gpio-davinci.txt suggests that as
> well.
>
> Existing GPIO nodes for AM654 or J721E does not have #address-cells as well.
>
> Adding Grygorii as well, in case he knows more about this.
Yes - we need to have this conversation in the community :) I had
tagged this internally already during the 5.10 merge cycle that we
need to clean up the #address-cells warning and in some cases, maybe
the bindings are probably not accurate to attempt an enforcement.
I'd really like a conclusion on the topic as I recollect Lokesh and
Grygorii had a debate internally, but reached no conclusion, lets get
the wisdom of the community to help us here.
[1] https://github.com/nmenon/kernel_patch_verify/blob/master/kpv
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-13 18:40 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 19:11 [PATCH 0/3] Add gpio support for TI's J7200 platform Faiz Abbas
2020-11-02 19:11 ` Faiz Abbas
2020-11-02 19:11 ` [PATCH 1/3] arm64: dts: ti: k3-j7200-main: Add gpio nodes in main domain Faiz Abbas
2020-11-02 19:11 ` Faiz Abbas
2020-11-12 16:39 ` Nishanth Menon
2020-11-12 16:39 ` Nishanth Menon
2020-11-13 18:29 ` Sekhar Nori
2020-11-13 18:29 ` Sekhar Nori
2020-11-13 18:40 ` Nishanth Menon [this message]
2020-11-13 18:40 ` Nishanth Menon
2020-11-13 19:09 ` Sekhar Nori
2020-11-13 19:09 ` Sekhar Nori
2020-11-13 20:55 ` Nishanth Menon
2020-11-13 20:55 ` Nishanth Menon
2020-11-14 4:15 ` Grygorii Strashko
2020-11-14 4:15 ` Grygorii Strashko
2020-11-14 5:56 ` Sekhar Nori
2020-11-14 5:56 ` Sekhar Nori
2020-11-02 19:11 ` [PATCH 2/3] arm64: dts: ti: k3-j7200: Add gpio nodes in wakeup domain Faiz Abbas
2020-11-02 19:11 ` Faiz Abbas
2020-11-02 19:11 ` [PATCH 3/3] arm64: dts: ti: k3-j7200-common-proc-board: Disable unused gpio modules Faiz Abbas
2020-11-02 19:11 ` Faiz Abbas
2020-11-04 11:40 ` [PATCH 0/3] Add gpio support for TI's J7200 platform Lokesh Vutla
2020-11-04 11:40 ` Lokesh Vutla
2020-11-12 16:42 ` Nishanth Menon
2020-11-12 16:42 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201113184020.drntugqsnj7dzsnh@ultimatum \
--to=nm@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=faiz_abbas@ti.com \
--cc=grygorii.strashko@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=nsekhar@ti.com \
--cc=robh+dt@kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.