* [PATCH] counter: microchip-tcb-capture: Fix CMR value check
@ 2020-11-11 16:38 ` William Breathitt Gray
0 siblings, 0 replies; 12+ messages in thread
From: William Breathitt Gray @ 2020-11-11 16:38 UTC (permalink / raw)
To: jic23
Cc: robh+dt, alexandre.belloni, linux-arm-kernel, linux-iio,
linux-kernel, William Breathitt Gray, Kamel Bouhara
The ATMEL_TC_ETRGEDG_* defines are not masks but rather possible values
for CMR. This patch fixes the action_get() callback to properly check
for these values rather than mask them.
Fixes: 106b104137fd ("counter: Add microchip TCB capture counter")
Cc: Kamel Bouhara <kamel.bouhara@bootlin.com>
Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
---
drivers/counter/microchip-tcb-capture.c | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/counter/microchip-tcb-capture.c b/drivers/counter/microchip-tcb-capture.c
index 039c54a78aa5..142b389fc9db 100644
--- a/drivers/counter/microchip-tcb-capture.c
+++ b/drivers/counter/microchip-tcb-capture.c
@@ -183,16 +183,20 @@ static int mchp_tc_count_action_get(struct counter_device *counter,
regmap_read(priv->regmap, ATMEL_TC_REG(priv->channel[0], CMR), &cmr);
- *action = MCHP_TC_SYNAPSE_ACTION_NONE;
-
- if (cmr & ATMEL_TC_ETRGEDG_NONE)
+ switch (cmr & ATMEL_TC_ETRGEDG_BOTH) {
+ default:
*action = MCHP_TC_SYNAPSE_ACTION_NONE;
- else if (cmr & ATMEL_TC_ETRGEDG_RISING)
+ break;
+ case ATMEL_TC_ETRGEDG_RISING:
*action = MCHP_TC_SYNAPSE_ACTION_RISING_EDGE;
- else if (cmr & ATMEL_TC_ETRGEDG_FALLING)
+ break;
+ case ATMEL_TC_ETRGEDG_FALLING:
*action = MCHP_TC_SYNAPSE_ACTION_FALLING_EDGE;
- else if (cmr & ATMEL_TC_ETRGEDG_BOTH)
+ break;
+ case ATMEL_TC_ETRGEDG_BOTH:
*action = MCHP_TC_SYNAPSE_ACTION_BOTH_EDGE;
+ break;
+ }
return 0;
}
--
2.29.2
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH] counter: microchip-tcb-capture: Fix CMR value check @ 2020-11-11 16:38 ` William Breathitt Gray 0 siblings, 0 replies; 12+ messages in thread From: William Breathitt Gray @ 2020-11-11 16:38 UTC (permalink / raw) To: jic23 Cc: Kamel Bouhara, alexandre.belloni, linux-iio, linux-kernel, William Breathitt Gray, robh+dt, linux-arm-kernel The ATMEL_TC_ETRGEDG_* defines are not masks but rather possible values for CMR. This patch fixes the action_get() callback to properly check for these values rather than mask them. Fixes: 106b104137fd ("counter: Add microchip TCB capture counter") Cc: Kamel Bouhara <kamel.bouhara@bootlin.com> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> --- drivers/counter/microchip-tcb-capture.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/counter/microchip-tcb-capture.c b/drivers/counter/microchip-tcb-capture.c index 039c54a78aa5..142b389fc9db 100644 --- a/drivers/counter/microchip-tcb-capture.c +++ b/drivers/counter/microchip-tcb-capture.c @@ -183,16 +183,20 @@ static int mchp_tc_count_action_get(struct counter_device *counter, regmap_read(priv->regmap, ATMEL_TC_REG(priv->channel[0], CMR), &cmr); - *action = MCHP_TC_SYNAPSE_ACTION_NONE; - - if (cmr & ATMEL_TC_ETRGEDG_NONE) + switch (cmr & ATMEL_TC_ETRGEDG_BOTH) { + default: *action = MCHP_TC_SYNAPSE_ACTION_NONE; - else if (cmr & ATMEL_TC_ETRGEDG_RISING) + break; + case ATMEL_TC_ETRGEDG_RISING: *action = MCHP_TC_SYNAPSE_ACTION_RISING_EDGE; - else if (cmr & ATMEL_TC_ETRGEDG_FALLING) + break; + case ATMEL_TC_ETRGEDG_FALLING: *action = MCHP_TC_SYNAPSE_ACTION_FALLING_EDGE; - else if (cmr & ATMEL_TC_ETRGEDG_BOTH) + break; + case ATMEL_TC_ETRGEDG_BOTH: *action = MCHP_TC_SYNAPSE_ACTION_BOTH_EDGE; + break; + } return 0; } -- 2.29.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] counter: microchip-tcb-capture: Fix CMR value check 2020-11-11 16:38 ` William Breathitt Gray @ 2020-11-14 16:03 ` Jonathan Cameron -1 siblings, 0 replies; 12+ messages in thread From: Jonathan Cameron @ 2020-11-14 16:03 UTC (permalink / raw) To: William Breathitt Gray Cc: robh+dt, alexandre.belloni, linux-arm-kernel, linux-iio, linux-kernel, Kamel Bouhara On Wed, 11 Nov 2020 11:38:07 -0500 William Breathitt Gray <vilhelm.gray@gmail.com> wrote: > The ATMEL_TC_ETRGEDG_* defines are not masks but rather possible values > for CMR. This patch fixes the action_get() callback to properly check > for these values rather than mask them. > > Fixes: 106b104137fd ("counter: Add microchip TCB capture counter") > Cc: Kamel Bouhara <kamel.bouhara@bootlin.com> > Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> Looks fine to me, but ideally after an ack from Kamel Thanks, Jonathan > --- > drivers/counter/microchip-tcb-capture.c | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/drivers/counter/microchip-tcb-capture.c b/drivers/counter/microchip-tcb-capture.c > index 039c54a78aa5..142b389fc9db 100644 > --- a/drivers/counter/microchip-tcb-capture.c > +++ b/drivers/counter/microchip-tcb-capture.c > @@ -183,16 +183,20 @@ static int mchp_tc_count_action_get(struct counter_device *counter, > > regmap_read(priv->regmap, ATMEL_TC_REG(priv->channel[0], CMR), &cmr); > > - *action = MCHP_TC_SYNAPSE_ACTION_NONE; > - > - if (cmr & ATMEL_TC_ETRGEDG_NONE) > + switch (cmr & ATMEL_TC_ETRGEDG_BOTH) { > + default: > *action = MCHP_TC_SYNAPSE_ACTION_NONE; > - else if (cmr & ATMEL_TC_ETRGEDG_RISING) > + break; > + case ATMEL_TC_ETRGEDG_RISING: > *action = MCHP_TC_SYNAPSE_ACTION_RISING_EDGE; > - else if (cmr & ATMEL_TC_ETRGEDG_FALLING) > + break; > + case ATMEL_TC_ETRGEDG_FALLING: > *action = MCHP_TC_SYNAPSE_ACTION_FALLING_EDGE; > - else if (cmr & ATMEL_TC_ETRGEDG_BOTH) > + break; > + case ATMEL_TC_ETRGEDG_BOTH: > *action = MCHP_TC_SYNAPSE_ACTION_BOTH_EDGE; > + break; > + } > > return 0; > } ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] counter: microchip-tcb-capture: Fix CMR value check @ 2020-11-14 16:03 ` Jonathan Cameron 0 siblings, 0 replies; 12+ messages in thread From: Jonathan Cameron @ 2020-11-14 16:03 UTC (permalink / raw) To: William Breathitt Gray Cc: Kamel Bouhara, alexandre.belloni, linux-iio, linux-kernel, robh+dt, linux-arm-kernel On Wed, 11 Nov 2020 11:38:07 -0500 William Breathitt Gray <vilhelm.gray@gmail.com> wrote: > The ATMEL_TC_ETRGEDG_* defines are not masks but rather possible values > for CMR. This patch fixes the action_get() callback to properly check > for these values rather than mask them. > > Fixes: 106b104137fd ("counter: Add microchip TCB capture counter") > Cc: Kamel Bouhara <kamel.bouhara@bootlin.com> > Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> Looks fine to me, but ideally after an ack from Kamel Thanks, Jonathan > --- > drivers/counter/microchip-tcb-capture.c | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/drivers/counter/microchip-tcb-capture.c b/drivers/counter/microchip-tcb-capture.c > index 039c54a78aa5..142b389fc9db 100644 > --- a/drivers/counter/microchip-tcb-capture.c > +++ b/drivers/counter/microchip-tcb-capture.c > @@ -183,16 +183,20 @@ static int mchp_tc_count_action_get(struct counter_device *counter, > > regmap_read(priv->regmap, ATMEL_TC_REG(priv->channel[0], CMR), &cmr); > > - *action = MCHP_TC_SYNAPSE_ACTION_NONE; > - > - if (cmr & ATMEL_TC_ETRGEDG_NONE) > + switch (cmr & ATMEL_TC_ETRGEDG_BOTH) { > + default: > *action = MCHP_TC_SYNAPSE_ACTION_NONE; > - else if (cmr & ATMEL_TC_ETRGEDG_RISING) > + break; > + case ATMEL_TC_ETRGEDG_RISING: > *action = MCHP_TC_SYNAPSE_ACTION_RISING_EDGE; > - else if (cmr & ATMEL_TC_ETRGEDG_FALLING) > + break; > + case ATMEL_TC_ETRGEDG_FALLING: > *action = MCHP_TC_SYNAPSE_ACTION_FALLING_EDGE; > - else if (cmr & ATMEL_TC_ETRGEDG_BOTH) > + break; > + case ATMEL_TC_ETRGEDG_BOTH: > *action = MCHP_TC_SYNAPSE_ACTION_BOTH_EDGE; > + break; > + } > > return 0; > } _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] counter: microchip-tcb-capture: Fix CMR value check 2020-11-11 16:38 ` William Breathitt Gray @ 2020-11-14 22:48 ` Alexandre Belloni -1 siblings, 0 replies; 12+ messages in thread From: Alexandre Belloni @ 2020-11-14 22:48 UTC (permalink / raw) To: William Breathitt Gray Cc: jic23, robh+dt, linux-arm-kernel, linux-iio, linux-kernel, Kamel Bouhara On 11/11/2020 11:38:07-0500, William Breathitt Gray wrote: > The ATMEL_TC_ETRGEDG_* defines are not masks but rather possible values > for CMR. This patch fixes the action_get() callback to properly check > for these values rather than mask them. > > Fixes: 106b104137fd ("counter: Add microchip TCB capture counter") > Cc: Kamel Bouhara <kamel.bouhara@bootlin.com> > Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > --- > drivers/counter/microchip-tcb-capture.c | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/drivers/counter/microchip-tcb-capture.c b/drivers/counter/microchip-tcb-capture.c > index 039c54a78aa5..142b389fc9db 100644 > --- a/drivers/counter/microchip-tcb-capture.c > +++ b/drivers/counter/microchip-tcb-capture.c > @@ -183,16 +183,20 @@ static int mchp_tc_count_action_get(struct counter_device *counter, > > regmap_read(priv->regmap, ATMEL_TC_REG(priv->channel[0], CMR), &cmr); > > - *action = MCHP_TC_SYNAPSE_ACTION_NONE; > - > - if (cmr & ATMEL_TC_ETRGEDG_NONE) > + switch (cmr & ATMEL_TC_ETRGEDG_BOTH) { > + default: > *action = MCHP_TC_SYNAPSE_ACTION_NONE; > - else if (cmr & ATMEL_TC_ETRGEDG_RISING) > + break; > + case ATMEL_TC_ETRGEDG_RISING: > *action = MCHP_TC_SYNAPSE_ACTION_RISING_EDGE; > - else if (cmr & ATMEL_TC_ETRGEDG_FALLING) > + break; > + case ATMEL_TC_ETRGEDG_FALLING: > *action = MCHP_TC_SYNAPSE_ACTION_FALLING_EDGE; > - else if (cmr & ATMEL_TC_ETRGEDG_BOTH) > + break; > + case ATMEL_TC_ETRGEDG_BOTH: > *action = MCHP_TC_SYNAPSE_ACTION_BOTH_EDGE; > + break; > + } > > return 0; > } > -- > 2.29.2 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] counter: microchip-tcb-capture: Fix CMR value check @ 2020-11-14 22:48 ` Alexandre Belloni 0 siblings, 0 replies; 12+ messages in thread From: Alexandre Belloni @ 2020-11-14 22:48 UTC (permalink / raw) To: William Breathitt Gray Cc: Kamel Bouhara, linux-iio, linux-kernel, robh+dt, jic23, linux-arm-kernel On 11/11/2020 11:38:07-0500, William Breathitt Gray wrote: > The ATMEL_TC_ETRGEDG_* defines are not masks but rather possible values > for CMR. This patch fixes the action_get() callback to properly check > for these values rather than mask them. > > Fixes: 106b104137fd ("counter: Add microchip TCB capture counter") > Cc: Kamel Bouhara <kamel.bouhara@bootlin.com> > Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > --- > drivers/counter/microchip-tcb-capture.c | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/drivers/counter/microchip-tcb-capture.c b/drivers/counter/microchip-tcb-capture.c > index 039c54a78aa5..142b389fc9db 100644 > --- a/drivers/counter/microchip-tcb-capture.c > +++ b/drivers/counter/microchip-tcb-capture.c > @@ -183,16 +183,20 @@ static int mchp_tc_count_action_get(struct counter_device *counter, > > regmap_read(priv->regmap, ATMEL_TC_REG(priv->channel[0], CMR), &cmr); > > - *action = MCHP_TC_SYNAPSE_ACTION_NONE; > - > - if (cmr & ATMEL_TC_ETRGEDG_NONE) > + switch (cmr & ATMEL_TC_ETRGEDG_BOTH) { > + default: > *action = MCHP_TC_SYNAPSE_ACTION_NONE; > - else if (cmr & ATMEL_TC_ETRGEDG_RISING) > + break; > + case ATMEL_TC_ETRGEDG_RISING: > *action = MCHP_TC_SYNAPSE_ACTION_RISING_EDGE; > - else if (cmr & ATMEL_TC_ETRGEDG_FALLING) > + break; > + case ATMEL_TC_ETRGEDG_FALLING: > *action = MCHP_TC_SYNAPSE_ACTION_FALLING_EDGE; > - else if (cmr & ATMEL_TC_ETRGEDG_BOTH) > + break; > + case ATMEL_TC_ETRGEDG_BOTH: > *action = MCHP_TC_SYNAPSE_ACTION_BOTH_EDGE; > + break; > + } > > return 0; > } > -- > 2.29.2 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] counter: microchip-tcb-capture: Fix CMR value check 2020-11-14 22:48 ` Alexandre Belloni @ 2020-11-14 22:51 ` Alexandre Belloni -1 siblings, 0 replies; 12+ messages in thread From: Alexandre Belloni @ 2020-11-14 22:51 UTC (permalink / raw) To: William Breathitt Gray Cc: jic23, robh+dt, linux-arm-kernel, linux-iio, linux-kernel, Kamel Bouhara On 14/11/2020 23:48:28+0100, Alexandre Belloni wrote: > On 11/11/2020 11:38:07-0500, William Breathitt Gray wrote: > > The ATMEL_TC_ETRGEDG_* defines are not masks but rather possible values > > for CMR. This patch fixes the action_get() callback to properly check > > for these values rather than mask them. > > > > Fixes: 106b104137fd ("counter: Add microchip TCB capture counter") > > Cc: Kamel Bouhara <kamel.bouhara@bootlin.com> > > Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> > Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > > > --- > > drivers/counter/microchip-tcb-capture.c | 16 ++++++++++------ > > 1 file changed, 10 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/counter/microchip-tcb-capture.c b/drivers/counter/microchip-tcb-capture.c > > index 039c54a78aa5..142b389fc9db 100644 > > --- a/drivers/counter/microchip-tcb-capture.c > > +++ b/drivers/counter/microchip-tcb-capture.c > > @@ -183,16 +183,20 @@ static int mchp_tc_count_action_get(struct counter_device *counter, > > > > regmap_read(priv->regmap, ATMEL_TC_REG(priv->channel[0], CMR), &cmr); > > > > - *action = MCHP_TC_SYNAPSE_ACTION_NONE; > > - > > - if (cmr & ATMEL_TC_ETRGEDG_NONE) > > + switch (cmr & ATMEL_TC_ETRGEDG_BOTH) { BTW, this could be simply ATMEL_TC_ETRGEDG which is the mask. > > + default: > > *action = MCHP_TC_SYNAPSE_ACTION_NONE; > > - else if (cmr & ATMEL_TC_ETRGEDG_RISING) > > + break; > > + case ATMEL_TC_ETRGEDG_RISING: > > *action = MCHP_TC_SYNAPSE_ACTION_RISING_EDGE; > > - else if (cmr & ATMEL_TC_ETRGEDG_FALLING) > > + break; > > + case ATMEL_TC_ETRGEDG_FALLING: > > *action = MCHP_TC_SYNAPSE_ACTION_FALLING_EDGE; > > - else if (cmr & ATMEL_TC_ETRGEDG_BOTH) > > + break; > > + case ATMEL_TC_ETRGEDG_BOTH: > > *action = MCHP_TC_SYNAPSE_ACTION_BOTH_EDGE; > > + break; > > + } > > > > return 0; > > } > > -- > > 2.29.2 > > > > -- > Alexandre Belloni, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] counter: microchip-tcb-capture: Fix CMR value check @ 2020-11-14 22:51 ` Alexandre Belloni 0 siblings, 0 replies; 12+ messages in thread From: Alexandre Belloni @ 2020-11-14 22:51 UTC (permalink / raw) To: William Breathitt Gray Cc: Kamel Bouhara, linux-iio, linux-kernel, robh+dt, jic23, linux-arm-kernel On 14/11/2020 23:48:28+0100, Alexandre Belloni wrote: > On 11/11/2020 11:38:07-0500, William Breathitt Gray wrote: > > The ATMEL_TC_ETRGEDG_* defines are not masks but rather possible values > > for CMR. This patch fixes the action_get() callback to properly check > > for these values rather than mask them. > > > > Fixes: 106b104137fd ("counter: Add microchip TCB capture counter") > > Cc: Kamel Bouhara <kamel.bouhara@bootlin.com> > > Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> > Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > > > --- > > drivers/counter/microchip-tcb-capture.c | 16 ++++++++++------ > > 1 file changed, 10 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/counter/microchip-tcb-capture.c b/drivers/counter/microchip-tcb-capture.c > > index 039c54a78aa5..142b389fc9db 100644 > > --- a/drivers/counter/microchip-tcb-capture.c > > +++ b/drivers/counter/microchip-tcb-capture.c > > @@ -183,16 +183,20 @@ static int mchp_tc_count_action_get(struct counter_device *counter, > > > > regmap_read(priv->regmap, ATMEL_TC_REG(priv->channel[0], CMR), &cmr); > > > > - *action = MCHP_TC_SYNAPSE_ACTION_NONE; > > - > > - if (cmr & ATMEL_TC_ETRGEDG_NONE) > > + switch (cmr & ATMEL_TC_ETRGEDG_BOTH) { BTW, this could be simply ATMEL_TC_ETRGEDG which is the mask. > > + default: > > *action = MCHP_TC_SYNAPSE_ACTION_NONE; > > - else if (cmr & ATMEL_TC_ETRGEDG_RISING) > > + break; > > + case ATMEL_TC_ETRGEDG_RISING: > > *action = MCHP_TC_SYNAPSE_ACTION_RISING_EDGE; > > - else if (cmr & ATMEL_TC_ETRGEDG_FALLING) > > + break; > > + case ATMEL_TC_ETRGEDG_FALLING: > > *action = MCHP_TC_SYNAPSE_ACTION_FALLING_EDGE; > > - else if (cmr & ATMEL_TC_ETRGEDG_BOTH) > > + break; > > + case ATMEL_TC_ETRGEDG_BOTH: > > *action = MCHP_TC_SYNAPSE_ACTION_BOTH_EDGE; > > + break; > > + } > > > > return 0; > > } > > -- > > 2.29.2 > > > > -- > Alexandre Belloni, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] counter: microchip-tcb-capture: Fix CMR value check 2020-11-14 22:51 ` Alexandre Belloni @ 2020-11-14 22:58 ` William Breathitt Gray -1 siblings, 0 replies; 12+ messages in thread From: William Breathitt Gray @ 2020-11-14 22:58 UTC (permalink / raw) To: Alexandre Belloni, Kamel Bouhara Cc: jic23, robh+dt, linux-arm-kernel, linux-iio, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1823 bytes --] On Sat, Nov 14, 2020 at 11:51:13PM +0100, Alexandre Belloni wrote: > On 14/11/2020 23:48:28+0100, Alexandre Belloni wrote: > > On 11/11/2020 11:38:07-0500, William Breathitt Gray wrote: > > > The ATMEL_TC_ETRGEDG_* defines are not masks but rather possible values > > > for CMR. This patch fixes the action_get() callback to properly check > > > for these values rather than mask them. > > > > > > Fixes: 106b104137fd ("counter: Add microchip TCB capture counter") > > > Cc: Kamel Bouhara <kamel.bouhara@bootlin.com> > > > Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> > > Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > > > > > --- > > > drivers/counter/microchip-tcb-capture.c | 16 ++++++++++------ > > > 1 file changed, 10 insertions(+), 6 deletions(-) > > > > > > diff --git a/drivers/counter/microchip-tcb-capture.c b/drivers/counter/microchip-tcb-capture.c > > > index 039c54a78aa5..142b389fc9db 100644 > > > --- a/drivers/counter/microchip-tcb-capture.c > > > +++ b/drivers/counter/microchip-tcb-capture.c > > > @@ -183,16 +183,20 @@ static int mchp_tc_count_action_get(struct counter_device *counter, > > > > > > regmap_read(priv->regmap, ATMEL_TC_REG(priv->channel[0], CMR), &cmr); > > > > > > - *action = MCHP_TC_SYNAPSE_ACTION_NONE; > > > - > > > - if (cmr & ATMEL_TC_ETRGEDG_NONE) > > > + switch (cmr & ATMEL_TC_ETRGEDG_BOTH) { > > BTW, this could be simply ATMEL_TC_ETRGEDG which is the mask. You're right, let me resubmit this patch with that change since it'll be much clearer. By the way, microchip-tcb-capture.c is missing a MAINTAINERS entry. Is Kamel the maintainer of this driver? I'd like to get a proper entry added so we have a point of contact in case of future bugs and changes. Thanks, William Breathitt Gray [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] counter: microchip-tcb-capture: Fix CMR value check @ 2020-11-14 22:58 ` William Breathitt Gray 0 siblings, 0 replies; 12+ messages in thread From: William Breathitt Gray @ 2020-11-14 22:58 UTC (permalink / raw) To: Alexandre Belloni, Kamel Bouhara Cc: linux-iio, robh+dt, linux-arm-kernel, jic23, linux-kernel [-- Attachment #1.1: Type: text/plain, Size: 1823 bytes --] On Sat, Nov 14, 2020 at 11:51:13PM +0100, Alexandre Belloni wrote: > On 14/11/2020 23:48:28+0100, Alexandre Belloni wrote: > > On 11/11/2020 11:38:07-0500, William Breathitt Gray wrote: > > > The ATMEL_TC_ETRGEDG_* defines are not masks but rather possible values > > > for CMR. This patch fixes the action_get() callback to properly check > > > for these values rather than mask them. > > > > > > Fixes: 106b104137fd ("counter: Add microchip TCB capture counter") > > > Cc: Kamel Bouhara <kamel.bouhara@bootlin.com> > > > Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> > > Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > > > > > --- > > > drivers/counter/microchip-tcb-capture.c | 16 ++++++++++------ > > > 1 file changed, 10 insertions(+), 6 deletions(-) > > > > > > diff --git a/drivers/counter/microchip-tcb-capture.c b/drivers/counter/microchip-tcb-capture.c > > > index 039c54a78aa5..142b389fc9db 100644 > > > --- a/drivers/counter/microchip-tcb-capture.c > > > +++ b/drivers/counter/microchip-tcb-capture.c > > > @@ -183,16 +183,20 @@ static int mchp_tc_count_action_get(struct counter_device *counter, > > > > > > regmap_read(priv->regmap, ATMEL_TC_REG(priv->channel[0], CMR), &cmr); > > > > > > - *action = MCHP_TC_SYNAPSE_ACTION_NONE; > > > - > > > - if (cmr & ATMEL_TC_ETRGEDG_NONE) > > > + switch (cmr & ATMEL_TC_ETRGEDG_BOTH) { > > BTW, this could be simply ATMEL_TC_ETRGEDG which is the mask. You're right, let me resubmit this patch with that change since it'll be much clearer. By the way, microchip-tcb-capture.c is missing a MAINTAINERS entry. Is Kamel the maintainer of this driver? I'd like to get a proper entry added so we have a point of contact in case of future bugs and changes. Thanks, William Breathitt Gray [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] counter: microchip-tcb-capture: Fix CMR value check 2020-11-14 22:58 ` William Breathitt Gray @ 2020-11-15 15:23 ` Kamel Bouhara -1 siblings, 0 replies; 12+ messages in thread From: Kamel Bouhara @ 2020-11-15 15:23 UTC (permalink / raw) To: William Breathitt Gray Cc: Alexandre Belloni, jic23, robh+dt, linux-arm-kernel, linux-iio, linux-kernel On Sat, Nov 14, 2020 at 05:58:28PM -0500, William Breathitt Gray wrote: > On Sat, Nov 14, 2020 at 11:51:13PM +0100, Alexandre Belloni wrote: > > On 14/11/2020 23:48:28+0100, Alexandre Belloni wrote: > > > On 11/11/2020 11:38:07-0500, William Breathitt Gray wrote: > > > > The ATMEL_TC_ETRGEDG_* defines are not masks but rather possible values > > > > for CMR. This patch fixes the action_get() callback to properly check > > > > for these values rather than mask them. > > > > > > > > Fixes: 106b104137fd ("counter: Add microchip TCB capture counter") > > > > Cc: Kamel Bouhara <kamel.bouhara@bootlin.com> > > > > Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> > > > Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > > > > > > > --- > > > > drivers/counter/microchip-tcb-capture.c | 16 ++++++++++------ > > > > 1 file changed, 10 insertions(+), 6 deletions(-) > > > > > > > > diff --git a/drivers/counter/microchip-tcb-capture.c b/drivers/counter/microchip-tcb-capture.c > > > > index 039c54a78aa5..142b389fc9db 100644 > > > > --- a/drivers/counter/microchip-tcb-capture.c > > > > +++ b/drivers/counter/microchip-tcb-capture.c > > > > @@ -183,16 +183,20 @@ static int mchp_tc_count_action_get(struct counter_device *counter, > > > > > > > > regmap_read(priv->regmap, ATMEL_TC_REG(priv->channel[0], CMR), &cmr); > > > > > > > > - *action = MCHP_TC_SYNAPSE_ACTION_NONE; > > > > - > > > > - if (cmr & ATMEL_TC_ETRGEDG_NONE) > > > > + switch (cmr & ATMEL_TC_ETRGEDG_BOTH) { > > > > BTW, this could be simply ATMEL_TC_ETRGEDG which is the mask. > > You're right, let me resubmit this patch with that change since it'll be > much clearer. > > By the way, microchip-tcb-capture.c is missing a MAINTAINERS entry. Is > Kamel the maintainer of this driver? I'd like to get a proper entry > added so we have a point of contact in case of future bugs and changes. > Hello William, Thanks for the patch, indeed Im the maintainer of this driver. Regards, Kamel > Thanks, > > William Breathitt Gray -- Kamel Bouhara, Bootlin Embedded Linux and kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] counter: microchip-tcb-capture: Fix CMR value check @ 2020-11-15 15:23 ` Kamel Bouhara 0 siblings, 0 replies; 12+ messages in thread From: Kamel Bouhara @ 2020-11-15 15:23 UTC (permalink / raw) To: William Breathitt Gray Cc: Alexandre Belloni, linux-iio, linux-kernel, robh+dt, jic23, linux-arm-kernel On Sat, Nov 14, 2020 at 05:58:28PM -0500, William Breathitt Gray wrote: > On Sat, Nov 14, 2020 at 11:51:13PM +0100, Alexandre Belloni wrote: > > On 14/11/2020 23:48:28+0100, Alexandre Belloni wrote: > > > On 11/11/2020 11:38:07-0500, William Breathitt Gray wrote: > > > > The ATMEL_TC_ETRGEDG_* defines are not masks but rather possible values > > > > for CMR. This patch fixes the action_get() callback to properly check > > > > for these values rather than mask them. > > > > > > > > Fixes: 106b104137fd ("counter: Add microchip TCB capture counter") > > > > Cc: Kamel Bouhara <kamel.bouhara@bootlin.com> > > > > Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> > > > Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > > > > > > > --- > > > > drivers/counter/microchip-tcb-capture.c | 16 ++++++++++------ > > > > 1 file changed, 10 insertions(+), 6 deletions(-) > > > > > > > > diff --git a/drivers/counter/microchip-tcb-capture.c b/drivers/counter/microchip-tcb-capture.c > > > > index 039c54a78aa5..142b389fc9db 100644 > > > > --- a/drivers/counter/microchip-tcb-capture.c > > > > +++ b/drivers/counter/microchip-tcb-capture.c > > > > @@ -183,16 +183,20 @@ static int mchp_tc_count_action_get(struct counter_device *counter, > > > > > > > > regmap_read(priv->regmap, ATMEL_TC_REG(priv->channel[0], CMR), &cmr); > > > > > > > > - *action = MCHP_TC_SYNAPSE_ACTION_NONE; > > > > - > > > > - if (cmr & ATMEL_TC_ETRGEDG_NONE) > > > > + switch (cmr & ATMEL_TC_ETRGEDG_BOTH) { > > > > BTW, this could be simply ATMEL_TC_ETRGEDG which is the mask. > > You're right, let me resubmit this patch with that change since it'll be > much clearer. > > By the way, microchip-tcb-capture.c is missing a MAINTAINERS entry. Is > Kamel the maintainer of this driver? I'd like to get a proper entry > added so we have a point of contact in case of future bugs and changes. > Hello William, Thanks for the patch, indeed Im the maintainer of this driver. Regards, Kamel > Thanks, > > William Breathitt Gray -- Kamel Bouhara, Bootlin Embedded Linux and kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2020-11-15 15:33 UTC | newest] Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-11-11 16:38 [PATCH] counter: microchip-tcb-capture: Fix CMR value check William Breathitt Gray 2020-11-11 16:38 ` William Breathitt Gray 2020-11-14 16:03 ` Jonathan Cameron 2020-11-14 16:03 ` Jonathan Cameron 2020-11-14 22:48 ` Alexandre Belloni 2020-11-14 22:48 ` Alexandre Belloni 2020-11-14 22:51 ` Alexandre Belloni 2020-11-14 22:51 ` Alexandre Belloni 2020-11-14 22:58 ` William Breathitt Gray 2020-11-14 22:58 ` William Breathitt Gray 2020-11-15 15:23 ` Kamel Bouhara 2020-11-15 15:23 ` Kamel Bouhara
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.