From: Peter Zijlstra <peterz@infradead.org>
To: Ionela Voinescu <ionela.voinescu@arm.com>
Cc: mingo@redhat.com, vincent.guittot@linaro.org,
catalin.marinas@arm.com, will@kernel.org, rjw@rjwysocki.net,
viresh.kumar@linaro.org, dietmar.eggemann@arm.com,
qperret@google.com, valentin.schneider@arm.com,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v2 0/3] condition EAS enablement on FI support
Date: Wed, 18 Nov 2020 15:01:41 +0100 [thread overview]
Message-ID: <20201118140141.GT3121392@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20201118114233.GB9782@arm.com>
On Wed, Nov 18, 2020 at 11:42:34AM +0000, Ionela Voinescu wrote:
> Hi guys,
>
> On Tuesday 27 Oct 2020 at 18:07:10 (+0000), Ionela Voinescu wrote:
> > Given the maturity gained by cpufreq-based Frequency Invariance (FI)
> > support following the patches at [1], this series conditions Energy
> > Aware Scheduling (EAS) enablement on a frequency invariant system.
> >
> > Currently, EAS can be enabled on a system without FI support, leading
> > to incorrect (energy-wise) task placements. As no warning is emitted,
> > it could take some debugging effort to track the behavior back to the
> > lack of FI support; this series changes that by disabling EAS
> > (and advertising it) when FI support is missing.
> >
> > The series is structured as follows:
> > - 1/3 - create function that can rebuild the scheduling and EAS'
> > performance domains if EAS' initial conditions change
> > - 2/3 - arm64: rebuild scheduling and performance domains in the
> > case of late, counter-driven FI initialisation.
> > - 3/3 - condition EAS enablement on FI support
> >
> > RESEND v2: rebase and retest on v5.10-rc1
> >
>
> This still applies nicely on v5.10-rc4.
>
> Peter, given that 1/3 and 2/3 are acked, do you think there's anything
> else that needs to be done for this?
I'll take it, thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Ionela Voinescu <ionela.voinescu@arm.com>
Cc: vincent.guittot@linaro.org, qperret@google.com,
catalin.marinas@arm.com, linux-pm@vger.kernel.org,
rjw@rjwysocki.net, linux-kernel@vger.kernel.org,
valentin.schneider@arm.com, mingo@redhat.com,
viresh.kumar@linaro.org, will@kernel.org,
dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RESEND v2 0/3] condition EAS enablement on FI support
Date: Wed, 18 Nov 2020 15:01:41 +0100 [thread overview]
Message-ID: <20201118140141.GT3121392@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20201118114233.GB9782@arm.com>
On Wed, Nov 18, 2020 at 11:42:34AM +0000, Ionela Voinescu wrote:
> Hi guys,
>
> On Tuesday 27 Oct 2020 at 18:07:10 (+0000), Ionela Voinescu wrote:
> > Given the maturity gained by cpufreq-based Frequency Invariance (FI)
> > support following the patches at [1], this series conditions Energy
> > Aware Scheduling (EAS) enablement on a frequency invariant system.
> >
> > Currently, EAS can be enabled on a system without FI support, leading
> > to incorrect (energy-wise) task placements. As no warning is emitted,
> > it could take some debugging effort to track the behavior back to the
> > lack of FI support; this series changes that by disabling EAS
> > (and advertising it) when FI support is missing.
> >
> > The series is structured as follows:
> > - 1/3 - create function that can rebuild the scheduling and EAS'
> > performance domains if EAS' initial conditions change
> > - 2/3 - arm64: rebuild scheduling and performance domains in the
> > case of late, counter-driven FI initialisation.
> > - 3/3 - condition EAS enablement on FI support
> >
> > RESEND v2: rebase and retest on v5.10-rc1
> >
>
> This still applies nicely on v5.10-rc4.
>
> Peter, given that 1/3 and 2/3 are acked, do you think there's anything
> else that needs to be done for this?
I'll take it, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-18 14:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 18:07 [PATCH RESEND v2 0/3] condition EAS enablement on FI support Ionela Voinescu
2020-10-27 18:07 ` Ionela Voinescu
2020-10-27 18:07 ` [PATCH RESEND v2 1/3] sched/topology,schedutil: wrap sched domains rebuild Ionela Voinescu
2020-10-27 18:07 ` [PATCH RESEND v2 1/3] sched/topology, schedutil: " Ionela Voinescu
2020-10-30 15:26 ` [PATCH RESEND v2 1/3] sched/topology,schedutil: " Rafael J. Wysocki
2020-10-30 15:26 ` Rafael J. Wysocki
2020-11-05 14:03 ` Ionela Voinescu
2020-11-05 14:03 ` Ionela Voinescu
2020-11-20 12:34 ` [tip: sched/core] sched/topology,schedutil: Wrap " tip-bot2 for Ionela Voinescu
2020-10-27 18:07 ` [PATCH RESEND v2 2/3] arm64: rebuild sched domains on invariance status changes Ionela Voinescu
2020-10-27 18:07 ` Ionela Voinescu
2020-11-10 17:20 ` Catalin Marinas
2020-11-10 17:20 ` Catalin Marinas
2020-11-20 12:34 ` [tip: sched/core] arm64: Rebuild " tip-bot2 for Ionela Voinescu
2020-10-27 18:07 ` [PATCH RESEND v2 3/3] sched/topology: condition EAS enablement on FIE support Ionela Voinescu
2020-10-27 18:07 ` Ionela Voinescu
2020-11-20 12:34 ` [tip: sched/core] sched/topology: Condition " tip-bot2 for Ionela Voinescu
2020-11-18 11:42 ` [PATCH RESEND v2 0/3] condition EAS enablement on FI support Ionela Voinescu
2020-11-18 11:42 ` Ionela Voinescu
2020-11-18 14:01 ` Peter Zijlstra [this message]
2020-11-18 14:01 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201118140141.GT3121392@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=catalin.marinas@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=ionela.voinescu@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=qperret@google.com \
--cc=rjw@rjwysocki.net \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.