From: Ionela Voinescu <ionela.voinescu@arm.com> To: mingo@redhat.com, peterz@infradead.org, vincent.guittot@linaro.org, catalin.marinas@arm.com, will@kernel.org, rjw@rjwysocki.net, viresh.kumar@linaro.org Cc: dietmar.eggemann@arm.com, qperret@google.com, valentin.schneider@arm.com, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND v2 0/3] condition EAS enablement on FI support Date: Wed, 18 Nov 2020 11:42:34 +0000 [thread overview] Message-ID: <20201118114233.GB9782@arm.com> (raw) In-Reply-To: <20201027180713.7642-1-ionela.voinescu@arm.com> Hi guys, On Tuesday 27 Oct 2020 at 18:07:10 (+0000), Ionela Voinescu wrote: > Given the maturity gained by cpufreq-based Frequency Invariance (FI) > support following the patches at [1], this series conditions Energy > Aware Scheduling (EAS) enablement on a frequency invariant system. > > Currently, EAS can be enabled on a system without FI support, leading > to incorrect (energy-wise) task placements. As no warning is emitted, > it could take some debugging effort to track the behavior back to the > lack of FI support; this series changes that by disabling EAS > (and advertising it) when FI support is missing. > > The series is structured as follows: > - 1/3 - create function that can rebuild the scheduling and EAS' > performance domains if EAS' initial conditions change > - 2/3 - arm64: rebuild scheduling and performance domains in the > case of late, counter-driven FI initialisation. > - 3/3 - condition EAS enablement on FI support > > RESEND v2: rebase and retest on v5.10-rc1 > This still applies nicely on v5.10-rc4. Peter, given that 1/3 and 2/3 are acked, do you think there's anything else that needs to be done for this? Thank you, Ionela. > v1 -> v2: > - v1 can be found at [2] > - 1/2 - moved now "static inline" rebuild_sched_domains_energy() stub > in sched/topology.h header, as suggested by Quentin. > - Changed the order of 2/3 and 3/3 to maintain bisection as suggested > by Quentin. > - 3/3 - place the warning under sched_debug() as per Quentin and > Dietmar's recommendations. > > [1] Most recent version at: > https://lore.kernel.org/lkml/20200901205549.30096-1-ionela.voinescu@arm.com/ > [2] https://lore.kernel.org/lkml/20200924123937.20938-1-ionela.voinescu@arm.com/ > > Many thanks, > Ionela. > > Ionela Voinescu (3): > sched/topology,schedutil: wrap sched domains rebuild > arm64: rebuild sched domains on invariance status changes > sched/topology: condition EAS enablement on FIE support > > arch/arm64/kernel/topology.c | 10 ++++++++++ > include/linux/sched/topology.h | 8 ++++++++ > kernel/sched/cpufreq_schedutil.c | 9 +-------- > kernel/sched/topology.c | 27 ++++++++++++++++++++------- > 4 files changed, 39 insertions(+), 15 deletions(-) > > > base-commit: 3650b228f83adda7e5ee532e2b90429c03f7b9ec > -- > 2.17.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Ionela Voinescu <ionela.voinescu@arm.com> To: mingo@redhat.com, peterz@infradead.org, vincent.guittot@linaro.org, catalin.marinas@arm.com, will@kernel.org, rjw@rjwysocki.net, viresh.kumar@linaro.org Cc: linux-pm@vger.kernel.org, qperret@google.com, linux-kernel@vger.kernel.org, dietmar.eggemann@arm.com, valentin.schneider@arm.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH RESEND v2 0/3] condition EAS enablement on FI support Date: Wed, 18 Nov 2020 11:42:34 +0000 [thread overview] Message-ID: <20201118114233.GB9782@arm.com> (raw) In-Reply-To: <20201027180713.7642-1-ionela.voinescu@arm.com> Hi guys, On Tuesday 27 Oct 2020 at 18:07:10 (+0000), Ionela Voinescu wrote: > Given the maturity gained by cpufreq-based Frequency Invariance (FI) > support following the patches at [1], this series conditions Energy > Aware Scheduling (EAS) enablement on a frequency invariant system. > > Currently, EAS can be enabled on a system without FI support, leading > to incorrect (energy-wise) task placements. As no warning is emitted, > it could take some debugging effort to track the behavior back to the > lack of FI support; this series changes that by disabling EAS > (and advertising it) when FI support is missing. > > The series is structured as follows: > - 1/3 - create function that can rebuild the scheduling and EAS' > performance domains if EAS' initial conditions change > - 2/3 - arm64: rebuild scheduling and performance domains in the > case of late, counter-driven FI initialisation. > - 3/3 - condition EAS enablement on FI support > > RESEND v2: rebase and retest on v5.10-rc1 > This still applies nicely on v5.10-rc4. Peter, given that 1/3 and 2/3 are acked, do you think there's anything else that needs to be done for this? Thank you, Ionela. > v1 -> v2: > - v1 can be found at [2] > - 1/2 - moved now "static inline" rebuild_sched_domains_energy() stub > in sched/topology.h header, as suggested by Quentin. > - Changed the order of 2/3 and 3/3 to maintain bisection as suggested > by Quentin. > - 3/3 - place the warning under sched_debug() as per Quentin and > Dietmar's recommendations. > > [1] Most recent version at: > https://lore.kernel.org/lkml/20200901205549.30096-1-ionela.voinescu@arm.com/ > [2] https://lore.kernel.org/lkml/20200924123937.20938-1-ionela.voinescu@arm.com/ > > Many thanks, > Ionela. > > Ionela Voinescu (3): > sched/topology,schedutil: wrap sched domains rebuild > arm64: rebuild sched domains on invariance status changes > sched/topology: condition EAS enablement on FIE support > > arch/arm64/kernel/topology.c | 10 ++++++++++ > include/linux/sched/topology.h | 8 ++++++++ > kernel/sched/cpufreq_schedutil.c | 9 +-------- > kernel/sched/topology.c | 27 ++++++++++++++++++++------- > 4 files changed, 39 insertions(+), 15 deletions(-) > > > base-commit: 3650b228f83adda7e5ee532e2b90429c03f7b9ec > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-18 11:42 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-27 18:07 [PATCH RESEND v2 0/3] condition EAS enablement on FI support Ionela Voinescu 2020-10-27 18:07 ` Ionela Voinescu 2020-10-27 18:07 ` [PATCH RESEND v2 1/3] sched/topology,schedutil: wrap sched domains rebuild Ionela Voinescu 2020-10-27 18:07 ` [PATCH RESEND v2 1/3] sched/topology, schedutil: " Ionela Voinescu 2020-10-30 15:26 ` [PATCH RESEND v2 1/3] sched/topology,schedutil: " Rafael J. Wysocki 2020-10-30 15:26 ` Rafael J. Wysocki 2020-11-05 14:03 ` Ionela Voinescu 2020-11-05 14:03 ` Ionela Voinescu 2020-11-20 12:34 ` [tip: sched/core] sched/topology,schedutil: Wrap " tip-bot2 for Ionela Voinescu 2020-10-27 18:07 ` [PATCH RESEND v2 2/3] arm64: rebuild sched domains on invariance status changes Ionela Voinescu 2020-10-27 18:07 ` Ionela Voinescu 2020-11-10 17:20 ` Catalin Marinas 2020-11-10 17:20 ` Catalin Marinas 2020-11-20 12:34 ` [tip: sched/core] arm64: Rebuild " tip-bot2 for Ionela Voinescu 2020-10-27 18:07 ` [PATCH RESEND v2 3/3] sched/topology: condition EAS enablement on FIE support Ionela Voinescu 2020-10-27 18:07 ` Ionela Voinescu 2020-11-20 12:34 ` [tip: sched/core] sched/topology: Condition " tip-bot2 for Ionela Voinescu 2020-11-18 11:42 ` Ionela Voinescu [this message] 2020-11-18 11:42 ` [PATCH RESEND v2 0/3] condition EAS enablement on FI support Ionela Voinescu 2020-11-18 14:01 ` Peter Zijlstra 2020-11-18 14:01 ` Peter Zijlstra
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201118114233.GB9782@arm.com \ --to=ionela.voinescu@arm.com \ --cc=catalin.marinas@arm.com \ --cc=dietmar.eggemann@arm.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=mingo@redhat.com \ --cc=peterz@infradead.org \ --cc=qperret@google.com \ --cc=rjw@rjwysocki.net \ --cc=valentin.schneider@arm.com \ --cc=vincent.guittot@linaro.org \ --cc=viresh.kumar@linaro.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.