[Buildroot] [PATCH v1] package/libcamera: fix BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS handling

[Buildroot] [PATCH v1] package/libcamera: fix BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS handling

[Peter Seiderer]

Fix BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS handling, change from
'depends on BR2_m68k' to 'depends on !BR2_m68k'.

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/libcamera/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in
index aadea56d19..b9c243084e 100644
--- a/package/libcamera/Config.in
+++ b/package/libcamera/Config.in
@@ -2,7 +2,7 @@ config BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS
 	bool
 	default y
 	# Invalid packing size of ControlValue struct on m68k
-	depends on BR2_m68k
+	depends on !BR2_m68k
 
 menuconfig BR2_PACKAGE_LIBCAMERA
 	bool "libcamera"
-- 
2.29.2

[Buildroot] [PATCH v1] package/libcamera: fix BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS handling

[Kieran Bingham]

Hi Peter,

On 17/11/2020 21:25, Peter Seiderer wrote:
> Fix BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS handling, change from
> 'depends on BR2_m68k' to 'depends on !BR2_m68k'.
> 
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
>  package/libcamera/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in
> index aadea56d19..b9c243084e 100644
> --- a/package/libcamera/Config.in
> +++ b/package/libcamera/Config.in
> @@ -2,7 +2,7 @@ config BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS
>  	bool
>  	default y
>  	# Invalid packing size of ControlValue struct on m68k
> -	depends on BR2_m68k
> +	depends on !BR2_m68k

Oh dear, this was definitely negated in the patch I submitted [0], but
looks like it landed as this in [1], which was incorrect.

[0]
https://lists.libcamera.org/pipermail/libcamera-devel/2020-September/012519.html

[1]
https://git.buildroot.net/buildroot/commit/?id=66526e3518e01a3fe16dede165c7890d194b7816

Fix looks good to me.

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>


>  
>  menuconfig BR2_PACKAGE_LIBCAMERA
>  	bool "libcamera"
> 

-- 
Regards
--
Kieran

[Buildroot] [PATCH v1] package/libcamera: fix BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS handling

[Yann E. MORIN]

Peter, All,

On 2020-11-17 22:25 +0100, Peter Seiderer spake thusly:
> Fix BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS handling, change from
> 'depends on BR2_m68k' to 'depends on !BR2_m68k'.

Uh-oh... My bad...

> Signed-off-by: Peter Seiderer <ps.report@gmx.net>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/libcamera/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in
> index aadea56d19..b9c243084e 100644
> --- a/package/libcamera/Config.in
> +++ b/package/libcamera/Config.in
> @@ -2,7 +2,7 @@ config BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS
>  	bool
>  	default y
>  	# Invalid packing size of ControlValue struct on m68k
> -	depends on BR2_m68k
> +	depends on !BR2_m68k
>  
>  menuconfig BR2_PACKAGE_LIBCAMERA
>  	bool "libcamera"
> -- 
> 2.29.2
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH v1] package/libcamera: fix BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS handling

[Peter Korsgaard]

>>>>> "Peter" == Peter Seiderer <ps.report@gmx.net> writes:

 > Fix BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS handling, change from
 > 'depends on BR2_m68k' to 'depends on !BR2_m68k'.

 > Signed-off-by: Peter Seiderer <ps.report@gmx.net>

Committed to 2020.08.x, thanks.

-- 
Bye, Peter Korsgaard