* [Buildroot] [PATCH v1] package/libcamera: fix BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS handling
@ 2020-11-17 21:25 Peter Seiderer
2020-11-17 22:36 ` Kieran Bingham
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Peter Seiderer @ 2020-11-17 21:25 UTC (permalink / raw)
To: buildroot
Fix BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS handling, change from
'depends on BR2_m68k' to 'depends on !BR2_m68k'.
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
package/libcamera/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in
index aadea56d19..b9c243084e 100644
--- a/package/libcamera/Config.in
+++ b/package/libcamera/Config.in
@@ -2,7 +2,7 @@ config BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS
bool
default y
# Invalid packing size of ControlValue struct on m68k
- depends on BR2_m68k
+ depends on !BR2_m68k
menuconfig BR2_PACKAGE_LIBCAMERA
bool "libcamera"
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Buildroot] [PATCH v1] package/libcamera: fix BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS handling
2020-11-17 21:25 [Buildroot] [PATCH v1] package/libcamera: fix BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS handling Peter Seiderer
@ 2020-11-17 22:36 ` Kieran Bingham
2020-11-19 18:40 ` Yann E. MORIN
2020-12-06 22:25 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Kieran Bingham @ 2020-11-17 22:36 UTC (permalink / raw)
To: buildroot
Hi Peter,
On 17/11/2020 21:25, Peter Seiderer wrote:
> Fix BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS handling, change from
> 'depends on BR2_m68k' to 'depends on !BR2_m68k'.
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> package/libcamera/Config.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in
> index aadea56d19..b9c243084e 100644
> --- a/package/libcamera/Config.in
> +++ b/package/libcamera/Config.in
> @@ -2,7 +2,7 @@ config BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS
> bool
> default y
> # Invalid packing size of ControlValue struct on m68k
> - depends on BR2_m68k
> + depends on !BR2_m68k
Oh dear, this was definitely negated in the patch I submitted [0], but
looks like it landed as this in [1], which was incorrect.
[0]
https://lists.libcamera.org/pipermail/libcamera-devel/2020-September/012519.html
[1]
https://git.buildroot.net/buildroot/commit/?id=66526e3518e01a3fe16dede165c7890d194b7816
Fix looks good to me.
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
>
> menuconfig BR2_PACKAGE_LIBCAMERA
> bool "libcamera"
>
--
Regards
--
Kieran
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v1] package/libcamera: fix BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS handling
2020-11-17 21:25 [Buildroot] [PATCH v1] package/libcamera: fix BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS handling Peter Seiderer
2020-11-17 22:36 ` Kieran Bingham
@ 2020-11-19 18:40 ` Yann E. MORIN
2020-12-06 22:25 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2020-11-19 18:40 UTC (permalink / raw)
To: buildroot
Peter, All,
On 2020-11-17 22:25 +0100, Peter Seiderer spake thusly:
> Fix BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS handling, change from
> 'depends on BR2_m68k' to 'depends on !BR2_m68k'.
Uh-oh... My bad...
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/libcamera/Config.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in
> index aadea56d19..b9c243084e 100644
> --- a/package/libcamera/Config.in
> +++ b/package/libcamera/Config.in
> @@ -2,7 +2,7 @@ config BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS
> bool
> default y
> # Invalid packing size of ControlValue struct on m68k
> - depends on BR2_m68k
> + depends on !BR2_m68k
>
> menuconfig BR2_PACKAGE_LIBCAMERA
> bool "libcamera"
> --
> 2.29.2
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v1] package/libcamera: fix BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS handling
2020-11-17 21:25 [Buildroot] [PATCH v1] package/libcamera: fix BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS handling Peter Seiderer
2020-11-17 22:36 ` Kieran Bingham
2020-11-19 18:40 ` Yann E. MORIN
@ 2020-12-06 22:25 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2020-12-06 22:25 UTC (permalink / raw)
To: buildroot
>>>>> "Peter" == Peter Seiderer <ps.report@gmx.net> writes:
> Fix BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS handling, change from
> 'depends on BR2_m68k' to 'depends on !BR2_m68k'.
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
Committed to 2020.08.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-06 22:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-17 21:25 [Buildroot] [PATCH v1] package/libcamera: fix BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS handling Peter Seiderer
2020-11-17 22:36 ` Kieran Bingham
2020-11-19 18:40 ` Yann E. MORIN
2020-12-06 22:25 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.