From: David Brazdil <dbrazdil@google.com>
To: Sami Tolvanen <samitolvanen@google.com>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Will Deacon <will@kernel.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Paul E. McKenney" <paulmck@kernel.org>,
Kees Cook <keescook@chromium.org>,
Nick Desaulniers <ndesaulniers@google.com>,
clang-built-linux@googlegroups.com,
kernel-hardening@lists.openwall.com, linux-arch@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v7 15/17] KVM: arm64: disable LTO for the nVHE directory
Date: Mon, 23 Nov 2020 10:21:49 +0000 [thread overview]
Message-ID: <20201123102149.ogl642tw234qod62@google.com> (raw)
In-Reply-To: <20201118220731.925424-16-samitolvanen@google.com>
Hey Sami,
On Wed, Nov 18, 2020 at 02:07:29PM -0800, Sami Tolvanen wrote:
> We use objcopy to manipulate ELF binaries for the nVHE code,
> which fails with LTO as the compiler produces LLVM bitcode
> instead. Disable LTO for this code to allow objcopy to be used.
We now partially link the nVHE code (generating machine code) before objcopy,
so I think you should be able to drop this patch now. Tried building your
branch without it, ran a couple of unit tests and all seems fine.
David
WARNING: multiple messages have this Message-ID (diff)
From: David Brazdil <dbrazdil@google.com>
To: Sami Tolvanen <samitolvanen@google.com>
Cc: linux-arch@vger.kernel.org, Kees Cook <keescook@chromium.org>,
"Paul E. McKenney" <paulmck@kernel.org>,
kernel-hardening@lists.openwall.com,
Peter Zijlstra <peterz@infradead.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Masahiro Yamada <masahiroy@kernel.org>,
linux-kbuild@vger.kernel.org,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
clang-built-linux@googlegroups.com, linux-pci@vger.kernel.org,
Josh Poimboeuf <jpoimboe@redhat.com>,
Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 15/17] KVM: arm64: disable LTO for the nVHE directory
Date: Mon, 23 Nov 2020 10:21:49 +0000 [thread overview]
Message-ID: <20201123102149.ogl642tw234qod62@google.com> (raw)
In-Reply-To: <20201118220731.925424-16-samitolvanen@google.com>
Hey Sami,
On Wed, Nov 18, 2020 at 02:07:29PM -0800, Sami Tolvanen wrote:
> We use objcopy to manipulate ELF binaries for the nVHE code,
> which fails with LTO as the compiler produces LLVM bitcode
> instead. Disable LTO for this code to allow objcopy to be used.
We now partially link the nVHE code (generating machine code) before objcopy,
so I think you should be able to drop this patch now. Tried building your
branch without it, ran a couple of unit tests and all seems fine.
David
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-23 10:22 UTC|newest]
Thread overview: 134+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 22:07 [PATCH v7 00/17] Add support for Clang LTO Sami Tolvanen
2020-11-18 22:07 ` Sami Tolvanen
2020-11-18 22:07 ` Sami Tolvanen
2020-11-18 22:07 ` [PATCH v7 01/17] tracing: move function tracer options to Kconfig Sami Tolvanen
2020-11-18 22:07 ` Sami Tolvanen
2020-11-18 22:07 ` Sami Tolvanen
2020-11-18 22:07 ` [PATCH v7 02/17] kbuild: add support for Clang LTO Sami Tolvanen
2020-11-18 22:07 ` Sami Tolvanen
2020-11-18 22:07 ` Sami Tolvanen
2020-11-18 23:48 ` Nick Desaulniers
2020-11-18 23:48 ` Nick Desaulniers
2020-11-18 23:48 ` Nick Desaulniers
2020-11-20 16:23 ` Sami Tolvanen
2020-11-20 16:23 ` Sami Tolvanen
2020-11-20 16:23 ` Sami Tolvanen
2020-11-20 19:47 ` Kees Cook
2020-11-20 19:47 ` Kees Cook
2020-11-20 20:29 ` Nathan Chancellor
2020-11-20 20:29 ` Nathan Chancellor
2020-11-20 20:43 ` Kees Cook
2020-11-20 20:43 ` Kees Cook
2020-11-20 20:58 ` Sami Tolvanen
2020-11-20 20:58 ` Sami Tolvanen
2020-11-20 20:58 ` Sami Tolvanen
2020-11-20 23:59 ` Kees Cook
2020-11-20 23:59 ` Kees Cook
2020-11-21 1:46 ` Sami Tolvanen
2020-11-21 1:46 ` Sami Tolvanen
2020-11-21 1:46 ` Sami Tolvanen
2020-11-21 20:11 ` Kees Cook
2020-11-21 20:11 ` Kees Cook
2020-11-18 22:07 ` [PATCH v7 03/17] kbuild: lto: fix module versioning Sami Tolvanen
2020-11-18 22:07 ` Sami Tolvanen
2020-11-18 22:07 ` Sami Tolvanen
2020-11-18 22:07 ` [PATCH v7 04/17] kbuild: lto: limit inlining Sami Tolvanen
2020-11-18 22:07 ` Sami Tolvanen
2020-11-18 22:07 ` Sami Tolvanen
2020-11-18 22:07 ` [PATCH v7 05/17] kbuild: lto: merge module sections Sami Tolvanen
2020-11-18 22:07 ` Sami Tolvanen
2020-11-18 22:07 ` Sami Tolvanen
2020-11-18 22:07 ` [PATCH v7 06/17] kbuild: lto: remove duplicate dependencies from .mod files Sami Tolvanen
2020-11-18 22:07 ` Sami Tolvanen
2020-11-18 22:07 ` Sami Tolvanen
2020-11-18 22:07 ` [PATCH v7 07/17] init: lto: ensure initcall ordering Sami Tolvanen
2020-11-18 22:07 ` Sami Tolvanen
2020-11-18 22:07 ` Sami Tolvanen
2020-11-18 22:07 ` [PATCH v7 08/17] init: lto: fix PREL32 relocations Sami Tolvanen
2020-11-18 22:07 ` Sami Tolvanen
2020-11-18 22:07 ` Sami Tolvanen
2020-11-18 22:07 ` [PATCH v7 09/17] PCI: Fix PREL32 relocations for LTO Sami Tolvanen
2020-11-18 22:07 ` Sami Tolvanen
2020-11-18 22:07 ` Sami Tolvanen
2020-11-18 22:07 ` [PATCH v7 10/17] modpost: lto: strip .lto from module names Sami Tolvanen
2020-11-18 22:07 ` Sami Tolvanen
2020-11-18 22:07 ` Sami Tolvanen
2020-11-18 22:07 ` [PATCH v7 11/17] scripts/mod: disable LTO for empty.c Sami Tolvanen
2020-11-18 22:07 ` Sami Tolvanen
2020-11-18 22:07 ` Sami Tolvanen
2020-11-18 22:07 ` [PATCH v7 12/17] efi/libstub: disable LTO Sami Tolvanen
2020-11-18 22:07 ` Sami Tolvanen
2020-11-18 22:07 ` Sami Tolvanen
2020-11-18 22:07 ` [PATCH v7 13/17] drivers/misc/lkdtm: disable LTO for rodata.o Sami Tolvanen
2020-11-18 22:07 ` Sami Tolvanen
2020-11-18 22:07 ` Sami Tolvanen
2020-11-18 22:07 ` [PATCH v7 14/17] arm64: vdso: disable LTO Sami Tolvanen
2020-11-18 22:07 ` Sami Tolvanen
2020-11-18 22:07 ` Sami Tolvanen
2020-11-30 11:52 ` Will Deacon
2020-11-30 11:52 ` Will Deacon
2020-11-30 23:44 ` Sami Tolvanen
2020-11-30 23:44 ` Sami Tolvanen
2020-11-30 23:44 ` Sami Tolvanen
2020-11-18 22:07 ` [PATCH v7 15/17] KVM: arm64: disable LTO for the nVHE directory Sami Tolvanen
2020-11-18 22:07 ` Sami Tolvanen
2020-11-18 22:07 ` Sami Tolvanen
2020-11-23 10:21 ` David Brazdil [this message]
2020-11-23 10:21 ` David Brazdil
2020-11-23 18:34 ` Sami Tolvanen
2020-11-23 18:34 ` Sami Tolvanen
2020-11-23 18:34 ` Sami Tolvanen
2020-11-18 22:07 ` [PATCH v7 16/17] arm64: disable recordmcount with DYNAMIC_FTRACE_WITH_REGS Sami Tolvanen
2020-11-18 22:07 ` Sami Tolvanen
2020-11-18 22:07 ` Sami Tolvanen
2020-11-30 11:59 ` Will Deacon
2020-11-30 11:59 ` Will Deacon
2020-11-18 22:07 ` [PATCH v7 17/17] arm64: allow LTO_CLANG and THINLTO to be selected Sami Tolvanen
2020-11-18 22:07 ` Sami Tolvanen
2020-11-18 22:07 ` Sami Tolvanen
2020-11-30 12:00 ` Will Deacon
2020-11-30 12:00 ` Will Deacon
2020-11-18 23:42 ` [PATCH v7 00/17] Add support for Clang LTO Nick Desaulniers
2020-11-18 23:42 ` Nick Desaulniers
2020-11-18 23:42 ` Nick Desaulniers
2020-11-20 10:29 ` Ard Biesheuvel
2020-11-20 10:29 ` Ard Biesheuvel
2020-11-20 10:29 ` Ard Biesheuvel
2020-11-20 20:19 ` Nick Desaulniers
2020-11-20 20:19 ` Nick Desaulniers
2020-11-20 20:19 ` Nick Desaulniers
2020-11-20 23:30 ` Ard Biesheuvel
2020-11-20 23:30 ` Ard Biesheuvel
2020-11-20 23:30 ` Ard Biesheuvel
2020-11-20 23:53 ` Nick Desaulniers
2020-11-20 23:53 ` Nick Desaulniers
2020-11-20 23:53 ` Nick Desaulniers
2020-11-21 7:35 ` Ard Biesheuvel
2020-11-21 7:35 ` Ard Biesheuvel
2020-11-21 7:35 ` Ard Biesheuvel
2020-11-21 11:40 ` Marc Zyngier
2020-11-21 11:40 ` Marc Zyngier
2020-11-21 3:14 ` Nathan Chancellor
2020-11-21 3:14 ` Nathan Chancellor
2020-11-20 4:04 ` Josh Poimboeuf
2020-11-20 4:04 ` Josh Poimboeuf
2020-11-20 20:25 ` Sami Tolvanen
2020-11-20 20:25 ` Sami Tolvanen
2020-11-20 20:25 ` Sami Tolvanen
2020-11-30 12:01 ` Will Deacon
2020-11-30 12:01 ` Will Deacon
2020-12-01 17:31 ` Kees Cook
2020-12-01 17:31 ` Kees Cook
2020-12-01 19:51 ` Nick Desaulniers
2020-12-01 19:51 ` Nick Desaulniers
2020-12-01 19:51 ` Nick Desaulniers
2020-12-01 21:38 ` Sami Tolvanen
2020-12-01 21:38 ` Sami Tolvanen
2020-12-01 21:38 ` Sami Tolvanen
2020-12-02 2:42 ` Masahiro Yamada
2020-12-02 2:42 ` Masahiro Yamada
2020-12-02 5:46 ` Sami Tolvanen
2020-12-02 5:46 ` Sami Tolvanen
2020-12-02 5:46 ` Sami Tolvanen
2020-12-02 18:54 ` Kees Cook
2020-12-02 18:54 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201123102149.ogl642tw234qod62@google.com \
--to=dbrazdil@google.com \
--cc=clang-built-linux@googlegroups.com \
--cc=gregkh@linuxfoundation.org \
--cc=jpoimboe@redhat.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=ndesaulniers@google.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=samitolvanen@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.