* [PATCH net-next 1/2] soc: qcom: ipa: Constify static qmi structs
@ 2020-11-22 23:40 ` Rikard Falkeborn
0 siblings, 0 replies; 16+ messages in thread
From: Rikard Falkeborn @ 2020-11-22 23:40 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski
Cc: Alex Elder, netdev, linux-wireless, linux-kernel, ath10k,
Rikard Falkeborn, Kalle Valo
These are only used as input arguments to qmi_handle_init() which
accepts const pointers to both qmi_ops and qmi_msg_handler. Make them
const to allow the compiler to put them in read-only memory.
Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
---
drivers/net/ipa/ipa_qmi.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ipa/ipa_qmi.c b/drivers/net/ipa/ipa_qmi.c
index 5090f0f923ad..d2c3f273c233 100644
--- a/drivers/net/ipa/ipa_qmi.c
+++ b/drivers/net/ipa/ipa_qmi.c
@@ -168,7 +168,7 @@ static void ipa_server_bye(struct qmi_handle *qmi, unsigned int node)
ipa_qmi->indication_sent = false;
}
-static struct qmi_ops ipa_server_ops = {
+static const struct qmi_ops ipa_server_ops = {
.bye = ipa_server_bye,
};
@@ -234,7 +234,7 @@ static void ipa_server_driver_init_complete(struct qmi_handle *qmi,
}
/* The server handles two request message types sent by the modem. */
-static struct qmi_msg_handler ipa_server_msg_handlers[] = {
+static const struct qmi_msg_handler ipa_server_msg_handlers[] = {
{
.type = QMI_REQUEST,
.msg_id = IPA_QMI_INDICATION_REGISTER,
@@ -261,7 +261,7 @@ static void ipa_client_init_driver(struct qmi_handle *qmi,
}
/* The client handles one response message type sent by the modem. */
-static struct qmi_msg_handler ipa_client_msg_handlers[] = {
+static const struct qmi_msg_handler ipa_client_msg_handlers[] = {
{
.type = QMI_RESPONSE,
.msg_id = IPA_QMI_INIT_DRIVER,
@@ -463,7 +463,7 @@ ipa_client_new_server(struct qmi_handle *qmi, struct qmi_service *svc)
return 0;
}
-static struct qmi_ops ipa_client_ops = {
+static const struct qmi_ops ipa_client_ops = {
.new_server = ipa_client_new_server,
};
--
2.29.2
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH net-next 1/2] soc: qcom: ipa: Constify static qmi structs
2020-11-22 23:40 ` Rikard Falkeborn
@ 2020-11-24 22:47 ` Jakub Kicinski
-1 siblings, 0 replies; 16+ messages in thread
From: Jakub Kicinski @ 2020-11-24 22:47 UTC (permalink / raw)
To: Rikard Falkeborn
Cc: David S. Miller, Alex Elder, Kalle Valo, netdev, linux-kernel,
ath10k, linux-wireless
On Mon, 23 Nov 2020 00:40:30 +0100 Rikard Falkeborn wrote:
> These are only used as input arguments to qmi_handle_init() which
> accepts const pointers to both qmi_ops and qmi_msg_handler. Make them
> const to allow the compiler to put them in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
I can take this one if Alex acks it.
The other patch is probably best handled by Kalle.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH net-next 1/2] soc: qcom: ipa: Constify static qmi structs
@ 2020-11-24 22:47 ` Jakub Kicinski
0 siblings, 0 replies; 16+ messages in thread
From: Jakub Kicinski @ 2020-11-24 22:47 UTC (permalink / raw)
To: Rikard Falkeborn
Cc: Alex Elder, netdev, linux-wireless, linux-kernel, ath10k,
David S. Miller, Kalle Valo
On Mon, 23 Nov 2020 00:40:30 +0100 Rikard Falkeborn wrote:
> These are only used as input arguments to qmi_handle_init() which
> accepts const pointers to both qmi_ops and qmi_msg_handler. Make them
> const to allow the compiler to put them in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
I can take this one if Alex acks it.
The other patch is probably best handled by Kalle.
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH net-next 1/2] soc: qcom: ipa: Constify static qmi structs
2020-11-24 22:47 ` Jakub Kicinski
@ 2020-11-25 5:59 ` Kalle Valo
-1 siblings, 0 replies; 16+ messages in thread
From: Kalle Valo @ 2020-11-25 5:59 UTC (permalink / raw)
To: Jakub Kicinski
Cc: Rikard Falkeborn, Alex Elder, netdev, linux-wireless,
linux-kernel, ath10k, David S. Miller
Jakub Kicinski <kuba@kernel.org> writes:
> On Mon, 23 Nov 2020 00:40:30 +0100 Rikard Falkeborn wrote:
>> These are only used as input arguments to qmi_handle_init() which
>> accepts const pointers to both qmi_ops and qmi_msg_handler. Make them
>> const to allow the compiler to put them in read-only memory.
>>
>> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
>
> I can take this one if Alex acks it.
>
> The other patch is probably best handled by Kalle.
Yes, patch 2 is in my queue.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH net-next 1/2] soc: qcom: ipa: Constify static qmi structs
2020-11-22 23:40 ` Rikard Falkeborn
@ 2020-11-25 21:45 ` Alex Elder
-1 siblings, 0 replies; 16+ messages in thread
From: Alex Elder @ 2020-11-25 21:45 UTC (permalink / raw)
To: Rikard Falkeborn, David S. Miller, Jakub Kicinski
Cc: Alex Elder, Kalle Valo, netdev, linux-kernel, ath10k, linux-wireless
On 11/22/20 5:40 PM, Rikard Falkeborn wrote:
> These are only used as input arguments to qmi_handle_init() which
> accepts const pointers to both qmi_ops and qmi_msg_handler. Make them
> const to allow the compiler to put them in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Good idea. Thanks a lot.
Acked-by: Alex Elder <elder@linaro.org>
> ---
> drivers/net/ipa/ipa_qmi.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ipa/ipa_qmi.c b/drivers/net/ipa/ipa_qmi.c
> index 5090f0f923ad..d2c3f273c233 100644
> --- a/drivers/net/ipa/ipa_qmi.c
> +++ b/drivers/net/ipa/ipa_qmi.c
> @@ -168,7 +168,7 @@ static void ipa_server_bye(struct qmi_handle *qmi, unsigned int node)
> ipa_qmi->indication_sent = false;
> }
>
> -static struct qmi_ops ipa_server_ops = {
> +static const struct qmi_ops ipa_server_ops = {
> .bye = ipa_server_bye,
> };
>
> @@ -234,7 +234,7 @@ static void ipa_server_driver_init_complete(struct qmi_handle *qmi,
> }
>
> /* The server handles two request message types sent by the modem. */
> -static struct qmi_msg_handler ipa_server_msg_handlers[] = {
> +static const struct qmi_msg_handler ipa_server_msg_handlers[] = {
> {
> .type = QMI_REQUEST,
> .msg_id = IPA_QMI_INDICATION_REGISTER,
> @@ -261,7 +261,7 @@ static void ipa_client_init_driver(struct qmi_handle *qmi,
> }
>
> /* The client handles one response message type sent by the modem. */
> -static struct qmi_msg_handler ipa_client_msg_handlers[] = {
> +static const struct qmi_msg_handler ipa_client_msg_handlers[] = {
> {
> .type = QMI_RESPONSE,
> .msg_id = IPA_QMI_INIT_DRIVER,
> @@ -463,7 +463,7 @@ ipa_client_new_server(struct qmi_handle *qmi, struct qmi_service *svc)
> return 0;
> }
>
> -static struct qmi_ops ipa_client_ops = {
> +static const struct qmi_ops ipa_client_ops = {
> .new_server = ipa_client_new_server,
> };
>
>
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH net-next 1/2] soc: qcom: ipa: Constify static qmi structs
@ 2020-11-25 21:45 ` Alex Elder
0 siblings, 0 replies; 16+ messages in thread
From: Alex Elder @ 2020-11-25 21:45 UTC (permalink / raw)
To: Rikard Falkeborn, David S. Miller, Jakub Kicinski
Cc: Alex Elder, netdev, linux-wireless, linux-kernel, ath10k, Kalle Valo
On 11/22/20 5:40 PM, Rikard Falkeborn wrote:
> These are only used as input arguments to qmi_handle_init() which
> accepts const pointers to both qmi_ops and qmi_msg_handler. Make them
> const to allow the compiler to put them in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Good idea. Thanks a lot.
Acked-by: Alex Elder <elder@linaro.org>
> ---
> drivers/net/ipa/ipa_qmi.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ipa/ipa_qmi.c b/drivers/net/ipa/ipa_qmi.c
> index 5090f0f923ad..d2c3f273c233 100644
> --- a/drivers/net/ipa/ipa_qmi.c
> +++ b/drivers/net/ipa/ipa_qmi.c
> @@ -168,7 +168,7 @@ static void ipa_server_bye(struct qmi_handle *qmi, unsigned int node)
> ipa_qmi->indication_sent = false;
> }
>
> -static struct qmi_ops ipa_server_ops = {
> +static const struct qmi_ops ipa_server_ops = {
> .bye = ipa_server_bye,
> };
>
> @@ -234,7 +234,7 @@ static void ipa_server_driver_init_complete(struct qmi_handle *qmi,
> }
>
> /* The server handles two request message types sent by the modem. */
> -static struct qmi_msg_handler ipa_server_msg_handlers[] = {
> +static const struct qmi_msg_handler ipa_server_msg_handlers[] = {
> {
> .type = QMI_REQUEST,
> .msg_id = IPA_QMI_INDICATION_REGISTER,
> @@ -261,7 +261,7 @@ static void ipa_client_init_driver(struct qmi_handle *qmi,
> }
>
> /* The client handles one response message type sent by the modem. */
> -static struct qmi_msg_handler ipa_client_msg_handlers[] = {
> +static const struct qmi_msg_handler ipa_client_msg_handlers[] = {
> {
> .type = QMI_RESPONSE,
> .msg_id = IPA_QMI_INIT_DRIVER,
> @@ -463,7 +463,7 @@ ipa_client_new_server(struct qmi_handle *qmi, struct qmi_service *svc)
> return 0;
> }
>
> -static struct qmi_ops ipa_client_ops = {
> +static const struct qmi_ops ipa_client_ops = {
> .new_server = ipa_client_new_server,
> };
>
>
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH net-next 1/2] soc: qcom: ipa: Constify static qmi structs
2020-11-25 21:45 ` Alex Elder
@ 2020-11-25 22:49 ` Jakub Kicinski
-1 siblings, 0 replies; 16+ messages in thread
From: Jakub Kicinski @ 2020-11-25 22:49 UTC (permalink / raw)
To: Alex Elder
Cc: Rikard Falkeborn, David S. Miller, Alex Elder, Kalle Valo,
netdev, linux-kernel, ath10k, linux-wireless
On Wed, 25 Nov 2020 15:45:05 -0600 Alex Elder wrote:
> On 11/22/20 5:40 PM, Rikard Falkeborn wrote:
> > These are only used as input arguments to qmi_handle_init() which
> > accepts const pointers to both qmi_ops and qmi_msg_handler. Make them
> > const to allow the compiler to put them in read-only memory.
> >
> > Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
>
> Acked-by: Alex Elder <elder@linaro.org>
Applied to net-next, thanks!
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH net-next 1/2] soc: qcom: ipa: Constify static qmi structs
@ 2020-11-25 22:49 ` Jakub Kicinski
0 siblings, 0 replies; 16+ messages in thread
From: Jakub Kicinski @ 2020-11-25 22:49 UTC (permalink / raw)
To: Alex Elder
Cc: Alex Elder, netdev, linux-wireless, linux-kernel,
Rikard Falkeborn, ath10k, David S. Miller, Kalle Valo
On Wed, 25 Nov 2020 15:45:05 -0600 Alex Elder wrote:
> On 11/22/20 5:40 PM, Rikard Falkeborn wrote:
> > These are only used as input arguments to qmi_handle_init() which
> > accepts const pointers to both qmi_ops and qmi_msg_handler. Make them
> > const to allow the compiler to put them in read-only memory.
> >
> > Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
>
> Acked-by: Alex Elder <elder@linaro.org>
Applied to net-next, thanks!
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 16+ messages in thread