From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alice Guo <alice.guo@nxp.com>
Cc: Adam Ford <aford173@gmail.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Peng Fan <peng.fan@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
arm-soc <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v6 4/4] soc: imx8m: change to use platform driver
Date: Thu, 26 Nov 2020 09:07:48 +0100 [thread overview]
Message-ID: <20201126080748.GC4347@kozik-lap> (raw)
In-Reply-To: <AM6PR04MB60533EAB39259666F522E55DE2F90@AM6PR04MB6053.eurprd04.prod.outlook.com>
On Thu, Nov 26, 2020 at 02:15:35AM +0000, Alice Guo wrote:
>
>
> > -----Original Message-----
> > From: linux-arm-kernel <linux-arm-kernel-bounces@lists.infradead.org> On
> > Behalf Of Adam Ford
> > Sent: 2020年11月25日 8:45
> > To: Alice Guo <alice.guo@nxp.com>
> > Cc: devicetree <devicetree@vger.kernel.org>; Peng Fan <peng.fan@nxp.com>;
> > Sascha Hauer <s.hauer@pengutronix.de>; Linux Kernel Mailing List
> > <linux-kernel@vger.kernel.org>; Krzysztof Kozlowski <krzk@kernel.org>; Rob
> > Herring <robh+dt@kernel.org>; dl-linux-imx <linux-imx@nxp.com>; Shawn Guo
> > <shawnguo@kernel.org>; arm-soc <linux-arm-kernel@lists.infradead.org>
> > Subject: Re: [PATCH v6 4/4] soc: imx8m: change to use platform driver
> >
> > On Mon, Nov 23, 2020 at 8:04 PM Alice Guo <alice.guo@nxp.com> wrote:
> > >
> > > Directly reading ocotp register depends on that bootloader enables
> > > ocotp clk, which is not always effective, so change to use nvmem API.
> > > Using nvmem API requires to support driver defer probe and thus change
> > > soc-imx8m.c to use platform driver.
> > >
> > > The other reason is that directly reading ocotp register causes kexec
> > > kernel hang because the 1st kernel running will disable unused clks
> > > after kernel boots up, and then ocotp clk will be disabled even if
> > > bootloader enables it. When kexec kernel, ocotp clk needs to be
> > > enabled before reading ocotp registers, and nvmem API with platform
> > > driver supported can accomplish this.
> > >
> > > Signed-off-by: Alice Guo <alice.guo@nxp.com>
> > > ---
> > >
> > The patch reads V6, but the change log only shows V2. Can you elaborate on
> > what has changed between V2 and V6?
> >
> > adam
>
> Hi,
>
> Sorry. The order of changlog is reversed. Thank Adam for pointing out the problem, and thank Krzysztof for reviewing my patch.
> Do I need to resend the patchset with the correct changelog order?
No, no need.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alice Guo <alice.guo@nxp.com>
Cc: devicetree <devicetree@vger.kernel.org>,
Peng Fan <peng.fan@nxp.com>, Adam Ford <aford173@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
arm-soc <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v6 4/4] soc: imx8m: change to use platform driver
Date: Thu, 26 Nov 2020 09:07:48 +0100 [thread overview]
Message-ID: <20201126080748.GC4347@kozik-lap> (raw)
In-Reply-To: <AM6PR04MB60533EAB39259666F522E55DE2F90@AM6PR04MB6053.eurprd04.prod.outlook.com>
On Thu, Nov 26, 2020 at 02:15:35AM +0000, Alice Guo wrote:
>
>
> > -----Original Message-----
> > From: linux-arm-kernel <linux-arm-kernel-bounces@lists.infradead.org> On
> > Behalf Of Adam Ford
> > Sent: 2020年11月25日 8:45
> > To: Alice Guo <alice.guo@nxp.com>
> > Cc: devicetree <devicetree@vger.kernel.org>; Peng Fan <peng.fan@nxp.com>;
> > Sascha Hauer <s.hauer@pengutronix.de>; Linux Kernel Mailing List
> > <linux-kernel@vger.kernel.org>; Krzysztof Kozlowski <krzk@kernel.org>; Rob
> > Herring <robh+dt@kernel.org>; dl-linux-imx <linux-imx@nxp.com>; Shawn Guo
> > <shawnguo@kernel.org>; arm-soc <linux-arm-kernel@lists.infradead.org>
> > Subject: Re: [PATCH v6 4/4] soc: imx8m: change to use platform driver
> >
> > On Mon, Nov 23, 2020 at 8:04 PM Alice Guo <alice.guo@nxp.com> wrote:
> > >
> > > Directly reading ocotp register depends on that bootloader enables
> > > ocotp clk, which is not always effective, so change to use nvmem API.
> > > Using nvmem API requires to support driver defer probe and thus change
> > > soc-imx8m.c to use platform driver.
> > >
> > > The other reason is that directly reading ocotp register causes kexec
> > > kernel hang because the 1st kernel running will disable unused clks
> > > after kernel boots up, and then ocotp clk will be disabled even if
> > > bootloader enables it. When kexec kernel, ocotp clk needs to be
> > > enabled before reading ocotp registers, and nvmem API with platform
> > > driver supported can accomplish this.
> > >
> > > Signed-off-by: Alice Guo <alice.guo@nxp.com>
> > > ---
> > >
> > The patch reads V6, but the change log only shows V2. Can you elaborate on
> > what has changed between V2 and V6?
> >
> > adam
>
> Hi,
>
> Sorry. The order of changlog is reversed. Thank Adam for pointing out the problem, and thank Krzysztof for reviewing my patch.
> Do I need to resend the patchset with the correct changelog order?
No, no need.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-26 8:08 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 1:59 [PATCH v6 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID Alice Guo
2020-11-24 1:59 ` Alice Guo
2020-11-24 1:59 ` [PATCH v6 2/4] arm64: dts: imx8m: add SoC ID compatible Alice Guo
2020-11-24 1:59 ` Alice Guo
2020-11-24 1:59 ` [PATCH v6 3/4] arm64: dts: imx8m: add NVMEM provider and consumer to read soc unique ID Alice Guo
2020-11-24 1:59 ` Alice Guo
2020-11-24 9:47 ` Krzysztof Kozlowski
2020-11-24 9:47 ` Krzysztof Kozlowski
2020-11-24 1:59 ` [PATCH v6 4/4] soc: imx8m: change to use platform driver Alice Guo
2020-11-24 1:59 ` Alice Guo
2020-11-24 9:48 ` Krzysztof Kozlowski
2020-11-24 9:48 ` Krzysztof Kozlowski
2020-11-25 0:44 ` Adam Ford
2020-11-25 0:44 ` Adam Ford
2020-11-25 7:33 ` Krzysztof Kozlowski
2020-11-25 7:33 ` Krzysztof Kozlowski
2020-11-26 2:15 ` Alice Guo
2020-11-26 2:15 ` Alice Guo
2020-11-26 8:07 ` Krzysztof Kozlowski [this message]
2020-11-26 8:07 ` Krzysztof Kozlowski
2020-12-02 1:27 ` kernel test robot
2020-12-02 1:27 ` kernel test robot
2020-12-02 1:27 ` kernel test robot
2020-11-24 9:46 ` [PATCH v6 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID Krzysztof Kozlowski
2020-11-24 9:46 ` Krzysztof Kozlowski
2020-11-30 21:57 ` Rob Herring
2020-11-30 21:57 ` Rob Herring
2020-12-01 3:31 ` Alice Guo (OSS)
2020-12-01 3:31 ` Alice Guo (OSS)
2020-12-09 2:30 ` Alice Guo (OSS)
2020-12-09 2:30 ` Alice Guo (OSS)
2020-12-09 7:43 ` Krzysztof Kozlowski
2020-12-09 7:43 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201126080748.GC4347@kozik-lap \
--to=krzk@kernel.org \
--cc=aford173@gmail.com \
--cc=alice.guo@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.