* [PATCH v2 0/2] arm64: dts: ti: k3-j721e: MMC/SD higher speed modes support
@ 2020-11-27 20:10 ` Sekhar Nori
0 siblings, 0 replies; 8+ messages in thread
From: Sekhar Nori @ 2020-11-27 20:10 UTC (permalink / raw)
To: Nishanth Menon, Tero Kristo
Cc: Faiz Abbas, Rob Herring, Linux ARM Mailing List,
Device Tree Mailing List
Hi,
This is repost of Faiz's patches adding higher speed modes
for J721E, originally posted here:'
https://lore.kernel.org/lkml/20201001190541.6364-1-faiz_abbas@ti.com/
Dependencies are resolved now, and patches rebased to latest linux-next.
v2:
- rebased to latest linux-next
- fixed dtbs_check warning caused by improper states property in gpio
regulator introduced in patch 2/2.
Faiz Abbas (2):
arm64: dts: ti: k3-j721e-main: Add output tap delay values
arm64: dts: ti: k3-j721e-common-proc-board: Add support SD card UHS
modes
.../dts/ti/k3-j721e-common-proc-board.dts | 35 ++++++++++++++++++-
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 22 +++++++++---
2 files changed, 51 insertions(+), 6 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 0/2] arm64: dts: ti: k3-j721e: MMC/SD higher speed modes support
@ 2020-11-27 20:10 ` Sekhar Nori
0 siblings, 0 replies; 8+ messages in thread
From: Sekhar Nori @ 2020-11-27 20:10 UTC (permalink / raw)
To: Nishanth Menon, Tero Kristo
Cc: Device Tree Mailing List, Faiz Abbas, Linux ARM Mailing List,
Rob Herring
Hi,
This is repost of Faiz's patches adding higher speed modes
for J721E, originally posted here:'
https://lore.kernel.org/lkml/20201001190541.6364-1-faiz_abbas@ti.com/
Dependencies are resolved now, and patches rebased to latest linux-next.
v2:
- rebased to latest linux-next
- fixed dtbs_check warning caused by improper states property in gpio
regulator introduced in patch 2/2.
Faiz Abbas (2):
arm64: dts: ti: k3-j721e-main: Add output tap delay values
arm64: dts: ti: k3-j721e-common-proc-board: Add support SD card UHS
modes
.../dts/ti/k3-j721e-common-proc-board.dts | 35 ++++++++++++++++++-
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 22 +++++++++---
2 files changed, 51 insertions(+), 6 deletions(-)
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 1/2] arm64: dts: ti: k3-j721e-main: Add output tap delay values
2020-11-27 20:10 ` Sekhar Nori
@ 2020-11-27 20:10 ` Sekhar Nori
-1 siblings, 0 replies; 8+ messages in thread
From: Sekhar Nori @ 2020-11-27 20:10 UTC (permalink / raw)
To: Nishanth Menon, Tero Kristo
Cc: Faiz Abbas, Rob Herring, Linux ARM Mailing List,
Device Tree Mailing List
From: Faiz Abbas <faiz_abbas@ti.com>
Add output tap delay values as given in the latest Data Manual[1],
SPRSP36E, revised December 2019.
[1] https://www.ti.com/lit/gpn/tda4vm
Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 20 +++++++++++++++++---
1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
index 19e602afdb05..d87748cb6896 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
@@ -1079,7 +1079,11 @@
bus-width = <8>;
mmc-hs400-1_8v;
mmc-ddr-1_8v;
- ti,otap-del-sel = <0x2>;
+ ti,otap-del-sel-legacy = <0xf>;
+ ti,otap-del-sel-mmc-hs = <0xf>;
+ ti,otap-del-sel-ddr52 = <0x5>;
+ ti,otap-del-sel-hs200 = <0x6>;
+ ti,otap-del-sel-hs400 = <0x0>;
ti,trm-icp = <0x8>;
ti,strobe-sel = <0x77>;
dma-coherent;
@@ -1094,7 +1098,12 @@
clocks = <&k3_clks 92 0>, <&k3_clks 92 5>;
assigned-clocks = <&k3_clks 92 0>;
assigned-clock-parents = <&k3_clks 92 1>;
- ti,otap-del-sel = <0x2>;
+ ti,otap-del-sel-legacy = <0x0>;
+ ti,otap-del-sel-sd-hs = <0xf>;
+ ti,otap-del-sel-sdr12 = <0xf>;
+ ti,otap-del-sel-sdr25 = <0xf>;
+ ti,otap-del-sel-sdr50 = <0xc>;
+ ti,otap-del-sel-ddr50 = <0xc>;
ti,trm-icp = <0x8>;
ti,clkbuf-sel = <0x7>;
dma-coherent;
@@ -1110,7 +1119,12 @@
clocks = <&k3_clks 93 0>, <&k3_clks 93 5>;
assigned-clocks = <&k3_clks 93 0>;
assigned-clock-parents = <&k3_clks 93 1>;
- ti,otap-del-sel = <0x2>;
+ ti,otap-del-sel-legacy = <0x0>;
+ ti,otap-del-sel-sd-hs = <0xf>;
+ ti,otap-del-sel-sdr12 = <0xf>;
+ ti,otap-del-sel-sdr25 = <0xf>;
+ ti,otap-del-sel-sdr50 = <0xc>;
+ ti,otap-del-sel-ddr50 = <0xc>;
ti,trm-icp = <0x8>;
ti,clkbuf-sel = <0x7>;
dma-coherent;
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2 1/2] arm64: dts: ti: k3-j721e-main: Add output tap delay values
@ 2020-11-27 20:10 ` Sekhar Nori
0 siblings, 0 replies; 8+ messages in thread
From: Sekhar Nori @ 2020-11-27 20:10 UTC (permalink / raw)
To: Nishanth Menon, Tero Kristo
Cc: Device Tree Mailing List, Faiz Abbas, Linux ARM Mailing List,
Rob Herring
From: Faiz Abbas <faiz_abbas@ti.com>
Add output tap delay values as given in the latest Data Manual[1],
SPRSP36E, revised December 2019.
[1] https://www.ti.com/lit/gpn/tda4vm
Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 20 +++++++++++++++++---
1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
index 19e602afdb05..d87748cb6896 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
@@ -1079,7 +1079,11 @@
bus-width = <8>;
mmc-hs400-1_8v;
mmc-ddr-1_8v;
- ti,otap-del-sel = <0x2>;
+ ti,otap-del-sel-legacy = <0xf>;
+ ti,otap-del-sel-mmc-hs = <0xf>;
+ ti,otap-del-sel-ddr52 = <0x5>;
+ ti,otap-del-sel-hs200 = <0x6>;
+ ti,otap-del-sel-hs400 = <0x0>;
ti,trm-icp = <0x8>;
ti,strobe-sel = <0x77>;
dma-coherent;
@@ -1094,7 +1098,12 @@
clocks = <&k3_clks 92 0>, <&k3_clks 92 5>;
assigned-clocks = <&k3_clks 92 0>;
assigned-clock-parents = <&k3_clks 92 1>;
- ti,otap-del-sel = <0x2>;
+ ti,otap-del-sel-legacy = <0x0>;
+ ti,otap-del-sel-sd-hs = <0xf>;
+ ti,otap-del-sel-sdr12 = <0xf>;
+ ti,otap-del-sel-sdr25 = <0xf>;
+ ti,otap-del-sel-sdr50 = <0xc>;
+ ti,otap-del-sel-ddr50 = <0xc>;
ti,trm-icp = <0x8>;
ti,clkbuf-sel = <0x7>;
dma-coherent;
@@ -1110,7 +1119,12 @@
clocks = <&k3_clks 93 0>, <&k3_clks 93 5>;
assigned-clocks = <&k3_clks 93 0>;
assigned-clock-parents = <&k3_clks 93 1>;
- ti,otap-del-sel = <0x2>;
+ ti,otap-del-sel-legacy = <0x0>;
+ ti,otap-del-sel-sd-hs = <0xf>;
+ ti,otap-del-sel-sdr12 = <0xf>;
+ ti,otap-del-sel-sdr25 = <0xf>;
+ ti,otap-del-sel-sdr50 = <0xc>;
+ ti,otap-del-sel-ddr50 = <0xc>;
ti,trm-icp = <0x8>;
ti,clkbuf-sel = <0x7>;
dma-coherent;
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2 2/2] arm64: dts: ti: k3-j721e-common-proc-board: Add support SD card UHS modes
2020-11-27 20:10 ` Sekhar Nori
@ 2020-11-27 20:10 ` Sekhar Nori
-1 siblings, 0 replies; 8+ messages in thread
From: Sekhar Nori @ 2020-11-27 20:10 UTC (permalink / raw)
To: Nishanth Menon, Tero Kristo
Cc: Faiz Abbas, Rob Herring, Linux ARM Mailing List,
Device Tree Mailing List
From: Faiz Abbas <faiz_abbas@ti.com>
Add support for UHS modes for the SD card connected at sdhci1. This
involves adding regulators for voltage switching and power cycling the
SD card and removing the no-1-8-v property.
Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
.../dts/ti/k3-j721e-common-proc-board.dts | 35 ++++++++++++++++++-
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 2 --
2 files changed, 34 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
index 5754892f8501..529b072e1eaf 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
@@ -67,6 +67,31 @@
regulator-boot-on;
};
+ vdd_mmc1: fixedregulator-sd {
+ compatible = "regulator-fixed";
+ regulator-name = "vdd_mmc1";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-boot-on;
+ enable-active-high;
+ vin-supply = <&vsys_3v3>;
+ gpio = <&exp2 2 GPIO_ACTIVE_HIGH>;
+ };
+
+ vdd_sd_dv_alt: gpio-regulator-TLV71033 {
+ compatible = "regulator-gpio";
+ pinctrl-names = "default";
+ pinctrl-0 = <&vdd_sd_dv_alt_pins_default>;
+ regulator-name = "tlv71033";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-boot-on;
+ vin-supply = <&vsys_5v0>;
+ gpios = <&main_gpio0 117 GPIO_ACTIVE_HIGH>;
+ states = <1800000 0x0>,
+ <3300000 0x1>;
+ };
+
sound0: sound@0 {
compatible = "ti,j721e-cpb-audio";
model = "j721e-cpb";
@@ -106,7 +131,13 @@
>;
};
- main_usbss0_pins_default: main-usbss0-pins-default {
+ vdd_sd_dv_alt_pins_default: vdd_sd_dv_alt_pins_default {
+ pinctrl-single,pins = <
+ J721E_IOPAD(0x1d8, PIN_INPUT, 7) /* (W4) SPI1_CS1.GPIO0_117 */
+ >;
+ };
+
+ main_usbss0_pins_default: main_usbss0_pins_default {
pinctrl-single,pins = <
J721E_IOPAD(0x290, PIN_OUTPUT, 0) /* (U6) USB0_DRVVBUS */
J721E_IOPAD(0x210, PIN_INPUT, 7) /* (W3) MCAN1_RX.GPIO1_3 */
@@ -295,6 +326,8 @@
&main_sdhci1 {
/* SD/MMC */
+ vmmc-supply = <&vdd_mmc1>;
+ vqmmc-supply = <&vdd_sd_dv_alt>;
pinctrl-names = "default";
pinctrl-0 = <&main_mmc1_pins_default>;
ti,driver-strength-ohm = <50>;
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
index d87748cb6896..2056a41f9378 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
@@ -1107,7 +1107,6 @@
ti,trm-icp = <0x8>;
ti,clkbuf-sel = <0x7>;
dma-coherent;
- no-1-8-v;
};
main_sdhci2: sdhci@4f98000 {
@@ -1128,7 +1127,6 @@
ti,trm-icp = <0x8>;
ti,clkbuf-sel = <0x7>;
dma-coherent;
- no-1-8-v;
};
usbss0: cdns-usb@4104000 {
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2 2/2] arm64: dts: ti: k3-j721e-common-proc-board: Add support SD card UHS modes
@ 2020-11-27 20:10 ` Sekhar Nori
0 siblings, 0 replies; 8+ messages in thread
From: Sekhar Nori @ 2020-11-27 20:10 UTC (permalink / raw)
To: Nishanth Menon, Tero Kristo
Cc: Device Tree Mailing List, Faiz Abbas, Linux ARM Mailing List,
Rob Herring
From: Faiz Abbas <faiz_abbas@ti.com>
Add support for UHS modes for the SD card connected at sdhci1. This
involves adding regulators for voltage switching and power cycling the
SD card and removing the no-1-8-v property.
Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
.../dts/ti/k3-j721e-common-proc-board.dts | 35 ++++++++++++++++++-
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 2 --
2 files changed, 34 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
index 5754892f8501..529b072e1eaf 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
@@ -67,6 +67,31 @@
regulator-boot-on;
};
+ vdd_mmc1: fixedregulator-sd {
+ compatible = "regulator-fixed";
+ regulator-name = "vdd_mmc1";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-boot-on;
+ enable-active-high;
+ vin-supply = <&vsys_3v3>;
+ gpio = <&exp2 2 GPIO_ACTIVE_HIGH>;
+ };
+
+ vdd_sd_dv_alt: gpio-regulator-TLV71033 {
+ compatible = "regulator-gpio";
+ pinctrl-names = "default";
+ pinctrl-0 = <&vdd_sd_dv_alt_pins_default>;
+ regulator-name = "tlv71033";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-boot-on;
+ vin-supply = <&vsys_5v0>;
+ gpios = <&main_gpio0 117 GPIO_ACTIVE_HIGH>;
+ states = <1800000 0x0>,
+ <3300000 0x1>;
+ };
+
sound0: sound@0 {
compatible = "ti,j721e-cpb-audio";
model = "j721e-cpb";
@@ -106,7 +131,13 @@
>;
};
- main_usbss0_pins_default: main-usbss0-pins-default {
+ vdd_sd_dv_alt_pins_default: vdd_sd_dv_alt_pins_default {
+ pinctrl-single,pins = <
+ J721E_IOPAD(0x1d8, PIN_INPUT, 7) /* (W4) SPI1_CS1.GPIO0_117 */
+ >;
+ };
+
+ main_usbss0_pins_default: main_usbss0_pins_default {
pinctrl-single,pins = <
J721E_IOPAD(0x290, PIN_OUTPUT, 0) /* (U6) USB0_DRVVBUS */
J721E_IOPAD(0x210, PIN_INPUT, 7) /* (W3) MCAN1_RX.GPIO1_3 */
@@ -295,6 +326,8 @@
&main_sdhci1 {
/* SD/MMC */
+ vmmc-supply = <&vdd_mmc1>;
+ vqmmc-supply = <&vdd_sd_dv_alt>;
pinctrl-names = "default";
pinctrl-0 = <&main_mmc1_pins_default>;
ti,driver-strength-ohm = <50>;
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
index d87748cb6896..2056a41f9378 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
@@ -1107,7 +1107,6 @@
ti,trm-icp = <0x8>;
ti,clkbuf-sel = <0x7>;
dma-coherent;
- no-1-8-v;
};
main_sdhci2: sdhci@4f98000 {
@@ -1128,7 +1127,6 @@
ti,trm-icp = <0x8>;
ti,clkbuf-sel = <0x7>;
dma-coherent;
- no-1-8-v;
};
usbss0: cdns-usb@4104000 {
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] arm64: dts: ti: k3-j721e-common-proc-board: Add support SD card UHS modes
2020-11-27 20:10 ` Sekhar Nori
@ 2020-11-28 16:41 ` Nishanth Menon
-1 siblings, 0 replies; 8+ messages in thread
From: Nishanth Menon @ 2020-11-28 16:41 UTC (permalink / raw)
To: Sekhar Nori
Cc: Tero Kristo, Faiz Abbas, Rob Herring, Linux ARM Mailing List,
Device Tree Mailing List
On 01:40-20201128, Sekhar Nori wrote:
[...]
> - main_usbss0_pins_default: main-usbss0-pins-default {
> + vdd_sd_dv_alt_pins_default: vdd_sd_dv_alt_pins_default {
> + pinctrl-single,pins = <
> + J721E_IOPAD(0x1d8, PIN_INPUT, 7) /* (W4) SPI1_CS1.GPIO0_117 */
> + >;
> + };
> +
> + main_usbss0_pins_default: main_usbss0_pins_default {
Could you not switch the node name to _ ? We just fixed that
bunch. Now, this patch introduces the following with W=2:
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts: /bus@100000/pinctrl@11c000/vdd_sd_dv_alt_pins_default: Character '_' not recommended in node name
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts: /bus@100000/pinctrl@11c000/main_usbss0_pins_default: Character '_' not recommended in node name
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] arm64: dts: ti: k3-j721e-common-proc-board: Add support SD card UHS modes
@ 2020-11-28 16:41 ` Nishanth Menon
0 siblings, 0 replies; 8+ messages in thread
From: Nishanth Menon @ 2020-11-28 16:41 UTC (permalink / raw)
To: Sekhar Nori
Cc: Tero Kristo, Device Tree Mailing List, Faiz Abbas,
Linux ARM Mailing List, Rob Herring
On 01:40-20201128, Sekhar Nori wrote:
[...]
> - main_usbss0_pins_default: main-usbss0-pins-default {
> + vdd_sd_dv_alt_pins_default: vdd_sd_dv_alt_pins_default {
> + pinctrl-single,pins = <
> + J721E_IOPAD(0x1d8, PIN_INPUT, 7) /* (W4) SPI1_CS1.GPIO0_117 */
> + >;
> + };
> +
> + main_usbss0_pins_default: main_usbss0_pins_default {
Could you not switch the node name to _ ? We just fixed that
bunch. Now, this patch introduces the following with W=2:
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts: /bus@100000/pinctrl@11c000/vdd_sd_dv_alt_pins_default: Character '_' not recommended in node name
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts: /bus@100000/pinctrl@11c000/main_usbss0_pins_default: Character '_' not recommended in node name
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-11-28 22:20 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-27 20:10 [PATCH v2 0/2] arm64: dts: ti: k3-j721e: MMC/SD higher speed modes support Sekhar Nori
2020-11-27 20:10 ` Sekhar Nori
2020-11-27 20:10 ` [PATCH v2 1/2] arm64: dts: ti: k3-j721e-main: Add output tap delay values Sekhar Nori
2020-11-27 20:10 ` Sekhar Nori
2020-11-27 20:10 ` [PATCH v2 2/2] arm64: dts: ti: k3-j721e-common-proc-board: Add support SD card UHS modes Sekhar Nori
2020-11-27 20:10 ` Sekhar Nori
2020-11-28 16:41 ` Nishanth Menon
2020-11-28 16:41 ` Nishanth Menon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.