* [PATCH] drm/amdgpu: fix compiler warnings
@ 2020-11-30 7:54 Wayne Lin
2020-11-30 14:41 ` Rodrigo Siqueira
0 siblings, 1 reply; 2+ messages in thread
From: Wayne Lin @ 2020-11-30 7:54 UTC (permalink / raw)
To: amd-gfx; +Cc: harry.wentland, rodrigo.siqueira, Nicholas.Kazlauskas, Wayne Lin
Fixes below compiler warnings:
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5374:5:
warning: no previous prototype for function
'amdgpu_dm_crtc_atomic_set_property' [-Wmissing-prototypes]
int amdgpu_dm_crtc_atomic_set_property(struct drm_crtc *crtc,
^
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5374:1:
note: declare 'static' if the function is not intended to be used
outside of this translation unit
int amdgpu_dm_crtc_atomic_set_property(struct drm_crtc *crtc,
^
static
>> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5398:5:
warning: no previous prototype for function
'amdgpu_dm_crtc_atomic_get_property' [-Wmissing-prototypes]
int amdgpu_dm_crtc_atomic_get_property(struct drm_crtc *crtc,
^
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5398:1:
note: declare 'static' if the function is not intended to be used
outside of this translation unit
int amdgpu_dm_crtc_atomic_get_property(struct drm_crtc *crtc,
^
static
2 warnings generated.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Wayne Lin <Wayne.Lin@amd.com>
---
amdgpu_dm/amdgpu_dm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/amdgpu_dm/amdgpu_dm.c b/amdgpu_dm/amdgpu_dm.c
index 1818d9392..f42046d04 100644
--- a/amdgpu_dm/amdgpu_dm.c
+++ b/amdgpu_dm/amdgpu_dm.c
@@ -4975,7 +4975,7 @@ dm_crtc_duplicate_state(struct drm_crtc *crtc)
}
#ifdef CONFIG_DEBUG_FS
-int amdgpu_dm_crtc_atomic_set_property(struct drm_crtc *crtc,
+static int amdgpu_dm_crtc_atomic_set_property(struct drm_crtc *crtc,
struct drm_crtc_state *crtc_state,
struct drm_property *property,
uint64_t val)
@@ -4999,7 +4999,7 @@ int amdgpu_dm_crtc_atomic_set_property(struct drm_crtc *crtc,
return 0;
}
-int amdgpu_dm_crtc_atomic_get_property(struct drm_crtc *crtc,
+static int amdgpu_dm_crtc_atomic_get_property(struct drm_crtc *crtc,
const struct drm_crtc_state *state,
struct drm_property *property,
uint64_t *val)
--
2.17.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amdgpu: fix compiler warnings
2020-11-30 7:54 [PATCH] drm/amdgpu: fix compiler warnings Wayne Lin
@ 2020-11-30 14:41 ` Rodrigo Siqueira
0 siblings, 0 replies; 2+ messages in thread
From: Rodrigo Siqueira @ 2020-11-30 14:41 UTC (permalink / raw)
To: Wayne Lin; +Cc: harry.wentland, Nicholas.Kazlauskas, amd-gfx
[-- Attachment #1.1: Type: text/plain, Size: 2436 bytes --]
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
On 11/30, Wayne Lin wrote:
> Fixes below compiler warnings:
>
> All warnings (new ones prefixed by >>):
>
> >> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5374:5:
> warning: no previous prototype for function
> 'amdgpu_dm_crtc_atomic_set_property' [-Wmissing-prototypes]
> int amdgpu_dm_crtc_atomic_set_property(struct drm_crtc *crtc,
> ^
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5374:1:
> note: declare 'static' if the function is not intended to be used
> outside of this translation unit
> int amdgpu_dm_crtc_atomic_set_property(struct drm_crtc *crtc,
> ^
> static
> >> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5398:5:
> warning: no previous prototype for function
> 'amdgpu_dm_crtc_atomic_get_property' [-Wmissing-prototypes]
> int amdgpu_dm_crtc_atomic_get_property(struct drm_crtc *crtc,
> ^
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5398:1:
> note: declare 'static' if the function is not intended to be used
> outside of this translation unit
> int amdgpu_dm_crtc_atomic_get_property(struct drm_crtc *crtc,
> ^
> static
> 2 warnings generated.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Wayne Lin <Wayne.Lin@amd.com>
> ---
> amdgpu_dm/amdgpu_dm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/amdgpu_dm/amdgpu_dm.c b/amdgpu_dm/amdgpu_dm.c
> index 1818d9392..f42046d04 100644
> --- a/amdgpu_dm/amdgpu_dm.c
> +++ b/amdgpu_dm/amdgpu_dm.c
> @@ -4975,7 +4975,7 @@ dm_crtc_duplicate_state(struct drm_crtc *crtc)
> }
>
> #ifdef CONFIG_DEBUG_FS
> -int amdgpu_dm_crtc_atomic_set_property(struct drm_crtc *crtc,
> +static int amdgpu_dm_crtc_atomic_set_property(struct drm_crtc *crtc,
> struct drm_crtc_state *crtc_state,
> struct drm_property *property,
> uint64_t val)
> @@ -4999,7 +4999,7 @@ int amdgpu_dm_crtc_atomic_set_property(struct drm_crtc *crtc,
> return 0;
> }
>
> -int amdgpu_dm_crtc_atomic_get_property(struct drm_crtc *crtc,
> +static int amdgpu_dm_crtc_atomic_get_property(struct drm_crtc *crtc,
> const struct drm_crtc_state *state,
> struct drm_property *property,
> uint64_t *val)
> --
> 2.17.1
>
--
Rodrigo Siqueira
https://siqueira.tech
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-30 14:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-30 7:54 [PATCH] drm/amdgpu: fix compiler warnings Wayne Lin
2020-11-30 14:41 ` Rodrigo Siqueira
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.