From: Herbert Xu <herbert@gondor.apana.org.au>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-crypto@vger.kernel.org, greearb@candelatech.com,
Steve deRosier <derosier@cal-sierra.com>
Subject: Re: [PATCH v2] crypto: aesni - add ccm(aes) algorithm implementation
Date: Wed, 2 Dec 2020 08:57:22 +1100 [thread overview]
Message-ID: <20201201215722.GA31941@gondor.apana.org.au> (raw)
In-Reply-To: <20201201194556.5220-1-ardb@kernel.org>
On Tue, Dec 01, 2020 at 08:45:56PM +0100, Ard Biesheuvel wrote:
> Add ccm(aes) implementation from linux-wireless mailing list (see
> http://permalink.gmane.org/gmane.linux.kernel.wireless.general/126679).
>
> This eliminates FPU context store/restore overhead existing in more
> general ccm_base(ctr(aes-aesni),aes-aesni) case in MAC calculation.
>
> Suggested-by: Ben Greear <greearb@candelatech.com>
> Co-developed-by: Steve deRosier <derosier@cal-sierra.com>
> Signed-off-by: Steve deRosier <derosier@cal-sierra.com>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> v2: avoid the SIMD helper, as it produces an CRYPTO_ALG_ASYNC aead, which
> is not usable by the 802.11 ccmp driver
Sorry, but this is not the way to go. Please fix wireless to
use the async interface instead.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2020-12-01 21:58 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 19:45 [PATCH v2] crypto: aesni - add ccm(aes) algorithm implementation Ard Biesheuvel
2020-12-01 21:40 ` Ben Greear
2020-12-01 21:57 ` Herbert Xu [this message]
2020-12-01 22:00 ` Ben Greear
2020-12-01 22:01 ` Herbert Xu
2020-12-01 22:01 ` Ard Biesheuvel
2020-12-01 22:04 ` Herbert Xu
2020-12-01 22:12 ` Ard Biesheuvel
2020-12-01 22:16 ` Herbert Xu
2020-12-01 22:27 ` Ard Biesheuvel
2020-12-01 23:11 ` Herbert Xu
2020-12-01 23:24 ` Ard Biesheuvel
2020-12-01 23:30 ` Herbert Xu
2020-12-01 23:41 ` Ard Biesheuvel
2020-12-01 23:48 ` Herbert Xu
2020-12-02 0:01 ` Ben Greear
2020-12-10 0:18 ` Ard Biesheuvel
2020-12-10 2:43 ` Herbert Xu
2020-12-10 3:01 ` Ben Greear
2020-12-10 7:30 ` Ard Biesheuvel
2020-12-10 11:14 ` Herbert Xu
2020-12-10 12:03 ` Ard Biesheuvel
2020-12-10 12:16 ` Herbert Xu
2020-12-10 12:19 ` Ard Biesheuvel
2020-12-15 8:55 ` Ard Biesheuvel
2020-12-15 9:19 ` Herbert Xu
2022-11-08 18:50 ` Ben Greear
2022-11-09 3:52 ` Herbert Xu
2022-11-09 10:05 ` Ard Biesheuvel
2022-11-09 14:12 ` Ben Greear
2022-11-11 22:29 ` Ben Greear
2022-11-12 14:59 ` Ard Biesheuvel
2023-10-16 20:50 ` Ben Greear
2023-10-17 3:16 ` Eric Biggers
2023-10-17 6:43 ` Ard Biesheuvel
2023-10-18 1:24 ` Herbert Xu
2020-12-10 14:40 ` Ben Greear
2020-12-01 22:12 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201201215722.GA31941@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=ardb@kernel.org \
--cc=derosier@cal-sierra.com \
--cc=greearb@candelatech.com \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.