From: Ben Greear <greearb@candelatech.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
Ard Biesheuvel <ardb@kernel.org>
Cc: Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
Steve deRosier <derosier@cal-sierra.com>
Subject: Re: [PATCH v2] crypto: aesni - add ccm(aes) algorithm implementation
Date: Tue, 1 Dec 2020 14:12:34 -0800 [thread overview]
Message-ID: <acdaf933-e7a3-e30b-28c3-a324fe957979@candelatech.com> (raw)
In-Reply-To: <20201201220431.GA32072@gondor.apana.org.au>
On 12/1/20 2:04 PM, Herbert Xu wrote:
> On Tue, Dec 01, 2020 at 11:01:57PM +0100, Ard Biesheuvel wrote:
>>
>> This is not the first time this has come up. The point is that CCMP in
>> the wireless stack is not used in 99% of the cases, given that any
>> wifi hardware built in the last ~10 years can do it in hardware. Only
>> in exceptional cases, such as Ben's, is there a need for exercising
>> this interface.
>
> Either it matters or it doesn't. If it doesn't matter why are we
> having this dicussion at all? If it does then fixing just one
> direction makes no sense.
>
>> Also, care to explain why we have synchronous AEADs in the first place
>> if they are not supposed to be used?
>
> Sync AEADs would make sense if you were dealing with a very small
> amount of data, e.g., one block.
Sure, I bet some part of the kernel does this. So let the patch in to
handle that case. It will just be happy luck that it improves some other
problems as well.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
prev parent reply other threads:[~2020-12-01 22:13 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 19:45 [PATCH v2] crypto: aesni - add ccm(aes) algorithm implementation Ard Biesheuvel
2020-12-01 21:40 ` Ben Greear
2020-12-01 21:57 ` Herbert Xu
2020-12-01 22:00 ` Ben Greear
2020-12-01 22:01 ` Herbert Xu
2020-12-01 22:01 ` Ard Biesheuvel
2020-12-01 22:04 ` Herbert Xu
2020-12-01 22:12 ` Ard Biesheuvel
2020-12-01 22:16 ` Herbert Xu
2020-12-01 22:27 ` Ard Biesheuvel
2020-12-01 23:11 ` Herbert Xu
2020-12-01 23:24 ` Ard Biesheuvel
2020-12-01 23:30 ` Herbert Xu
2020-12-01 23:41 ` Ard Biesheuvel
2020-12-01 23:48 ` Herbert Xu
2020-12-02 0:01 ` Ben Greear
2020-12-10 0:18 ` Ard Biesheuvel
2020-12-10 2:43 ` Herbert Xu
2020-12-10 3:01 ` Ben Greear
2020-12-10 7:30 ` Ard Biesheuvel
2020-12-10 11:14 ` Herbert Xu
2020-12-10 12:03 ` Ard Biesheuvel
2020-12-10 12:16 ` Herbert Xu
2020-12-10 12:19 ` Ard Biesheuvel
2020-12-15 8:55 ` Ard Biesheuvel
2020-12-15 9:19 ` Herbert Xu
2022-11-08 18:50 ` Ben Greear
2022-11-09 3:52 ` Herbert Xu
2022-11-09 10:05 ` Ard Biesheuvel
2022-11-09 14:12 ` Ben Greear
2022-11-11 22:29 ` Ben Greear
2022-11-12 14:59 ` Ard Biesheuvel
2023-10-16 20:50 ` Ben Greear
2023-10-17 3:16 ` Eric Biggers
2023-10-17 6:43 ` Ard Biesheuvel
2023-10-18 1:24 ` Herbert Xu
2020-12-10 14:40 ` Ben Greear
2020-12-01 22:12 ` Ben Greear [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acdaf933-e7a3-e30b-28c3-a324fe957979@candelatech.com \
--to=greearb@candelatech.com \
--cc=ardb@kernel.org \
--cc=derosier@cal-sierra.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.