All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Staging: ralink-gdma: ralink-gdma: Fix a blank line coding style issue
@ 2020-12-10  1:32 ` Triplehx3
  0 siblings, 0 replies; 8+ messages in thread
From: Triplehx3 @ 2020-12-10  1:32 UTC (permalink / raw)
  To: gregkh; +Cc: devel, linux-kernel, Triplehx3

Fix a coding style issue as identified by checkpatch.pl

Signed-off-by: Triplehx3 <ginge264@gmail.com>
---
 drivers/staging/ralink-gdma/ralink-gdma.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c
index 655df317d0ee..a6181a167814 100644
--- a/drivers/staging/ralink-gdma/ralink-gdma.c
+++ b/drivers/staging/ralink-gdma/ralink-gdma.c
@@ -122,6 +122,7 @@ struct gdma_dma_dev {
 	struct gdma_data *data;
 	void __iomem *base;
 	struct tasklet_struct task;
+
 	volatile unsigned long chan_issued;
 	atomic_t cnt;
 
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH] Staging: ralink-gdma: ralink-gdma: Fix a blank line coding style issue
@ 2020-12-10  1:32 ` Triplehx3
  0 siblings, 0 replies; 8+ messages in thread
From: Triplehx3 @ 2020-12-10  1:32 UTC (permalink / raw)
  To: gregkh; +Cc: devel, linux-kernel, Triplehx3

Fix a coding style issue as identified by checkpatch.pl

Signed-off-by: Triplehx3 <ginge264@gmail.com>
---
 drivers/staging/ralink-gdma/ralink-gdma.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c
index 655df317d0ee..a6181a167814 100644
--- a/drivers/staging/ralink-gdma/ralink-gdma.c
+++ b/drivers/staging/ralink-gdma/ralink-gdma.c
@@ -122,6 +122,7 @@ struct gdma_dma_dev {
 	struct gdma_data *data;
 	void __iomem *base;
 	struct tasklet_struct task;
+
 	volatile unsigned long chan_issued;
 	atomic_t cnt;
 
-- 
2.28.0

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH] Staging: ralink-gdma: ralink-gdma: Fix a blank line coding style issue
  2020-12-10  1:32 ` Triplehx3
@ 2020-12-10  7:57   ` Greg KH
  -1 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2020-12-10  7:57 UTC (permalink / raw)
  To: Triplehx3; +Cc: devel, linux-kernel

On Thu, Dec 10, 2020 at 01:32:28AM +0000, Triplehx3 wrote:
> Fix a coding style issue as identified by checkpatch.pl
> 
> Signed-off-by: Triplehx3 <ginge264@gmail.com>
> ---
>  drivers/staging/ralink-gdma/ralink-gdma.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c
> index 655df317d0ee..a6181a167814 100644
> --- a/drivers/staging/ralink-gdma/ralink-gdma.c
> +++ b/drivers/staging/ralink-gdma/ralink-gdma.c
> @@ -122,6 +122,7 @@ struct gdma_dma_dev {
>  	struct gdma_data *data;
>  	void __iomem *base;
>  	struct tasklet_struct task;
> +
>  	volatile unsigned long chan_issued;
>  	atomic_t cnt;
>  


Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- It looks like you did not use your "real" name for the patch on either
  the Signed-off-by: line, or the From: line (both of which have to
  match).  Please read the kernel file, Documentation/SubmittingPatches
  for how to do this correctly.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] Staging: ralink-gdma: ralink-gdma: Fix a blank line coding style issue
@ 2020-12-10  7:57   ` Greg KH
  0 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2020-12-10  7:57 UTC (permalink / raw)
  To: Triplehx3; +Cc: devel, linux-kernel

On Thu, Dec 10, 2020 at 01:32:28AM +0000, Triplehx3 wrote:
> Fix a coding style issue as identified by checkpatch.pl
> 
> Signed-off-by: Triplehx3 <ginge264@gmail.com>
> ---
>  drivers/staging/ralink-gdma/ralink-gdma.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c
> index 655df317d0ee..a6181a167814 100644
> --- a/drivers/staging/ralink-gdma/ralink-gdma.c
> +++ b/drivers/staging/ralink-gdma/ralink-gdma.c
> @@ -122,6 +122,7 @@ struct gdma_dma_dev {
>  	struct gdma_data *data;
>  	void __iomem *base;
>  	struct tasklet_struct task;
> +
>  	volatile unsigned long chan_issued;
>  	atomic_t cnt;
>  


Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- It looks like you did not use your "real" name for the patch on either
  the Signed-off-by: line, or the From: line (both of which have to
  match).  Please read the kernel file, Documentation/SubmittingPatches
  for how to do this correctly.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH] Staging: ralink-gdma: ralink-gdma: Fix a blank line coding style issue
@ 2020-12-10 10:06 ` Chris Bloomfield
  0 siblings, 0 replies; 8+ messages in thread
From: Chris Bloomfield @ 2020-12-10 10:06 UTC (permalink / raw)
  To: gregkh; +Cc: devel, linux-kernel, Chris Bloomfield

Fix a coding style issue as identified by checkpatch.pl

Signed-off-by: Chris Bloomfield <ginge264@gmail.com>
---
 drivers/staging/ralink-gdma/ralink-gdma.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c
index 655df317d0ee..a6181a167814 100644
--- a/drivers/staging/ralink-gdma/ralink-gdma.c
+++ b/drivers/staging/ralink-gdma/ralink-gdma.c
@@ -122,6 +122,7 @@ struct gdma_dma_dev {
 	struct gdma_data *data;
 	void __iomem *base;
 	struct tasklet_struct task;
+
 	volatile unsigned long chan_issued;
 	atomic_t cnt;
 
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH] Staging: ralink-gdma: ralink-gdma: Fix a blank line coding style issue
@ 2020-12-10 10:06 ` Chris Bloomfield
  0 siblings, 0 replies; 8+ messages in thread
From: Chris Bloomfield @ 2020-12-10 10:06 UTC (permalink / raw)
  To: gregkh; +Cc: devel, linux-kernel, Chris Bloomfield

Fix a coding style issue as identified by checkpatch.pl

Signed-off-by: Chris Bloomfield <ginge264@gmail.com>
---
 drivers/staging/ralink-gdma/ralink-gdma.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c
index 655df317d0ee..a6181a167814 100644
--- a/drivers/staging/ralink-gdma/ralink-gdma.c
+++ b/drivers/staging/ralink-gdma/ralink-gdma.c
@@ -122,6 +122,7 @@ struct gdma_dma_dev {
 	struct gdma_data *data;
 	void __iomem *base;
 	struct tasklet_struct task;
+
 	volatile unsigned long chan_issued;
 	atomic_t cnt;
 
-- 
2.28.0

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH] Staging: ralink-gdma: ralink-gdma: Fix a blank line coding style issue
  2020-12-10 10:06 ` Chris Bloomfield
@ 2020-12-10  9:28   ` Greg KH
  -1 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2020-12-10  9:28 UTC (permalink / raw)
  To: Chris Bloomfield; +Cc: devel, linux-kernel

On Thu, Dec 10, 2020 at 10:06:57AM +0000, Chris Bloomfield wrote:
> Fix a coding style issue as identified by checkpatch.pl
> 
> Signed-off-by: Chris Bloomfield <ginge264@gmail.com>
> ---
>  drivers/staging/ralink-gdma/ralink-gdma.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c
> index 655df317d0ee..a6181a167814 100644
> --- a/drivers/staging/ralink-gdma/ralink-gdma.c
> +++ b/drivers/staging/ralink-gdma/ralink-gdma.c
> @@ -122,6 +122,7 @@ struct gdma_dma_dev {
>  	struct gdma_data *data;
>  	void __iomem *base;
>  	struct tasklet_struct task;
> +
>  	volatile unsigned long chan_issued;
>  	atomic_t cnt;
>  

With your knowledge of C, do you think the above change looks correct?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] Staging: ralink-gdma: ralink-gdma: Fix a blank line coding style issue
@ 2020-12-10  9:28   ` Greg KH
  0 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2020-12-10  9:28 UTC (permalink / raw)
  To: Chris Bloomfield; +Cc: devel, linux-kernel

On Thu, Dec 10, 2020 at 10:06:57AM +0000, Chris Bloomfield wrote:
> Fix a coding style issue as identified by checkpatch.pl
> 
> Signed-off-by: Chris Bloomfield <ginge264@gmail.com>
> ---
>  drivers/staging/ralink-gdma/ralink-gdma.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c
> index 655df317d0ee..a6181a167814 100644
> --- a/drivers/staging/ralink-gdma/ralink-gdma.c
> +++ b/drivers/staging/ralink-gdma/ralink-gdma.c
> @@ -122,6 +122,7 @@ struct gdma_dma_dev {
>  	struct gdma_data *data;
>  	void __iomem *base;
>  	struct tasklet_struct task;
> +
>  	volatile unsigned long chan_issued;
>  	atomic_t cnt;
>  

With your knowledge of C, do you think the above change looks correct?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2020-12-10  9:27 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-10  1:32 [PATCH] Staging: ralink-gdma: ralink-gdma: Fix a blank line coding style issue Triplehx3
2020-12-10  1:32 ` Triplehx3
2020-12-10  7:57 ` Greg KH
2020-12-10  7:57   ` Greg KH
2020-12-10 10:06 Chris Bloomfield
2020-12-10 10:06 ` Chris Bloomfield
2020-12-10  9:28 ` Greg KH
2020-12-10  9:28   ` Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.