All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: Will Deacon <will@kernel.org>,
	Julien Thierry <julien.thierry.kdev@gmail.com>
Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
	linux-arm-kernel@lists.infradead.org,
	Alexandru Elisei <alexandru.elisei@arm.com>,
	Marc Zyngier <maz@kernel.org>
Subject: [PATCH kvmtool 12/21] hw/vesa: Switch trap handling to use MMIO handler
Date: Thu, 10 Dec 2020 14:28:59 +0000	[thread overview]
Message-ID: <20201210142908.169597-13-andre.przywara@arm.com> (raw)
In-Reply-To: <20201210142908.169597-1-andre.przywara@arm.com>

To be able to use the VESA device with the new generic I/O trap handler,
we need to use the different MMIO handler callback routine.

Replace the existing dummy in and out handlers with a joint dummy
MMIO handler, and register this using the new registration function.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
 hw/vesa.c | 19 +++++--------------
 1 file changed, 5 insertions(+), 14 deletions(-)

diff --git a/hw/vesa.c b/hw/vesa.c
index 8659a002..7f82cdb4 100644
--- a/hw/vesa.c
+++ b/hw/vesa.c
@@ -43,21 +43,11 @@ static struct framebuffer vesafb = {
 	.mem_size	= VESA_MEM_SIZE,
 };
 
-static bool vesa_pci_io_in(struct ioport *ioport, struct kvm_cpu *vcpu, u16 port, void *data, int size)
+static void vesa_pci_io(struct kvm_cpu *vcpu, u64 addr, u8 *data, u32 len,
+		        u8 is_write, void *ptr)
 {
-	return true;
 }
 
-static bool vesa_pci_io_out(struct ioport *ioport, struct kvm_cpu *vcpu, u16 port, void *data, int size)
-{
-	return true;
-}
-
-static struct ioport_operations vesa_io_ops = {
-	.io_in			= vesa_pci_io_in,
-	.io_out			= vesa_pci_io_out,
-};
-
 static int vesa__bar_activate(struct kvm *kvm, struct pci_device_header *pci_hdr,
 			      int bar_num, void *data)
 {
@@ -82,7 +72,8 @@ struct framebuffer *vesa__init(struct kvm *kvm)
 	BUILD_BUG_ON(VESA_MEM_SIZE < VESA_BPP/8 * VESA_WIDTH * VESA_HEIGHT);
 
 	vesa_base_addr = pci_get_io_port_block(PCI_IO_SIZE);
-	r = ioport__register(kvm, vesa_base_addr, &vesa_io_ops, PCI_IO_SIZE, NULL);
+	r = kvm__register_pio(kvm, vesa_base_addr, PCI_IO_SIZE, vesa_pci_io,
+			      NULL);
 	if (r < 0)
 		goto out_error;
 
@@ -116,7 +107,7 @@ unmap_dev:
 unregister_device:
 	device__unregister(&vesa_device);
 unregister_ioport:
-	ioport__unregister(kvm, vesa_base_addr);
+	kvm__deregister_pio(kvm, vesa_base_addr);
 out_error:
 	return ERR_PTR(r);
 }
-- 
2.17.1


WARNING: multiple messages have this Message-ID (diff)
From: Andre Przywara <andre.przywara@arm.com>
To: Will Deacon <will@kernel.org>,
	Julien Thierry <julien.thierry.kdev@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
	Marc Zyngier <maz@kernel.org>,
	kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org
Subject: [PATCH kvmtool 12/21] hw/vesa: Switch trap handling to use MMIO handler
Date: Thu, 10 Dec 2020 14:28:59 +0000	[thread overview]
Message-ID: <20201210142908.169597-13-andre.przywara@arm.com> (raw)
In-Reply-To: <20201210142908.169597-1-andre.przywara@arm.com>

To be able to use the VESA device with the new generic I/O trap handler,
we need to use the different MMIO handler callback routine.

Replace the existing dummy in and out handlers with a joint dummy
MMIO handler, and register this using the new registration function.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
 hw/vesa.c | 19 +++++--------------
 1 file changed, 5 insertions(+), 14 deletions(-)

diff --git a/hw/vesa.c b/hw/vesa.c
index 8659a002..7f82cdb4 100644
--- a/hw/vesa.c
+++ b/hw/vesa.c
@@ -43,21 +43,11 @@ static struct framebuffer vesafb = {
 	.mem_size	= VESA_MEM_SIZE,
 };
 
-static bool vesa_pci_io_in(struct ioport *ioport, struct kvm_cpu *vcpu, u16 port, void *data, int size)
+static void vesa_pci_io(struct kvm_cpu *vcpu, u64 addr, u8 *data, u32 len,
+		        u8 is_write, void *ptr)
 {
-	return true;
 }
 
-static bool vesa_pci_io_out(struct ioport *ioport, struct kvm_cpu *vcpu, u16 port, void *data, int size)
-{
-	return true;
-}
-
-static struct ioport_operations vesa_io_ops = {
-	.io_in			= vesa_pci_io_in,
-	.io_out			= vesa_pci_io_out,
-};
-
 static int vesa__bar_activate(struct kvm *kvm, struct pci_device_header *pci_hdr,
 			      int bar_num, void *data)
 {
@@ -82,7 +72,8 @@ struct framebuffer *vesa__init(struct kvm *kvm)
 	BUILD_BUG_ON(VESA_MEM_SIZE < VESA_BPP/8 * VESA_WIDTH * VESA_HEIGHT);
 
 	vesa_base_addr = pci_get_io_port_block(PCI_IO_SIZE);
-	r = ioport__register(kvm, vesa_base_addr, &vesa_io_ops, PCI_IO_SIZE, NULL);
+	r = kvm__register_pio(kvm, vesa_base_addr, PCI_IO_SIZE, vesa_pci_io,
+			      NULL);
 	if (r < 0)
 		goto out_error;
 
@@ -116,7 +107,7 @@ unmap_dev:
 unregister_device:
 	device__unregister(&vesa_device);
 unregister_ioport:
-	ioport__unregister(kvm, vesa_base_addr);
+	kvm__deregister_pio(kvm, vesa_base_addr);
 out_error:
 	return ERR_PTR(r);
 }
-- 
2.17.1

_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

WARNING: multiple messages have this Message-ID (diff)
From: Andre Przywara <andre.przywara@arm.com>
To: Will Deacon <will@kernel.org>,
	Julien Thierry <julien.thierry.kdev@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
	Marc Zyngier <maz@kernel.org>,
	Alexandru Elisei <alexandru.elisei@arm.com>,
	kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org
Subject: [PATCH kvmtool 12/21] hw/vesa: Switch trap handling to use MMIO handler
Date: Thu, 10 Dec 2020 14:28:59 +0000	[thread overview]
Message-ID: <20201210142908.169597-13-andre.przywara@arm.com> (raw)
In-Reply-To: <20201210142908.169597-1-andre.przywara@arm.com>

To be able to use the VESA device with the new generic I/O trap handler,
we need to use the different MMIO handler callback routine.

Replace the existing dummy in and out handlers with a joint dummy
MMIO handler, and register this using the new registration function.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
 hw/vesa.c | 19 +++++--------------
 1 file changed, 5 insertions(+), 14 deletions(-)

diff --git a/hw/vesa.c b/hw/vesa.c
index 8659a002..7f82cdb4 100644
--- a/hw/vesa.c
+++ b/hw/vesa.c
@@ -43,21 +43,11 @@ static struct framebuffer vesafb = {
 	.mem_size	= VESA_MEM_SIZE,
 };
 
-static bool vesa_pci_io_in(struct ioport *ioport, struct kvm_cpu *vcpu, u16 port, void *data, int size)
+static void vesa_pci_io(struct kvm_cpu *vcpu, u64 addr, u8 *data, u32 len,
+		        u8 is_write, void *ptr)
 {
-	return true;
 }
 
-static bool vesa_pci_io_out(struct ioport *ioport, struct kvm_cpu *vcpu, u16 port, void *data, int size)
-{
-	return true;
-}
-
-static struct ioport_operations vesa_io_ops = {
-	.io_in			= vesa_pci_io_in,
-	.io_out			= vesa_pci_io_out,
-};
-
 static int vesa__bar_activate(struct kvm *kvm, struct pci_device_header *pci_hdr,
 			      int bar_num, void *data)
 {
@@ -82,7 +72,8 @@ struct framebuffer *vesa__init(struct kvm *kvm)
 	BUILD_BUG_ON(VESA_MEM_SIZE < VESA_BPP/8 * VESA_WIDTH * VESA_HEIGHT);
 
 	vesa_base_addr = pci_get_io_port_block(PCI_IO_SIZE);
-	r = ioport__register(kvm, vesa_base_addr, &vesa_io_ops, PCI_IO_SIZE, NULL);
+	r = kvm__register_pio(kvm, vesa_base_addr, PCI_IO_SIZE, vesa_pci_io,
+			      NULL);
 	if (r < 0)
 		goto out_error;
 
@@ -116,7 +107,7 @@ unmap_dev:
 unregister_device:
 	device__unregister(&vesa_device);
 unregister_ioport:
-	ioport__unregister(kvm, vesa_base_addr);
+	kvm__deregister_pio(kvm, vesa_base_addr);
 out_error:
 	return ERR_PTR(r);
 }
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-12-10 19:08 UTC|newest]

Thread overview: 216+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-10 14:28 [PATCH kvmtool 00/21] Unify I/O port and MMIO trap handling Andre Przywara
2020-12-10 14:28 ` Andre Przywara
2020-12-10 14:28 ` Andre Przywara
2020-12-10 14:28 ` [PATCH kvmtool 01/21] ioport: Remove ioport__setup_arch() Andre Przywara
2020-12-10 14:28   ` Andre Przywara
2020-12-10 14:28   ` Andre Przywara
2021-02-10 17:44   ` Alexandru Elisei
2021-02-10 17:44     ` Alexandru Elisei
2021-02-10 17:44     ` Alexandru Elisei
2021-02-11 17:16     ` Andre Przywara
2021-02-11 17:16       ` Andre Przywara
2021-02-11 17:16       ` Andre Przywara
2021-02-11 17:32       ` Alexandru Elisei
2021-02-11 17:32         ` Alexandru Elisei
2021-02-11 17:32         ` Alexandru Elisei
2021-02-17 16:46         ` Andre Przywara
2021-02-17 16:46           ` Andre Przywara
2021-02-17 16:46           ` Andre Przywara
2021-02-22 10:23           ` Andre Przywara
2021-02-22 10:23             ` Andre Przywara
2021-02-22 10:23             ` Andre Przywara
2021-02-22 15:01             ` Alexandru Elisei
2021-02-22 15:01               ` Alexandru Elisei
2021-02-22 15:01               ` Alexandru Elisei
2020-12-10 14:28 ` [PATCH kvmtool 02/21] hw/serial: Use device abstraction for FDT generator function Andre Przywara
2020-12-10 14:28   ` Andre Przywara
2020-12-10 14:28   ` Andre Przywara
2021-02-11 12:05   ` Alexandru Elisei
2021-02-11 12:05     ` Alexandru Elisei
2021-02-11 12:05     ` Alexandru Elisei
2021-02-11 17:45     ` Andre Przywara
2021-02-11 17:45       ` Andre Przywara
2021-02-11 17:45       ` Andre Przywara
2020-12-10 14:28 ` [PATCH kvmtool 03/21] ioport: Retire .generate_fdt_node functionality Andre Przywara
2020-12-10 14:28   ` Andre Przywara
2020-12-10 14:28   ` Andre Przywara
2021-02-11 14:05   ` Alexandru Elisei
2021-02-11 14:05     ` Alexandru Elisei
2021-02-11 14:05     ` Alexandru Elisei
2021-02-17 15:54     ` Andre Przywara
2021-02-17 15:54       ` Andre Przywara
2021-02-17 15:54       ` Andre Przywara
2021-02-17 16:06       ` Alexandru Elisei
2021-02-17 16:06         ` Alexandru Elisei
2021-02-17 16:06         ` Alexandru Elisei
2020-12-10 14:28 ` [PATCH kvmtool 04/21] mmio: Extend handling to include ioport emulation Andre Przywara
2020-12-10 14:28   ` Andre Przywara
2020-12-10 14:28   ` Andre Przywara
2021-02-11 16:10   ` Alexandru Elisei
2021-02-11 16:10     ` Alexandru Elisei
2021-02-11 16:10     ` Alexandru Elisei
2021-02-17 17:43     ` Andre Przywara
2021-02-17 17:43       ` Andre Przywara
2021-02-17 17:43       ` Andre Przywara
2021-02-22 15:50       ` Alexandru Elisei
2021-02-22 15:50         ` Alexandru Elisei
2021-02-22 15:50         ` Alexandru Elisei
2020-12-10 14:28 ` [PATCH kvmtool 05/21] hw/i8042: Clean up data types Andre Przywara
2020-12-10 14:28   ` Andre Przywara
2020-12-10 14:28   ` Andre Przywara
2021-02-11 16:55   ` Alexandru Elisei
2021-02-11 16:55     ` Alexandru Elisei
2021-02-11 16:55     ` Alexandru Elisei
2021-02-17 17:46     ` Andre Przywara
2021-02-17 17:46       ` Andre Przywara
2021-02-17 17:46       ` Andre Przywara
2020-12-10 14:28 ` [PATCH kvmtool 06/21] hw/i8042: Refactor trap handler Andre Przywara
2020-12-10 14:28   ` Andre Przywara
2020-12-10 14:28   ` Andre Przywara
2021-02-11 17:23   ` Alexandru Elisei
2021-02-11 17:23     ` Alexandru Elisei
2021-02-11 17:23     ` Alexandru Elisei
2021-02-18 10:34     ` Andre Przywara
2021-02-18 10:34       ` Andre Przywara
2021-02-18 10:34       ` Andre Przywara
2021-02-18 11:17       ` Alexandru Elisei
2021-02-18 11:17         ` Alexandru Elisei
2021-02-18 11:17         ` Alexandru Elisei
2021-02-18 11:48         ` Andre Przywara
2021-02-18 11:48           ` Andre Przywara
2021-02-18 11:48           ` Andre Przywara
2021-02-22 16:03           ` Alexandru Elisei
2021-02-22 16:03             ` Alexandru Elisei
2021-02-22 16:03             ` Alexandru Elisei
2020-12-10 14:28 ` [PATCH kvmtool 07/21] hw/i8042: Switch to new trap handlers Andre Przywara
2020-12-10 14:28   ` Andre Przywara
2020-12-10 14:28   ` Andre Przywara
2021-02-12 10:41   ` Alexandru Elisei
2021-02-12 10:41     ` Alexandru Elisei
2021-02-12 10:41     ` Alexandru Elisei
2021-02-18 12:09     ` Andre Przywara
2021-02-18 12:09       ` Andre Przywara
2021-02-18 12:09       ` Andre Przywara
2021-02-22 16:19       ` Alexandru Elisei
2021-02-22 16:19         ` Alexandru Elisei
2021-02-22 16:19         ` Alexandru Elisei
2020-12-10 14:28 ` [PATCH kvmtool 08/21] x86/ioport: Refactor " Andre Przywara
2020-12-10 14:28   ` Andre Przywara
2020-12-10 14:28   ` Andre Przywara
2021-02-12 11:14   ` Alexandru Elisei
2021-02-12 11:14     ` Alexandru Elisei
2021-02-12 11:14     ` Alexandru Elisei
2020-12-10 14:28 ` [PATCH kvmtool 09/21] x86/ioport: Switch to new " Andre Przywara
2020-12-10 14:28   ` Andre Przywara
2020-12-10 14:28   ` Andre Przywara
2021-02-12 11:27   ` Alexandru Elisei
2021-02-12 11:27     ` Alexandru Elisei
2021-02-12 11:27     ` Alexandru Elisei
2021-02-18 14:05     ` Andre Przywara
2021-02-18 14:05       ` Andre Przywara
2021-02-18 14:05       ` Andre Przywara
2020-12-10 14:28 ` [PATCH kvmtool 10/21] hw/rtc: Refactor " Andre Przywara
2020-12-10 14:28   ` Andre Przywara
2020-12-10 14:28   ` Andre Przywara
2021-02-12 11:56   ` Alexandru Elisei
2021-02-12 11:56     ` Alexandru Elisei
2021-02-12 11:56     ` Alexandru Elisei
2020-12-10 14:28 ` [PATCH kvmtool 11/21] hw/rtc: Switch to new trap handler Andre Przywara
2020-12-10 14:28   ` Andre Przywara
2020-12-10 14:28   ` Andre Przywara
2021-02-12 12:02   ` Alexandru Elisei
2021-02-12 12:02     ` Alexandru Elisei
2021-02-12 12:02     ` Alexandru Elisei
2020-12-10 14:28 ` Andre Przywara [this message]
2020-12-10 14:28   ` [PATCH kvmtool 12/21] hw/vesa: Switch trap handling to use MMIO handler Andre Przywara
2020-12-10 14:28   ` Andre Przywara
2021-02-12 17:50   ` Alexandru Elisei
2021-02-12 17:50     ` Alexandru Elisei
2021-02-12 17:50     ` Alexandru Elisei
2020-12-10 14:29 ` [PATCH kvmtool 13/21] hw/serial: Refactor trap handler Andre Przywara
2020-12-10 14:29   ` Andre Przywara
2020-12-10 14:29   ` Andre Przywara
2021-02-16 14:22   ` Alexandru Elisei
2021-02-16 14:22     ` Alexandru Elisei
2021-02-16 14:22     ` Alexandru Elisei
2021-02-18 14:41     ` Andre Przywara
2021-02-18 14:41       ` Andre Przywara
2021-02-18 14:41       ` Andre Przywara
2021-02-22 17:40       ` Alexandru Elisei
2021-02-22 17:40         ` Alexandru Elisei
2021-02-22 17:40         ` Alexandru Elisei
2021-02-24 14:54         ` Andre Przywara
2021-02-24 14:54           ` Andre Przywara
2021-02-24 14:54           ` Andre Przywara
2020-12-10 14:29 ` [PATCH kvmtool 14/21] hw/serial: Switch to new trap handlers Andre Przywara
2020-12-10 14:29   ` Andre Przywara
2020-12-10 14:29   ` Andre Przywara
2021-02-16 14:31   ` Alexandru Elisei
2021-02-16 14:31     ` Alexandru Elisei
2021-02-16 14:31     ` Alexandru Elisei
2020-12-10 14:29 ` [PATCH kvmtool 15/21] vfio: Refactor ioport trap handler Andre Przywara
2020-12-10 14:29   ` Andre Przywara
2020-12-10 14:29   ` Andre Przywara
2021-02-16 14:47   ` Alexandru Elisei
2021-02-16 14:47     ` Alexandru Elisei
2021-02-16 14:47     ` Alexandru Elisei
2021-02-18 15:51     ` Andre Przywara
2021-02-18 15:51       ` Andre Przywara
2021-02-18 15:51       ` Andre Przywara
2020-12-10 14:29 ` [PATCH kvmtool 16/21] vfio: Switch to new ioport trap handlers Andre Przywara
2020-12-10 14:29   ` Andre Przywara
2020-12-10 14:29   ` Andre Przywara
2021-02-16 14:52   ` Alexandru Elisei
2021-02-16 14:52     ` Alexandru Elisei
2021-02-16 14:52     ` Alexandru Elisei
2020-12-10 14:29 ` [PATCH kvmtool 17/21] virtio: Switch trap handling to use MMIO handler Andre Przywara
2020-12-10 14:29   ` Andre Przywara
2020-12-10 14:29   ` Andre Przywara
2021-02-16 17:03   ` Alexandru Elisei
2021-02-16 17:03     ` Alexandru Elisei
2021-02-16 17:03     ` Alexandru Elisei
2021-02-18 16:13     ` Andre Przywara
2021-02-18 16:13       ` Andre Przywara
2021-02-18 16:13       ` Andre Przywara
2020-12-10 14:29 ` [PATCH kvmtool 18/21] pci: " Andre Przywara
2020-12-10 14:29   ` Andre Przywara
2020-12-10 14:29   ` Andre Przywara
2021-02-17 15:14   ` Alexandru Elisei
2021-02-17 15:14     ` Alexandru Elisei
2021-02-17 15:14     ` Alexandru Elisei
2020-12-10 14:29 ` [PATCH kvmtool 19/21] Remove ioport specific routines Andre Przywara
2020-12-10 14:29   ` Andre Przywara
2020-12-10 14:29   ` Andre Przywara
2021-02-17 15:49   ` Alexandru Elisei
2021-02-17 15:49     ` Alexandru Elisei
2021-02-17 15:49     ` Alexandru Elisei
2021-02-17 16:11     ` Alexandru Elisei
2021-02-17 16:11       ` Alexandru Elisei
2021-02-17 16:11       ` Alexandru Elisei
2021-02-18 16:34       ` Andre Przywara
2021-02-18 16:34         ` Andre Przywara
2021-02-18 16:34         ` Andre Przywara
2020-12-10 14:29 ` [PATCH kvmtool 20/21] hw/serial: ARM/arm64: Use MMIO at higher addresses Andre Przywara
2020-12-10 14:29   ` Andre Przywara
2020-12-10 14:29   ` Andre Przywara
2021-02-17 16:48   ` Alexandru Elisei
2021-02-17 16:48     ` Alexandru Elisei
2021-02-17 16:48     ` Alexandru Elisei
2021-02-18 12:18     ` Alexandru Elisei
2021-02-18 12:18       ` Alexandru Elisei
2021-02-18 12:18       ` Alexandru Elisei
2021-02-18 16:38       ` Andre Przywara
2021-02-18 16:38         ` Andre Przywara
2021-02-18 16:38         ` Andre Przywara
2020-12-10 14:29 ` [PATCH kvmtool 21/21] hw/rtc: " Andre Przywara
2020-12-10 14:29   ` Andre Przywara
2020-12-10 14:29   ` Andre Przywara
2021-02-18 13:33   ` Alexandru Elisei
2021-02-18 13:33     ` Alexandru Elisei
2021-02-18 13:33     ` Alexandru Elisei
2021-02-18 16:41     ` Andre Przywara
2021-02-18 16:41       ` Andre Przywara
2021-02-18 16:41       ` Andre Przywara
2021-02-10 17:44 ` [PATCH kvmtool 00/21] Unify I/O port and MMIO trap handling Alexandru Elisei
2021-02-10 17:44   ` Alexandru Elisei
2021-02-10 17:44   ` Alexandru Elisei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201210142908.169597-13-andre.przywara@arm.com \
    --to=andre.przywara@arm.com \
    --cc=alexandru.elisei@arm.com \
    --cc=julien.thierry.kdev@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=maz@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.