All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: dts: aspeed: g220a: Enable ipmb
@ 2020-12-11  4:00 John Wang
  2020-12-11  4:00 ` [PATCH 2/2] ARM: dts: aspeed: g220a: Fix some gpio John Wang
  2020-12-11 10:47 ` [PATCH 1/2] ARM: dts: aspeed: g220a: Enable ipmb Joel Stanley
  0 siblings, 2 replies; 4+ messages in thread
From: John Wang @ 2020-12-11  4:00 UTC (permalink / raw)
  To: xuxiaohan, yulei.sh, openbmc, joel

From: Lotus Xu <xuxiaohan@bytedance.com>

Enable ipmb on i2c4

Signed-off-by: Lotus Xu <xuxiaohan@bytedance.com>
Signed-off-by: John Wang <wangzhiqiang.bj@bytedance.com>
---
 arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dts | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dts b/arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dts
index 89916a2eec18..3a4bf3db400c 100644
--- a/arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dts
@@ -453,7 +453,11 @@ channel_3_3: i2c@3 {
 
 &i2c4 {
 	status = "okay";
-
+	ipmb0@10 {
+		compatible = "ipmb-dev";
+		reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
+		i2c-protocol;
+	};
 };
 
 &i2c5 {
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] ARM: dts: aspeed: g220a: Fix some gpio
  2020-12-11  4:00 [PATCH 1/2] ARM: dts: aspeed: g220a: Enable ipmb John Wang
@ 2020-12-11  4:00 ` John Wang
  2020-12-11 10:47   ` Joel Stanley
  2020-12-11 10:47 ` [PATCH 1/2] ARM: dts: aspeed: g220a: Enable ipmb Joel Stanley
  1 sibling, 1 reply; 4+ messages in thread
From: John Wang @ 2020-12-11  4:00 UTC (permalink / raw)
  To: xuxiaohan, yulei.sh, openbmc, joel

The NCSI_BMC_R_SEL and EN_NCSI_SWITCH_N should be active-high

Signed-off-by: John Wang <wangzhiqiang.bj@bytedance.com>
---
 arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dts b/arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dts
index 3a4bf3db400c..8baefd2d6962 100644
--- a/arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dts
@@ -912,14 +912,14 @@ fan@5 {
 &gpio {
 	pin_gpio_i3 {
 		gpio-hog;
-		gpios = <ASPEED_GPIO(I, 3) GPIO_ACTIVE_LOW>;
+		gpios = <ASPEED_GPIO(I, 3) GPIO_ACTIVE_HIGH>;
 		output-low;
 		line-name = "NCSI_BMC_R_SEL";
 	};
 
 	pin_gpio_b6 {
 		gpio-hog;
-		gpios = <ASPEED_GPIO(B, 6) GPIO_ACTIVE_LOW>;
+		gpios = <ASPEED_GPIO(B, 6) GPIO_ACTIVE_HIGH>;
 		output-low;
 		line-name = "EN_NCSI_SWITCH_N";
 	};
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] ARM: dts: aspeed: g220a: Enable ipmb
  2020-12-11  4:00 [PATCH 1/2] ARM: dts: aspeed: g220a: Enable ipmb John Wang
  2020-12-11  4:00 ` [PATCH 2/2] ARM: dts: aspeed: g220a: Fix some gpio John Wang
@ 2020-12-11 10:47 ` Joel Stanley
  1 sibling, 0 replies; 4+ messages in thread
From: Joel Stanley @ 2020-12-11 10:47 UTC (permalink / raw)
  To: John Wang; +Cc: OpenBMC Maillist, 郁雷, xuxiaohan

On Fri, 11 Dec 2020 at 04:00, John Wang <wangzhiqiang.bj@bytedance.com> wrote:
>
> From: Lotus Xu <xuxiaohan@bytedance.com>
>
> Enable ipmb on i2c4
>
> Signed-off-by: Lotus Xu <xuxiaohan@bytedance.com>
> Signed-off-by: John Wang <wangzhiqiang.bj@bytedance.com>

Reviewed-by: Joel Stanley <joel@jms.id.au>

> ---
>  arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dts | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dts b/arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dts
> index 89916a2eec18..3a4bf3db400c 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dts
> @@ -453,7 +453,11 @@ channel_3_3: i2c@3 {
>
>  &i2c4 {
>         status = "okay";
> -
> +       ipmb0@10 {
> +               compatible = "ipmb-dev";
> +               reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> +               i2c-protocol;
> +       };
>  };
>
>  &i2c5 {
> --
> 2.25.1
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] ARM: dts: aspeed: g220a: Fix some gpio
  2020-12-11  4:00 ` [PATCH 2/2] ARM: dts: aspeed: g220a: Fix some gpio John Wang
@ 2020-12-11 10:47   ` Joel Stanley
  0 siblings, 0 replies; 4+ messages in thread
From: Joel Stanley @ 2020-12-11 10:47 UTC (permalink / raw)
  To: John Wang; +Cc: OpenBMC Maillist, 郁雷, xuxiaohan

On Fri, 11 Dec 2020 at 04:00, John Wang <wangzhiqiang.bj@bytedance.com> wrote:
>
> The NCSI_BMC_R_SEL and EN_NCSI_SWITCH_N should be active-high
>
> Signed-off-by: John Wang <wangzhiqiang.bj@bytedance.com>

Reviewed-by: Joel Stanley <joel@jms.id.au>

> ---
>  arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dts b/arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dts
> index 3a4bf3db400c..8baefd2d6962 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dts
> @@ -912,14 +912,14 @@ fan@5 {
>  &gpio {
>         pin_gpio_i3 {
>                 gpio-hog;
> -               gpios = <ASPEED_GPIO(I, 3) GPIO_ACTIVE_LOW>;
> +               gpios = <ASPEED_GPIO(I, 3) GPIO_ACTIVE_HIGH>;
>                 output-low;
>                 line-name = "NCSI_BMC_R_SEL";
>         };
>
>         pin_gpio_b6 {
>                 gpio-hog;
> -               gpios = <ASPEED_GPIO(B, 6) GPIO_ACTIVE_LOW>;
> +               gpios = <ASPEED_GPIO(B, 6) GPIO_ACTIVE_HIGH>;
>                 output-low;
>                 line-name = "EN_NCSI_SWITCH_N";
>         };
> --
> 2.25.1
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-12-11 10:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-11  4:00 [PATCH 1/2] ARM: dts: aspeed: g220a: Enable ipmb John Wang
2020-12-11  4:00 ` [PATCH 2/2] ARM: dts: aspeed: g220a: Fix some gpio John Wang
2020-12-11 10:47   ` Joel Stanley
2020-12-11 10:47 ` [PATCH 1/2] ARM: dts: aspeed: g220a: Enable ipmb Joel Stanley

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.