* [PATCH -next] mfd: rave-sp: convert comma to semicolon
@ 2020-12-11 8:44 Zheng Yongjun
2020-12-11 10:05 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Zheng Yongjun @ 2020-12-11 8:44 UTC (permalink / raw)
To: linux-kernel; +Cc: Zheng Yongjun
Replace a comma between expression statements by a semicolon.
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
drivers/mfd/rave-sp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/rave-sp.c b/drivers/mfd/rave-sp.c
index 545196c85b5c..abb9cbdabaa9 100644
--- a/drivers/mfd/rave-sp.c
+++ b/drivers/mfd/rave-sp.c
@@ -358,7 +358,7 @@ int rave_sp_exec(struct rave_sp *sp,
ackid = atomic_inc_return(&sp->ackid);
reply.ackid = ackid;
- reply.code = rave_sp_reply_code((u8)command),
+ reply.code = rave_sp_reply_code((u8)command);
mutex_lock(&sp->bus_lock);
--
2.22.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] mfd: rave-sp: convert comma to semicolon
2020-12-11 8:44 [PATCH -next] mfd: rave-sp: convert comma to semicolon Zheng Yongjun
@ 2020-12-11 10:05 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2020-12-11 10:05 UTC (permalink / raw)
To: Zheng Yongjun; +Cc: linux-kernel
On Fri, 11 Dec 2020, Zheng Yongjun wrote:
> Replace a comma between expression statements by a semicolon.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
> drivers/mfd/rave-sp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/rave-sp.c b/drivers/mfd/rave-sp.c
> index 545196c85b5c..abb9cbdabaa9 100644
> --- a/drivers/mfd/rave-sp.c
> +++ b/drivers/mfd/rave-sp.c
> @@ -358,7 +358,7 @@ int rave_sp_exec(struct rave_sp *sp,
>
> ackid = atomic_inc_return(&sp->ackid);
> reply.ackid = ackid;
> - reply.code = rave_sp_reply_code((u8)command),
> + reply.code = rave_sp_reply_code((u8)command);
How did the original code not create a build error?
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-11 10:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-11 8:44 [PATCH -next] mfd: rave-sp: convert comma to semicolon Zheng Yongjun
2020-12-11 10:05 ` Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.