From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Cc: thierry.reding@gmail.com, lee.jones@linaro.org,
nsaenzjulienne@suse.de, f.fainelli@gmail.com, rjui@broadcom.com,
sean@mess.org, sbranden@broadcom.com,
bcm-kernel-feedback-list@broadcom.com, linux-pwm@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] pwm: bcm2835: Support apply function for atomic configuration
Date: Fri, 11 Dec 2020 10:53:05 +0100 [thread overview]
Message-ID: <20201211095305.vsin3mkrytylqm47@pengutronix.de> (raw)
In-Reply-To: <trinity-8db15ca3-e42e-497d-8718-b4928fa76a3c-1607678915350@3c-app-gmx-bs43>
[-- Attachment #1: Type: text/plain, Size: 1692 bytes --]
On Fri, Dec 11, 2020 at 10:28:35AM +0100, Lino Sanfilippo wrote:
> Hi Uwe,
>
> > Gesendet: Donnerstag, 10. Dezember 2020 um 12:43 Uhr
> > Von: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
> > An: "Lino Sanfilippo" <LinoSanfilippo@gmx.de>
> > Cc: thierry.reding@gmail.com, lee.jones@linaro.org, nsaenzjulienne@suse.de, f.fainelli@gmail.com, rjui@broadcom.com, sean@mess.org, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, linux-pwm@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
> > Betreff: Re: [PATCH v3] pwm: bcm2835: Support apply function for atomic configuration
>
> >
> > Side note: I'm a bit surprised about the output of
> >
> > b4 diff 1607464905-16630-1-git-send-email-LinoSanfilippo@gmx.de
> >
> > This is probably due to the fact that compared to v3 you also rebased.
> > Still the diff is quite big.
>
> You are right, I made a rebase before I created the last patch, sorry for the confusion this caused.
> Anyway, thanks for the review(s)!
You did everything good enough. (To further improve, you could use
git-format-patch's --base option and mention a rebase in the series'
changelog; note this is quite high level critic.)
This was more me wondering the output is not easier to use. (And note I
also showed the wrong commandline, but that doesn't resolve the issue.
The right command is:
b4 diff 1607546905-20549-1-git-send-email-LinoSanfilippo@gmx.de
.)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Cc: linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org,
f.fainelli@gmail.com, sbranden@broadcom.com, sean@mess.org,
rjui@broadcom.com, linux-kernel@vger.kernel.org,
thierry.reding@gmail.com, bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org, lee.jones@linaro.org,
nsaenzjulienne@suse.de
Subject: Re: [PATCH v3] pwm: bcm2835: Support apply function for atomic configuration
Date: Fri, 11 Dec 2020 10:53:05 +0100 [thread overview]
Message-ID: <20201211095305.vsin3mkrytylqm47@pengutronix.de> (raw)
In-Reply-To: <trinity-8db15ca3-e42e-497d-8718-b4928fa76a3c-1607678915350@3c-app-gmx-bs43>
[-- Attachment #1.1: Type: text/plain, Size: 1692 bytes --]
On Fri, Dec 11, 2020 at 10:28:35AM +0100, Lino Sanfilippo wrote:
> Hi Uwe,
>
> > Gesendet: Donnerstag, 10. Dezember 2020 um 12:43 Uhr
> > Von: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
> > An: "Lino Sanfilippo" <LinoSanfilippo@gmx.de>
> > Cc: thierry.reding@gmail.com, lee.jones@linaro.org, nsaenzjulienne@suse.de, f.fainelli@gmail.com, rjui@broadcom.com, sean@mess.org, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, linux-pwm@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
> > Betreff: Re: [PATCH v3] pwm: bcm2835: Support apply function for atomic configuration
>
> >
> > Side note: I'm a bit surprised about the output of
> >
> > b4 diff 1607464905-16630-1-git-send-email-LinoSanfilippo@gmx.de
> >
> > This is probably due to the fact that compared to v3 you also rebased.
> > Still the diff is quite big.
>
> You are right, I made a rebase before I created the last patch, sorry for the confusion this caused.
> Anyway, thanks for the review(s)!
You did everything good enough. (To further improve, you could use
git-format-patch's --base option and mention a rebase in the series'
changelog; note this is quite high level critic.)
This was more me wondering the output is not easier to use. (And note I
also showed the wrong commandline, but that doesn't resolve the issue.
The right command is:
b4 diff 1607546905-20549-1-git-send-email-LinoSanfilippo@gmx.de
.)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-11 9:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 22:01 [PATCH v3] pwm: bcm2835: Support apply function for atomic configuration Lino Sanfilippo
2020-12-08 22:01 ` Lino Sanfilippo
2020-12-09 7:05 ` Uwe Kleine-König
2020-12-09 7:05 ` Uwe Kleine-König
2020-12-09 13:20 ` Aw: " Lino Sanfilippo
2020-12-09 13:20 ` Lino Sanfilippo
2020-12-10 11:43 ` Uwe Kleine-König
2020-12-10 11:43 ` Uwe Kleine-König
2020-12-11 9:28 ` Aw: " Lino Sanfilippo
2020-12-11 9:28 ` Lino Sanfilippo
2020-12-11 9:53 ` Uwe Kleine-König [this message]
2020-12-11 9:53 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201211095305.vsin3mkrytylqm47@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=LinoSanfilippo@gmx.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nsaenzjulienne@suse.de \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=sean@mess.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.