* [meta-oe][PATCH v3] sudo: split into smaller tools package
@ 2020-12-15 19:35 Sinan Kaya
2020-12-15 19:44 ` [OE-core] " Bruce Ashfield
0 siblings, 1 reply; 6+ messages in thread
From: Sinan Kaya @ 2020-12-15 19:35 UTC (permalink / raw)
To: openembedded-core; +Cc: Sinan Kaya
Allow to include whether we want sudo, visudo, sudoreplay
or cvtsudoers tools.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
meta/recipes-extended/sudo/sudo_1.9.3p1.bb | 24 +++++++++++++++++++++-
1 file changed, 23 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-extended/sudo/sudo_1.9.3p1.bb b/meta/recipes-extended/sudo/sudo_1.9.3p1.bb
index ba61a7f2472..0ea72caf790 100644
--- a/meta/recipes-extended/sudo/sudo_1.9.3p1.bb
+++ b/meta/recipes-extended/sudo/sudo_1.9.3p1.bb
@@ -44,6 +44,28 @@ do_install_append () {
rmdir -p --ignore-fail-on-non-empty ${D}/run/sudo
}
-FILES_${PN} += "${nonarch_libdir}/tmpfiles.d"
FILES_${PN}-dev += "${libdir}/${BPN}/lib*${SOLIBSDEV} ${libdir}/${BPN}/*.la \
${libdir}/lib*${SOLIBSDEV} ${libdir}/*.la"
+
+PACKAGES += "${PN}-cvtsudoers"
+PACKAGES += "${PN}-sudoreplay"
+PACKAGES += "${PN}-visudo"
+PACKAGES += "${PN}-sudo"
+PACKAGES += "${PN}-lib"
+
+RDEPENDS_${PN}-cvtsudoers = "${PN}-lib"
+RDEPENDS_${PN}-sudo = "${PN}-lib"
+RDEPENDS_${PN}-sudoreplay = "${PN}-lib"
+RDEPENDS_${PN}-visudo = "${PN}-lib"
+
+PROVIDES += "${PACKAGES}"
+RRECOMMENDS_${PN} += "${PACKAGES}"
+
+ALLOW_EMPTY_${PN} = "1"
+
+FILES_${PN} = ""
+FILES_${PN}-cvtsudoers = "${bindir}/cvtsudoers"
+FILES_${PN}-sudoreplay = "${bindir}/sudoreplay"
+FILES_${PN}-sudo = "${bindir}/sudo ${bindir}/sudoedit"
+FILES_${PN}-visudo = "${sbindir}/visudo"
+FILES_${PN}-lib = "${localstatedir} ${libexecdir} ${sysconfdir} ${libdir}"
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [OE-core] [meta-oe][PATCH v3] sudo: split into smaller tools package
2020-12-15 19:35 [meta-oe][PATCH v3] sudo: split into smaller tools package Sinan Kaya
@ 2020-12-15 19:44 ` Bruce Ashfield
2020-12-15 19:54 ` Sinan Kaya
0 siblings, 1 reply; 6+ messages in thread
From: Bruce Ashfield @ 2020-12-15 19:44 UTC (permalink / raw)
To: Sinan Kaya; +Cc: Patches and discussions about the oe-core layer
On Tue, Dec 15, 2020 at 2:35 PM Sinan Kaya <okaya@kernel.org> wrote:
>
> Allow to include whether we want sudo, visudo, sudoreplay
> or cvtsudoers tools.
>
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> ---
> meta/recipes-extended/sudo/sudo_1.9.3p1.bb | 24 +++++++++++++++++++++-
> 1 file changed, 23 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-extended/sudo/sudo_1.9.3p1.bb b/meta/recipes-extended/sudo/sudo_1.9.3p1.bb
> index ba61a7f2472..0ea72caf790 100644
> --- a/meta/recipes-extended/sudo/sudo_1.9.3p1.bb
> +++ b/meta/recipes-extended/sudo/sudo_1.9.3p1.bb
> @@ -44,6 +44,28 @@ do_install_append () {
> rmdir -p --ignore-fail-on-non-empty ${D}/run/sudo
> }
>
> -FILES_${PN} += "${nonarch_libdir}/tmpfiles.d"
I don't see this maintained in the split of changes below, why was it dropped ?
> FILES_${PN}-dev += "${libdir}/${BPN}/lib*${SOLIBSDEV} ${libdir}/${BPN}/*.la \
> ${libdir}/lib*${SOLIBSDEV} ${libdir}/*.la"
> +
> +PACKAGES += "${PN}-cvtsudoers"
> +PACKAGES += "${PN}-sudoreplay"
> +PACKAGES += "${PN}-visudo"
> +PACKAGES += "${PN}-sudo"
> +PACKAGES += "${PN}-lib"
> +
> +RDEPENDS_${PN}-cvtsudoers = "${PN}-lib"
> +RDEPENDS_${PN}-sudo = "${PN}-lib"
> +RDEPENDS_${PN}-sudoreplay = "${PN}-lib"
> +RDEPENDS_${PN}-visudo = "${PN}-lib"
> +
> +PROVIDES += "${PACKAGES}"
> +RRECOMMENDS_${PN} += "${PACKAGES}"
This isn't a direct replacement of the existing packaging. If we are
going to get a series of patches that keep splitting on binaries, they
shouldn't be like this.
For an image or configuration that turns off rrecommends (which is the
policy for a distro that I have), this is not backwards compatible and
we are going to get all sorts of runtime issues .. and then be forced
to update packages lists with this explosion of new splits.
If we do splits like this, something stronger than rrcommends is
needed, or they simply belong in a layer besides core.
Bruce
> +
> +ALLOW_EMPTY_${PN} = "1"
> +
> +FILES_${PN} = ""
> +FILES_${PN}-cvtsudoers = "${bindir}/cvtsudoers"
> +FILES_${PN}-sudoreplay = "${bindir}/sudoreplay"
> +FILES_${PN}-sudo = "${bindir}/sudo ${bindir}/sudoedit"
> +FILES_${PN}-visudo = "${sbindir}/visudo"
> +FILES_${PN}-lib = "${localstatedir} ${libexecdir} ${sysconfdir} ${libdir}"
> --
> 2.17.1
>
>
>
>
--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [OE-core] [meta-oe][PATCH v3] sudo: split into smaller tools package
2020-12-15 19:44 ` [OE-core] " Bruce Ashfield
@ 2020-12-15 19:54 ` Sinan Kaya
2020-12-15 19:57 ` Bruce Ashfield
0 siblings, 1 reply; 6+ messages in thread
From: Sinan Kaya @ 2020-12-15 19:54 UTC (permalink / raw)
To: Bruce Ashfield; +Cc: Patches and discussions about the oe-core layer
On 12/15/2020 2:44 PM, Bruce Ashfield wrote:
>> -FILES_${PN} += "${nonarch_libdir}/tmpfiles.d"
> I don't see this maintained in the split of changes below, why was it dropped ?
>
I'll fix that. I thought ${libdir} would cover it but apparently it does
not.
>> FILES_${PN}-dev += "${libdir}/${BPN}/lib*${SOLIBSDEV} ${libdir}/${BPN}/*.la \
>> ${libdir}/lib*${SOLIBSDEV} ${libdir}/*.la"
>> +
>> +PACKAGES += "${PN}-cvtsudoers"
>> +PACKAGES += "${PN}-sudoreplay"
>> +PACKAGES += "${PN}-visudo"
>> +PACKAGES += "${PN}-sudo"
>> +PACKAGES += "${PN}-lib"
>> +
>> +RDEPENDS_${PN}-cvtsudoers = "${PN}-lib"
>> +RDEPENDS_${PN}-sudo = "${PN}-lib"
>> +RDEPENDS_${PN}-sudoreplay = "${PN}-lib"
>> +RDEPENDS_${PN}-visudo = "${PN}-lib"
>> +
>> +PROVIDES += "${PACKAGES}"
>> +RRECOMMENDS_${PN} += "${PACKAGES}"
> This isn't a direct replacement of the existing packaging. If we are
> going to get a series of patches that keep splitting on binaries, they
> shouldn't be like this.
>> For an image or configuration that turns off rrecommends (which is the
> policy for a distro that I have), this is not backwards compatible and
> we are going to get all sorts of runtime issues .. and then be forced
> to update packages lists with this explosion of new splits.
Interesting, I didn't know that RRECOMMENDS can be turned off.
I was hoping to do a non-invasive change for existing users.
>
> If we do splits like this, something stronger than rrcommends is
> needed, or they simply belong in a layer besides core.
Would RDEPENDS work?
Sinan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [OE-core] [meta-oe][PATCH v3] sudo: split into smaller tools package
2020-12-15 19:54 ` Sinan Kaya
@ 2020-12-15 19:57 ` Bruce Ashfield
2020-12-15 20:09 ` Sinan Kaya
0 siblings, 1 reply; 6+ messages in thread
From: Bruce Ashfield @ 2020-12-15 19:57 UTC (permalink / raw)
To: Sinan Kaya; +Cc: Patches and discussions about the oe-core layer
On Tue, Dec 15, 2020 at 2:54 PM Sinan Kaya <okaya@kernel.org> wrote:
>
> On 12/15/2020 2:44 PM, Bruce Ashfield wrote:
> >> -FILES_${PN} += "${nonarch_libdir}/tmpfiles.d"
> > I don't see this maintained in the split of changes below, why was it dropped ?
> >
>
> I'll fix that. I thought ${libdir} would cover it but apparently it does
> not.
>
> >> FILES_${PN}-dev += "${libdir}/${BPN}/lib*${SOLIBSDEV} ${libdir}/${BPN}/*.la \
> >> ${libdir}/lib*${SOLIBSDEV} ${libdir}/*.la"
> >> +
> >> +PACKAGES += "${PN}-cvtsudoers"
> >> +PACKAGES += "${PN}-sudoreplay"
> >> +PACKAGES += "${PN}-visudo"
> >> +PACKAGES += "${PN}-sudo"
> >> +PACKAGES += "${PN}-lib"
> >> +
> >> +RDEPENDS_${PN}-cvtsudoers = "${PN}-lib"
> >> +RDEPENDS_${PN}-sudo = "${PN}-lib"
> >> +RDEPENDS_${PN}-sudoreplay = "${PN}-lib"
> >> +RDEPENDS_${PN}-visudo = "${PN}-lib"
> >> +
> >> +PROVIDES += "${PACKAGES}"
> >> +RRECOMMENDS_${PN} += "${PACKAGES}"
>
> > This isn't a direct replacement of the existing packaging. If we are
> > going to get a series of patches that keep splitting on binaries, they
> > shouldn't be like this.
> >> For an image or configuration that turns off rrecommends (which is the
> > policy for a distro that I have), this is not backwards compatible and
> > we are going to get all sorts of runtime issues .. and then be forced
> > to update packages lists with this explosion of new splits.
>
> Interesting, I didn't know that RRECOMMENDS can be turned off.
> I was hoping to do a non-invasive change for existing users.
A good goal!
It's this variable:
https://www.yoctoproject.org/docs/current/mega-manual/mega-manual.html#var-NO_RECOMMENDATIONS
(but you probably already searched and found it).
>
> >
> > If we do splits like this, something stronger than rrcommends is
> > needed, or they simply belong in a layer besides core.
>
> Would RDEPENDS work?
It would pull all the subpackages in yes, and can't be turned off like
the recommends.
I can't think of where it would break, but maybe others can :D
Bruce
>
> Sinan
--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [OE-core] [meta-oe][PATCH v3] sudo: split into smaller tools package
2020-12-15 19:57 ` Bruce Ashfield
@ 2020-12-15 20:09 ` Sinan Kaya
2020-12-15 21:07 ` Bruce Ashfield
0 siblings, 1 reply; 6+ messages in thread
From: Sinan Kaya @ 2020-12-15 20:09 UTC (permalink / raw)
To: Bruce Ashfield; +Cc: Patches and discussions about the oe-core layer
On 12/15/2020 2:57 PM, Bruce Ashfield wrote:
>> Interesting, I didn't know that RRECOMMENDS can be turned off.
>> I was hoping to do a non-invasive change for existing users.
> A good goal!
>
> It's this variable:
> https://www.yoctoproject.org/docs/current/mega-manual/mega-manual.html#var-NO_RECOMMENDATIONS
Would you be interested in setting it as default for the tiny distro
with a patch?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [OE-core] [meta-oe][PATCH v3] sudo: split into smaller tools package
2020-12-15 20:09 ` Sinan Kaya
@ 2020-12-15 21:07 ` Bruce Ashfield
0 siblings, 0 replies; 6+ messages in thread
From: Bruce Ashfield @ 2020-12-15 21:07 UTC (permalink / raw)
To: Sinan Kaya; +Cc: Patches and discussions about the oe-core layer
On Tue, Dec 15, 2020 at 3:09 PM Sinan Kaya <okaya@kernel.org> wrote:
>
> On 12/15/2020 2:57 PM, Bruce Ashfield wrote:
> >> Interesting, I didn't know that RRECOMMENDS can be turned off.
> >> I was hoping to do a non-invasive change for existing users.
> > A good goal!
> >
> > It's this variable:
> > https://www.yoctoproject.org/docs/current/mega-manual/mega-manual.html#var-NO_RECOMMENDATIONS
>
> Would you be interested in setting it as default for the tiny distro
> with a patch?
I'm not the maintainer of that reference distro, but if something
really wants to control what is install and not have optional things
creep in, turning off the recommends is a good idea.
It would have to be run through some tests of course, because
something may be relying on those packages.
Bruce
--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-12-15 21:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-15 19:35 [meta-oe][PATCH v3] sudo: split into smaller tools package Sinan Kaya
2020-12-15 19:44 ` [OE-core] " Bruce Ashfield
2020-12-15 19:54 ` Sinan Kaya
2020-12-15 19:57 ` Bruce Ashfield
2020-12-15 20:09 ` Sinan Kaya
2020-12-15 21:07 ` Bruce Ashfield
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.